@schukai/monster 4.46.5 → 4.46.6

package/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 
 
+## [4.46.6] - 2025-11-22
+
+### Bug Fixes
+
+- some NaN Issues
+
+
+
 ## [4.46.5] - 2025-11-22
 
 ### Bug Fixes

package/package.json

@@ -1 +1 @@
-{"author":"schukai GmbH","dependencies":{"@floating-ui/dom":"^1.7.4","@popperjs/core":"^2.11.8"},"description":"Monster is a simple library for creating fast, robust and lightweight websites.","homepage":"https://monsterjs.org/","keywords":["framework","web","dom","css","sass","mobile-first","app","front-end","templates","schukai","core","shopcloud","alvine","monster","buildmap","stack","observer","observable","uuid","node","nodelist","css-in-js","logger","log","theme"],"license":"AGPL 3.0","main":"source/monster.mjs","module":"source/monster.mjs","name":"@schukai/monster","repository":{"type":"git","url":"https://gitlab.schukai.com/oss/libraries/javascript/monster.git"},"type":"module","version":"4.46.5"}
+{"author":"schukai GmbH","dependencies":{"@floating-ui/dom":"^1.7.4","@popperjs/core":"^2.11.8"},"description":"Monster is a simple library for creating fast, robust and lightweight websites.","homepage":"https://monsterjs.org/","keywords":["framework","web","dom","css","sass","mobile-first","app","front-end","templates","schukai","core","shopcloud","alvine","monster","buildmap","stack","observer","observable","uuid","node","nodelist","css-in-js","logger","log","theme"],"license":"AGPL 3.0","main":"source/monster.mjs","module":"source/monster.mjs","name":"@schukai/monster","repository":{"type":"git","url":"https://gitlab.schukai.com/oss/libraries/javascript/monster.git"},"type":"module","version":"4.46.6"}

package/source/dom/updater.mjs

@@ -72,6 +72,12 @@ const pendingDiffsSymbol = Symbol("pendingDiffs");
  */
 const processingSymbol = Symbol("processing");
 
+/**
+ * @private
+ * Performance optimization: static Set for boolean checks
+ */
+const TRUE_VALUES = new Set(["true", "1", "on"]);
+
 /**
  * The updater class connects an object with the DOM. In this way, structures and contents in the DOM can be
  * programmatically adapted via attributes.
@@ -194,7 +200,7 @@ class Updater extends Base {
    *
    * ```js
    * updater.run().then(() => {
-   *   updater.enableEventProcessing();
+   * updater.enableEventProcessing();
    * });
    * ```
    *
@@ -243,7 +249,7 @@ class Updater extends Base {
    *
    * ```js
    * updater.run().then(() => {
-   *   updater.enableEventProcessing();
+   * updater.enableEventProcessing();
    * });
    * ```
    *
@@ -308,8 +314,9 @@ function getCheckStateCallback() {
   return function (current) {
     // this is a reference to the current object (therefore no array function here)
     if (this instanceof HTMLInputElement) {
-      if (["radio", "checkbox"].indexOf(this.type) !== -1) {
-        return `${this.value}` === `${current}` ? "true" : undefined;
+      if (["radio", "checkbox"].includes(this.type)) {
+        if (current == null) return undefined;
+        return String(this.value) === String(current) ? "true" : undefined;
       }
     } else if (this instanceof HTMLOptionElement) {
       if (isArray(current) && current.indexOf(this.value) !== -1) {
@@ -447,18 +454,21 @@ function retrieveAndSetValue(element) {
     case "int":
     case "float":
     case "integer":
-      value = Number(value);
-      if (isNaN(value)) {
-        value = 0;
+      const num = Number(value);
+      if (value === "" || value === null || value === undefined) {
+        value = undefined;
+      } else if (Number.isNaN(num)) {
+        value = undefined;
+      } else {
+        value = num;
       }
       break;
     case "boolean":
     case "bool":
     case "checkbox":
-      value =
-        value === "true" || value === "1" || value === "on" || value === true;
+      // Use static set (Performance fix)
+      value = TRUE_VALUES.has(String(value).toLowerCase()) || value === true;
       break;
-
     case "string[]":
     case "[]string":
       if (isString(value)) {
@@ -509,11 +519,14 @@ function retrieveAndSetValue(element) {
     case "object":
     case "json":
       if (isString(value)) {
-        value = JSON.parse(value);
+        try {
+          value = JSON.parse(value);
+        } catch (e) {
+          throw new Error("unsupported value for object");
+        }
       } else {
         throw new Error("unsupported value for object");
       }
-
       break;
     default:
       break;
@@ -535,21 +548,11 @@ function retrieveAndSetValue(element) {
  * @private
  */
 function parseIntArray(val) {
-  if (isString(val)) {
-    return val.trim() === ""
-      ? []
-      : val
-          .split(",")
-          .map((v) => parseInt(v, 10))
-          .filter((v) => !isNaN(v));
-  } else if (isInteger(val)) {
-    return [val];
-  } else if (val === undefined || val === null) {
-    return [];
-  } else if (isArray(val)) {
-    return val.map((v) => parseInt(v, 10)).filter((v) => !isNaN(v));
-  }
-  throw new Error("unsupported value for int array");
+  if (val === undefined || val === null) return [];
+
+  const list = isArray(val) ? val : String(val).split(",");
+
+  return list.map((v) => parseInt(v, 10)).filter((v) => !Number.isNaN(v));
 }
 
 /**
@@ -830,18 +833,11 @@ function runUpdateContent(container, parts, subject) {
 
     // Unfortunately, static data is always changed as well, since it is not possible to react to changes here.
     const query = `[${ATTRIBUTE_UPDATER_REPLACE}^="path:${current}"], [${ATTRIBUTE_UPDATER_REPLACE}^="static:"], [${ATTRIBUTE_UPDATER_REPLACE}^="i18n:"]`;
-    const e = container.querySelectorAll(`${query}`);
-
-    const iterator = new Set([...e]);
 
-    if (container.matches(query)) {
-      iterator.add(container);
-    }
+    // Performance optimization: avoid new Set([...NodeList])
+    const elements = container.querySelectorAll(`${query}`);
 
-    /**
-     * @type {HTMLElement}
-     */
-    for (const [element] of iterator.entries()) {
+    const process = (element) => {
       if (mem.has(element)) return;
       mem.add(element);
 
@@ -874,6 +870,16 @@ function runUpdateContent(container, parts, subject) {
       } else {
         element.innerHTML = value;
       }
+    };
+
+    // Iterate NodeList directly
+    for (const element of elements) {
+      process(element);
+    }
+
+    // Check container
+    if (container.matches(query)) {
+      process(container);
     }
   }
 }
@@ -908,27 +914,18 @@ function runUpdateAttributes(container, parts, subject) {
     const current = parts.join(".");
     parts.pop();
 
-    let iterator = new Set();
-
     const query = `[${ATTRIBUTE_UPDATER_SELECT_THIS}][${ATTRIBUTE_UPDATER_ATTRIBUTES}], [${ATTRIBUTE_UPDATER_ATTRIBUTES}*="path:${current}"], [${ATTRIBUTE_UPDATER_ATTRIBUTES}^="static:"], [${ATTRIBUTE_UPDATER_ATTRIBUTES}^="i18n:"]`;
 
-    const e = container.querySelectorAll(query);
-
-    if (e.length > 0) {
-      iterator = new Set([...e]);
-    }
-
-    if (container.matches(query)) {
-      iterator.add(container);
-    }
+    // Performance optimization: avoid new Set([...NodeList])
+    const elements = container.querySelectorAll(query);
 
-    for (const [element] of iterator.entries()) {
+    const process = (element) => {
       if (mem.has(element)) return;
       mem.add(element);
 
       // this case occurs when the ATTRIBUTE_UPDATER_SELECT_THIS attribute is set
       if (!element.hasAttribute(ATTRIBUTE_UPDATER_ATTRIBUTES)) {
-        continue;
+        return;
       }
 
       const attributes = element.getAttribute(ATTRIBUTE_UPDATER_ATTRIBUTES);
@@ -967,6 +964,16 @@ function runUpdateAttributes(container, parts, subject) {
         }
         handleInputControlAttributeUpdate.call(this, element, name, value);
       }
+    };
+
+    // Iterate NodeList directly
+    for (const element of elements) {
+      process(element);
+    }
+
+    // Check container
+    if (container.matches(query)) {
+      process(container);
     }
   }
 }
@@ -979,52 +986,59 @@ function runUpdateAttributes(container, parts, subject) {
  * @return {void}
  * @this Updater
  */
-
 function handleInputControlAttributeUpdate(element, name, value) {
+  // Prevent NaN warnings by normalizing invalid numbers to undefined
+  if (typeof value === "number" && isNaN(value)) {
+    value = undefined;
+  }
+
   if (element instanceof HTMLSelectElement) {
     switch (element.type) {
       case "select-multiple":
-        for (const [index, opt] of Object.entries(element.options)) {
-          opt.selected = value.indexOf(opt.value) !== -1;
+        // Ensure value is an array before calling indexOf to avoid errors
+        if (Array.isArray(value) || typeof value === "string") {
+          for (const [index, opt] of Object.entries(element.options)) {
+            opt.selected = value.indexOf(opt.value) !== -1;
+          }
         }
-
         break;
       case "select-one":
         // Only one value may be selected
-
         for (const [index, opt] of Object.entries(element.options)) {
-          if (opt.value === value) {
+          if (opt.value == value) {
+            // Loose equality to match string numbers
             element.selectedIndex = index;
             break;
           }
         }
-
         break;
     }
   } else if (element instanceof HTMLInputElement) {
     switch (element.type) {
       case "radio":
         if (name === "checked") {
-          element.checked = value !== undefined;
+          element.checked = value !== undefined && value !== null;
         }
         break;
 
       case "checkbox":
         if (name === "checked") {
-          element.checked = value !== undefined;
+          element.checked = value !== undefined && value !== null;
         }
         break;
 
       case "text":
       default:
         if (name === "value") {
-          element.value = value === undefined ? "" : value;
+          // Check for undefined, null, or NaN
+          element.value = value === undefined || value === null ? "" : value;
         }
         break;
     }
   } else if (element instanceof HTMLTextAreaElement) {
     if (name === "value") {
-      element.value = value === undefined ? "" : value;
+      // Check for undefined, null, or NaN
+      element.value = value === undefined || value === null ? "" : value;
     }
   }
 }