@schukai/monster 4.42.1 → 4.42.2

package/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 
 
+## [4.42.2] - 2025-09-29
+
+### Bug Fixes
+
+- **viewer:** remove revoke from click handler
+
+
+
 ## [4.42.1] - 2025-09-28
 
 ### Bug Fixes

package/package.json

@@ -1 +1 @@
-{"author":"schukai GmbH","dependencies":{"@floating-ui/dom":"^1.7.4","@popperjs/core":"^2.11.8"},"description":"Monster is a simple library for creating fast, robust and lightweight websites.","homepage":"https://monsterjs.org/","keywords":["framework","web","dom","css","sass","mobile-first","app","front-end","templates","schukai","core","shopcloud","alvine","monster","buildmap","stack","observer","observable","uuid","node","nodelist","css-in-js","logger","log","theme"],"license":"AGPL 3.0","main":"source/monster.mjs","module":"source/monster.mjs","name":"@schukai/monster","repository":{"type":"git","url":"https://gitlab.schukai.com/oss/libraries/javascript/monster.git"},"type":"module","version":"4.42.1"}
+{"author":"schukai GmbH","dependencies":{"@floating-ui/dom":"^1.7.4","@popperjs/core":"^2.11.8"},"description":"Monster is a simple library for creating fast, robust and lightweight websites.","homepage":"https://monsterjs.org/","keywords":["framework","web","dom","css","sass","mobile-first","app","front-end","templates","schukai","core","shopcloud","alvine","monster","buildmap","stack","observer","observable","uuid","node","nodelist","css-in-js","logger","log","theme"],"license":"AGPL 3.0","main":"source/monster.mjs","module":"source/monster.mjs","name":"@schukai/monster","repository":{"type":"git","url":"https://gitlab.schukai.com/oss/libraries/javascript/monster.git"},"type":"module","version":"4.42.2"}

package/source/components/content/viewer.mjs

@@ -483,7 +483,6 @@ class Viewer extends CustomElement {
     let revoke = null;
     let suggestedName = filename;
 
-    // 1) Datenquelle normalisieren → href + optional revoke
     if (data instanceof File) {
       href = URL.createObjectURL(data);
       suggestedName = data.name || filename;
@@ -496,18 +495,14 @@ class Viewer extends CustomElement {
       (isString(data) && /^(data:|blob:|https?:)/.test(data))
     ) {
       href = data.toString();
-      // Dateiname ggf. aus URL ableiten
       try {
         const u = new URL(href, location.href);
         const last = u.pathname.split("/").pop();
         if ((!filename || filename === "download") && last) {
           suggestedName = decodeURIComponent(last);
         }
-      } catch {
-        /* ignore */
-      }
+      } catch {}
     } else if (isString(data)) {
-      // Reiner Inhalt → als Datei verpacken
       const blob = new Blob([data], { type: "application/octet-stream" });
       href = URL.createObjectURL(blob);
       revoke = () => URL.revokeObjectURL(href);
@@ -517,14 +512,12 @@ class Viewer extends CustomElement {
       throw new Error(msg);
     }
 
-    // 2) Button rendern
     const button =
       `<monster-button data-monster-role="download">` +
       this.getOption("labels.download") +
       `</monster-button>`;
     this.setOption("content", button);
 
-    // 3) Alten Handler entfernen & ggf. alte Object-URL freigeben
     if (this[downloadHandlerSymbol]) {
       this.removeEventListener("click", this[downloadHandlerSymbol]);
     }
@@ -534,7 +527,6 @@ class Viewer extends CustomElement {
       } catch {}
     }
 
-    // 4) Neuen Handler setzen
     this[downloadHandlerSymbol] = (event) => {
       const el = findTargetElementFromEvent(
         event,
@@ -543,23 +535,13 @@ class Viewer extends CustomElement {
       );
       if (el instanceof Button) {
         const a = document.createElement("a");
-
-        // Cross-Origin Hinweis:
-        // Der download-Attr kann bei fremder Origin ignoriert werden. In dem Fall
-        // öffnet der Browser die URL. Wenn du *erzwingen* willst, dann vorher
-        // per fetch → blob holen (sofern CORS erlaubt) und daraus eine Object-URL bauen.
-
         a.href = href;
         a.download = suggestedName;
         a.rel = "noopener";
         a.style.display = "none";
-
         document.body.appendChild(a);
         a.click();
         document.body.removeChild(a);
-
-        // Object-URL nach dem Klick freigeben
-        if (revoke) setTimeout(revoke, 0);
       }
     };
     this[downloadRevokeSymbol] = revoke;