@schukai/monster 4.153.0 → 4.154.0

package/source/dom/updater.mjs

@@ -651,7 +651,7 @@ function retrieveAndSetValue(element) {
 
 				let options = element?.selectedOptions;
 				if (options === undefined)
-					options = element.querySelectorAll(":scope option:checked");
+					options = element.querySelectorAll("option:checked");
 				value = Array.from(options).map(({ value }) => value);
 
 				break;
@@ -803,17 +803,34 @@ function parseIntArray(val) {
  * @private
  */
 function retrieveFromBindings() {
-	if (this[internalSymbol].element.matches(`[${ATTRIBUTE_UPDATER_BIND}]`)) {
+	if (
+		this[internalSymbol].element.matches(`[${ATTRIBUTE_UPDATER_BIND}]`) &&
+		!isUncheckedRadio(this[internalSymbol].element)
+	) {
 		retrieveAndSetValue.call(this, this[internalSymbol].element);
 	}
 
 	for (const [, element] of this[internalSymbol].element
 		.querySelectorAll(`[${ATTRIBUTE_UPDATER_BIND}]`)
 		.entries()) {
+		if (isUncheckedRadio(element)) continue;
 		retrieveAndSetValue.call(this, element);
 	}
 }
 
+/**
+ * @param {HTMLElement} element
+ * @return {boolean}
+ * @private
+ */
+function isUncheckedRadio(element) {
+	return (
+		element instanceof HTMLInputElement &&
+		element.type === "radio" &&
+		element.checked === false
+	);
+}
+
 /**
  * @private
  * @license AGPLv3
@@ -830,8 +847,12 @@ function removeElement(_change, renderContext) {
 	}
 
 	let changed = false;
+	// No :scope prefix: querySelectorAll() on an element already returns only its
+	// descendants, so the prefix carries no meaning here, while :scope does not
+	// resolve for shadow root content under jsdom, which made this a silent no-op
+	// for every component that renders into a shadow root.
 	for (const [, element] of this[internalSymbol].element
-		.querySelectorAll(`:scope [${ATTRIBUTE_UPDATER_REMOVE}]`)
+		.querySelectorAll(`[${ATTRIBUTE_UPDATER_REMOVE}]`)
 		.entries()) {
 		teardownManagedSubtree(element);
 		element.parentNode.removeChild(element);
@@ -1201,7 +1222,10 @@ function getSlots(container, cache) {
 		return cache.get(container);
 	}
 
-	const slots = container.querySelectorAll("slot");
+	const slots = Array.from(container.querySelectorAll("slot"));
+	if (container.localName === "slot") {
+		slots.unshift(container);
+	}
 	cache.set(container, slots);
 	return slots;
 }
@@ -1565,6 +1589,9 @@ function replaceKeyedPatchedChildren(
 			const nextNode = preparePatchedNode(reused, renderedValue);
 			nextNode[patchNodeKeySymbol] = normalizedKey;
 			if (nextNode !== reused && reused.parentNode === element) {
+				if (reused instanceof HTMLElement) {
+					teardownManagedSubtree(reused);
+				}
 				element.replaceChild(nextNode, reused);
 			}
 			nextNodes.push(nextNode);
@@ -1591,15 +1618,11 @@ function replaceKeyedPatchedChildren(
 		}
 	}
 
-	for (const node of nextNodes) {
-		if (node.parentNode !== element) {
-			element.appendChild(node);
-			continue;
-		}
-
-		if (element.lastChild !== node) {
-			element.appendChild(node);
-		}
+	for (let index = 0; index < nextNodes.length; index++) {
+		const node = nextNodes[index];
+		const current = element.childNodes[index] ?? null;
+		if (current === node) continue;
+		element.insertBefore(node, current);
 	}
 }
 
@@ -1851,8 +1874,7 @@ function runUpdateAttributes(
 			if (
 				!element.hasAttribute(ATTRIBUTE_UPDATER_SELECT_THIS) &&
 				!attributes.includes(`path:${current}`) &&
-				!attributes.startsWith("static:") &&
-				!attributes.startsWith("i18n:")
+				!hasUnconditionalBinding(attributes)
 			) {
 				continue;
 			}
@@ -1933,8 +1955,7 @@ function runUpdateProperties(
 			if (
 				!element.hasAttribute(ATTRIBUTE_UPDATER_SELECT_THIS) &&
 				!properties.includes(`path:${current}`) &&
-				!properties.startsWith("static:") &&
-				!properties.startsWith("i18n:")
+				!hasUnconditionalBinding(properties)
 			) {
 				continue;
 			}
@@ -1981,6 +2002,9 @@ function runUpdateProperties(
 
 function handleInputControlAttributeUpdate(element, name, value) {
 	if (element instanceof HTMLSelectElement) {
+		if (name !== "value") {
+			return;
+		}
 		switch (element.type) {
 			case "select-multiple":
 				const selectedValues = isArray(value)
@@ -2054,6 +2078,22 @@ function handleInputControlAttributeUpdate(element, name, value) {
 	}
 }
 
+/**
+ * Check whether an attribute/property definition contains a command that is
+ * independent from the changed subject path.
+ * @param {string} definitions
+ * @return {boolean}
+ * @private
+ */
+function hasUnconditionalBinding(definitions) {
+	return definitions.split(",").some((definition) => {
+		const separator = definition.indexOf(" ");
+		if (separator < 0) return false;
+		const command = trimSpaces(definition.substring(separator + 1));
+		return command.startsWith("static:") || command.startsWith("i18n:");
+	});
+}
+
 /**
  * @private
  * @param {HTMLElement|*} element

package/source/types/base.mjs

@@ -115,21 +115,22 @@ function checkInstanceSymbol(obj) {
 	}
 
 	if (proto.hasOwnProperty(instanceSymbol) !== true) {
-		return checkInstanceSymbol.apply(this, [obj.__proto__]);
+		return checkInstanceSymbol.apply(this, [Object.getPrototypeOf(obj)]);
 	}
 
 	const symbol = proto[instanceSymbol];
 	if (symbol === undefined) {
-		if (obj.__proto__) {
-			return checkInstanceSymbol(obj.__proto__);
-		} else {
-			return false;
+		const parent = Object.getPrototypeOf(obj);
+		if (parent) {
+			return checkInstanceSymbol.apply(this, [parent]);
 		}
+
+		return false;
 	}
 
 	if (symbol === this[instanceSymbol]) {
 		return true;
 	}
 
-	return checkInstanceSymbol.apply(this, [obj.__proto__]);
+	return checkInstanceSymbol.apply(this, [Object.getPrototypeOf(obj)]);
 }

package/source/types/basewithoptions.mjs

@@ -80,13 +80,6 @@ class BaseWithOptions extends Base {
 	 * @since 1.10.0
 	 */
 	getOption(path, defaultValue) {
-		let value;
-
-		try {
-			value = new Pathfinder(this[internalSymbol]).getVia(path);
-		} catch (e) {}
-
-		if (value === undefined) return defaultValue;
-		return value;
+		return new Pathfinder(this[internalSymbol]).getVia(path, defaultValue);
 	}
 }

package/source/types/internal.mjs

@@ -126,16 +126,10 @@ function equipWithInternal() {
 	 * @return {*}
 	 */
 	this["getInternal"] = (path, defaultValue) => {
-		let value;
-
-		try {
-			value = new Pathfinder(this[internalSymbol].getRealSubject()).getVia(
-				path,
-			);
-		} catch (e) {}
-
-		if (value === undefined) return defaultValue;
-		return value;
+		return new Pathfinder(this[internalSymbol].getRealSubject()).getVia(
+			path,
+			defaultValue,
+		);
 	};
 }
 

package/source/types/node.mjs

@@ -199,8 +199,6 @@ class Node extends Base {
  * @return {setChildLevelAndParent}
  */
 function setChildLevelAndParent(node, operand, visitedNodes) {
-	const self = this;
-
 	if (visitedNodes.has(node)) {
 		throw new Error(
 			"the node has already been visited and cannot be traversed again",
@@ -217,7 +215,7 @@ function setChildLevelAndParent(node, operand, visitedNodes) {
 		child[treeStructureSymbol].parent = node;
 		child[treeStructureSymbol].level =
 			node[treeStructureSymbol].level + operand;
-		setChildLevelAndParent.call(self, child, operand, visitedNodes);
+		setChildLevelAndParent.call(node, child, operand, visitedNodes);
 	});
 	return this;
 }

package/source/types/observerlist.mjs

@@ -55,9 +55,9 @@ class ObserverList extends Base {
 	detach(observer) {
 		validateInstance(observer, Observer);
 
-		var i = 0;
-		var l = this.observers.length;
-		for (; i < l; i++) {
+		// Iterate backwards: splicing while moving forward skips the entry that
+		// takes the freed slot, which left adjacent duplicates attached.
+		for (let i = this.observers.length - 1; i >= 0; i--) {
 			if (this.observers[i] === observer) {
 				this.observers.splice(i, 1);
 			}
@@ -74,14 +74,8 @@ class ObserverList extends Base {
 	 */
 	contains(observer) {
 		validateInstance(observer, Observer);
-		var i = 0;
-		var l = this.observers.length;
-		for (; i < l; i++) {
-			if (this.observers[i] === observer) {
-				return true;
-			}
-		}
-		return false;
+
+		return this.observers.includes(observer);
 	}
 
 	/**
@@ -90,14 +84,12 @@ class ObserverList extends Base {
 	 * @return {Promise}
 	 */
 	notify(subject) {
-		const pomises = [];
+		const promises = [];
 
-		let i = 0;
-		const l = this.observers.length;
-		for (; i < l; i++) {
-			pomises.push(this.observers[i].update(subject));
+		for (const observer of this.observers) {
+			promises.push(observer.update(subject));
 		}
 
-		return Promise.all(pomises);
+		return Promise.all(promises);
 	}
 }

package/source/types/proxyobserver.mjs

@@ -156,6 +156,15 @@ function getHandler() {
 			}
 
 			const value = Reflect.get(target, key, receiver);
+			const descriptor = Reflect.getOwnPropertyDescriptor(target, key);
+			if (
+				descriptor &&
+				descriptor.configurable === false &&
+				"value" in descriptor &&
+				descriptor.writable === false
+			) {
+				return value;
+			}
 
 			if (typeof key === "symbol") {
 				return value;
@@ -209,7 +218,7 @@ function getHandler() {
 				current = proxy.proxyMap.get(current);
 			}
 
-			if (current === value) {
+			if (isSameValue(current, value)) {
 				return true;
 			}
 
@@ -223,7 +232,7 @@ function getHandler() {
 				if (proxy.proxyMap.has(next)) {
 					next = proxy.proxyMap.get(next);
 				}
-				if (next !== current) {
+				if (!isSameValue(next, current)) {
 					proxy.observers.notify(proxy);
 				}
 			}
@@ -233,16 +242,12 @@ function getHandler() {
 
 		// https://262.ecma-international.org/9.0/#sec-proxy-object-internal-methods-and-internal-slots-delete-p
 		deleteProperty: function (target, key) {
-			if (key in target) {
-				delete target[key];
-
-				if (typeof key !== "symbol") {
-					proxy.observers.notify(proxy);
-				}
-
-				return true;
+			const hadOwnProperty = Object.hasOwn(target, key);
+			const result = Reflect.deleteProperty(target, key);
+			if (result && hadOwnProperty && typeof key !== "symbol") {
+				proxy.observers.notify(proxy);
 			}
-			return false;
+			return result;
 		},
 
 		// https://262.ecma-international.org/9.0/#sec-proxy-object-internal-methods-and-internal-slots-defineownproperty-p-desc
@@ -269,6 +274,23 @@ function getHandler() {
 	return handler;
 }
 
+/**
+ * Two NaN values are the same value, so assigning NaN over NaN is not a change.
+ * Object.is() is not used here because it would additionally treat 0 and -0 as
+ * a change and notify for assignments that do not alter the subject.
+ * @param {*} a
+ * @param {*} b
+ * @return {boolean}
+ * @private
+ */
+function isSameValue(a, b) {
+	if (a === b) {
+		return true;
+	}
+
+	return Number.isNaN(a) && Number.isNaN(b);
+}
+
 /**
  * Native objects with internal slots cannot be used through a transparent Proxy
  * because their prototype methods require the original receiver.
@@ -277,5 +299,22 @@ function getHandler() {
  * @private
  */
 function isNativeObjectWithInternalSlots(value) {
-	return value instanceof Date || value instanceof Map || value instanceof Set;
+	if (
+		value instanceof Date ||
+		value instanceof RegExp ||
+		value instanceof Map ||
+		value instanceof Set ||
+		value instanceof WeakMap ||
+		value instanceof WeakSet ||
+		value instanceof Promise ||
+		value instanceof ArrayBuffer ||
+		ArrayBuffer.isView(value)
+	) {
+		return true;
+	}
+
+	return (
+		typeof SharedArrayBuffer === "function" &&
+		value instanceof SharedArrayBuffer
+	);
 }

package/source/types/tokenlist.mjs

@@ -84,13 +84,18 @@ class TokenList extends Base {
 	 */
 	contains(value) {
 		if (isString(value)) {
-			value = value.trim();
-			let counter = 0;
-			value.split(" ").forEach((token) => {
-				if (this.tokens.has(token.trim()) === false) return false;
-				counter++;
-			});
-			return counter > 0 ? true : false;
+			// Repeated or surrounding whitespace produces empty segments, which are
+			// not tokens. A value without any token contains nothing.
+			const tokens = value
+				.split(" ")
+				.map((token) => token.trim())
+				.filter((token) => token !== "");
+
+			if (tokens.length === 0) {
+				return false;
+			}
+
+			return tokens.every((token) => this.tokens.has(token));
 		}
 
 		if (isIterable(value)) {
@@ -100,7 +105,7 @@ class TokenList extends Base {
 				if (this.tokens.has(token.trim()) === false) return false;
 				counter++;
 			}
-			return counter > 0 ? true : false;
+			return counter > 0;
 		}
 
 		return false;

package/source/util/clone.mjs

@@ -42,6 +42,16 @@ export { clone };
  * @throws {Error} unable to clone obj! its type isn't supported.
  */
 function clone(obj) {
+	return cloneValue(obj, new WeakMap());
+}
+
+/**
+ * @private
+ * @param {*} obj
+ * @param {WeakMap} seen already cloned objects, keyed by source
+ * @return {*}
+ */
+function cloneValue(obj, seen) {
 	// typeof null results in 'object'.  https://2ality.com/2013/10/typeof-null.html
 	if (null === obj) {
 		return obj;
@@ -59,9 +69,14 @@ function clone(obj) {
 
 	// Handle Array
 	if (isArray(obj)) {
+		if (seen.has(obj)) {
+			return seen.get(obj);
+		}
+
 		const copy = [];
+		seen.set(obj, copy);
 		for (let i = 0, len = obj.length; i < len; i++) {
-			copy[i] = clone(obj[i]);
+			copy[i] = cloneValue(obj[i], seen);
 		}
 
 		return copy;
@@ -87,18 +102,28 @@ function clone(obj) {
 
 		// Handle Map
 		if (obj instanceof Map) {
+			if (seen.has(obj)) {
+				return seen.get(obj);
+			}
+
 			const copy = new Map();
+			seen.set(obj, copy);
 			for (const [key, value] of obj.entries()) {
-				copy.set(clone(key), clone(value));
+				copy.set(cloneValue(key, seen), cloneValue(value, seen));
 			}
 			return copy;
 		}
 
 		// Handle Set
 		if (obj instanceof Set) {
+			if (seen.has(obj)) {
+				return seen.get(obj);
+			}
+
 			const copy = new Set();
+			seen.set(obj, copy);
 			for (const value of obj.values()) {
-				copy.add(clone(value));
+				copy.add(cloneValue(value, seen));
 			}
 			return copy;
 		}
@@ -119,7 +144,7 @@ function clone(obj) {
 		if (typeof navigator !== "undefined" && obj === navigator) return obj;
 		if (typeof JSON !== "undefined" && obj === JSON) return obj;
 		if (isProxy(obj)) return obj; // Handle Proxy-Object
-		return cloneObject(obj);
+		return cloneObject(obj, seen);
 	}
 
 	throw new Error("unable to clone obj! its type isn't supported.");
@@ -128,12 +153,17 @@ function clone(obj) {
 /**
  *
  * @param {object} obj
+ * @param {WeakMap} seen already cloned objects, keyed by source
  * @return {object}
  * @private
  */
-function cloneObject(obj) {
+function cloneObject(obj, seen) {
 	validateObject(obj);
 
+	if (seen.has(obj)) {
+		return seen.get(obj);
+	}
+
 	const fkt = obj?.["constructor"];
 	const sourcePrototype = Object.getPrototypeOf(obj);
 
@@ -145,19 +175,19 @@ function cloneObject(obj) {
 				Object.prototype.hasOwnProperty.call(prototype, "getClone") &&
 				typeOf(obj.getClone) === "function"
 			) {
+				// deliberately before the memo is written: the object decides for
+				// itself what its copy is, and that result must not be replaced by
+				// a half built copy when the object is reached again inside a cycle.
 				return obj.getClone();
 			}
 		}
 	}
 
-	let copy = sourcePrototype === null ? Object.create(null) : {};
-	if (
-		sourcePrototype !== null &&
-		typeof fkt === "function" &&
-		typeof fkt.call === "function"
-	) {
-		copy = new fkt();
-	}
+	// The constructor is not invoked. Calling it would run arbitrary code and
+	// fail for every class whose constructor requires arguments. Classes that
+	// need constructor work expose getClone() instead.
+	const copy = Object.create(sourcePrototype);
+	seen.set(obj, copy);
 
 	for (const key in obj) {
 		if (!Object.prototype.hasOwnProperty.call(obj, key)) {
@@ -169,7 +199,7 @@ function cloneObject(obj) {
 			continue;
 		}
 
-		copy[key] = clone(obj[key]);
+		copy[key] = cloneValue(obj[key], seen);
 	}
 
 	return copy;

package/test/cases/browser-bundle.mjs

@@ -0,0 +1,75 @@
+"use strict";
+
+import { expect } from "chai";
+import { buildCurrentTests } from "../web/current-bundle.mjs";
+
+/**
+ * Guards the browser test bundle for issue #577.
+ *
+ * The browser tier bundles the cases as bare `import "<file>"` statements. A
+ * `sideEffects` list in package.json is a restriction: every path it does not
+ * match counts as side effect free, and esbuild then drops those bare imports.
+ * With `./test/**` missing from the list the bundle collapsed from about 9 MB
+ * to 15 bytes, and all three browser jobs reported `0 passing, 0 failing,
+ * 0 pending` rather than failing loudly.
+ *
+ * This file runs esbuild over the repository, so it is listed in nodeOnlyCases
+ * in test/web/current-bundle.mjs and does not run in the browser bundle itself.
+ */
+describe("Browser test bundle issue #577", function () {
+	this.timeout(60000);
+
+	let bundle;
+
+	before(async function () {
+		bundle = await buildCurrentTests();
+	});
+
+	it("should collect the case files", function () {
+		expect(bundle.files).to.be.an("array");
+		expect(
+			bundle.files.length,
+			"far fewer case files than the repository contains",
+		).to.be.above(150);
+	});
+
+	it("should produce a bundle that actually contains the cases", function () {
+		// an emptied bundle is a few bytes, a complete one is megabytes
+		expect(
+			bundle.code.length,
+			"the bundled browser suite is far too small to hold the test cases",
+		).to.be.above(1_000_000);
+	});
+
+	it("should keep the suites of the bundled files", function () {
+		// every case file registers suites at module scope, so dropping the bare
+		// imports removes these calls even though the file list stays complete
+		const suites = [...bundle.code.matchAll(/\bdescribe\(/g)].length;
+
+		expect(suites, "the bundle registers almost no suites").to.be.above(300);
+	});
+
+	it("should contain content from several distinct case files", function () {
+		for (const marker of [
+			"Pathfinder resolution baseline",
+			"CustomElement rebind baseline",
+			"Updater remove attribute",
+			"MonthCalendar date configuration",
+			"contains all tokens",
+		]) {
+			expect(
+				bundle.code.includes(marker),
+				`the bundle does not contain "${marker}", so cases are missing`,
+			).to.be.true;
+		}
+	});
+
+	it("should not bundle the node only cases", function () {
+		for (const nodeOnly of ["packaging.mjs", "browser-bundle.mjs"]) {
+			expect(
+				bundle.files.some((file) => file.endsWith(`test/cases/${nodeOnly}`)),
+				`${nodeOnly} must stay out of the browser bundle`,
+			).to.be.false;
+		}
+	});
+});