@schukai/monster 3.73.4 → 3.73.6

package/source/types/node.mjs

@@ -12,13 +12,13 @@
  * SPDX-License-Identifier: AGPL-3.0
  */
 
-import { Base } from "./base.mjs";
-import { isPrimitive } from "./is.mjs";
-import { NodeList } from "./nodelist.mjs";
-import { validateInstance } from "./validate.mjs";
-import { instanceSymbol } from "../constants.mjs";
+import {Base} from "./base.mjs";
+import {isPrimitive} from "./is.mjs";
+import {NodeList} from "./nodelist.mjs";
+import {validateInstance} from "./validate.mjs";
+import {instanceSymbol} from "../constants.mjs";
 
-export { Node };
+export {Node};
 
 /**
  * @private
@@ -43,120 +43,120 @@ const treeStructureSymbol = Symbol("treeStructure");
  * @see https://developer.mozilla.org/de/docs/Web/JavaScript/Reference/Iteration_protocols
  */
 class Node extends Base {
-	/**
-	 * @param {*} [value]
-	 */
-	constructor(value) {
-		super();
-		this[internalValueSymbol] = value;
-
-		this[treeStructureSymbol] = {
-			parent: null,
-			childNodes: new NodeList(),
-			level: 0,
-		};
-	}
-
-	/**
-	 * This method is called by the `instanceof` operator.
-	 * @returns {symbol}
-	 * @since 2.1.0
-	 */
-	static get [instanceSymbol]() {
-		return Symbol.for("@schukai/monster/types/node");
-	}
-
-	/**
-	 * @property {*}
-	 */
-	get value() {
-		return this[internalValueSymbol];
-	}
-
-	/**
-	 * @property {*}
-	 */
-	set value(value) {
-		this[internalValueSymbol] = value;
-	}
-
-	/**
-	 * @property {Monster.Types.Node|null}
-	 */
-	get parent() {
-		return this[treeStructureSymbol].parent;
-	}
-
-	/**
-	 * @property {integer}
-	 */
-	get level() {
-		return this[treeStructureSymbol].level;
-	}
-
-	/**
-	 *
-	 * @property {NodeList}
-	 */
-	get childNodes() {
-		return this[treeStructureSymbol].childNodes;
-	}
-
-	/**
-	 *
-	 * @property {NodeList}
-	 */
-	set childNodes(childNodes) {
-		this[treeStructureSymbol].childNodes = validateInstance(
-			childNodes,
-			NodeList,
-		);
-		setChildLevelAndParent.call(this, this, 1);
-	}
-
-	/**
-	 * @return {Monster.Types.Node}
-	 * @param {Node} node
-	 */
-	appendChild(node) {
-		this[treeStructureSymbol].childNodes.add(validateInstance(node, Node));
-		node[treeStructureSymbol].parent = this;
-
-		node[treeStructureSymbol].level = this.level + 1;
-		setChildLevelAndParent.call(this, node, 1);
-		return this;
-	}
-
-	/**
-	 * @return {Monster.Types.Node}
-	 * @param {Node} node
-	 */
-	removeChild(node) {
-		this[treeStructureSymbol].childNodes.remove(validateInstance(node, Node));
-		node[treeStructureSymbol].parent = null;
-
-		node[treeStructureSymbol].level = 0;
-		setChildLevelAndParent.call(this, node, -1);
-		return this;
-	}
-
-	/**
-	 *
-	 * @return {boolean}
-	 */
-	hasChildNodes() {
-		return this[treeStructureSymbol].childNodes.length > 0;
-	}
-
-	/**
-	 * @return {Monster.Types.Node}
-	 * @param {Node} node
-	 */
-	hasChild(node) {
-		return this[treeStructureSymbol].childNodes.has(
-			validateInstance(node, Node),
-		);
-	}
+    /**
+     * @param {*} [value]
+     */
+    constructor(value) {
+        super();
+        this[internalValueSymbol] = value;
+
+        this[treeStructureSymbol] = {
+            parent: null,
+            childNodes: new NodeList(),
+            level: 0,
+        };
+    }
+
+    /**
+     * This method is called by the `instanceof` operator.
+     * @returns {symbol}
+     * @since 2.1.0
+     */
+    static get [instanceSymbol]() {
+        return Symbol.for("@schukai/monster/types/node");
+    }
+
+    /**
+     * @property {*}
+     */
+    get value() {
+        return this[internalValueSymbol];
+    }
+
+    /**
+     * @property {*}
+     */
+    set value(value) {
+        this[internalValueSymbol] = value;
+    }
+
+    /**
+     * @property {Monster.Types.Node|null}
+     */
+    get parent() {
+        return this[treeStructureSymbol].parent;
+    }
+
+    /**
+     * @property {integer}
+     */
+    get level() {
+        return this[treeStructureSymbol].level;
+    }
+
+    /**
+     *
+     * @property {NodeList}
+     */
+    get childNodes() {
+        return this[treeStructureSymbol].childNodes;
+    }
+
+    /**
+     *
+     * @property {NodeList}
+     */
+    set childNodes(childNodes) {
+        this[treeStructureSymbol].childNodes = validateInstance(
+            childNodes,
+            NodeList,
+        );
+        setChildLevelAndParent.call(this, this, 1, new Set());
+    }
+
+    /**
+     * @return {Monster.Types.Node}
+     * @param {Node} node
+     */
+    appendChild(node) {
+        this[treeStructureSymbol].childNodes.add(validateInstance(node, Node));
+        node[treeStructureSymbol].parent = this;
+
+        node[treeStructureSymbol].level = this.level + 1;
+        setChildLevelAndParent.call(this, node, 1, new Set());
+        return this;
+    }
+
+    /**
+     * @return {Monster.Types.Node}
+     * @param {Node} node
+     */
+    removeChild(node) {
+        this[treeStructureSymbol].childNodes.remove(validateInstance(node, Node));
+        node[treeStructureSymbol].parent = null;
+
+        node[treeStructureSymbol].level = 0;
+        setChildLevelAndParent.call(this, node, -1, new Set());
+        return this;
+    }
+
+    /**
+     *
+     * @return {boolean}
+     */
+    hasChildNodes() {
+        return this[treeStructureSymbol].childNodes.length > 0;
+    }
+
+    /**
+     * @return {Monster.Types.Node}
+     * @param {Node} node
+     */
+    hasChild(node) {
+        return this[treeStructureSymbol].childNodes.has(
+            validateInstance(node, Node),
+        );
+    }
 
 	/**
 	 * @since 1.28.0
@@ -192,24 +192,34 @@ class Node extends Base {
 	}
 }
 
+
 /**
  * @private
  * @param {Node} node
  * @param {int} operand
+ * @param {Set} visitedNodes
  * @return {setChildLevelAndParent}
  */
-function setChildLevelAndParent(node, operand) {
-	const self = this;
-
-	if (node !== this) {
-		node[treeStructureSymbol].parent = this;
-	}
-
-	node[treeStructureSymbol].childNodes.forEach(function (child) {
-		child[treeStructureSymbol].parent = node;
-		child[treeStructureSymbol].level =
-			node[treeStructureSymbol].level + operand;
-		setChildLevelAndParent.call(self, child, operand);
-	});
-	return this;
+function setChildLevelAndParent(node, operand, visitedNodes) {
+    const self = this;
+
+    if (visitedNodes.has(node)) {
+        throw new Error(
+            "the node has already been visited and cannot be traversed again",
+        )
+    }
+
+    visitedNodes.add(node);
+
+    if (node !== this) {
+        node[treeStructureSymbol].parent = this;
+    }
+
+    node[treeStructureSymbol].childNodes.forEach(function (child) {
+        child[treeStructureSymbol].parent = node;
+        child[treeStructureSymbol].level =
+            node[treeStructureSymbol].level + operand;
+        setChildLevelAndParent.call(self, child, operand, visitedNodes);
+    });
+    return this;
 }

package/source/types/version.mjs

@@ -159,7 +159,7 @@ function getMonsterVersion() {
 	}
 
 	/** don't touch, replaced by make with package.json version */
-	monsterVersion = new Version("3.73.2");
+	monsterVersion = new Version("3.73.5");
 
 	return monsterVersion;
 }

package/test/cases/data/buildtree.mjs

@@ -7,6 +7,52 @@ import {NodeList} from "../../../source/types/nodelist.mjs";
 
 describe('buildTree', function () {
 
+
+    describe('legacy navigation example (issue #230)', function () {
+
+        it('should run example', function () {
+
+            const objects = JSON.parse(`{
+    "dataset": [
+        {
+            "id": 100001,
+            "parent_id": 200001,
+            "title": "eBay",
+            "url": "/",
+            "weight": 1,
+            "css_styles": "",
+            "css_classes": ""
+        },
+        {
+            "id": 200001,
+            "parent_id": 200001,
+            "title": "alvineconsole",
+            "url": "",
+            "weight": 1,
+            "css_styles": "",
+            "css_classes": ""
+        }
+    ],
+    "sys": {
+        "code": 200,
+        "result": {},
+        "api_version": "1"
+    }
+}`);
+
+            try {
+                buildTree(objects, 'dataset.*', 'id', 'parent_id');    
+            } catch (error) {
+                expect(error).to.be.instanceOf(Error);
+            }
+            
+
+            
+
+        })
+    })    
+    
+
     describe('example', function () {
 
         it('should run example', function () {
@@ -207,6 +253,9 @@ describe('buildTree', function () {
 
 
     });
+    
+    
+    
 
 
 });

package/test/cases/dom/resource/data.mjs

@@ -76,7 +76,7 @@ describe('Data', function () {
     describe('External Data', () => {
 
         let id = new ID('data').toString();
-        let server, data, url = 'https://monsterjs.org/assets/empty.js?' + id;
+        let server, data, url = 'https://cdnjs.cloudflare.com/ajax/libs/layzr.js/2.2.2/layzr.min.js';
 
         beforeEach(() => {
 

package/test/cases/dom/resource/link/stylesheet.mjs

@@ -54,7 +54,7 @@ describe('Stylesheet', function () {
     describe('External Stylesheet', () => {
 
         let id = new ID('Stylesheet').toString();
-        let stylesheet, url = 'https://monsterjs.org/assets/empty.css?' + id;
+        let stylesheet, url = 'https://alvine.io/main.min.css';
 
         beforeEach(() => {
 

package/test/cases/dom/resource/link.mjs

@@ -51,7 +51,7 @@ describe('Link', function () {
         this.timeout(5000);
 
         let id = new ID('link').toString();
-        let link, url = 'https://monsterjs.org/assets/empty.css?' + id;
+        let link, url = 'https://alvine.io/main.min.css';
 
         beforeEach(() => {
 

package/test/cases/dom/resource/script.mjs

@@ -60,7 +60,7 @@ describe('Script', function () {
     describe('External JS', () => {
 
         let id = new ID('script').toString();
-        let server, script, url = 'https://monsterjs.org/assets/empty.js?' + id;
+        let server, script, url = 'https://cdnjs.cloudflare.com/ajax/libs/layzr.js/2.2.2/layzr.min.js';
 
         beforeEach(() => {
 

package/test/cases/monster.mjs

@@ -7,7 +7,7 @@ describe('Monster', function () {
         let monsterVersion
 
         /** don´t touch, replaced by make with package.json version */
-        monsterVersion = new Version("3.73.2")
+        monsterVersion = new Version("3.73.5")
 
         let m = getMonsterVersion();
 

package/test/web/test.html

@@ -9,8 +9,8 @@
 </head>
 <body>
 <div id="headline" style="display: flex;align-items: center;justify-content: center;flex-direction: column;">
-  <h1 style='margin-bottom: 0.1em;'>Monster 3.73.2</h1>
-  <div id="lastupdate" style='font-size:0.7em'>last update Di 2. Jul 20:16:21 CEST 2024</div>
+  <h1 style='margin-bottom: 0.1em;'>Monster 3.73.5</h1>
+  <div id="lastupdate" style='font-size:0.7em'>last update Mi 31. Jul 23:19:18 CEST 2024</div>
 </div>
 <div id="mocha-errors"
      style="color: red;font-weight: bold;display: flex;align-items: center;justify-content: center;flex-direction: column;margin:20px;"></div>