@schlessera/brain-ui-server 0.34.1 → 0.35.0

package/src/brain/types.ts

@@ -42,3 +42,13 @@ export interface BrainSyncResult {
   conflicts: number;
   message: string;
 }
+
+/** Outcome of saving content, including a recoverable indexing failure. */
+export interface BrainAddResult {
+  action: "created" | "appended";
+  path: string;
+  title: string;
+  type: string;
+  indexed: boolean;
+  indexError?: string;
+}

package/src/cron/run-job.ts

@@ -8,6 +8,7 @@ import { unlinkSync } from "fs";
 import { ingestSpanSink } from "../activity/span-sink.js";
 import { createActivityStore } from "../activity/store.js";
 import { createUiDb } from "../db/client.js";
+import { resolveSystemPrincipal } from "../db/principals.js";
 import { recordCronRun } from "./scheduler.js";
 
 /** Tail of stderr retained for the cron_runs error row. */
@@ -70,7 +71,7 @@ function messageOf(error: unknown): string {
 }
 
 function writeLine(sink: TextSink, text: string): void {
-  sink.write(`${text}\n`);
+  try { sink.write(`${text}\n`); } catch { /* Logging cannot stop the job. */ }
 }
 
 /** Forward a stream verbatim while exposing decoded chunks for tail capture. */
@@ -80,11 +81,17 @@ export async function teeStream(
   onText: (text: string) => void
 ): Promise<void> {
   const decoder = new TextDecoder();
-  for await (const chunk of stream) {
-    const text = decoder.decode(chunk, { stream: true });
-    sink.write(text);
+  let forwarding = true;
+  const forward = async (text: string) => {
     onText(text);
+    if (!forwarding) return;
+    try { await sink.write(text); } catch { forwarding = false; }
+  };
+  for await (const chunk of stream) {
+    await forward(decoder.decode(chunk, { stream: true }));
   }
+  const trailing = decoder.decode();
+  if (trailing) await forward(trailing);
 }
 
 /** Keep the last `cap` characters, never the head. */
@@ -99,10 +106,16 @@ async function startRecord(
   dbPath: string,
   stderr: TextSink
 ): Promise<RunRecorder | null> {
+  let db: ReturnType<typeof createUiDb> | undefined;
   try {
-    const db = createUiDb(dbPath);
+    db = createUiDb(dbPath);
+    const openedDb = db;
     const record = recordCronRun(db, name);
     const store = createActivityStore(db, { writer: `cron:${process.pid}` });
+    const principal = resolveSystemPrincipal(db, {
+      identity: "scheduled-jobs",
+      label: "Scheduled jobs",
+    });
     const runId = `cron-${name}-${Date.now()}`;
     const rootSpanId = `${runId}:root`;
     store.startSpan({
@@ -112,6 +125,7 @@ async function startRecord(
       kind: "cron",
       origin: "cron",
       jobName: name,
+      principalId: principal.id,
     });
 
     let sinkOffset = 0;
@@ -168,10 +182,11 @@ async function startRecord(
       },
       close() {
         clearInterval(heartbeat);
-        db.close();
+        openedDb.close();
       },
     };
   } catch (error) {
+    try { db?.close(); } catch { /* Preserve fail-open tracking. */ }
     writeLine(
       stderr,
       `[cron-run] tracking unavailable (job runs anyway): ${messageOf(error)}`
@@ -191,13 +206,12 @@ export async function runJob(
     dependencies.sinkPath ??
     `/tmp/brain-activity-sink-${process.pid}-${Date.now()}.jsonl`;
   const beginRecord = dependencies.startRecord ?? startRecord;
-  const recorder = await beginRecord(
-    options.jobName,
-    sinkPath,
-    options.command,
-    options.dbPath,
-    stderr
-  );
+  let recorder: RunRecorder | null = null;
+  try {
+    recorder = await beginRecord(options.jobName, sinkPath, options.command, options.dbPath, stderr);
+  } catch (error) {
+    writeLine(stderr, `[cron-run] tracking unavailable (job runs anyway): ${messageOf(error)}`);
+  }
 
   let exitCode: number;
   let errorMessage: string | undefined;
@@ -213,7 +227,7 @@ export async function runJob(
     });
 
     let stderrTail = "";
-    await Promise.all([
+    const outcomes = await Promise.allSettled([
       teeStream(proc.stdout, stdout, (text) => {
         outputTail = appendTail(outputTail, text, OUTPUT_TAIL_CHARS);
       }),
@@ -221,9 +235,16 @@ export async function runJob(
         stderrTail = appendTail(stderrTail, text, STDERR_TAIL_CHARS);
         outputTail = appendTail(outputTail, text, OUTPUT_TAIL_CHARS);
       }),
+      proc.exited,
     ]);
-
-    exitCode = await proc.exited;
+    for (const outcome of outcomes.slice(0, 2)) {
+      if (outcome.status === "rejected") {
+        writeLine(stderr, `[cron-run] output capture failed: ${messageOf(outcome.reason)}`);
+      }
+    }
+    const child = outcomes[2]!;
+    if (child.status === "rejected") throw child.reason;
+    exitCode = child.value;
     if (exitCode !== 0) {
       const cause = proc.signalCode ? `killed by ${proc.signalCode}` : `exit code ${exitCode}`;
       const trimmedTail = stderrTail.trim();
@@ -238,9 +259,12 @@ export async function runJob(
   if (recorder) {
     try {
       recorder.finish(errorMessage, outputTail.trim(), exitCode);
-      recorder.close();
     } catch (error) {
       writeLine(stderr, `[cron-run] failed to record run outcome: ${messageOf(error)}`);
+    } finally {
+      try { recorder.close(); } catch (error) {
+        writeLine(stderr, `[cron-run] failed to close tracking: ${messageOf(error)}`);
+      }
     }
   }
 

package/src/db/principals.ts

@@ -0,0 +1,452 @@
+import { createHash, randomBytes } from "node:crypto";
+import type { Database } from "bun:sqlite";
+
+export const MAX_LIVE_PRINCIPALS = 100;
+export const PRINCIPAL_RETENTION_MS = 30 * 24 * 60 * 60 * 1_000;
+export const PRINCIPAL_PRUNE_INTERVAL_MS = 60 * 60 * 1_000;
+
+export const LAST_SEEN_WRITE_INTERVAL_MS = 60_000;
+const MAX_LABEL_LENGTH = 64;
+const CONTROL_CHARACTER = /[\u0000-\u001f\u007f-\u009f]/u;
+const lastPrincipalPruneByDb = new WeakMap<Database, number>();
+
+export type PrincipalKind = "owner" | "agent" | "ambient" | "system";
+export type PrincipalAuthMethod =
+  | "password"
+  | "passkey"
+  | "delegated"
+  | "ambient";
+
+export type AmbientPrincipalSource = "none" | "proxy" | "tailscale";
+
+export interface Principal {
+  id: string;
+  kind: PrincipalKind;
+  authMethod: PrincipalAuthMethod;
+  label: string;
+  credentialId: string | null;
+  createdBy: string | null;
+  createdAt: number;
+  expiresAt: number;
+  lastSeenAt: number | null;
+  revokedAt: number | null;
+}
+
+export interface CreatePrincipalInput {
+  authMethod: Exclude<PrincipalAuthMethod, "ambient">;
+  label: string;
+  credentialId?: string;
+  createdBy?: string;
+  ttlSeconds: number;
+}
+
+export interface ResolveSystemPrincipalInput {
+  identity: string;
+  label: string;
+}
+
+export class PrincipalLimitError extends Error {
+  constructor() {
+    super(`live principal limit of ${MAX_LIVE_PRINCIPALS} reached`);
+    this.name = "PrincipalLimitError";
+  }
+}
+
+export class PrincipalCredentialNotFoundError extends Error {
+  constructor(credentialId: string) {
+    super(`passkey credential ${credentialId} no longer exists`);
+    this.name = "PrincipalCredentialNotFoundError";
+  }
+}
+
+export class PrincipalCreatorNotUsableError extends Error {
+  constructor(createdBy: string | undefined) {
+    super(`principal creator ${createdBy ?? "(missing)"} is not a usable owner`);
+    this.name = "PrincipalCreatorNotUsableError";
+  }
+}
+
+interface PrincipalDbRow {
+  id: string;
+  kind: PrincipalKind;
+  auth_method: PrincipalAuthMethod;
+  label: string;
+  credential_id: string | null;
+  created_by: string | null;
+  created_at: number;
+  expires_at: number;
+  last_seen_at: number | null;
+  revoked_at: number | null;
+}
+
+const PRINCIPAL_COLUMNS = `id, kind, auth_method, label, credential_id,
+  created_by, created_at, expires_at, last_seen_at, revoked_at`;
+
+function rowToPrincipal(row: PrincipalDbRow): Principal {
+  return {
+    id: row.id,
+    kind: row.kind,
+    authMethod: row.auth_method,
+    label: row.label,
+    credentialId: row.credential_id,
+    createdBy: row.created_by,
+    createdAt: row.created_at,
+    expiresAt: row.expires_at,
+    lastSeenAt: row.last_seen_at,
+    revokedAt: row.revoked_at,
+  };
+}
+
+function validateLabel(label: string): void {
+  if (typeof label !== "string") throw new TypeError("principal label must be a string");
+  if (label.length > MAX_LABEL_LENGTH) {
+    throw new RangeError(`principal label must be at most ${MAX_LABEL_LENGTH} characters`);
+  }
+  if (CONTROL_CHARACTER.test(label)) {
+    throw new RangeError("principal label must not contain control characters");
+  }
+}
+
+function expiryFromTtl(now: number, ttlSeconds: number): number {
+  if (!Number.isSafeInteger(ttlSeconds) || ttlSeconds <= 0) {
+    throw new RangeError("principal ttlSeconds must be a positive safe integer");
+  }
+  const expiresAt = now + ttlSeconds * 1_000;
+  if (!Number.isSafeInteger(expiresAt)) {
+    throw new RangeError("principal expiry must be a safe integer");
+  }
+  return expiresAt;
+}
+
+function generatePrincipalId(): string {
+  return randomBytes(16).toString("base64url");
+}
+
+function ambientPrincipalId(
+  source: AmbientPrincipalSource,
+  identity: string
+): string {
+  return createHash("sha256")
+    .update("brain-ui:ambient-principal:v1\0")
+    .update(source)
+    .update("\0")
+    .update(identity)
+    .digest()
+    .subarray(0, 16)
+    .toString("base64url");
+}
+
+function systemPrincipalId(identity: string): string {
+  return createHash("sha256")
+    .update("brain-ui:system-principal:v1\0")
+    .update(identity)
+    .digest()
+    .subarray(0, 16)
+    .toString("base64url");
+}
+
+function kindFromAuthMethod(
+  authMethod: CreatePrincipalInput["authMethod"]
+): "owner" | "agent" {
+  switch (authMethod) {
+    case "password":
+    case "passkey":
+      return "owner";
+    case "delegated":
+      return "agent";
+    default:
+      throw new TypeError(`unsupported principal auth method: ${String(authMethod)}`);
+  }
+}
+
+export function createPrincipal(db: Database, input: CreatePrincipalInput): Principal {
+  validateLabel(input.label);
+
+  return db.transaction(() => {
+    const now = Date.now();
+    const expiresAt = expiryFromTtl(now, input.ttlSeconds);
+    if (input.authMethod === "delegated") {
+      // Request authentication may precede an awaited body read. Re-check the
+      // creator only after taking the write lock, in the transaction that
+      // inserts the delegated row, so revocation cannot race this authority.
+      const creator = input.createdBy
+        ? resolvePrincipal(db, input.createdBy)
+        : null;
+      if (
+        !creator ||
+        creator.kind !== "owner" ||
+        !isUsablePrincipal(creator, now)
+      ) {
+        throw new PrincipalCreatorNotUsableError(input.createdBy);
+      }
+    }
+    if (
+      input.credentialId !== undefined &&
+      !db.prepare("SELECT 1 FROM passkey_credentials WHERE id = ?").get(input.credentialId)
+    ) {
+      throw new PrincipalCredentialNotFoundError(input.credentialId);
+    }
+    if (countLivePrincipals(db, now) >= MAX_LIVE_PRINCIPALS) {
+      throw new PrincipalLimitError();
+    }
+
+    let id = generatePrincipalId();
+    const idExists = db.prepare("SELECT 1 FROM principals WHERE id = ?");
+    while (idExists.get(id)) id = generatePrincipalId();
+
+    db.prepare(
+      `INSERT INTO principals
+         (id, kind, auth_method, label, credential_id, created_by, created_at, expires_at)
+       VALUES (?, ?, ?, ?, ?, ?, ?, ?)`
+    ).run(
+      id,
+      kindFromAuthMethod(input.authMethod),
+      input.authMethod,
+      input.label,
+      input.credentialId ?? null,
+      input.createdBy ?? null,
+      now,
+      expiresAt
+    );
+
+    return resolvePrincipal(db, id)!;
+  }).immediate();
+}
+
+/**
+ * Resolve the durable attribution row for an ambient authorization identity.
+ * The id is deterministic per mode and full identity so repeated requests —
+ * including concurrent first requests — cannot grow one row per authorization
+ * check, while bounded display-label collisions remain distinct.
+ */
+export function resolveAmbientPrincipal(
+  db: Database,
+  source: AmbientPrincipalSource,
+  identity: string,
+  label: string
+): Principal {
+  validateLabel(label);
+  const id = ambientPrincipalId(source, identity);
+  const existing = resolvePrincipal(db, id);
+  if (existing) return resolveStoredIdentity(db, existing, label, "ambient");
+
+  return db.transaction(() => {
+    let principal = resolvePrincipal(db, id);
+    if (!principal) {
+      const now = Date.now();
+      db.prepare(
+        `INSERT INTO principals
+           (id, kind, auth_method, label, credential_id, created_by,
+            created_at, expires_at, last_seen_at)
+         VALUES (?, 'ambient', 'ambient', ?, NULL, NULL, ?, ?, ?)`
+      ).run(id, label, now, Number.MAX_SAFE_INTEGER, now);
+      principal = resolvePrincipal(db, id)!;
+    }
+
+    return resolveStoredIdentity(db, principal, label, "ambient");
+  }).immediate();
+}
+
+/** Resolve the durable attribution row for a non-cookie system identity. */
+export function resolveSystemPrincipal(
+  db: Database,
+  input: ResolveSystemPrincipalInput
+): Principal {
+  validateLabel(input.label);
+  const id = systemPrincipalId(input.identity);
+  const existing = resolvePrincipal(db, id);
+  if (existing) return resolveStoredIdentity(db, existing, input.label, "system");
+
+  return db.transaction(() => {
+    let principal = resolvePrincipal(db, id);
+    if (!principal) {
+      const now = Date.now();
+      db.prepare(
+        `INSERT INTO principals
+           (id, kind, auth_method, label, credential_id, created_by,
+            created_at, expires_at)
+         VALUES (?, 'system', 'ambient', ?, NULL, NULL, ?, ?)`
+      ).run(id, input.label, now, Number.MAX_SAFE_INTEGER);
+      principal = resolvePrincipal(db, id)!;
+    }
+    return resolveStoredIdentity(db, principal, input.label, "system");
+  }).immediate();
+}
+
+function resolveStoredIdentity(
+  db: Database,
+  principal: Principal,
+  label: string,
+  kind: "ambient" | "system"
+): Principal {
+  if (
+    principal.kind !== kind ||
+    principal.authMethod !== "ambient" ||
+    !isUsablePrincipal(principal, Date.now())
+  ) {
+    throw new Error(`Corrupt ${kind} principal ${principal.id}`);
+  }
+  if (principal.label !== label) {
+    db.prepare("UPDATE principals SET label = ? WHERE id = ?").run(
+      label,
+      principal.id
+    );
+    principal = { ...principal, label };
+  }
+  if (kind === "ambient") {
+    // The UPDATE's WHERE throttles the write, but issuing it at all starts an
+    // implicit write transaction — on every request, in three of four auth
+    // modes. Decide from the row already in hand; the SQL predicate stays as
+    // the concurrency guard for the writes that do happen.
+    const now = Date.now();
+    if (isLastSeenStale(principal.lastSeenAt, now)) {
+      touchLastSeen(db, principal.id, now);
+      principal = { ...principal, lastSeenAt: now };
+    }
+  }
+  return principal;
+}
+
+export function resolvePrincipal(db: Database, id: string): Principal | null {
+  const row = db
+    .prepare(`SELECT ${PRINCIPAL_COLUMNS} FROM principals WHERE id = ?`)
+    .get(id) as PrincipalDbRow | null;
+  return row ? rowToPrincipal(row) : null;
+}
+
+/** List currently usable cookie-bearing principals, newest first. */
+export function listLivePrincipals(db: Database, now: number): Principal[] {
+  return (
+    db
+      .prepare(
+        `SELECT ${PRINCIPAL_COLUMNS} FROM principals
+         WHERE kind IN ('owner', 'agent')
+           AND revoked_at IS NULL AND expires_at > ?
+         ORDER BY created_at DESC, id ASC`
+      )
+      .all(now) as PrincipalDbRow[]
+  ).map(rowToPrincipal);
+}
+
+export function isUsablePrincipal(row: Principal, now: number): boolean {
+  assertPrincipalTimestamp(row, "created_at", row.createdAt, false);
+  assertPrincipalTimestamp(row, "expires_at", row.expiresAt, false);
+  assertPrincipalTimestamp(row, "last_seen_at", row.lastSeenAt, true);
+  assertPrincipalTimestamp(row, "revoked_at", row.revokedAt, true);
+  return row.revokedAt === null && now < row.expiresAt;
+}
+
+/** Whether this principal kind may be carried by an authenticated cookie. */
+export function isCookieBearingPrincipal(
+  principal: Principal
+): principal is Principal & { kind: "owner" | "agent" } {
+  return principal.kind === "owner" || principal.kind === "agent";
+}
+
+function assertPrincipalTimestamp(
+  row: Principal,
+  column: string,
+  value: number | null,
+  nullable: boolean
+): void {
+  if ((nullable && value === null) || Number.isSafeInteger(value)) return;
+  throw new Error(`Corrupt principal ${row.id}: ${column} must be an integer`);
+}
+
+/** Whether a stored last_seen_at is old enough to be worth a write. */
+export function isLastSeenStale(lastSeenAt: number | null, now: number): boolean {
+  return lastSeenAt === null || lastSeenAt < now - LAST_SEEN_WRITE_INTERVAL_MS;
+}
+
+export function touchLastSeen(db: Database, id: string, now: number): void {
+  db.prepare(
+    `UPDATE principals SET last_seen_at = ?
+     WHERE id = ? AND (last_seen_at IS NULL OR last_seen_at < ?)`
+  ).run(now, id, now - LAST_SEEN_WRITE_INTERVAL_MS);
+}
+
+export function revokePrincipal(db: Database, id: string, now: number): string[] {
+  return idsFromRows(
+    db
+      .prepare(
+        `UPDATE principals SET revoked_at = ?
+         WHERE id = ? AND kind IN ('owner', 'agent')
+           AND revoked_at IS NULL RETURNING id`
+      )
+      .all(now, id) as Array<{ id: string }>
+  );
+}
+
+export function revokeAllPrincipals(db: Database, now: number): string[] {
+  return idsFromRows(
+    db
+      .prepare(
+        `UPDATE principals SET revoked_at = ?
+         WHERE kind IN ('owner', 'agent')
+           AND revoked_at IS NULL RETURNING id`
+      )
+      .all(now) as Array<{ id: string }>
+  );
+}
+
+export function revokeByCredential(
+  db: Database,
+  credentialId: string,
+  now: number
+): string[] {
+  return idsFromRows(
+    db
+      .prepare(
+        `UPDATE principals SET revoked_at = ?
+         WHERE credential_id = ? AND revoked_at IS NULL RETURNING id`
+      )
+      .all(now, credentialId) as Array<{ id: string }>
+  );
+}
+
+function idsFromRows(rows: Array<{ id: string }>): string[] {
+  return rows.map(({ id }) => id);
+}
+
+export function prunePrincipals(db: Database, now: number): void {
+  // Thirty days preserves a useful audit/debug window after a principal stops
+  // being usable while still placing a fixed bound on terminal-row growth.
+  const cutoff = now - PRINCIPAL_RETENTION_MS;
+  db.prepare(
+    `DELETE FROM principals
+     WHERE (kind = 'ambient' AND COALESCE(last_seen_at, created_at) < ?)
+        OR (kind <> 'ambient' AND (
+          (revoked_at IS NOT NULL AND revoked_at < ?)
+          OR expires_at < ?
+        ))`
+  ).run(cutoff, cutoff, cutoff);
+}
+
+/**
+ * Run principal retention at most once per database per process interval.
+ * Authentication paths call this cheaply; only the due call reaches SQLite.
+ */
+export function prunePrincipalsIfDue(db: Database, now: number): boolean {
+  const lastPrunedAt = lastPrincipalPruneByDb.get(db);
+  if (
+    lastPrunedAt !== undefined &&
+    now >= lastPrunedAt &&
+    now - lastPrunedAt < PRINCIPAL_PRUNE_INTERVAL_MS
+  ) {
+    return false;
+  }
+  prunePrincipals(db, now);
+  lastPrincipalPruneByDb.set(db, now);
+  return true;
+}
+
+export function countLivePrincipals(db: Database, now: number): number {
+  const row = db
+    .prepare(
+      `SELECT COUNT(*) AS count FROM principals
+       WHERE kind IN ('owner', 'agent')
+         AND revoked_at IS NULL AND expires_at > ?`
+    )
+    .get(now) as { count: number };
+  return row.count;
+}

package/src/files/walker.ts

@@ -383,12 +383,16 @@ export async function resolveForRaw(rel: string, root: string): Promise<{ abs: s
  */
 export async function buildWikilinkMap(root: string): Promise<Record<string, string>> {
   const matcher = await loadIgnore(root);
-  const out: Record<string, string> = {};
+  const out: Record<string, string> = Object.create(null);
+  const visited = new Set<string>();
 
   async function walk(rel: string): Promise<void> {
     const abs = await safeResolve(rel, root);
     let dirents;
     try {
+      const canonical = await realpath(abs);
+      if (visited.has(canonical)) return;
+      visited.add(canonical);
       dirents = await readdir(abs, { withFileTypes: true });
     } catch {
       return;

package/src/index.ts

@@ -41,13 +41,17 @@ export {
 } from "./agent/backend.js";
 export {
   authGuard,
-  bumpSessionsEpoch,
   isWsAuthorized,
+  resolveCookiePrincipal,
   resolveAuthMode,
+  revokeAllSessions,
   type AuthMode,
   type AuthRuntime,
 } from "./middleware/auth.js";
 
+export { type Principal } from "./db/principals.js";
+export { type AppEnv } from "./app-env.js";
+
 // The app's own SQLite database (sessions, passkeys, settings).
 export { createUiDb } from "./db/client.js";
 
@@ -68,6 +72,7 @@ export {
   turnIdMatches,
   type ConnectionState,
 } from "./ws/dispatch.js";
+export { type AuthorizationContext } from "./ws/turns.js";
 export { resolveTurnTarget } from "./ws/routing.js";
 export {
   createSessionCatalog,