@schlessera/brain-ui-react 0.35.0 → 0.36.0

package/src/components/quick-actions/streaming-output.tsx

@@ -0,0 +1,112 @@
+import { Button, Placeholder, StatusDot } from "@schlessera/brain-ui-kit";
+import type { ReactNode } from "react";
+import type { Tone } from "@schlessera/brain-ui-kit";
+
+/**
+ * What a streamed backend job looks like while it runs and once it has
+ * finished — rendered from props (S6). `StreamingPanel` and `WhatsupPanel`
+ * are the containers: they own the request, the reader loop, the abort
+ * controller and the "is this still my stream" checks; the two views here
+ * own the status row, the output area and the one button in the footer.
+ *
+ * `state` is the job's, in the container's vocabulary: `running` is the only
+ * state with a Cancel; every other state offers Close. The status dot is the
+ * kit's — amber breathing while running, teal when it completed, red for a
+ * failure or a cancellation — and the row is a polite live region so a
+ * screen reader hears "Complete" once, not every line.
+ */
+export type StreamState = "idle" | "running" | "success" | "error" | "cancelled";
+
+const STATUS: Record<StreamState, { tone: Tone; pulse: boolean; text: string }> = {
+  idle: { tone: "neutral", pulse: false, text: "Ready" },
+  running: { tone: "amber", pulse: true, text: "Running..." },
+  success: { tone: "teal", pulse: false, text: "Complete" },
+  error: { tone: "red", pulse: false, text: "Failed" },
+  cancelled: { tone: "red", pulse: false, text: "Cancelled" },
+};
+
+export interface StreamingOutputProps {
+  state: StreamState;
+  /** The job's lines so far, already turned into nodes by the container (paths linkified). */
+  lines: ReactNode[];
+  onCancel: () => void;
+  onClose: () => void;
+  /** Wire to the scroll anchor the container keeps in view. */
+  anchor?: ReactNode;
+}
+
+export function StreamingOutput(p: StreamingOutputProps) {
+  const running = p.state === "running";
+  const s = STATUS[p.state];
+  return (
+    <div className="flex h-full flex-col">
+      <div className="flex items-center gap-2 border-b border-border px-5 py-2" aria-live="polite">
+        <StatusDot tone={s.tone} pulse={s.pulse} size={7} />
+        <span className="text-xs text-muted-foreground">{s.text}</span>
+      </div>
+
+      <div className="flex-1 overflow-y-auto p-4 font-[family-name:var(--font-mono)] text-xs leading-relaxed text-muted-foreground">
+        {p.lines.map((line, i) => (
+          <div key={i} className="whitespace-pre-wrap">
+            {line}
+          </div>
+        ))}
+        {running && p.lines.length === 0 && <div className="text-muted-foreground/50">Starting...</div>}
+        {p.anchor}
+      </div>
+
+      <StreamFooter running={running} onCancel={p.onCancel} onClose={p.onClose} />
+    </div>
+  );
+}
+
+/**
+ * The briefing: one document rather than a log, so it loads behind a skeleton
+ * and renders as prose once it has all arrived. `content` is the container's
+ * rendered markdown node; the view does not know what it is made of.
+ */
+export interface BriefingOutputProps {
+  state: "loading" | "done" | "error" | "cancelled";
+  content: ReactNode;
+  onCancel: () => void;
+  onClose: () => void;
+}
+
+export function BriefingOutput(p: BriefingOutputProps) {
+  const loading = p.state === "loading";
+  return (
+    <div className="flex h-full flex-col">
+      {(p.state === "error" || p.state === "cancelled") && (
+        <div className="flex items-center gap-2 border-b border-border px-5 py-2" aria-live="polite">
+          <StatusDot tone="red" pulse={false} size={7} />
+          <span className="text-xs text-muted-foreground">Failed</span>
+        </div>
+      )}
+
+      <div className="flex-1 overflow-y-auto p-5">
+        {loading ? (
+          <div className="flex flex-col gap-3">
+            <Placeholder variant="loading" lines={4} bordered={false} pad={0} />
+            <p className="text-sm text-muted-foreground">Generating briefing...</p>
+          </div>
+        ) : (
+          p.content
+        )}
+      </div>
+
+      <StreamFooter running={loading} onCancel={p.onCancel} onClose={p.onClose} />
+    </div>
+  );
+}
+
+function StreamFooter({ running, onCancel, onClose }: { running: boolean; onCancel: () => void; onClose: () => void }) {
+  return (
+    <div className="flex justify-end border-t border-border px-5 py-3">
+      {running ? (
+        <Button label="Cancel" icon="cancel" tone="danger" size="sm" block={false} onClick={onCancel} />
+      ) : (
+        <Button label="Close" tone="quiet" size="sm" block={false} onClick={onClose} />
+      )}
+    </div>
+  );
+}

package/src/components/quick-actions/whatsup-modal.tsx

@@ -1,11 +1,16 @@
+import { useBrainUiRoot } from "../../root-context.js";
 import { useState, useEffect, useRef } from "react";
-import { Loader2, XCircle } from "lucide-react";
 import { SlidePanel } from "../layout/slide-panel.js";
 import { BrainMarkdown } from "../chat/brain-markdown.js";
-import { getBackendUrl } from "../../lib/backend.js";
+import { BriefingOutput } from "./streaming-output.js";
 
 type State = "loading" | "done" | "error" | "cancelled";
 
+/**
+ * The container (S6) for the briefing: the request, the SSE reader loop, the
+ * abort controller and the "still my stream" checks live here;
+ * `BriefingOutput` draws from props.
+ */
 export function WhatsupPanel({
   open,
   onClose,
@@ -13,6 +18,7 @@ export function WhatsupPanel({
   open: boolean;
   onClose: () => void;
 }) {
+  const root = useBrainUiRoot();
   const [state, setState] = useState<State>("loading");
   const [content, setContent] = useState("");
   const controllerRef = useRef<AbortController | null>(null);
@@ -23,29 +29,39 @@ export function WhatsupPanel({
     setState("loading");
     setContent("");
 
+    let disposed = false;
+    let reader: ReadableStreamDefaultReader<Uint8Array> | undefined;
     const controller = new AbortController();
+    const cancelReader = () => { void reader?.cancel().catch(() => {}); };
+    controller.signal.addEventListener("abort", cancelReader);
     controllerRef.current = controller;
 
     (async () => {
       try {
-        const res = await fetch(getBackendUrl("/api/brain/whatsup"), {
+        const res = await root.request(root.backendUrl("/api/brain/whatsup"), {
           method: "POST",
           signal: controller.signal,
         });
 
+        if (disposed || controller.signal.aborted) {
+          await res.body?.cancel();
+          return;
+        }
+
         if (!res.ok || !res.body) {
           setState("error");
           setContent(`HTTP ${res.status}: ${res.statusText}`);
           return;
         }
 
-        const reader = res.body.getReader();
+        reader = res.body.getReader();
         const decoder = new TextDecoder();
         let buffer = "";
         const lines: string[] = [];
 
         while (true) {
           const { done, value } = await reader.read();
+          if (disposed || controller.signal.aborted) return;
           if (done) break;
 
           buffer += decoder.decode(value, { stream: true });
@@ -72,6 +88,7 @@ export function WhatsupPanel({
 
         setContent(lines.join("\n"));
       } catch (err: any) {
+        if (disposed || controller.signal.aborted) return;
         if (err.name === "AbortError") {
           setState("cancelled");
           setContent("Cancelled.");
@@ -80,70 +97,31 @@ export function WhatsupPanel({
           setContent(`Error: ${err.message}`);
         }
       } finally {
-        controllerRef.current = null;
+        controller.signal.removeEventListener("abort", cancelReader);
+        reader?.releaseLock();
+        if (controllerRef.current === controller) controllerRef.current = null;
       }
     })();
 
     return () => {
+      disposed = true;
       controller.abort();
-      controllerRef.current = null;
+      if (controllerRef.current === controller) controllerRef.current = null;
     };
-  }, [open]);
-
-  const isLoading = state === "loading";
+  }, [open, root]);
 
   return (
-    <SlidePanel
-      open={open}
-      onClose={onClose}
-      title="Whatsup"
-      wide
-    >
-      <div className="flex h-full flex-col">
-        {/* Status bar (errors only — loading uses centered indicator) */}
-        {(state === "error" || state === "cancelled") && (
-          <div className="flex items-center gap-2 border-b border-border px-5 py-2">
-            <XCircle className="h-3.5 w-3.5 text-destructive" />
-            <span className="text-xs text-muted-foreground">Failed</span>
-          </div>
-        )}
-
-        {/* Content */}
-        <div className="flex-1 overflow-y-auto p-5">
-          {isLoading ? (
-            <div className="flex items-center justify-center h-32 text-muted-foreground text-sm">
-              <Loader2 className="h-5 w-5 animate-spin mr-2 text-primary" />
-              Generating briefing...
-            </div>
-          ) : (
-            <BrainMarkdown
-              content={content}
-              className="whatsup-briefing brain-prose"
-              entityTags
-              fileLinks
-            />
-          )}
-        </div>
-
-        {/* Footer */}
-        <div className="border-t border-border px-5 py-3 flex justify-end">
-          {isLoading ? (
-            <button
-              onClick={() => controllerRef.current?.abort()}
-              className="rounded-lg border border-destructive/30 px-4 py-1.5 text-xs font-medium text-destructive transition-colors hover:bg-destructive/10"
-            >
-              Cancel
-            </button>
-          ) : (
-            <button
-              onClick={onClose}
-              className="rounded-lg bg-surface-raised px-4 py-1.5 text-xs font-medium text-foreground transition-colors hover:bg-surface-overlay"
-            >
-              Close
-            </button>
-          )}
-        </div>
-      </div>
+    <SlidePanel open={open} onClose={onClose} title="Whatsup" wide>
+      <BriefingOutput
+        state={state}
+        content={<BrainMarkdown content={content} className="whatsup-briefing brain-prose" entityTags fileLinks />}
+        onCancel={() => {
+          controllerRef.current?.abort();
+          setState("cancelled");
+          setContent("Cancelled.");
+        }}
+        onClose={onClose}
+      />
     </SlidePanel>
   );
 }

package/src/components/settings/devices-agents-tab.tsx

@@ -1,9 +1,9 @@
-import { useEffect, useState, type FormEvent } from "react";
-import { Bot, Laptop, Loader2, Plus, Trash2 } from "lucide-react";
-import { api, type PrincipalSummary } from "../../lib/api-client.js";
+import { useCallback, useEffect, useRef, useState } from "react";
+import type { PrincipalSummary } from "../../lib/api-client.js";
+import { useBrainApi } from "../../root-context.js";
 import { formatRelativeTime } from "../../lib/format-time.js";
-import { cn } from "../../lib/utils.js";
 import { usePrincipalStore } from "../../stores/principal-store.js";
+import { PrincipalList } from "./principal-list.js";
 
 const MAX_LABEL_LENGTH = 64;
 const NOT_ENABLED = "Principal management is not enabled";
@@ -12,8 +12,16 @@ function displayLabel(label: string): string {
   return Array.from(label).slice(0, MAX_LABEL_LENGTH).join("");
 }
 
-/** Active devices and delegated agents, with owner-only mint and revoke controls. */
+/**
+ * Active devices and delegated agents, with owner-only mint and revoke
+ * controls. This is the container (S7): the principals request, the mint
+ * through the principal store and the revoke with its confirm live here;
+ * `PrincipalList` draws the list and the form on the kit.
+ */
 export function DevicesAgentsTab({ active }: { active: boolean }) {
+  const api = useBrainApi();
+  const lifetime = useRef(0);
+  const request = useRef(0);
   const [principals, setPrincipals] = useState<PrincipalSummary[]>([]);
   const [loading, setLoading] = useState(false);
   const [enabled, setEnabled] = useState(true);
@@ -28,15 +36,20 @@ export function DevicesAgentsTab({ active }: { active: boolean }) {
   );
   const mintAgent = usePrincipalStore((state) => state.mintAgent);
 
-  async function refresh() {
+  const refresh = useCallback(async () => {
+    const generation = lifetime.current;
+    const token = ++request.current;
+    const current = () => generation === lifetime.current && token === request.current;
     setLoading(true);
     setLoadFailed(false);
     setError(null);
     try {
       const data = await api.principals();
+      if (!current()) return;
       setPrincipals(data.principals);
       setEnabled(true);
     } catch (err) {
+      if (!current()) return;
       setPrincipals([]);
       if (err instanceof Error && err.message === NOT_ENABLED) {
         setEnabled(false);
@@ -46,22 +59,31 @@ export function DevicesAgentsTab({ active }: { active: boolean }) {
         setError(err instanceof Error ? err.message : "Could not load devices and agents");
       }
     } finally {
-      setLoading(false);
+      if (current()) setLoading(false);
     }
-  }
+  }, [api]);
 
   useEffect(() => {
+    lifetime.current++;
+    setPrincipals([]);
+    setLoading(false);
+    setEnabled(true);
+    setLoadFailed(false);
+    setError(null);
+    setLabel("");
+    setTtlDays(7);
     if (active) void refresh();
-  }, [active]);
+    const invalidate = () => { lifetime.current++; };
+    return invalidate;
+  }, [active, refresh]);
 
   useEffect(() => {
     if (!oneTimeCredential) return;
     setLabel("");
     if (active) void refresh();
-  }, [active, oneTimeCredential]);
+  }, [active, oneTimeCredential, refresh]);
 
-  function onMint(event: FormEvent<HTMLFormElement>) {
-    event.preventDefault();
+  function onMint() {
     const trimmed = label.trim();
     if (!trimmed || busy) return;
     setError(null);
@@ -76,156 +98,42 @@ export function DevicesAgentsTab({ active }: { active: boolean }) {
         : "That device will be signed out immediately.";
     if (!window.confirm(`${consequence} You can't undo this.`)) return;
 
+    const generation = lifetime.current;
     setError(null);
     try {
       await api.principalRevoke(principal.id);
+      if (generation !== lifetime.current) return;
       setPrincipals((rows) => rows.filter((row) => row.id !== principal.id));
       if (principal.is_own) window.location.reload();
     } catch (err) {
+      if (generation !== lifetime.current) return;
       setError(err instanceof Error ? err.message : "Could not revoke access");
     }
   }
 
   return (
-    <div className="h-full overflow-y-auto p-4">
-      <h3 className="text-xs font-medium uppercase tracking-wide text-muted-foreground">
-        Devices &amp; agents
-      </h3>
-      <p className="mt-1 text-xs text-muted-foreground">
-        See where this brain is signed in and create time-limited access for an agent.
-      </p>
-
-      {loading ? (
-        <div className="mt-6 flex justify-center">
-          <Loader2 className="h-5 w-5 animate-spin text-muted-foreground" />
-        </div>
-      ) : !enabled ? (
-        <p className="mt-4 text-xs text-muted-foreground">
-          Devices and agents can only be managed when password authentication is enabled.
-        </p>
-      ) : loadFailed ? (
-        <p role="alert" className="mt-4 text-xs text-destructive">
-          {error}
-        </p>
-      ) : (
-        <>
-          <ul className="mt-4 flex flex-col gap-2">
-            {principals.map((principal) => (
-              <PrincipalRow
-                key={principal.id}
-                principal={principal}
-                onRevoke={() => void onRevoke(principal)}
-              />
-            ))}
-            {principals.length === 0 ? (
-              <li className="rounded-lg border border-dashed border-border-subtle p-4 text-center text-xs text-muted-foreground">
-                No active devices or agents.
-              </li>
-            ) : null}
-          </ul>
-
-          {error || mintError ? (
-            <p role="alert" className="mt-3 text-xs text-destructive">
-              {error ?? mintError}
-            </p>
-          ) : null}
-
-          <form onSubmit={onMint} className="mt-6 border-t border-border pt-4">
-            <h4 className="text-xs font-medium uppercase tracking-wide text-muted-foreground">
-              Agent access
-            </h4>
-            <p className="mt-1 text-xs text-muted-foreground">
-              Create a credential an agent can use until it expires or you revoke it.
-            </p>
-            <label className="mt-3 block text-xs font-medium text-foreground" htmlFor="agent-label">
-              Label
-            </label>
-            <input
-              id="agent-label"
-              value={label}
-              maxLength={MAX_LABEL_LENGTH}
-              onChange={(event) => setLabel(event.target.value)}
-              placeholder="Build agent"
-              className="mt-1 w-full rounded-lg border border-border-subtle bg-background px-3 py-2 text-sm text-foreground outline-none focus:border-primary"
-            />
-            <label className="mt-3 block text-xs font-medium text-foreground" htmlFor="agent-ttl">
-              Expires after
-            </label>
-            <select
-              id="agent-ttl"
-              value={ttlDays}
-              onChange={(event) => setTtlDays(Number(event.target.value))}
-              className="mt-1 w-full rounded-lg border border-border-subtle bg-background px-3 py-2 text-sm text-foreground outline-none focus:border-primary"
-            >
-              <option value={1}>1 day</option>
-              <option value={7}>7 days</option>
-              <option value={30}>30 days</option>
-            </select>
-            <button
-              type="submit"
-              disabled={busy || !label.trim()}
-              className="mt-4 flex w-full items-center justify-center gap-2 rounded-lg bg-primary px-4 py-2 text-sm font-medium text-primary-foreground transition-colors hover:brightness-110 disabled:opacity-50"
-            >
-              {busy ? <Loader2 className="h-4 w-4 animate-spin" /> : <Plus className="h-4 w-4" />}
-              Create agent credential
-            </button>
-          </form>
-        </>
-      )}
-    </div>
-  );
-}
-
-function PrincipalRow({
-  principal,
-  onRevoke,
-}: {
-  principal: PrincipalSummary;
-  onRevoke: () => void;
-}) {
-  const agent = principal.kind === "agent";
-  const Icon = agent ? Bot : Laptop;
-  const kind = principal.is_own ? "This device" : agent ? "Agent" : "Device";
-
-  return (
-    <li
-      className={cn(
-        "rounded-lg border bg-surface p-3",
-        principal.is_own ? "border-primary/60" : "border-border-subtle"
-      )}
-    >
-      <div className="flex items-start gap-2">
-        <Icon className="mt-0.5 h-4 w-4 shrink-0 text-primary" />
-        <div className="min-w-0 flex-1">
-          <div className="flex flex-wrap items-center gap-1.5">
-            <span className="break-words text-sm text-foreground">
-              {displayLabel(principal.label)}
-            </span>
-            <span className="rounded bg-surface-raised px-1.5 py-0.5 text-[10px] font-medium uppercase tracking-wide text-muted-foreground">
-              {kind}
-            </span>
-          </div>
-          <dl className="mt-1.5 grid grid-cols-[auto_1fr] gap-x-2 gap-y-0.5 text-[11px] text-muted-foreground">
-            <dt>Created</dt>
-            <dd>{formatRelativeTime(principal.created_at)}</dd>
-            <dt>Last seen</dt>
-            <dd>
-              {principal.last_seen_at ? formatRelativeTime(principal.last_seen_at) : "Never"}
-            </dd>
-            <dt>Expires</dt>
-            <dd>{formatRelativeTime(principal.expires_at)}</dd>
-          </dl>
-        </div>
-        <button
-          type="button"
-          onClick={onRevoke}
-          aria-label={`Revoke ${displayLabel(principal.label)}`}
-          className="flex shrink-0 items-center gap-1 rounded px-1.5 py-1 text-xs text-muted-foreground transition-colors hover:text-destructive"
-        >
-          <Trash2 className="h-3.5 w-3.5" />
-          Revoke
-        </button>
-      </div>
-    </li>
+    <PrincipalList
+      state={loading ? "loading" : !enabled ? "unavailable" : loadFailed ? "error" : "ready"}
+      principals={principals.map((principal) => ({
+        id: principal.id,
+        label: displayLabel(principal.label),
+        kind: principal.kind,
+        isOwn: principal.is_own,
+        created: formatRelativeTime(principal.created_at),
+        lastSeen: principal.last_seen_at ? formatRelativeTime(principal.last_seen_at) : "Never",
+        expires: formatRelativeTime(principal.expires_at),
+      }))}
+      error={error ?? mintError}
+      label={label}
+      ttlDays={ttlDays}
+      minting={busy}
+      onLabel={setLabel}
+      onTtlDays={setTtlDays}
+      onMint={onMint}
+      onRevoke={(id) => {
+        const principal = principals.find((row) => row.id === id);
+        if (principal) void onRevoke(principal);
+      }}
+    />
   );
 }