@schilling.mark.a/atdd-guardian 1.0.0

package/dist/services/phase-gate.js

@@ -0,0 +1,309 @@
+/**
+ * Phase Gate Enforcement Service
+ *
+ * Implements the process constraints from the ATDD requirements:
+ *   PC-1: No production code without a failing unit test
+ *   PC-2: Minimal implementation principle
+ *   PC-3: Test independence
+ *
+ * The key idea: advance_phase is no longer a free pass.
+ * The system validates that the ATDD discipline was followed
+ * before allowing phase transitions. Violations are either
+ * blocked (hard gate) or warned (soft gate), depending on
+ * severity and team configuration.
+ *
+ * Gate strictness can be configured:
+ *   "strict"  — blocks on any violation
+ *   "guided"  — blocks on errors, warns on warnings
+ *   "lenient" — warns on everything, never blocks
+ */
+// ─── Valid Phase Transitions ─────────────────────────────────────
+const VALID_TRANSITIONS = {
+    requirements: ["test-design"],
+    "test-design": ["implementation"],
+    implementation: ["refactor"],
+    refactor: ["pre-pr-review", "implementation"], // back to impl if more ACs
+    "pre-pr-review": ["pr-submitted", "refactor"], // back to refactor if issues
+    "pr-submitted": ["pr-feedback", "done"],
+    "pr-feedback": ["refactor", "done"], // back to refactor to fix
+    done: [],
+};
+// ─── Main Gate Check ─────────────────────────────────────────────
+/**
+ * Validate whether a phase transition is allowed.
+ * Checks TDD discipline, test state, and workflow sequence.
+ */
+export function checkPhaseGate(session, targetPhase, strictness = "guided") {
+    const feature = session.activeFeature;
+    if (!feature) {
+        return {
+            allowed: false,
+            violations: [{
+                    type: "phase-skipped",
+                    message: "No active feature. Use start_feature first.",
+                    guidance: "Load a story context before advancing phases.",
+                    level: "block",
+                }],
+            summary: "No active feature loaded.",
+            nextSteps: ["Call start_feature with your story context."],
+        };
+    }
+    const currentPhase = feature.currentPhase;
+    const violations = [];
+    // 1. Check valid transition path
+    const validTargets = VALID_TRANSITIONS[currentPhase] ?? [];
+    if (!validTargets.includes(targetPhase)) {
+        violations.push({
+            type: "phase-skipped",
+            message: `Cannot go from '${currentPhase}' to '${targetPhase}'. Valid transitions: ${validTargets.join(", ") || "none"}.`,
+            guidance: `Follow the ATDD sequence. From '${currentPhase}', you can go to: ${validTargets.join(", ")}.`,
+            level: "block",
+        });
+    }
+    // 2. Phase-specific gates
+    switch (targetPhase) {
+        case "implementation":
+            violations.push(...checkTestDesignToImplementation(feature));
+            break;
+        case "refactor":
+            violations.push(...checkImplementationToRefactor(feature, session));
+            break;
+        case "pre-pr-review":
+            violations.push(...checkRefactorToPrePr(feature, session));
+            break;
+        case "pr-submitted":
+            violations.push(...checkPrePrToSubmit(feature, session));
+            break;
+        case "done":
+            violations.push(...checkDone(feature));
+            break;
+    }
+    // 3. Determine if allowed based on strictness
+    const blockers = violations.filter((v) => v.level === "block");
+    const warnings = violations.filter((v) => v.level === "warn");
+    let allowed;
+    switch (strictness) {
+        case "strict":
+            allowed = violations.length === 0;
+            break;
+        case "guided":
+            allowed = blockers.length === 0;
+            break;
+        case "lenient":
+            allowed = true;
+            break;
+    }
+    // 4. Build summary
+    const summary = violations.length === 0
+        ? `✅ Phase gate passed. Ready to advance to '${targetPhase}'.`
+        : `${blockers.length > 0 ? "❌ BLOCKED" : "⚠️ WARNINGS"}: ` +
+            `${blockers.length} blockers, ${warnings.length} warnings for transition to '${targetPhase}'.`;
+    const nextSteps = violations.map((v) => v.guidance);
+    return { allowed, violations, summary, nextSteps };
+}
+// ─── Gate: test-design → implementation ──────────────────────────
+/**
+ * Before entering implementation:
+ * - Every AC must have at least one acceptance test (status = "red")
+ * - No AC should still be "no-test"
+ */
+function checkTestDesignToImplementation(feature) {
+    const violations = [];
+    const noTest = feature.acceptanceCriteria.filter((ac) => ac.testStatus === "no-test");
+    if (noTest.length > 0) {
+        violations.push({
+            type: "no-red-test",
+            message: `${noTest.length} acceptance criteria have no test: ${noTest.map((ac) => ac.id).join(", ")}`,
+            guidance: "Write a failing Playwright test for each AC before implementing. " +
+                "Use update_criterion to mark them as 'red' once tests are created.",
+            level: "block",
+        });
+    }
+    const notRed = feature.acceptanceCriteria.filter((ac) => ac.testStatus !== "red" && ac.testStatus !== "no-test");
+    // ACs that are already green before implementation haven't gone through red
+    const alreadyGreen = feature.acceptanceCriteria.filter((ac) => ac.testStatus === "green");
+    if (alreadyGreen.length > 0) {
+        violations.push({
+            type: "skipped-red",
+            message: `${alreadyGreen.length} ACs are already green before implementation: ${alreadyGreen.map((ac) => ac.id).join(", ")}. Tests should be RED at this stage.`,
+            guidance: "Acceptance tests should fail (red) before you start implementation. " +
+                "If they pass without implementation, the test may not be testing the right thing.",
+            level: "warn",
+        });
+    }
+    return violations;
+}
+// ─── Gate: implementation → refactor ─────────────────────────────
+/**
+ * Before entering refactor:
+ * - All ACs should have green acceptance tests
+ * - Each AC that went red→green should have unit TDD cycles
+ * - No incomplete unit cycles (stuck in red without green)
+ */
+function checkImplementationToRefactor(feature, session) {
+    const violations = [];
+    // Check all ACs are green
+    const notGreen = feature.acceptanceCriteria.filter((ac) => ac.testStatus !== "green" && ac.testStatus !== "skipped");
+    if (notGreen.length > 0) {
+        violations.push({
+            type: "ac-still-red",
+            message: `${notGreen.length} acceptance criteria are not green: ${notGreen.map((ac) => `${ac.id}[${ac.testStatus}]`).join(", ")}`,
+            guidance: "All acceptance tests must pass before refactoring. " +
+                "Continue implementation until all ACs are green.",
+            level: "block",
+        });
+    }
+    // Check that unit TDD cycles were used (PC-1 enforcement)
+    const greenWithoutUnits = feature.acceptanceCriteria.filter((ac) => ac.testStatus === "green" && ac.unitCycles.length === 0);
+    if (greenWithoutUnits.length > 0) {
+        violations.push({
+            type: "no-unit-tests",
+            message: `${greenWithoutUnits.length} ACs went green without any unit TDD cycles: ${greenWithoutUnits.map((ac) => ac.id).join(", ")}`,
+            guidance: "PC-1: No production code without a failing unit test. " +
+                "Use start_unit_cycle and advance_unit_cycle to track the unit RED→GREEN→REFACTOR loops " +
+                "that drove each AC to green.",
+            level: "block",
+        });
+    }
+    // Check for incomplete unit cycles (stuck in red)
+    for (const ac of feature.acceptanceCriteria) {
+        const incomplete = ac.unitCycles.filter((uc) => uc.state === "red");
+        if (incomplete.length > 0) {
+            violations.push({
+                type: "incomplete-unit-cycle",
+                message: `AC ${ac.id} has ${incomplete.length} unit cycle(s) stuck in RED state (cycle ${incomplete.map((u) => u.cycleNumber).join(", ")})`,
+                guidance: "Each unit TDD cycle must complete RED→GREEN→REFACTOR. " +
+                    "Either make the failing unit test pass, or abandon the cycle with a reason.",
+                level: "warn",
+            });
+        }
+    }
+    return violations;
+}
+// ─── Gate: refactor → pre-pr-review ──────────────────────────────
+/**
+ * Before entering pre-PR review:
+ * - All ACs still green (refactoring didn't break anything)
+ * - Unit cycles should be in "refactored" state, not just "green"
+ * - Most recent test run should show all passing
+ */
+function checkRefactorToPrePr(feature, session) {
+    const violations = [];
+    // All ACs still green
+    const notGreen = feature.acceptanceCriteria.filter((ac) => ac.testStatus !== "green" && ac.testStatus !== "skipped");
+    if (notGreen.length > 0) {
+        violations.push({
+            type: "tests-regressed",
+            message: `Acceptance tests regressed during refactoring: ${notGreen.map((ac) => `${ac.id}[${ac.testStatus}]`).join(", ")}`,
+            guidance: "Refactoring must not break tests. Fix the regression before proceeding.",
+            level: "block",
+        });
+    }
+    // Check that unit cycles went through refactor
+    let unrefactored = 0;
+    for (const ac of feature.acceptanceCriteria) {
+        const greenNotRefactored = ac.unitCycles.filter((uc) => uc.state === "green");
+        unrefactored += greenNotRefactored.length;
+    }
+    if (unrefactored > 0) {
+        violations.push({
+            type: "no-refactor",
+            message: `${unrefactored} unit cycle(s) completed GREEN but were not refactored.`,
+            guidance: "Each unit TDD cycle should include a REFACTOR step. " +
+                "Review the green code for duplication, naming, SOLID principles. " +
+                "Use advance_unit_cycle to mark cycles as refactored.",
+            level: "warn",
+        });
+    }
+    // Check most recent test run
+    const recentRun = session.testRunHistory[session.testRunHistory.length - 1];
+    if (!recentRun) {
+        violations.push({
+            type: "no-red-test",
+            message: "No test runs recorded. Run tests to verify everything passes.",
+            guidance: "Use run_tests to execute your test suite and capture results.",
+            level: "warn",
+        });
+    }
+    else if (recentRun.failed > 0) {
+        violations.push({
+            type: "tests-regressed",
+            message: `Most recent test run had ${recentRun.failed} failures (${recentRun.timestamp}).`,
+            guidance: "Fix failing tests before submitting for review.",
+            level: "block",
+        });
+    }
+    return violations;
+}
+// ─── Gate: pre-pr-review → pr-submitted ──────────────────────────
+function checkPrePrToSubmit(feature, session) {
+    const violations = [];
+    // Must have at least one passing review
+    const passingReview = session.reviewHistory.find((r) => r.phase === "pre-pr-review" && (r.verdict === "pass" || r.verdict === "warnings-only"));
+    if (!passingReview) {
+        violations.push({
+            type: "phase-skipped",
+            message: "No passing pre-PR review found. Run review_code first.",
+            guidance: "Run review_code and fix all errors before submitting the PR.",
+            level: "block",
+        });
+    }
+    // DoD should be mostly complete
+    const incomplete = feature.definitionOfDone.filter((d) => !d.completed);
+    if (incomplete.length > 0) {
+        violations.push({
+            type: "phase-skipped",
+            message: `${incomplete.length} Definition of Done items incomplete: ${incomplete.map((d) => d.id).join(", ")}`,
+            guidance: "Complete all DoD items, or document why they're deferred.",
+            level: "warn",
+        });
+    }
+    return violations;
+}
+// ─── Gate: → done ────────────────────────────────────────────────
+function checkDone(feature) {
+    const violations = [];
+    const notGreen = feature.acceptanceCriteria.filter((ac) => ac.testStatus !== "green" && ac.testStatus !== "skipped");
+    if (notGreen.length > 0) {
+        violations.push({
+            type: "ac-still-red",
+            message: `Cannot mark as done — ${notGreen.length} ACs are not green.`,
+            guidance: "All acceptance criteria must have passing tests to be considered done.",
+            level: "block",
+        });
+    }
+    return violations;
+}
+// ─── Format Gate Result ──────────────────────────────────────────
+export function formatGateResult(result) {
+    const lines = [result.summary, ""];
+    if (result.violations.length === 0) {
+        return result.summary;
+    }
+    const blockers = result.violations.filter((v) => v.level === "block");
+    const warnings = result.violations.filter((v) => v.level === "warn");
+    if (blockers.length > 0) {
+        lines.push("## 🚫 Blockers (must resolve)");
+        for (const v of blockers) {
+            lines.push(`- **${v.type}**: ${v.message}`);
+            lines.push(`  → ${v.guidance}`);
+        }
+        lines.push("");
+    }
+    if (warnings.length > 0) {
+        lines.push("## ⚠️ Warnings (should resolve)");
+        for (const v of warnings) {
+            lines.push(`- **${v.type}**: ${v.message}`);
+            lines.push(`  → ${v.guidance}`);
+        }
+        lines.push("");
+    }
+    if (result.nextSteps.length > 0) {
+        lines.push("## Next Steps");
+        result.nextSteps.forEach((step, i) => {
+            lines.push(`${i + 1}. ${step}`);
+        });
+    }
+    return lines.join("\n");
+}
+//# sourceMappingURL=phase-gate.js.map

package/dist/services/phase-gate.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"phase-gate.js","sourceRoot":"","sources":["../../src/services/phase-gate.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;GAkBG;AAwBH,oEAAoE;AAEpE,MAAM,iBAAiB,GAAmC;IACxD,YAAY,EAAI,CAAC,aAAa,CAAC;IAC/B,aAAa,EAAG,CAAC,gBAAgB,CAAC;IAClC,cAAc,EAAE,CAAC,UAAU,CAAC;IAC5B,QAAQ,EAAQ,CAAC,eAAe,EAAE,gBAAgB,CAAC,EAAG,2BAA2B;IACjF,eAAe,EAAE,CAAC,cAAc,EAAE,UAAU,CAAC,EAAS,6BAA6B;IACnF,cAAc,EAAE,CAAC,aAAa,EAAE,MAAM,CAAC;IACvC,aAAa,EAAG,CAAC,UAAU,EAAE,MAAM,CAAC,EAAkB,0BAA0B;IAChF,IAAI,EAAY,EAAE;CACnB,CAAC;AAEF,oEAAoE;AAEpE;;;GAGG;AACH,MAAM,UAAU,cAAc,CAC5B,OAAqB,EACrB,WAAsB,EACtB,aAA6B,QAAQ;IAErC,MAAM,OAAO,GAAG,OAAO,CAAC,aAAa,CAAC;IACtC,IAAI,CAAC,OAAO,EAAE,CAAC;QACb,OAAO;YACL,OAAO,EAAE,KAAK;YACd,UAAU,EAAE,CAAC;oBACX,IAAI,EAAE,eAAe;oBACrB,OAAO,EAAE,6CAA6C;oBACtD,QAAQ,EAAE,+CAA+C;oBACzD,KAAK,EAAE,OAAO;iBACf,CAAC;YACF,OAAO,EAAE,2BAA2B;YACpC,SAAS,EAAE,CAAC,6CAA6C,CAAC;SAC3D,CAAC;IACJ,CAAC;IAED,MAAM,YAAY,GAAG,OAAO,CAAC,YAAY,CAAC;IAC1C,MAAM,UAAU,GAAmB,EAAE,CAAC;IAEtC,iCAAiC;IACjC,MAAM,YAAY,GAAG,iBAAiB,CAAC,YAAY,CAAC,IAAI,EAAE,CAAC;IAC3D,IAAI,CAAC,YAAY,CAAC,QAAQ,CAAC,WAAW,CAAC,EAAE,CAAC;QACxC,UAAU,CAAC,IAAI,CAAC;YACd,IAAI,EAAE,eAAe;YACrB,OAAO,EAAE,mBAAmB,YAAY,SAAS,WAAW,yBAAyB,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,MAAM,GAAG;YACzH,QAAQ,EAAE,mCAAmC,YAAY,qBAAqB,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG;YACxG,KAAK,EAAE,OAAO;SACf,CAAC,CAAC;IACL,CAAC;IAED,0BAA0B;IAC1B,QAAQ,WAAW,EAAE,CAAC;QACpB,KAAK,gBAAgB;YACnB,UAAU,CAAC,IAAI,CAAC,GAAG,+BAA+B,CAAC,OAAO,CAAC,CAAC,CAAC;YAC7D,MAAM;QACR,KAAK,UAAU;YACb,UAAU,CAAC,IAAI,CAAC,GAAG,6BAA6B,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC,CAAC;YACpE,MAAM;QACR,KAAK,eAAe;YAClB,UAAU,CAAC,IAAI,CAAC,GAAG,oBAAoB,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC,CAAC;YAC3D,MAAM;QACR,KAAK,cAAc;YACjB,UAAU,CAAC,IAAI,CAAC,GAAG,kBAAkB,CAAC,OAAO,EAAE,OAAO,CAAC,CAAC,CAAC;YACzD,MAAM;QACR,KAAK,MAAM;YACT,UAAU,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,OAAO,CAAC,CAAC,CAAC;YACvC,MAAM;IACV,CAAC;IAED,8CAA8C;IAC9C,MAAM,QAAQ,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,KAAK,OAAO,CAAC,CAAC;IAC/D,MAAM,QAAQ,GAAG,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,KAAK,MAAM,CAAC,CAAC;IAE9D,IAAI,OAAgB,CAAC;IACrB,QAAQ,UAAU,EAAE,CAAC;QACnB,KAAK,QAAQ;YACX,OAAO,GAAG,UAAU,CAAC,MAAM,KAAK,CAAC,CAAC;YAClC,MAAM;QACR,KAAK,QAAQ;YACX,OAAO,GAAG,QAAQ,CAAC,MAAM,KAAK,CAAC,CAAC;YAChC,MAAM;QACR,KAAK,SAAS;YACZ,OAAO,GAAG,IAAI,CAAC;YACf,MAAM;IACV,CAAC;IAED,mBAAmB;IACnB,MAAM,OAAO,GAAG,UAAU,CAAC,MAAM,KAAK,CAAC;QACrC,CAAC,CAAC,6CAA6C,WAAW,IAAI;QAC9D,CAAC,CAAC,GAAG,QAAQ,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,WAAW,CAAC,CAAC,CAAC,aAAa,IAAI;YACxD,GAAG,QAAQ,CAAC,MAAM,cAAc,QAAQ,CAAC,MAAM,gCAAgC,WAAW,IAAI,CAAC;IAEnG,MAAM,SAAS,GAAG,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC;IAEpD,OAAO,EAAE,OAAO,EAAE,UAAU,EAAE,OAAO,EAAE,SAAS,EAAE,CAAC;AACrD,CAAC;AAED,oEAAoE;AAEpE;;;;GAIG;AACH,SAAS,+BAA+B,CACtC,OAAuB;IAEvB,MAAM,UAAU,GAAmB,EAAE,CAAC;IAEtC,MAAM,MAAM,GAAG,OAAO,CAAC,kBAAkB,CAAC,MAAM,CAC9C,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,UAAU,KAAK,SAAS,CACpC,CAAC;IAEF,IAAI,MAAM,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACtB,UAAU,CAAC,IAAI,CAAC;YACd,IAAI,EAAE,aAAa;YACnB,OAAO,EAAE,GAAG,MAAM,CAAC,MAAM,sCAAsC,MAAM,CAAC,GAAG,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE;YACrG,QAAQ,EACN,mEAAmE;gBACnE,oEAAoE;YACtE,KAAK,EAAE,OAAO;SACf,CAAC,CAAC;IACL,CAAC;IAED,MAAM,MAAM,GAAG,OAAO,CAAC,kBAAkB,CAAC,MAAM,CAC9C,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,UAAU,KAAK,KAAK,IAAI,EAAE,CAAC,UAAU,KAAK,SAAS,CAC/D,CAAC;IAEF,4EAA4E;IAC5E,MAAM,YAAY,GAAG,OAAO,CAAC,kBAAkB,CAAC,MAAM,CACpD,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,UAAU,KAAK,OAAO,CAClC,CAAC;IACF,IAAI,YAAY,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC5B,UAAU,CAAC,IAAI,CAAC;YACd,IAAI,EAAE,aAAa;YACnB,OAAO,EAAE,GAAG,YAAY,CAAC,MAAM,iDAAiD,YAAY,CAAC,GAAG,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,sCAAsC;YAChK,QAAQ,EACN,sEAAsE;gBACtE,mFAAmF;YACrF,KAAK,EAAE,MAAM;SACd,CAAC,CAAC;IACL,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED,oEAAoE;AAEpE;;;;;GAKG;AACH,SAAS,6BAA6B,CACpC,OAAuB,EACvB,OAAqB;IAErB,MAAM,UAAU,GAAmB,EAAE,CAAC;IAEtC,0BAA0B;IAC1B,MAAM,QAAQ,GAAG,OAAO,CAAC,kBAAkB,CAAC,MAAM,CAChD,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,UAAU,KAAK,OAAO,IAAI,EAAE,CAAC,UAAU,KAAK,SAAS,CACjE,CAAC;IACF,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACxB,UAAU,CAAC,IAAI,CAAC;YACd,IAAI,EAAE,cAAc;YACpB,OAAO,EAAE,GAAG,QAAQ,CAAC,MAAM,uCAAuC,QAAQ,CAAC,GAAG,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,GAAG,EAAE,CAAC,EAAE,IAAI,EAAE,CAAC,UAAU,GAAG,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE;YACjI,QAAQ,EACN,qDAAqD;gBACrD,kDAAkD;YACpD,KAAK,EAAE,OAAO;SACf,CAAC,CAAC;IACL,CAAC;IAED,0DAA0D;IAC1D,MAAM,iBAAiB,GAAG,OAAO,CAAC,kBAAkB,CAAC,MAAM,CACzD,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,UAAU,KAAK,OAAO,IAAI,EAAE,CAAC,UAAU,CAAC,MAAM,KAAK,CAAC,CAChE,CAAC;IACF,IAAI,iBAAiB,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACjC,UAAU,CAAC,IAAI,CAAC;YACd,IAAI,EAAE,eAAe;YACrB,OAAO,EAAE,GAAG,iBAAiB,CAAC,MAAM,gDAAgD,iBAAiB,CAAC,GAAG,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE;YACrI,QAAQ,EACN,wDAAwD;gBACxD,yFAAyF;gBACzF,8BAA8B;YAChC,KAAK,EAAE,OAAO;SACf,CAAC,CAAC;IACL,CAAC;IAED,kDAAkD;IAClD,KAAK,MAAM,EAAE,IAAI,OAAO,CAAC,kBAAkB,EAAE,CAAC;QAC5C,MAAM,UAAU,GAAG,EAAE,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,KAAK,KAAK,KAAK,CAAC,CAAC;QACpE,IAAI,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;YAC1B,UAAU,CAAC,IAAI,CAAC;gBACd,IAAI,EAAE,uBAAuB;gBAC7B,OAAO,EAAE,MAAM,EAAE,CAAC,EAAE,QAAQ,UAAU,CAAC,MAAM,4CAA4C,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,GAAG;gBAC3I,QAAQ,EACN,wDAAwD;oBACxD,6EAA6E;gBAC/E,KAAK,EAAE,MAAM;aACd,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED,oEAAoE;AAEpE;;;;;GAKG;AACH,SAAS,oBAAoB,CAC3B,OAAuB,EACvB,OAAqB;IAErB,MAAM,UAAU,GAAmB,EAAE,CAAC;IAEtC,sBAAsB;IACtB,MAAM,QAAQ,GAAG,OAAO,CAAC,kBAAkB,CAAC,MAAM,CAChD,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,UAAU,KAAK,OAAO,IAAI,EAAE,CAAC,UAAU,KAAK,SAAS,CACjE,CAAC;IACF,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACxB,UAAU,CAAC,IAAI,CAAC;YACd,IAAI,EAAE,iBAAiB;YACvB,OAAO,EAAE,kDAAkD,QAAQ,CAAC,GAAG,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,GAAG,EAAE,CAAC,EAAE,IAAI,EAAE,CAAC,UAAU,GAAG,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE;YAC1H,QAAQ,EACN,yEAAyE;YAC3E,KAAK,EAAE,OAAO;SACf,CAAC,CAAC;IACL,CAAC;IAED,+CAA+C;IAC/C,IAAI,YAAY,GAAG,CAAC,CAAC;IACrB,KAAK,MAAM,EAAE,IAAI,OAAO,CAAC,kBAAkB,EAAE,CAAC;QAC5C,MAAM,kBAAkB,GAAG,EAAE,CAAC,UAAU,CAAC,MAAM,CAC7C,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,KAAK,KAAK,OAAO,CAC7B,CAAC;QACF,YAAY,IAAI,kBAAkB,CAAC,MAAM,CAAC;IAC5C,CAAC;IACD,IAAI,YAAY,GAAG,CAAC,EAAE,CAAC;QACrB,UAAU,CAAC,IAAI,CAAC;YACd,IAAI,EAAE,aAAa;YACnB,OAAO,EAAE,GAAG,YAAY,yDAAyD;YACjF,QAAQ,EACN,sDAAsD;gBACtD,mEAAmE;gBACnE,sDAAsD;YACxD,KAAK,EAAE,MAAM;SACd,CAAC,CAAC;IACL,CAAC;IAED,6BAA6B;IAC7B,MAAM,SAAS,GAAG,OAAO,CAAC,cAAc,CAAC,OAAO,CAAC,cAAc,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC;IAC5E,IAAI,CAAC,SAAS,EAAE,CAAC;QACf,UAAU,CAAC,IAAI,CAAC;YACd,IAAI,EAAE,aAAa;YACnB,OAAO,EAAE,+DAA+D;YACxE,QAAQ,EAAE,+DAA+D;YACzE,KAAK,EAAE,MAAM;SACd,CAAC,CAAC;IACL,CAAC;SAAM,IAAI,SAAS,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAChC,UAAU,CAAC,IAAI,CAAC;YACd,IAAI,EAAE,iBAAiB;YACvB,OAAO,EAAE,4BAA4B,SAAS,CAAC,MAAM,cAAc,SAAS,CAAC,SAAS,IAAI;YAC1F,QAAQ,EAAE,iDAAiD;YAC3D,KAAK,EAAE,OAAO;SACf,CAAC,CAAC;IACL,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED,oEAAoE;AAEpE,SAAS,kBAAkB,CACzB,OAAuB,EACvB,OAAqB;IAErB,MAAM,UAAU,GAAmB,EAAE,CAAC;IAEtC,wCAAwC;IACxC,MAAM,aAAa,GAAG,OAAO,CAAC,aAAa,CAAC,IAAI,CAC9C,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,KAAK,eAAe,IAAI,CAAC,CAAC,CAAC,OAAO,KAAK,MAAM,IAAI,CAAC,CAAC,OAAO,KAAK,eAAe,CAAC,CAC9F,CAAC;IACF,IAAI,CAAC,aAAa,EAAE,CAAC;QACnB,UAAU,CAAC,IAAI,CAAC;YACd,IAAI,EAAE,eAAe;YACrB,OAAO,EAAE,wDAAwD;YACjE,QAAQ,EAAE,8DAA8D;YACxE,KAAK,EAAE,OAAO;SACf,CAAC,CAAC;IACL,CAAC;IAED,gCAAgC;IAChC,MAAM,UAAU,GAAG,OAAO,CAAC,gBAAgB,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC;IACxE,IAAI,UAAU,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC1B,UAAU,CAAC,IAAI,CAAC;YACd,IAAI,EAAE,eAAe;YACrB,OAAO,EAAE,GAAG,UAAU,CAAC,MAAM,yCAAyC,UAAU,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE;YAC9G,QAAQ,EAAE,2DAA2D;YACrE,KAAK,EAAE,MAAM;SACd,CAAC,CAAC;IACL,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED,oEAAoE;AAEpE,SAAS,SAAS,CAAC,OAAuB;IACxC,MAAM,UAAU,GAAmB,EAAE,CAAC;IAEtC,MAAM,QAAQ,GAAG,OAAO,CAAC,kBAAkB,CAAC,MAAM,CAChD,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,UAAU,KAAK,OAAO,IAAI,EAAE,CAAC,UAAU,KAAK,SAAS,CACjE,CAAC;IACF,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACxB,UAAU,CAAC,IAAI,CAAC;YACd,IAAI,EAAE,cAAc;YACpB,OAAO,EAAE,yBAAyB,QAAQ,CAAC,MAAM,qBAAqB;YACtE,QAAQ,EAAE,wEAAwE;YAClF,KAAK,EAAE,OAAO;SACf,CAAC,CAAC;IACL,CAAC;IAED,OAAO,UAAU,CAAC;AACpB,CAAC;AAED,oEAAoE;AAEpE,MAAM,UAAU,gBAAgB,CAAC,MAAkB;IACjD,MAAM,KAAK,GAAa,CAAC,MAAM,CAAC,OAAO,EAAE,EAAE,CAAC,CAAC;IAE7C,IAAI,MAAM,CAAC,UAAU,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACnC,OAAO,MAAM,CAAC,OAAO,CAAC;IACxB,CAAC;IAED,MAAM,QAAQ,GAAG,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,KAAK,OAAO,CAAC,CAAC;IACtE,MAAM,QAAQ,GAAG,MAAM,CAAC,UAAU,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,KAAK,KAAK,MAAM,CAAC,CAAC;IAErE,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACxB,KAAK,CAAC,IAAI,CAAC,+BAA+B,CAAC,CAAC;QAC5C,KAAK,MAAM,CAAC,IAAI,QAAQ,EAAE,CAAC;YACzB,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,OAAO,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC;YAC5C,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,QAAQ,EAAE,CAAC,CAAC;QAClC,CAAC;QACD,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACjB,CAAC;IAED,IAAI,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACxB,KAAK,CAAC,IAAI,CAAC,iCAAiC,CAAC,CAAC;QAC9C,KAAK,MAAM,CAAC,IAAI,QAAQ,EAAE,CAAC;YACzB,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,IAAI,OAAO,CAAC,CAAC,OAAO,EAAE,CAAC,CAAC;YAC5C,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,QAAQ,EAAE,CAAC,CAAC;QAClC,CAAC;QACD,KAAK,CAAC,IAAI,CAAC,EAAE,CAAC,CAAC;IACjB,CAAC;IAED,IAAI,MAAM,CAAC,SAAS,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAChC,KAAK,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC;QAC5B,MAAM,CAAC,SAAS,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,CAAC,EAAE,EAAE;YACnC,KAAK,CAAC,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,KAAK,IAAI,EAAE,CAAC,CAAC;QAClC,CAAC,CAAC,CAAC;IACL,CAAC;IAED,OAAO,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;AAC1B,CAAC"}

package/dist/services/review-engine.d.ts

@@ -0,0 +1,26 @@
+/**
+ * Review Engine Service
+ *
+ * Core logic for applying review rules against source files.
+ * Separated from MCP tool definitions so it can be tested
+ * independently and reused across tools.
+ */
+import type { ReviewFinding, ReviewSummary, RuleSet, Severity, AtddPhase } from "../types.js";
+/**
+ * Recursively find all reviewable files under a root directory.
+ * Respects default excludes and reviewable extensions.
+ */
+export declare function discoverFiles(rootDir: string, additionalExcludes?: string[]): Promise<string[]>;
+/**
+ * Run a full review of a directory against a rule set.
+ */
+export declare function reviewDirectory(rootDir: string, ruleSet: RuleSet, options?: {
+    excludePatterns?: string[];
+    includePatterns?: string[];
+    severityFilter?: Severity[];
+    categoryFilter?: string[];
+    /** Only apply rules that match this ATDD phase */
+    phase?: AtddPhase;
+}): Promise<ReviewSummary>;
+export declare function reviewSingleFile(filePath: string, rootDir: string, ruleSet: RuleSet): Promise<ReviewFinding[]>;
+//# sourceMappingURL=review-engine.d.ts.map

package/dist/services/review-engine.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-engine.d.ts","sourceRoot":"","sources":["../../src/services/review-engine.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAKH,OAAO,KAAK,EAEV,aAAa,EACb,aAAa,EACb,OAAO,EACP,QAAQ,EACR,SAAS,EACV,MAAM,aAAa,CAAC;AAQrB;;;GAGG;AACH,wBAAsB,aAAa,CACjC,OAAO,EAAE,MAAM,EACf,kBAAkB,GAAE,MAAM,EAAO,GAChC,OAAO,CAAC,MAAM,EAAE,CAAC,CA2BnB;AAuGD;;GAEG;AACH,wBAAsB,eAAe,CACnC,OAAO,EAAE,MAAM,EACf,OAAO,EAAE,OAAO,EAChB,OAAO,GAAE;IACP,eAAe,CAAC,EAAE,MAAM,EAAE,CAAC;IAC3B,eAAe,CAAC,EAAE,MAAM,EAAE,CAAC;IAC3B,cAAc,CAAC,EAAE,QAAQ,EAAE,CAAC;IAC5B,cAAc,CAAC,EAAE,MAAM,EAAE,CAAC;IAC1B,kDAAkD;IAClD,KAAK,CAAC,EAAE,SAAS,CAAC;CACd,GACL,OAAO,CAAC,aAAa,CAAC,CA2HxB;AAID,wBAAsB,gBAAgB,CACpC,QAAQ,EAAE,MAAM,EAChB,OAAO,EAAE,MAAM,EACf,OAAO,EAAE,OAAO,GACf,OAAO,CAAC,aAAa,EAAE,CAAC,CAc1B"}

package/dist/services/review-engine.js

@@ -0,0 +1,235 @@
+/**
+ * Review Engine Service
+ *
+ * Core logic for applying review rules against source files.
+ * Separated from MCP tool definitions so it can be tested
+ * independently and reused across tools.
+ */
+import { readFile, readdir } from "node:fs/promises";
+import { join, relative, extname } from "node:path";
+import { minimatch } from "minimatch";
+import { DEFAULT_EXCLUDES, REVIEWABLE_EXTENSIONS, } from "../constants.js";
+// ─── File Discovery ──────────────────────────────────────────────
+/**
+ * Recursively find all reviewable files under a root directory.
+ * Respects default excludes and reviewable extensions.
+ */
+export async function discoverFiles(rootDir, additionalExcludes = []) {
+    const allExcludes = [...DEFAULT_EXCLUDES, ...additionalExcludes];
+    const results = [];
+    async function walk(dir) {
+        const entries = await readdir(dir, { withFileTypes: true });
+        for (const entry of entries) {
+            const fullPath = join(dir, entry.name);
+            const relPath = relative(rootDir, fullPath);
+            // Check if path matches any exclude pattern
+            const isExcluded = allExcludes.some((pattern) => minimatch(relPath, pattern, { dot: true }));
+            if (isExcluded)
+                continue;
+            if (entry.isDirectory()) {
+                await walk(fullPath);
+            }
+            else if (REVIEWABLE_EXTENSIONS.includes(extname(entry.name))) {
+                results.push(fullPath);
+            }
+        }
+    }
+    await walk(rootDir);
+    return results;
+}
+// ─── Rule Matching ───────────────────────────────────────────────
+/**
+ * Check whether a rule applies to a given file path.
+ */
+function ruleAppliesToFile(rule, relPath) {
+    const matchesInclude = rule.appliesTo.some((pattern) => minimatch(relPath, pattern, { dot: true }));
+    if (!matchesInclude)
+        return false;
+    if (rule.excludes && rule.excludes.length > 0) {
+        const matchesExclude = rule.excludes.some((pattern) => minimatch(relPath, pattern, { dot: true }));
+        if (matchesExclude)
+            return false;
+    }
+    return true;
+}
+/**
+ * Apply a single rule against file content.
+ * Returns findings (possibly empty).
+ */
+function applyRule(rule, filePath, relPath, content, lines) {
+    const findings = [];
+    // Pattern-based rules
+    if (rule.pattern) {
+        const regex = new RegExp(rule.pattern, "gm");
+        let match;
+        while ((match = regex.exec(content)) !== null) {
+            if (rule.matchIsViolation) {
+                // Find line number
+                const upToMatch = content.substring(0, match.index);
+                const lineNumber = upToMatch.split("\n").length;
+                findings.push({
+                    ruleId: rule.id,
+                    ruleName: rule.name,
+                    category: rule.category,
+                    severity: rule.severity,
+                    filePath: relPath,
+                    line: lineNumber,
+                    matchedText: match[0].substring(0, 100),
+                    message: rule.description,
+                    suggestion: rule.suggestion,
+                    goodExample: rule.goodExample,
+                    badExample: rule.badExample,
+                });
+            }
+        }
+        // For "require" rules (matchIsViolation = false), flag if NOT found
+        if (!rule.matchIsViolation) {
+            const hasMatch = regex.test(content);
+            if (!hasMatch) {
+                findings.push({
+                    ruleId: rule.id,
+                    ruleName: rule.name,
+                    category: rule.category,
+                    severity: rule.severity,
+                    filePath: relPath,
+                    message: `Required pattern not found: ${rule.description}`,
+                    suggestion: rule.suggestion,
+                    goodExample: rule.goodExample,
+                    badExample: rule.badExample,
+                });
+            }
+        }
+    }
+    // Structural rules (no pattern, custom logic)
+    if (rule.id === "arch-002" && !rule.pattern) {
+        // Component file length check
+        if (lines.length > 150) {
+            findings.push({
+                ruleId: rule.id,
+                ruleName: rule.name,
+                category: rule.category,
+                severity: rule.severity,
+                filePath: relPath,
+                message: `Component has ${lines.length} lines (limit: 150). Likely contains business logic that should be in a service.`,
+                suggestion: rule.suggestion,
+            });
+        }
+    }
+    return findings;
+}
+// ─── Main Review Function ────────────────────────────────────────
+/**
+ * Run a full review of a directory against a rule set.
+ */
+export async function reviewDirectory(rootDir, ruleSet, options = {}) {
+    const files = await discoverFiles(rootDir, options.excludePatterns);
+    // Optionally filter to only requested files
+    const targetFiles = options.includePatterns
+        ? files.filter((f) => {
+            const rel = relative(rootDir, f);
+            return options.includePatterns.some((p) => minimatch(rel, p, { dot: true }));
+        })
+        : files;
+    // Filter rules by severity/category/phase if requested
+    let activeRules = ruleSet.rules;
+    if (options.phase) {
+        activeRules = activeRules.filter((r) => !r.applicablePhases ||
+            r.applicablePhases.length === 0 ||
+            r.applicablePhases.includes(options.phase));
+    }
+    if (options.severityFilter?.length) {
+        activeRules = activeRules.filter((r) => options.severityFilter.includes(r.severity));
+    }
+    if (options.categoryFilter?.length) {
+        activeRules = activeRules.filter((r) => options.categoryFilter.includes(r.category));
+    }
+    const allFindings = [];
+    let filesReviewed = 0;
+    let filesSkipped = 0;
+    for (const filePath of targetFiles) {
+        const relPath = relative(rootDir, filePath);
+        // Find rules that apply to this file
+        const applicableRules = activeRules.filter((rule) => ruleAppliesToFile(rule, relPath));
+        if (applicableRules.length === 0) {
+            filesSkipped++;
+            continue;
+        }
+        filesReviewed++;
+        try {
+            const content = await readFile(filePath, "utf-8");
+            const lines = content.split("\n");
+            for (const rule of applicableRules) {
+                const findings = applyRule(rule, filePath, relPath, content, lines);
+                allFindings.push(...findings);
+            }
+        }
+        catch (error) {
+            const message = error instanceof Error ? error.message : "Unknown read error";
+            allFindings.push({
+                ruleId: "system-error",
+                ruleName: "File Read Error",
+                category: "custom",
+                severity: "warning",
+                filePath: relPath,
+                message: `Could not read file: ${message}`,
+                suggestion: "Check file permissions and encoding.",
+            });
+        }
+    }
+    // Build summary
+    const errorCount = allFindings.filter((f) => f.severity === "error").length;
+    const warningCount = allFindings.filter((f) => f.severity === "warning").length;
+    const infoCount = allFindings.filter((f) => f.severity === "info").length;
+    const findingsByCategory = {};
+    const findingsByFile = {};
+    for (const finding of allFindings) {
+        if (!findingsByCategory[finding.category]) {
+            findingsByCategory[finding.category] = [];
+        }
+        findingsByCategory[finding.category].push(finding);
+        if (!findingsByFile[finding.filePath]) {
+            findingsByFile[finding.filePath] = [];
+        }
+        findingsByFile[finding.filePath].push(finding);
+    }
+    let verdict;
+    if (errorCount > 0) {
+        verdict = "fail";
+    }
+    else if (warningCount > 0) {
+        verdict = "warnings-only";
+    }
+    else {
+        verdict = "pass";
+    }
+    return {
+        verdict,
+        phase: options.phase ?? "pre-pr-review",
+        totalFiles: targetFiles.length,
+        filesReviewed,
+        filesSkipped,
+        totalFindings: allFindings.length,
+        errorCount,
+        warningCount,
+        infoCount,
+        findingsByCategory,
+        findingsByFile,
+        findings: allFindings,
+        rulesApplied: activeRules.length,
+        reviewedAt: new Date().toISOString(),
+    };
+}
+// ─── Review Single File (for quick checks) ───────────────────────
+export async function reviewSingleFile(filePath, rootDir, ruleSet) {
+    const relPath = relative(rootDir, filePath);
+    const content = await readFile(filePath, "utf-8");
+    const lines = content.split("\n");
+    const findings = [];
+    for (const rule of ruleSet.rules) {
+        if (ruleAppliesToFile(rule, relPath)) {
+            findings.push(...applyRule(rule, filePath, relPath, content, lines));
+        }
+    }
+    return findings;
+}
+//# sourceMappingURL=review-engine.js.map

package/dist/services/review-engine.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"review-engine.js","sourceRoot":"","sources":["../../src/services/review-engine.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAEH,OAAO,EAAE,QAAQ,EAAE,OAAO,EAAQ,MAAM,kBAAkB,CAAC;AAC3D,OAAO,EAAE,IAAI,EAAE,QAAQ,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AACpD,OAAO,EAAE,SAAS,EAAE,MAAM,WAAW,CAAC;AAStC,OAAO,EACL,gBAAgB,EAChB,qBAAqB,GACtB,MAAM,iBAAiB,CAAC;AAEzB,oEAAoE;AAEpE;;;GAGG;AACH,MAAM,CAAC,KAAK,UAAU,aAAa,CACjC,OAAe,EACf,qBAA+B,EAAE;IAEjC,MAAM,WAAW,GAAG,CAAC,GAAG,gBAAgB,EAAE,GAAG,kBAAkB,CAAC,CAAC;IACjE,MAAM,OAAO,GAAa,EAAE,CAAC;IAE7B,KAAK,UAAU,IAAI,CAAC,GAAW;QAC7B,MAAM,OAAO,GAAG,MAAM,OAAO,CAAC,GAAG,EAAE,EAAE,aAAa,EAAE,IAAI,EAAE,CAAC,CAAC;QAE5D,KAAK,MAAM,KAAK,IAAI,OAAO,EAAE,CAAC;YAC5B,MAAM,QAAQ,GAAG,IAAI,CAAC,GAAG,EAAE,KAAK,CAAC,IAAI,CAAC,CAAC;YACvC,MAAM,OAAO,GAAG,QAAQ,CAAC,OAAO,EAAE,QAAQ,CAAC,CAAC;YAE5C,4CAA4C;YAC5C,MAAM,UAAU,GAAG,WAAW,CAAC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE,CAC9C,SAAS,CAAC,OAAO,EAAE,OAAO,EAAE,EAAE,GAAG,EAAE,IAAI,EAAE,CAAC,CAC3C,CAAC;YACF,IAAI,UAAU;gBAAE,SAAS;YAEzB,IAAI,KAAK,CAAC,WAAW,EAAE,EAAE,CAAC;gBACxB,MAAM,IAAI,CAAC,QAAQ,CAAC,CAAC;YACvB,CAAC;iBAAM,IAAI,qBAAqB,CAAC,QAAQ,CAAC,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,EAAE,CAAC;gBAC/D,OAAO,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;YACzB,CAAC;QACH,CAAC;IACH,CAAC;IAED,MAAM,IAAI,CAAC,OAAO,CAAC,CAAC;IACpB,OAAO,OAAO,CAAC;AACjB,CAAC;AAED,oEAAoE;AAEpE;;GAEG;AACH,SAAS,iBAAiB,CAAC,IAAgB,EAAE,OAAe;IAC1D,MAAM,cAAc,GAAG,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE,CACrD,SAAS,CAAC,OAAO,EAAE,OAAO,EAAE,EAAE,GAAG,EAAE,IAAI,EAAE,CAAC,CAC3C,CAAC;IACF,IAAI,CAAC,cAAc;QAAE,OAAO,KAAK,CAAC;IAElC,IAAI,IAAI,CAAC,QAAQ,IAAI,IAAI,CAAC,QAAQ,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QAC9C,MAAM,cAAc,GAAG,IAAI,CAAC,QAAQ,CAAC,IAAI,CAAC,CAAC,OAAO,EAAE,EAAE,CACpD,SAAS,CAAC,OAAO,EAAE,OAAO,EAAE,EAAE,GAAG,EAAE,IAAI,EAAE,CAAC,CAC3C,CAAC;QACF,IAAI,cAAc;YAAE,OAAO,KAAK,CAAC;IACnC,CAAC;IAED,OAAO,IAAI,CAAC;AACd,CAAC;AAED;;;GAGG;AACH,SAAS,SAAS,CAChB,IAAgB,EAChB,QAAgB,EAChB,OAAe,EACf,OAAe,EACf,KAAe;IAEf,MAAM,QAAQ,GAAoB,EAAE,CAAC;IAErC,sBAAsB;IACtB,IAAI,IAAI,CAAC,OAAO,EAAE,CAAC;QACjB,MAAM,KAAK,GAAG,IAAI,MAAM,CAAC,IAAI,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC;QAC7C,IAAI,KAA6B,CAAC;QAElC,OAAO,CAAC,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,KAAK,IAAI,EAAE,CAAC;YAC9C,IAAI,IAAI,CAAC,gBAAgB,EAAE,CAAC;gBAC1B,mBAAmB;gBACnB,MAAM,SAAS,GAAG,OAAO,CAAC,SAAS,CAAC,CAAC,EAAE,KAAK,CAAC,KAAK,CAAC,CAAC;gBACpD,MAAM,UAAU,GAAG,SAAS,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,MAAM,CAAC;gBAEhD,QAAQ,CAAC,IAAI,CAAC;oBACZ,MAAM,EAAE,IAAI,CAAC,EAAE;oBACf,QAAQ,EAAE,IAAI,CAAC,IAAI;oBACnB,QAAQ,EAAE,IAAI,CAAC,QAAQ;oBACvB,QAAQ,EAAE,IAAI,CAAC,QAAQ;oBACvB,QAAQ,EAAE,OAAO;oBACjB,IAAI,EAAE,UAAU;oBAChB,WAAW,EAAE,KAAK,CAAC,CAAC,CAAC,CAAC,SAAS,CAAC,CAAC,EAAE,GAAG,CAAC;oBACvC,OAAO,EAAE,IAAI,CAAC,WAAW;oBACzB,UAAU,EAAE,IAAI,CAAC,UAAU;oBAC3B,WAAW,EAAE,IAAI,CAAC,WAAW;oBAC7B,UAAU,EAAE,IAAI,CAAC,UAAU;iBAC5B,CAAC,CAAC;YACL,CAAC;QACH,CAAC;QAED,oEAAoE;QACpE,IAAI,CAAC,IAAI,CAAC,gBAAgB,EAAE,CAAC;YAC3B,MAAM,QAAQ,GAAG,KAAK,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;YACrC,IAAI,CAAC,QAAQ,EAAE,CAAC;gBACd,QAAQ,CAAC,IAAI,CAAC;oBACZ,MAAM,EAAE,IAAI,CAAC,EAAE;oBACf,QAAQ,EAAE,IAAI,CAAC,IAAI;oBACnB,QAAQ,EAAE,IAAI,CAAC,QAAQ;oBACvB,QAAQ,EAAE,IAAI,CAAC,QAAQ;oBACvB,QAAQ,EAAE,OAAO;oBACjB,OAAO,EAAE,+BAA+B,IAAI,CAAC,WAAW,EAAE;oBAC1D,UAAU,EAAE,IAAI,CAAC,UAAU;oBAC3B,WAAW,EAAE,IAAI,CAAC,WAAW;oBAC7B,UAAU,EAAE,IAAI,CAAC,UAAU;iBAC5B,CAAC,CAAC;YACL,CAAC;QACH,CAAC;IACH,CAAC;IAED,8CAA8C;IAC9C,IAAI,IAAI,CAAC,EAAE,KAAK,UAAU,IAAI,CAAC,IAAI,CAAC,OAAO,EAAE,CAAC;QAC5C,8BAA8B;QAC9B,IAAI,KAAK,CAAC,MAAM,GAAG,GAAG,EAAE,CAAC;YACvB,QAAQ,CAAC,IAAI,CAAC;gBACZ,MAAM,EAAE,IAAI,CAAC,EAAE;gBACf,QAAQ,EAAE,IAAI,CAAC,IAAI;gBACnB,QAAQ,EAAE,IAAI,CAAC,QAAQ;gBACvB,QAAQ,EAAE,IAAI,CAAC,QAAQ;gBACvB,QAAQ,EAAE,OAAO;gBACjB,OAAO,EAAE,iBAAiB,KAAK,CAAC,MAAM,kFAAkF;gBACxH,UAAU,EAAE,IAAI,CAAC,UAAU;aAC5B,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,OAAO,QAAQ,CAAC;AAClB,CAAC;AAED,oEAAoE;AAEpE;;GAEG;AACH,MAAM,CAAC,KAAK,UAAU,eAAe,CACnC,OAAe,EACf,OAAgB,EAChB,UAOI,EAAE;IAEN,MAAM,KAAK,GAAG,MAAM,aAAa,CAAC,OAAO,EAAE,OAAO,CAAC,eAAe,CAAC,CAAC;IAEpE,4CAA4C;IAC5C,MAAM,WAAW,GAAG,OAAO,CAAC,eAAe;QACzC,CAAC,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE;YACjB,MAAM,GAAG,GAAG,QAAQ,CAAC,OAAO,EAAE,CAAC,CAAC,CAAC;YACjC,OAAO,OAAO,CAAC,eAAgB,CAAC,IAAI,CAAC,CAAC,CAAC,EAAE,EAAE,CACzC,SAAS,CAAC,GAAG,EAAE,CAAC,EAAE,EAAE,GAAG,EAAE,IAAI,EAAE,CAAC,CACjC,CAAC;QACJ,CAAC,CAAC;QACJ,CAAC,CAAC,KAAK,CAAC;IAEV,uDAAuD;IACvD,IAAI,WAAW,GAAG,OAAO,CAAC,KAAK,CAAC;IAChC,IAAI,OAAO,CAAC,KAAK,EAAE,CAAC;QAClB,WAAW,GAAG,WAAW,CAAC,MAAM,CAC9B,CAAC,CAAC,EAAE,EAAE,CACJ,CAAC,CAAC,CAAC,gBAAgB;YACnB,CAAC,CAAC,gBAAgB,CAAC,MAAM,KAAK,CAAC;YAC/B,CAAC,CAAC,gBAAgB,CAAC,QAAQ,CAAC,OAAO,CAAC,KAAM,CAAC,CAC9C,CAAC;IACJ,CAAC;IACD,IAAI,OAAO,CAAC,cAAc,EAAE,MAAM,EAAE,CAAC;QACnC,WAAW,GAAG,WAAW,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CACrC,OAAO,CAAC,cAAe,CAAC,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,CAC7C,CAAC;IACJ,CAAC;IACD,IAAI,OAAO,CAAC,cAAc,EAAE,MAAM,EAAE,CAAC;QACnC,WAAW,GAAG,WAAW,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CACrC,OAAO,CAAC,cAAe,CAAC,QAAQ,CAAC,CAAC,CAAC,QAAQ,CAAC,CAC7C,CAAC;IACJ,CAAC;IAED,MAAM,WAAW,GAAoB,EAAE,CAAC;IACxC,IAAI,aAAa,GAAG,CAAC,CAAC;IACtB,IAAI,YAAY,GAAG,CAAC,CAAC;IAErB,KAAK,MAAM,QAAQ,IAAI,WAAW,EAAE,CAAC;QACnC,MAAM,OAAO,GAAG,QAAQ,CAAC,OAAO,EAAE,QAAQ,CAAC,CAAC;QAE5C,qCAAqC;QACrC,MAAM,eAAe,GAAG,WAAW,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,EAAE,CAClD,iBAAiB,CAAC,IAAI,EAAE,OAAO,CAAC,CACjC,CAAC;QAEF,IAAI,eAAe,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;YACjC,YAAY,EAAE,CAAC;YACf,SAAS;QACX,CAAC;QAED,aAAa,EAAE,CAAC;QAEhB,IAAI,CAAC;YACH,MAAM,OAAO,GAAG,MAAM,QAAQ,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;YAClD,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;YAElC,KAAK,MAAM,IAAI,IAAI,eAAe,EAAE,CAAC;gBACnC,MAAM,QAAQ,GAAG,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,OAAO,EAAE,OAAO,EAAE,KAAK,CAAC,CAAC;gBACpE,WAAW,CAAC,IAAI,CAAC,GAAG,QAAQ,CAAC,CAAC;YAChC,CAAC;QACH,CAAC;QAAC,OAAO,KAAc,EAAE,CAAC;YACxB,MAAM,OAAO,GACX,KAAK,YAAY,KAAK,CAAC,CAAC,CAAC,KAAK,CAAC,OAAO,CAAC,CAAC,CAAC,oBAAoB,CAAC;YAChE,WAAW,CAAC,IAAI,CAAC;gBACf,MAAM,EAAE,cAAc;gBACtB,QAAQ,EAAE,iBAAiB;gBAC3B,QAAQ,EAAE,QAAQ;gBAClB,QAAQ,EAAE,SAAS;gBACnB,QAAQ,EAAE,OAAO;gBACjB,OAAO,EAAE,wBAAwB,OAAO,EAAE;gBAC1C,UAAU,EAAE,sCAAsC;aACnD,CAAC,CAAC;QACL,CAAC;IACH,CAAC;IAED,gBAAgB;IAChB,MAAM,UAAU,GAAG,WAAW,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,OAAO,CAAC,CAAC,MAAM,CAAC;IAC5E,MAAM,YAAY,GAAG,WAAW,CAAC,MAAM,CACrC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,SAAS,CAChC,CAAC,MAAM,CAAC;IACT,MAAM,SAAS,GAAG,WAAW,CAAC,MAAM,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,QAAQ,KAAK,MAAM,CAAC,CAAC,MAAM,CAAC;IAE1E,MAAM,kBAAkB,GAAoC,EAAE,CAAC;IAC/D,MAAM,cAAc,GAAoC,EAAE,CAAC;IAE3D,KAAK,MAAM,OAAO,IAAI,WAAW,EAAE,CAAC;QAClC,IAAI,CAAC,kBAAkB,CAAC,OAAO,CAAC,QAAQ,CAAC,EAAE,CAAC;YAC1C,kBAAkB,CAAC,OAAO,CAAC,QAAQ,CAAC,GAAG,EAAE,CAAC;QAC5C,CAAC;QACD,kBAAkB,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QAEnD,IAAI,CAAC,cAAc,CAAC,OAAO,CAAC,QAAQ,CAAC,EAAE,CAAC;YACtC,cAAc,CAAC,OAAO,CAAC,QAAQ,CAAC,GAAG,EAAE,CAAC;QACxC,CAAC;QACD,cAAc,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;IACjD,CAAC;IAED,IAAI,OAA0C,CAAC;IAC/C,IAAI,UAAU,GAAG,CAAC,EAAE,CAAC;QACnB,OAAO,GAAG,MAAM,CAAC;IACnB,CAAC;SAAM,IAAI,YAAY,GAAG,CAAC,EAAE,CAAC;QAC5B,OAAO,GAAG,eAAe,CAAC;IAC5B,CAAC;SAAM,CAAC;QACN,OAAO,GAAG,MAAM,CAAC;IACnB,CAAC;IAED,OAAO;QACL,OAAO;QACP,KAAK,EAAE,OAAO,CAAC,KAAK,IAAI,eAAe;QACvC,UAAU,EAAE,WAAW,CAAC,MAAM;QAC9B,aAAa;QACb,YAAY;QACZ,aAAa,EAAE,WAAW,CAAC,MAAM;QACjC,UAAU;QACV,YAAY;QACZ,SAAS;QACT,kBAAkB;QAClB,cAAc;QACd,QAAQ,EAAE,WAAW;QACrB,YAAY,EAAE,WAAW,CAAC,MAAM;QAChC,UAAU,EAAE,IAAI,IAAI,EAAE,CAAC,WAAW,EAAE;KACrC,CAAC;AACJ,CAAC;AAED,oEAAoE;AAEpE,MAAM,CAAC,KAAK,UAAU,gBAAgB,CACpC,QAAgB,EAChB,OAAe,EACf,OAAgB;IAEhB,MAAM,OAAO,GAAG,QAAQ,CAAC,OAAO,EAAE,QAAQ,CAAC,CAAC;IAC5C,MAAM,OAAO,GAAG,MAAM,QAAQ,CAAC,QAAQ,EAAE,OAAO,CAAC,CAAC;IAClD,MAAM,KAAK,GAAG,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC;IAElC,MAAM,QAAQ,GAAoB,EAAE,CAAC;IAErC,KAAK,MAAM,IAAI,IAAI,OAAO,CAAC,KAAK,EAAE,CAAC;QACjC,IAAI,iBAAiB,CAAC,IAAI,EAAE,OAAO,CAAC,EAAE,CAAC;YACrC,QAAQ,CAAC,IAAI,CAAC,GAAG,SAAS,CAAC,IAAI,EAAE,QAAQ,EAAE,OAAO,EAAE,OAAO,EAAE,KAAK,CAAC,CAAC,CAAC;QACvE,CAAC;IACH,CAAC;IAED,OAAO,QAAQ,CAAC;AAClB,CAAC"}

package/dist/services/rule-loader.d.ts

@@ -0,0 +1,19 @@
+/**
+ * Rule Loader Service
+ *
+ * Loads review rules from JSON config files.
+ * Supports loading from a default bundled ruleset
+ * or from a team's custom rules file.
+ */
+import type { RuleSet } from "../types.js";
+/**
+ * Load rules from a JSON file path.
+ * Falls back to bundled defaults if no path provided.
+ */
+export declare function loadRuleSet(customPath?: string): Promise<RuleSet>;
+/**
+ * Merge multiple rule sets (e.g., base + team overrides).
+ * Later rules with the same ID override earlier ones.
+ */
+export declare function mergeRuleSets(...sets: RuleSet[]): RuleSet;
+//# sourceMappingURL=rule-loader.d.ts.map

package/dist/services/rule-loader.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"rule-loader.d.ts","sourceRoot":"","sources":["../../src/services/rule-loader.ts"],"names":[],"mappings":"AAAA;;;;;;GAMG;AAKH,OAAO,KAAK,EAAE,OAAO,EAAc,MAAM,aAAa,CAAC;AAavD;;;GAGG;AACH,wBAAsB,WAAW,CAC/B,UAAU,CAAC,EAAE,MAAM,GAClB,OAAO,CAAC,OAAO,CAAC,CA8BlB;AAED;;;GAGG;AACH,wBAAgB,aAAa,CAAC,GAAG,IAAI,EAAE,OAAO,EAAE,GAAG,OAAO,CAezD"}