@schematics/angular 8.0.0-rc.4 → 8.0.3

package/application/index.js

@@ -137,6 +137,7 @@ function addAppToWorkspaceFile(options, appDir) {
                     main: `${sourceRoot}/main.ts`,
                     polyfills: `${sourceRoot}/polyfills.ts`,
                     tsConfig: `${projectRoot}tsconfig.app.json`,
+                    aot: !!options.enableIvy,
                     assets: [
                         `${sourceRoot}/favicon.ico`,
                         `${sourceRoot}/assets`,
@@ -203,7 +204,7 @@ function addAppToWorkspaceFile(options, appDir) {
                     scripts: [],
                 },
             },
-            lint: {
+            lint: options.minimal ? undefined : {
                 builder: workspace_models_1.Builders.TsLint,
                 options: {
                     tsConfig: [

package/collection.json

@@ -102,7 +102,7 @@
       "description": "Generate a library project for Angular."
     },
     "webWorker": {
-      "aliases": ["web-worker", "worker"],
+      "aliases": ["web-worker"],
       "factory": "./web-worker",
       "schema": "./web-worker/schema.json",
       "description": "Create a Web Worker."

package/library/files/tsconfig.lib.json.template

@@ -12,6 +12,7 @@
     ]
   },
   "angularCompilerOptions": {
+    "annotateForClosureCompiler": true,
     "skipTemplateCodegen": true,
     "strictMetadataEmit": true,
     "fullTemplateTypeCheck": true,

package/library/index.js

@@ -70,7 +70,12 @@ function addDependenciesToPackageJson() {
             {
                 type: dependencies_1.NodeDependencyType.Dev,
                 name: 'ng-packagr',
-                version: '^5.1.0',
+                version: latest_versions_1.latestVersions.ngPackagr,
+            },
+            {
+                type: dependencies_1.NodeDependencyType.Dev,
+                name: 'tsickle',
+                version: latest_versions_1.latestVersions.tsickle,
             },
             {
                 type: dependencies_1.NodeDependencyType.Default,

package/migrations/update-8/differential-loading.js

@@ -23,38 +23,9 @@ Firefox ESR
 not dead
 not IE 9-11 # For IE 9-11 support, remove 'not'.`;
 function updateES5Projects() {
-    return (host) => {
-        const tsConfigPath = '/tsconfig.json';
-        const compilerOptions = getCompilerOptionsAstObject(host, tsConfigPath);
-        if (!compilerOptions) {
-            return host;
-        }
-        const recorder = host.beginUpdate(tsConfigPath);
-        const scriptTarget = json_utils_1.findPropertyInAstObject(compilerOptions, 'target');
-        if (!scriptTarget) {
-            json_utils_1.insertPropertyInAstObjectInOrder(recorder, compilerOptions, 'target', 'es2015', 4);
-        }
-        else if (scriptTarget.value !== 'es2015') {
-            const { start, end } = scriptTarget;
-            recorder.remove(start.offset, end.offset - start.offset);
-            recorder.insertLeft(start.offset, '"es2015"');
-        }
-        const scriptModule = json_utils_1.findPropertyInAstObject(compilerOptions, 'module');
-        if (!scriptModule) {
-            json_utils_1.insertPropertyInAstObjectInOrder(recorder, compilerOptions, 'module', 'esnext', 4);
-        }
-        else if (scriptModule.value !== 'esnext') {
-            const { start, end } = scriptModule;
-            recorder.remove(start.offset, end.offset - start.offset);
-            recorder.insertLeft(start.offset, '"esnext"');
-        }
-        host.commitUpdate(recorder);
-        return updateProjects;
-    };
-}
-exports.updateES5Projects = updateES5Projects;
-function updateProjects() {
     return (tree) => {
+        // update workspace tsconfig
+        updateTsConfig(tree, '/tsconfig.json');
         const angularConfigContent = tree.read('angular.json') || tree.read('.angular.json');
         if (!angularConfigContent) {
             return;
@@ -84,55 +55,35 @@ function updateProjects() {
                 // Skip projects who's build builder is not build-angular:browser
                 continue;
             }
-            const tsConfigs = [];
             const buildOptionsConfig = architect.build.options;
             if (core_1.isJsonObject(buildOptionsConfig) && typeof buildOptionsConfig.tsConfig === 'string') {
-                tsConfigs.push(buildOptionsConfig.tsConfig);
+                updateTsConfig(tree, buildOptionsConfig.tsConfig);
             }
             const testConfig = architect.test;
             if (core_1.isJsonObject(testConfig)
                 && core_1.isJsonObject(testConfig.options)
                 && typeof testConfig.options.tsConfig === 'string') {
-                tsConfigs.push(testConfig.options.tsConfig);
-            }
-            for (const tsConfig of tsConfigs) {
-                const compilerOptions = getCompilerOptionsAstObject(tree, tsConfig);
-                if (!compilerOptions) {
-                    continue;
-                }
-                const recorder = tree.beginUpdate(tsConfig);
-                json_utils_1.removePropertyInAstObject(recorder, compilerOptions, 'target');
-                json_utils_1.removePropertyInAstObject(recorder, compilerOptions, 'module');
-                tree.commitUpdate(recorder);
+                updateTsConfig(tree, testConfig.options.tsConfig);
             }
             const browserslistPath = core_1.join(core_1.normalize(project.root), 'browserslist');
-            if (typeof project.sourceRoot === 'string') {
-                // Move the CLI 7 style browserlist to root if it's there.
-                const srcBrowsersList = core_1.join(core_1.normalize(project.sourceRoot), 'browserslist');
-                if (tree.exists(srcBrowsersList) && !tree.exists(browserslistPath)) {
-                    // TODO: use rename instead.
-                    // This is a hacky workaround. We should be able to just rename it.
-                    // On unit tests the rename works fine but on real projects it fails with
-                    //     ERROR! browserslist does not exist..
-                    // This seems to happen because we are both renaming and then commiting an update.
-                    // But it's fine if we read/create/delete. There's a bug somewhere.
-                    // tree.rename(srcBrowsersList, browserslistPath);
-                    const content = tree.read(srcBrowsersList);
-                    if (content) {
-                        tree.create(browserslistPath, content);
-                        tree.delete(srcBrowsersList);
-                    }
-                }
+            // Move the CLI 7 style browserlist to root if it's there.
+            const sourceRoot = project.sourceRoot === 'string'
+                ? project.sourceRoot
+                : core_1.join(core_1.normalize(project.root), 'src');
+            const srcBrowsersList = core_1.join(core_1.normalize(sourceRoot), 'browserslist');
+            if (tree.exists(srcBrowsersList)) {
+                tree.rename(srcBrowsersList, browserslistPath);
             }
-            if (!tree.exists(browserslistPath)) {
+            else if (!tree.exists(browserslistPath)) {
                 tree.create(browserslistPath, browserslistContent);
             }
         }
         return tree;
     };
 }
-function getCompilerOptionsAstObject(host, tsConfigPath) {
-    const buffer = host.read(tsConfigPath);
+exports.updateES5Projects = updateES5Projects;
+function updateTsConfig(tree, tsConfigPath) {
+    const buffer = tree.read(tsConfigPath);
     if (!buffer) {
         return;
     }
@@ -140,9 +91,46 @@ function getCompilerOptionsAstObject(host, tsConfigPath) {
     if (tsCfgAst.kind !== 'object') {
         return;
     }
+    const configExtends = json_utils_1.findPropertyInAstObject(tsCfgAst, 'extends');
+    const isExtendedConfig = configExtends && configExtends.kind === 'string';
     const compilerOptions = json_utils_1.findPropertyInAstObject(tsCfgAst, 'compilerOptions');
     if (!compilerOptions || compilerOptions.kind !== 'object') {
         return;
     }
-    return compilerOptions;
+    const recorder = tree.beginUpdate(tsConfigPath);
+    if (isExtendedConfig) {
+        json_utils_1.removePropertyInAstObject(recorder, compilerOptions, 'target');
+        json_utils_1.removePropertyInAstObject(recorder, compilerOptions, 'module');
+        json_utils_1.removePropertyInAstObject(recorder, compilerOptions, 'downlevelIteration');
+    }
+    else {
+        const downlevelIteration = json_utils_1.findPropertyInAstObject(compilerOptions, 'downlevelIteration');
+        if (!downlevelIteration) {
+            json_utils_1.insertPropertyInAstObjectInOrder(recorder, compilerOptions, 'downlevelIteration', true, 4);
+        }
+        else if (!downlevelIteration.value) {
+            const { start, end } = downlevelIteration;
+            recorder.remove(start.offset, end.offset - start.offset);
+            recorder.insertLeft(start.offset, 'true');
+        }
+        const scriptTarget = json_utils_1.findPropertyInAstObject(compilerOptions, 'target');
+        if (!scriptTarget) {
+            json_utils_1.insertPropertyInAstObjectInOrder(recorder, compilerOptions, 'target', 'es2015', 4);
+        }
+        else if (scriptTarget.value !== 'es2015') {
+            const { start, end } = scriptTarget;
+            recorder.remove(start.offset, end.offset - start.offset);
+            recorder.insertLeft(start.offset, '"es2015"');
+        }
+        const scriptModule = json_utils_1.findPropertyInAstObject(compilerOptions, 'module');
+        if (!scriptModule) {
+            json_utils_1.insertPropertyInAstObjectInOrder(recorder, compilerOptions, 'module', 'esnext', 4);
+        }
+        else if (scriptModule.value !== 'esnext') {
+            const { start, end } = scriptModule;
+            recorder.remove(start.offset, end.offset - start.offset);
+            recorder.insertLeft(start.offset, '"esnext"');
+        }
+    }
+    tree.commitUpdate(recorder);
 }

package/migrations/update-8/drop-es6-polyfills.js

@@ -64,11 +64,11 @@ function dropES2015PolyfillsFromFile(polyfillPath) {
         if (!source) {
             return;
         }
-        // normalize line endings to increase hash match chances
-        const content = source.toString().replace(/\r\n|\r/g, '\n');
+        const content = source.toString();
         // Check if file is unmodified, if so then replace and return
         const hash = crypto_1.createHash('md5');
-        hash.update(content);
+        // normalize line endings to increase hash match chances
+        hash.update(content.replace(/\r\n|\r/g, '\n'));
         const digest = hash.digest('hex');
         if (knownPolyfillHashes.includes(digest)) {
             // Replace with new project polyfills file
@@ -84,7 +84,7 @@ function dropES2015PolyfillsFromFile(polyfillPath) {
             // no action required if no mention of core-js
             return;
         }
-        const sourceFile = ts.createSourceFile(polyfillPath, content, ts.ScriptTarget.Latest, true);
+        const sourceFile = ts.createSourceFile(polyfillPath, content.replace(/^\uFEFF/, ''), ts.ScriptTarget.Latest, true);
         const imports = sourceFile.statements
             .filter(s => s.kind === ts.SyntaxKind.ImportDeclaration);
         if (imports.length === 0) {

package/migrations/update-8/index.js

@@ -13,7 +13,7 @@ const codelyzer_5_1 = require("./codelyzer-5");
 const differential_loading_1 = require("./differential-loading");
 const drop_es6_polyfills_1 = require("./drop-es6-polyfills");
 const remove_angular_http_1 = require("./remove-angular-http");
-const update_builders_1 = require("./update-builders");
+const update_dependencies_1 = require("./update-dependencies");
 var update_lazy_module_paths_1 = require("./update-lazy-module-paths");
 exports.updateLazyModulePaths = update_lazy_module_paths_1.updateLazyModulePaths;
 function default_1() {
@@ -23,7 +23,7 @@ function default_1() {
             codelyzer_5_1.updatePackageJson(),
             drop_es6_polyfills_1.dropES2015Polyfills(),
             differential_loading_1.updateES5Projects(),
-            update_builders_1.updateBuilders(),
+            update_dependencies_1.updateDependencies(),
             remove_angular_http_1.removeAngularHttp(),
             (tree, context) => {
                 const packageChanges = tree.actions.some(a => a.path.endsWith('/package.json'));

package/migrations/update-8/update-dependencies.d.ts

@@ -0,0 +1 @@
+export declare function updateDependencies(): (host: import("../../../../angular_devkit/schematics/src/tree/interface").Tree) => void;

package/migrations/update-8/update-dependencies.js

@@ -0,0 +1,31 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+const dependencies_1 = require("../../utility/dependencies");
+const latest_versions_1 = require("../../utility/latest-versions");
+function updateDependencies() {
+    return (host) => {
+        const dependenciesToUpdate = {
+            '@angular-devkit/build-angular': latest_versions_1.latestVersions.DevkitBuildAngular,
+            '@angular-devkit/build-ng-packagr': latest_versions_1.latestVersions.DevkitBuildNgPackagr,
+            '@angular-devkit/build-webpack': latest_versions_1.latestVersions.DevkitBuildWebpack,
+            'zone.js': latest_versions_1.latestVersions.ZoneJs,
+            'tsickle': latest_versions_1.latestVersions.tsickle,
+            'ng-packagr': latest_versions_1.latestVersions.ngPackagr,
+            // FIXME: change to ^2.3.2 as soon as it's released with the pr208 fix
+            'web-animations-js': 'github:angular/web-animations-js#release_pr208',
+        };
+        for (const [name, version] of Object.entries(dependenciesToUpdate)) {
+            const current = dependencies_1.getPackageJsonDependency(host, name);
+            if (!current || current.version === version) {
+                continue;
+            }
+            dependencies_1.addPackageJsonDependency(host, {
+                type: current.type,
+                name,
+                version,
+                overwrite: true,
+            });
+        }
+    };
+}
+exports.updateDependencies = updateDependencies;

package/migrations/update-8/update-lazy-module-paths.js

@@ -8,7 +8,7 @@ function* visit(directory) {
             if (entry) {
                 const content = entry.content;
                 if (content.includes('loadChildren')) {
-                    const source = ts.createSourceFile(entry.path, content.toString(), ts.ScriptTarget.Latest, true);
+                    const source = ts.createSourceFile(entry.path, content.toString().replace(/^\uFEFF/, ''), ts.ScriptTarget.Latest, true);
                     yield source;
                 }
             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@schematics/angular",
-  "version": "8.0.0-rc.4",
+  "version": "8.0.3",
   "description": "Schematics specific to Angular",
   "keywords": [
     "angular",
@@ -14,8 +14,8 @@
   ],
   "schematics": "./collection.json",
   "dependencies": {
-    "@angular-devkit/core": "8.0.0-rc.4",
-    "@angular-devkit/schematics": "8.0.0-rc.4"
+    "@angular-devkit/core": "8.0.3",
+    "@angular-devkit/schematics": "8.0.3"
   },
   "repository": {
     "type": "git",

package/utility/ast-utils.js

@@ -240,8 +240,7 @@ function getDecoratorMetadata(source, identifier, module) {
         .filter(expr => {
         if (expr.expression.kind == ts.SyntaxKind.Identifier) {
             const id = expr.expression;
-            return id.getFullText(source) == identifier
-                && angularImports[id.getFullText(source)] === module;
+            return id.text == identifier && angularImports[id.text] === module;
         }
         else if (expr.expression.kind == ts.SyntaxKind.PropertyAccessExpression) {
             // This covers foo.NgModule when importing * as foo.
@@ -251,7 +250,7 @@ function getDecoratorMetadata(source, identifier, module) {
                 return false;
             }
             const id = paExpr.name.text;
-            const moduleId = paExpr.expression.getText(source);
+            const moduleId = paExpr.expression.text;
             return id === identifier && (angularImports[moduleId + '.'] === module);
         }
         return false;

package/utility/latest-versions.d.ts

@@ -13,4 +13,7 @@ export declare const latestVersions: {
     TsLib: string;
     DevkitBuildAngular: string;
     DevkitBuildNgPackagr: string;
+    DevkitBuildWebpack: string;
+    tsickle: string;
+    ngPackagr: string;
 };

package/utility/latest-versions.js

@@ -9,12 +9,15 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.latestVersions = {
     // These versions should be kept up to date with latest Angular peer dependencies.
-    Angular: '~8.0.0-rc.4',
+    Angular: '~8.0.1',
     RxJs: '~6.4.0',
     ZoneJs: '~0.9.1',
     TypeScript: '~3.4.3',
     TsLib: '^1.9.0',
     // The versions below must be manually updated when making a new devkit release.
-    DevkitBuildAngular: '~0.800.0-rc.4',
-    DevkitBuildNgPackagr: '~0.800.0-rc.4',
+    DevkitBuildAngular: '~0.800.0',
+    DevkitBuildNgPackagr: '~0.800.0',
+    DevkitBuildWebpack: '~0.800.0',
+    tsickle: '^0.35.0',
+    ngPackagr: '^5.1.0',
 };

package/web-worker/index.js

@@ -49,9 +49,11 @@ function addSnippet(options) {
         if (options.path === undefined) {
             return;
         }
+        const fileRegExp = new RegExp(`^${options.name}.*\.ts`);
         const siblingModules = host.getDir(options.path).subfiles
-            // Find all files that start with the same name, are ts files, and aren't spec files.
-            .filter(f => f.startsWith(options.name) && f.endsWith('.ts') && !f.endsWith('spec.ts'))
+            // Find all files that start with the same name, are ts files,
+            // and aren't spec or module files.
+            .filter(f => fileRegExp.test(f) && !/(module|spec)\.ts$/.test(f))
             // Sort alphabetically for consistency.
             .sort();
         if (siblingModules.length === 0) {

package/workspace/files/tsconfig.json.template

@@ -5,10 +5,11 @@
     "outDir": "./dist/out-tsc",
     "sourceMap": true,
     "declaration": false,
-    "module": "esnext",
-    "moduleResolution": "node",
+    "downlevelIteration": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
+    "module": "esnext",
+    "moduleResolution": "node",
     "importHelpers": true,
     "target": "es2015",
     "typeRoots": [

package/migrations/update-8/update-builders.d.ts

@@ -1 +0,0 @@
-export declare function updateBuilders(): (host: import("../../../../angular_devkit/schematics/src/tree/interface").Tree) => void;

package/migrations/update-8/update-builders.js

@@ -1,36 +0,0 @@
-"use strict";
-Object.defineProperty(exports, "__esModule", { value: true });
-const dependencies_1 = require("../../utility/dependencies");
-const latest_versions_1 = require("../../utility/latest-versions");
-function updateBuilders() {
-    return (host) => {
-        let current = dependencies_1.getPackageJsonDependency(host, '@angular-devkit/build-angular');
-        if (current && current.version !== latest_versions_1.latestVersions.DevkitBuildAngular) {
-            dependencies_1.addPackageJsonDependency(host, {
-                type: current.type,
-                name: '@angular-devkit/build-angular',
-                version: latest_versions_1.latestVersions.DevkitBuildAngular,
-                overwrite: true,
-            });
-        }
-        current = dependencies_1.getPackageJsonDependency(host, '@angular-devkit/build-ng-packagr');
-        if (current && current.version !== latest_versions_1.latestVersions.DevkitBuildNgPackagr) {
-            dependencies_1.addPackageJsonDependency(host, {
-                type: current.type,
-                name: '@angular-devkit/build-ng-packagr',
-                version: latest_versions_1.latestVersions.DevkitBuildNgPackagr,
-                overwrite: true,
-            });
-        }
-        current = dependencies_1.getPackageJsonDependency(host, 'zone.js');
-        if (current && current.version !== latest_versions_1.latestVersions.ZoneJs) {
-            dependencies_1.addPackageJsonDependency(host, {
-                type: current.type,
-                name: 'zone.js',
-                version: latest_versions_1.latestVersions.ZoneJs,
-                overwrite: true,
-            });
-        }
-    };
-}
-exports.updateBuilders = updateBuilders;