@sceneview-sdk/react-native 4.28.0 → 4.29.0

package/android/build.gradle.kts

@@ -64,4 +64,13 @@ dependencies {
     implementation("androidx.compose.ui:ui")
     implementation("androidx.compose.foundation:foundation")
     implementation("androidx.compose.runtime:runtime")
+
+    // Local JVM unit tests (#3062). Until this existed, the bridge's pure-Kotlin
+    // derivations — the tap payload's `nodeName` above all — were exercised by
+    // NOTHING: `tools/rn-android-compile` is a compile gate, and the RN demo has
+    // never been built end-to-end. A string derivation that silently reports the
+    // wrong value is exactly the class a compiler cannot catch, and #3071 was one.
+    // These run on the JVM with no device and no emulator, in the same standalone
+    // harness that already compiles the module.
+    testImplementation("junit:junit:4.13.2")
 }

package/android/src/main/java/io/github/sceneview/reactnative/SceneViewManager.kt

@@ -404,13 +404,62 @@ data class ModelNodeData(
      * `robot.glb?sig=SIG&v=1` — a CDN signature leaking into a payload that
      * apps routinely put in a label or an analytics event.
      *
+     * [urlPathOf] then drops the authority, which carries the other half of the
+     * same exposure: the last `/`-separated segment of a path-less URL IS the
+     * authority, and an authority may carry userinfo, so
+     * `https://user:pa55w0rd@cdn.example` would report `user:pa55w0rd@cdn`
+     * (#3071).
+     *
      * `null` for a path with no usable base name, so the payload stays
      * `nodeName: null` rather than an empty string.
      */
-    fun nodeName(): String? =
-        src.substringBefore('?').substringBefore('#')
-            .substringAfterLast('/').substringBeforeLast('.')
-            .takeIf { it.isNotEmpty() }
+    fun nodeName(): String? = modelNodeName(src)
+}
+
+/**
+ * [ModelNodeData.nodeName]'s derivation, as a top-level function.
+ *
+ * Split out so it can be unit-tested without constructing a [ModelNodeData]:
+ * that data class defaults `position`/`rotation` to `Position`/`Rotation` from
+ * the **published** SceneView artifacts, which are compiled for JVM 21, while
+ * this module targets JVM 17 and its CI gate runs on a JDK 17. Compiling
+ * against a newer class file is fine; *loading* one is not, so instantiating
+ * the data class in a JVM unit test throws `UnsupportedClassVersionError`.
+ *
+ * That mismatch is harmless on a device — D8 re-compiles everything to DEX and
+ * the class-file version stops existing — so the fix belongs in the test's
+ * reach, not in the module's or the gate's toolchain.
+ *
+ * This also puts the derivation at the same level as the Flutter bridge's
+ * `tapNodeName`, which the shared case table already assumed.
+ */
+internal fun modelNodeName(src: String): String? =
+    urlPathOf(src.substringBefore('?').substringBefore('#'))
+        .substringAfterLast('/').substringBeforeLast('.')
+        .takeIf { it.isNotEmpty() }
+
+/**
+ * The path part of [source] when it is a URL, [source] unchanged otherwise.
+ *
+ * Returns `""` for a path-less URL: there is no file name in
+ * `https://cdn.example` to report, and `null` is the honest payload.
+ *
+ * Mirrored verbatim in the Flutter bridge's `SceneViewPlugin.kt`. The two
+ * bridges are separately published packages with no shared Kotlin, so the
+ * duplication is the seam, not an oversight — both sides are pinned by their
+ * own unit tests.
+ */
+internal fun urlPathOf(source: String): String {
+    val schemeEnd = source.indexOf("://")
+    if (schemeEnd < 0) return source
+    // A "://" that appears after a slash is not a scheme delimiter — the string
+    // is already a path (`models/odd://name.glb`) and cutting at it would drop
+    // real path segments.
+    val firstSlash = source.indexOf('/')
+    if (firstSlash in 0 until schemeEnd) return source
+    val afterScheme = source.substring(schemeEnd + 3)
+    val pathStart = afterScheme.indexOf('/')
+    return if (pathStart < 0) "" else afterScheme.substring(pathStart)
 }
 
 data class GeometryNodeData(

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sceneview-sdk/react-native",
-  "version": "4.28.0",
+  "version": "4.29.0",
   "description": "React Native bindings for SceneView — 3D and AR scenes powered by Filament (Android) and RealityKit (iOS)",
   "main": "lib/commonjs/index",
   "module": "lib/module/index",
@@ -13,7 +13,8 @@
     "android",
     "ios",
     "react-native-sceneview.podspec",
-    "!**/__tests__"
+    "!**/__tests__",
+    "!android/src/test"
   ],
   "scripts": {
     "typescript": "tsc --noEmit",

package/react-native-sceneview.podspec

@@ -48,7 +48,7 @@ Pod::Spec.new do |s|
   #
   # Loose `~> 4.27` rather than `= s.version`: an app pinned to an older
   # SceneViewSwift still resolves, mirroring `flutter_sceneview.podspec`.
-  s.dependency "SceneViewSwift", "~> 4.28"
+  s.dependency "SceneViewSwift", "~> 4.29"
 
   s.swift_version = "5.9"
 end