@scayle/storefront-core 7.59.1 → 7.59.2

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # @scayle/storefront-core
 
+## 7.59.2
+
+### Patch Changes
+
+- Resolved a memory leak within the `timeout` util where `setTimeout` might not have been garbage collected if the promise had been resolved/rejected before the timeout itself
+
 ## 7.59.1
 
 ### Patch Changes

package/dist/rpc/methods/checkout/checkout.cjs

@@ -31,7 +31,7 @@ const getCheckoutToken = exports.getCheckoutToken = async function getCheckoutTo
     carrier,
     basketId: context.basketKey,
     campaignKey: context.campaignKey
-  }).setIssuedAt(now).setNotBefore(now).setExpirationTime("1h").setIssuer(`${"@scayle/storefront-core"}@${"7.59.0"}`).setProtectedHeader({
+  }).setIssuedAt(now).setNotBefore(now).setExpirationTime("1h").setIssuer(`${"@scayle/storefront-core"}@${"7.59.2"}`).setProtectedHeader({
     alg: "HS256",
     typ: "JWT"
   }).sign(secret);

package/dist/rpc/methods/checkout/checkout.mjs

@@ -21,7 +21,7 @@ export const getCheckoutToken = async function getCheckoutToken2(jwtPayload = {}
     carrier,
     basketId: context.basketKey,
     campaignKey: context.campaignKey
-  }).setIssuedAt(now).setNotBefore(now).setExpirationTime("1h").setIssuer(`${"@scayle/storefront-core"}@${"7.59.0"}`).setProtectedHeader({ alg: "HS256", typ: "JWT" }).sign(secret);
+  }).setIssuedAt(now).setNotBefore(now).setExpirationTime("1h").setIssuer(`${"@scayle/storefront-core"}@${"7.59.2"}`).setProtectedHeader({ alg: "HS256", typ: "JWT" }).sign(secret);
   return {
     accessToken: refreshedAccessToken,
     checkoutJwt

package/dist/utils/timeout.cjs

@@ -9,9 +9,10 @@ const wait = ms => {
 };
 exports.wait = wait;
 const timeout = (ms, promise) => {
-  const breaker = new Promise((_resolve, reject) => {
-    setTimeout(() => reject(new Error("timeout")), ms);
-  });
-  return Promise.race([promise, breaker]);
+  let pendingTimeout;
+  return new Promise((resolve, reject) => {
+    pendingTimeout = setTimeout(() => reject(new Error("timeout")), ms);
+    promise.then(resolve, reject);
+  }).finally(() => clearTimeout(pendingTimeout));
 };
 exports.timeout = timeout;

package/dist/utils/timeout.d.ts

@@ -1,2 +1,2 @@
 export declare const wait: (ms: number) => Promise<unknown>;
-export declare const timeout: (ms: number, promise: Promise<any>) => Promise<any>;
+export declare const timeout: <T>(ms: number, promise: Promise<T>) => Promise<T>;

package/dist/utils/timeout.mjs

@@ -2,8 +2,9 @@ export const wait = (ms) => {
   return new Promise((resolve) => setTimeout(resolve, ms));
 };
 export const timeout = (ms, promise) => {
-  const breaker = new Promise((_resolve, reject) => {
-    setTimeout(() => reject(new Error("timeout")), ms);
-  });
-  return Promise.race([promise, breaker]);
+  let pendingTimeout;
+  return new Promise((resolve, reject) => {
+    pendingTimeout = setTimeout(() => reject(new Error("timeout")), ms);
+    promise.then(resolve, reject);
+  }).finally(() => clearTimeout(pendingTimeout));
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@scayle/storefront-core",
-  "version": "7.59.1",
+  "version": "7.59.2",
   "description": "Collection of essential utilities to work with the Storefront API",
   "author": "SCAYLE Commerce Engine",
   "license": "MIT",
@@ -74,9 +74,9 @@
     "@types/crypto-js": "4.2.2",
     "@types/node": "20.14.10",
     "@types/webpack-env": "1.18.5",
-    "@vitest/coverage-v8": "2.0.2",
+    "@vitest/coverage-v8": "2.0.3",
     "dprint": "0.47.2",
-    "eslint": "9.6.0",
+    "eslint": "9.7.0",
     "eslint-formatter-gitlab": "5.1.0",
     "publint": "0.2.8",
     "rimraf": "6.0.1",
@@ -84,7 +84,7 @@
     "typescript": "5.5.3",
     "unbuild": "2.0.0",
     "unstorage": "1.10.2",
-    "vitest": "2.0.2"
+    "vitest": "2.0.3"
   },
   "optionalDependencies": {
     "redis": "4"