@scandipwa/magento-scripts 1.13.2 → 1.13.3

package/lib/commands/execute.js

@@ -6,33 +6,46 @@ const executeInContainer = require('../tasks/execute');
  * @param {import('yargs')} yargs
  */
 module.exports = (yargs) => {
-    yargs.command('exec <container name> [commands...]', 'Execute command in docker container', () => {}, async (argv) => {
-        const containers = (await docker).getContainers();
-        const services = Object.keys(containers);
+    yargs.command(
+        'exec <container name> [commands...]',
+        'Execute command in docker container',
+        (yargs) => {
+            yargs.usage(`Usage: npm run exec <container name> [commands...]
 
-        if (services.includes(argv.containername) || services.some((service) => service.includes(argv.containername))) {
-            const container = containers[argv.containername]
-                ? containers[argv.containername]
-                : Object.entries(containers).find(([key]) => key.includes(argv.containername))[1];
+Available containers:
+- mysql
+- nginx
+- redis
+- elasticsearch`);
+        },
+        async (argv) => {
+            const containers = (await docker).getContainers();
+            const services = Object.keys(containers);
 
-            if (argv.commands.length === 0) {
+            if (services.includes(argv.containername) || services.some((service) => service.includes(argv.containername))) {
+                const container = containers[argv.containername]
+                    ? containers[argv.containername]
+                    : Object.entries(containers).find(([key]) => key.includes(argv.containername))[1];
+
+                if (argv.commands.length === 0) {
                 // if we have default connect command then use it
-                if (container.connectCommand) {
+                    if (container.connectCommand) {
                     // eslint-disable-next-line no-param-reassign
-                    argv.commands = container.connectCommand;
-                } else {
+                        argv.commands = container.connectCommand;
+                    } else {
                     // otherwise fall back to bash (if it exists inside container)
-                    argv.commands.push('bash');
+                        argv.commands.push('bash');
+                    }
                 }
+                await executeInContainer({
+                    containerName: container.name,
+                    commands: argv.commands
+                });
+
+                return;
             }
-            await executeInContainer({
-                containerName: container.name,
-                commands: argv.commands
-            });
 
-            return;
+            logger.error(`No container found "${argv.containername}"`);
         }
-
-        logger.error(`No container found "${argv.containername}"`);
-    });
+    );
 };

package/lib/commands/logs.js

@@ -10,6 +10,18 @@ module.exports = (yargs) => {
         'logs <scope>',
         'Display application logs.',
         (yargs) => {
+            yargs.usage(`Usage: npm run logs <scope>
+
+Available scopes:
+- magento
+- mysql
+- redis
+- nginx
+- elasticsearch
+
+And you can use name matching:
+npm run logs ma (will match magento)
+npm run logs re (will match redis)`);
             yargs.option(
                 'tail',
                 {
@@ -91,7 +103,7 @@ module.exports = (yargs) => {
 
                 return;
             }
-
+            console.log(argv);
             logger.error(`No service found "${argv.scope}"`);
             process.exit(1);
         }

package/lib/commands/start.js

@@ -95,12 +95,14 @@ module.exports = (yargs) => {
                     systemConfiguration: { analytics }
                 } = ctx;
 
+                const webLocation = `${ssl.enabled ? 'https' : 'http'}://${host}${ssl.enabled || ports.app === 80 ? '' : `:${ports.app}`}/`;
+
                 const block = new ConsoleBlock();
                 block
                     .addHeader('Magento 2')
                     .addEmptyLine()
-                    .addLine(`Web location: ${logger.style.link(`${ssl.enabled ? 'https' : 'http'}://${host}${ports.app === 80 ? '' : `:${ports.app}`}/`)}`)
-                    .addLine(`Magento Admin panel location: ${logger.style.link(`${ssl.enabled ? 'https' : 'http'}://${host}${ports.app === 80 ? '' : `:${ports.app}`}/${magentoConfiguration.adminuri}`)}`)
+                    .addLine(`Web location: ${logger.style.link(webLocation)}`)
+                    .addLine(`Magento Admin panel location: ${logger.style.link(`${webLocation}${magentoConfiguration.adminuri}`)}`)
                     .addLine(`Magento Admin panel credentials: ${logger.style.misc(magentoConfiguration.user)} - ${logger.style.misc(magentoConfiguration.password)}`);
 
                 const themes = await getCSAThemes();

package/lib/config/dependencies-for-platforms.js

@@ -92,7 +92,8 @@ const dependenciesForPlatforms = {
             'php-cli',
             'php-bz2',
             'pkg-config',
-            'autoconf'
+            'autoconf',
+            'cmake'
         ],
         installCommand: (deps) => `sudo apt-get install ${deps} -y`
     }

package/lib/tasks/cleanup.js

@@ -5,6 +5,7 @@ const {
     uninstallMagento,
     removeMagento
 } = require('./magento');
+const getMagentoVersionConfig = require('../config/get-magento-version-config');
 const { stopPhpFpm } = require('./php-fpm');
 const getProjectConfiguration = require('../config/get-project-configuration');
 const checkConfigurationFile = require('../config/check-configuration-file');
@@ -16,6 +17,7 @@ const cleanup = () => ({
     title: 'Cleanup project',
     task: (ctx, task) => task.newListr([
         checkConfigurationFile(),
+        getMagentoVersionConfig(),
         getProjectConfiguration(),
         stopPhpFpm(),
         stopServices(),

package/lib/tasks/magento/remove-magento.js

@@ -37,29 +37,27 @@ const magentoFiles = [
  */
 const removeMagento = () => ({
     title: 'Remove magento application folder',
-    task: async (ctx, task) => {
+    skip: async (ctx) => {
         const { config: { baseConfig } } = ctx;
         const appPathExists = await pathExists(baseConfig.magentoDir);
 
-        if (appPathExists && ctx.force) {
-            await Promise.all(magentoFiles.map(async (fileName) => {
-                const filePath = path.join(baseConfig.magentoDir, fileName);
-                const fileExists = await pathExists(filePath);
-                if (!fileExists) {
-                    return;
-                }
-                const file = await fs.promises.stat(filePath);
-                if (file.isFile()) {
-                    await fs.promises.unlink(filePath);
-                } else if (file.isDirectory()) {
-                    await fs.promises.rmdir(filePath, { recursive: true });
-                }
-            }));
-
-            return;
-        }
-
-        task.skip();
+        return !(appPathExists && ctx.force);
+    },
+    task: async (ctx) => {
+        const { config: { baseConfig } } = ctx;
+        await Promise.all(magentoFiles.map(async (fileName) => {
+            const filePath = path.join(baseConfig.magentoDir, fileName);
+            const fileExists = await pathExists(filePath);
+            if (!fileExists) {
+                return;
+            }
+            const file = await fs.promises.stat(filePath);
+            if (file.isFile()) {
+                await fs.promises.unlink(filePath);
+            } else if (file.isDirectory()) {
+                await fs.promises.rmdir(filePath, { recursive: true });
+            }
+        }));
     }
 });
 

package/lib/tasks/magento/setup-magento/set-base-url.js

@@ -11,11 +11,11 @@ module.exports = () => ({
             config: { overridenConfiguration: { host, ssl } },
             mysqlConnection
         } = ctx;
+        const enableSecureFrontend = ssl.enabled ? '1' : '0';
         const location = `${host}${ ports.app !== 80 ? `:${ports.app}` : '' }/`;
+        const secureLocation = `${host}/`; // SSL will work only on port 443, so you cannot run multiple projects with SSL at the same time.
         const httpUrl = `http://${location}`;
-        const httpsUrl = `https://${location}`;
-
-        const enableSecureFrontend = ssl.enabled ? '1' : '0';
+        const httpsUrl = `https://${secureLocation}`;
 
         await updateTableValues('core_config_data', [
             { path: 'web/unsecure/base_url', value: httpUrl },

package/lib/tasks/requirements/dependency/ubuntu.js

@@ -1,9 +1,31 @@
+const logger = require('@scandipwa/scandipwa-dev-utils/logger');
+const os = require('os');
 const dependenciesForPlatforms = require('../../../config/dependencies-for-platforms');
-const { execAsyncSpawn } = require('../../../util/exec-async-command');
+const { execAsyncSpawn, execCommandTask } = require('../../../util/exec-async-command');
 const installDependenciesTask = require('../../../util/install-dependencies-task');
 
 const pkgRegex = /^(\S+)\/\S+\s(\S+)\s\S+\s\S+$/i;
 
+const updateSystem = () => ({
+    title: 'Updating Ubuntu system',
+    task: async (ctx, task) => {
+        task.output = 'Enter your sudo password!';
+        task.output = logger.style.command(`>[sudo] password for ${ os.userInfo().username }:`);
+
+        return task.newListr(
+            execCommandTask('sudo apt update', {
+                callback: (t) => {
+                    task.output = t;
+                },
+                pipeInput: true
+            })
+        );
+    },
+    options: {
+        bottomBar: 10
+    }
+});
+
 /**
  * @type {() => import('listr2').ListrTask<import('../../../../typings/context').ListrContext>}
  */
@@ -28,6 +50,23 @@ const ubuntuDependenciesCheck = () => ({
             .map((dep) => (Array.isArray(dep) ? dep[0] : dep));
 
         if (dependenciesToInstall.length > 0) {
+            const runSystemUpdate = await task.prompt({
+                type: 'Confirm',
+                message: `Would you like to run ${logger.style.command('apt update')} before installing missing ${dependenciesToInstall.length} dependenc${dependenciesToInstall.length > 1 ? 'ies' : 'y'}?`
+            });
+
+            if (runSystemUpdate) {
+                return task.newListr([
+                    updateSystem(),
+                    installDependenciesTask({
+                        platform: 'Ubuntu',
+                        dependenciesToInstall
+                    })
+                ], {
+                    concurrent: false
+                });
+            }
+
             return task.newListr(
                 installDependenciesTask({
                     platform: 'Ubuntu',

package/lib/tasks/start.js

@@ -174,7 +174,7 @@ const start = () => ({
                 title: 'Opening browser',
                 skip: (ctx) => ctx.noOpen,
                 task: ({ ports, config: { overridenConfiguration: { host, ssl } } }) => {
-                    openBrowser(`${ssl.enabled ? 'https' : 'http'}://${host}${ports.app === 80 ? '' : `:${ports.app}`}/`);
+                    openBrowser(`${ssl.enabled ? 'https' : 'http'}://${host}${ssl.enabled || ports.app === 80 ? '' : `:${ports.app}`}/`);
                 },
                 options: {
                     showTimer: false

package/package.json

@@ -3,7 +3,7 @@
     "description": "Scripts and configuration used by CMA.",
     "homepage": "https://docs.create-magento-app.com/",
     "repository": "github:scandipwa/create-magento-app",
-    "version": "1.13.2",
+    "version": "1.13.3",
     "main": "./index.js",
     "types": "./typings/index.d.ts",
     "license": "OSL-3.0",
@@ -42,5 +42,5 @@
     "publishConfig": {
         "access": "public"
     },
-    "gitHead": "358a4bdd57aa7b87431915e27a9f063f93f7c644"
+    "gitHead": "b03f5e0d8d7899f8d217b5eda38e7daabc63dccd"
 }