@scallop-io/sui-scallop-sdk 0.46.45 → 0.46.47

package/dist/types/builder/spool.d.ts

@@ -14,7 +14,7 @@ export type SpoolNormalMethods = {
 };
 export type SpoolQuickMethods = {
     stakeQuick(amountOrMarketCoin: SuiObjectArg | number, stakeMarketCoinName: SupportStakeMarketCoins, stakeAccountId?: SuiAddressArg): Promise<void>;
-    unstakeQuick(amount: number, stakeMarketCoinName: SupportStakeMarketCoins, stakeAccountId?: SuiAddressArg): Promise<TransactionResult>;
+    unstakeQuick(amount: number, stakeMarketCoinName: SupportStakeMarketCoins, stakeAccountId?: SuiAddressArg): Promise<TransactionResult | undefined>;
     claimQuick(stakeMarketCoinName: SupportStakeMarketCoins, stakeAccountId?: SuiAddressArg): Promise<TransactionResult[]>;
 };
 export type SuiTxBlockWithSpoolNormalMethods = SuiKitTxBlock & SuiTxBlockWithSCoin & SpoolNormalMethods;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@scallop-io/sui-scallop-sdk",
-  "version": "0.46.45",
+  "version": "0.46.47",
   "description": "Typescript sdk for interacting with Scallop contract on SUI",
   "keywords": [
     "sui",

package/src/builders/spoolBuilder.ts

@@ -273,26 +273,28 @@ const generateSpoolQuickMethod: GenerateSpoolQuickMethod = ({
         if (amount === 0) break;
       }
 
-      const mergedSCoin = sCoins[0];
-      if (sCoins.length > 1) {
-        txBlock.mergeCoins(mergedSCoin, sCoins.slice(1));
-      }
+      if (sCoins.length > 0) {
+        const mergedSCoin = sCoins[0];
 
-      // check for existing sCoins
-      try {
-        const existingCoins = await builder.utils.selectCoins(
-          Number.MAX_SAFE_INTEGER,
-          builder.utils.parseSCoinType(stakeMarketCoinName),
-          requireSender(txBlock)
-        );
+        if (sCoins.length > 1) {
+          txBlock.mergeCoins(mergedSCoin, sCoins.slice(1));
+        }
+        // check for existing sCoins
+        try {
+          const existingCoins = await builder.utils.selectCoins(
+            Number.MAX_SAFE_INTEGER,
+            builder.utils.parseSCoinType(stakeMarketCoinName),
+            requireSender(txBlock)
+          );
 
-        if (existingCoins.length > 0) {
-          txBlock.mergeCoins(mergedSCoin, existingCoins);
+          if (existingCoins.length > 0) {
+            txBlock.mergeCoins(mergedSCoin, existingCoins);
+          }
+        } catch (e) {
+          // ignore
         }
-      } catch (e) {
-        // ignore
+        return mergedSCoin;
       }
-      return mergedSCoin;
     },
     claimQuick: async (stakeMarketCoinName, stakeAccountId) => {
       const stakeAccountIds = await requireStakeAccountIds(

package/src/models/scallopClient.ts

@@ -742,12 +742,12 @@ export class ScallopClient {
     const sender = walletAddress || this.walletAddress;
     txBlock.setSender(sender);
 
-    const marketCoins = await txBlock.unstakeQuick(
+    const marketCoin = await txBlock.unstakeQuick(
       amount,
       stakeMarketCoinName,
       stakeAccountId
     );
-    txBlock.transferObjects(marketCoins, sender);
+    txBlock.transferObjects([marketCoin], sender);
 
     if (sign) {
       return (await this.suiKit.signAndSendTxn(
@@ -790,20 +790,17 @@ export class ScallopClient {
     const sender = walletAddress || this.walletAddress;
     txBlock.setSender(sender);
 
-    const stakeMarketCoins = await txBlock.unstakeQuick(
+    const stakeMarketCoin = await txBlock.unstakeQuick(
       amount,
       stakeMarketCoinName,
       stakeAccountId
     );
-
-    const coins = [];
-    for (const stakeMarketCoin of stakeMarketCoins) {
-      const stakeCoinName =
-        this.utils.parseCoinName<SupportStakeCoins>(stakeMarketCoinName);
+    const stakeCoinName =
+      this.utils.parseCoinName<SupportStakeCoins>(stakeMarketCoinName);
+    if (stakeMarketCoin) {
       const coin = txBlock.withdraw(stakeMarketCoin, stakeCoinName);
-      coins.push(coin);
+      txBlock.transferObjects([coin], sender);
     }
-    txBlock.transferObjects(coins, sender);
 
     if (sign) {
       return (await this.suiKit.signAndSendTxn(
@@ -980,6 +977,7 @@ export class ScallopClient {
          * First check marketCoin inside mini wallet
          * Then check stakedMarketCoin inside spool
          */
+        const sCoins: SuiObjectArg[] = [];
         let toDestroyMarketCoin: SuiObjectArg | undefined;
 
         // check market coin in mini wallet
@@ -1003,26 +1001,6 @@ export class ScallopClient {
             throw e;
         }
 
-        // check for staked market coin in spool
-        if (SUPPORT_SPOOLS.includes(sCoinName as SupportStakeMarketCoins)) {
-          try {
-            const stakedMarketCoin = await txBlock.unstakeQuick(
-              Number.MAX_SAFE_INTEGER,
-              sCoinName as SupportStakeMarketCoins
-            );
-            // merge with takeMarketCoin
-            if (toDestroyMarketCoin) {
-              txBlock.mergeCoins(toDestroyMarketCoin, [stakedMarketCoin]);
-            } else {
-              toDestroyMarketCoin = stakedMarketCoin;
-            }
-          } catch (e: any) {
-            // ignore
-            const errMsg = e.toString();
-            if (!errMsg.includes('No stake account found')) throw e;
-          }
-        }
-
         // if market coin found, mint sCoin
         if (toDestroyMarketCoin) {
           // mint new sCoin
@@ -1051,7 +1029,33 @@ export class ScallopClient {
             if (!errMsg.includes('No valid coins found for the transaction'))
               throw e;
           }
-          toTransfer.push(sCoin);
+          sCoins.push(sCoin);
+        }
+
+        // check for staked market coin in spool
+        if (SUPPORT_SPOOLS.includes(sCoinName as SupportStakeMarketCoins)) {
+          try {
+            const sCoin = await txBlock.unstakeQuick(
+              Number.MAX_SAFE_INTEGER,
+              sCoinName as SupportStakeMarketCoins
+            );
+            if (sCoin) {
+              sCoins.push(sCoin);
+            }
+          } catch (e: any) {
+            // ignore
+            const errMsg = e.toString();
+            if (!errMsg.includes('No stake account found')) throw e;
+          }
+        }
+
+        if (sCoins.length > 0) {
+          const mergedSCoin = sCoins[0];
+          if (sCoins.length > 1) {
+            txBlock.mergeCoins(mergedSCoin, sCoins.slice(1));
+          }
+
+          toTransfer.push(mergedSCoin);
         }
       })
     );

package/src/types/builder/spool.ts

@@ -43,7 +43,7 @@ export type SpoolQuickMethods = {
     amount: number,
     stakeMarketCoinName: SupportStakeMarketCoins,
     stakeAccountId?: SuiAddressArg
-  ): Promise<TransactionResult>;
+  ): Promise<TransactionResult | undefined>;
   claimQuick(
     stakeMarketCoinName: SupportStakeMarketCoins,
     stakeAccountId?: SuiAddressArg