@scality/data-browser-library 1.1.9 → 1.1.11

package/dist/test/utils/errorHandling.test.js

@@ -117,6 +117,18 @@ describe('EnhancedS3Error', ()=>{
             expect(TestEnhancedErrors.unknown().shouldRetry()).toBe(false);
         });
     });
+    describe('getUserMessage', ()=>{
+        test('returns permission message for AUTHORIZATION errors', ()=>{
+            expect(TestEnhancedErrors.auth().getUserMessage('save the bucket policy')).toBe("You don't have permission to save the bucket policy. Contact your administrator.");
+        });
+        test('returns original message for non-authorization errors', ()=>{
+            expect(TestEnhancedErrors.server().getUserMessage('save tags')).toBe('Server error');
+        });
+        test('returns fallback when message is empty', ()=>{
+            const error = new EnhancedS3Error('', 'EmptyError', ErrorCategory.SERVER_ERROR, new Error());
+            expect(error.getUserMessage('save tags')).toBe('Failed to save tags');
+        });
+    });
 });
 describe('Type Guards', ()=>{
     describe('isS3ServiceException', ()=>{
@@ -272,39 +284,15 @@ describe('createS3Error', ()=>{
     });
 });
 describe('createS3OperationError', ()=>{
-    test('message modification scenarios', ()=>{
-        const testCases = [
-            {
-                name: 'preserves existing operation in message',
-                error: new Error('ListObjectsV2 failed: Access denied'),
-                operation: 'ListObjectsV2',
-                bucket: TEST_CONSTANTS.BUCKET,
-                expectedMessage: 'ListObjectsV2 failed: Access denied'
-            },
-            {
-                name: 'enhances message with operation context',
-                error: new Error(TEST_CONSTANTS.MESSAGES.ACCESS_DENIED),
-                operation: 'GetObject',
-                bucket: TEST_CONSTANTS.BUCKET,
-                key: TEST_CONSTANTS.KEY,
-                expectedMessage: `GetObject failed for bucket '${TEST_CONSTANTS.BUCKET}', key '${TEST_CONSTANTS.KEY}': ${TEST_CONSTANTS.MESSAGES.ACCESS_DENIED}`
-            },
-            {
-                name: 'handles operation without bucket',
-                error: new Error(TEST_CONSTANTS.MESSAGES.SERVICE_UNAVAILABLE),
-                operation: 'ListBuckets',
-                expectedMessage: `ListBuckets failed: ${TEST_CONSTANTS.MESSAGES.SERVICE_UNAVAILABLE}`
-            }
-        ];
-        testCases.forEach(({ error, operation, bucket, key, expectedMessage })=>{
-            const result = createS3OperationError(error, operation, bucket, key);
-            expect(result.message).toBe(expectedMessage);
-            expect(result.context).toEqual({
-                operation,
-                bucketName: bucket || void 0,
-                objectKey: key || void 0,
-                timestamp: expect.any(String)
-            });
+    test('preserves original error message without operationLabel', ()=>{
+        const error = new Error(TEST_CONSTANTS.MESSAGES.ACCESS_DENIED);
+        const result = createS3OperationError(error, 'GetObject', TEST_CONSTANTS.BUCKET, TEST_CONSTANTS.KEY);
+        expect(result.message).toBe(TEST_CONSTANTS.MESSAGES.ACCESS_DENIED);
+        expect(result.context).toEqual({
+            operation: 'GetObject',
+            bucketName: TEST_CONSTANTS.BUCKET,
+            objectKey: TEST_CONSTANTS.KEY,
+            timestamp: expect.any(String)
         });
     });
     test('preserves all error properties', ()=>{
@@ -411,6 +399,30 @@ describe('isNotFoundError', ()=>{
         expect(result).toBe(false);
     });
 });
+describe('createS3OperationError with operationLabel', ()=>{
+    test('embeds permission message for 403 errors', ()=>{
+        const error = TestErrors.accessDenied();
+        const result = createS3OperationError(error, 'PutBucketPolicy', 'my-bucket', void 0, 'save the bucket policy');
+        expect(result.message).toBe("You don't have permission to save the bucket policy. Contact your administrator.");
+    });
+    test('preserves original message for non-403 errors', ()=>{
+        const error = TestErrors.internalError();
+        const result = createS3OperationError(error, 'PutBucketPolicy', 'my-bucket', void 0, 'save the bucket policy');
+        expect(result.message).toBe('Internal error');
+    });
+    test('uses fallback when error has no message', ()=>{
+        const error = new Error('');
+        const result = createS3OperationError(error, 'PutBucketPolicy', 'my-bucket', void 0, 'save the bucket policy');
+        expect(result.message).toBe('Failed to save the bucket policy');
+    });
+    test('preserves category when double-wrapping an EnhancedS3Error', ()=>{
+        const inner = createS3OperationError(TestErrors.accessDenied(), 'GeneratePresignedDownload', 'my-bucket');
+        expect(inner.category).toBe(ErrorCategory.AUTHORIZATION);
+        const outer = createS3OperationError(inner, 'PresigningMutation', void 0, void 0, 'generate the presigned URL');
+        expect(outer.category).toBe(ErrorCategory.AUTHORIZATION);
+        expect(outer.message).toBe("You don't have permission to generate the presigned URL. Contact your administrator.");
+    });
+});
 describe('Integration Tests', ()=>{
     test('complete error processing workflow', ()=>{
         const testCases = [

package/dist/utils/errorHandling.d.ts

@@ -29,6 +29,7 @@ export declare class EnhancedS3Error extends Error {
      * Server errors, network issues, and expired credentials are retryable.
      */
     shouldRetry(): boolean;
+    getUserMessage(operationLabel: string): string;
 }
 /**
  * Type guard to check if an error is an AWS S3 service exception.
@@ -47,7 +48,7 @@ export declare function createS3Error(error: unknown, context?: Record<string, u
  * Creates an enhanced S3 error with operation context and enriched error messages.
  * Automatically adds operation details to error messages for better debugging.
  */
-export declare function createS3OperationError(error: unknown, operation: string, bucketName?: string, objectKey?: string): EnhancedS3Error;
+export declare function createS3OperationError(error: unknown, operation: string, bucketName?: string, objectKey?: string, operationLabel?: string): EnhancedS3Error;
 /**
  * Determines whether an error should be retried based on its classification.
  * Implements unified retry policy for all S3 operations.

package/dist/utils/errorHandling.js

@@ -29,6 +29,10 @@ class EnhancedS3Error extends Error {
     shouldRetry() {
         return "SERVER_ERROR" === this.category || "NETWORK_ERROR" === this.category || "EXPIRED_CREDENTIALS" === this.category;
     }
+    getUserMessage(operationLabel) {
+        if ("AUTHORIZATION" === this.category) return `You don't have permission to ${operationLabel}. Contact your administrator.`;
+        return this.message || `Failed to ${operationLabel}`;
+    }
 }
 const EXPIRED_CREDENTIAL_ERROR_NAMES = new Set([
     'ExpiredToken',
@@ -68,19 +72,16 @@ function createS3Error(error, context) {
     const message = 'string' == typeof error ? error : 'Unknown error occurred';
     return new EnhancedS3Error(message, 'UnknownError', "UNKNOWN", new Error(message), void 0, void 0, context);
 }
-function createS3OperationError(error, operation, bucketName, objectKey) {
+function createS3OperationError(error, operation, bucketName, objectKey, operationLabel) {
     const context = {
         operation,
         bucketName,
         objectKey,
         timestamp: new Date().toISOString()
     };
-    const enhancedError = createS3Error(error, context);
-    if (!enhancedError.message.includes(operation)) {
-        const prefix = bucketName ? `${operation} failed for bucket '${bucketName}'${objectKey ? `, key '${objectKey}'` : ''}` : `${operation} failed`;
-        return new EnhancedS3Error(`${prefix}: ${enhancedError.message}`, enhancedError.name, enhancedError.category, enhancedError.originalError, enhancedError.statusCode, enhancedError.metadata, context);
-    }
-    return enhancedError;
+    const enhancedError = isEnhancedS3Error(error) ? error : createS3Error(error, context);
+    const message = operationLabel ? enhancedError.getUserMessage(operationLabel) : enhancedError.message;
+    return new EnhancedS3Error(message, enhancedError.name, enhancedError.category, enhancedError.originalError, enhancedError.statusCode, enhancedError.metadata, context);
 }
 function shouldRetryError(error, failureCount, maxRetries = 3) {
     if (failureCount >= maxRetries) return false;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@scality/data-browser-library",
-  "version": "1.1.9",
+  "version": "1.1.11",
   "description": "A modular React component library for browsing S3 buckets and objects",
   "type": "module",
   "types": "./dist/index.d.ts",
@@ -61,7 +61,7 @@
     "jest": "^30.0.5",
     "jest-environment-jsdom": "^30.0.5",
     "msw": "^2.12.3",
-    "ts-jest": "^29.4.1"
+    "ts-jest": "^29.4.6"
   },
   "repository": {
     "type": "git",