@scality/data-browser-library 1.0.5 → 1.0.7

package/dist/components/__tests__/BucketCreate.test.js

@@ -76,7 +76,9 @@ const setupMocks = (overrides = {})=>{
     mockUseSetBucketEncryption.mockReturnValue(createMockMutationResult(mockMutations.setBucketEncryption));
 };
 const fillBucketName = async (name)=>{
-    const nameInput = screen.getByLabelText(/bucket name/i);
+    const nameInput = screen.getByRole('textbox', {
+        name: /bucket name/i
+    });
     await user_event.type(nameInput, name);
 };
 const submitForm = async ()=>{
@@ -101,13 +103,21 @@ describe('BucketCreate', ()=>{
     it('renders form with required fields', ()=>{
         renderBucketCreate();
         expect(screen.getByText('Create a New Bucket')).toBeInTheDocument();
-        expect(screen.getByLabelText(/bucket name/i)).toBeInTheDocument();
-        expect(screen.getByText('Versioning')).toBeInTheDocument();
-        expect(screen.getByText('Object-lock')).toBeInTheDocument();
+        expect(screen.getByRole('textbox', {
+            name: /bucket name/i
+        })).toBeInTheDocument();
+        expect(screen.getByRole('checkbox', {
+            name: /versioning/i
+        })).toBeInTheDocument();
+        expect(screen.getByRole('checkbox', {
+            name: /object-lock/i
+        })).toBeInTheDocument();
     });
     it('shows validation error for invalid bucket name with uppercase', async ()=>{
         renderBucketCreate();
-        await user_event.type(screen.getByLabelText(/bucket name/i), 'INVALID');
+        await user_event.type(screen.getByRole('textbox', {
+            name: /bucket name/i
+        }), 'INVALID');
         await user_event.tab();
         await waitFor(()=>{
             expect(screen.getByText(/bucket names can include only lowercase/i)).toBeInTheDocument();
@@ -115,7 +125,9 @@ describe('BucketCreate', ()=>{
     });
     it('shows validation error for bucket name starting with hyphen', async ()=>{
         renderBucketCreate();
-        await user_event.type(screen.getByLabelText(/bucket name/i), '-invalid');
+        await user_event.type(screen.getByRole('textbox', {
+            name: /bucket name/i
+        }), '-invalid');
         await user_event.tab();
         await waitFor(()=>{
             expect(screen.getByText(/bucket names can include only lowercase/i)).toBeInTheDocument();
@@ -123,7 +135,9 @@ describe('BucketCreate', ()=>{
     });
     it('shows validation error for bucket name ending with hyphen', async ()=>{
         renderBucketCreate();
-        await user_event.type(screen.getByLabelText(/bucket name/i), 'invalid-');
+        await user_event.type(screen.getByRole('textbox', {
+            name: /bucket name/i
+        }), 'invalid-');
         await user_event.tab();
         await waitFor(()=>{
             expect(screen.getByText(/bucket names can include only lowercase/i)).toBeInTheDocument();
@@ -131,7 +145,9 @@ describe('BucketCreate', ()=>{
     });
     it('shows validation error for bucket name with adjacent periods', async ()=>{
         renderBucketCreate();
-        await user_event.type(screen.getByLabelText(/bucket name/i), 'test..bucket');
+        await user_event.type(screen.getByRole('textbox', {
+            name: /bucket name/i
+        }), 'test..bucket');
         await user_event.tab();
         await waitFor(()=>{
             expect(screen.getByText(/bucket names cannot contain two adjacent periods/i)).toBeInTheDocument();
@@ -139,7 +155,9 @@ describe('BucketCreate', ()=>{
     });
     it('shows validation error for bucket name formatted as IP address', async ()=>{
         renderBucketCreate();
-        await user_event.type(screen.getByLabelText(/bucket name/i), '192.168.1.1');
+        await user_event.type(screen.getByRole('textbox', {
+            name: /bucket name/i
+        }), '192.168.1.1');
         await user_event.tab();
         await waitFor(()=>{
             expect(screen.getByText(/bucket names must not be formatted as an ip address/i)).toBeInTheDocument();
@@ -147,7 +165,9 @@ describe('BucketCreate', ()=>{
     });
     it('shows validation error for bucket name with forbidden prefix', async ()=>{
         renderBucketCreate();
-        await user_event.type(screen.getByLabelText(/bucket name/i), 'xn--test');
+        await user_event.type(screen.getByRole('textbox', {
+            name: /bucket name/i
+        }), 'xn--test');
         await user_event.tab();
         await waitFor(()=>{
             expect(screen.getByText(/bucket names must not start with/i)).toBeInTheDocument();
@@ -155,7 +175,9 @@ describe('BucketCreate', ()=>{
     });
     it('shows validation error for bucket name with forbidden suffix', async ()=>{
         renderBucketCreate();
-        await user_event.type(screen.getByLabelText(/bucket name/i), 'test-s3alias');
+        await user_event.type(screen.getByRole('textbox', {
+            name: /bucket name/i
+        }), 'test-s3alias');
         await user_event.tab();
         await waitFor(()=>{
             expect(screen.getByText(/bucket names must not end with/i)).toBeInTheDocument();
@@ -170,7 +192,9 @@ describe('BucketCreate', ()=>{
                 ]
             }
         });
-        await user_event.type(screen.getByLabelText(/bucket name/i), 'existing-bucket');
+        await user_event.type(screen.getByRole('textbox', {
+            name: /bucket name/i
+        }), 'existing-bucket');
         await user_event.tab();
         await waitFor(()=>{
             expect(screen.getByText(/a bucket with this name already exists/i)).toBeInTheDocument();
@@ -185,7 +209,9 @@ describe('BucketCreate', ()=>{
             '123-bucket-456'
         ];
         for (const name of validNames){
-            const input = screen.getByLabelText(/bucket name/i);
+            const input = screen.getByRole('textbox', {
+                name: /bucket name/i
+            });
             await user_event.clear(input);
             await user_event.type(input, name);
             await user_event.tab();
@@ -469,7 +495,9 @@ describe('BucketCreate', ()=>{
             });
             renderBucketCreate();
             await fillBucketName('test-bucket');
-            const encryptionCheckbox = screen.getByLabelText(/encryption/i);
+            const encryptionCheckbox = screen.getByRole('checkbox', {
+                name: /encryption/i
+            });
             await user_event.click(encryptionCheckbox);
             await submitForm();
             const createSuccessCallback = mockMutations.createBucket.mock.calls[0][1].onSuccess;
@@ -516,8 +544,12 @@ describe('BucketCreate', ()=>{
             });
             renderBucketCreate();
             await fillBucketName('test-bucket');
-            await user_event.click(screen.getByLabelText(/versioning/i));
-            await user_event.click(screen.getByLabelText(/encryption/i));
+            await user_event.click(screen.getByRole('checkbox', {
+                name: /versioning/i
+            }));
+            await user_event.click(screen.getByRole('checkbox', {
+                name: /encryption/i
+            }));
             await submitForm();
             const createSuccessCallback = mockMutations.createBucket.mock.calls[0][1].onSuccess;
             createSuccessCallback();
@@ -536,9 +568,15 @@ describe('BucketCreate', ()=>{
             });
             renderBucketCreate();
             await fillBucketName('test-bucket');
-            await user_event.click(screen.getByLabelText(/object-lock/i));
-            await user_event.click(screen.getByLabelText(/default retention/i));
-            await user_event.click(screen.getByLabelText(/encryption/i));
+            await user_event.click(screen.getByRole('checkbox', {
+                name: /object-lock/i
+            }));
+            await user_event.click(screen.getByRole('checkbox', {
+                name: /default retention/i
+            }));
+            await user_event.click(screen.getByRole('checkbox', {
+                name: /encryption/i
+            }));
             await submitForm();
             const createSuccessCallback = mockMutations.createBucket.mock.calls[0][1].onSuccess;
             createSuccessCallback();
@@ -557,7 +595,9 @@ describe('BucketCreate', ()=>{
             });
             renderBucketCreate();
             await fillBucketName('test-bucket');
-            await user_event.click(screen.getByLabelText(/encryption/i));
+            await user_event.click(screen.getByRole('checkbox', {
+                name: /encryption/i
+            }));
             await submitForm();
             const createSuccessCallback = mockMutations.createBucket.mock.calls[0][1].onSuccess;
             createSuccessCallback();

package/dist/components/__tests__/BucketLifecycleFormPage.test.js

@@ -3,14 +3,19 @@ import { fireEvent, render, screen, waitFor } from "@testing-library/react";
 import user_event from "@testing-library/user-event";
 import { MemoryRouter, Route, Routes } from "react-router";
 import { useGetBucketLifecycle, useSetBucketLifecycle } from "../../hooks/bucketConfiguration.js";
+import { useISVBucketStatus } from "../../hooks/useISVBucketDetection.js";
 import { createTestWrapper, findToggleByLabel, mockErrorSubmit, mockOffsetSize, mockSuccessSubmit, submitForm } from "../../test/testUtils.js";
 import { BucketLifecycleFormPage } from "../buckets/BucketLifecycleFormPage.js";
 jest.mock('../../hooks/bucketConfiguration', ()=>({
         useGetBucketLifecycle: jest.fn(),
         useSetBucketLifecycle: jest.fn()
     }));
+jest.mock('../../hooks/useISVBucketDetection', ()=>({
+        useISVBucketStatus: jest.fn()
+    }));
 const mockUseGetBucketLifecycle = jest.mocked(useGetBucketLifecycle);
 const mockUseSetBucketLifecycle = jest.mocked(useSetBucketLifecycle);
+const mockUseISVBucketStatus = jest.mocked(useISVBucketStatus);
 const mockNavigate = jest.fn();
 const mockShowToast = jest.fn();
 jest.mock('react-router', ()=>({
@@ -69,6 +74,15 @@ describe('BucketLifecycleFormPage', ()=>{
             mutate: mockMutate,
             isPending: false
         });
+        mockUseISVBucketStatus.mockReturnValue({
+            isVeeamBucket: false,
+            isCommvaultBucket: false,
+            isKastenBucket: false,
+            isISVManaged: false,
+            isvApplication: void 0,
+            isLoading: false,
+            bucketTagsStatus: 'success'
+        });
     });
     describe('Page Rendering', ()=>{
         it('renders create mode with correct title', ()=>{
@@ -615,4 +629,62 @@ describe('BucketLifecycleFormPage', ()=>{
             });
         });
     });
+    describe('ISV Bucket Warning', ()=>{
+        const setupISVMock = (isvApplication = 'Veeam')=>{
+            mockUseISVBucketStatus.mockReturnValue({
+                isVeeamBucket: 'Veeam' === isvApplication,
+                isCommvaultBucket: 'Commvault' === isvApplication,
+                isKastenBucket: 'Kasten' === isvApplication,
+                isISVManaged: true,
+                isvApplication,
+                isLoading: false,
+                bucketTagsStatus: 'success'
+            });
+        };
+        it('renders ISV warning banner and checkbox when bucket is ISV-managed', ()=>{
+            setupISVMock('Veeam');
+            renderBucketLifecycleFormPage();
+            expect(screen.getByText(/bucket used for external integration with Veeam/i)).toBeInTheDocument();
+            expect(screen.getByText(/may conflict with Veeam's backup strategy/i)).toBeInTheDocument();
+            expect(screen.getByLabelText(/i understand what i'm doing/i)).toBeInTheDocument();
+        });
+        it('does not render ISV warning for non-ISV buckets', ()=>{
+            renderBucketLifecycleFormPage();
+            expect(screen.queryByText(/bucket used for external integration with/i)).not.toBeInTheDocument();
+            expect(screen.queryByLabelText(/i understand what i'm doing/i)).not.toBeInTheDocument();
+        });
+        it('blocks form submission when ISV checkbox is unchecked', async ()=>{
+            setupISVMock('Veeam');
+            renderBucketLifecycleFormPage();
+            await fillRequiredFields('isv-rule');
+            await waitFor(()=>{
+                const createButton = screen.getByRole('button', {
+                    name: /create/i
+                });
+                expect(createButton).toBeDisabled();
+            });
+        });
+        it('allows form submission when ISV checkbox is checked', async ()=>{
+            setupISVMock('Veeam');
+            renderBucketLifecycleFormPage();
+            await fillRequiredFields('isv-rule');
+            const checkbox = screen.getByLabelText(/i understand what i'm doing/i);
+            await user_event.click(checkbox);
+            mockSuccessSubmit(mockMutate);
+            await submitForm('create');
+            await waitFor(()=>{
+                expect(mockMutate).toHaveBeenCalled();
+            });
+        });
+        it('displays correct application name for Commvault ISV bucket', ()=>{
+            setupISVMock('Commvault');
+            renderBucketLifecycleFormPage();
+            expect(screen.getByText(/bucket used for external integration with Commvault/i)).toBeInTheDocument();
+        });
+        it('displays correct application name for Kasten ISV bucket', ()=>{
+            setupISVMock('Kasten');
+            renderBucketLifecycleFormPage();
+            expect(screen.getByText(/bucket used for external integration with Kasten/i)).toBeInTheDocument();
+        });
+    });
 });

package/dist/components/__tests__/BucketList.test.js

@@ -45,9 +45,15 @@ describe('BucketList', ()=>{
             buckets: mockBuckets
         });
         expect(screen.getByRole('grid')).toBeInTheDocument();
-        expect(screen.getByText('Bucket Name')).toBeInTheDocument();
-        expect(screen.getByText('Storage Location')).toBeInTheDocument();
-        expect(screen.getByText('Created on')).toBeInTheDocument();
+        expect(screen.getByRole('columnheader', {
+            name: /bucket name/i
+        })).toBeInTheDocument();
+        expect(screen.getByRole('columnheader', {
+            name: /storage location/i
+        })).toBeInTheDocument();
+        expect(screen.getByRole('columnheader', {
+            name: /created on/i
+        })).toBeInTheDocument();
     });
     it('displays buckets with their names as clickable links', ()=>{
         const onNavigateToBucket = jest.fn();
@@ -109,14 +115,16 @@ describe('BucketList', ()=>{
         });
         const searchInput = screen.getByRole('searchbox');
         expect(searchInput).toBeInTheDocument();
-        expect(searchInput).toHaveAttribute('placeholder', 'Example: Search');
+        expect(searchInput).toHaveAttribute('placeholder', 'Search');
     });
     it('handles empty buckets list', ()=>{
         renderBucketList({
             buckets: []
         });
         expect(screen.getByRole('grid')).toBeInTheDocument();
-        expect(screen.getByText('Bucket Name')).toBeInTheDocument();
+        expect(screen.getByRole('columnheader', {
+            name: /bucket name/i
+        })).toBeInTheDocument();
     });
     it('handles buckets without names gracefully', ()=>{
         const bucketsWithMissingNames = [
@@ -248,7 +256,9 @@ describe('BucketList', ()=>{
         renderBucketList({
             buckets: bucketsWithReversedDateOrder
         });
-        fireEvent.click(screen.getByText('Created on'));
+        fireEvent.click(screen.getByRole('columnheader', {
+            name: /created on/i
+        }));
         const rows = screen.getAllByRole('row');
         expect(rows[1]).toHaveTextContent('alpha-bucket');
         expect(rows[2]).toHaveTextContent('gamma-bucket');
@@ -272,7 +282,9 @@ describe('BucketList', ()=>{
         renderBucketList({
             buckets: mockBuckets
         });
-        fireEvent.click(screen.getByText('Storage Location'));
+        fireEvent.click(screen.getByRole('columnheader', {
+            name: /storage location/i
+        }));
         const rows = screen.getAllByRole('row');
         expect(rows[1]).toHaveTextContent('test-bucket-3');
         expect(rows[2]).toHaveTextContent('test-bucket-2');

package/dist/components/__tests__/BucketNotificationFormPage.test.js

@@ -66,11 +66,18 @@ describe('BucketNotificationFormPage', ()=>{
         it('renders create notification form with all fields', ()=>{
             renderCreatePage();
             expect(screen.getByText('Create Bucket Notification')).toBeInTheDocument();
-            expect(screen.getByLabelText(/rule name/i)).toBeInTheDocument();
-            expect(screen.getByText('Events')).toBeInTheDocument();
-            expect(screen.getByLabelText(/destination queue/i)).toBeInTheDocument();
-            expect(screen.getByLabelText(/prefix/i)).toBeInTheDocument();
-            expect(screen.getByLabelText(/suffix/i)).toBeInTheDocument();
+            expect(screen.getByRole('textbox', {
+                name: /rule name/i
+            })).toBeInTheDocument();
+            expect(screen.getByRole('textbox', {
+                name: /destination queue/i
+            })).toBeInTheDocument();
+            expect(screen.getByRole('textbox', {
+                name: /^prefix$/i
+            })).toBeInTheDocument();
+            expect(screen.getByRole('textbox', {
+                name: /^suffix$/i
+            })).toBeInTheDocument();
         });
         it('disables create button when form is pristine', ()=>{
             renderCreatePage();
@@ -80,7 +87,9 @@ describe('BucketNotificationFormPage', ()=>{
         });
         it('shows validation error when rule name is empty', async ()=>{
             renderCreatePage();
-            const ruleNameInput = screen.getByLabelText(/rule name/i);
+            const ruleNameInput = screen.getByRole('textbox', {
+                name: /rule name/i
+            });
             await user_event.type(ruleNameInput, 'a');
             await user_event.clear(ruleNameInput);
             await waitFor(()=>{
@@ -104,7 +113,9 @@ describe('BucketNotificationFormPage', ()=>{
                 status: 'success'
             });
             renderCreatePage();
-            const ruleNameInput = screen.getByLabelText(/rule name/i);
+            const ruleNameInput = screen.getByRole('textbox', {
+                name: /rule name/i
+            });
             await user_event.type(ruleNameInput, 'existing-rule');
             await waitFor(()=>{
                 expect(screen.getByText(/a rule with this name already exists/i)).toBeInTheDocument();
@@ -112,7 +123,9 @@ describe('BucketNotificationFormPage', ()=>{
         });
         it('shows validation error when queue ARN is invalid', async ()=>{
             renderCreatePage();
-            const queueArnInput = screen.getByLabelText(/destination queue/i);
+            const queueArnInput = screen.getByRole('textbox', {
+                name: /destination queue/i
+            });
             await user_event.type(queueArnInput, 'invalid-arn');
             await waitFor(()=>{
                 expect(screen.getByText(/must be a valid arn/i)).toBeInTheDocument();
@@ -120,8 +133,12 @@ describe('BucketNotificationFormPage', ()=>{
         });
         it('enables create button when form is valid', async ()=>{
             renderCreatePage();
-            await user_event.type(screen.getByLabelText(/rule name/i), 'test-rule');
-            await user_event.type(screen.getByLabelText(/destination queue/i), 'arn:aws:sqs:us-east-1:123:queue');
+            await user_event.type(screen.getByRole('textbox', {
+                name: /rule name/i
+            }), 'test-rule');
+            await user_event.type(screen.getByRole('textbox', {
+                name: /destination queue/i
+            }), 'arn:aws:sqs:us-east-1:123:queue');
             const checkbox = screen.getByRole('checkbox', {
                 name: /s3:ObjectCreated:\*/i
             });
@@ -134,13 +151,21 @@ describe('BucketNotificationFormPage', ()=>{
         });
         it('creates notification with all fields and navigates on success', async ()=>{
             renderCreatePage();
-            await user_event.type(screen.getByLabelText(/rule name/i), 'test-rule');
-            await user_event.type(screen.getByLabelText(/destination queue/i), 'arn:aws:sqs:us-east-1:123:my-queue');
+            await user_event.type(screen.getByRole('textbox', {
+                name: /rule name/i
+            }), 'test-rule');
+            await user_event.type(screen.getByRole('textbox', {
+                name: /destination queue/i
+            }), 'arn:aws:sqs:us-east-1:123:my-queue');
             fireEvent.click(screen.getByRole('checkbox', {
                 name: /s3:ObjectCreated:Put/i
             }));
-            await user_event.type(screen.getByLabelText(/prefix/i), 'uploads/');
-            await user_event.type(screen.getByLabelText(/suffix/i), '.jpg');
+            await user_event.type(screen.getByRole('textbox', {
+                name: /^prefix$/i
+            }), 'uploads/');
+            await user_event.type(screen.getByRole('textbox', {
+                name: /^suffix$/i
+            }), '.jpg');
             mockMutate.mockImplementation((_, options)=>{
                 options?.onSuccess?.();
             });
@@ -263,9 +288,15 @@ describe('BucketNotificationFormPage', ()=>{
         it('pre-fills form with existing rule data', async ()=>{
             renderEditPage();
             await waitFor(()=>{
-                expect(screen.getByLabelText(/destination queue/i)).toHaveValue('arn:aws:sqs:us-east-1:123:existing-queue');
-                expect(screen.getByLabelText(/prefix/i)).toHaveValue('data/');
-                expect(screen.getByLabelText(/suffix/i)).toHaveValue('.json');
+                expect(screen.getByRole('textbox', {
+                    name: /destination queue/i
+                })).toHaveValue('arn:aws:sqs:us-east-1:123:existing-queue');
+                expect(screen.getByRole('textbox', {
+                    name: /^prefix$/i
+                })).toHaveValue('data/');
+                expect(screen.getByRole('textbox', {
+                    name: /^suffix$/i
+                })).toHaveValue('.json');
             });
         });
         it('shows Save button instead of Create in edit mode', ()=>{
@@ -280,9 +311,13 @@ describe('BucketNotificationFormPage', ()=>{
         it('updates notification and navigates on success', async ()=>{
             renderEditPage();
             await waitFor(()=>{
-                expect(screen.getByLabelText(/destination queue/i)).toHaveValue('arn:aws:sqs:us-east-1:123:existing-queue');
+                expect(screen.getByRole('textbox', {
+                    name: /destination queue/i
+                })).toHaveValue('arn:aws:sqs:us-east-1:123:existing-queue');
+            });
+            const queueInput = screen.getByRole('textbox', {
+                name: /destination queue/i
             });
-            const queueInput = screen.getByLabelText(/destination queue/i);
             await user_event.clear(queueInput);
             await user_event.type(queueInput, 'arn:aws:sqs:us-east-1:123:updated-queue');
             mockMutate.mockImplementation((_, options)=>{

package/dist/components/__tests__/BucketPolicyPage.test.js

@@ -73,6 +73,7 @@ describe('BucketPolicyPage', ()=>{
         mockUseISVBucketStatus.mockReturnValue({
             isVeeamBucket: false,
             isCommvaultBucket: false,
+            isKastenBucket: false,
             isISVManaged: false,
             isvApplication: void 0,
             isLoading: false,
@@ -204,6 +205,7 @@ describe('BucketPolicyPage', ()=>{
         mockUseISVBucketStatus.mockReturnValue({
             isVeeamBucket: false,
             isCommvaultBucket: false,
+            isKastenBucket: false,
             isISVManaged: false,
             isvApplication: void 0,
             isLoading: true,
@@ -217,6 +219,7 @@ describe('BucketPolicyPage', ()=>{
         mockUseISVBucketStatus.mockReturnValue({
             isVeeamBucket: true,
             isCommvaultBucket: false,
+            isKastenBucket: false,
             isISVManaged: true,
             isvApplication: 'Veeam',
             isLoading: false,
@@ -234,6 +237,7 @@ describe('BucketPolicyPage', ()=>{
         mockUseISVBucketStatus.mockReturnValue({
             isVeeamBucket: false,
             isCommvaultBucket: true,
+            isKastenBucket: false,
             isISVManaged: true,
             isvApplication: 'Commvault',
             isLoading: false,
@@ -251,6 +255,7 @@ describe('BucketPolicyPage', ()=>{
         mockUseISVBucketStatus.mockReturnValue({
             isVeeamBucket: false,
             isCommvaultBucket: false,
+            isKastenBucket: false,
             isISVManaged: false,
             isvApplication: void 0,
             isLoading: false,