@scality/core-ui 0.206.0 → 0.208.0

package/.github/workflows/github-pages.yml

@@ -14,6 +14,8 @@ jobs:
         with:
           node-version: 20
       - run: npm ci
+      - name: Configure git credentials
+        run: git config --global url."https://x-access-token:${{ github.token }}@github.com/".insteadOf "https://github.com/"
       - run: npm run storybook:deploy
         env:
           STORYBOOK_DISABLE_TELEMETRY: 1

package/.github/workflows/post-release.yml

@@ -39,19 +39,11 @@ jobs:
               body: ''
             });
             core.setOutput('pull-request-number', String(pr.data.number));
-      - uses: actions/github-script@v5
-        if: ${{ steps.cpr.outputs.pull-request-number }}
-        with:
-          script: |
-            github.rest.issues.createComment({
-              issue_number: '${{ steps.cpr.outputs.pull-request-number }}',
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              body: '/approve'
-            })
-      - uses: actions/github-script@v5
+      - name: Merge Pull Request
+        uses: actions/github-script@v5
         if: ${{ steps.cpr.outputs.pull-request-number }}
         with:
+          github-token: ${{ secrets.GIT_ACCESS_TOKEN }}
           script: |
             await github.rest.pulls.merge({
               owner: context.repo.owner,

package/dist/components/icon/Icon.component.d.ts

@@ -1,6 +1,6 @@
-import { SizeProp } from '@fortawesome/fontawesome-svg-core';
-import { CSSProperties } from 'react';
-import { CoreUITheme } from '../../style/theme';
+import type { SizeProp } from '@fortawesome/fontawesome-svg-core';
+import { type CSSProperties } from 'react';
+import type { CoreUITheme } from '../../style/theme';
 import { iconTable } from './iconTable';
 type IconProps = {
     'aria-label'?: string;

package/dist/components/icon/Icon.component.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"Icon.component.d.ts","sourceRoot":"","sources":["../../../src/lib/components/icon/Icon.component.tsx"],"names":[],"mappings":"AAAA,OAAO,EAAE,QAAQ,EAAE,MAAM,mCAAmC,CAAC;AAE7D,OAAO,EACL,aAAa,EAKd,MAAM,OAAO,CAAC;AAEf,OAAO,EAAE,WAAW,EAAE,MAAM,mBAAmB,CAAC;AAGhD,OAAO,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAKxC,KAAK,SAAS,GAAG;IACf,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,KAAK,CAAC,EAAE,MAAM,CAAC;CAChB,CAAC;AAEF,eAAO,MAAM,WAAW,EAAE,MAAM,CAC9B,MAAM,EACN,CAAC,CAAC,KAAK,EAAE,SAAS,KAAK,GAAG,CAAC,OAAO,CAAC,GAAG;IAAE,WAAW,CAAC,EAAE,MAAM,CAAA;CAAE,CAc/D,CAAC;AAkBF,MAAM,MAAM,QAAQ,GAAG,MAAM,OAAO,SAAS,GAAG,MAAM,OAAO,WAAW,CAAC;AACzE,MAAM,MAAM,SAAS,GAAG,MAAM,WAAW,CAAC;AAC1C,KAAK,KAAK,GAAG;IACX,IAAI,EAAE,QAAQ,CAAC;IACf,IAAI,CAAC,EAAE,QAAQ,CAAC;IAChB,KAAK,CAAC,EAAE,SAAS,GAAG,aAAa,CAAC,OAAO,CAAC,CAAC;IAC3C;;;;OAIG;IACH,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,WAAW,CAAC,EAAE,OAAO,CAAC;IACtB,KAAK,CAAC,EAAE,aAAa,CAAC;IACtB,OAAO,CAAC,EAAE,CAAC,KAAK,EAAE,KAAK,CAAC,UAAU,KAAK,IAAI,CAAC;IAC5C,KAAK,CAAC,EAAE,MAAM,CAAC;CAChB,CAAC;AAiBF,eAAO,MAAM,WAAW;UAAsB,QAAQ;SAiCrD,CAAC;AAmEF,iBAAS,IAAI,CAAC,EAAE,WAAW,EAAE,GAAG,KAAK,EAAE,EAAE,KAAK,2CAU7C;AAED,OAAO,EAAE,IAAI,EAAE,SAAS,EAAE,CAAC"}
+{"version":3,"file":"Icon.component.d.ts","sourceRoot":"","sources":["../../../src/lib/components/icon/Icon.component.tsx"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,QAAQ,EAAE,MAAM,mCAAmC,CAAC;AAElE,OAAO,EACL,KAAK,aAAa,EAKnB,MAAM,OAAO,CAAC;AAEf,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,mBAAmB,CAAC;AAGrD,OAAO,EAAE,SAAS,EAAE,MAAM,aAAa,CAAC;AAKxC,KAAK,SAAS,GAAG;IACf,YAAY,CAAC,EAAE,MAAM,CAAC;IACtB,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,IAAI,CAAC,EAAE,MAAM,CAAC;IACd,KAAK,CAAC,EAAE,MAAM,CAAC;CAChB,CAAC;AAEF,eAAO,MAAM,WAAW,EAAE,MAAM,CAC9B,MAAM,EACN,CAAC,CAAC,KAAK,EAAE,SAAS,KAAK,GAAG,CAAC,OAAO,CAAC,GAAG;IAAE,WAAW,CAAC,EAAE,MAAM,CAAA;CAAE,CAc/D,CAAC;AAkBF,MAAM,MAAM,QAAQ,GAAG,MAAM,OAAO,SAAS,GAAG,MAAM,OAAO,WAAW,CAAC;AACzE,MAAM,MAAM,SAAS,GAAG,MAAM,WAAW,CAAC;AAC1C,KAAK,KAAK,GAAG;IACX,IAAI,EAAE,QAAQ,CAAC;IACf,IAAI,CAAC,EAAE,QAAQ,CAAC;IAChB,KAAK,CAAC,EAAE,SAAS,GAAG,aAAa,CAAC,OAAO,CAAC,CAAC;IAC3C;;;;OAIG;IACH,SAAS,CAAC,EAAE,MAAM,CAAC;IACnB,WAAW,CAAC,EAAE,OAAO,CAAC;IACtB,KAAK,CAAC,EAAE,aAAa,CAAC;IACtB,OAAO,CAAC,EAAE,CAAC,KAAK,EAAE,KAAK,CAAC,UAAU,KAAK,IAAI,CAAC;IAC5C,KAAK,CAAC,EAAE,MAAM,CAAC;CAChB,CAAC;AAiBF,eAAO,MAAM,WAAW;UAAsB,QAAQ;SAiCrD,CAAC;AAsEF,iBAAS,IAAI,CAAC,EAAE,WAAW,EAAE,GAAG,KAAK,EAAE,EAAE,KAAK,2CAU7C;AAED,OAAO,EAAE,IAAI,EAAE,SAAS,EAAE,CAAC"}

package/dist/components/icon/Icon.component.js

@@ -60,8 +60,8 @@ export const IconWrapper = styled.div `
         height: 1.5rem;
       `
                 : `
-        width: ${parseInt(props.size.replace('x', '')) * 2}rem;
-        height: ${parseInt(props.size.replace('x', '')) * 2}rem;
+        width: ${parseInt(props.size.replace('x', ''), 10) * 2}rem;
+        height: ${parseInt(props.size.replace('x', ''), 10) * 2}rem;
       `}
     `;
 }}
@@ -92,9 +92,12 @@ function NonWrappedIcon({ name, size = '1x', color, ariaLabel, title, ...rest })
         // Handle FontAwesome icons with dynamic import
         import(
         /* webpackExclude: /import\.macro\.js$/ */
-        `@fortawesome/${fontAwesomeType}/${iconClass}.js`).then((module) => {
+        /* webpackInclude: /\.js$/ */
+        `@fortawesome/${fontAwesomeType}/${iconClass}`).then((module) => {
             setIcon(module[iconClass]);
             iconCache[cacheKey] = module[iconClass];
+        }).catch((err) => {
+            console.warn(`Icon ${iconClass} could not be loaded:`, err.message);
         });
         return () => setIcon(undefined);
     }, [name, iconInfo]);

package/jest.config.js

@@ -10,5 +10,10 @@ export default {
     '^@fortawesome/free-regular-svg-icons/(.+)\\.js$':
       '@fortawesome/free-regular-svg-icons/$1',
   },
+  // Transform both .js and .mjs files with Babel
+  transform: {
+    '^.+\\.(js|jsx|mjs)$': 'babel-jest',
+    '^.+\\.(ts|tsx)$': 'babel-jest',
+  },
   testEnvironment: 'jsdom',
 };

package/package.json

@@ -1,11 +1,10 @@
 {
   "name": "@scality/core-ui",
-  "version": "0.206.0",
+  "version": "0.208.0",
   "description": "Scality common React component library",
   "author": "Scality Engineering",
   "license": "SEE LICENSE IN LICENSE",
   "main": "dist/index.js",
-  "type": "module",
   "types": "dist/index.d.ts",
   "mainSrc": "src/lib/index.js",
   "exports": {
@@ -14,7 +13,7 @@
       "require": "./dist/index.js",
       "types": "./dist/index.d.ts"
     },
-    "./eslint-plugin": "./src/lib/valalint/index.js",
+    "./eslint-plugin": "./src/lib/valalint/index.mjs",
     "./dist/*.css": "./dist/*.css",
     "./dist/*": "./dist/*"
   },

package/src/lib/components/icon/Icon.component.tsx

@@ -1,14 +1,14 @@
-import { SizeProp } from '@fortawesome/fontawesome-svg-core';
+import type { SizeProp } from '@fortawesome/fontawesome-svg-core';
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
 import {
-  CSSProperties,
-  HTMLProps,
-  PropsWithChildren,
+  type CSSProperties,
+  type HTMLProps,
+  type PropsWithChildren,
   useEffect,
   useState,
 } from 'react';
 import styled, { css } from 'styled-components';
-import { CoreUITheme } from '../../style/theme';
+import type { CoreUITheme } from '../../style/theme';
 import { Loader } from '../loader/Loader.component';
 import { Bucket, Buckets, RemoteGroup, RemoteUser } from './CustomsIcons';
 import { iconTable } from './iconTable';
@@ -114,8 +114,8 @@ export const IconWrapper = styled.div<{ size: SizeProp }>`
         height: 1.5rem;
       `
             : `
-        width: ${parseInt(props.size.replace('x', '')) * 2}rem;
-        height: ${parseInt(props.size.replace('x', '')) * 2}rem;
+        width: ${parseInt(props.size.replace('x', ''), 10) * 2}rem;
+        height: ${parseInt(props.size.replace('x', ''), 10) * 2}rem;
       `}
     `;
   }}
@@ -157,9 +157,12 @@ function NonWrappedIcon({
     // Handle FontAwesome icons with dynamic import
     import(
       /* webpackExclude: /import\.macro\.js$/ */
-      `@fortawesome/${fontAwesomeType}/${iconClass}.js`).then((module) => {
+      /* webpackInclude: /\.js$/ */
+      `@fortawesome/${fontAwesomeType}/${iconClass}`).then((module) => {
         setIcon(module[iconClass]);
         iconCache[cacheKey] = module[iconClass];
+      }).catch((err) => {
+        console.warn(`Icon ${iconClass} could not be loaded:`, err.message);
       });
     return () => setIcon(undefined);
   }, [name, iconInfo]);

package/src/lib/valalint/index.mjs

@@ -0,0 +1,49 @@
+import tsParser from "@typescript-eslint/parser";
+import modalButtonForbiddenLabel from "./rules/modal-button-forbidden-label.mjs";
+import noRawNumberInJsx from "./rules/no-raw-number-in-jsx.mjs";
+import technicalSentenceCase from "./rules/technical-sentence-case.mjs";
+
+const rules = {
+	"technical-sentence-case": technicalSentenceCase,
+	"modal-button-forbidden-label": modalButtonForbiddenLabel,
+	"no-raw-number-in-jsx": noRawNumberInJsx,
+};
+
+/** Default rule severity for the recommended config. */
+const recommendedRules = {
+	"valalint/technical-sentence-case": "warn",
+	"valalint/modal-button-forbidden-label": "warn",
+	"valalint/no-raw-number-in-jsx": "warn",
+};
+
+const plugin = {
+	meta: {
+		name: "valalint",
+		version: "1.0.0",
+	},
+
+	rules,
+	configs: {
+		/** Legacy eslintrc-style recommended config. */
+		recommended: {
+			plugins: ["valalint"],
+			rules: recommendedRules,
+		},
+	},
+};
+
+plugin.configs["flat/recommended"] = {
+	plugins: { valalint: plugin },
+	rules: recommendedRules,
+	languageOptions: {
+		parser: tsParser,
+		parserOptions: {
+			ecmaFeatures: {
+				jsx: true,
+			},
+			project: true,
+		},
+	},
+};
+
+export default plugin;

package/src/lib/valalint/rules/modal-button-forbidden-label.test.js

@@ -1,5 +1,5 @@
 import { RuleTester } from 'eslint';
-import rule from './modal-button-forbidden-label.js';
+import rule from './modal-button-forbidden-label.mjs';
 import * as tsParser from '@typescript-eslint/parser';
 
 const tester = new RuleTester({

package/src/lib/valalint/rules/no-raw-number-in-jsx.test.js

@@ -2,7 +2,7 @@
  * @jest-environment node
  */
 import { RuleTester } from '@typescript-eslint/rule-tester';
-import rule from './no-raw-number-in-jsx.js';
+import rule from './no-raw-number-in-jsx.mjs';
 import path from 'path';
 
 // Jest runs from the project root, so process.cwd() is the workspace root

package/src/lib/valalint/rules/technical-sentence-case.test.js

@@ -1,5 +1,5 @@
 import { RuleTester } from 'eslint';
-import rule from './technical-sentence-case.js';
+import rule from './technical-sentence-case.mjs';
 import * as tsParser from '@typescript-eslint/parser';
 
 const tester = new RuleTester({

package/src/lib/valalint/index.js

@@ -1,49 +0,0 @@
-import tsParser from '@typescript-eslint/parser';
-import technicalSentenceCase from './rules/technical-sentence-case.js';
-import modalButtonForbiddenLabel from './rules/modal-button-forbidden-label.js';
-import noRawNumberInJsx from './rules/no-raw-number-in-jsx.js';
-
-const rules = {
-    'technical-sentence-case': technicalSentenceCase,
-    'modal-button-forbidden-label': modalButtonForbiddenLabel,
-    'no-raw-number-in-jsx': noRawNumberInJsx,
-};
-
-/** Default rule severity for the recommended config. */
-const recommendedRules = {
-    'valalint/technical-sentence-case': 'warn',
-    'valalint/modal-button-forbidden-label': 'warn',
-    'valalint/no-raw-number-in-jsx': 'warn',
-};
-
-const plugin = {
-    meta: {
-        name: 'valalint',
-        version: '1.0.0',
-    },
-
-    rules,
-    configs: {
-        /** Legacy eslintrc-style recommended config. */
-        recommended: {
-            plugins: ['valalint'],
-            rules: recommendedRules,
-        },
-    },
-};
-
-plugin.configs['flat/recommended'] = {
-    plugins: { valalint: plugin },
-    rules: recommendedRules,
-    languageOptions: {
-        parser: tsParser,
-        parserOptions: {
-            ecmaFeatures: {
-                jsx: true,
-            },
-            project: true,
-        },
-    },
-};
-
-export default plugin;