@scaleway/eslint-config-react 3.18.4 → 4.0.0

package/emotion.mjs

@@ -0,0 +1,24 @@
+import { rules } from '@emotion/eslint-plugin'
+import { fixupPluginRules } from '@eslint/compat'
+
+export default [
+  {
+    plugins: {
+      '@emotion': fixupPluginRules({ rules }),
+    },
+
+    rules: {
+      'react/no-unknown-property': [
+        'error',
+        {
+          ignore: ['css'],
+        },
+      ],
+
+      '@emotion/import-from-emotion': 'error',
+      '@emotion/no-vanilla': 'error',
+      '@emotion/styled-import': 'error',
+      '@emotion/syntax-preference': ['error', 'string'],
+    },
+  },
+]

package/index.mjs

@@ -0,0 +1,5 @@
+import emotion from './emotion.mjs'
+import javascript from './javascript.mjs'
+import typescript from './typescript.mjs'
+
+export { emotion, javascript, typescript }

package/javascript.mjs

@@ -0,0 +1,28 @@
+import { fixupConfigRules } from '@eslint/compat'
+import { FlatCompat } from '@eslint/eslintrc'
+import airbnb from 'eslint-config-airbnb'
+import path from 'node:path'
+import { fileURLToPath } from 'node:url'
+import shared from './shared.mjs'
+
+const filename = fileURLToPath(import.meta.url)
+const dirname = path.dirname(filename)
+
+const compat = new FlatCompat({
+  baseDirectory: dirname,
+})
+
+export default [
+  ...fixupConfigRules(compat.config(airbnb)),
+  ...shared,
+  {
+    rules: {
+      'react/jsx-filename-extension': [
+        'error',
+        {
+          extensions: ['.js'],
+        },
+      ],
+    },
+  },
+]

package/package.json

@@ -1,25 +1,41 @@
 {
   "name": "@scaleway/eslint-config-react",
-  "version": "3.18.4",
+  "version": "4.0.0",
   "description": "Scaleway React eslint shared config",
   "keywords": [
     "eslint",
     "eslintconfig"
   ],
-  "main": "index.js",
   "publishConfig": {
     "access": "public"
   },
+  "type": "module",
   "repository": {
     "type": "git",
     "url": "https://github.com/scaleway/scaleway-lib",
     "directory": "packages/eslint-config-react"
   },
+  "exports": {
+    ".": "./index.mjs",
+    "./javascript": "./javascript.mjs",
+    "./typescript": "./typescript.mjs",
+    "./emotion": "./emotion.mjs",
+    "./shared": "./shared.mjs"
+  },
+  "files": [
+    "index.mjs",
+    "javascript.mjs",
+    "typescript.mjs",
+    "shared.mjs",
+    "emotion.mjs"
+  ],
   "license": "MIT",
   "dependencies": {
     "@emotion/eslint-plugin": "11.11.0",
-    "@typescript-eslint/eslint-plugin": "7.11.0",
-    "@typescript-eslint/parser": "7.11.0",
+    "@eslint/compat": "1.0.3",
+    "@eslint/eslintrc": "3.1.0",
+    "@typescript-eslint/eslint-plugin": "7.12.0",
+    "@typescript-eslint/parser": "7.12.0",
     "eslint-config-airbnb": "19.0.4",
     "eslint-config-airbnb-typescript": "18.0.0",
     "eslint-config-prettier": "9.1.0",
@@ -31,10 +47,10 @@
     "eslint-plugin-react-hooks": "4.6.2"
   },
   "peerDependencies": {
-    "eslint": ">= 8.5"
+    "eslint": ">= 9.4"
   },
   "devDependencies": {
-    "eslint": "8.57.0",
+    "eslint": "9.4.0",
     "typescript": "5.4.5"
   }
 }

package/shared.mjs

@@ -0,0 +1,135 @@
+import { fixupConfigRules } from '@eslint/compat'
+import { FlatCompat } from '@eslint/eslintrc'
+import path from 'node:path'
+import { fileURLToPath } from 'node:url'
+
+const filename = fileURLToPath(import.meta.url)
+const dirname = path.dirname(filename)
+
+const compat = new FlatCompat({
+  baseDirectory: dirname,
+})
+
+export default [
+  ...fixupConfigRules(
+    compat.extends(
+      'airbnb/hooks',
+      'prettier',
+      'plugin:eslint-comments/recommended',
+      'plugin:react/jsx-runtime',
+    ),
+  ),
+  {
+    rules: {
+      curly: 'error',
+
+      'import/order': [
+        'error',
+        {
+          alphabetize: {
+            caseInsensitive: false,
+            order: 'asc',
+          },
+
+          groups: [
+            ['builtin', 'external'],
+            'internal',
+            'parent',
+            'sibling',
+            'index',
+          ],
+          'newlines-between': 'never',
+        },
+      ],
+
+      'import/no-extraneous-dependencies': [
+        'error',
+        {
+          devDependencies: [
+            '**/.jest/**',
+            '**/.storybook/**',
+            'test/**',
+            'tests/**',
+            'spec/**',
+            '**/__tests__/**',
+            '**/__mocks__/**',
+            '**/__stories__/**',
+            'test.{js,jsx,ts,tsx}',
+            'test-*.{js,jsx,ts,tsx}',
+            '**/*{.,_}{test,spec}.{js,jsx,ts,tsx}',
+            '**/jest.config.{js,ts,mjs,mts}',
+            '**/jest.setup.{js,ts,mjs,mts}',
+            '**/webpack.config.{js,ts,mjs,mts}',
+            '**/webpack.config.*.{js,ts,mjs,mts}',
+            '**/rollup.config.{js,ts,mjs,mts}',
+            '**/rollup.config.*.{js,ts,mjs,mts}',
+          ],
+
+          optionalDependencies: false,
+        },
+      ],
+
+      'import/prefer-default-export': 'off',
+
+      'no-restricted-syntax': [
+        'error',
+        {
+          message:
+            'for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array.',
+          selector: 'ForInStatement',
+        },
+        {
+          message:
+            'Labels are a form of GOTO; using them makes code confusing and hard to maintain and understand.',
+          selector: 'LabeledStatement',
+        },
+        {
+          message:
+            '`with` is disallowed in strict mode because it makes code impossible to predict and optimize.',
+          selector: 'WithStatement',
+        },
+        {
+          message: '`export *` is forbidden.',
+          selector: 'ExportAllDeclaration',
+        },
+      ],
+
+      'padding-line-between-statements': [
+        'error',
+        {
+          blankLine: 'always',
+          next: 'return',
+          prev: '*',
+        },
+      ],
+
+      'react/function-component-definition': 'off',
+      'react/no-adjacent-inline-elements': 'error',
+      'prefer-object-has-own': 'error',
+      'react/no-object-type-as-default-prop': 'error',
+      'react/static-property-placement': ['error', 'static public field'],
+      'react/state-in-constructor': ['error', 'never'],
+
+      'react/sort-prop-types': [
+        'error',
+        {
+          ignoreCase: true,
+          requiredFirst: false,
+          sortShapeProp: true,
+        },
+      ],
+
+      'sort-imports': [
+        'error',
+        {
+          ignoreDeclarationSort: true,
+          memberSyntaxSortOrder: ['single', 'multiple', 'all', 'none'],
+        },
+      ],
+
+      'sort-keys': 'off',
+      'no-constant-binary-expression': 'error',
+      'react/jsx-key': 'error',
+    },
+  },
+]

package/typescript.mjs

@@ -0,0 +1,77 @@
+import { fixupConfigRules } from '@eslint/compat'
+import { FlatCompat } from '@eslint/eslintrc'
+import deprecation from 'eslint-plugin-deprecation'
+import path from 'node:path'
+import { fileURLToPath } from 'node:url'
+import shared from './shared.mjs'
+
+const filename = fileURLToPath(import.meta.url)
+const dirname = path.dirname(filename)
+
+const compat = new FlatCompat({
+  baseDirectory: dirname,
+})
+
+export default [
+  ...fixupConfigRules(
+    compat.extends(
+      'eslint-config-airbnb',
+      'eslint-config-airbnb-typescript',
+      'plugin:@typescript-eslint/recommended',
+      'plugin:@typescript-eslint/recommended-requiring-type-checking',
+    ),
+  ),
+  ...shared,
+  {
+    plugins: {
+      deprecation,
+    },
+
+    rules: {
+      '@typescript-eslint/array-type': [
+        'error',
+        {
+          default: 'array',
+        },
+      ],
+
+      '@typescript-eslint/no-base-to-string': 'error',
+      '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
+      '@typescript-eslint/no-unnecessary-condition': 'error',
+      '@typescript-eslint/no-unnecessary-type-arguments': 'error',
+      '@typescript-eslint/no-unsafe-declaration-merging': 'error',
+      '@typescript-eslint/prefer-for-of': 'error',
+      '@typescript-eslint/prefer-includes': 'error',
+      '@typescript-eslint/prefer-optional-chain': 'error',
+      '@typescript-eslint/prefer-reduce-type-parameter': 'error',
+      '@typescript-eslint/prefer-string-starts-ends-with': 'error',
+      '@typescript-eslint/prefer-ts-expect-error': 'error',
+      '@typescript-eslint/no-floating-promises': 'error',
+
+      '@typescript-eslint/no-misused-promises': [
+        'error',
+        {
+          checksVoidReturn: {
+            attributes: false,
+          },
+        },
+      ],
+
+      '@typescript-eslint/no-explicit-any': 'warn',
+      '@typescript-eslint/no-unused-vars': 'error',
+      '@typescript-eslint/consistent-type-imports': 'error',
+      '@typescript-eslint/consistent-type-exports': 'error',
+      '@typescript-eslint/consistent-type-definitions': ['error', 'type'],
+      '@typescript-eslint/no-redundant-type-constituents': 'warn',
+      'react/require-default-props': 'off',
+      'react/prop-types': 'off',
+
+      'react/jsx-no-useless-fragment': [
+        'error',
+        {
+          allowExpressions: true,
+        },
+      ],
+    },
+  },
+]