@scaleway/eslint-config-react 3.13.8 → 3.14.0

package/CHANGELOG.md

@@ -3,6 +3,15 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [3.14.0](https://github.com/scaleway/scaleway-lib/compare/@scaleway/eslint-config-react@3.13.8...@scaleway/eslint-config-react@3.14.0) (2023-01-16)
+
+
+### :gear: Features
+
+* **eslint-config:** harden eslint config ([#1157](https://github.com/scaleway/scaleway-lib/issues/1157)) ([8087ac8](https://github.com/scaleway/scaleway-lib/commit/8087ac8cf8b06c23bbbf9f13d001468b61313cd6))
+
+
+
 ## 3.13.8 (2023-01-16)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@scaleway/eslint-config-react",
-  "version": "3.13.8",
+  "version": "3.14.0",
   "description": "Scaleway React eslint shared config",
   "keywords": [
     "eslint",
@@ -25,17 +25,17 @@
     "eslint-config-prettier": "8.6.0",
     "eslint-plugin-deprecation": "1.3.3",
     "eslint-plugin-eslint-comments": "3.2.0",
-    "eslint-plugin-import": "2.26.0",
-    "eslint-plugin-jsx-a11y": "6.7.0",
-    "eslint-plugin-react": "7.31.11",
+    "eslint-plugin-import": "2.27.4",
+    "eslint-plugin-jsx-a11y": "6.7.1",
+    "eslint-plugin-react": "7.32.0",
     "eslint-plugin-react-hooks": "4.6.0"
   },
   "peerDependencies": {
     "eslint": ">= 8.5"
   },
   "devDependencies": {
-    "eslint": "8.31.0",
+    "eslint": "8.32.0",
     "typescript": "4.9.4"
   },
-  "gitHead": "7157c5a9112897f1a9bdd06f1e7195324932d63c"
+  "gitHead": "223f265da52e3fe1041611f971a8de128e92cf16"
 }

package/shared.js

@@ -98,6 +98,10 @@ module.exports = {
     'react/no-adjacent-inline-elements': 'error', // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-adjacent-inline-elements.md
     'prefer-object-has-own': 'error', // https://eslint.org/docs/rules/prefer-object-has-own
 
+    // Prevent uneeded rerender with object as default props
+    // https://github.com/jsx-eslint/eslint-plugin-react/blob/c8f2813758dea1759ba5ab8caf1920cae9417a43/docs/rules/no-object-type-as-default-prop.md
+    'react/no-object-type-as-default-prop': 'error',
+
     // We don't use babel-preset-airbnb so we can make those changes
     'react/static-property-placement': ['error', 'static public field'],
     'react/state-in-constructor': ['error', 'never'],

package/typescript.js

@@ -9,6 +9,26 @@ module.exports = {
   plugins: ['deprecation', '@typescript-eslint'],
   rules: {
     'deprecation/deprecation': 'warn',
+    // Enforce T[] instead of Array<T>
+    '@typescript-eslint/array-type': [
+      'error',
+      {
+        default: 'array',
+      },
+    ],
+    // Avoid toString which are going to generate [object Object]
+    '@typescript-eslint/no-base-to-string': 'error',
+    // (someCondition === true) => (someCondition)
+    '@typescript-eslint/no-unnecessary-boolean-literal-compare': 'error',
+    '@typescript-eslint/no-unnecessary-condition': 'error',
+    '@typescript-eslint/no-unnecessary-type-arguments': 'error',
+    '@typescript-eslint/no-unsafe-declaration-merging': 'error',
+    '@typescript-eslint/prefer-for-of': 'error',
+    '@typescript-eslint/prefer-includes': 'error',
+    '@typescript-eslint/prefer-optional-chain': 'error',
+    '@typescript-eslint/prefer-reduce-type-parameter': 'error',
+    '@typescript-eslint/prefer-string-starts-ends-with': 'error',
+    '@typescript-eslint/prefer-ts-expect-error': 'error',
     // https://github.com/typescript-eslint/typescript-eslint/issues/4619
     '@typescript-eslint/no-misused-promises': [
       'error',