@sayknow-cli/coding-agent 0.3.7 → 0.3.9

package/src/prompts/tools/task.md

@@ -3,12 +3,11 @@ Launches subagents to parallelize workflows.
 - Results are delivered automatically when complete.
 - The tool result lists the assigned task ids (e.g. `0-AuthLoader`) — those are the live agent ids.
 {{#if ircEnabled}}
-- Coordinate with running tasks via `irc` using those ids. `subagent` cancel terminates a task and **cannot carry a message** — never cancel because an await timed out; cancel only when the task has actually failed, gone off-track, or become unrecoverably wrong.
-- If genuinely blocked on completion, wait with `subagent` action `await` and a timeout; timeout only bounds your wait and does not stop or fail the subagent.
+- Coordinate with running tasks via `irc` using those ids. `subagent` cancel terminates a task and **cannot carry a message**.
 {{else}}
-- If genuinely blocked on completion, wait with `subagent` action `await` and a timeout; timeout only bounds your wait and does not stop or fail the subagent.
-- Use `subagent` action `inspect` or `list` to snapshot manager state; `cancel` only when a task has actually failed, gone off-track, or become unrecoverably wrong.
+- Use `subagent` action `inspect` or `list` to snapshot manager state.
 {{/if}}
+- To wait or cancel, use the `subagent` tool; its await/cancel doctrine applies (never cancel just because an await timed out).
 
 {{#if ircEnabled}}
 Subagents have no conversation history, but they can reach you and their siblings live via the `irc` tool. Front-load every fact, file path, and direction they need in {{#if contextEnabled}}`context` or `assignment`{{else}}each `assignment`{{/if}}.
@@ -19,7 +18,7 @@ Subagents have no conversation history. Every fact, file path, and direction the
 <parameters>
 - `agent`: agent type for all tasks
 - `tasks`: tasks to execute in parallel
- - `.id`: CamelCase, ≤32 chars
+ - `.id`: filesystem-safe, ≤48 chars, matching `[A-Za-z0-9][A-Za-z0-9_-]*`; prefer CamelCase
  - `.description`: UI label only — subagent never sees it
  - `.assignment`: complete self-contained instructions; one-liners and missing acceptance criteria are PROHIBITED
 {{#if contextEnabled}}- `context`: shared background prepended to every assignment; session-specific only{{/if}}

package/src/prompts/tools/todo-write.md

@@ -12,7 +12,7 @@ Allowed `op` values are only `init`, `start`, `done`, `drop`, `rm`, `append`, an
 |`start`|`task`|Mark in progress|
 |`done`|`task` or `phase`|Mark completed|
 |`drop`|`task` or `phase`|Mark abandoned|
-|`rm`|`task` or `phase`|Remove|
+|`rm`|`task` or `phase` or *(none = clear all tasks)*|Remove a task; with `phase`, empties the phase (the phase entry remains); bare `rm` clears every task in every phase|
 |`append`|`phase`, `items: string[]`|Append tasks to `phase`; lazily creates phase|
 |`note`|`task`, `text`|Append a note to a task. Reminders for future-you only.|
 

package/src/prompts/tools/vim.md

@@ -1,6 +1,7 @@
 Vim-style `edit` mode. The tool name stays `edit`; every call requires `file`, and the buffer loads automatically on first use.
 - `{"file": "path"}` - view file
 - `{"file": "path", "steps": [{"kbd": ["…"], "insert": "…"}]}` - edit file
+- `pause` (optional boolean) - a "paused" call skips the auto-save after its steps and may leave the last step in INSERT mode; the buffer stays open for the next call. Non-paused calls auto-save once after all steps complete.
 
 **Multi-location edits: always edit highest line number first (bottom-up).** Each insert shifts lines below it.
 

package/src/prompts/tools/web-search.md

@@ -3,9 +3,11 @@ Searches the web for up-to-date information beyond knowledge cutoff.
 <instruction>
 - You SHOULD prefer primary sources (papers, official docs) and corroborate key claims with multiple sources
 - You MUST include links for cited sources in the final response
+- Provider-neutral params: `recency` (freshness window), `limit`/`num_search_results` (result counts), `max_tokens`, `temperature`
 </instruction>
 
 <xai>
+The parameters below apply ONLY when the active search provider is `xai`; ignore them (and never pass them) on any other provider.
 - With provider `xai`, use `xai_search_mode: "web"` for normal web search, `"x"` for X/Twitter search, or `"web_and_x"` when both surfaces are relevant.
 - xAI web filters: `allowed_domains` or `excluded_domains` (max 5, mutually exclusive), plus `enable_image_understanding` and `enable_image_search`.
 - xAI X filters: `allowed_x_handles` or `excluded_x_handles` (max 20, mutually exclusive), `from_date`, `to_date`, `enable_image_understanding`, and `enable_video_understanding`.

package/src/prompts/tools/write.md

@@ -3,10 +3,16 @@ Creates or overwrites file at specified path.
 <conditions>
 - Creating new files explicitly required by task
 - Replacing entire file contents when editing would be more complex
-- Supports `.tar`, `.tar.gz`, `.tgz`, and `.zip` archive entries via `archive.ext:path/inside/archive`
-- Supports SQLite row operations via `db.sqlite:table` (insert), `db.sqlite:table:key` (update with JSON content, delete with empty content)
 </conditions>
 
+<instruction>
+- Archives: write entries inside `.tar`, `.tar.gz`, `.tgz`, and `.zip` via `archive.ext:path/inside/archive`.
+- SQLite rows:
+  - `db.sqlite:table` with JSON content — insert a row
+  - `db.sqlite:table:key` with JSON content — update the row with that primary key
+  - `db.sqlite:table:key` with empty content — DELETE that row (destructive; double-check the key)
+</instruction>
+
 <critical>
 - You SHOULD use Edit tool for modifying existing files (more precise, preserves formatting)
 - You NEVER create documentation files (*.md, README) unless explicitly requested

package/src/runtime-api-key.ts

@@ -0,0 +1,16 @@
+export interface RuntimeApiKeyTarget {
+	setRuntimeApiKey(provider: string, apiKey: string): void;
+}
+
+export interface RuntimeApiKeyModel {
+	provider: string;
+}
+
+export function applyCliRuntimeApiKeyOverride(
+	target: RuntimeApiKeyTarget,
+	apiKey: string | undefined,
+	model: RuntimeApiKeyModel | undefined,
+): void {
+	if (!apiKey || !model) return;
+	target.setRuntimeApiKey(model.provider, apiKey);
+}

package/src/sdk.ts

@@ -4,7 +4,7 @@ import {
 	type AgentMessage,
 	type AgentTelemetryConfig,
 	type AgentTool,
-	AppendOnlyContextManager,
+	type AppendOnlyContextManager,
 	INTENT_FIELD,
 	type ThinkingLevel,
 } from "@sayknow-cli/agent-core";
@@ -32,7 +32,11 @@ import {
 	prompt,
 	Snowflake,
 } from "@sayknow-cli/utils";
-
+import {
+	createAppendOnlyContextManager,
+	providerSupportsAppendOnlyAuto,
+	resolveAppendOnlyMode,
+} from "./append-only-mode";
 import { type AsyncJob, AsyncJobManager, isBackgroundJobSupportEnabled, jobElapsedMs } from "./async";
 import { loadCapability } from "./capability";
 import { type Rule, ruleCapability, setActiveRules } from "./capability/rule";
@@ -119,7 +123,12 @@ import {
 } from "./system-prompt";
 import { AgentOutputManager } from "./task/output-manager";
 import { parseThinkingLevel, resolveThinkingLevelForModel, toReasoningEffort } from "./thinking";
-import { collectDiscoverableTools, type DiscoverableTool } from "./tool-discovery/tool-index";
+import {
+	collectDiscoverableTools,
+	type DiscoverableTool,
+	isMCPBridgeTool,
+	isMCPToolName,
+} from "./tool-discovery/tool-index";
 import {
 	applyConfiguredSearchTimeout,
 	BashTool,
@@ -617,23 +626,12 @@ function registerJsVmCleanup(): void {
 	postmortem.register("js-vm-cleanup", disposeAllVmContexts);
 }
 
-/**
- * Resolve whether to enable append-only context mode based on the setting and provider.
- *
- * - `"on"` → always enable
- * - `"off"` → never enable
- * - `"auto"` → enable for DeepSeek (prefix-caching provider)
+/*
+ * Append-only context-mode resolution + manager construction live in
+ * ./append-only-mode so the initial build, the runtime model/setting-change
+ * path, and the status UI share one implementation. Re-exported for importers/tests.
  */
-function resolveAppendOnlyMode(setting: "auto" | "on" | "off" | undefined, provider: string): boolean {
-	switch (setting ?? "auto") {
-		case "on":
-			return true;
-		case "off":
-			return false;
-		default:
-			return provider === "deepseek";
-	}
-}
+export { createAppendOnlyContextManager, providerSupportsAppendOnlyAuto, resolveAppendOnlyMode };
 
 function customToolToDefinition(tool: CustomTool): ToolDefinition {
 	const definition: ToolDefinition & { [TOOL_DEFINITION_MARKER]: true } = {
@@ -868,6 +866,10 @@ function withEmbeddedDefaultSkcSkills(skills: Skill[]): Skill[] {
 	return [...byName.values()];
 }
 
+export function resolveIntentTracingEnabled(intentTracingSetting: boolean | undefined, hasUI: boolean): boolean {
+	return (!!intentTracingSetting || $flag("PI_INTENT_TRACING")) && hasUI;
+}
+
 export async function createAgentSession(options: CreateAgentSessionOptions = {}): Promise<CreateAgentSessionResult> {
 	const cwd = options.cwd ?? getProjectDir();
 	const agentDir = options.agentDir ?? getDefaultAgentDir();
@@ -1127,8 +1129,15 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 				rulebookRules.push(rule);
 			}
 		}
-		if (existingSession.injectedTtsrRules.length > 0) {
-			ttsrManager.restoreInjected(existingSession.injectedTtsrRules);
+		if (ttsrManager.getSettings().enabled !== false) {
+			if ((existingSession.ttsrMessageCount ?? 0) > 0) {
+				ttsrManager.restoreMessageCount(existingSession.ttsrMessageCount ?? 0);
+			}
+			if (existingSession.injectedTtsrRuleRecords && existingSession.injectedTtsrRuleRecords.length > 0) {
+				ttsrManager.restoreInjected(existingSession.injectedTtsrRuleRecords);
+			} else if (existingSession.injectedTtsrRules.length > 0) {
+				ttsrManager.restoreInjected(existingSession.injectedTtsrRules);
+			}
 		}
 		return { ttsrManager, rulebookRules, alwaysApplyRules };
 	});
@@ -1216,8 +1225,8 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 
 	const agentRegistry = options.agentRegistry ?? AgentRegistry.global();
 	const resolvedAgentId = options.agentId ?? options.parentTaskPrefix ?? MAIN_AGENT_ID;
-	const resolvedAgentDisplayName =
-		options.agentDisplayName ?? ((options.taskDepth ?? 0) > 0 || options.parentTaskPrefix ? "sub" : "main");
+	const isSubSession = taskDepth > 0 || Boolean(options.parentTaskPrefix) || Boolean(options.currentAgentType);
+	const resolvedAgentDisplayName = options.agentDisplayName ?? (isSubSession ? "sub" : "main");
 	const evalKernelOwnerId = `agent-session:${Snowflake.next()}`;
 
 	try {
@@ -1522,12 +1531,20 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 		}
 		let notificationCfg: NotificationConfig | undefined;
 		try {
-			notificationCfg = getNotificationConfig(Settings.instance);
+			notificationCfg = getNotificationConfig(settings);
 		} catch {
 			notificationCfg = undefined;
 		}
-		if (shouldRegisterNotificationsExtension({ env: process.env, cfg: notificationCfg })) {
-			inlineExtensions.push(createNotificationsExtension);
+		if (
+			shouldRegisterNotificationsExtension({
+				env: process.env,
+				cfg: notificationCfg,
+				taskDepth,
+				parentTaskPrefix: options.parentTaskPrefix,
+				currentAgentType: options.currentAgentType,
+			})
+		) {
+			inlineExtensions.push(api => createNotificationsExtension(api, { settings }));
 		}
 
 		// Extension/module discovery is quarantined; retain only the private
@@ -1655,6 +1672,12 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 				cwd,
 				sessionManager,
 				modelRegistry,
+				{
+					kind: isSubSession ? "sub" : "main",
+					taskDepth,
+					...(options.parentTaskPrefix ? { parentTaskPrefix: options.parentTaskPrefix } : {}),
+					...(options.currentAgentType ? { currentAgentType: options.currentAgentType } : {}),
+				},
 			);
 		}
 
@@ -1774,7 +1797,11 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 
 		const repeatToolDescriptions = settings.get("repeatToolDescriptions");
 		const eagerTasks = settings.get("task.eager");
-		const intentField = settings.get("tools.intentTracing") || $flag("PI_INTENT_TRACING") ? INTENT_FIELD : undefined;
+		const intentTracingEnabled = resolveIntentTracingEnabled(
+			settings.get("tools.intentTracing"),
+			options.hasUI ?? false,
+		);
+		const intentField = intentTracingEnabled ? INTENT_FIELD : undefined;
 		const rebuildSystemPrompt = async (
 			toolNames: string[],
 			tools: Map<string, AgentTool>,
@@ -1790,7 +1817,15 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 							{ source: "builtin" },
 						)
 					: [];
-			const discoverableToolsForDesc: DiscoverableTool[] = [...discoverableBuiltinTools];
+			const discoverableMCPTools: DiscoverableTool[] = mcpDiscoveryEnabled
+				? collectDiscoverableTools(
+						Array.from(tools.values()).filter(
+							tool => isMCPToolName(tool.name) && !activeToolNames.has(tool.name),
+						),
+						{ source: "mcp" },
+					)
+				: [];
+			const discoverableToolsForDesc: DiscoverableTool[] = [...discoverableBuiltinTools, ...discoverableMCPTools];
 			const promptTools = buildSystemPromptToolMetadata(tools, {
 				search_tool_bm25: { description: renderSearchToolBm25Description(discoverableToolsForDesc) },
 			});
@@ -1839,13 +1874,14 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 				intentField,
 				mcpDiscoveryMode: false,
 				mcpDiscoveryServerSummaries: [],
-				toolDiscoveryActive: effectiveDiscoveryMode === "all",
-				discoverableTools: discoverableBuiltinTools
+				toolDiscoveryActive: effectiveDiscoveryMode === "all" || mcpDiscoveryEnabled,
+				discoverableTools: [...discoverableBuiltinTools, ...discoverableMCPTools]
 					.map(tool => ({ name: tool.name, summary: tool.summary }))
 					.sort((a, b) => a.name.localeCompare(b.name)),
 				eagerTasks,
 				secretsEnabled,
 				workspaceTree: workspaceTreePromise,
+				subagent: options.parentTaskPrefix !== undefined,
 			});
 
 			if (options.systemPrompt === undefined) {
@@ -1870,11 +1906,12 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 			: toolNamesFromRegistry;
 		const normalizedRequested = requestedToolNames.filter(name => toolRegistry.has(name));
 		const requestedToolNameSet = new Set(normalizedRequested);
-		// Effective discovery mode only covers built-in tools; MCP tool discovery
-		// is quarantined from the SKC public surface.
+		// Generic tool discovery hides non-essential built-ins behind search_tool_bm25.
+		// Legacy MCP discovery remains separately controlled by mcp.discoveryMode so
+		// loaded MCP catalogs can be searched without enabling every hidden built-in.
 		const toolsDiscoveryModeSetting = settings.get("tools.discoveryMode");
 		const effectiveDiscoveryMode: "off" | "all" = toolsDiscoveryModeSetting === "all" ? "all" : "off";
-		const mcpDiscoveryEnabled = false;
+		const mcpDiscoveryEnabled = settings.get("mcp.discoveryMode") === true;
 		const defaultInactiveToolNames = new Set(
 			registeredTools.filter(tool => tool.definition.defaultInactive).map(tool => tool.definition.name),
 		);
@@ -1887,6 +1924,20 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 		const discoveryDefaultServerToolNames: string[] = [];
 		let initialSelectedMCPToolNames: string[] = [];
 		let defaultSelectedMCPToolNames: string[] = [];
+		if (mcpDiscoveryEnabled) {
+			const defaultServerNames = new Set(settings.get("mcp.discoveryDefaultServers") ?? []);
+			for (const tool of toolRegistry.values()) {
+				if (!isMCPBridgeTool(tool)) continue;
+				discoverableMCPToolNames.add(tool.name);
+				if (initialRequestedActiveToolNames.includes(tool.name)) {
+					explicitlyRequestedMCPToolNames.push(tool.name);
+				}
+				const serverName = (tool as AgentTool & { mcpServerName?: string }).mcpServerName;
+				if (serverName && defaultServerNames.has(serverName)) {
+					discoveryDefaultServerToolNames.push(tool.name);
+				}
+			}
+		}
 		let initialToolNames = [...initialRequestedActiveToolNames];
 		if (mcpDiscoveryEnabled) {
 			const restoredSelectedMCPToolNames = existingSession.selectedMCPToolNames.filter(name =>
@@ -1947,7 +1998,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 		agentRegistry.register({
 			id: resolvedAgentId,
 			displayName: resolvedAgentDisplayName,
-			kind: (options.taskDepth ?? 0) > 0 || options.parentTaskPrefix ? "sub" : "main",
+			kind: isSubSession ? "sub" : "main",
 			parentId: options.parentTaskPrefix,
 			session: null,
 			sessionFile: sessionManager.getSessionFile() ?? null,
@@ -2045,7 +2096,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 
 		const appendOnlyContext =
 			model && resolveAppendOnlyMode(settings.get("provider.appendOnlyContext"), model.provider)
-				? new AppendOnlyContextManager()
+				? createAppendOnlyContextManager(model.provider)
 				: undefined;
 		if (appendOnlyContext && options.forkContextSeed && !hasExistingSession) {
 			if (options.forkContextSeed.appendOnlyPrefixSnapshot) {
@@ -2216,6 +2267,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 			onResponse,
 			convertToLlm: convertToLlmFinal,
 			rebuildSystemPrompt,
+			workspaceTree: resolvedWorkspaceTree,
 			reloadSshTool,
 			requestedToolNames: requestedToolNameSet,
 			discoverableToolAllowedNames: options.discoverableToolAllowedNames,
@@ -2237,7 +2289,7 @@ export async function createAgentSession(options: CreateAgentSessionOptions = {}
 			initialSelectedMCPToolNames,
 			defaultSelectedMCPToolNames,
 			persistInitialMCPToolSelection: !hasExistingSession,
-			defaultSelectedMCPServerNames: [],
+			defaultSelectedMCPServerNames: settings.get("mcp.discoveryDefaultServers") ?? [],
 			ttsrManager,
 			obfuscator,
 			agentId: resolvedAgentId,