@sayknow-cli/coding-agent 0.3.7 → 0.3.8

package/src/modes/components/settings-selector.ts

@@ -669,6 +669,8 @@ export interface SettingsRuntimeContext {
 	thinkingLevel: ThinkingLevel | undefined;
 	/** Available themes */
 	availableThemes: string[];
+	/** Available model profile names (from the model registry) */
+	availableModelProfiles: string[];
 	/** Working directory for plugins tab */
 	cwd: string;
 }
@@ -861,6 +863,8 @@ export class SettingsSelectorComponent extends Container {
 			});
 		} else if (def.path === "theme.dark" || def.path === "theme.light") {
 			options = this.context.availableThemes.map(t => ({ value: t, label: t }));
+		} else if (def.path === "modelProfile.default") {
+			options = this.context.availableModelProfiles.map(p => ({ value: p, label: p }));
 		}
 		if (def.path === "statusLine.preset") {
 			options = options.filter(option => option.value !== "custom");

package/src/modes/components/status-line.ts

@@ -175,6 +175,9 @@ export class StatusLineComponent implements Component {
 	#settings: StatusLineSettings = {};
 	#cachedBranch: string | null | undefined = undefined;
 	#cachedBranchRepoId: string | null | undefined = undefined;
+	#branchProjectDir: string | undefined;
+	#branchLastFetch = 0;
+	#branchInFlight = false;
 	#gitWatcher: fs.FSWatcher | null = null;
 	#onBranchChange: (() => void) | null = null;
 	#autoCompactEnabled: boolean = true;
@@ -188,6 +191,14 @@ export class StatusLineComponent implements Component {
 	#skillHudLastFetch = 0;
 	#skillHudInFlight = false;
 	#version: string | undefined;
+	#resolvedSettingsCache:
+		| (Required<Pick<StatusLineSettings, "leftSegments" | "rightSegments" | "separator" | "segmentOptions">> &
+				StatusLineSettings)
+		| undefined;
+	#resolvedSettingsFingerprint: string | undefined;
+	#renderedRowsCache: { key: string; rows: string[] } | undefined;
+	#renderedRowsCacheHits = 0;
+	#renderedRowsCacheMisses = 0;
 
 	// Git status caching (1s TTL)
 	#cachedGitStatus: { staged: number; unstaged: number; untracked: number } | null = null;
@@ -320,18 +331,39 @@ export class StatusLineComponent implements Component {
 	#invalidateGitCaches(): void {
 		this.#cachedBranch = undefined;
 		this.#cachedBranchRepoId = undefined;
+		this.#branchProjectDir = undefined;
 		this.#cachedPrContext = undefined;
+		this.#branchLastFetch = 0;
+		this.#branchInFlight = false;
+		this.#renderedRowsCache = undefined;
 	}
 	#getCurrentBranch(): string | null {
-		const current = resolveCurrentBranch(getProjectDir());
-		if (this.#cachedBranch !== undefined && this.#cachedBranchRepoId === current.repoId) {
-			return this.#cachedBranch;
+		const now = Date.now();
+		const projectDir = getProjectDir();
+		const withinTtl =
+			this.#cachedBranch !== undefined &&
+			this.#branchProjectDir === projectDir &&
+			Date.now() - this.#branchLastFetch < 1000;
+		if (withinTtl || this.#branchInFlight) {
+			return this.#cachedBranch ?? null;
 		}
 
-		this.#cachedBranchRepoId = current.repoId;
-		this.#cachedBranch = current.branch;
-
-		return this.#cachedBranch ?? null;
+		this.#branchInFlight = true;
+		try {
+			const current = resolveCurrentBranch(projectDir);
+			this.#cachedBranchRepoId = current.repoId;
+			this.#cachedBranch = current.branch;
+			this.#branchProjectDir = projectDir;
+			return this.#cachedBranch ?? null;
+		} catch {
+			this.#cachedBranchRepoId = null;
+			this.#cachedBranch = null;
+			this.#branchProjectDir = projectDir;
+			return null;
+		} finally {
+			this.#branchLastFetch = now;
+			this.#branchInFlight = false;
+		}
 	}
 
 	#isDefaultBranch(branch: string): boolean {
@@ -467,7 +499,7 @@ export class StatusLineComponent implements Component {
 		const cwd = typeof getCwd === "function" ? getCwd.call(this.session.sessionManager) : getProjectDir();
 		const sessionId = typeof getSessionId === "function" ? getSessionId.call(this.session.sessionManager) : undefined;
 		this.#skillHudInFlight = true;
-		void readVisibleSkillActiveState(cwd, sessionId)
+		void readVisibleSkillActiveState(cwd, sessionId, { tier: "hud" })
 			.then(state => {
 				this.#skillHudEntries = state?.active_skills ?? [];
 			})
@@ -637,7 +669,13 @@ export class StatusLineComponent implements Component {
 		return `${modelId}|${sp.length}:${sp[0]?.length ?? 0}|${tools.length}|${skills.length}`;
 	}
 
-	#buildSegmentContext(width: number): SegmentContext {
+	#buildSegmentContext(
+		width: number,
+		effectiveSettings: Required<
+			Pick<StatusLineSettings, "leftSegments" | "rightSegments" | "separator" | "segmentOptions">
+		> &
+			StatusLineSettings,
+	): SegmentContext {
 		const state = this.session.state;
 
 		// Trigger background fetch (5-min TTL); render uses cached value
@@ -666,7 +704,7 @@ export class StatusLineComponent implements Component {
 		return {
 			session: this.session,
 			width,
-			options: this.#resolveSettings().segmentOptions ?? {},
+			options: effectiveSettings.segmentOptions ?? {},
 			planMode: this.#planModeStatus,
 			goalMode: this.#goalModeStatus,
 			usageStats,
@@ -685,10 +723,19 @@ export class StatusLineComponent implements Component {
 		};
 	}
 
+	#settingsFingerprint(): string {
+		return JSON.stringify(this.#settings);
+	}
+
 	#resolveSettings(): Required<
 		Pick<StatusLineSettings, "leftSegments" | "rightSegments" | "separator" | "segmentOptions">
 	> &
 		StatusLineSettings {
+		const fingerprint = this.#settingsFingerprint();
+		if (this.#resolvedSettingsCache && this.#resolvedSettingsFingerprint === fingerprint) {
+			return this.#resolvedSettingsCache;
+		}
+
 		const preset = this.#settings.preset ?? "default";
 		const presetDef = getPreset(preset);
 		const useCustomSegments = preset === "custom";
@@ -713,13 +760,15 @@ export class StatusLineComponent implements Component {
 			? (this.#settings.rightSegments ?? presetDef.rightSegments)
 			: presetDef.rightSegments;
 
-		return {
+		this.#resolvedSettingsFingerprint = fingerprint;
+		this.#resolvedSettingsCache = {
 			...this.#settings,
 			leftSegments,
 			rightSegments,
 			separator: this.#settings.separator ?? presetDef.separator,
 			segmentOptions: mergedSegmentOptions,
 		};
+		return this.#resolvedSettingsCache;
 	}
 
 	#groupWidth(parts: string[], capWidth: number, sepWidth: number): number {
@@ -785,9 +834,14 @@ export class StatusLineComponent implements Component {
 		return reRendered.content;
 	}
 
-	#collectStatusSegments(width: number): CollectedStatusSegments {
-		const ctx = this.#buildSegmentContext(width);
-		const effectiveSettings = this.#resolveSettings();
+	#collectStatusSegments(
+		width: number,
+		effectiveSettings: Required<
+			Pick<StatusLineSettings, "leftSegments" | "rightSegments" | "separator" | "segmentOptions">
+		> &
+			StatusLineSettings,
+	): CollectedStatusSegments {
+		const ctx = this.#buildSegmentContext(width, effectiveSettings);
 		const separatorDef = getSeparator(effectiveSettings.separator ?? "powerline-thin", theme);
 
 		// Use the subtle surface tone (the same elevated background as user-message
@@ -856,7 +910,7 @@ export class StatusLineComponent implements Component {
 	}
 
 	#buildStatusLine(width: number, precollected?: CollectedStatusSegments): string {
-		const seg = precollected ?? this.#collectStatusSegments(width);
+		const seg = precollected ?? this.#collectStatusSegments(width, this.#resolveSettings());
 		const { ctx, separatorDef, bgAnsi, fgAnsi, sepAnsi, previewHighlightSegment } = seg;
 		const { leftSepWidth, rightSepWidth, leftCapWidth, rightCapWidth } = seg;
 		const left = [...seg.left];
@@ -915,8 +969,52 @@ export class StatusLineComponent implements Component {
 	 * everything fits on one line.
 	 */
 	#buildStatusRows(width: number, maxRows: number): string[] {
-		const seg = this.#collectStatusSegments(width);
-		if (seg.left.length === 0 && seg.right.length === 0) return [];
+		const effectiveSettings = this.#resolveSettings();
+		const seg = this.#collectStatusSegments(width, effectiveSettings);
+		const cacheKey = JSON.stringify({
+			width,
+			maxRows,
+			settings: this.#resolvedSettingsFingerprint,
+			left: seg.left,
+			leftSegIds: seg.leftSegIds,
+			right: seg.right,
+			separator: effectiveSettings.separator,
+			previewHighlightSegment: seg.previewHighlightSegment,
+			sessionAccent: seg.sessionAccent,
+			theme: [seg.bgAnsi, seg.fgAnsi, seg.sepAnsi],
+			rowLayout: {
+				separatorLeft: seg.separatorDef.left,
+				separatorRight: seg.separatorDef.right,
+				separatorEndCapLeft: seg.separatorDef.endCaps?.left,
+				separatorEndCapRight: seg.separatorDef.endCaps?.right,
+				separatorEndCapUseBgAsFg: seg.separatorDef.endCaps?.useBgAsFg,
+				borderFgAnsi: theme.getFgAnsi("border"),
+				boxRoundHorizontal: theme.boxRound.horizontal,
+			},
+			context: [seg.ctx.contextPercent, seg.ctx.contextWindow],
+			usageStats: seg.ctx.usageStats,
+			usage: seg.ctx.usage,
+			git: seg.ctx.git,
+			modes: [seg.ctx.planMode, seg.ctx.goalMode, seg.ctx.autoCompactEnabled],
+			runtime: [seg.ctx.subagentCount, seg.ctx.jobs, seg.ctx.sessionStartTime],
+			sessionName: seg.sessionAccent !== false ? this.session.sessionManager?.getSessionName() : undefined,
+			asyncJobs: this.session
+				.getAsyncJobSnapshot()
+				?.running.filter(job => job.metadata?.monitor !== true)
+				.map(job => job.id ?? job.metadata ?? job)
+				.join(","),
+			version: this.#version,
+		});
+		if (this.#renderedRowsCache?.key === cacheKey) {
+			this.#renderedRowsCacheHits++;
+			return [...this.#renderedRowsCache.rows];
+		}
+		this.#renderedRowsCacheMisses++;
+
+		if (seg.left.length === 0 && seg.right.length === 0) {
+			this.#renderedRowsCache = { key: cacheKey, rows: [] };
+			return [];
+		}
 
 		const topFillWidth = Math.max(1, width);
 		const leftWidth = this.#groupWidth(seg.left, seg.leftCapWidth, seg.leftSepWidth);
@@ -924,51 +1022,52 @@ export class StatusLineComponent implements Component {
 		const gap = seg.left.length > 0 && seg.right.length > 0 ? 1 : 0;
 		const fitsSingleRow = leftWidth + rightWidth + gap <= topFillWidth;
 
+		let rows: string[];
 		if (maxRows <= 1 || fitsSingleRow) {
 			const single = this.#buildStatusLine(width, seg);
-			return single ? [single] : [];
-		}
-
-		// Ordered sequence: left segments first (in order), then right segments.
-		const items: { content: string; isPath: boolean }[] = [
-			...seg.left.map((content, i) => ({ content, isPath: seg.leftSegIds[i] === "path" })),
-			...seg.right.map(content => ({ content, isPath: false })),
-		];
-
-		// Pre-shrink an over-wide path so it never blows out a row on its own.
-		for (const item of items) {
-			if (!item.isPath) continue;
-			const alone = this.#groupWidth([item.content], seg.leftCapWidth, seg.leftSepWidth);
-			if (alone > topFillWidth) {
-				const shrunk = this.#shrinkPathToWidth(item.content, seg.ctx, alone - topFillWidth);
-				if (shrunk !== null) item.content = shrunk;
+			rows = single ? [single] : [];
+		} else {
+			const items: { content: string; isPath: boolean }[] = [
+				...seg.left.map((content, i) => ({ content, isPath: seg.leftSegIds[i] === "path" })),
+				...seg.right.map(content => ({ content, isPath: false })),
+			];
+
+			for (const item of items) {
+				if (!item.isPath) continue;
+				const alone = this.#groupWidth([item.content], seg.leftCapWidth, seg.leftSepWidth);
+				if (alone > topFillWidth) {
+					const shrunk = this.#shrinkPathToWidth(item.content, seg.ctx, alone - topFillWidth);
+					if (shrunk !== null) item.content = shrunk;
+				}
 			}
-		}
 
-		// Greedy pack into up to `maxRows` left-justified rows.
-		const rows: string[][] = [];
-		let current: string[] = [];
-		for (const item of items) {
-			if (current.length === 0) {
-				current.push(item.content);
-				continue;
+			const packedRows: string[][] = [];
+			let current: string[] = [];
+			for (const item of items) {
+				if (current.length === 0) {
+					current.push(item.content);
+					continue;
+				}
+				const tentative = [...current, item.content];
+				if (this.#groupWidth(tentative, seg.leftCapWidth, seg.leftSepWidth) <= topFillWidth) {
+					current = tentative;
+				} else {
+					packedRows.push(current);
+					current = [item.content];
+					if (packedRows.length >= maxRows) break;
+				}
 			}
-			const tentative = [...current, item.content];
-			if (this.#groupWidth(tentative, seg.leftCapWidth, seg.leftSepWidth) <= topFillWidth) {
-				current = tentative;
-			} else {
-				rows.push(current);
-				current = [item.content];
-				if (rows.length >= maxRows) break;
+			if (packedRows.length < maxRows && current.length > 0) {
+				packedRows.push(current);
 			}
-		}
-		if (rows.length < maxRows && current.length > 0) {
-			rows.push(current);
+
+			rows = packedRows.map(row =>
+				this.#renderStatusGroup(row, "left", seg.separatorDef, seg.bgAnsi, seg.fgAnsi, seg.sepAnsi),
+			);
 		}
 
-		return rows.map(row =>
-			this.#renderStatusGroup(row, "left", seg.separatorDef, seg.bgAnsi, seg.fgAnsi, seg.sepAnsi),
-		);
+		this.#renderedRowsCache = { key: cacheKey, rows };
+		return [...rows];
 	}
 
 	getTopBorder(width: number): { content: string; width: number } {
@@ -989,6 +1088,20 @@ export class StatusLineComponent implements Component {
 		return this.#buildStatusRows(width, this.#resolveMaxRows()).join("\n");
 	}
 
+	getCacheStatsForTest(): { rowHits: number; rowMisses: number } {
+		return { rowHits: this.#renderedRowsCacheHits, rowMisses: this.#renderedRowsCacheMisses };
+	}
+
+	invalidateBranchForTest(): void {
+		this.#invalidateGitCaches();
+	}
+
+	setCachedPrForTest(pr: { number: number; url: string } | null): void {
+		const branch = this.#getCurrentBranch();
+		this.#cachedPr = pr;
+		this.#cachedPrContext = branch ? createPrCacheContext(branch, this.#cachedBranchRepoId ?? null) : undefined;
+	}
+
 	render(width: number): string[] {
 		const lines: string[] = [];
 		this.#refreshSkillHudInBackground();

package/src/modes/components/tool-execution.ts

@@ -1,5 +1,6 @@
 import type { AgentTool } from "@sayknow-cli/agent-core";
 import {
+	type AnimationRegistration,
 	Box,
 	type Component,
 	Container,
@@ -7,6 +8,7 @@ import {
 	Image,
 	ImageProtocol,
 	imageFallback,
+	registerAnimationCallback,
 	Spacer,
 	TERMINAL,
 	Text,
@@ -51,6 +53,21 @@ function cloneToolArgs<T>(args: T): T {
 	}
 }
 
+// Built-in tool renderers that treat call args as read-only, so streaming UI can
+// avoid per-delta defensive clone churn. Kept here (not in the tool renderer
+// registry) because it is a rendering-perf capability of these renderers, not a
+// tool-registration concern.
+const READONLY_ARG_RENDERER_TOOLS = new Set(["bash", "recipe", "eval", "edit", "apply_patch"]);
+
+function argsCanBeSharedWithRenderer(toolName: string, tool: AgentTool | undefined): boolean {
+	return !tool?.renderCall && !tool?.renderResult && READONLY_ARG_RENDERER_TOOLS.has(toolName);
+}
+
+function partialJsonLength(args: unknown): number {
+	const value = args && typeof args === "object" ? (args as { __partialJson?: unknown }).__partialJson : undefined;
+	return typeof value === "string" ? value.length : -1;
+}
+
 /**
  * Drop trailing removal/hunk-header lines that appear in a streaming diff
  * before the matching `+added` lines have arrived. Without this, a partial
@@ -158,11 +175,14 @@ export class ToolExecutionComponent extends Container {
 	#editDiffPreview?: PerFileDiffPreview[];
 	#editDiffAbort?: AbortController;
 	#editDiffLastArgsKey?: string;
+	#argsIdentityVersion = 0;
+	#lastArgsReference: any;
+	#shareArgsWithRenderer = false;
 	// Cached converted images for Kitty protocol (which requires PNG), keyed by index
 	#convertedImages: Map<number, { data: string; mimeType: string }> = new Map();
 	// Spinner animation for partial task results
 	#spinnerFrame?: number;
-	#spinnerInterval?: NodeJS.Timeout;
+	#spinnerAnimation?: AnimationRegistration;
 	// Track if args are still being streamed (for edit/write spinner)
 	#argsComplete = false;
 	#renderState: {
@@ -194,7 +214,9 @@ export class ToolExecutionComponent extends Container {
 		this.#tool = tool;
 		this.#ui = ui;
 		this.#cwd = cwd;
-		this.#args = cloneToolArgs(args);
+		this.#shareArgsWithRenderer = argsCanBeSharedWithRenderer(toolName, tool);
+		this.#lastArgsReference = args;
+		this.#args = this.#shareArgsWithRenderer ? args : cloneToolArgs(args);
 
 		this.addChild(new Spacer(1));
 
@@ -220,7 +242,11 @@ export class ToolExecutionComponent extends Container {
 	}
 
 	updateArgs(args: any, _toolCallId?: string): void {
-		this.#args = cloneToolArgs(args);
+		if (args !== this.#lastArgsReference) {
+			this.#lastArgsReference = args;
+			this.#argsIdentityVersion += 1;
+		}
+		this.#args = this.#shareArgsWithRenderer ? args : cloneToolArgs(args);
 		this.#updateSpinnerAnimation();
 		void this.#runPreviewDiff();
 		this.#updateDisplay();
@@ -253,13 +279,13 @@ export class ToolExecutionComponent extends Container {
 			effectiveArgs = args;
 		}
 
-		// Coalesce duplicate computes for identical args.
-		let argsKey: string;
-		try {
-			argsKey = JSON.stringify(effectiveArgs);
-		} catch {
-			argsKey = String(Date.now());
-		}
+		// Coalesce duplicate computes without serializing multi-KB streamed args every delta.
+		const argsKey = [
+			this.#toolName,
+			this.#argsIdentityVersion,
+			partialJsonLength(args),
+			this.#argsComplete ? 1 : 0,
+		].join(":");
 		if (argsKey === this.#editDiffLastArgsKey) return;
 		this.#editDiffLastArgsKey = argsKey;
 
@@ -367,18 +393,17 @@ export class ToolExecutionComponent extends Container {
 			(this.#result?.details as { async?: { state?: string } } | undefined)?.async?.state === "running";
 		const isPartialTask = this.#isPartial && this.#toolName === "task" && !isBackgroundAsyncTask;
 		const needsSpinner = isStreamingArgs || isPartialTask;
-		if (needsSpinner && !this.#spinnerInterval) {
-			this.#spinnerInterval = setInterval(() => {
+		if (needsSpinner && !this.#spinnerAnimation) {
+			this.#spinnerAnimation = registerAnimationCallback(() => {
 				const frameCount = theme.spinnerFrames.length;
 				if (frameCount === 0) return;
 				this.#spinnerFrame = ((this.#spinnerFrame ?? -1) + 1) % frameCount;
 				this.#renderState.spinnerFrame = this.#spinnerFrame;
 				this.#ui.requestRender();
 			}, 80);
-			this.#spinnerInterval?.unref?.();
-		} else if (!needsSpinner && this.#spinnerInterval) {
-			clearInterval(this.#spinnerInterval);
-			this.#spinnerInterval = undefined;
+		} else if (!needsSpinner && this.#spinnerAnimation) {
+			this.#spinnerAnimation.unregister();
+			this.#spinnerAnimation = undefined;
 		}
 	}
 
@@ -386,9 +411,9 @@ export class ToolExecutionComponent extends Container {
 	 * Stop spinner animation and cleanup resources.
 	 */
 	stopAnimation(): void {
-		if (this.#spinnerInterval) {
-			clearInterval(this.#spinnerInterval);
-			this.#spinnerInterval = undefined;
+		if (this.#spinnerAnimation) {
+			this.#spinnerAnimation.unregister();
+			this.#spinnerAnimation = undefined;
 			this.#spinnerFrame = undefined;
 		}
 		this.#editDiffAbort?.abort();