@sayknow-cli/coding-agent 0.3.1 → 0.3.4

package/src/commands/session.ts

@@ -2,6 +2,7 @@ import { Args, Command, Flags } from "@sayknow-cli/utils/cli";
 import {
 	attachSkcTmuxSession,
 	createSkcTmuxSession,
+	forceCloseSkcTmuxSession,
 	listSkcTmuxSessions,
 	removeSkcTmuxSession,
 	statusSkcTmuxSession,
@@ -60,6 +61,12 @@ export default class Session extends Command {
 
 	static flags = {
 		json: Flags.boolean({ char: "j", description: "Emit machine-readable JSON", default: false }),
+		"session-id": Flags.string({
+			description: "Expected @skc-session-id tag for force-close (defense-in-depth match)",
+		}),
+		"state-file": Flags.string({
+			description: "Expected @skc-session-state-file tag for force-close (defense-in-depth match)",
+		}),
 	};
 
 	static examples = [
@@ -68,6 +75,7 @@ export default class Session extends Command {
 		"skc session status <session>",
 		"skc session attach <session>",
 		"skc session remove <session>",
+		"skc session force-close <session> --session-id <id>",
 	];
 
 	async run(): Promise<void> {
@@ -136,6 +144,16 @@ export default class Session extends Command {
 				return;
 			}
 
+			if (action === "force-close" || action === "force-remove") {
+				const closed = forceCloseSkcTmuxSession(sessionName, process.env, flags["session-id"], flags["state-file"]);
+				if (json) {
+					writeJson({ ok: true, session: sessionJson(closed) });
+					return;
+				}
+				writeText([`force-closed: ${closed.name}`]);
+				return;
+			}
+
 			if (action === "attach") {
 				attachSkcTmuxSession(sessionName);
 				return;

package/src/config/keybindings.ts

@@ -117,8 +117,8 @@ export const KEYBINDINGS = {
 		description: "Open external editor",
 	},
 	"app.message.followUp": {
-		defaultKeys: "ctrl+enter",
-		description: "Send follow-up message",
+		defaultKeys: [],
+		description: "Send follow-up message (no default; Ctrl+Enter inserts a newline)",
 	},
 	"app.message.queue": {
 		defaultKeys: "alt+enter",

package/src/config/model-profile-activation.ts

@@ -7,8 +7,14 @@ import {
 	formatAvailableProfileNames,
 	resolveProfileBindings,
 } from "./model-profiles";
-import { isAuthenticated, type ModelRegistry, type SkcModelAssignmentTargetId } from "./model-registry";
-import { resolveModelRoleValue } from "./model-resolver";
+import {
+	isAuthenticated,
+	kNoAuth,
+	type ModelRegistry,
+	SKC_MODEL_ASSIGNMENT_TARGETS,
+	type SkcModelAssignmentTargetId,
+} from "./model-registry";
+import { formatModelSelectorValue, resolveModelRoleValue } from "./model-resolver";
 import type { Settings } from "./settings";
 
 const LEGACY_MODEL_PROFILE_ALIASES: ReadonlyMap<string, string> = new Map([["codex-standard", "codex-medium"]]);
@@ -60,6 +66,48 @@ export interface PreparedModelProfileActivation {
 	 */
 	previousSessionDefaultModel: string | undefined;
 }
+export interface MaterializeModelProfileAssignmentOptions {
+	session: Pick<
+		ModelProfileActivationSession,
+		"model" | "thinkingLevel" | "setActiveModelProfile" | "getActiveModelProfile"
+	>;
+	settings: Pick<Settings, "clearOverride" | "get" | "override" | "set">;
+	role: SkcModelAssignmentTargetId;
+	selector: string;
+}
+
+export function materializeActiveModelProfileAssignment(options: MaterializeModelProfileAssignmentOptions): boolean {
+	const activeProfile = options.session.getActiveModelProfile?.() ?? options.settings.get("modelProfile.default");
+	if (!activeProfile) return false;
+
+	const nextModelRoles = { ...options.settings.get("modelRoles") };
+	const nextAgentModelOverrides = { ...options.settings.get("task.agentModelOverrides") };
+	const target = SKC_MODEL_ASSIGNMENT_TARGETS[options.role];
+
+	if (options.role === "default") {
+		nextModelRoles.default = options.selector;
+	} else if (!nextModelRoles.default && options.session.model) {
+		nextModelRoles.default = formatModelSelectorValue(
+			`${options.session.model.provider}/${options.session.model.id}`,
+			options.session.thinkingLevel,
+		);
+	}
+
+	if (target.settingsPath === "modelRoles") {
+		nextModelRoles[options.role] = options.selector;
+	} else {
+		nextAgentModelOverrides[options.role] = options.selector;
+	}
+
+	options.settings.set("modelRoles", nextModelRoles);
+	options.settings.set("task.agentModelOverrides", nextAgentModelOverrides);
+	options.settings.set("modelProfile.default", undefined);
+	options.settings.clearOverride("modelProfile.default");
+	options.settings.override("modelRoles", nextModelRoles);
+	options.settings.override("task.agentModelOverrides", nextAgentModelOverrides);
+	options.session.setActiveModelProfile?.(undefined);
+	return true;
+}
 
 export function formatModelProfileCredentialError(profileName: string, providers: readonly string[]): string {
 	return `Model profile "${profileName}" requires credentials for: ${providers.join(", ")}. Run /login and configure the missing provider(s), then retry.`;
@@ -145,7 +193,12 @@ export async function prepareModelProfileActivation(
 	const authenticatedProviders: string[] = [];
 	for (const provider of allProviders) {
 		const apiKey = await options.modelRegistry.getApiKeyForProvider(provider, options.session.sessionId);
-		if (!isAuthenticated(apiKey)) {
+		// kNoAuth ("N/A") is the sentinel for keyless/no-auth providers (local LLMs,
+		// `--auth none` custom providers): usable WITHOUT a key. isAuthenticated()
+		// rejects it, so gate on usability ("a credential resolved OR keyless")
+		// rather than "has a real key" — otherwise activating a keyless profile
+		// throws a spurious "requires credentials" error and the model never applies.
+		if (!isAuthenticated(apiKey) && apiKey !== kNoAuth) {
 			missingProviders.push(provider);
 		} else {
 			authenticatedProviders.push(provider);
@@ -255,20 +308,19 @@ export async function applyPreparedModelProfileActivation(
 			modelChanged = true;
 		}
 		if (Object.keys(prepared.modelRoles).length > 0) {
-			prepared.settings.override("modelRoles", {
-				...prepared.settings.get("modelRoles"),
-				...prepared.modelRoles,
-			});
+			prepared.settings.override("modelRoles", { ...previousModelRoles, ...prepared.modelRoles });
 			modelRolesChanged = true;
 		}
 		if (Object.keys(prepared.agentModelOverrides).length > 0) {
 			prepared.settings.override("task.agentModelOverrides", {
-				...prepared.settings.get("task.agentModelOverrides"),
+				...previousAgentModelOverrides,
 				...prepared.agentModelOverrides,
 			});
 			overridesChanged = true;
 		}
 		if (options.persistDefault) {
+			prepared.settings.set("modelRoles", {});
+			prepared.settings.set("task.agentModelOverrides", {});
 			prepared.settings.set("modelProfile.default", prepared.profileName);
 			defaultChanged = true;
 			await prepared.settings.flush();
@@ -277,6 +329,8 @@ export async function applyPreparedModelProfileActivation(
 	} catch (error) {
 		if (defaultChanged) {
 			prepared.settings.set("modelProfile.default", previousPersistedDefault);
+			prepared.settings.set("modelRoles", previousModelRoles);
+			prepared.settings.set("task.agentModelOverrides", previousAgentModelOverrides);
 		}
 		if (modelRolesChanged) {
 			prepared.settings.override("modelRoles", previousModelRoles);

package/src/config/model-profiles.ts

@@ -23,8 +23,8 @@ export interface ModelProfileDefinition {
 
 export interface ResolvedProfileBinding {
 	defaultSelector?: string;
-	modelRoles: Partial<Record<"vision", string>>;
-	agentModelOverrides: Partial<Record<Exclude<ModelProfileRole, "default" | "vision">, string>>;
+	modelRoles: Record<string, string>;
+	agentModelOverrides: Partial<Record<Exclude<ModelProfileRole, "default">, string>>;
 }
 
 function parseModelSelectorProvider(selector: string): string | undefined {
@@ -383,9 +383,8 @@ export function mergeModelProfiles(userProfiles?: ModelsConfig["profiles"]): Map
 }
 
 export function resolveProfileBindings(definition: ModelProfileDefinition): ResolvedProfileBinding {
-	const { default: defaultSelector, vision, executor, architect, planner, critic } = definition.modelMapping;
+	const { default: defaultSelector, executor, architect, planner, critic } = definition.modelMapping;
 	const modelRoles: ResolvedProfileBinding["modelRoles"] = {};
-	if (vision !== undefined) modelRoles.vision = vision;
 	const agentModelOverrides: ResolvedProfileBinding["agentModelOverrides"] = {};
 	if (executor !== undefined) agentModelOverrides.executor = executor;
 	if (architect !== undefined) agentModelOverrides.architect = architect;

package/src/config/model-registry.ts

@@ -70,7 +70,7 @@ export function isAuthenticated(apiKey: string | undefined | null): apiKey is st
 	return Boolean(apiKey) && apiKey !== kNoAuth;
 }
 
-export type ModelRole = "default" | "vision";
+export type ModelRole = "default";
 
 export interface ModelRoleInfo {
 	tag?: string;
@@ -80,12 +80,11 @@ export interface ModelRoleInfo {
 
 export const MODEL_ROLES: Record<ModelRole, ModelRoleInfo> = {
 	default: { tag: "DEFAULT", name: "Default", color: "success" },
-	vision: { tag: "VISION", name: "Vision", color: "accent" },
 };
 
-export const MODEL_ROLE_IDS: ModelRole[] = ["default", "vision"];
+export const MODEL_ROLE_IDS: ModelRole[] = ["default"];
 
-export type SkcModelAssignmentTargetId = "default" | "vision" | "executor" | "architect" | "planner" | "critic";
+export type SkcModelAssignmentTargetId = "default" | "executor" | "architect" | "planner" | "critic";
 
 export interface SkcModelAssignmentTargetInfo extends ModelRoleInfo {
 	id: SkcModelAssignmentTargetId;
@@ -94,7 +93,6 @@ export interface SkcModelAssignmentTargetInfo extends ModelRoleInfo {
 
 export const SKC_MODEL_ASSIGNMENT_TARGET_IDS: SkcModelAssignmentTargetId[] = [
 	"default",
-	"vision",
 	"executor",
 	"architect",
 	"planner",
@@ -103,7 +101,6 @@ export const SKC_MODEL_ASSIGNMENT_TARGET_IDS: SkcModelAssignmentTargetId[] = [
 
 export const SKC_MODEL_ASSIGNMENT_TARGETS: Record<SkcModelAssignmentTargetId, SkcModelAssignmentTargetInfo> = {
 	default: { id: "default", tag: "DEFAULT", name: "Default", color: "success", settingsPath: "modelRoles" },
-	vision: { id: "vision", tag: "VISION", name: "Vision", color: "accent", settingsPath: "modelRoles" },
 	executor: {
 		id: "executor",
 		tag: "EXECUTOR",

package/src/config/models-config-schema.ts

@@ -81,7 +81,7 @@ const ModelBindingsSchema = z.object({
 	modelRoles: z.record(z.string(), z.string().min(1)).optional(),
 	agentModelOverrides: z.record(z.string(), z.string().min(1)).optional(),
 });
-export const ProfileRoleSchema = z.enum(["default", "vision", "executor", "architect", "planner", "critic"]);
+export const ProfileRoleSchema = z.enum(["default", "executor", "architect", "planner", "critic"]);
 
 function isValidProfileModelSelector(value: string): boolean {
 	if (value.includes(",")) return false;

package/src/config/settings-schema.ts

@@ -31,7 +31,6 @@ export type SettingTab =
 	| "appearance"
 	| "model"
 	| "interaction"
-	| "notifications"
 	| "context"
 	| "memory"
 	| "editing"
@@ -47,7 +46,6 @@ export const SETTING_TABS: SettingTab[] = [
 	"appearance",
 	"model",
 	"interaction",
-	"notifications",
 	"context",
 	"memory",
 	"editing",
@@ -61,7 +59,6 @@ export const TAB_METADATA: Record<SettingTab, { label: string; icon: `tab.${stri
 	appearance: { label: "Appearance", icon: "tab.appearance" },
 	model: { label: "Model", icon: "tab.model" },
 	interaction: { label: "Interaction", icon: "tab.interaction" },
-	notifications: { label: "Notifications", icon: "tab.notifications" },
 	context: { label: "Context", icon: "tab.context" },
 	memory: { label: "Memory", icon: "tab.memory" },
 	editing: { label: "Editing", icon: "tab.editing" },
@@ -133,14 +130,11 @@ interface UiString extends UiBase {
 	 *  - Omitted → renders as a free text input.
 	 */
 	options?: ReadonlyArray<SubmenuOption> | "runtime";
-	/** When true, the value is masked in the settings list display but edited in full. */
-	secret?: boolean;
 }
 
 /** Wide ui shape exposed to consumers that walk the schema generically. */
 export type AnyUiMetadata = UiBase & {
 	options?: ReadonlyArray<SubmenuOption> | "runtime";
-	secret?: boolean;
 };
 
 interface BooleanDef {
@@ -262,97 +256,18 @@ export const SETTINGS_SCHEMA = {
 	"auth.broker.token": { type: "string", default: undefined },
 
 	// Notifications (shared daemon with Telegram/Discord/Slack presentation adapters)
-	"notifications.enabled": {
-		type: "boolean",
-		default: false,
-		ui: {
-			tab: "notifications",
-			label: "Enabled",
-			description:
-				"Master switch for notifications. Requires at least one adapter (Telegram/Discord/Slack) configured with a token and a chat/channel to actually deliver.",
-		},
-	},
-	"notifications.telegram.botToken": {
-		type: "string",
-		default: undefined,
-		ui: {
-			tab: "notifications",
-			label: "Telegram bot token",
-			description: "Telegram BotFather HTTP API token. Stored locally; shown masked.",
-			secret: true,
-		},
-	},
-	"notifications.telegram.chatId": {
-		type: "string",
-		default: undefined,
-		ui: {
-			tab: "notifications",
-			label: "Telegram chat ID",
-			description:
-				"Target chat. For end-to-end per-session delivery this must be a forum-enabled supergroup the bot can manage; a private chat id is only enough for setup/status.",
-		},
-	},
-	"notifications.discord.botToken": {
-		type: "string",
-		default: undefined,
-		ui: {
-			tab: "notifications",
-			label: "Discord bot token",
-			description: "Discord bot token for the notifications adapter. Stored locally; shown masked.",
-			secret: true,
-		},
-	},
-	"notifications.discord.channelId": {
-		type: "string",
-		default: undefined,
-		ui: {
-			tab: "notifications",
-			label: "Discord channel ID",
-			description: "Discord channel that receives notifications and routes replies back.",
-		},
-	},
-	"notifications.slack.botToken": {
-		type: "string",
-		default: undefined,
-		ui: {
-			tab: "notifications",
-			label: "Slack bot token",
-			description: "Slack bot token for the notifications adapter. Stored locally; shown masked.",
-			secret: true,
-		},
-	},
-	"notifications.slack.channelId": {
-		type: "string",
-		default: undefined,
-		ui: {
-			tab: "notifications",
-			label: "Slack channel ID",
-			description: "Slack channel that receives notifications and routes replies back.",
-		},
-	},
-	"notifications.redact": {
-		type: "boolean",
-		default: false,
-		ui: {
-			tab: "notifications",
-			label: "Redact",
-			description:
-				"Strip idle summaries and streamed content before remote delivery. Ask prompts are always sent so they remain answerable.",
-		},
-	},
+	"notifications.enabled": { type: "boolean", default: false },
+	"notifications.telegram.botToken": { type: "string", default: undefined },
+	"notifications.telegram.chatId": { type: "string", default: undefined },
+	"notifications.discord.botToken": { type: "string", default: undefined },
+	"notifications.discord.channelId": { type: "string", default: undefined },
+	"notifications.slack.botToken": { type: "string", default: undefined },
+	"notifications.slack.channelId": { type: "string", default: undefined },
+	"notifications.redact": { type: "boolean", default: false },
 	"notifications.verbosity": {
 		type: "string",
 		default: "lean",
 		validate: (value: string) => value === "lean" || value === "verbose",
-		ui: {
-			tab: "notifications",
-			label: "Verbosity",
-			description: "How much session context to stream to Telegram.",
-			options: [
-				{ value: "lean", label: "Lean" },
-				{ value: "verbose", label: "Verbose" },
-			],
-		},
 	},
 	"notifications.daemon.idleTimeoutMs": {
 		type: "number",
@@ -2178,16 +2093,6 @@ export const SETTINGS_SCHEMA = {
 		},
 	},
 
-	"inspect_image.enabled": {
-		type: "boolean",
-		default: false,
-		ui: {
-			tab: "tools",
-			label: "Inspect Image",
-			description: "Enable the inspect_image tool, delegating image understanding to a vision-capable model",
-		},
-	},
-
 	"checkpoint.enabled": {
 		type: "boolean",
 		default: false,
@@ -2285,6 +2190,17 @@ export const SETTINGS_SCHEMA = {
 		},
 	},
 
+	"web_search.timeout": {
+		type: "number",
+		default: 300,
+		validate: (value: number) => Number.isFinite(value) && value > 0,
+		ui: {
+			tab: "tools",
+			label: "Web Search Timeout",
+			description: "Hard timeout in seconds for a single web search request (default 300)",
+		},
+	},
+
 	"browser.enabled": {
 		type: "boolean",
 		default: true,
@@ -2315,6 +2231,46 @@ export const SETTINGS_SCHEMA = {
 		},
 	},
 
+	"browser.gc.enabled": {
+		type: "boolean",
+		default: true,
+		ui: {
+			tab: "tools",
+			label: "Browser Tab GC",
+			description: "Automatically reclaim idle, unheld SKC-managed headless/spawned browser tabs.",
+		},
+	},
+	"browser.gc.idleMs": {
+		type: "number",
+		default: 300_000,
+		validate: (value: number) => Number.isFinite(value) && value >= 0,
+		ui: {
+			tab: "tools",
+			label: "Browser Tab GC Idle (ms)",
+			description: "Evict headless/spawned tabs idle longer than this many milliseconds.",
+		},
+	},
+	"browser.gc.rssLimitMb": {
+		type: "number",
+		default: 1536,
+		validate: (value: number) => Number.isFinite(value) && value > 0,
+		ui: {
+			tab: "tools",
+			label: "Browser Tab GC RSS Limit (MB)",
+			description: "Parent-process RSS (MB) above which idle tabs are opportunistically evicted LRU.",
+		},
+	},
+	"resourceGc.sweepIntervalMs": {
+		type: "number",
+		default: 30_000,
+		validate: (value: number) => Number.isFinite(value) && value > 0,
+		ui: {
+			tab: "tools",
+			label: "Resource GC Sweep Interval (ms)",
+			description: "How often the resource GC sweeps browser tabs and stale screenshot directories.",
+		},
+	},
+
 	"computer.enabled": {
 		type: "boolean",
 		default: false,
@@ -2374,6 +2330,35 @@ export const SETTINGS_SCHEMA = {
 			description: "Persist audit records for enabled computer-use actions.",
 		},
 	},
+	"computer.screenshotGc.enabled": {
+		type: "boolean",
+		default: true,
+		ui: {
+			tab: "tools",
+			label: "Computer Screenshot GC",
+			description: "Delete stale computer-use screenshot fallback directories on disk.",
+		},
+	},
+	"computer.screenshotGc.staleMs": {
+		type: "number",
+		default: 43_200_000,
+		validate: (value: number) => Number.isFinite(value) && value >= 0,
+		ui: {
+			tab: "tools",
+			label: "Computer Screenshot GC Stale Age (ms)",
+			description: "Remove screenshot fallback directories whose mtime is older than this many milliseconds.",
+		},
+	},
+	"computer.screenshotGc.scanIntervalMs": {
+		type: "number",
+		default: 1_800_000,
+		validate: (value: number) => Number.isFinite(value) && value > 0,
+		ui: {
+			tab: "tools",
+			label: "Computer Screenshot GC Scan Interval (ms)",
+			description: "Minimum interval between os.tmpdir scans for stale screenshot directories.",
+		},
+	},
 
 	// Tool execution
 	"tools.intentTracing": {

package/src/deep-interview/plaintext-gate-guard.ts

@@ -0,0 +1,94 @@
+export type DeepInterviewPlaintextAskLeakOption = "Yes, crystallize" | "Adjust wording" | "Missing scope";
+
+export type DeepInterviewPlaintextAskLeakResult = {
+	kind: "deep_interview_plaintext_ask_leak";
+	matchedOptions: DeepInterviewPlaintextAskLeakOption[];
+	signals: {
+		optionsHeading: true;
+		restateIntent: true;
+		deepInterviewContext: boolean;
+	};
+};
+
+const CANONICAL_OPTIONS: DeepInterviewPlaintextAskLeakOption[] = [
+	"Yes, crystallize",
+	"Adjust wording",
+	"Missing scope",
+];
+
+const RESTATE_INTENT_PATTERNS: RegExp[] = [
+	/\brestate\b/i,
+	/\bconfirmation\b/i,
+	/\bconfirm(?:ation|ed|ing)?\b/i,
+	/\bcrystall?ize\b/i,
+	/\bdoes\s+this\s+(?:capture|match|reflect|summari[sz]e)\b/i,
+	/\bbefore\s+(?:i|we)\s+(?:write|finali[sz]e|crystall?ize)\b/i,
+	/\bread\s+only\s+this\s+line\b/i,
+	/\bturn\s+this\s+into\s+(?:the\s+)?(?:spec|final)\b/i,
+	/재진술/,
+	/다시\s*말/,
+	/확인/,
+	/확정/,
+	/정리/,
+	/요약/,
+	/맞(?:습니까|나요|는지)/,
+];
+
+const DEEP_INTERVIEW_CONTEXT_PATTERNS: RegExp[] = [
+	/\bdeep[ -]?interview\b/i,
+	/\bsocratic\b/i,
+	/\binterview\s+round\b/i,
+	/\bround\s+\d+\b/i,
+	/\bambiguity\b/i,
+	/\btopology\s+confirmation\b/i,
+	/딥\s*인터뷰/,
+	/심층\s*인터뷰/,
+	/인터뷰\s*(?:라운드|진행|확인)/,
+];
+
+const FINAL_ARTIFACT_PATTERNS: RegExp[] = [
+	/^\s*#{1,3}\s*(?:(?:final|approved|completed|완료|최종)\s+)?(?:deep[ -]?interview\s+)?(?:spec(?:ification)?|transcript)\b/im,
+	/^\s*#{1,3}\s*(?:deep[ -]?interview\s+)?(?:final|approved|completed|완료|최종)\s+(?:spec(?:ification)?|transcript)\b/im,
+	/\b(?:final|approved|completed)\s+(?:deep[ -]?interview\s+)?(?:spec(?:ification)?|transcript)\b/i,
+	/\binterview\s+transcript\b/i,
+	/\.skc\/specs\//i,
+	/최종\s*(?:명세|스펙|기록)/,
+];
+
+function hasOptionsHeading(text: string): boolean {
+	return /(?:^|\n)\s*options\s*:/i.test(text);
+}
+
+function hasPattern(text: string, patterns: RegExp[]): boolean {
+	return patterns.some(pattern => pattern.test(text));
+}
+
+function matchedCanonicalOptions(text: string): DeepInterviewPlaintextAskLeakOption[] {
+	const folded = text.toLocaleLowerCase("en-US");
+	return CANONICAL_OPTIONS.filter(option => folded.includes(option.toLocaleLowerCase("en-US")));
+}
+
+function looksLikeFinalArtifact(text: string): boolean {
+	return hasPattern(text, FINAL_ARTIFACT_PATTERNS);
+}
+
+export function detectDeepInterviewPlaintextAskLeak(text: string): DeepInterviewPlaintextAskLeakResult | null {
+	const trimmed = text.trim();
+	if (trimmed.length === 0) return null;
+	if (looksLikeFinalArtifact(trimmed)) return null;
+	if (!hasOptionsHeading(trimmed)) return null;
+
+	const matchedOptions = matchedCanonicalOptions(trimmed);
+	if (matchedOptions.length < 2) return null;
+	if (!hasPattern(trimmed, RESTATE_INTENT_PATTERNS)) return null;
+
+	return {
+		kind: "deep_interview_plaintext_ask_leak",
+		matchedOptions,
+		signals: {
+			optionsHeading: true,
+			restateIntent: true,
+			deepInterviewContext: hasPattern(trimmed, DEEP_INTERVIEW_CONTEXT_PATTERNS),
+		},
+	};
+}

package/src/defaults/skc/extensions/grok-cli-vendor/biome.json

@@ -17,7 +17,7 @@
   "linter": {
     "enabled": true,
     "rules": {
-      "recommended": true
+      "preset": "recommended"
     }
   },
   "javascript": {

package/src/defaults/skc/skills/deep-interview/SKILL.md

@@ -292,7 +292,7 @@ Auto-research must never add a public skill entrypoint, never be slash-command/d
 
 ### Step 2b: Ask the Question
 
-Use the `ask` tool with the generated question. Before rendering the prompt/options, apply `language.instruction` from state when present so the entire user-facing question remains in the preserved session language. Present it clearly with the current ambiguity context:
+Use the `ask` tool with the generated question. When a question has options, you MUST call `ask` and must not print `Question:`/`Options:` blocks as assistant prose. If you already printed a question/options block as prose, your next action is to call `ask` with the same question/options, not to wait for a typed answer. Before rendering the prompt/options, apply `language.instruction` from state when present so the entire user-facing question remains in the preserved session language. Present it clearly with the current ambiguity context:
 
 ```
 Round {n} | Component: {target_component_name} | Targeting: {weakest_dimension} | Why now: {one_sentence_targeting_rationale} | Ambiguity: {score}%
@@ -458,7 +458,7 @@ Also recompute and persist `ambiguity_milestone` each round (detect band transit
 
 - **Round 3+**: Allow early exit if user says "enough", "let's go", "build it"
 - **Round 10**: Show soft warning: "We're at 10 rounds. Current ambiguity: {score}%. Continue or proceed with current clarity?"
-- **Round 20**: Hard cap: "Maximum interview rounds reached. Proceeding with current clarity level ({score}%)."
+- **Round 100**: Hard cap: "Maximum interview rounds reached. Proceeding with current clarity level ({score}%)."
 
 ## Phase 3: Lateral Review Panel (milestone-triggered)
 
@@ -495,7 +495,7 @@ When ambiguity ≤ threshold (or hard cap / early exit):
 
 **4a. Closure / Acceptance Guard.** Even when ambiguity ≤ threshold, do not treat the math as completion. Run an independent readiness audit from the full main-session perspective (including explore findings, established facts, and triggers the scorer may not have fully weighed). Confirm every active topology component has goal/constraint/criteria coverage, no unresolved or disputed trigger remains on a path that matters, and no low-confidence auto-answer is standing in for user-confirmed truth above the clarity cap. If a material gap exists, explicitly override the gate to the user — "The math says ready, but I am not accepting it yet because {gap}" — and ask the single highest-impact follow-up, returning to Phase 2. Record any override in `state.closure_overrides`.
 
-**4b. Restate gate.** Once closure passes, collapse the agreed answers into ONE sentence goal that covers every active component, and confirm it with a single `ask`: "If someone read only this line, would they reach the same outcome you have in mind?" Offer **Yes, crystallize**, **Adjust wording**, and **Missing scope**, plus free-text, applying `language.instruction` when present. On "Adjust wording" / "Missing scope", collect the exact correction with one follow-up `ask`, route it back through Step 2c scoring and established-facts maintenance (a correction can change ambiguity), then re-run closure and ask the Restate gate again. Cap at two loops; if alignment is not reached, return to Phase 2 with a targeted question instead of forcing a goal line. Persist the confirmed line as `state.restated_goal`.
+**4b. Restate gate.** Once closure passes, collapse the agreed answers into ONE sentence goal that covers every active component, and confirm it with a single `ask`: "If someone read only this line, would they reach the same outcome you have in mind?" Offer **Yes, crystallize**, **Adjust wording**, and **Missing scope**, plus free-text, applying `language.instruction` when present. Because this gate has options, it MUST go through `ask`: do not print the Restate question and options as assistant prose with `Question:`/`Options:` labels. If the Restate gate was already printed that way, immediately call `ask` with the same question/options before accepting or waiting for any answer. On "Adjust wording" / "Missing scope", collect the exact correction with one follow-up `ask`, route it back through Step 2c scoring and established-facts maintenance (a correction can change ambiguity), then re-run closure and ask the Restate gate again. Cap at two loops; if alignment is not reached, return to Phase 2 with a targeted question instead of forcing a goal line. Persist the confirmed line as `state.restated_goal`.
 
 1. **Generate the specification** using opus model with the prompt-safe transcript. If the full interview transcript or initial context is too large, include the summary plus all concrete decisions, acceptance criteria, unresolved gaps, and ontology snapshots; never overflow the prompt with raw oversized context.
    - Apply `language.instruction` when present so user-facing prose in the spec preserves the session language; keep code identifiers, file paths, commands, JSON/settings keys, and quoted source text unchanged.
@@ -690,6 +690,7 @@ Skipping any stage is possible but reduces quality assurance:
 
 <Tool_Usage>
 - Use the `ask` tool for each interview question — provides clickable UI with contextual options
+- For any option-bearing question, call `ask`; never print `Question:`/`Options:` blocks as assistant prose. If such a block was already printed, call `ask` with the same question/options as the very next action instead of waiting for a typed/prose answer
 - Preserve the SKC `ask` tool path for native interaction; do not introduce parallel structured-question transport into this skill
 - Use `read/search/find exploration or a bounded read-only planner/architect subagent` for brownfield codebase exploration (run BEFORE asking user about codebase)
 - Use opus model (temperature 0.1) for ambiguity scoring — consistency is critical
@@ -698,7 +699,7 @@ Skipping any stage is possible but reduces quality assurance:
 - Use the SKC workflow CLI to save the final spec at `.skc/_session-{sessionid}/specs/deep-interview-{slug}.md` exactly; do not use `write`, `edit`, or `ast_edit` directly on `.skc/` paths without force override.
 - Use public SKC workflow entrypoints to bridge to ralplan, ultragoal, or team only after explicit execution approval — never implement directly. Implementation handoff defaults to ultragoal; reserve team for when tmux-based interactive worker parallelization is genuinely required.
 - The lateral-review panel spawns read-only persona subagents (Task tool) in parallel with independent context; it is an assist layer, never an executor and never the completion authority
-- Apply the Refine gate (Step 2b″), the Dialectic Rhythm Guard (Step 2a), and the Closure + Restate gates (Phase 4) through the `ask` tool, preserving `language.instruction` for each
+- Apply the Refine gate (Step 2b″), the Dialectic Rhythm Guard (Step 2a), and the Closure + Restate gates (Phase 4) through the `ask` tool, preserving `language.instruction` for each; if any of these gates has options, the assistant must call `ask` and must not print `Question:`/`Options:` blocks as assistant prose
 - Use internal fragment auto-modes only at their documented hooks: `auto-research-greenfield.md` between Step 2a and 2b for greenfield `research: true` questions, `auto-answer-uncertain.md` as Step 2b′ after `ask` resolves and before scoring, and `lateral-review-panel.md` for the Phase 3 panel personas at ambiguity-milestone transitions and before synthesizing agent-supplied answers.
 - Fragment auto-modes are loaded on demand as `kind: "skill-fragment"`; they are not public workflow skills, not slash-command/discoverable, and not `skill://` registrations.
 </Tool_Usage>
@@ -787,7 +788,7 @@ Why bad: 45% ambiguity means nearly half the requirements are unclear. The mathe
 </Examples>
 
 <Escalation_And_Stop_Conditions>
-- **Hard cap at 20 rounds**: Proceed with whatever clarity exists, noting the risk
+- **Hard cap at 100 rounds**: Proceed with whatever clarity exists, noting the risk
 - **Soft warning at 10 rounds**: Offer to continue or proceed
 - **Early exit (round 3+)**: Allow with warning if ambiguity > threshold
 - **User says "stop", "cancel", "abort"**: Stop immediately, save state for resume
@@ -822,7 +823,7 @@ Optional settings in `.skc/settings.json`:
   "skc": {
     "deepInterview": {
       "ambiguityThreshold": <resolvedThreshold>,
-      "maxRounds": 20,
+      "maxRounds": 100,
       "softWarningRounds": 10,
       "minRoundsBeforeExit": 3,
       "enableChallengeAgents": true,