@savvy-web/tsdown-plugins 1.1.4 → 1.1.5

package/build/build-target-groups.js

@@ -32,6 +32,13 @@ const STUB_BASE_ENTRY = "index";
 * build (JS and the dts plugin share it), so a single pass cannot give per-module JS + bundled
 * dts. Per-module dts breaks type portability (TS2883); bundling the JS re-bundles workspace
 * consumers. The split keeps per-module JS AND rolled-up, self-contained declarations.
+*
+* **The JS pass's `unbundle` flips to `false` for a `bundleNodeModules` partition** (see
+* `DerivedTsdownOptions` in `target-groups.ts`), so that partition's JS pass ALSO bundles
+* instead of preserving modules — a per-module preserveModules JS pass writes every inlined
+* node_modules dependency to its own sibling file (mirroring its `node_modules/...` path),
+* which `npm pack` then strips, breaking the "self-contained" promise `bundleNodeModules`
+* already makes. Scoped to that flag alone; every other build's JS pass is unaffected.
 * @public
 */
 async function buildTargetGroups(options) {
@@ -45,6 +52,7 @@ async function buildTargetGroups(options) {
 		customLogger: createTsdownLogger(collector, groupId)
 	};
 	const metricsPlugins = (groupId, pass) => collector === void 0 ? [] : [buildMetricsPlugin(collector, groupId, pass, verbose)];
+	const timingChecks = { checks: { pluginTimings: verbose } };
 	const timed = async (groupId, pass, run) => {
 		const timer = createTimer();
 		try {
@@ -81,6 +89,7 @@ async function buildTargetGroups(options) {
 				tsconfigPath: dtsEmitTsconfigPath,
 				devManifest: options.devManifest,
 				...partExternals !== void 0 ? { externals: partExternals } : {},
+				...partBundleNodeModules !== void 0 ? { bundleNodeModules: partBundleNodeModules } : {},
 				...partBundledPackages !== void 0 ? { bundledPackages: partBundledPackages } : {},
 				...part.format !== void 0 ? { format: part.format } : {},
 				...options.minify !== void 0 ? { minify: options.minify } : {},
@@ -126,6 +135,7 @@ async function buildTargetGroups(options) {
 				fixedExtension: js.fixedExtension,
 				dts: js.dts,
 				define: js.define,
+				...timingChecks,
 				...instrument(group.id),
 				...part.css !== void 0 ? { css: part.css } : {},
 				...partExternals?.length || partBundleNodeModules || partBundle?.length ? { deps: {
@@ -218,6 +228,7 @@ async function buildTargetGroups(options) {
 						fixedExtension: dts.fixedExtension,
 						dts: dts.dts,
 						define: dts.define,
+						...timingChecks,
 						...instrument(group.id),
 						...dtsDeps,
 						plugins: [
@@ -244,6 +255,7 @@ async function buildTargetGroups(options) {
 						fixedExtension: decl.fixedExtension,
 						dts: decl.dts,
 						define: decl.define,
+						...timingChecks,
 						logLevel: "silent",
 						...dtsNeverBundle.length > 0 || partBundleNodeModules || decl.bundledPackages ? { deps: {
 							...dtsNeverBundle.length > 0 ? { neverBundle: dtsNeverBundle } : {},
@@ -292,6 +304,7 @@ async function buildTargetGroups(options) {
 					"process.env.__PACKAGE_VERSION__": JSON.stringify(options.version),
 					...options.define
 				},
+				...timingChecks,
 				...instrument(group.id),
 				...Object.keys(looseDeps).length > 0 ? { deps: looseDeps } : {},
 				...hasCjs ? { cjsDefault: true } : {},

package/build/target-groups.js

@@ -23,7 +23,7 @@ function deriveTargetGroupOptions(options) {
 		sourcemap: !isProd,
 		minify: isProd && (options.minify ?? false),
 		format,
-		unbundle: true,
+		unbundle: !(options.bundleNodeModules ?? false),
 		clean: true,
 		platform: options.platform ?? "node",
 		fixedExtension: false,

package/index.d.ts

@@ -403,6 +403,13 @@ interface DeriveOptions {
    * runtime JS bundling is unaffected.
    */
   readonly bundledPackages?: ReadonlyArray<string> | undefined;
+  /**
+   * Force-bundle node_modules (and workspace) JS dependencies into the JS pass (tsdown
+   * `deps.skipNodeModulesBundle: false`). Consumed here ONLY to decide the JS pass's
+   * `unbundle` posture — see {@link DerivedTsdownOptions.unbundle} — the `deps` shape
+   * itself is computed separately in `buildTargetGroups`.
+   */
+  readonly bundleNodeModules?: boolean | undefined;
 }
 /**
  * The JS pass: per-module JavaScript, no declarations.
@@ -420,6 +427,22 @@ interface DeriveOptions {
  * the JS re-bundles workspace consumers (e.g. silk re-bundling silk-effects crashes at
  * runtime). The split keeps per-module JS (no re-bundle hazard) AND bundled, self-contained
  * declarations (no TS2883).
+ *
+ * **`unbundle` flips to `false` when `bundleNodeModules` is set.** `bundleNodeModules: true`
+ * exists to produce a genuinely self-contained artifact (its own TSDoc already promises this),
+ * but `preserveModules` (the per-module JS pass) writes every inlined node_modules dependency
+ * out to its OWN sibling file, mirroring its `node_modules/.pnpm/...` (or workspace) path
+ * relative to the package root — for BOTH esm and cjs. `npm pack` unconditionally strips any
+ * directory literally named `node_modules` from the published tarball, so an esm entry built
+ * this way throws `Cannot find module '.../node_modules/.pnpm/.../foo.js'` once packed and
+ * installed (the cjs sibling accidentally escapes this: tsdown's own dts pass, which always
+ * runs `unbundle: false`, re-emits and overwrites a dual-format build's `.cjs` JS chunk as a
+ * side effect of emitting `.d.cts` — see the dts-pass rebuild note in `buildTargetGroups` — so
+ * only the esm artifact keeps the broken preserveModules layout). Turning `unbundle` off for
+ * the JS pass whenever `bundleNodeModules` is requested makes BOTH formats bundle into one
+ * self-contained file, matching what the flag already promises and what the cjs side already
+ * does by accident. Scoped to `bundleNodeModules` alone: every other build keeps the default
+ * per-module dev-friendly layout unchanged.
  * @public
  */
 interface DerivedTsdownOptions {
@@ -427,7 +450,8 @@ interface DerivedTsdownOptions {
   readonly sourcemap: boolean;
   readonly minify: boolean;
   readonly format: ReadonlyArray<BuildFormat>;
-  readonly unbundle: true;
+  /** `false` only when `bundleNodeModules` is set — see the interface TSDoc above. */
+  readonly unbundle: boolean;
   /** JS pass starts fresh; it owns the outDir before the dts pass appends to it. */
   readonly clean: true;
   readonly platform: BuildPlatform;
@@ -700,6 +724,13 @@ interface BuildTargetGroupsOptions {
  * build (JS and the dts plugin share it), so a single pass cannot give per-module JS + bundled
  * dts. Per-module dts breaks type portability (TS2883); bundling the JS re-bundles workspace
  * consumers. The split keeps per-module JS AND rolled-up, self-contained declarations.
+ *
+ * **The JS pass's `unbundle` flips to `false` for a `bundleNodeModules` partition** (see
+ * `DerivedTsdownOptions` in `target-groups.ts`), so that partition's JS pass ALSO bundles
+ * instead of preserving modules — a per-module preserveModules JS pass writes every inlined
+ * node_modules dependency to its own sibling file (mirroring its `node_modules/...` path),
+ * which `npm pack` then strips, breaking the "self-contained" promise `bundleNodeModules`
+ * already makes. Scoped to that flag alone; every other build's JS pass is unaffected.
  * @public
  */
 declare function buildTargetGroups(options: BuildTargetGroupsOptions): Promise<void>;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@savvy-web/tsdown-plugins",
-	"version": "1.1.4",
+	"version": "1.1.5",
 	"private": false,
 	"description": "Interface-only tsdown/rolldown plugin pack powering @savvy-web/bundler",
 	"homepage": "https://github.com/savvy-web/systems/tree/main/packages/tsdown-plugins",