@savvy-web/silk-effects 5.2.0 → 5.3.0

package/commitlint/hook/rules/closes-trailer.js

@@ -7,8 +7,34 @@ import { Effect } from "effect";
 *
 * @internal
 */
+/**
+* A closing keyword followed by its full list of issue references.
+*
+* @remarks
+* The house commit format puts every issue on ONE comma-separated trailer
+* (`Closes #247, #248, #251`), so a pattern anchored on `keyword\s+#N` sees
+* only the first id and reports a missing trailer that is plainly present.
+* Capturing the whole list and scanning it is what makes the later ids count.
+*
+* `and` is accepted alongside the comma because humans write it; the optional
+* colon matches the `Closes: #N` form the validator's trailer pattern allows.
+*
+* @internal
+*/
+const CLOSING_LIST_PATTERN = /\b(?:closes|fixes|resolves):?\s+(#\d+(?:\s*(?:,|and)\s*#\d+)*)/gi;
+/**
+* Reference ids within a captured closing list.
+*
+* @internal
+*/
+const REFERENCE_PATTERN = /#(\d+)/g;
 function hasClosingTrailer(message, ticketId) {
-	return new RegExp(`\\b(closes|fixes|resolves)\\s+#${ticketId}\\b`, "i").test(message);
+	for (const keywordMatch of message.matchAll(CLOSING_LIST_PATTERN)) {
+		const list = keywordMatch[1];
+		if (list === void 0) continue;
+		for (const reference of list.matchAll(REFERENCE_PATTERN)) if (Number(reference[1]) === ticketId) return true;
+	}
+	return false;
 }
 const closesTrailerRule = {
 	id: "closes-trailer",

package/commitlint/hook/rules/verbosity.js

@@ -6,8 +6,26 @@ import { Effect } from "effect";
 *
 * @internal
 */
-const VERBOSITY_LINE_THRESHOLD = 25;
-const VERBOSITY_WORD_THRESHOLD = 400;
+/**
+* Body-line ceiling before the rule advises.
+*
+* @remarks
+* The house format is three to five bullets (or one to two short paragraphs)
+* plus a `Closes` line and a `Signed-off-by` line, and the counted body here
+* includes those two trailers. That is a 7-line message at the top of the
+* intended range, so 12 leaves headroom and fires only on a body that is
+* clearly past the format rather than at its boundary.
+*/
+const VERBOSITY_LINE_THRESHOLD = 12;
+/**
+* Body-word ceiling before the rule advises.
+*
+* @remarks
+* Five bullets at roughly 20 words each, plus trailers, lands near 110. A
+* two-paragraph prose body lands lower. 150 is the point past which a body
+* has stopped being a scannable index entry.
+*/
+const VERBOSITY_WORD_THRESHOLD = 150;
 const verbosityRule = {
 	id: "verbosity",
 	severity: "advise",
@@ -15,14 +33,14 @@ const verbosityRule = {
 		const body = input.message.split("\n").slice(2).filter((l) => l.length > 0);
 		const lineCount = body.length;
 		const wordCount = body.join(" ").trim().split(/\s+/).filter(Boolean).length;
-		if (lineCount <= 25 && wordCount <= 400) return null;
+		if (lineCount <= 12 && wordCount <= 150) return null;
 		const reasons = [];
-		if (lineCount > 25) reasons.push(`${lineCount} non-empty body lines`);
-		if (wordCount > 400) reasons.push(`${wordCount} words`);
+		if (lineCount > 12) reasons.push(`${lineCount} non-empty body lines`);
+		if (wordCount > 150) reasons.push(`${wordCount} words`);
 		return {
 			ruleId: "verbosity",
 			severity: "advise",
-			message: `Body has ${reasons.join(" / ")}; the project standard keeps commit bodies under ~${25} lines and ~${400} words. Move detail to the PR description and keep the commit body to the irreducible "what + why".`
+			message: `Body has ${reasons.join(" / ")}; the project standard is three to five bullets, or one to two short paragraphs, under ~${12} lines and ~${150} words. This repo squash-merges, so a long body is discarded at merge. Cut to the user-visible change, the behavior a consumer could trip over, and any non-obvious trap; move the reasoning and evidence to the PR description.`
 		};
 	})
 };

package/commitlint/index.js

@@ -60,8 +60,8 @@ var commitlint_exports = /* @__PURE__ */ __exportAll({
 	TDD_STATES: () => TDD_STATES,
 	TYPE_EMOJIS: () => TYPE_EMOJIS,
 	TYPE_EMOJIS_UNICODE: () => TYPE_EMOJIS_UNICODE,
-	VERBOSITY_LINE_THRESHOLD: () => 25,
-	VERBOSITY_WORD_THRESHOLD: () => 400,
+	VERBOSITY_LINE_THRESHOLD: () => 12,
+	VERBOSITY_WORD_THRESHOLD: () => 150,
 	buildSigningDiagnostic: () => buildSigningDiagnostic,
 	closesTrailerRule: () => closesTrailerRule,
 	createPromptConfig: () => createPromptConfig,

package/index.d.ts

@@ -6513,8 +6513,26 @@ declare const softWrapRule: Rule<SoftWrapInput, never>;
 interface VerbosityInput {
   message: string;
 }
-declare const VERBOSITY_LINE_THRESHOLD = 25;
-declare const VERBOSITY_WORD_THRESHOLD = 400;
+/**
+ * Body-line ceiling before the rule advises.
+ *
+ * @remarks
+ * The house format is three to five bullets (or one to two short paragraphs)
+ * plus a `Closes` line and a `Signed-off-by` line, and the counted body here
+ * includes those two trailers. That is a 7-line message at the top of the
+ * intended range, so 12 leaves headroom and fires only on a body that is
+ * clearly past the format rather than at its boundary.
+ */
+declare const VERBOSITY_LINE_THRESHOLD = 12;
+/**
+ * Body-word ceiling before the rule advises.
+ *
+ * @remarks
+ * Five bullets at roughly 20 words each, plus trailers, lands near 110. A
+ * two-paragraph prose body lands lower. 150 is the point past which a body
+ * has stopped being a scannable index entry.
+ */
+declare const VERBOSITY_WORD_THRESHOLD = 150;
 declare const verbosityRule: Rule<VerbosityInput, never>;
 declare namespace index_d_exports$1 {
   export { BranchInfo, COMMIT_TYPES, COMMIT_TYPE_DEFINITIONS, ClosesTrailerCtx, ClosesTrailerInput, CommitType, CommitTypeDefinition, CommitlintConfig, CommitlintPlugin, CommitlintUserConfig, ConfigOptions, DCO_SIGNOFF_TEXT, DEFAULT_BODY_MAX_LINE_LENGTH, ERROR_EXPLANATIONS, ERROR_SUGGESTIONS, ForbiddenContentInput, FormatterResult, HookOutput, RuleSeverity$1 as HookRuleSeverity, HookSilencer, ISSUES_CACHE_RELATIVE_PATH, ISSUES_CACHE_TTL_SECONDS, Inquirer, LintOutcome, LockfilePresence, OpenIssue, PackageManager$1 as PackageManager, ParsedCommit, ParsedKind, PlanLeakageInput, PostToolUseEnvelope, PostToolUseEnvelope as PostToolUseEnvelopeType, PreToolUseEnvelope, PreToolUseEnvelope as PreToolUseEnvelopeType, PromptConfig, PromptConfigOptions, PromptQuestion, PromptSettings, PrompterOptions, Question, RawSigningInputs, ReleaseFormat, ResolvedPromptConfig, Rule, RuleApplicability, RuleConfigTuple, RuleHit, RuleResult, RuleSeverity, RulesConfig, SessionStartEnvelope, SessionStartEnvelope as SessionStartEnvelopeType, SigningDiagnostic, SigningFlagCtx, SigningFlagInput, SoftWrapInput, TDD_SCOPE_PATTERN, TDD_STATES, TYPE_EMOJIS, TYPE_EMOJIS_UNICODE, TypeEnumEntry, VERBOSITY_LINE_THRESHOLD, VERBOSITY_WORD_THRESHOLD, VerbosityInput, buildSigningDiagnostic, closesTrailerRule, createPromptConfig, createTypeEnum, CommitlintConfig as default, defaultPromptConfig, detectDCO, detectFromLockfiles, detectPackageManager, detectScopes, emojiPromptConfig, fetchAndCacheOpenIssues, forbiddenContentRule, format, getExplanation, getSuggestion, getTypeEmoji, hasClosingTrailer, inferTicketId, parseBashCommand, parseGpgKeyExpiry, parseHuskyConfigPath, parsePackageManagerField, partitionHits, planLeakageRule, postToolUseAdvise, preToolUseAdvise, preToolUseAllow, preToolUseDeny, preToolUseSilent, prompter, readBranchInfo, readCache, readCommitlintConfigPath, readOpenIssuesFromCache, readOrFetchOpenIssues, readSigningDiagnostic, sessionStartContext, signingFlagConflictRule, softWrapRule, staticConfig, verbosityRule, writeCache };

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@savvy-web/silk-effects",
-	"version": "5.2.0",
+	"version": "5.3.0",
 	"private": false,
 	"description": "Shared Effect library for Silk Suite conventions",
 	"homepage": "https://github.com/savvy-web/systems/tree/main/packages/silk-effects",
@@ -33,15 +33,15 @@
 		"@changesets/config": "^4.0.0-next.6",
 		"@changesets/get-github-info": "^1.0.0-next.4",
 		"@changesets/get-release-plan": "^5.0.0-next.9",
-		"@effected/commands": "^0.2.0",
-		"@effected/git": "^0.5.1",
-		"@effected/glob": "^0.2.1",
-		"@effected/jsonc": "^0.5.1",
-		"@effected/package-json": "^0.7.1",
-		"@effected/templates": "^0.1.0",
-		"@effected/walker": "^0.3.3",
-		"@effected/workspaces": "^0.9.3",
-		"@effected/yaml": "^0.6.0",
+		"@effected/commands": "^0.2.1",
+		"@effected/git": "^0.5.2",
+		"@effected/glob": "^0.2.2",
+		"@effected/jsonc": "^0.5.2",
+		"@effected/package-json": "^0.7.2",
+		"@effected/templates": "^0.1.1",
+		"@effected/walker": "^0.3.4",
+		"@effected/workspaces": "^0.9.4",
+		"@effected/yaml": "^0.6.1",
 		"@manypkg/get-packages": "^3.1.0",
 		"mdast-util-heading-range": "^4.0.0",
 		"mdast-util-to-string": "^4.0.0",