@savvy-web/bundler 2.0.13 → 2.1.1

package/README.md

@@ -58,7 +58,11 @@ The bundler ships its shared TypeScript base as a subpath export. Extend it from
 }
 ```
 
-`ecma.json` sets ESNext libs, NodeNext resolution, strict mode and `composite` declaration output. Override any of it in your own `tsconfig.json`.
+`ecma.json` sets ESNext libs, NodeNext resolution, strict mode and declaration emit (`declaration: true`, `composite: false`). Override any of it in your own `tsconfig.json`.
+
+Pick the one preset that matches your package type and extend it once: `@savvy-web/bundler/tsconfig/ecma.json` for a plain Node library, `@savvy-web/rspress-builder/tsconfig/plugin.json` for an RSPress plugin, `@savvy-web/github-action-builder/tsconfig/action.json` for a GitHub Action. Each preset is a complete, self-contained config for its package type — none of them uses `extends` internally, so you never need to compose or chain them together.
+
+That design choice exists because TypeScript's own `extends` replaces array-valued compiler options rather than merging them. If you override `types` or `lib` in your own `tsconfig.json`, the override replaces the base preset's list outright instead of adding to it, so you have to re-list every entry you still need, `node` included, or lose it silently — the symptom is `console`, `process` and `Buffer` no longer resolving. `packages/rspress-builder/public/tsconfig/plugin.json` illustrates both points at once: it is a fully self-contained preset for RSPress plugins, and it declares `types: ["node", "react", "react-dom"]` rather than assuming `node` inherits.
 
 ## Multi-target publishing
 
@@ -206,7 +210,7 @@ const config = defineBuild({
 
 ## Per-entry overrides
 
-The format and bundling fields above apply to every export entry. Use `overrides` to pin a subset of entries to their own format and bundling, layered onto the base config. The base build stays as configured; only the listed `entries` (by export subpath) get the override:
+The format and bundling fields above apply to every export entry. Use `overrides` to pin a subset of entries to their own format and bundling. Each override is built from its own values alone — it does not inherit from the base config, so every field it needs must be listed again (see below). The base build stays as configured; only the listed `entries` (by export subpath) get the override:
 
 ```ts
 const config = defineBuild({
@@ -223,7 +227,7 @@ const config = defineBuild({
 });
 ```
 
-Each override carries the same `format`, `bundle`, `externals`, `bundleNodeModules`, `bundledPackages` and `dtsExternals` fields as the base config, plus three partition-only fields: `platform` (the JS-pass target, `"node"` by default or `"browser"` for a client runtime), `css` (forwarded to tsdown's `css` option to enable `@tsdown/css`) and `outSubdir` (builds the partition into an isolated `<group>/pkg/<subdir>/` sub-package, for which exactly one export path may be pinned). An override does not inherit the base `externals` — list what that partition needs. The build errors if an override names an export path the package does not declare. These partition fields are what [`@savvy-web/rspress-builder`](https://www.npmjs.com/package/@savvy-web/rspress-builder) composes to build an RSPress plugin's browser runtime bundle.
+Each override carries the same `format`, `bundle`, `externals`, `bundleNodeModules`, `bundledPackages` and `dtsExternals` fields as the base config, plus three partition-only fields: `platform` (the JS-pass target, `"node"` by default or `"browser"` for a client runtime), `css` (forwarded to tsdown's `css` option to enable `@tsdown/css`) and `outSubdir` (builds the partition into an isolated `<group>/pkg/<subdir>/` sub-package, for which exactly one export path may be pinned). An override does not inherit any base-config value — every field it needs, including `externals`, must be listed again. The build errors if an override names an export path the package does not declare. These partition fields are what [`@savvy-web/rspress-builder`](https://www.npmjs.com/package/@savvy-web/rspress-builder) composes to build an RSPress plugin's browser runtime bundle.
 
 ## Loose files
 
@@ -308,6 +312,14 @@ const config = defineBuild({
 
 `define` merges with the auto-injected version constant; a key of `process.env.__PACKAGE_VERSION__` in your own `define` wins.
 
+`@savvy-web/bundler` ships an ambient declaration for that injected key as its own `./env` types-only export, so a consumer's `process.env.__PACKAGE_VERSION__` resolves instead of falling through `@types/node`'s untyped index signature. Add a triple-slash reference to a `.d.ts` in your project to pull it in:
+
+```ts
+/// <reference types="@savvy-web/bundler/env" />
+```
+
+That gives you `readonly __PACKAGE_VERSION__?: string` on `NodeJS.ProcessEnv` — optional, matching the `?? "0.0.0"` fallback every consumer already uses for unbuilt source.
+
 ## Features
 
 - **One self-executing config** — `savvy.build.ts` is a top-level `await build({...})` call that derives `cwd` and `argv` from process globals. No main guard, no `export default`, no factory-notation config file.

package/env.d.ts

@@ -0,0 +1,12 @@
+// Ambient process.env declaration for packages built with @savvy-web/bundler.
+
+declare namespace NodeJS {
+	interface ProcessEnv {
+		/**
+		 * The built package's version, injected at build time by `@savvy-web/bundler`
+		 * (`buildTargetGroups`'s `define`, `process.env.__PACKAGE_VERSION__`). Absent when running
+		 * unbuilt source — a consumer reading it should fall back, e.g. `?? "0.0.0"`.
+		 */
+		readonly __PACKAGE_VERSION__?: string;
+	}
+}

package/index.d.ts

@@ -1,4 +1,4 @@
-import { AmbientDtsEntry, BuildFormat, BuildPlatform, BuildReport, BuildTargetGroupsOptions, CopyAmbientDtsOptions, CssOptions, ExeConfig, GenerateMetaOptions, Json, JsxConfig, LooseFiles, MetaOptions, MetaResult, NextVersions, PublishTargets, RenderedOutput, RunExeBuildOptions, TargetGroupRef, TargetResolution, TsconfigJsx, defaultManifestTransform, extractAmbientDts } from "@savvy-web/tsdown-plugins";
+import { AmbientDtsEntry, BuildFormat, BuildPlatform, BuildReport, BuildTargetGroupsOptions, CssOptions, ExeConfig, GenerateMetaOptions, Json, JsxConfig, LooseFiles, MetaOptions, MetaResult, NextVersions, PublishTargets, RenderedOutput, RunExeBuildOptions, TargetGroupRef, TargetResolution, TsconfigJsx, defaultManifestTransform, extractAmbientDts } from "@savvy-web/tsdown-plugins";
 import { Plugin, Plugin as Plugin$1 } from "rolldown";
 //#region src/config.d.ts
 /** @public */
@@ -269,8 +269,6 @@ interface RunOptions {
       message: string;
     } | undefined;
   }) => string | undefined;
-  /** Injectable ambient-.d.ts copier (defaults to copyAmbientDts). */
-  readonly copyAmbientDts?: ((o: CopyAmbientDtsOptions) => void) | undefined;
 }
 /** Run a build from a normalized config. Pure orchestration; all IO injectable. @public */
 declare function runBuild(config: BuildConfig, options: RunOptions): Promise<void>;

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@savvy-web/bundler",
-	"version": "2.0.13",
+	"version": "2.1.1",
 	"private": false,
 	"description": "Zero-config tsdown-based bundler for Silk Suite TypeScript packages",
 	"homepage": "https://github.com/savvy-web/systems/tree/main/packages/bundler",
@@ -25,11 +25,14 @@
 			"import": "./index.js",
 			"default": "./index.js"
 		},
+		"./env": {
+			"types": "./env.d.ts"
+		},
 		"./tsconfig/ecma.json": "./tsconfig/ecma.json",
 		"./package.json": "./package.json"
 	},
 	"dependencies": {
-		"@savvy-web/tsdown-plugins": "2.2.2",
+		"@savvy-web/tsdown-plugins": "2.4.0",
 		"@tsdown/exe": "^0.22.14",
 		"effect": "4.0.0-beta.101",
 		"rolldown": "^1.2.0",

package/run.js

@@ -1,5 +1,5 @@
 import { defineBuild, parseArgs } from "./config.js";
-import { BuildCollector, ConfigValidationError, ConfigValidator, ConfigValidatorLive, ReportPipelineLive, assertNoEntryCollisions, buildEmittedManifest, buildTargetGroups, computeExeFileName, copyAmbientDts, createEntryName, deriveExportPaths, extractAmbientDts, normalizeExeOptions, normalizeLooseFiles, packageJsonEntries, readTsconfigJsx, removeDeclarationMaps, renderReport, resolveJsxConfig, resolveTargets, runExeBuild, runMetaPass, writeIssuesArtifact, writeResolvedTsconfig, writeTargetsBinding } from "@savvy-web/tsdown-plugins";
+import { BuildCollector, ConfigValidationError, ConfigValidator, ReportPipeline, assertNoEntryCollisions, buildEmittedManifest, buildTargetGroups, computeExeFileName, createEntryName, deriveExportPaths, extractAmbientDts, normalizeExeOptions, normalizeLooseFiles, packageJsonEntries, readTsconfigJsx, removeDeclarationMaps, renderReport, resolveJsxConfig, resolveTargets, runExeBuild, runMetaPass, writeIssuesArtifact, writeResolvedTsconfig, writeTargetsBinding } from "@savvy-web/tsdown-plugins";
 import { copyFileSync, existsSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
 import { dirname, join } from "node:path";
 import { Effect } from "effect";
@@ -32,8 +32,9 @@ function readPackageJson(cwd) {
 }
 /** Resolve the prod build groups and the target binding from publishConfig.targets (or the single-npm default). */
 function deriveProdGroups(targets, baseName) {
+	const effective = targets !== void 0 && Object.keys(targets).length > 0 ? targets : { npm: true };
 	const resolution = resolveTargets({
-		targets: targets !== void 0 && Object.keys(targets).length > 0 ? targets : { npm: true },
+		targets: effective,
 		baseName
 	});
 	return {
@@ -87,7 +88,8 @@ async function runBuild(config, options) {
 	};
 	let renderAndWrite;
 	try {
-		const jsx = resolveJsxConfig((options.readTsconfigJsx ?? (() => readTsconfigJsx(cwd)))(), config.jsx);
+		const readJsx = options.readTsconfigJsx ?? (() => readTsconfigJsx(cwd));
+		const jsx = resolveJsxConfig(readJsx(), config.jsx);
 		const tsconfigPath = (options.writeTsconfig ?? ((c) => writeResolvedTsconfig({
 			cwd: c,
 			...jsx?.runtime === "automatic" ? {
@@ -114,7 +116,7 @@ async function runBuild(config, options) {
 			osCpu: osCpuForValidate,
 			...config.meta !== void 0 && config.meta !== false ? { meta: config.meta } : {},
 			...config.looseFiles !== void 0 ? { looseFiles: config.looseFiles } : {}
-		})).pipe(Effect.provide(ConfigValidatorLive)));
+		})).pipe(Effect.provide(ConfigValidator.layer)));
 		const exeSpecs = config.exe !== void 0 ? normalizeExeOptions(config.exe, osCpuForValidate) : [];
 		if (config.exe !== void 0 && (exeSpecs.length !== 1 || (exeSpecs[0]?.targets.length ?? 0) !== 1)) throw new Error(`exe build requires exactly one binary with one target (got ${exeSpecs.length} spec(s), ${exeSpecs[0]?.targets.length ?? 0} target(s) on the first). A package's exports["."] resolves to a single SEA — cross-platform binaries must each ship as their own per-platform package.`);
 		const exeSpec = exeSpecs[0];
@@ -231,7 +233,7 @@ async function runBuild(config, options) {
 				...explicitFormat !== void 0 ? { explicitFormat } : {},
 				verbose,
 				noColor: process.env.NO_COLOR !== void 0 || !process.stdout.isTTY
-			}).pipe(Effect.provide(ReportPipelineLive)));
+			}).pipe(Effect.provide(ReportPipeline)));
 			for (const output of rendered) writeOutput(output);
 		};
 		if (hasJsEntries || config.exe === void 0) await build({
@@ -280,14 +282,6 @@ async function runBuild(config, options) {
 			});
 		}
 		if (target === "prod") for (const g of groups) removeDeclarationMaps(join(cwd, "dist", "prod", g.id, "pkg"));
-		if (ambient.length > 0 && (target === "dev" || target === "prod")) {
-			const copyAmbient = options.copyAmbientDts ?? copyAmbientDts;
-			for (const g of groups) copyAmbient({
-				ambient,
-				srcCwd: cwd,
-				outDir: target === "dev" ? join(cwd, "dist", "dev", "pkg") : join(cwd, "dist", "prod", g.id, "pkg")
-			});
-		}
 		if (config.exe !== void 0 && exeSpec !== void 0 && exeRewrite !== void 0 && exeFileName !== void 0) {
 			const runExe = options.runExeBuild ?? runExeBuild;
 			const groupOutDir = (g) => target === "dev" ? join(cwd, "dist", "dev", "pkg") : join(cwd, "dist", "prod", g.id, "pkg");

package/tsconfig/ecma.json

@@ -1,8 +1,9 @@
 {
+	"//": "types and lib REPLACE the base list rather than merging with it. If you override either, re-list every entry you still need, including node.",
 	"$schema": "https://json.schemastore.org/tsconfig.json",
 	"compilerOptions": {
 		"allowSyntheticDefaultImports": true,
-		"composite": true,
+		"composite": false,
 		"declaration": true,
 		"declarationDir": "${configDir}/dist",
 		"declarationMap": false,
@@ -42,7 +43,8 @@
 		"${configDir}/__fixtures__/**/*"
 	],
 	"include": [
-		"${configDir}/types/*.ts",
+		"${configDir}/src/*.d.ts",
+		"${configDir}/types/*.d.ts",
 		"${configDir}/package.json",
 		"${configDir}/*.ts",
 		"${configDir}/*.cts",