@sasjs/lint 4.3.0 → 4.3.2

package/.github/CONTRIBUTING.md

@@ -92,6 +92,51 @@ Two habits catch the failures that plain coverage does not:
 - **Mutation-check your assertions.** Revert the behaviour one piece at a time and confirm a test fails. An assertion that passes on the broken code is documenting nothing. Watch for vacuous cases: for example, a "does not throw" test over a mis-split file passes while the mis-split still contains the string being searched for, so the fixture has to be shaped to fail.
 - **A negative test must fail for the reason it names.** Assert on the specific message or error, never a bare `toThrow()`.
 
+### Mutation testing
+
+The habit above is automated, because the mutant you think to try is rarely the
+one that matters. Stryker rewrites the source in small ways (an operator, a
+string, a branch) and runs the tests; a mutant that survives is behaviour no
+test asserts.
+
+```bash
+npm run mutation:changed     # only the files this branch changed, vs the baseline
+MUTATION_FILES=src/utils/parseMacroCalls.ts npm run mutation:changed   # one file
+npm run mutation             # whatever stryker.conf.json selects
+npm run mutation:watch       # the whole tree; prints a refreshed baseline
+```
+
+The gate compares each file with `mutation-baseline.json` and fails when a file
+carries MORE surviving mutants than the baseline records, so it asks "did this
+branch add an untested behaviour?", not "is the repo perfect yet". A file with no
+baseline must reach 80%. `mutation-pr.yml` runs the changed-file gate on every
+pull request; `mutation-weekly.yml` runs the whole tree and fails if anything
+regressed, which is how the baseline is refreshed (the run prints the new JSON to
+paste in).
+
+Two things to know before running it:
+
+- the dev tree needs Node 22.18 or newer: `@stryker-mutator/core` pulls `@babel/*` 8,
+  whose `engines` start at 22.18. `package.json` records that in `devEngines` (dev installs
+  warn, published installs are unaffected - the tarball carries no devDependencies).
+
+
+- `jest.stryker.config.js` differs from `jest.config.js` in switching coverage
+  off, and in nothing else: a skipped spec records the mutants it covers as
+  legitimate survivors, and the weekly refresh writes them into the baseline.
+  `isIgnored` therefore derives its path with `path.relative(root, file)` and
+  returns false for a path outside the root, and `isIgnored.spec.ts` pins
+  `getProjectRoot()` with a jest mock - the `ignore` package rejects an absolute
+  or `..`-prefixed path, which is what a sandbox run produced before.
+- a run mutates the file(s) in a sandbox under `.stryker-tmp`, and `jest.config.js`
+  ignores that directory by a `<rootDir>`-anchored pattern - an unanchored one
+  makes Stryker's own dry run collect nothing.
+
+A surviving mutant is either a missing test or an EQUIVALENT mutant (a change
+that cannot alter behaviour, such as dropping a check the following regular
+expression repeats). Add the spec that fails on it, or say in the PR body why it
+is equivalent - do not lower the baseline.
+
 ## Regenerating the shipped macro list
 
 The macros SAS ships are language data, owned by `@sasjs/sas-language`. Do not hand-write them here. `npm run generate:macros` reads its `macroStatements` and `macroFunctions` groups and writes `src/utils/sasMacros.generated.ts`, which is committed so the published package carries no runtime dependency. `sasMacros.spec.ts` reads the same data independently and fails when the committed list differs, which is the drift guard. Extending that vocabulary is a PR to `@sasjs/sas-language`.

package/.github/workflows/mutation-pr.yml

@@ -0,0 +1,69 @@
+name: Mutation (changed files)
+
+# Mutation testing answers a question coverage cannot: does any test FAIL when
+# the code is wrong? Stryker flips an operator or a string in the source and runs
+# the tests; a mutant that survives is behaviour nothing asserts.
+#
+# This job mutates only the source files the PR changed, and compares them with
+# mutation-baseline.json - so it asks "did this branch add an untested
+# behaviour?", not "is the repo perfect yet". The baseline is refreshed by
+# mutation-weekly.yml.
+#
+# Cost control: Stryker runs the tests that cover the mutated file
+# (`enableFindRelatedTests`), and only the mutated file is instrumented. A
+# two-file run takes minutes, not the hours a whole-suite run per mutant would.
+
+on:
+  pull_request:
+    paths:
+      - 'src/**'
+      - 'jest.config.js'
+      - 'jest.stryker.config.js'
+      - 'stryker.conf.json'
+      - 'mutation-baseline.json'
+      - 'scripts/mutation-gate.mjs'
+      - 'package.json'
+      - 'package-lock.json'
+
+# a second push supersedes the first run rather than queueing behind it
+concurrency:
+  group: mutation-${{ github.event.pull_request.number }}
+  cancel-in-progress: true
+
+jobs:
+  mutation:
+    runs-on: ubuntu-latest
+    # checkout needs read, and the job writes nothing else
+    permissions:
+      contents: read
+    # a changed-file run takes minutes; the default cap is six hours, which would
+    # hold a runner on a stuck mutation run
+    timeout-minutes: 20
+
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          # the diff against the base commit needs the base commit
+          fetch-depth: 0
+
+      - name: Use Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 22
+          cache: npm
+
+      - name: Install Dependencies
+        run: npm ci
+
+      - name: Mutate the changed files
+        env:
+          MUTATION_BASE: ${{ github.event.pull_request.base.sha }}
+        run: node scripts/mutation-gate.mjs pr
+
+      - name: Keep the report
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: mutation-report
+          path: reports/mutation/mutation.json
+          if-no-files-found: ignore

package/.github/workflows/mutation-weekly.yml

@@ -0,0 +1,92 @@
+name: Mutation Watch
+
+# The per-PR mutation gate compares a branch's changed files with a baseline, so
+# the baseline is the thing that has to stay honest: if it is never refreshed,
+# files that improve keep their old count and the gate stops asking for more.
+#
+# This runs the whole source tree weekly, prints the new baseline, and fails when
+# any file carries MORE surviving mutants than the recorded one - which means a
+# PR was merged without the gate seeing it (a push to main, a config change, a
+# file the gate skipped). Failure files an issue, as audit-watch.yml does, and
+# only a genuine regression does so.
+
+on:
+  schedule:
+    - cron: '0 7 * * 1' # Mondays, 07:00 UTC
+  workflow_dispatch:
+
+jobs:
+  watch:
+    runs-on: ubuntu-latest
+    # the whole tree takes ~20-30 minutes; bounded so a hang cannot hold a runner
+    # for the six-hour default
+    timeout-minutes: 90
+    permissions:
+      contents: read
+      issues: write
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Use Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 22
+          cache: npm
+
+      - name: Install Dependencies
+        run: npm ci
+
+      - name: Mutate the whole source tree
+        id: watch
+        env:
+          MUTATION_WATCH_REPORT: ${{ runner.temp }}/mutation-watch-report.md
+        run: node scripts/mutation-gate.mjs weekly
+
+      - name: Keep the report
+        if: always()
+        uses: actions/upload-artifact@v4
+        with:
+          name: mutation-watch-report
+          path: |
+            reports/mutation/mutation.json
+            ${{ runner.temp }}/mutation-watch-report.md
+          if-no-files-found: ignore
+
+  report:
+    needs: watch
+    # a failure files an issue; a cancelled run does so only when the schedule
+    # cancelled it (the 90-minute timeout), so cancelling a manual run by hand
+    # does not claim a regression that never happened
+    if: >-
+      always() &&
+      (needs.watch.result == 'failure' ||
+       (needs.watch.result == 'cancelled' && github.event_name == 'schedule'))
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+    permissions:
+      contents: read
+      issues: write
+
+    steps:
+      - name: File an issue
+        env:
+          GH_TOKEN: ${{ github.token }}
+        run: |
+          title='Mutation watch: a file carries more surviving mutants than the baseline'
+          existing=$(gh issue list --state open --search "\"$title\" in:title" \
+            --json number --jq '.[0].number // empty')
+
+          if [ -n "$existing" ]; then
+            echo "already tracked in #$existing"
+            exit 0
+          fi
+
+          gh issue create --title "$title" --body \
+            "The weekly mutation run found a file carrying more surviving mutants than mutation-baseline.json records, so behaviour was merged without a test that fails on it.
+
+          The run names the file and each surviving mutant (file:line:column, mutator, replacement), and prints the refreshed baseline:
+
+          $GITHUB_SERVER_URL/$GITHUB_REPOSITORY/actions/runs/$GITHUB_RUN_ID
+
+          Close this once a spec kills them and mutation-baseline.json is updated from that run."

package/README.md

@@ -118,7 +118,15 @@ The default header is as follows:
 **/
 ```
 
-A blank line separates the `<h4> SAS Macros </h4>` section from the header content before it and from whatever follows the list. The same blank-line convention applies to the `<h4> Other Macros </h4>` section.
+A blank line separates the `<h4> SAS Macros </h4>` section from the header content before it and from whatever follows the list.
+
+`<h4> SAS Macros </h4>` is the compile dependency list: `sasjs compile` reads it and inlines each macro as precode, so an entry is a file the build resolves. It is the only header list this linter reads, and every other `<h4>` list in the header (`SAS Includes`, `Binary Files`, `SAS Programs`, `Service Inputs`, `Service Outputs`, ...) is left entirely alone.
+
+Each entry is the tag and one file token - `@li mf_trim.sas` - indented to the same width as the section tag; nothing may follow the token. The extension is dropped to give the macro name, so `@li mp_as` is read as `mp_as` too. A line carrying anything after the file token is not an entry: prose belongs on its own line, and a section that carries such a line is left as its author wrote it rather than being rewritten or having the line removed. The section is machine-maintained, so text after the token would be lost on the next rewrite anyway.
+
+A tag one slip away from `@li` (`@il`, `@l1`, `@1i`) is read as an entry, so a typo cannot hide the declarations below it - and because such a line is read, nothing reports it, so the formatter writes every entry back as `@li <file>` at the section's indentation. The repair edits the entry lines in place, so it adds no blank lines and moves nothing else in the header.
+
+A line that opens with any other tag - `@example`, `@param` - ends the list rather than being read or converted. The entries above it are still readable and still rewritable, so the formatter keeps adding and removing entries above that line and leaves the rest of the header alone.
 
 If creating a new value, use `{lineEnding}` instead of `\n`, eg as follows:
 
@@ -362,10 +370,12 @@ This will highlight lines with trailing spaces. Trailing spaces serve no useful
 
 ### noUndeclaredMacros
 
-SASjs programs declare the macros they use in the `<h4> SAS Macros </h4>` section of the header, so that the compiler can assemble the job before it runs. This rule reports a warning for each macro that a file invokes without declaring it - either by defining it in the file, or by listing it under `<h4> SAS Macros </h4>` or `<h4> Other Macros </h4>`.
+SASjs programs declare the macros they use in the `<h4> SAS Macros </h4>` section of the header, so that the compiler can assemble the job before it runs. This rule reports a warning for each macro that a file invokes without declaring it - either by defining it in the file, or by listing it in the `<h4> SAS Macros </h4>` section. That is the only header list `sasjs compile` reads, so it is the only one that makes a macro available to the job; entries anywhere else in the header do not count.
 
 The macros that ship with SAS (`%scan`, `%index`, `%sysfunc` and the other macro functions, along with the macro language keywords such as `%if`, `%then` and `%do`) are always considered declared, so they are never reported. That list is generated from the `macroStatements` and `macroFunctions` groups of `@sasjs/sas-language` (`npm run generate:macros`), so it tracks the SAS language data rather than being maintained here. Macros made available through the `SASAUTOS` system option are not visible to the linter and will be reported - list them in [`ignoredMacros`](#ignoredmacros), which carries `webout` by default.
 
+An invocation written inside the argument of `%str` / `%nrstr` is not reported. A file masks a trigger to print it as often as to defer it, and nothing runs at that point, so a warning there would land on text that may never be code. [`noUnusedMacros`](#nounusedmacros) counts such a name as a use, so the deferred form - `%mp_abort(iftrue=%str(%mf_existds(work.x)=1))` - satisfies the declaration it depends on without demanding one.
+
 The warning is resolved by adding the macro name to the header. Running `sasjs lint fix` (or saving in the SASjs VS Code extension with `formatOnSave`) adds the missing macros automatically, as a unique list sorted alphabetically.
 
 - Default: true
@@ -421,7 +431,9 @@ The counterpart of `noUndeclaredMacros`. This rule reports a warning for each ma
 
 A macro can be referenced indirectly - for example by another macro in the dependency chain, or through a dynamic `%&macro` call - without appearing as a direct invocation in the file, so the warning is advisory.
 
-Running `sasjs lint fix` (or saving in the SASjs VS Code extension with `formatOnSave`) removes the unused entries from the header. Together with `noUndeclaredMacros`, this leaves the `<h4> SAS Macros </h4>` section listing exactly the macros the file uses.
+An invocation written inside the argument of `%str` / `%nrstr` counts as a use. That text is data while the masking function runs, but its caller normally unquotes it - `%mp_abort(iftrue=%str(%mf_existds(work.x)=1))` resolves `%mf_existds` when `%mp_abort` evaluates the condition - so the declaration is a dependency of the file, and treating it as unused would have the formatter delete it.
+
+Running `sasjs lint fix` (or saving in the SASjs VS Code extension with `formatOnSave`) removes the unused entries from the header. Together with `noUndeclaredMacros`, this leaves the `<h4> SAS Macros </h4>` section listing exactly the macros the file uses. The pass that reads the list also writes each entry back as `@li <macro>.sas` at the section's indentation, in place and without re-spacing the header, so a mistyped tag (`@il`) is repaired even when no entry is removed.
 
 - Default: true
 - Severity: WARNING

package/jest.config.js

@@ -1,12 +1,61 @@
 module.exports = {
   preset: 'ts-jest',
   testEnvironment: 'node',
+  // A Stryker run keeps a sandbox under .stryker-tmp with a copy of src/ in it.
+  // Without this, any jest run that overlaps a mutation run collects every spec
+  // twice (measured: 946 tests instead of 464) and reports failures from files
+  // that are being mutated. Anchored to <rootDir> on purpose: inside the sandbox
+  // the whole project IS under .stryker-tmp, and an unanchored pattern would make
+  // Stryker's own dry run collect nothing ("No tests were executed").
+  testPathIgnorePatterns: [
+    '/node_modules/',
+    '<rootDir>/.stryker-tmp/',
+    '<rootDir>/build/'
+  ],
   coverageThreshold: {
     global: {
       branches: 80,
       functions: 80,
       lines: 80,
       statements: -10
+    },
+    // Per-path floors, so a change that hollows out one area cannot hide behind
+    // the aggregate. Every number is the coverage measured when this was written,
+    // rounded down, so the block is a ratchet: raise one when the area improves,
+    // never lower one to get a branch green. `statements` is a PERCENTAGE unless
+    // it is negative, where `-N` reads as "at most N uncovered statements" - so a
+    // plain `0` asserts nothing at all (0% coverage passes), which is why the two
+    // fully-covered areas ask for 100 and the three with known gaps carry a budget
+    // measured from the tree on the day this landed.
+    './src/utils/': {
+      branches: 95,
+      functions: 100,
+      lines: 99,
+      statements: -4
+    },
+    './src/rules/': {
+      branches: 95,
+      functions: 100,
+      lines: 100,
+      statements: 100
+    },
+    './src/lint/': {
+      branches: 85,
+      functions: 100,
+      lines: 100,
+      statements: -2
+    },
+    './src/format/': {
+      branches: 90,
+      functions: 100,
+      lines: 100,
+      statements: 100
+    },
+    './src/types/': {
+      branches: 95,
+      functions: 100,
+      lines: 96,
+      statements: -4
     }
   },
   collectCoverageFrom: ['src/**/{!(index|formatExample|lintExample),}.ts']

package/jest.stryker.config.js

@@ -0,0 +1,17 @@
+/**
+ * Jest config for Stryker runs.
+ *
+ * The only difference from jest.config.js is that coverage is off: Stryker
+ * instruments the code itself, and the coverage thresholds would fail a
+ * single-mutant run. The suite itself runs in full, so the weekly baseline is
+ * built on every test - a skipped spec here would record mutants it covers as
+ * legitimate survivors and let them into the baseline permanently.
+ */
+const base = require('./jest.config.js')
+
+module.exports = {
+  ...base,
+  collectCoverage: false,
+  coverageThreshold: undefined,
+  collectCoverageFrom: undefined
+}

package/mutation-baseline.json

@@ -0,0 +1,30 @@
+{
+  "_comment": "Surviving-mutant counts per file, used by scripts/mutation-gate.mjs. Refresh from the output of npm run mutation:watch; raise a count only with a reason in the PR that raises it.",
+  "generatedAt": "2026-10-25T20:06:38Z",
+  "files": {
+    "src/rules/file/noUnusedMacros.ts": {
+      "score": 100.0,
+      "survived": 0,
+      "killed": 37,
+      "timeout": 0
+    },
+    "src/utils/getIndicesOf.ts": {
+      "score": 100.0,
+      "survived": 0,
+      "killed": 15,
+      "timeout": 6
+    },
+    "src/utils/isIgnored.ts": {
+      "score": 100.0,
+      "survived": 0,
+      "killed": 25,
+      "timeout": 0
+    },
+    "src/utils/parseMacroCalls.ts": {
+      "score": 92.98,
+      "survived": 25,
+      "killed": 293,
+      "timeout": 38
+    }
+  }
+}

package/package.json

@@ -12,7 +12,10 @@
     "publishInit": "cp -r ./build/* . && rm -rf ./build && rm -rf ./src && rm tsconfig.json",
     "package:lib": "npm run build && cp ./package.json ./checkNodeVersion.js build && cp README.md build && cd build && npm version \"5.0.0\" && npm pack",
     "lint:fix": "npx prettier --write \"{src,test}/**/*.{ts,tsx,js,jsx,html,css,sass,less,json,yml,md,graphql}\"",
-    "lint": "npx prettier --check \"{src,test}/**/*.{ts,tsx,js,jsx,html,css,sass,less,json,yml,md,graphql}\""
+    "lint": "npx prettier --check \"{src,test}/**/*.{ts,tsx,js,jsx,html,css,sass,less,json,yml,md,graphql}\"",
+    "mutation": "stryker run",
+    "mutation:changed": "node scripts/mutation-gate.mjs pr",
+    "mutation:watch": "node scripts/mutation-gate.mjs weekly"
   },
   "publishConfig": {
     "access": "public"
@@ -62,6 +65,8 @@
   "devDependencies": {
     "@nogoo9/gitleaks": "8.30.1-post.2",
     "@sasjs/sas-language": "0.3.0",
+    "@stryker-mutator/core": "10.1.1",
+    "@stryker-mutator/jest-runner": "10.1.1",
     "@types/jest": "30.0.0",
     "@types/node": "26.6.3",
     "jest": "30.5.2",
@@ -73,5 +78,12 @@
     "@sasjs/utils": "4.0.0",
     "ignore": "7.0.11"
   },
-  "version": "4.3.0"
+  "version": "4.3.2",
+  "devEngines": {
+    "runtime": {
+      "name": "node",
+      "version": ">=22.18",
+      "onFail": "warn"
+    }
+  }
 }

package/rules/file/noUndeclaredMacros.js

@@ -10,14 +10,21 @@ const parseMacros_1 = require("../../utils/parseMacros");
 const sasMacros_1 = require("../../utils/sasMacros");
 const name = 'noUndeclaredMacros';
 const description = 'Enforce that every macro used in a file is declared.';
-const message = `Macro '{macro}' is not declared - add it to the <h4> SAS Macros </h4> or <h4> Other Macros </h4> section of the header, or list the macro in 'ignoredMacros'`;
+const message = `Macro '{macro}' is not declared - add it to the <h4> SAS Macros </h4> section of the header, or list the macro in 'ignoredMacros'`;
 /**
  * Collects the first invocation of each macro that the file uses but does not
  * declare. A macro is declared when it is defined in the file, or listed in the
- * `<h4> SAS Macros </h4>` or `<h4> Other Macros </h4>` section of its header.
+ * `<h4> SAS Macros </h4>` section of its header - the only header list that
+ * `sasjs compile` reads.
  * Macros that ship with SAS are always considered declared, and so are the
  * names the configuration lists in `ignoredMacros` - a macro such as `%webout`
  * has no file to point at.
+ *
+ * The scan leaves out the argument of `%str` / `%nrstr`: a file that masks a
+ * trigger usually does so to print it, and reporting it would be a new warning
+ * on text that never runs at that point. `noUnusedMacros` counts those names,
+ * which is the conservative direction - a deferred invocation satisfies a
+ * declaration without ever demanding one.
  */
 const getUndeclaredCalls = (value, config) => {
     if (!value)

package/rules/file/noUndeclaredMacros.js.map

@@ -1 +1 @@
-{"version":3,"file":"noUndeclaredMacros.js","sourceRoot":"","sources":["../../../src/rules/file/noUndeclaredMacros.ts"],"names":[],"mappings":";;;AAAA,uCAAoD;AAEpD,2DAAuD;AACvD,mDAA+C;AAC/C,2DAA6E;AAC7E,iEAAwE;AACxE,yDAAqD;AACrD,qDAAkD;AAElD,MAAM,IAAI,GAAG,oBAAoB,CAAA;AACjC,MAAM,WAAW,GAAG,sDAAsD,CAAA;AAC1E,MAAM,OAAO,GAAG,8JAA8J,CAAA;AAE9K;;;;;;;GAOG;AACH,MAAM,kBAAkB,GAAG,CAAC,KAAa,EAAE,MAAkB,EAAe,EAAE;IAC5E,IAAI,CAAC,KAAK;QAAE,OAAO,EAAE,CAAA;IAErB,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAA;IAElC,IAAA,yBAAW,EAAC,KAAK,EAAE,MAAM,CAAC,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;QAC3C,IAAI,KAAK,CAAC,IAAI;YAAE,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC,CAAA;IACxD,CAAC,CAAC,CAAA;IAEF,IAAA,8BAAe,EAAC,KAAK,EAAE,MAAM,CAAC,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;QAC/C,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC,CAAA;IACxC,CAAC,CAAC,CAAA;IAEF,MAAM,OAAO,GAAG,IAAI,GAAG,CACrB,MAAM,CAAC,aAAa,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC,CAChE,CAAA;IAED,MAAM,UAAU,GAAgB,EAAE,CAAA;IAClC,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAA;IAE9B,IAAA,iCAAe,EAAC,KAAK,EAAE,MAAM,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;QAC9C,MAAM,GAAG,GAAG,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,CAAA;QACnC,IAAI,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC;YAAE,OAAM;QACzB,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAA;QAEb,IAAI,IAAA,sBAAU,EAAC,IAAI,CAAC,IAAI,CAAC;YAAE,OAAM;QACjC,IAAI,OAAO,CAAC,GAAG,CAAC,GAAG,CAAC;YAAE,OAAM;QAC5B,IAAI,QAAQ,CAAC,GAAG,CAAC,GAAG,CAAC;YAAE,OAAM;QAE7B,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;IACvB,CAAC,CAAC,CAAA;IAEF,OAAO,UAAU,CAAA;AACnB,CAAC,CAAA;AAED,MAAM,IAAI,GAAG,CAAC,KAAa,EAAE,MAAmB,EAAgB,EAAE;IAChE,MAAM,GAAG,GAAG,MAAM,IAAI,IAAI,kBAAU,EAAE,CAAA;IACtC,MAAM,QAAQ,GAAG,GAAG,CAAC,aAAa,CAAC,IAAI,CAAC,IAAI,mBAAQ,CAAC,OAAO,CAAA;IAE5D,OAAO,kBAAkB,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;QACnD,OAAO,EAAE,OAAO,CAAC,OAAO,CAAC,SAAS,EAAE,IAAI,CAAC,IAAI,CAAC;QAC9C,UAAU,EAAE,IAAI,CAAC,UAAU;QAC3B,iBAAiB,EAAE,IAAI,CAAC,iBAAiB;QACzC,eAAe,EAAE,IAAI,CAAC,eAAe;QACrC,QAAQ;KACT,CAAC,CAAC,CAAA;AACL,CAAC,CAAA;AAED,MAAM,GAAG,GAAG,CAAC,KAAa,EAAE,MAAmB,EAAU,EAAE;IACzD,MAAM,GAAG,GAAG,MAAM,IAAI,IAAI,kBAAU,EAAE,CAAA;IACtC,MAAM,MAAM,GAAG,kBAAkB,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;IAEtE,IAAI,CAAC,MAAM,CAAC,MAAM;QAAE,OAAO,KAAK,CAAA;IAEhC,OAAO,IAAA,gCAAiB,EAAC,KAAK,EAAE,GAAG,EAAE,MAAM,CAAC,CAAA;AAC9C,CAAC,CAAA;AAED;;;;GAIG;AACU,QAAA,kBAAkB,GAAiB;IAC9C,IAAI,EAAE,2BAAY,CAAC,IAAI;IACvB,IAAI;IACJ,WAAW;IACX,OAAO;IACP,IAAI;IACJ,GAAG;CACJ,CAAA"}
+{"version":3,"file":"noUndeclaredMacros.js","sourceRoot":"","sources":["../../../src/rules/file/noUndeclaredMacros.ts"],"names":[],"mappings":";;;AAAA,uCAAoD;AAEpD,2DAAuD;AACvD,mDAA+C;AAC/C,2DAA6E;AAC7E,iEAAwE;AACxE,yDAAqD;AACrD,qDAAkD;AAElD,MAAM,IAAI,GAAG,oBAAoB,CAAA;AACjC,MAAM,WAAW,GAAG,sDAAsD,CAAA;AAC1E,MAAM,OAAO,GAAG,mIAAmI,CAAA;AAEnJ;;;;;;;;;;;;;;GAcG;AACH,MAAM,kBAAkB,GAAG,CAAC,KAAa,EAAE,MAAkB,EAAe,EAAE;IAC5E,IAAI,CAAC,KAAK;QAAE,OAAO,EAAE,CAAA;IAErB,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAA;IAElC,IAAA,yBAAW,EAAC,KAAK,EAAE,MAAM,CAAC,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;QAC3C,IAAI,KAAK,CAAC,IAAI;YAAE,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC,CAAA;IACxD,CAAC,CAAC,CAAA;IAEF,IAAA,8BAAe,EAAC,KAAK,EAAE,MAAM,CAAC,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;QAC/C,QAAQ,CAAC,GAAG,CAAC,KAAK,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC,CAAA;IACxC,CAAC,CAAC,CAAA;IAEF,MAAM,OAAO,GAAG,IAAI,GAAG,CACrB,MAAM,CAAC,aAAa,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC,CAChE,CAAA;IAED,MAAM,UAAU,GAAgB,EAAE,CAAA;IAClC,MAAM,IAAI,GAAG,IAAI,GAAG,EAAU,CAAA;IAE9B,IAAA,iCAAe,EAAC,KAAK,EAAE,MAAM,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;QAC9C,MAAM,GAAG,GAAG,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,CAAA;QACnC,IAAI,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC;YAAE,OAAM;QACzB,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC,CAAA;QAEb,IAAI,IAAA,sBAAU,EAAC,IAAI,CAAC,IAAI,CAAC;YAAE,OAAM;QACjC,IAAI,OAAO,CAAC,GAAG,CAAC,GAAG,CAAC;YAAE,OAAM;QAC5B,IAAI,QAAQ,CAAC,GAAG,CAAC,GAAG,CAAC;YAAE,OAAM;QAE7B,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;IACvB,CAAC,CAAC,CAAA;IAEF,OAAO,UAAU,CAAA;AACnB,CAAC,CAAA;AAED,MAAM,IAAI,GAAG,CAAC,KAAa,EAAE,MAAmB,EAAgB,EAAE;IAChE,MAAM,GAAG,GAAG,MAAM,IAAI,IAAI,kBAAU,EAAE,CAAA;IACtC,MAAM,QAAQ,GAAG,GAAG,CAAC,aAAa,CAAC,IAAI,CAAC,IAAI,mBAAQ,CAAC,OAAO,CAAA;IAE5D,OAAO,kBAAkB,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,CAAC;QACnD,OAAO,EAAE,OAAO,CAAC,OAAO,CAAC,SAAS,EAAE,IAAI,CAAC,IAAI,CAAC;QAC9C,UAAU,EAAE,IAAI,CAAC,UAAU;QAC3B,iBAAiB,EAAE,IAAI,CAAC,iBAAiB;QACzC,eAAe,EAAE,IAAI,CAAC,eAAe;QACrC,QAAQ;KACT,CAAC,CAAC,CAAA;AACL,CAAC,CAAA;AAED,MAAM,GAAG,GAAG,CAAC,KAAa,EAAE,MAAmB,EAAU,EAAE;IACzD,MAAM,GAAG,GAAG,MAAM,IAAI,IAAI,kBAAU,EAAE,CAAA;IACtC,MAAM,MAAM,GAAG,kBAAkB,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;IAEtE,IAAI,CAAC,MAAM,CAAC,MAAM;QAAE,OAAO,KAAK,CAAA;IAEhC,OAAO,IAAA,gCAAiB,EAAC,KAAK,EAAE,GAAG,EAAE,MAAM,CAAC,CAAA;AAC9C,CAAC,CAAA;AAED;;;;GAIG;AACU,QAAA,kBAAkB,GAAiB;IAC9C,IAAI,EAAE,2BAAY,CAAC,IAAI;IACvB,IAAI;IACJ,WAAW;IACX,OAAO;IACP,IAAI;IACJ,GAAG;CACJ,CAAA"}

package/rules/file/noUnusedMacros.js

@@ -13,16 +13,20 @@ const message = `Macro '{macro}' is declared in the <h4> SAS Macros </h4> sectio
  * Collects the macros declared in the `<h4> SAS Macros </h4>` section that the
  * file itself never invokes. A macro that appears more than once is reported
  * once, at its first entry.
+ *
+ * The scan includes the argument of `%str` / `%nrstr`, because that text is
+ * usually unquoted by its caller and the invocation runs: the guard idiom
+ * `%mp_abort(iftrue=%str(%mf_existds(work.x)=1))` resolves `%mf_existds` when
+ * `%mp_abort` evaluates the condition. Counting it as unused would report a
+ * declaration the file depends on - and the formatter would then delete it.
  */
 const getUnusedMacros = (value, config) => {
     if (!value)
         return [];
-    const used = new Set((0, parseMacroCalls_1.parseMacroCalls)(value, config).map((call) => call.name.toLowerCase()));
+    const used = new Set((0, parseMacroCalls_1.parseMacroCalls)(value, config, { includeMasked: true }).map((call) => call.name.toLowerCase()));
     const unused = [];
     const reported = new Set();
-    (0, headerMacros_1.getHeaderMacros)(value, config)
-        .filter((macro) => macro.section === 'sasMacros')
-        .forEach((macro) => {
+    (0, headerMacros_1.getHeaderMacros)(value, config).forEach((macro) => {
         const key = macro.name.toLowerCase();
         if (reported.has(key))
             return;
@@ -47,9 +51,13 @@ const test = (value, config) => {
 const fix = (value, config) => {
     const cfg = config || new types_1.LintConfig();
     const macros = getUnusedMacros(value, cfg).map((macro) => macro.name);
-    if (!macros.length)
-        return value;
-    return (0, headerMacros_1.removeMacrosFromHeader)(value, cfg, macros);
+    const removed = macros.length
+        ? (0, headerMacros_1.removeMacrosFromHeader)(value, cfg, macros)
+        : value;
+    // The list is normalised even when nothing is removed: a mistyped `@li` tag
+    // or a stray indentation is read as a declaration, so no diagnostic points
+    // at it and no other pass would repair it.
+    return (0, headerMacros_1.repairHeaderList)(removed, cfg);
 };
 /**
  * Lint rule that reports macros declared in the `<h4> SAS Macros </h4>` section

package/rules/file/noUnusedMacros.js.map

@@ -1 +1 @@
-{"version":3,"file":"noUnusedMacros.js","sourceRoot":"","sources":["../../../src/rules/file/noUnusedMacros.ts"],"names":[],"mappings":";;;AAAA,uCAAoD;AAEpD,2DAAuD;AACvD,mDAA+C;AAC/C,2DAIiC;AACjC,iEAA6D;AAE7D,MAAM,IAAI,GAAG,gBAAgB,CAAA;AAC7B,MAAM,WAAW,GACf,yFAAyF,CAAA;AAC3F,MAAM,OAAO,GAAG,2FAA2F,CAAA;AAE3G;;;;GAIG;AACH,MAAM,eAAe,GAAG,CAAC,KAAa,EAAE,MAAkB,EAAiB,EAAE;IAC3E,IAAI,CAAC,KAAK;QAAE,OAAO,EAAE,CAAA;IAErB,MAAM,IAAI,GAAG,IAAI,GAAG,CAClB,IAAA,iCAAe,EAAC,KAAK,EAAE,MAAM,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CAAC,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC,CACtE,CAAA;IAED,MAAM,MAAM,GAAkB,EAAE,CAAA;IAChC,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAA;IAElC,IAAA,8BAAe,EAAC,KAAK,EAAE,MAAM,CAAC;SAC3B,MAAM,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,OAAO,KAAK,WAAW,CAAC;SAChD,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;QACjB,MAAM,GAAG,GAAG,KAAK,CAAC,IAAI,CAAC,WAAW,EAAE,CAAA;QACpC,IAAI,QAAQ,CAAC,GAAG,CAAC,GAAG,CAAC;YAAE,OAAM;QAC7B,QAAQ,CAAC,GAAG,CAAC,GAAG,CAAC,CAAA;QACjB,IAAI,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC;YAAE,OAAM;QAEzB,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;IACpB,CAAC,CAAC,CAAA;IAEJ,OAAO,MAAM,CAAA;AACf,CAAC,CAAA;AAED,MAAM,IAAI,GAAG,CAAC,KAAa,EAAE,MAAmB,EAAgB,EAAE;IAChE,MAAM,GAAG,GAAG,MAAM,IAAI,IAAI,kBAAU,EAAE,CAAA;IACtC,MAAM,QAAQ,GAAG,GAAG,CAAC,aAAa,CAAC,IAAI,CAAC,IAAI,mBAAQ,CAAC,OAAO,CAAA;IAE5D,OAAO,eAAe,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC;QACjD,OAAO,EAAE,OAAO,CAAC,OAAO,CAAC,SAAS,EAAE,KAAK,CAAC,IAAI,CAAC;QAC/C,UAAU,EAAE,KAAK,CAAC,UAAU;QAC5B,iBAAiB,EAAE,KAAK,CAAC,iBAAiB;QAC1C,eAAe,EAAE,KAAK,CAAC,eAAe;QACtC,QAAQ;KACT,CAAC,CAAC,CAAA;AACL,CAAC,CAAA;AAED,MAAM,GAAG,GAAG,CAAC,KAAa,EAAE,MAAmB,EAAU,EAAE;IACzD,MAAM,GAAG,GAAG,MAAM,IAAI,IAAI,kBAAU,EAAE,CAAA;IACtC,MAAM,MAAM,GAAG,eAAe,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAA;IAErE,IAAI,CAAC,MAAM,CAAC,MAAM;QAAE,OAAO,KAAK,CAAA;IAEhC,OAAO,IAAA,qCAAsB,EAAC,KAAK,EAAE,GAAG,EAAE,MAAM,CAAC,CAAA;AACnD,CAAC,CAAA;AAED;;;;GAIG;AACU,QAAA,cAAc,GAAiB;IAC1C,IAAI,EAAE,2BAAY,CAAC,IAAI;IACvB,IAAI;IACJ,WAAW;IACX,OAAO;IACP,IAAI;IACJ,GAAG;CACJ,CAAA"}
+{"version":3,"file":"noUnusedMacros.js","sourceRoot":"","sources":["../../../src/rules/file/noUnusedMacros.ts"],"names":[],"mappings":";;;AAAA,uCAAoD;AAEpD,2DAAuD;AACvD,mDAA+C;AAC/C,2DAKiC;AACjC,iEAA6D;AAE7D,MAAM,IAAI,GAAG,gBAAgB,CAAA;AAC7B,MAAM,WAAW,GACf,yFAAyF,CAAA;AAC3F,MAAM,OAAO,GAAG,2FAA2F,CAAA;AAE3G;;;;;;;;;;GAUG;AACH,MAAM,eAAe,GAAG,CAAC,KAAa,EAAE,MAAkB,EAAiB,EAAE;IAC3E,IAAI,CAAC,KAAK;QAAE,OAAO,EAAE,CAAA;IAErB,MAAM,IAAI,GAAG,IAAI,GAAG,CAClB,IAAA,iCAAe,EAAC,KAAK,EAAE,MAAM,EAAE,EAAE,aAAa,EAAE,IAAI,EAAE,CAAC,CAAC,GAAG,CAAC,CAAC,IAAI,EAAE,EAAE,CACnE,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,CACxB,CACF,CAAA;IAED,MAAM,MAAM,GAAkB,EAAE,CAAA;IAChC,MAAM,QAAQ,GAAG,IAAI,GAAG,EAAU,CAAA;IAElC,IAAA,8BAAe,EAAC,KAAK,EAAE,MAAM,CAAC,CAAC,OAAO,CAAC,CAAC,KAAK,EAAE,EAAE;QAC/C,MAAM,GAAG,GAAG,KAAK,CAAC,IAAI,CAAC,WAAW,EAAE,CAAA;QACpC,IAAI,QAAQ,CAAC,GAAG,CAAC,GAAG,CAAC;YAAE,OAAM;QAC7B,QAAQ,CAAC,GAAG,CAAC,GAAG,CAAC,CAAA;QACjB,IAAI,IAAI,CAAC,GAAG,CAAC,GAAG,CAAC;YAAE,OAAM;QAEzB,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;IACpB,CAAC,CAAC,CAAA;IAEF,OAAO,MAAM,CAAA;AACf,CAAC,CAAA;AAED,MAAM,IAAI,GAAG,CAAC,KAAa,EAAE,MAAmB,EAAgB,EAAE;IAChE,MAAM,GAAG,GAAG,MAAM,IAAI,IAAI,kBAAU,EAAE,CAAA;IACtC,MAAM,QAAQ,GAAG,GAAG,CAAC,aAAa,CAAC,IAAI,CAAC,IAAI,mBAAQ,CAAC,OAAO,CAAA;IAE5D,OAAO,eAAe,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC;QACjD,OAAO,EAAE,OAAO,CAAC,OAAO,CAAC,SAAS,EAAE,KAAK,CAAC,IAAI,CAAC;QAC/C,UAAU,EAAE,KAAK,CAAC,UAAU;QAC5B,iBAAiB,EAAE,KAAK,CAAC,iBAAiB;QAC1C,eAAe,EAAE,KAAK,CAAC,eAAe;QACtC,QAAQ;KACT,CAAC,CAAC,CAAA;AACL,CAAC,CAAA;AAED,MAAM,GAAG,GAAG,CAAC,KAAa,EAAE,MAAmB,EAAU,EAAE;IACzD,MAAM,GAAG,GAAG,MAAM,IAAI,IAAI,kBAAU,EAAE,CAAA;IACtC,MAAM,MAAM,GAAG,eAAe,CAAC,KAAK,EAAE,GAAG,CAAC,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,IAAI,CAAC,CAAA;IAErE,MAAM,OAAO,GAAG,MAAM,CAAC,MAAM;QAC3B,CAAC,CAAC,IAAA,qCAAsB,EAAC,KAAK,EAAE,GAAG,EAAE,MAAM,CAAC;QAC5C,CAAC,CAAC,KAAK,CAAA;IAET,4EAA4E;IAC5E,2EAA2E;IAC3E,2CAA2C;IAC3C,OAAO,IAAA,+BAAgB,EAAC,OAAO,EAAE,GAAG,CAAC,CAAA;AACvC,CAAC,CAAA;AAED;;;;GAIG;AACU,QAAA,cAAc,GAAiB;IAC1C,IAAI,EAAE,2BAAY,CAAC,IAAI;IACvB,IAAI;IACJ,WAAW;IACX,OAAO;IACP,IAAI;IACJ,GAAG;CACJ,CAAA"}

package/sasjslint-schema.json

@@ -207,7 +207,7 @@
       "$id": "#/properties/noUndeclaredMacros",
       "type": "boolean",
       "title": "noUndeclaredMacros",
-      "description": "Reports a warning for each macro a file invokes without declaring it in the `<h4> SAS Macros </h4>` or `<h4> Other Macros </h4>` section of the header. Macros that ship with SAS are always considered declared, and so are the macros listed in `ignoredMacros` (`webout` by default). The formatter resolves the warning by adding the macro names to the header, sorted alphabetically.",
+      "description": "Reports a warning for each macro a file invokes without declaring it in the `<h4> SAS Macros </h4>` section of the header - the only header list `sasjs compile` reads. Macros that ship with SAS are always considered declared, and so are the macros listed in `ignoredMacros` (`webout` by default). The formatter resolves the warning by adding the macro names to the header, sorted alphabetically.",
       "default": true,
       "examples": [true, false]
     },