@sasjs/lint 4.1.0 → 4.1.2

package/.github/workflows/publish.yml

@@ -79,6 +79,25 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}   # <-- app token, not secrets.GITHUB_TOKEN
 
+      # semantic-release only releases when it finds a releasable commit, and the
+      # angular convention this repo is configured with does not treat `chore:` or
+      # `docs:` as one. This step ran on `if: success()` regardless, so a merge with
+      # no releasable commit published the version already in package.json, which
+      # npm rejects with "You cannot publish over the previously published
+      # versions". Compare against the registry instead, and publish only when
+      # there is something new.
       - name: Publish to npm with trusted publisher
+        id: publish
         if: success()
-        run: npm publish --access public
+        run: |
+          local_version=$(node -p "require('./package.json').version")
+          published_version=$(npm view @sasjs/lint version 2>/dev/null || echo "")
+
+          if [ "$local_version" = "$published_version" ]; then
+            echo "released=false" >> "$GITHUB_OUTPUT"
+            echo "Nothing to publish - $local_version is already on npm"
+            exit 0
+          fi
+
+          npm publish --access public
+          echo "released=true" >> "$GITHUB_OUTPUT"

package/checkNodeVersion.js

@@ -1,9 +1,23 @@
 const result = process.versions
+
+// Mirrors engines.node. @sasjs/utils pulls in consola 3, which declares
+// ^14.18.0 || >=16.10.0, so a major-only floor would admit versions whose own
+// dependencies reject them - 14.0-14.17 and all of 15.x.
+const satisfiesNode = (version) => {
+  const [major, minor] = version.split('.').map(Number)
+
+  if (major === 14) return minor >= 18
+  if (major === 15) return false
+  if (major === 16) return minor >= 10
+
+  return major > 16
+}
+
 if (result && result.node) {
-  if (parseInt(result.node) < 14) {
+  if (!satisfiesNode(result.node)) {
     console.log(
       '\x1b[31m%s\x1b[0m',
-      `❌ Process failed due to Node Version,\nPlease install and use Node Version >= 14\nYour current Node Version is: ${result.node}`
+      `❌ Process failed due to Node Version,\nPlease install and use Node Version ^14.18.0 || >=16.10.0\nYour current Node Version is: ${result.node}`
     )
     process.exit(1)
   }

package/package.json

@@ -1,17 +1,18 @@
 {
   "name": "@sasjs/lint",
   "description": "Linting and formatting for SAS code",
+  "engines": {
+    "node": "^14.18.0 || >=16.10.0"
+  },
   "scripts": {
     "test": "jest --coverage",
     "build": "rimraf build && tsc",
     "generate:macros": "node ./scripts/generate-macro-names.mjs",
-    "preinstall": "node checkNodeVersion",
     "prebuild": "node checkNodeVersion",
     "publishInit": "cp -r ./build/* . && rm -rf ./build && rm -rf ./src && rm tsconfig.json",
     "package:lib": "npm run build && cp ./package.json ./checkNodeVersion.js build && cp README.md build && cd build && npm version \"5.0.0\" && npm pack",
     "lint:fix": "npx prettier --write \"{src,test}/**/*.{ts,tsx,js,jsx,html,css,sass,less,json,yml,md,graphql}\"",
-    "lint": "npx prettier --check \"{src,test}/**/*.{ts,tsx,js,jsx,html,css,sass,less,json,yml,md,graphql}\"",
-    "prepare": "git rev-parse --git-dir && git config core.hooksPath ./.git-hooks || true"
+    "lint": "npx prettier --check \"{src,test}/**/*.{ts,tsx,js,jsx,html,css,sass,less,json,yml,md,graphql}\""
   },
   "publishConfig": {
     "access": "public"
@@ -69,8 +70,8 @@
     "typescript": "6.0.3"
   },
   "dependencies": {
-    "@sasjs/utils": "3.6.2",
+    "@sasjs/utils": "3.6.4",
     "ignore": "7.0.11"
   },
-  "version": "4.1.0"
+  "version": "4.1.2"
 }