@sascha384/tic 2.1.0 → 3.0.0

package/dist/backends/ado/index.js

@@ -1,26 +1,49 @@
 import { execFileSync } from 'node:child_process';
 import { BaseBackend, UnsupportedOperationError } from '../types.js';
-import { az, azExec, azInvoke, azRest, azExecSync, azInvokeSync, } from './az.js';
+import { getAdoToken, getAdoPat, authenticateAdo } from '../../auth/ado.js';
+import { AuthError } from '../shared/api-client.js';
+import { AdoApiClient } from './api.js';
 import { parseAdoRemote } from './remote.js';
 import { mapWorkItemToWorkItem, mapCommentToComment, mapPriorityToAdo, formatTags, extractParent, extractPredecessors, } from './mappers.js';
 export class AzureDevOpsBackend extends BaseBackend {
-    cwd;
+    api;
     org;
     project;
     types;
-    constructor(cwd) {
+    constructor(api, org, project, types) {
         super(60_000);
-        this.cwd = cwd;
-        azExecSync(['account', 'show'], cwd);
+        this.api = api;
+        this.org = org;
+        this.project = project;
+        this.types = types;
+    }
+    static async create(cwd, options) {
         const remote = parseAdoRemote(cwd);
-        this.org = remote.org;
-        this.project = remote.project;
-        this.types = azInvokeSync({
-            area: 'wit',
-            resource: 'workitemtypes',
-            routeParameters: `project=${this.project}`,
-            apiVersion: '7.1',
-        }, cwd).value;
+        let auth = null;
+        const token = getAdoToken();
+        const pat = getAdoPat();
+        if (token) {
+            auth = { type: 'bearer', token };
+        }
+        else if (pat) {
+            auth = { type: 'basic', pat };
+        }
+        if (!auth) {
+            if (options?.skipAuth) {
+                throw new AuthError('Azure DevOps authentication required. Run "tic auth login azure" to authenticate.');
+            }
+            const accessToken = await authenticateAdo({
+                onCode: (code, url) => {
+                    console.log(`\nAzure DevOps authentication required.`);
+                    console.log(`Visit ${url} and enter code: ${code}\n`);
+                },
+            });
+            auth = { type: 'bearer', token: accessToken };
+        }
+        const api = new AdoApiClient(auth, remote.org);
+        // Fetch work item types to verify auth and cache type metadata
+        const typesResult = await api.rest('GET', `/${remote.project}/_apis/wit/workitemtypes`);
+        return new AzureDevOpsBackend(api, remote.org, remote.project, typesResult.value);
     }
     getCapabilities() {
         return {
@@ -66,18 +89,8 @@ export class AzureDevOpsBackend extends BaseBackend {
     }
     async getAssignees() {
         try {
-            const members = await az([
-                'devops',
-                'team',
-                'list-members',
-                '--team',
-                `${this.project} Team`,
-                '--org',
-                `https://dev.azure.com/${this.org}`,
-                '--project',
-                this.project,
-            ], this.cwd);
-            return members.map((m) => m.identity.displayName);
+            const result = await this.api.rest('GET', `/_apis/projects/${encodeURIComponent(this.project)}/teams/${encodeURIComponent(this.project + ' Team')}/members`);
+            return result.value.map((m) => m.identity.displayName);
         }
         catch {
             return [];
@@ -87,36 +100,12 @@ export class AzureDevOpsBackend extends BaseBackend {
         return this.getLabelsFromCache();
     }
     async getIterations() {
-        const iterations = await az([
-            'boards',
-            'iteration',
-            'team',
-            'list',
-            '--team',
-            `${this.project} Team`,
-            '--org',
-            `https://dev.azure.com/${this.org}`,
-            '--project',
-            this.project,
-        ], this.cwd);
-        return iterations.map((i) => i.path);
+        const result = await this.api.rest('GET', `/${encodeURIComponent(this.project)}/${encodeURIComponent(this.project + ' Team')}/_apis/work/teamsettings/iterations`);
+        return result.value.map((i) => i.path);
     }
     async getCurrentIteration() {
-        const iterations = await az([
-            'boards',
-            'iteration',
-            'team',
-            'list',
-            '--team',
-            `${this.project} Team`,
-            '--timeframe',
-            'current',
-            '--org',
-            `https://dev.azure.com/${this.org}`,
-            '--project',
-            this.project,
-        ], this.cwd);
-        return iterations[0]?.path ?? '';
+        const result = await this.api.rest('GET', `/${encodeURIComponent(this.project)}/${encodeURIComponent(this.project + ' Team')}/_apis/work/teamsettings/iterations?$timeframe=current`);
+        return result.value[0]?.path ?? '';
     }
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     async setCurrentIteration(_name) {
@@ -126,37 +115,16 @@ export class AzureDevOpsBackend extends BaseBackend {
         return value.replace(/'/g, "''");
     }
     async batchFetchWorkItems(ids) {
-        const CHUNK_SIZE = 200;
-        const items = [];
-        for (let i = 0; i < ids.length; i += CHUNK_SIZE) {
-            const chunk = ids.slice(i, i + CHUNK_SIZE);
-            const batchResult = await azInvoke({
-                area: 'wit',
-                resource: 'workitemsbatch',
-                httpMethod: 'POST',
-                body: { ids: chunk, $expand: 4 },
-                apiVersion: '7.1',
-            }, this.cwd);
-            items.push(...batchResult.value.map(mapWorkItemToWorkItem));
-        }
-        return items;
+        const result = await this.api.batchGetWorkItems(ids);
+        return result.value.map(mapWorkItemToWorkItem);
     }
     async listWorkItems(iteration) {
         let wiql = `SELECT [System.Id] FROM WorkItems WHERE [System.TeamProject] = '${this.escapeWiql(this.project)}'`;
         if (iteration) {
             wiql += ` AND [System.IterationPath] = '${this.escapeWiql(iteration)}'`;
         }
-        const queryResult = await az([
-            'boards',
-            'query',
-            '--wiql',
-            wiql,
-            '--org',
-            `https://dev.azure.com/${this.org}`,
-            '--project',
-            this.project,
-        ], this.cwd);
-        const ids = queryResult.map((w) => w.id);
+        const queryResult = await this.api.wiql(this.project, wiql);
+        const ids = queryResult.workItems.map((w) => w.id);
         if (ids.length === 0)
             return [];
         const items = await this.batchFetchWorkItems(ids);
@@ -164,25 +132,11 @@ export class AzureDevOpsBackend extends BaseBackend {
         return items;
     }
     async getWorkItem(id) {
-        // Fetch work item and comments in parallel.
-        // Comments use `az rest` which requires AAD auth (`az login`).
-        // If only PAT auth is available (`az devops login`), comments
-        // gracefully degrade to an empty array.
         const [ado, commentResult] = await Promise.all([
-            az([
-                'boards',
-                'work-item',
-                'show',
-                '--id',
-                id,
-                '--expand',
-                'relations',
-                '--org',
-                `https://dev.azure.com/${this.org}`,
-            ], this.cwd),
-            azRest({
-                url: `https://dev.azure.com/${this.org}/${encodeURIComponent(this.project)}/_apis/wit/workItems/${id}/comments?api-version=7.1-preview.4`,
-            }, this.cwd).catch(() => ({ comments: [] })),
+            this.api.rest('GET', `/${encodeURIComponent(this.project)}/_apis/wit/workitems/${id}?$expand=relations`),
+            this.api
+                .rest('GET', `/${encodeURIComponent(this.project)}/_apis/wit/workItems/${id}/comments?api-version=7.1-preview.4`)
+                .catch(() => ({ comments: [] })),
         ]);
         const item = mapWorkItemToWorkItem(ado);
         item.comments = (commentResult.comments ?? []).map(mapCommentToComment);
@@ -190,268 +144,182 @@ export class AzureDevOpsBackend extends BaseBackend {
     }
     async createWorkItem(data) {
         this.validateFields(data);
-        const args = [
-            'boards',
-            'work-item',
-            'create',
-            '--type',
-            data.type,
-            '--title',
-            data.title,
-            '--org',
-            `https://dev.azure.com/${this.org}`,
-            '--project',
-            this.project,
+        const patch = [
+            { op: 'add', path: '/fields/System.Title', value: data.title },
         ];
-        const fields = [];
         if (data.status)
-            fields.push(`System.State=${data.status}`);
+            patch.push({
+                op: 'add',
+                path: '/fields/System.State',
+                value: data.status,
+            });
         if (data.iteration)
-            fields.push(`System.IterationPath=${data.iteration}`);
+            patch.push({
+                op: 'add',
+                path: '/fields/System.IterationPath',
+                value: data.iteration,
+            });
         if (data.priority)
-            fields.push(`Microsoft.VSTS.Common.Priority=${mapPriorityToAdo(data.priority)}`);
+            patch.push({
+                op: 'add',
+                path: '/fields/Microsoft.VSTS.Common.Priority',
+                value: mapPriorityToAdo(data.priority),
+            });
         if (data.assignee)
-            fields.push(`System.AssignedTo=${data.assignee}`);
+            patch.push({
+                op: 'add',
+                path: '/fields/System.AssignedTo',
+                value: data.assignee,
+            });
         if (data.labels.length > 0)
-            fields.push(`System.Tags=${formatTags(data.labels)}`);
+            patch.push({
+                op: 'add',
+                path: '/fields/System.Tags',
+                value: formatTags(data.labels),
+            });
         if (data.description)
-            fields.push(`System.Description=${data.description}`);
-        for (const field of fields) {
-            args.push('--fields', field);
+            patch.push({
+                op: 'add',
+                path: '/fields/System.Description',
+                value: data.description,
+            });
+        // Add parent relation in same request
+        if (data.parent) {
+            patch.push({
+                op: 'add',
+                path: '/relations/-',
+                value: {
+                    rel: 'System.LinkTypes.Hierarchy-Reverse',
+                    url: `https://dev.azure.com/${this.org}/_apis/wit/workitems/${data.parent}`,
+                },
+            });
         }
-        const created = await az(args, this.cwd);
-        const createdId = String(created.id);
-        // Add parent and dependency relations
-        if (data.parent || data.dependsOn.length > 0) {
-            try {
-                if (data.parent) {
-                    await azExec([
-                        'boards',
-                        'work-item',
-                        'relation',
-                        'add',
-                        '--id',
-                        createdId,
-                        '--relation-type',
-                        'System.LinkTypes.Hierarchy-Reverse',
-                        '--target-id',
-                        data.parent,
-                        '--org',
-                        `https://dev.azure.com/${this.org}`,
-                    ], this.cwd);
-                }
-                for (const depId of data.dependsOn) {
-                    await azExec([
-                        'boards',
-                        'work-item',
-                        'relation',
-                        'add',
-                        '--id',
-                        createdId,
-                        '--relation-type',
-                        'System.LinkTypes.Dependency-Reverse',
-                        '--target-id',
-                        depId,
-                        '--org',
-                        `https://dev.azure.com/${this.org}`,
-                    ], this.cwd);
-                }
-            }
-            catch (err) {
-                try {
-                    await azExec([
-                        'boards',
-                        'work-item',
-                        'delete',
-                        '--id',
-                        createdId,
-                        '--yes',
-                        '--org',
-                        `https://dev.azure.com/${this.org}`,
-                        '--project',
-                        this.project,
-                    ], this.cwd);
-                }
-                catch {
-                    // Best-effort cleanup
-                }
-                throw new Error(`Failed to link relationships for work item #${createdId}; item was rolled back: ${err instanceof Error ? err.message : String(err)}`);
-            }
+        // Add dependency relations in same request
+        for (const depId of data.dependsOn) {
+            patch.push({
+                op: 'add',
+                path: '/relations/-',
+                value: {
+                    rel: 'System.LinkTypes.Dependency-Reverse',
+                    url: `https://dev.azure.com/${this.org}/_apis/wit/workitems/${depId}`,
+                },
+            });
         }
-        return this.getWorkItem(createdId);
+        const created = await this.api.rest('POST', `/${encodeURIComponent(this.project)}/_apis/wit/workitems/$${encodeURIComponent(data.type)}`, patch, 'application/json-patch+json');
+        return this.getWorkItem(String(created.id));
     }
     async updateWorkItem(id, data) {
         this.validateFields(data);
-        const args = [
-            'boards',
-            'work-item',
-            'update',
-            '--id',
-            id,
-            '--org',
-            `https://dev.azure.com/${this.org}`,
-        ];
-        const fields = [];
+        const patch = [];
         if (data.title !== undefined)
-            fields.push(`System.Title=${data.title}`);
+            patch.push({
+                op: 'replace',
+                path: '/fields/System.Title',
+                value: data.title,
+            });
         if (data.status !== undefined)
-            fields.push(`System.State=${data.status}`);
+            patch.push({
+                op: 'replace',
+                path: '/fields/System.State',
+                value: data.status,
+            });
         if (data.iteration !== undefined)
-            fields.push(`System.IterationPath=${data.iteration}`);
+            patch.push({
+                op: 'replace',
+                path: '/fields/System.IterationPath',
+                value: data.iteration,
+            });
         if (data.priority !== undefined)
-            fields.push(`Microsoft.VSTS.Common.Priority=${mapPriorityToAdo(data.priority)}`);
+            patch.push({
+                op: 'replace',
+                path: '/fields/Microsoft.VSTS.Common.Priority',
+                value: mapPriorityToAdo(data.priority),
+            });
         if (data.assignee !== undefined)
-            fields.push(`System.AssignedTo=${data.assignee}`);
+            patch.push({
+                op: 'replace',
+                path: '/fields/System.AssignedTo',
+                value: data.assignee,
+            });
         if (data.labels !== undefined)
-            fields.push(`System.Tags=${formatTags(data.labels)}`);
+            patch.push({
+                op: 'replace',
+                path: '/fields/System.Tags',
+                value: formatTags(data.labels),
+            });
         if (data.description !== undefined)
-            fields.push(`System.Description=${data.description}`);
-        for (const field of fields) {
-            args.push('--fields', field);
-        }
-        if (fields.length > 0) {
-            await az(args, this.cwd);
-        }
-        // Handle parent and dependency relation changes (single fetch)
+            patch.push({
+                op: 'replace',
+                path: '/fields/System.Description',
+                value: data.description,
+            });
+        // Handle relation changes — need to fetch current relations first
         if (data.parent !== undefined || data.dependsOn !== undefined) {
-            const current = await az([
-                'boards',
-                'work-item',
-                'show',
-                '--id',
-                id,
-                '--expand',
-                'relations',
-                '--org',
-                `https://dev.azure.com/${this.org}`,
-            ], this.cwd);
-            try {
-                if (data.parent !== undefined) {
-                    const currentParent = extractParent(current.relations);
-                    if (currentParent && currentParent !== data.parent) {
-                        await azExec([
-                            'boards',
-                            'work-item',
-                            'relation',
-                            'remove',
-                            '--id',
-                            id,
-                            '--relation-type',
-                            'System.LinkTypes.Hierarchy-Reverse',
-                            '--target-id',
-                            currentParent,
-                            '--org',
-                            `https://dev.azure.com/${this.org}`,
-                            '--yes',
-                        ], this.cwd);
-                    }
-                    if (data.parent && data.parent !== currentParent) {
-                        await azExec([
-                            'boards',
-                            'work-item',
-                            'relation',
-                            'add',
-                            '--id',
-                            id,
-                            '--relation-type',
-                            'System.LinkTypes.Hierarchy-Reverse',
-                            '--target-id',
-                            data.parent,
-                            '--org',
-                            `https://dev.azure.com/${this.org}`,
-                        ], this.cwd);
+            const current = await this.api.rest('GET', `/${encodeURIComponent(this.project)}/_apis/wit/workitems/${id}?$expand=relations`);
+            if (data.parent !== undefined) {
+                const currentParent = extractParent(current.relations);
+                if (currentParent && currentParent !== data.parent) {
+                    // Find the index of the parent relation to remove it
+                    const parentIdx = current.relations?.findIndex((r) => r.rel === 'System.LinkTypes.Hierarchy-Reverse');
+                    if (parentIdx !== undefined && parentIdx >= 0) {
+                        patch.push({
+                            op: 'remove',
+                            path: `/relations/${parentIdx}`,
+                        });
                     }
                 }
-                if (data.dependsOn !== undefined) {
-                    const currentDeps = new Set(extractPredecessors(current.relations));
-                    const newDeps = new Set(data.dependsOn);
-                    // Remove deps that are no longer in the list
-                    for (const dep of currentDeps) {
-                        if (!newDeps.has(dep)) {
-                            await azExec([
-                                'boards',
-                                'work-item',
-                                'relation',
-                                'remove',
-                                '--id',
-                                id,
-                                '--relation-type',
-                                'System.LinkTypes.Dependency-Reverse',
-                                '--target-id',
-                                dep,
-                                '--org',
-                                `https://dev.azure.com/${this.org}`,
-                                '--yes',
-                            ], this.cwd);
+                if (data.parent && data.parent !== currentParent) {
+                    patch.push({
+                        op: 'add',
+                        path: '/relations/-',
+                        value: {
+                            rel: 'System.LinkTypes.Hierarchy-Reverse',
+                            url: `https://dev.azure.com/${this.org}/_apis/wit/workitems/${data.parent}`,
+                        },
+                    });
+                }
+            }
+            if (data.dependsOn !== undefined) {
+                const currentDeps = new Set(extractPredecessors(current.relations));
+                const newDeps = new Set(data.dependsOn);
+                // Remove deps no longer in the list (iterate in reverse to preserve indices)
+                const removeIndices = [];
+                current.relations?.forEach((r, i) => {
+                    if (r.rel === 'System.LinkTypes.Dependency-Reverse') {
+                        const depId = r.url.match(/\/workitems\/(\d+)$/i)?.[1];
+                        if (depId && !newDeps.has(depId)) {
+                            removeIndices.push(i);
                         }
                     }
-                    // Add deps that are new
-                    for (const dep of newDeps) {
-                        if (!currentDeps.has(dep)) {
-                            await azExec([
-                                'boards',
-                                'work-item',
-                                'relation',
-                                'add',
-                                '--id',
-                                id,
-                                '--relation-type',
-                                'System.LinkTypes.Dependency-Reverse',
-                                '--target-id',
-                                dep,
-                                '--org',
-                                `https://dev.azure.com/${this.org}`,
-                            ], this.cwd);
-                        }
+                });
+                for (const idx of removeIndices.reverse()) {
+                    patch.push({ op: 'remove', path: `/relations/${idx}` });
+                }
+                // Add new deps
+                for (const dep of newDeps) {
+                    if (!currentDeps.has(dep)) {
+                        patch.push({
+                            op: 'add',
+                            path: '/relations/-',
+                            value: {
+                                rel: 'System.LinkTypes.Dependency-Reverse',
+                                url: `https://dev.azure.com/${this.org}/_apis/wit/workitems/${dep}`,
+                            },
+                        });
                     }
                 }
             }
-            catch (err) {
-                throw new Error(`Failed to update relationships for work item #${id}: ${err instanceof Error ? err.message : String(err)}`);
-            }
+        }
+        if (patch.length > 0) {
+            await this.api.rest('PATCH', `/_apis/wit/workitems/${id}`, patch, 'application/json-patch+json');
         }
         return this.getWorkItem(id);
     }
     async deleteWorkItem(id) {
-        await azExec([
-            'boards',
-            'work-item',
-            'delete',
-            '--id',
-            id,
-            '--yes',
-            '--org',
-            `https://dev.azure.com/${this.org}`,
-            '--project',
-            this.project,
-        ], this.cwd);
+        await this.api.rest('DELETE', `/_apis/wit/workitems/${id}`);
     }
-    /**
-     * Add a comment to a work item.
-     *
-     * The Work Item Comments API is preview-only (7.1-preview.4) and cannot be
-     * called via `az devops invoke` (it fails to parse preview version strings),
-     * so we use `az rest` instead. Unlike `az devops` commands which honor PAT
-     * auth from `az devops login`, `az rest --resource` requires an Azure AD
-     * token obtained via `az login`. If only PAT auth is available, this method
-     * throws a descriptive error directing the user to run `az login`.
-     */
     async addComment(workItemId, comment) {
-        try {
-            await azRest({
-                url: `https://dev.azure.com/${this.org}/${encodeURIComponent(this.project)}/_apis/wit/workItems/${workItemId}/comments?api-version=7.1-preview.4`,
-                httpMethod: 'POST',
-                body: { text: comment.body },
-            }, this.cwd);
-        }
-        catch (err) {
-            const msg = err instanceof Error ? err.message : String(err);
-            if (msg.includes('not been materialized') ||
-                msg.includes('not allowed')) {
-                throw new Error('Adding comments requires Azure AD authentication. Run `az login` in addition to `az devops login`.');
-            }
-            throw err;
-        }
+        await this.api.rest('POST', `/${encodeURIComponent(this.project)}/_apis/wit/workItems/${workItemId}/comments?api-version=7.1-preview.4`, { text: comment.body });
         return {
             author: comment.author,
             date: new Date().toISOString(),
@@ -463,18 +331,10 @@ export class AzureDevOpsBackend extends BaseBackend {
         if (isNaN(numericId))
             throw new Error(`Invalid work item ID: "${id}"`);
         const wiql = `SELECT [System.Id] FROM WorkItemLinks WHERE [Source].[System.Id] = ${numericId} AND [System.Links.LinkType] = 'System.LinkTypes.Hierarchy-Forward' MODE (MustContain)`;
-        const queryResult = await az([
-            'boards',
-            'query',
-            '--wiql',
-            wiql,
-            '--org',
-            `https://dev.azure.com/${this.org}`,
-            '--project',
-            this.project,
-        ], this.cwd);
-        // Filter out the source item (link queries include it)
-        const ids = queryResult.map((w) => w.id).filter((wid) => wid !== numericId);
+        const queryResult = await this.api.wiql(this.project, wiql);
+        const ids = queryResult.workItemRelations
+            .map((r) => r.target.id)
+            .filter((wid) => wid !== numericId);
         if (ids.length === 0)
             return [];
         return this.batchFetchWorkItems(ids);
@@ -484,18 +344,10 @@ export class AzureDevOpsBackend extends BaseBackend {
         if (isNaN(numericId))
             throw new Error(`Invalid work item ID: "${id}"`);
         const wiql = `SELECT [System.Id] FROM WorkItemLinks WHERE [Source].[System.Id] = ${numericId} AND [System.Links.LinkType] = 'System.LinkTypes.Dependency-Forward' MODE (MustContain)`;
-        const queryResult = await az([
-            'boards',
-            'query',
-            '--wiql',
-            wiql,
-            '--org',
-            `https://dev.azure.com/${this.org}`,
-            '--project',
-            this.project,
-        ], this.cwd);
-        // Filter out the source item (link queries include it)
-        const ids = queryResult.map((w) => w.id).filter((wid) => wid !== numericId);
+        const queryResult = await this.api.wiql(this.project, wiql);
+        const ids = queryResult.workItemRelations
+            .map((r) => r.target.id)
+            .filter((wid) => wid !== numericId);
         if (ids.length === 0)
             return [];
         return this.batchFetchWorkItems(ids);