@sarj/eslint-plugin 4.2.0 → 5.0.0

package/dist/index.d.cts

@@ -86,8 +86,10 @@ interface RuleOptions$2 {
  *     "allow": ["[\\\\/]lib[\\\\/]api[\\\\/]", "-gateway\\\\.ts$"]
  *   }]
  *
- * Supplying `allow` REPLACES the defaults, so include the test patterns if you
- * still want test files exempt.
+ * Supplying `allow` REPLACES the default CLIENT-LAYER patterns. Test files are
+ * no longer part of that list — they are recognised unconditionally by the
+ * shared `isTestFile` predicate — so a repo that overrides `allow` keeps its
+ * test tree exempt without having to remember the test patterns.
  *
  * CORPUS SWEEP (2220 files, zod / TanStack Query / react-router / swr /
  * zustand, 2026-07): 96 raw hits. The defaults missed three path conventions
@@ -103,6 +105,44 @@ interface RuleOptions$2 {
  *   - `__testfixtures__/` — 8 hits from jscodeshift fixtures such as
  *     `query/packages/query-codemods/src/v5/remove-overloads/__testfixtures__/bug-reports.input.tsx`,
  *     which are input/output text for a codemod, not code that runs.
+ *
+ * SECOND SWEEP (25,508 deduped TS/TSX files across zod / trpc / dub /
+ * openstatus / formbricks / documenso / unkey / midday / papermark / cal.com /
+ * hono plus six first-party repos, 2026-07): 1,019 hits, 50 read in a seeded
+ * random sample — 24 true positives, 21 false positives, 5 arguable. At a 42%
+ * false-positive rate this was the loudest rule of the five audited, and the
+ * cause was the same one the first sweep found, just further along: the reports
+ * were landing ON the client layer, under names the `allow` list did not know.
+ *
+ *   - **Vendor wrapper modules** — 147 findings. `*Service.ts`, `services/`,
+ *     `connectors/` (16), `providers/` (12), `integrations/` (16),
+ *     `notifications/<vendor>/` (29), `adapters/`, `*-fetcher.ts`. Every fetch
+ *     in them is an absolute-URL call to ONE third-party origin — they ARE the
+ *     module the rule wants the fetch to live in. Citable:
+ *     `cal.com/packages/app-store/office365calendar/lib/CalendarService.ts:265`,
+ *     `openstatus/packages/notifications/telegram/src/index.ts:81`,
+ *     `formbricks/apps/web/lib/googleSheet/service.ts:164`.
+ *     Recall cost: 0 of the 50 sampled true positives lived in such a path —
+ *     every one was a `.tsx` component/page/modal or a React hook.
+ *   - **Test-path drift** — 36 findings. The rule hand-rolled its own test-path
+ *     list instead of using the shared `isTestFile`, so it missed `playwright/`
+ *     (19) and the `.e2e.ts` basename. The single loudest file corpus-wide was
+ *     `cal.com/apps/web/playwright/oauth-provider.e2e.ts` (16 findings). The
+ *     sibling rule `require-fetch-timeout` had always used `isTestFile`; this
+ *     was pure drift between two rules that see the same call sites.
+ *   - **Asset / passthrough handoff** — see `isConstructedArgumentHandoff`.
+ *
+ * DELIBERATELY NOT GUARDED: restricting the rule to component/hook files. It
+ * would cut the residual false-positive rate from ~25% to ~4%, but costs ~80
+ * real positives in `.ts` background jobs (e.g.
+ * `papermark/lib/trigger/convert-pdf-direct.ts:332`).
+ *
+ * DELIBERATELY NOT ALLOWED: a `-provider.*` BASENAME, even though the
+ * `providers/` DIRECTORY is. In the corpus that basename is usually a React
+ * context or modal provider calling the app's own API —
+ * `dub/apps/web/ui/modals/modal-provider.tsx:134` is exactly the true-positive
+ * shape — and the two vendor files that carry it are already covered by
+ * `integrations/`.
  */
 
 interface RuleOptions$1 {
@@ -197,9 +237,6 @@ interface LoggingOptions {
 }
 
 declare const rules: {
-    "ban-loose-type-guards-in-tests": _typescript_eslint_utils_ts_eslint.RuleModule<"banLooseTypeGuardsInTests", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
-        name: string;
-    };
     "enforce-file-structure": _typescript_eslint_utils_ts_eslint.RuleModule<"importsFirst" | "useServerDirective", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
         name: string;
     };
@@ -358,19 +395,15 @@ declare const rules: {
     "require-interface-for-injected-service": _typescript_eslint_utils_ts_eslint.RuleModule<"requireInterface", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
         name: string;
     };
-    "strict-test-assertions": _typescript_eslint_utils_ts_eslint.RuleModule<"combineAssertions", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
-    "prefer-non-nullable-collection": _typescript_eslint_utils_ts_eslint.RuleModule<"preferNonNullableCollection", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
+    "strict-test-assertions": _typescript_eslint_utils_ts_eslint.RuleModule<"combineAssertions" | "assertArrayOnce", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
         name: string;
     };
-    "no-implicit-attribute-access": _typescript_eslint_utils_ts_eslint.RuleModule<"noImplicitAttributeAccess", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
+    "prefer-non-nullable-collection": _typescript_eslint_utils_ts_eslint.RuleModule<"preferNonNullableCollection", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
         name: string;
     };
     "no-async-callback-in-waitfor": _typescript_eslint_utils_ts_eslint.RuleModule<"noAsyncCallbackInWaitFor", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
         name: string;
     };
-    "prefer-setup-file-mocks": _typescript_eslint_utils_ts_eslint.RuleModule<"preferSetupFileMocks", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
-        name: string;
-    };
 };
 declare const plugin: {
     meta: {
@@ -378,9 +411,6 @@ declare const plugin: {
         version: string;
     };
     rules: {
-        "ban-loose-type-guards-in-tests": _typescript_eslint_utils_ts_eslint.RuleModule<"banLooseTypeGuardsInTests", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
-            name: string;
-        };
         "enforce-file-structure": _typescript_eslint_utils_ts_eslint.RuleModule<"importsFirst" | "useServerDirective", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
             name: string;
         };
@@ -539,19 +569,15 @@ declare const plugin: {
         "require-interface-for-injected-service": _typescript_eslint_utils_ts_eslint.RuleModule<"requireInterface", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
             name: string;
         };
-        "strict-test-assertions": _typescript_eslint_utils_ts_eslint.RuleModule<"combineAssertions", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
-        "prefer-non-nullable-collection": _typescript_eslint_utils_ts_eslint.RuleModule<"preferNonNullableCollection", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
+        "strict-test-assertions": _typescript_eslint_utils_ts_eslint.RuleModule<"combineAssertions" | "assertArrayOnce", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
             name: string;
         };
-        "no-implicit-attribute-access": _typescript_eslint_utils_ts_eslint.RuleModule<"noImplicitAttributeAccess", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
+        "prefer-non-nullable-collection": _typescript_eslint_utils_ts_eslint.RuleModule<"preferNonNullableCollection", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
             name: string;
         };
         "no-async-callback-in-waitfor": _typescript_eslint_utils_ts_eslint.RuleModule<"noAsyncCallbackInWaitFor", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
             name: string;
         };
-        "prefer-setup-file-mocks": _typescript_eslint_utils_ts_eslint.RuleModule<"preferSetupFileMocks", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
-            name: string;
-        };
     };
     configs: {
         recommended: {
@@ -560,7 +586,6 @@ declare const plugin: {
                 "@sarj/zod-naming-convention": string;
                 "@sarj/require-assert-never": string;
                 "@sarj/require-zod-form-validation": string;
-                "@sarj/ban-loose-type-guards-in-tests": string;
                 "@sarj/enforce-file-structure": string;
                 "@sarj/no-client-side-data-fetching": string;
                 "@sarj/prefer-server-actions": string;
@@ -603,9 +628,7 @@ declare const plugin: {
                 "@sarj/no-tautological-expect": string;
                 "@sarj/require-interface-for-injected-service": string;
                 "@sarj/prefer-non-nullable-collection": string;
-                "@sarj/no-implicit-attribute-access": string;
                 "@sarj/no-async-callback-in-waitfor": string;
-                "@sarj/prefer-setup-file-mocks": string;
             };
         };
         strict: {
@@ -614,7 +637,6 @@ declare const plugin: {
                 "@sarj/zod-naming-convention": string;
                 "@sarj/require-assert-never": string;
                 "@sarj/require-zod-form-validation": string;
-                "@sarj/ban-loose-type-guards-in-tests": string;
                 "@sarj/enforce-file-structure": string;
                 "@sarj/no-raw-env": string;
                 "@sarj/no-enum": string;
@@ -661,9 +683,7 @@ declare const plugin: {
                 "@sarj/no-tautological-expect": string;
                 "@sarj/require-interface-for-injected-service": string;
                 "@sarj/prefer-non-nullable-collection": string;
-                "@sarj/no-implicit-attribute-access": string;
                 "@sarj/no-async-callback-in-waitfor": string;
-                "@sarj/prefer-setup-file-mocks": string;
             };
         };
     };

package/dist/index.d.ts

@@ -86,8 +86,10 @@ interface RuleOptions$2 {
  *     "allow": ["[\\\\/]lib[\\\\/]api[\\\\/]", "-gateway\\\\.ts$"]
  *   }]
  *
- * Supplying `allow` REPLACES the defaults, so include the test patterns if you
- * still want test files exempt.
+ * Supplying `allow` REPLACES the default CLIENT-LAYER patterns. Test files are
+ * no longer part of that list — they are recognised unconditionally by the
+ * shared `isTestFile` predicate — so a repo that overrides `allow` keeps its
+ * test tree exempt without having to remember the test patterns.
  *
  * CORPUS SWEEP (2220 files, zod / TanStack Query / react-router / swr /
  * zustand, 2026-07): 96 raw hits. The defaults missed three path conventions
@@ -103,6 +105,44 @@ interface RuleOptions$2 {
  *   - `__testfixtures__/` — 8 hits from jscodeshift fixtures such as
  *     `query/packages/query-codemods/src/v5/remove-overloads/__testfixtures__/bug-reports.input.tsx`,
  *     which are input/output text for a codemod, not code that runs.
+ *
+ * SECOND SWEEP (25,508 deduped TS/TSX files across zod / trpc / dub /
+ * openstatus / formbricks / documenso / unkey / midday / papermark / cal.com /
+ * hono plus six first-party repos, 2026-07): 1,019 hits, 50 read in a seeded
+ * random sample — 24 true positives, 21 false positives, 5 arguable. At a 42%
+ * false-positive rate this was the loudest rule of the five audited, and the
+ * cause was the same one the first sweep found, just further along: the reports
+ * were landing ON the client layer, under names the `allow` list did not know.
+ *
+ *   - **Vendor wrapper modules** — 147 findings. `*Service.ts`, `services/`,
+ *     `connectors/` (16), `providers/` (12), `integrations/` (16),
+ *     `notifications/<vendor>/` (29), `adapters/`, `*-fetcher.ts`. Every fetch
+ *     in them is an absolute-URL call to ONE third-party origin — they ARE the
+ *     module the rule wants the fetch to live in. Citable:
+ *     `cal.com/packages/app-store/office365calendar/lib/CalendarService.ts:265`,
+ *     `openstatus/packages/notifications/telegram/src/index.ts:81`,
+ *     `formbricks/apps/web/lib/googleSheet/service.ts:164`.
+ *     Recall cost: 0 of the 50 sampled true positives lived in such a path —
+ *     every one was a `.tsx` component/page/modal or a React hook.
+ *   - **Test-path drift** — 36 findings. The rule hand-rolled its own test-path
+ *     list instead of using the shared `isTestFile`, so it missed `playwright/`
+ *     (19) and the `.e2e.ts` basename. The single loudest file corpus-wide was
+ *     `cal.com/apps/web/playwright/oauth-provider.e2e.ts` (16 findings). The
+ *     sibling rule `require-fetch-timeout` had always used `isTestFile`; this
+ *     was pure drift between two rules that see the same call sites.
+ *   - **Asset / passthrough handoff** — see `isConstructedArgumentHandoff`.
+ *
+ * DELIBERATELY NOT GUARDED: restricting the rule to component/hook files. It
+ * would cut the residual false-positive rate from ~25% to ~4%, but costs ~80
+ * real positives in `.ts` background jobs (e.g.
+ * `papermark/lib/trigger/convert-pdf-direct.ts:332`).
+ *
+ * DELIBERATELY NOT ALLOWED: a `-provider.*` BASENAME, even though the
+ * `providers/` DIRECTORY is. In the corpus that basename is usually a React
+ * context or modal provider calling the app's own API —
+ * `dub/apps/web/ui/modals/modal-provider.tsx:134` is exactly the true-positive
+ * shape — and the two vendor files that carry it are already covered by
+ * `integrations/`.
  */
 
 interface RuleOptions$1 {
@@ -197,9 +237,6 @@ interface LoggingOptions {
 }
 
 declare const rules: {
-    "ban-loose-type-guards-in-tests": _typescript_eslint_utils_ts_eslint.RuleModule<"banLooseTypeGuardsInTests", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
-        name: string;
-    };
     "enforce-file-structure": _typescript_eslint_utils_ts_eslint.RuleModule<"importsFirst" | "useServerDirective", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
         name: string;
     };
@@ -358,19 +395,15 @@ declare const rules: {
     "require-interface-for-injected-service": _typescript_eslint_utils_ts_eslint.RuleModule<"requireInterface", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
         name: string;
     };
-    "strict-test-assertions": _typescript_eslint_utils_ts_eslint.RuleModule<"combineAssertions", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
-    "prefer-non-nullable-collection": _typescript_eslint_utils_ts_eslint.RuleModule<"preferNonNullableCollection", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
+    "strict-test-assertions": _typescript_eslint_utils_ts_eslint.RuleModule<"combineAssertions" | "assertArrayOnce", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
         name: string;
     };
-    "no-implicit-attribute-access": _typescript_eslint_utils_ts_eslint.RuleModule<"noImplicitAttributeAccess", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
+    "prefer-non-nullable-collection": _typescript_eslint_utils_ts_eslint.RuleModule<"preferNonNullableCollection", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
         name: string;
     };
     "no-async-callback-in-waitfor": _typescript_eslint_utils_ts_eslint.RuleModule<"noAsyncCallbackInWaitFor", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
         name: string;
     };
-    "prefer-setup-file-mocks": _typescript_eslint_utils_ts_eslint.RuleModule<"preferSetupFileMocks", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
-        name: string;
-    };
 };
 declare const plugin: {
     meta: {
@@ -378,9 +411,6 @@ declare const plugin: {
         version: string;
     };
     rules: {
-        "ban-loose-type-guards-in-tests": _typescript_eslint_utils_ts_eslint.RuleModule<"banLooseTypeGuardsInTests", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
-            name: string;
-        };
         "enforce-file-structure": _typescript_eslint_utils_ts_eslint.RuleModule<"importsFirst" | "useServerDirective", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
             name: string;
         };
@@ -539,19 +569,15 @@ declare const plugin: {
         "require-interface-for-injected-service": _typescript_eslint_utils_ts_eslint.RuleModule<"requireInterface", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
             name: string;
         };
-        "strict-test-assertions": _typescript_eslint_utils_ts_eslint.RuleModule<"combineAssertions", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
-        "prefer-non-nullable-collection": _typescript_eslint_utils_ts_eslint.RuleModule<"preferNonNullableCollection", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
+        "strict-test-assertions": _typescript_eslint_utils_ts_eslint.RuleModule<"combineAssertions" | "assertArrayOnce", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
             name: string;
         };
-        "no-implicit-attribute-access": _typescript_eslint_utils_ts_eslint.RuleModule<"noImplicitAttributeAccess", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
+        "prefer-non-nullable-collection": _typescript_eslint_utils_ts_eslint.RuleModule<"preferNonNullableCollection", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
             name: string;
         };
         "no-async-callback-in-waitfor": _typescript_eslint_utils_ts_eslint.RuleModule<"noAsyncCallbackInWaitFor", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
             name: string;
         };
-        "prefer-setup-file-mocks": _typescript_eslint_utils_ts_eslint.RuleModule<"preferSetupFileMocks", readonly [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener> & {
-            name: string;
-        };
     };
     configs: {
         recommended: {
@@ -560,7 +586,6 @@ declare const plugin: {
                 "@sarj/zod-naming-convention": string;
                 "@sarj/require-assert-never": string;
                 "@sarj/require-zod-form-validation": string;
-                "@sarj/ban-loose-type-guards-in-tests": string;
                 "@sarj/enforce-file-structure": string;
                 "@sarj/no-client-side-data-fetching": string;
                 "@sarj/prefer-server-actions": string;
@@ -603,9 +628,7 @@ declare const plugin: {
                 "@sarj/no-tautological-expect": string;
                 "@sarj/require-interface-for-injected-service": string;
                 "@sarj/prefer-non-nullable-collection": string;
-                "@sarj/no-implicit-attribute-access": string;
                 "@sarj/no-async-callback-in-waitfor": string;
-                "@sarj/prefer-setup-file-mocks": string;
             };
         };
         strict: {
@@ -614,7 +637,6 @@ declare const plugin: {
                 "@sarj/zod-naming-convention": string;
                 "@sarj/require-assert-never": string;
                 "@sarj/require-zod-form-validation": string;
-                "@sarj/ban-loose-type-guards-in-tests": string;
                 "@sarj/enforce-file-structure": string;
                 "@sarj/no-raw-env": string;
                 "@sarj/no-enum": string;
@@ -661,9 +683,7 @@ declare const plugin: {
                 "@sarj/no-tautological-expect": string;
                 "@sarj/require-interface-for-injected-service": string;
                 "@sarj/prefer-non-nullable-collection": string;
-                "@sarj/no-implicit-attribute-access": string;
                 "@sarj/no-async-callback-in-waitfor": string;
-                "@sarj/prefer-setup-file-mocks": string;
             };
         };
     };