@sarj/eslint-plugin 2.4.0 → 2.4.1

package/dist/index.cjs

@@ -37,7 +37,6 @@ module.exports = __toCommonJS(index_exports);
 
 // src/rules/enforce-file-structure.ts
 var import_utils = require("@typescript-eslint/utils");
-var SERVER_ACTION_FILE_RE = /(?:^|\/)actions\/|\.action\.[jt]sx?$|(?:^|\/)actions\.[jt]sx?$/;
 var classifyStatement = (statement) => {
   switch (statement.type) {
     case import_utils.AST_NODE_TYPES.ImportDeclaration:
@@ -52,7 +51,6 @@ var classifyStatement = (statement) => {
 };
 var isStringDirective = (statement) => statement.type === import_utils.AST_NODE_TYPES.ExpressionStatement && statement.expression.type === import_utils.AST_NODE_TYPES.Literal && typeof statement.expression.value === "string" && statement.expression.value.startsWith("use ");
 var isUseServerDirective = (statement) => {
-  if (statement === void 0) return false;
   if (statement.type !== import_utils.AST_NODE_TYPES.ExpressionStatement) return false;
   const expr = statement.expression;
   if (expr.type !== import_utils.AST_NODE_TYPES.Literal) return false;
@@ -65,23 +63,25 @@ var enforce_file_structure_default = import_utils.ESLintUtils.RuleCreator(
   meta: {
     type: "suggestion",
     docs: {
-      description: "Require `import` statements to come first, then allow step-down ordering (public API first, private helpers below) for the rest of the file. Exported statements are classified by WHAT they export \u2014 an exported interface is a declaration, an exported function is a function \u2014 so a public exported function followed by a private helper, or an exported interface among declarations, is allowed. Re-exports (`export { \u2026 } from`, `export *`, `export { \u2026 }`) are a neutral group, so generated namespace barrels pass. Server-action files (under `/actions/`, named `*.action.ts`, or `actions.ts`) must also begin with a `use server` directive."
+      description: "Require `import` statements to come first, then allow step-down ordering (public API first, private helpers below) for the rest of the file. Exported statements are classified by WHAT they export \u2014 an exported interface is a declaration, an exported function is a function \u2014 so a public exported function followed by a private helper, or an exported interface among declarations, is allowed. Re-exports (`export { \u2026 } from`, `export *`, `export { \u2026 }`) are a neutral group, so generated namespace barrels pass. When a module contains a `use server` directive, it must be the first statement in the file."
     },
     schema: [],
     messages: {
       importsFirst: "File structure violation: import statements must come before other declarations",
-      useServerDirective: "Server action files must start with 'use server' directive"
+      useServerDirective: "A 'use server' directive must be the first statement in the file"
     }
   },
   defaultOptions: [],
   create(context) {
-    const isServerAction = SERVER_ACTION_FILE_RE.test(context.filename);
     return {
       Program(node) {
         const body = node.body;
-        if (isServerAction && !isUseServerDirective(body[0])) {
+        const misplacedUseServer = body.find(
+          (statement, index) => index > 0 && isUseServerDirective(statement)
+        );
+        if (misplacedUseServer !== void 0) {
           context.report({
-            node,
+            node: misplacedUseServer,
             messageId: "useServerDirective"
           });
         }
@@ -663,12 +663,49 @@ function instanceofErrorSubject(test) {
   }
   return null;
 }
+var TYPE_GUARD_PATTERN = /^(is|has)[A-Z]/;
+function typeGuardSubject(test) {
+  const arg = test.type === "CallExpression" ? test.arguments[0] : void 0;
+  if (test.type === "CallExpression" && test.callee.type === "Identifier" && TYPE_GUARD_PATTERN.test(test.callee.name) && test.arguments.length === 1 && arg !== void 0 && arg.type !== "SpreadElement") {
+    return arg;
+  }
+  return null;
+}
+function positiveErrorSubject(test) {
+  return instanceofErrorSubject(test) ?? typeGuardSubject(test);
+}
 function negatedInstanceofErrorSubject(test) {
   if (test.type === "UnaryExpression" && test.operator === "!") {
-    return instanceofErrorSubject(test.argument);
+    return positiveErrorSubject(test.argument);
   }
   return null;
 }
+function branchTerminates(branch) {
+  const body = branch.type === "BlockStatement" ? branch.body : [branch];
+  const last = body[body.length - 1];
+  return last !== void 0 && (last.type === "ReturnStatement" || last.type === "ThrowStatement");
+}
+function isNarrowedByEarlyReturn(node, argExpr, sourceCode) {
+  const argText = sourceCode.getText(argExpr);
+  let current = node.parent;
+  while (current) {
+    if (current.type === "BlockStatement" || current.type === "Program") {
+      for (const stmt of current.body) {
+        if (stmt.range[0] >= node.range[0]) {
+          break;
+        }
+        if (stmt.type === "IfStatement" && stmt.alternate === null && branchTerminates(stmt.consequent)) {
+          const subject = positiveErrorSubject(stmt.test);
+          if (subject && sourceCode.getText(subject) === argText) {
+            return true;
+          }
+        }
+      }
+    }
+    current = current.parent;
+  }
+  return false;
+}
 function nodeWithin(node, container) {
   return container !== null && node.range[0] >= container.range[0] && node.range[1] <= container.range[1];
 }
@@ -678,7 +715,7 @@ function isGuardedByInstanceofError(node, argExpr, sourceCode) {
   let current = node.parent;
   while (current) {
     if (current.type === "ConditionalExpression") {
-      const subject = instanceofErrorSubject(current.test);
+      const subject = positiveErrorSubject(current.test);
       if (subject && sameSubject(subject) && nodeWithin(node, current.alternate)) {
         return true;
       }
@@ -687,7 +724,7 @@ function isGuardedByInstanceofError(node, argExpr, sourceCode) {
         return true;
       }
     } else if (current.type === "IfStatement") {
-      const subject = instanceofErrorSubject(current.test);
+      const subject = positiveErrorSubject(current.test);
       if (subject && sameSubject(subject) && nodeWithin(node, current.alternate)) {
         return true;
       }
@@ -740,7 +777,7 @@ var no_json_stringify_error_default = import_utils6.ESLintUtils.RuleCreator(
         if (!suggestsError) {
           return;
         }
-        if (isGuardedByInstanceofError(node, firstArg, context.sourceCode)) {
+        if (isGuardedByInstanceofError(node, firstArg, context.sourceCode) || isNarrowedByEarlyReturn(node, firstArg, context.sourceCode)) {
           return;
         }
         context.report({
@@ -883,6 +920,17 @@ function isProcessEnv(node) {
 function isImportMetaEnv(node) {
   return !node.computed && node.property.type === "Identifier" && node.property.name === "env" && node.object.type === "MetaProperty" && node.object.meta.name === "import" && node.object.property.name === "meta";
 }
+var BUILD_TIME_CONSTANTS = /* @__PURE__ */ new Set([
+  "NODE_ENV",
+  "MODE",
+  "DEV",
+  "PROD",
+  "SSR"
+]);
+function isBuildTimeConstantAccess(node) {
+  const parent = node.parent;
+  return parent.type === "MemberExpression" && parent.object === node && !parent.computed && parent.property.type === "Identifier" && BUILD_TIME_CONSTANTS.has(parent.property.name);
+}
 var no_raw_env_default = import_utils9.ESLintUtils.RuleCreator(
   (name) => `https://github.com/sarj-ai/linting/blob/main/packages/typescript/src/rules/${name}.ts`
 )({
@@ -901,7 +949,7 @@ var no_raw_env_default = import_utils9.ESLintUtils.RuleCreator(
   create(context) {
     return {
       MemberExpression(node) {
-        if (isProcessEnv(node) || isImportMetaEnv(node)) {
+        if ((isProcessEnv(node) || isImportMetaEnv(node)) && !isBuildTimeConstantAccess(node)) {
           context.report({
             node,
             messageId: "noRawEnv"
@@ -1137,7 +1185,7 @@ var no_sentinel_return_on_catch_default = import_utils10.ESLintUtils.RuleCreator
 // src/rules/no-sequential-await.ts
 var import_utils11 = require("@typescript-eslint/utils");
 var ARRAY_ITERATION_METHODS = /* @__PURE__ */ new Set(["forEach", "map", "filter"]);
-var SEQUENTIAL_ITERABLE_HINT = /sort|reverse|ordered|sequence|hook|middleware|pipeline|\bstage|\bstep|\bphase|migration|chain/i;
+var SEQUENTIAL_ITERABLE_HINT = /sort|reverse|ordered|sequence|hook|middleware|pipeline|\bstage|\bstep|\bphase|migration|chain|buffer|stream|teleport|chunk|\bqueue|drain/i;
 function isFunctionLike(node) {
   return node.type === "FunctionDeclaration" || node.type === "FunctionExpression" || node.type === "ArrowFunctionExpression";
 }
@@ -1180,9 +1228,29 @@ function hasEarlyExit(root) {
   });
   return found;
 }
+var TIMER_HELPER_RE = /^(sleep|timeout|delay|wait|pause|tick)$/i;
+function calleeName2(callee) {
+  if (callee.type === "Identifier") return callee.name;
+  if (callee.type === "MemberExpression" && !callee.computed && callee.property.type === "Identifier") {
+    return callee.property.name;
+  }
+  return null;
+}
 function isTimerYield(node) {
   const arg = node.argument;
-  return arg.type === "NewExpression" && arg.callee.type === "Identifier" && arg.callee.name === "Promise";
+  if (arg.type === "NewExpression" && arg.callee.type === "Identifier" && arg.callee.name === "Promise") {
+    return true;
+  }
+  if (arg.type === "CallExpression") {
+    const name = calleeName2(arg.callee);
+    return name !== null && TIMER_HELPER_RE.test(name);
+  }
+  return false;
+}
+var QUEUE_DRAIN_METHODS = /^(shift|pop|dequeue|next|poll)$/;
+function isQueueDrain(node) {
+  const arg = node.argument;
+  return arg.type === "CallExpression" && arg.callee.type === "MemberExpression" && !arg.callee.computed && arg.callee.property.type === "Identifier" && QUEUE_DRAIN_METHODS.test(arg.callee.property.name);
 }
 function referencesName(root, name) {
   let found = false;
@@ -1217,7 +1285,7 @@ function shouldReport(awaits, earlyExit, iterableText) {
     return false;
   }
   return awaits.some(
-    (node) => !isTimerYield(node) && !isThreadedAccumulator(node)
+    (node) => !isTimerYield(node) && !isThreadedAccumulator(node) && !isQueueDrain(node)
   );
 }
 var no_sequential_await_default = import_utils11.ESLintUtils.RuleCreator(
@@ -1238,10 +1306,10 @@ var no_sequential_await_default = import_utils11.ESLintUtils.RuleCreator(
   create(context) {
     function loopParts(node) {
       if (node.type === "ForStatement") {
-        return [node.body, node.init, node.test, node.update];
+        return [node.body, node.test, node.update];
       }
       if (node.type === "ForOfStatement" || node.type === "ForInStatement") {
-        return [node.body, node.right];
+        return [node.body];
       }
       return [node.body, node.test];
     }
@@ -1897,10 +1965,10 @@ var SVG_EXEMPT_COLOR_VALUES = /* @__PURE__ */ new Set([
   "currentcolor",
   "inherit"
 ]);
-var isInsideSvgDefsContainer = (node) => {
+var isInsideSvg = (node) => {
   let current = node.parent;
   while (current !== void 0 && current !== null) {
-    if (current.type === import_utils17.AST_NODE_TYPES.JSXElement && current.openingElement.name.type === import_utils17.AST_NODE_TYPES.JSXIdentifier && SVG_DEFS_CONTAINERS.has(current.openingElement.name.name)) {
+    if (current.type === import_utils17.AST_NODE_TYPES.JSXElement && current.openingElement.name.type === import_utils17.AST_NODE_TYPES.JSXIdentifier && (current.openingElement.name.name === "svg" || SVG_DEFS_CONTAINERS.has(current.openingElement.name.name))) {
       return true;
     }
     current = current.parent;
@@ -2010,7 +2078,7 @@ var prefer_semantic_colors_default = import_utils17.ESLintUtils.RuleCreator(
         if (typeof node.value.value === "string" && SVG_EXEMPT_COLOR_VALUES.has(node.value.value.toLowerCase())) {
           return;
         }
-        if (isInsideSvgDefsContainer(node)) return;
+        if (isInsideSvg(node)) return;
         checkColorValueNode(node.value);
       },
       // Inline style objects: style={{ color: "#111827", backgroundColor: "#fff" }}
@@ -2538,7 +2606,7 @@ function propertyKeyName(prop) {
   }
   return void 0;
 }
-function calleeName2(node) {
+function calleeName3(node) {
   const callee = node.callee;
   if (callee.type === "Identifier") {
     return callee.name;
@@ -2549,7 +2617,7 @@ function calleeName2(node) {
   return void 0;
 }
 function isCorsWildcardCredentialsCall(node) {
-  const name = calleeName2(node);
+  const name = calleeName3(node);
   if (name === void 0 || name.toLowerCase() !== "cors") {
     return false;
   }
@@ -3664,7 +3732,7 @@ var rules = {
 var plugin = {
   meta: {
     name: "@sarj/eslint-plugin",
-    version: "2.4.0"
+    version: "2.4.1"
   },
   rules,
   configs: {