@sapui5/sap.ushell_abap 1.140.0 → 1.141.1

package/src/main/js/sap/ushell_abap/components/TCodeNavigation.js

@@ -4,147 +4,160 @@ sap.ui.define([
     "sap/ushell/Container",
     "sap/base/Log",
     "sap/ushell/api/performance/Extension",
-    // navigation sources
-    "sap/ushell/api/performance/NavigationSource"
-], (Container, Log, Extension, NavigationSource) => {
+    "sap/ushell/api/performance/NavigationSource",
+    "sap/ushell_abap/components/TCodeNavigation/TCodeNavigationError",
+    "sap/ushell_abap/components/TCodeNavigation/MessageCode"
+], (
+    Container,
+    Log,
+    Extension,
+    NavigationSource,
+    TCodeNavigationError,
+    MessageCode
+) => {
     "use strict";
 
     /**
-     * @typedef {object} sap.ushell_abap.components.TCodeNavigation.NavigationResult
-     *
+     * @alias sap.ushell_abap.components.TCodeNavigation.NavigationResult
+     * @typedef {object}
      * @property {boolean} successful Indicates whether the navigation was successful. //TODO Remove as not needed due to resolved or rejected promise
      * @property {string} messagecode The message code associated with the navigation result.
-     * @private
-     */
-
-    /**
-     * Message codes for navigation results.
-     * @enum {string} sap.ushell_abap.components.TCodeNavigation.MessageCode
-     * @property {string} NAV_SUCCESS Indicates that the navigation was successful.
-     * @property {string} NO_INBOUND_FOUND Indicates that no matching inbound was found for the transaction code or a mandatory parameter is missing.
-     * @property {string} UNKNOWN_ERROR Indicates an unknown error occurred during navigation.
+     *
+     * @since 1.140.0
      * @private
      * @ui5-restricted sap.esh.search.ui
      */
-    const MessageCode = {
-        NAV_SUCCESS: "NAV_SUCCESS",
-        NO_INBOUND_FOUND: "NO_INBOUND_FOUND",
-        UNKNOWN_ERROR: "UNKNOWN_ERROR"
-    };
-
-    // Performance extension for tracking navigation sources
-    const oExtension = new Extension("TCodeNavigation");
-
-    /**
-     * Finds the first inbound that matches the given transaction code and doesn't have mandatory parameters.
-     * @param {object} oNavigationData The navigation data containing inbounds.
-     * @param {string} sTCode The transaction code to match.
-     * @returns {object|null} The matched inbound or null if no match is found.
-     * @private
-     */
-    function _getValidInbound (oNavigationData, sTCode) {
-        if (!oNavigationData?.inbounds) {
-            Log.error("No navigation data found");
-            return null;
-        }
-
-        // Find all inbounds with matching transaction code
-        const aMatchedInbounds = oNavigationData.inbounds.filter((oInbound) =>
-            oInbound.resolutionResult?.appInfo?.["abap.transaction"] === sTCode
-        );
-        if (aMatchedInbounds.length === 0) {
-            return null;
-        }
-
-        // Return the first matched inbound where all mandatory parameters have default values
-        const oValidInbound = aMatchedInbounds.find((oInbound) => {
-            const oParams = oInbound.signature?.parameters;
-            if (!oParams) {
-                return true; // No parameters, consider valid
-            }
-            // All required parameters must have a default value
-            return Object.values(oParams).every((oValue) =>
-                !oValue.required || (oValue.defaultValue && oValue.defaultValue.value)
-            );
-        });
-
-        if (!oValidInbound) {
-            throw Object.assign(
-                new Error(`Mandatory parameter is missing for transaction ${sTCode}`),
-                { code: MessageCode.NO_INBOUND_FOUND }
-            );
-        }
-
-        return oValidInbound;
-    }
 
     /**
      * TCodeNavigation module for navigating by Transaction (TA) Code.
      * @alias sap.ushell_abap.components.TCodeNavigation
      * @namespace
-     * @class
      * @description This module provides functionality to navigate to an application intent based on a transaction code.
      * It checks if the provided transaction code matches any inbound's appInfo parameter `abap.transaction`.
      * If a match is found, it extracts the semantic object, action, and parameters from the inbound
      * and uses the Navigation service to perform the navigation.
-     * @private
-     * @ui5-restricted sap.esh.search.ui  // TODO add technical name of esearch component / team name
+     *
+     * @hideconstructor
+     *
      * @since 1.140.0
-     */
-    class TCodeNavigation {
-    }
-
-    /**
-     * Navigates to an app intent if the given sTCode matches an inbound's appInfo parameter abap.transaction.
-     * If a matching inbound is found, it extracts the semantic object, action, and parameters
-     * and uses the Navigation service to perform the navigation.
-     * @param {string} sTCode The transaction code to search for, can also be an App ID.
-     * @param {boolean} bExplace Indicates whether to open the navigation in a new tab.
-     * @returns {Promise<NavigationResult>} Resolves with a NavigationResult object containing a successful flag and a message code. Otherwise, it rejects with an error.
-     * @throws {Error} E.g., if no matching inbound is found or if a mandatory parameter is missing.
      * @private
-     */
-    TCodeNavigation.navigateByTCode = async (sTCode, bExplace) => {
-        try {
-            const NavDataProvider = await Container.getServiceAsync("NavigationDataProvider");
-            const oNavigationData = await NavDataProvider.getNavigationData();
-
-            const oValidInbound = _getValidInbound(oNavigationData, sTCode);
-
-            if (oValidInbound) {
-                // Extract semantic object, action, and parameters from the matched inbound for navigation
-                const { semanticObject: sSemanticObject, action: sAction } = oValidInbound;
-                const oParams = {};
-                if (bExplace) {
-                    oParams["sap-ushell-navmode"] = "explace";
+     * @ui5-restricted sap.esh.search.ui
+     */ // TODO add technical name of esearch component / team name
+    class TCodeNavigation {
+        // Performance extension for tracking navigation sources
+        static #oExtension = new Extension("TCodeNavigation");
+
+        // Expose MessageCode enum
+        static MessageCode = MessageCode;
+
+        /**
+         * Navigates to an app intent if the given sTCode matches an inbound's appInfo parameter abap.transaction.
+         * If a matching inbound is found, it extracts the semantic object, action, and parameters
+         * and uses the Navigation service to perform the navigation.
+         * @param {string} sTCode The transaction code to search for, can also be an App ID.
+         * @param {boolean} bExplace Indicates whether to open the navigation in a new tab.
+         * @returns {Promise<sap.ushell_abap.components.TCodeNavigation.NavigationResult>}
+         * Resolves with a NavigationResult object containing a successful flag and a message code. Otherwise, it rejects with an error.
+         * @throws {sap.ushell_abap.components.TCodeNavigation.TCodeNavigationError} E.g., if no matching inbound is found or if a mandatory parameter is missing.
+         *
+         * @since 1.140.0
+         * @private
+         * @ui5-restricted sap.esh.search.ui
+         */
+        static async navigateByTCode (sTCode, bExplace) {
+            try {
+                const NavDataProvider = await Container.getServiceAsync("NavigationDataProvider");
+                const oNavigationData = await NavDataProvider.getNavigationData();
+
+                const oValidInbound = this.#getValidInbound(oNavigationData, sTCode);
+
+                if (oValidInbound) {
+                    // Extract semantic object, action, and parameters from the matched inbound for navigation
+                    const { semanticObject: sSemanticObject, action: sAction } = oValidInbound;
+                    const oParams = {};
+                    if (bExplace) {
+                        oParams["sap-ushell-navmode"] = "explace";
+                    }
+
+                    // Log the navigation source for performance tracking
+                    this.#oExtension.addNavigationSource(NavigationSource.SearchDirectLaunch);
+
+                    const oNavService = await Container.getServiceAsync("Navigation");
+                    await oNavService.navigate({
+                        target: {
+                            semanticObject: sSemanticObject,
+                            action: sAction
+                        },
+                        params: oParams
+                    });
+
+                    return {
+                        successful: true,
+                        messagecode: MessageCode.NAV_SUCCESS
+                    };
                 }
+                throw new TCodeNavigationError(
+                    `No matching inbound found for transaction code: ${sTCode}`,
+                    { code: MessageCode.NO_INBOUND_FOUND }
+                );
+            } catch (oError) {
+                Log.error("Error during TCode navigation", oError);
+                const oErrorResult = new TCodeNavigationError(
+                    "Error during TCode navigation.",
+                    {
+                        successful: false,
+                        code: oError.code
+                    }
+                );
+                throw oErrorResult;
+            }
+        }
 
-                // Log the navigation source for performance tracking
-                oExtension.addNavigationSource(NavigationSource.SearchDirectLaunch);
+        /**
+         * Finds the first inbound that matches the given transaction code and doesn't have mandatory parameters.
+         * @param {object} oNavigationData The navigation data containing inbounds.
+         * @param {string} sTCode The transaction code to match.
+         * @returns {object|null} The matched inbound or null if no match is found.
+         *
+         * @since 1.140.0
+         * @private
+         */
+        static #getValidInbound (oNavigationData, sTCode) {
+            if (!oNavigationData?.inbounds) {
+                Log.error("No navigation data found");
+                return null;
+            }
 
-                const oNavService = await Container.getServiceAsync("Navigation");
-                await oNavService.navigate({
-                    target: {
-                        semanticObject: sSemanticObject,
-                        action: sAction
-                    },
-                    params: oParams
-                });
+            // Find all inbounds with matching transaction code
+            const aMatchedInbounds = oNavigationData.inbounds.filter((oInbound) =>
+                oInbound.resolutionResult?.appInfo?.["abap.transaction"] === sTCode
+            );
+            if (aMatchedInbounds.length === 0) {
+                return null;
+            }
 
-                return { successful: true, messagecode: MessageCode.NAV_SUCCESS };
+            // Return the first matched inbound where all mandatory parameters have default values
+            const oValidInbound = aMatchedInbounds.find((oInbound) => {
+                const oParams = oInbound.signature?.parameters;
+                if (!oParams) {
+                    return true; // No parameters, consider valid
+                }
+                // All required parameters must have a default value
+                return Object.values(oParams).every((oValue) =>
+                    !oValue.required || (oValue.defaultValue && oValue.defaultValue.value)
+                );
+            });
+
+            if (!oValidInbound) {
+                throw new TCodeNavigationError(
+                    `Mandatory parameter is missing for transaction ${sTCode}`,
+                    { code: MessageCode.NO_INBOUND_FOUND }
+                );
             }
-            throw Object.assign(
-                new Error(`No matching inbound found for transaction code: ${sTCode}`),
-                { code: MessageCode.NO_INBOUND_FOUND }
-            );
-        } catch (oError) {
-            Log.error("Error during TCode navigation", oError);
-            const oErrorResult = new Error("Error during TCode navigation.");
-            oErrorResult.successful = false;
-            oErrorResult.messagecode = oError.code || MessageCode.UNKNOWN_ERROR;
-            throw oErrorResult;
+
+            return oValidInbound;
         }
-    };
+    }
 
     return TCodeNavigation;
 });

package/src/main/js/sap/ushell_abap/integration/fileshares/AppRuntimeFileShareSupport.js

@@ -37,14 +37,14 @@ sap.ui.define([
     const ACTION = "manage";
     const URL = `/sap/bc/ui2/start_up?so=${SEMANTIC_OBJECT}&action=${ACTION}&systemAliasesFormat=object&formFactor=desktop&shellType=FLP&depth=0`;
 
-    AppRuntimeFileShareSupport.getDataSource = function () {
+    AppRuntimeFileShareSupport.getDataSource = async function () {
         const sSapClient = AppRuntimeFileShareSupport._getClient();
         const sUrl = `${URL}&sap-client=${sSapClient}`;
 
         // reject if sap-client not found to avoid 401 responses
         if (!sSapClient) {
             Log.error("Could not determine sap-client parameter.", null, MODULE_NAME);
-            return Promise.reject(new Error("Could not determine sap-client parameter."));
+            throw new Error("Could not determine sap-client parameter.");
         }
 
         if (!AppRuntimeFileShareSupport._getDataSourcePromise) {
@@ -62,7 +62,7 @@ sap.ui.define([
                 if (oResponse.ok === false) {
                     Log.error("Could not fetch data, request failed",
                         `error: ${oResponse.status}, ${oResponse.statusText},\nurl: ${sUrl}`, MODULE_NAME);
-                    return Promise.reject(oResponse.statusText);
+                    throw new Error(oResponse.statusText);
                 }
                 return oResponse.json();
             }).then((oData) => {
@@ -87,7 +87,7 @@ sap.ui.define([
                     }
                 }
 
-                const sErrorMessage = ["No manifest URL defined:", JSON.stringify(oData)].join(" ");
+                const sErrorMessage = `No manifest URL defined: ${JSON.stringify(oData)}`;
                 Log.error(sErrorMessage, null, MODULE_NAME);
                 throw new Error(sErrorMessage);
             }).then((oManifest) => {

package/src/main/js/sap/ushell_abap/library.js

@@ -11,6 +11,13 @@ sap.ui.define([
 ) => {
     "use strict";
 
+    /**
+     * @namespace sap.ushell_abap.components
+     * @since 1.121.0
+     * @private
+     * @ui5-restricted
+     */
+
     /**
      * SAP library: sap.ushell_abap
      * provides base functions for Fiori launchpad running on SAP NetWeaver ABAP
@@ -23,7 +30,7 @@ sap.ui.define([
     const ushellAbapLib = Library.init({
         name: "sap.ushell_abap",
         apiVersion: 2,
-        version: "1.140.0",
+        version: "1.141.1",
         dependencies: ["sap.ui.core", "sap.m"],
         noLibraryCSS: true,
         extensions: {

package/src/main/js/sap/ushell_abap/pbServices/ui2/Bag.js

@@ -370,18 +370,18 @@ sap.ui.define([
          *
          * @param {function} fnSuccess
          *   no-args success handler
-         * @param {function(string, object=)} [fnError]
+         * @param {function(string, object=)} [fnFailure]
          *   error handler taking an error message and, since version 1.28.6, an
          *   optional object containing the complete error information as delivered
          *   by the ODataService. See fnFailure parameter of {@link sap.ushell_abap.pbServices.ui2.ODataWrapper#onError}
          *   for more details.
-         *   If fnError is not given, the default error handler from the factory's
+         *   If fnFailure is not given, the default error handler from the factory's
          *   page building service is called.
          * @throws Error when called while {@link #save()} or a previous <code>reset()</code> is
          *   running.
          * @since 1.3.0
          */
-        this.reset = function (fnSuccess, fnError) {
+        this.reset = function (fnSuccess, fnFailure) {
             const oParent = getParentMock();
             const oPbs = oFactory.getPageBuildingService();
 
@@ -404,11 +404,11 @@ sap.ui.define([
             errorIfSaveRunning();
             errorIfResetRunning();
             bResetting = true;
-            fnError = fnError || oPbs.getDefaultErrorHandler();
+            fnFailure = fnFailure || oPbs.getDefaultErrorHandler();
 
             if (oAlterEgo.$tmp) {
                 // if bag is not yet persisted do not call delete and read
-                Utils.callHandler(onReadSuccess.bind(null, oAlterEgo), fnError, true);
+                Utils.callHandler(onReadSuccess.bind(null, oAlterEgo), fnFailure, true);
                 return;
             }
 
@@ -425,7 +425,7 @@ sap.ui.define([
                 bResetting = false;
 
                 // NOTE: call error handler with any arguments passed in this wrapper
-                fnError.apply(null, arguments);
+                fnFailure.apply(null, arguments);
             });
         };
 
@@ -483,9 +483,9 @@ sap.ui.define([
          *
          * @param {function} fnSuccess
          *   no-args success handler. Errors thrown in this function will be reported to the page
-         *   building service's default error handler (not to <code>fnError</code> since the signature
+         *   building service's default error handler (not to <code>fnFailure</code> since the signature
          *   does not fit)
-         * @param {function(Object<string, string>, Object<string, object>)} fnError
+         * @param {function(Object<string, string>, Object<string, object>)} fnFailure
          *   error handler taking two maps, each mapping individual property names
          *   to error message and complete error information respectively. Since
          *   version 1.28.6, the second parameter is always returned,
@@ -498,7 +498,7 @@ sap.ui.define([
          *   running.
          * @since 1.3.0
          */
-        this.save = function (fnSuccess, fnError) {
+        this.save = function (fnSuccess, fnFailure) {
             let iNumberOfRequests = 0;
             const oResetPropertyNames = new Utils.Map(); // used as a "hash set"
             const mMessagesByName = {};
@@ -509,7 +509,7 @@ sap.ui.define([
             if (typeof fnSuccess !== "function") {
                 throw new SrvcError("Missing success handler", "sap.ushell_abap.pbServices.ui2.Bag");
             }
-            if (typeof fnError !== "function") {
+            if (typeof fnFailure !== "function") {
                 throw new SrvcError("Missing error handler", "sap.ushell_abap.pbServices.ui2.Bag");
             }
             errorIfSaveRunning();
@@ -577,7 +577,7 @@ sap.ui.define([
                     fnChangeListener(that);
                 }
                 if (Object.keys(mMessagesByName).length > 0) {
-                    fnError(mMessagesByName, mErrorResponseByName);
+                    fnFailure(mMessagesByName, mErrorResponseByName);
                 } else {
                     oAlterEgo.$tmp = false;
                     fnSuccess(); // Note: try/catch done by submitBatchQueue()!

package/src/main/js/sap/ushell_abap/pbServices/ui2/Catalog.js

@@ -262,8 +262,8 @@ sap.ui.define([
                     oAlterEgo = oResult;
                     try {
                         sRemoteBaseUrl = that.getRemoteBaseUrl();
-                    } catch (e) {
-                        couldNotLoadRemoteChips(e.toString());
+                    } catch (oError) {
+                        couldNotLoadRemoteChips(oError.toString());
                         return;
                     }
                     that.getRemoteCatalogService().readChips(sRemoteBaseUrl, oAlterEgo.remoteId, undefined,

package/src/main/js/sap/ushell_abap/pbServices/ui2/Chip.js

@@ -606,12 +606,8 @@ sap.ui.define([
          *
          * @see #isStub()
          */
-        this.getImplementationAsSapui5Async = function (oApi) {
-            try {
-                checkStub();
-            } catch (oError) {
-                return Promise.reject(oError);
-            }
+        this.getImplementationAsSapui5Async = async function (oApi) {
+            checkStub();
 
             return new Promise((resolve, reject) => {
                 sap.ui.require([
@@ -1016,10 +1012,10 @@ sap.ui.define([
             if (typeof vConfigurationUpdates === "string") {
                 try {
                     mConfigurationUpdates = JSON.parse(vConfigurationUpdates);
-                } catch (e) {
+                } catch (oError) {
                     // configuration as a whole is incorrect and will be ignored
                     // Note: toString(true) will also output configuration, thus it is no secret
-                    Log.warning(`${this}: ignoring invalid configuration "${vConfigurationUpdates}"`, null, "Chip");
+                    Log.warning(`${this}: ignoring invalid configuration "${vConfigurationUpdates}"`, oError, "Chip");
                     return;
                 }
             } else {

package/src/main/js/sap/ushell_abap/pbServices/ui2/ChipInstance.js

@@ -485,12 +485,8 @@ sap.ui.define([
          *
          * @see #isStub()
          */
-        this.getImplementationAsSapui5Async = function () {
-            try {
-                checkStub();
-            } catch (oError) {
-                return Promise.reject(oError);
-            }
+        this.getImplementationAsSapui5Async = async function () {
+            checkStub();
 
             return oChip.getImplementationAsSapui5Async(oApi);
         };
@@ -759,8 +755,8 @@ sap.ui.define([
                 try {
                     fnRefreshHandler(); // Note: "this" is undefined
                     return true;
-                } catch (ex) {
-                    Log.error(`${that}: call to refresh handler failed: ${ex.message || ex.toString()}`, null, "ChipInstance");
+                } catch (oError) {
+                    Log.error(`${that.getId()}: call to refresh handler failed:`, oError, "ChipInstance");
                     return false;
                 }
             }

package/src/main/js/sap/ushell_abap/pbServices/ui2/ODataWrapper.js

@@ -63,7 +63,7 @@ sap.ui.define([
         }
         try {
             return JSON.parse(JSON.stringify(oInputObject));
-        } catch (e) {
+        } catch {
             return undefined;
         }
     }
@@ -342,6 +342,16 @@ sap.ui.define([
                 "X-CSRF-Token": oODataService.getCsrfToken()
             };
 
+            // Ensure fetching a csrf token for POST methods always. As of today, ABAP only requires a valid token for POST requests.
+            // Conceptual apart from HEAD request, a back-end can require a valid token for GET as well.
+            if (oODataService.getCsrfToken() === "" && sMethod !== "GET") {
+                oODataService.refreshCsrfToken(
+                    this.doRequest.bind(that, sRequestUrl, sMethod, oPayload, fnSuccess, fnFailure, oHandler, /* bIsRepeatedRequest */ true),
+                    fnFailure
+                );
+                return;
+            }
+
             addGlobalSapHeaders(oHeaders);
             addStickySessionHeader(oHeaders);
 
@@ -447,7 +457,9 @@ sap.ui.define([
             const sRequestUrl = this.toRequestUrl(sRelativeUrl);
             const oHeaders = addStickySessionHeader(addGlobalSapHeaders()); // may return an empty object
 
-            if (aBatchQueue) {
+            // if sRelativeUrl is empty, we ask for the service document, which is only used for fetching an XSRF token,
+            // so we are not taking already queued requests into account.
+            if (aBatchQueue && sRelativeUrl !== "") {
                 Log.debug(`Queued OData request for GET "${sRelativeUrl}"`, null,
                     "ODataWrapper");
                 aBatchQueue.push({
@@ -794,15 +806,15 @@ sap.ui.define([
                             oParsedErrorInformation.httpStatus = oError.response.statusCode;
                         }
                     }
-                } catch (ex) {
+                } catch (oParseError) {
                     // do not rely on subtleties of error response, treat error details as optional
                 }
             }
 
-            Log.error(sMessage, JSON.stringify(oError.response),
-                "ODataWrapper");
+            Log.error(sMessage, JSON.stringify(oError.response), "ODataWrapper");
 
             if (oDeferred) {
+                // reject with string as this is used to call the fnFailure
                 oDeferred.reject(sMessage, oParsedErrorInformation);
             }
             fnFailure(sMessage, oParsedErrorInformation);
@@ -1206,7 +1218,7 @@ sap.ui.define([
         try {
             // read the value from UI5 as it may be set via [CTRL-SHIFT-ALT-P]
             ODataWrapper["sap-statistics"] = Supportability.isStatisticsEnabled();
-        } catch (e) {
+        } catch {
             // Read sap-statistics directly form query parameter in scenarios without UI5
             ODataWrapper["sap-statistics"] =
                 /sap-statistics=(true|x|X)/.test(sWindowLocationSearch);

package/src/main/js/sap/ushell_abap/pbServices/ui2/Utils.js

@@ -76,8 +76,6 @@ sap.ui.define([
      */
     Utils.callHandler = function (fnSuccess, fnFailure, bAsync) {
         // see also redundant declaration in sap.ushell.utils.call which has to be in sync
-        let sMessage;
-
         if (bAsync) {
             setTimeout(() => {
                 Utils.callHandler(fnSuccess, fnFailure, false);
@@ -87,10 +85,9 @@ sap.ui.define([
 
         try {
             fnSuccess();
-        } catch (e) {
-            sMessage = e.message || e.toString();
-            Log.error(`Call to success handler failed: ${sMessage}`,
-                e.stack);
+        } catch (oError) {
+            const sMessage = oError.message || oError.toString();
+            Log.error(`Call to success handler failed: ${sMessage}`, oError);
             if (fnFailure) {
                 fnFailure(sMessage);
             }
@@ -189,10 +186,10 @@ sap.ui.define([
                 }
                 oXHR.send();
                 Log.debug(`Sent request to URL ${sUrl}`, null);
-            } catch (e) {
-                Log.error(`Error '${e.message || e}' in request to URL ${sUrl}`,
+            } catch (oError) {
+                Log.error(`Error '${oError.message || oError}' in request to URL ${sUrl}`,
                     null);
-                throw e;
+                throw oError;
             }
         }
     };

package/src/main/js/sap/ushell_abap/pbServices/ui2/contracts/actions.js

@@ -229,9 +229,9 @@ sap.ui.define([
                 }
                 try {
                     fnSetTypeHandler(sTypeLowerCase);
-                } catch (e) {
+                } catch (oError) {
                     Log.error(`Could not set CHIP type '${sTypeLowerCase}': ${
-                        e.message || e.toString()}`, null, "chip.types");
+                        oError.message || oError.toString()}`, null, "chip.types");
                 }
             }
         };

package/src/main/js/sap/ushell_abap/pbServices/ui2/contracts/visible.js

@@ -33,9 +33,9 @@ sap.ui.require([
         function callOnVisible () {
             try {
                 fnOnVisible(bVisible);
-            } catch (e) {
+            } catch (oError) {
                 Log.error(`${oChipInstance}: call to visible handler failed: ${
-                    e.message || e.toString()}`, null, "chip.visible");
+                    oError.message || oError.toString()}`, null, "chip.visible");
             }
         }
 

package/src/main/js/sap/ushell_abap/ui5appruntime/AppInfoAdapter.js

@@ -24,7 +24,7 @@ sap.ui.define([
      * @param {string} sAppId the ID of the app which is loaded
      * @returns {Promise<object>} a Promise resolving with the app data
      */
-    AppInfoAdapter.prototype.getAppInfo = function (sAppId) {
+    AppInfoAdapter.prototype.getAppInfo = async function (sAppId) {
         const oUrlParams = new URLSearchParams(window.location.search);
 
         // TODO: app ID should always be passed by caller
@@ -35,7 +35,7 @@ sap.ui.define([
         if (sAppId) {
             return this._loadAppIndexData("/sap/bc/ui2/app_index/ui5_app_info_json", sAppId);
         }
-        return Promise.reject(new Error("Cannot load app info - no app-id provided and URL parameter 'sap-ui-app-id' not set"));
+        return new Error("Cannot load app info - no app-id provided and URL parameter 'sap-ui-app-id' not set");
     };
 
     AppInfoAdapter.prototype._loadAppIndexData = function (sServiceUrl, sAppId) {