@sapui5/sap.ushell_abap 1.139.0 → 1.141.0

package/src/main/js/sap/ushell_abap/adapters/abap/FlpLaunchPageAdapter.js

@@ -3,7 +3,7 @@
 /**
  * @fileoverview The Unified Shell's page building adapter for the ABAP platform. Private copy. Classical home page functions are deprecated.
  * @since 1.121
- * @version 1.139.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/ui/thirdparty/URI",
@@ -22,7 +22,8 @@ sap.ui.define([
     "sap/ushell/ui/tile/StaticTile",
     "sap/ushell/utils",
     "sap/ushell_abap/pbServices/ui2/contracts/preview",
-    "sap/ushell/Container"
+    "sap/ushell/Container",
+    "sap/ushell/utils/LaunchpadError"
 ], (
     URI,
     ManifestPropertyHelper,
@@ -40,7 +41,8 @@ sap.ui.define([
     StaticTile,
     ushellUtils,
     Preview,
-    Container
+    Container,
+    LaunchpadError
 ) => {
     "use strict";
 
@@ -78,7 +80,7 @@ sap.ui.define([
      * @since 1.121.0
      * @private
      */
-    const LaunchPageAdapter = function (oUnused, sParameter, oAdapterConfiguration) {
+    function LaunchPageAdapter (oUnused, sParameter, oAdapterConfiguration) {
         let bCatalogsValid; // undefined = not yet valid
         let oGetGroupsDeferred; // used to synchronize parallel getGroups-requests
         let oGetCatalogsDeferred; // used to synchronize parallel getCatalog-requests
@@ -110,14 +112,14 @@ sap.ui.define([
         function getImplementationAsSapui5 (oTile, sTitle, sMessage) {
             try {
                 return oTile.getImplementationAsSapui5();
-            } catch (ex) {
+            } catch (oError) {
                 // log errors, but do not fail
-                Log.error(`${sMessage}: ${ex.message || ex}`, ex.stack, sCOMPONENT);
+                Log.error(sMessage, oError, sCOMPONENT);
                 return new StaticTile({
                     icon: "sap-icon://error",
                     info: "",
                     infoState: "Critical",
-                    subtitle: ex.message || ex,
+                    subtitle: oError.message || oError,
                     title: sTitle
                 }).addStyleClass("sapUshellTileError");
             }
@@ -167,7 +169,7 @@ sap.ui.define([
             try {
                 sTileConfig = oChip.getConfigurationParameter(sConfigParameterId);
                 oTileConfig = JSON.parse(sTileConfig);
-            } catch (e) {
+            } catch {
                 // most likely this is not a static or dynamic applauncher
                 return undefined;
             }
@@ -188,6 +190,8 @@ sap.ui.define([
          *
          * @param {object} [oConfiguration] object containing an order array, example: {order: ["id1", "id2", "id3"]}
          * @param {object[]} aElements array of objects. Each object must provide a getId method
+         *
+         * @returns {object[]} array of elements ordered according to the configuration
          * @private
          * @since 1.11.0
          * @deprecated since 1.120
@@ -226,6 +230,24 @@ sap.ui.define([
             return aOrderedElements;
         };
 
+        /**
+         * Removes vValue from the given array.
+         *
+         * @param {Array<*>} aArray The array from which the value should be removed from.
+         * @param {any} vValue The value to be removed.
+         * @returns {int} The index of the vValue in the array or -1 if it was not found.
+         * @private
+         * @deprecated since 1.120
+         */
+        function removeFromArray (aArray, vValue) {
+            const iSourceIndex = aArray.indexOf(vValue);
+            if (iSourceIndex < 0) {
+                return iSourceIndex;
+            }
+            aArray.splice(iSourceIndex, 1);
+            return iSourceIndex;
+        }
+
         /**
          * Removes the given tile from the given Page layout, according to it's current type.
          *
@@ -249,24 +271,6 @@ sap.ui.define([
             return removeFromArray(oLayout.order, oTile.getId());
         }
 
-        /**
-         * Removes vValue from the given array.
-         *
-         * @param {Array<*>} aArray The array from which the value should be removed from.
-         * @param {any} vValue The value to be removed.
-         * @returns {int} The index of the vValue in the array or -1 if it was not found.
-         * @private
-         * @deprecated since 1.120
-         */
-        function removeFromArray (aArray, vValue) {
-            const iSourceIndex = aArray.indexOf(vValue);
-            if (iSourceIndex < 0) {
-                return iSourceIndex;
-            }
-            aArray.splice(iSourceIndex, 1);
-            return iSourceIndex;
-        }
-
         /**
          * Adds the given tile ID to the given Page layout in the specified index and according to it's current type.
          *
@@ -332,7 +336,7 @@ sap.ui.define([
         /**
          * Orders the pages of _oCurrentPageSet based on the configuration maintained in _oCurrentPageSet and returns the result.
          *
-         * @returns {sap.ushell_abap.pbServices.ui2.Page[]}
+         * @returns {sap.ushell_abap.pbServices.ui2.Page[]} Returns a UI2 Page
          * @private
          * @deprecated since 1.120
          */
@@ -343,7 +347,7 @@ sap.ui.define([
             try {
                 oConfiguration = JSON.parse(that._oCurrentPageSet.getConfiguration());
                 oConfiguration.order.splice(0, 0, that._oCurrentPageSet.getDefaultPage().getId());
-            } catch (e) {
+            } catch {
                 oConfiguration = { order: [that._oCurrentPageSet.getDefaultPage().getId()] };
             }
             return LaunchPageAdapter.prototype._orderBasedOnConfiguration(oConfiguration, that._oCurrentPageSet.getPages());
@@ -364,15 +368,19 @@ sap.ui.define([
             const oDeferred = new jQuery.Deferred();
 
             if (!aHiddenGroupsIDs || !(aHiddenGroupsIDs instanceof Array)) {
-                oDeferred.reject("Input parameter must be of type Array.");
+                oDeferred.reject(new Error("Input parameter must be of type Array."));
             } else {
                 const oConf = JSON.parse(that._oCurrentPageSet.getConfiguration() || "{}");
 
                 // Replace the hidden groups array on the current configuration with the new hidden groups array
                 oConf.hiddenGroups = aHiddenGroupsIDs;
-                that._oCurrentPageSet.setConfiguration(JSON.stringify(oConf),
-                /* fnSuccess */oDeferred.resolve.bind(oDeferred),
-                    /* fnFailure */oDeferred.reject.bind(oDeferred));
+                that._oCurrentPageSet.setConfiguration(
+                    JSON.stringify(oConf),
+                    /* fnSuccess */oDeferred.resolve.bind(oDeferred),
+                    /* fnFailure */(sErrorMessage) => {
+                        oDeferred.reject(new Error(sErrorMessage));
+                    }
+                );
             }
             return oDeferred.promise();
         };
@@ -414,6 +422,7 @@ sap.ui.define([
          * Triggers loading of a CHIP instance and adds the temporary property $loadingPromise to it
          * as it does not wait for the loading success or failure.
          * As soon as it is completely loaded (or loading failed) the $loadingPromise property is removed again.
+         * @param {object} oChipInstance the CHIP instance to be loaded
          * @deprecated since 1.120
          */
         LaunchPageAdapter.prototype._triggerChipInstanceLoad = function (oChipInstance) {
@@ -425,11 +434,11 @@ sap.ui.define([
                 delete oChipInstance.$loadingPromise; // was temporarily needed only
             }
 
-            function fnFailure (sMessage) {
+            function fnFailure (sErrorMessage) {
                 // log errors, but do not fail
-                Log.error(`Failed to load tile: ${sMessage}`, oChipInstance.toString(), sCOMPONENT);
+                Log.error(`Failed to load tile '${oChipInstance.toString()}': ${sErrorMessage}`, null, sCOMPONENT);
                 if (oChipInstance._loadingDeferred) {
-                    oChipInstance._loadingDeferred.reject();
+                    oChipInstance._loadingDeferred.reject(new Error(sErrorMessage));
                 }
                 delete oChipInstance._loadingDeferred;
                 delete oChipInstance.$loadingPromise; // was temporarily needed only
@@ -438,6 +447,49 @@ sap.ui.define([
             oChipInstance.load(fnSuccess, fnFailure);
         };
 
+        /**
+         * Tells whether the given CHIP instance is a static or dynamic app launcher
+         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance the chip instance
+         * @returns {boolean} true if the CHIP instance is an app launcher, false otherwise
+         */
+        function isAppLauncher (oChipInstance) {
+            const sBaseChipId = oChipInstance.getChip().getBaseChipId();
+            return sBaseChipId === sDYNAMIC_BASE_CHIP_ID || sBaseChipId === sSTATIC_BASE_CHIP_ID;
+        }
+
+        /**
+         * Tells whether the given CHIP instance is a card
+         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance the chip instance
+         * @returns {boolean} true if the CHIP instance is a card, false otherwise
+         */
+        function isCard (oChipInstance) {
+            const sBaseChipId = oChipInstance.getChip().getBaseChipId();
+            return S_CARD_BASE_CHIP_ID === sBaseChipId;
+        }
+
+        /**
+         * Tells whether the given CHIP instance is remote
+         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance the chip instance
+         * @returns {boolean} true if the CHIP instance is remote, false otherwise
+         */
+        function isRemoteChipInstance (oChipInstance) {
+            return !!oChipInstance.getChip().getRemoteCatalog();
+        }
+
+        /**
+         * Tells whether the given CHIP instance is not loadable.
+         * This means it's data from the OData Service could not be loaded.
+         *
+         * Note: If this method returns false does not mean that the later loading will not fail
+         *
+         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance the chip instance
+         * @returns {boolean} true if the CHIP instance is not loadable, false otherwise
+         */
+        function isBrokenChip (oChipInstance) {
+            // alternative: !oChipInstance.getChip().isInitiallyDefined();
+            return !isRemoteChipInstance(oChipInstance) && oChipInstance.getChip().getBaseChipId() === undefined;
+        }
+
         /**
          * Triggers loading of all ChipInstances of the given pages and calls fnLocalChipsLoaded
          * when all local CHIP instances are completely loaded.
@@ -462,6 +514,7 @@ sap.ui.define([
             /**
              * Loads dependent libraries (core-ext-light for custom tiles and custom remote tiles)
              * and triggers the loading of the chip instances.
+             * @param {object} oChipInstance the CHIP instance to be loaded
              */
             function loadDependenciesAndTriggerChipInstanceLoad (oChipInstance) {
                 // append the promise for loading to the instance, but only as long as loading is
@@ -500,6 +553,7 @@ sap.ui.define([
 
             /**
              * loads a CHIP instance and triggers finalize() or reject afterwards
+             * @param {object} oChipInstance the CHIP instance to be loaded
              */
             function loadChipInstance (oChipInstance) {
                 function onLoad () {
@@ -577,12 +631,14 @@ sap.ui.define([
             }
 
             if (ObjectPath.get("compactTMPromise", oAdapterConfig)) {
-                oAdapterConfig.compactTMPromise.then((oResult) => {
-                    const aRes = formatResult(oResult || {});
-                    oDeferred.resolve({ results: aRes });
-                }, (sFail) => {
-                    oDeferred.reject(sFail);
-                });
+                oAdapterConfig.compactTMPromise
+                    .then((oResult) => {
+                        const aRes = formatResult(oResult || {});
+                        oDeferred.resolve({ results: aRes });
+                    })
+                    .catch((oError) => {
+                        oDeferred.reject(oError);
+                    });
                 return oDeferred.promise();
             }
             const oTargetMappingsConfig = ObjectPath.create("services.targetMappings", oAdapterConfig);
@@ -606,8 +662,8 @@ sap.ui.define([
                     const aRes = formatResult(oDirectStartTargetMappings);
                     oDeferred.resolve({ results: aRes });
                 },
-                (sMessage) => {
-                    oDeferred.reject(sMessage);
+                (sErrorMessage) => {
+                    oDeferred.reject(new Error(sErrorMessage));
                 }
             );
             return oDeferred.promise();
@@ -630,8 +686,8 @@ sap.ui.define([
          * This is the case for the results of {@link #addTile}, but not for {@link #addBookmark}.
          * Such wrappers must be unwrapped by {@link #moveTile} or else the title becomes "hard coded" in the newly created CHIP instance.
          *
-         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oTile
-         * @returns {boolean}
+         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oTile the tile object
+         * @returns {boolean} true if the tile has a config
          * @deprecated since 1.120
          */
         LaunchPageAdapter.prototype._isWrapperOnly = function (oTile) {
@@ -700,49 +756,6 @@ sap.ui.define([
             return aWrappedCatalogs;
         }
 
-        /**
-         * Tells whether the given CHIP instance is a static or dynamic app launcher
-         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance
-         * @returns {boolean}
-         */
-        function isAppLauncher (oChipInstance) {
-            const sBaseChipId = oChipInstance.getChip().getBaseChipId();
-            return sBaseChipId === sDYNAMIC_BASE_CHIP_ID || sBaseChipId === sSTATIC_BASE_CHIP_ID;
-        }
-
-        /**
-         * Tells whether the given CHIP instance is a card
-         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance
-         * @returns {boolean}
-         */
-        function isCard (oChipInstance) {
-            const sBaseChipId = oChipInstance.getChip().getBaseChipId();
-            return S_CARD_BASE_CHIP_ID === sBaseChipId;
-        }
-
-        /**
-         * Tells whether the given CHIP instance is remote
-         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance
-         * @returns {boolean}
-         */
-        function isRemoteChipInstance (oChipInstance) {
-            return !!oChipInstance.getChip().getRemoteCatalog();
-        }
-
-        /**
-         * Tells whether the given CHIP instance is not loadable.
-         * This means it's data from the OData Service could not be loaded.
-         *
-         * Note: If this method returns false does not mean that the later loading will not fail
-         *
-         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance
-         * @returns {boolean}
-         */
-        function isBrokenChip (oChipInstance) {
-            // alternative: !oChipInstance.getChip().isInitiallyDefined();
-            return !isRemoteChipInstance(oChipInstance) && oChipInstance.getChip().getBaseChipId() === undefined;
-        }
-
         /**
          * Returns the tile configuration of the given (app launcher) CHIP instance.
          * It logs an error message if the tile configuration cannot be parsed.
@@ -755,11 +768,11 @@ sap.ui.define([
             const sConfigParam = oChipInstance.getConfigurationParameter("tileConfiguration");
             try {
                 oParsedTileConfiguration = JSON.parse(sConfigParam || "{}");
-            } catch (oEx) {
+            } catch (oError) {
                 Log.error(`Tile with ID '${oChipInstance.getId()
                 }' has a corrupt configuration containing a 'tileConfiguration' value '${sConfigParam
                 }' which could not be parsed. If present, a (stringified) JSON is expected as value.`,
-                oEx.message,
+                oError,
                 "sap.ushell_abap.adapters.abap.LaunchPageAdapter"
                 );
                 return {}; // the FLP must react robust on broken single tiles
@@ -794,7 +807,7 @@ sap.ui.define([
                     oAppLauncherStyleConfig.navigation_semantic_object = oParsedTileProperties.semanticObject;
                     oAppLauncherStyleConfig.navigation_semantic_action = oParsedTileProperties.semanticAction;
                 }
-            } catch (oEx) {
+            } catch (oError) {
                 // it is fine if a tile is not sticking to the expected configuration structure
                 return {};
             }
@@ -846,7 +859,7 @@ sap.ui.define([
                 // Drawback: Configuration defaults (which are usually not used in Fiori) from CHIP definition XML are ignored here.
                 const oConfigParam = JSON.parse(oChipInstance.getChip()._getChipRawConfigurationString());
                 oParsedTileConfiguration = JSON.parse(oConfigParam && oConfigParam.tileConfiguration || "{}");
-            } catch (oEx) {
+            } catch (oError) {
                 // Custom tiles may or may not stick to the app launcher's configuration format
                 return {};
             }
@@ -920,7 +933,7 @@ sap.ui.define([
          * @private
          */
         this._parseReferenceLost = function (sReferenceLost) {
-            var sReferenceLostSafe = sReferenceLost || Object.prototype.toString.apply(sReferenceLostSafe);
+            const sReferenceLostSafe = sReferenceLost || "";
 
             if (!sReferenceLostSafe.match(/^Reference lost: Note \d+ Page.+\s,\sInstance ID.+$/)) {
                 Log.warning(
@@ -1078,7 +1091,7 @@ sap.ui.define([
                                 });
                                 break;
                             case O_ERROR_TYPES.emptyConfiguration:
-                                var sRawTileConfiguration = oChipInstance.getConfigurationParameter("tileConfiguration");
+                                const sRawTileConfiguration = oChipInstance.getConfigurationParameter("tileConfiguration");
                                 aResult.push({
                                     type: O_ERROR_TYPES.emptyConfiguration,
                                     chipInstanceId: oChipInstance.getId(),
@@ -1113,6 +1126,7 @@ sap.ui.define([
          * Formats information about one error into a string.
          *
          * @param {object} oTileError An object representing tile errors
+         * @returns {string} A string describing the error
          */
         this._formatTileError = function (oTileError) {
             switch (oTileError.type) {
@@ -1438,8 +1452,8 @@ sap.ui.define([
 
             try {
                 oLayout = JSON.parse(oGroup.getLayout());
-            } catch (e) {
-                Log.warning(`Group ${oGroup.getId()}: invalid layout: ${oGroup.getLayout()}`, null, sCOMPONENT);
+            } catch (oError) {
+                Log.warning(`Group ${oGroup.getId()}: invalid layout: ${oGroup.getLayout()}`, oError, sCOMPONENT);
                 // no valid layout
             }
             return this._orderBasedOnConfiguration(oLayout, oGroup.getChipInstances());
@@ -1490,7 +1504,9 @@ sap.ui.define([
 
             that._oCurrentPageSet.appendPage(sTitle, sDEFAULT_CATALOG_ID,
                 oDeferred.resolve.bind(oDeferred),
-                oDeferred.reject.bind(oDeferred, getOrderedPages()));
+                (sErrorMessage) => {
+                    oDeferred.reject(new Error(sErrorMessage), getOrderedPages());
+                });
 
             return oDeferred.promise();
         };
@@ -1509,10 +1525,16 @@ sap.ui.define([
             const oDeferred = new jQuery.Deferred();
 
             if (that._oCurrentPageSet.isPageRemovable(oGroup)) {
-                that._oCurrentPageSet.removePage(oGroup, oDeferred.resolve.bind(oDeferred),
-                    oDeferred.reject.bind(oDeferred, getOrderedPages()));
+                that._oCurrentPageSet.removePage(
+                    oGroup,
+                    oDeferred.resolve.bind(oDeferred),
+                    (sErrorMessage) => {
+                        Log.error(`Failed to remove group '${oGroup.toString()}'`, sErrorMessage, sCOMPONENT);
+                        oDeferred.reject(new Error(sErrorMessage), getOrderedPages());
+                    }
+                );
             } else {
-                oDeferred.reject(getOrderedPages());
+                oDeferred.reject(new Error("Group is not removable"), getOrderedPages());
             }
             return oDeferred.promise();
         };
@@ -1534,12 +1556,17 @@ sap.ui.define([
 
             if (that._oCurrentPageSet.isPageRemovable(oGroup)) {
                 // pages which are removable should be removed and cannot be reset
-                oDeferred.reject(getOrderedPages());
+                oDeferred.reject(new Error("Group is not removable"), getOrderedPages());
             } else if (that._oCurrentPageSet.isPageResettable(oGroup)) {
                 // pages which are resettable should be reset
-                that._oCurrentPageSet.resetPage(oGroup, () => {
-                    that._loadApplaunchersAndDelayLoadingOfOtherChips([oGroup], oDeferred.resolve.bind(oDeferred, oGroup));
-                }, oDeferred.reject.bind(oDeferred, getOrderedPages()));
+                that._oCurrentPageSet.resetPage(
+                    oGroup,
+                    () => {
+                        that._loadApplaunchersAndDelayLoadingOfOtherChips([oGroup], oDeferred.resolve.bind(oDeferred, oGroup));
+                    },
+                    (sErrorMessage) => {
+                        oDeferred.reject(new Error("Failed to reset group"), getOrderedPages());
+                    });
             } else {
                 // on all other pages an reset has simply no effect
                 oDeferred.resolve(oGroup);
@@ -1803,7 +1830,9 @@ sap.ui.define([
                 oConf.order = aIds;
                 that._oCurrentPageSet.setConfiguration(JSON.stringify(oConf),
                     oDeferred.resolve.bind(oDeferred),
-                    oDeferred.reject.bind(oDeferred, getOrderedPages()));
+                    (sErrorMessage) => {
+                        oDeferred.reject(new Error(sErrorMessage), getOrderedPages());
+                    });
             }
 
             this.getGroups().done((aPages) => {
@@ -1832,8 +1861,8 @@ sap.ui.define([
 
             oGroup.setTitle(sNewTitle,
                 oDeferred.resolve.bind(oDeferred),
-                () => {
-                    oDeferred.reject(oGroup.getTitle());
+                (sErrorMessage) => {
+                    oDeferred.reject(new Error("Failed to set group title"), oGroup.getTitle());
                 });
 
             return oDeferred.promise();
@@ -1856,7 +1885,7 @@ sap.ui.define([
             if (oCatalogTile.isStub()) {
                 // this is a "Cannot load tile" tile, this should not be added to the group
                 // BCP 1670300106
-                oDeferred.reject(getOrderedPages(), new Error("Tile was not added to the group as the tile failed loading"));
+                oDeferred.reject(new Error("Tile was not added to the group as the tile failed loading"), getOrderedPages());
             } else {
                 if (!oGroup) {
                     oGroup = that._oCurrentPageSet.getDefaultPage();
@@ -1864,7 +1893,10 @@ sap.ui.define([
 
                 oGroup.addChipInstance(oChip,
                     oDeferred.resolve.bind(oDeferred),
-                    oDeferred.reject.bind(oDeferred, getOrderedPages()));
+                    (sErrorMessage) => {
+                        oDeferred.reject(new Error(sErrorMessage), getOrderedPages());
+                    }
+                );
             }
 
             return oDeferred.promise();
@@ -1885,7 +1917,10 @@ sap.ui.define([
 
             oGroup.removeChipInstance(oTile,
                 oDeferred.resolve.bind(oDeferred),
-                oDeferred.reject.bind(oDeferred, getOrderedPages()));
+                (sErrorMessage) => {
+                    oDeferred.reject(new Error(sErrorMessage), getOrderedPages());
+                }
+            );
             return oDeferred.promise();
         };
 
@@ -1909,7 +1944,9 @@ sap.ui.define([
             const bIsWrapperOnly = this._isWrapperOnly(oTile);
             const oBagsContents = new Utils.Map();
             let oCreatedChipInstance;
-            const fnFailure = oDeferred.reject.bind(oDeferred, getOrderedPages());
+            function fnFailure (sErrorMessage) {
+                oDeferred.reject(new Error(sErrorMessage), getOrderedPages());
+            }
             let iCalls = 2;
 
             function resolveMoveBetweenGroups (oNewChipInstance) {
@@ -1934,7 +1971,7 @@ sap.ui.define([
             iSourceIndex = removeFromLayout(oSourceLayout, oTile, sOldTileType);
             if (iSourceIndex < 0) {
                 Log.error("moveTile: tile not found in source group", null, sCOMPONENT);
-                fnFailure();
+                fnFailure("moveTile: tile not found in source group");
                 return oDeferred.promise();
             }
 
@@ -2041,8 +2078,8 @@ sap.ui.define([
                     // Note: no verification if oTile.getChip().getAvailableTypes() contains "link" -> fail early in this case
                     return "link";
                 }
-            } catch (e) {
-                Log.warning(`Group ${oGroup.getId()}: invalid layout: ${oGroup.getLayout()}`, null, sCOMPONENT);
+            } catch (oError) {
+                Log.warning(`Group ${oGroup.getId()}: invalid layout: ${oGroup.getLayout()}`, oError, sCOMPONENT);
             }
 
             // Cards can never be a stub at this point
@@ -2072,8 +2109,8 @@ sap.ui.define([
                 oManifest = ManifestPropertyHelper.mergeCardData(oManifest, oCardData);
 
                 return oManifest;
-            } catch (error) {
-                Log.error(`Manifest of card with id '${card.getId()}' could not be read. ${error.message}`);
+            } catch (oError) {
+                Log.error(`Manifest of card with id '${card.getId()}' could not be read.`, oError);
             }
         };
 
@@ -2103,6 +2140,11 @@ sap.ui.define([
             const that = this;
             const oDeferred = new jQuery.Deferred();
 
+            function doReject (oError) {
+                Log.error("Tile not successfully loaded:", oError, sCOMPONENT);
+                oDeferred.reject(oError);
+            }
+
             function doResolve () {
                 let sTileType;
 
@@ -2145,10 +2187,6 @@ sap.ui.define([
                     .catch(doReject);
             }
 
-            function doReject (sMessage) {
-                oDeferred.reject(`Tile not successfully loaded${sMessage ? (`: ${sMessage}`) : ""}`);
-            }
-
             if (!oTile.$loadingPromise) { // loading resolved or failed
                 if (!oTile.isStub()) { // success
                     // call getImplementationAsSapui5Async async for non-AppLaunchers and resolves.
@@ -2157,7 +2195,7 @@ sap.ui.define([
                     // Although they are called sync the view creation is still async
                     Utils.callHandler(doResolve, doReject, /* async */!isAppLauncher(oTile));
                 } else { // failed
-                    doReject();
+                    doReject(new Error("Tile failed to load - tile is still a stub"));
                 }
             } else { // loading pending
                 oTile.$loadingPromise
@@ -2165,8 +2203,8 @@ sap.ui.define([
                     .done(() => {
                         try {
                             doResolve();
-                        } catch (ex) {
-                            doReject((ex.message || ex));
+                        } catch (oError) {
+                            doReject((oError));
                         }
                     });
             }
@@ -2394,10 +2432,10 @@ sap.ui.define([
                                 if (iPendingRequests <= 0) {
                                     oDeferred.resolve(aWrappedCatalogs);
                                 }
-                            }, (sMessage) => {
+                            }, (sErrorMessage) => {
                                 // log errors, but do not fail
-                                Log.error(`Failed to load catalog: ${sMessage}`, oCatalog.toString(), sCOMPONENT);
-                                oWrappedCatalog.errorMessage = sMessage || "Error"; // not undefined!
+                                Log.error(`Failed to load catalog: ${sErrorMessage}`, oCatalog.toString(), sCOMPONENT);
+                                oWrappedCatalog.errorMessage = sErrorMessage || "Error"; // not undefined!
 
                                 oDeferred.notify(oWrappedCatalog);
 
@@ -2450,7 +2488,9 @@ sap.ui.define([
             if (oAllCatalogs.isStub()) {
                 oAllCatalogs.load(() => {
                     this._refreshRemoteCatalogs(oDeferred);
-                }, oDeferred.reject, "type eq 'CATALOG_PAGE' or type eq 'H' or type eq 'SM_CATALOG' or type eq 'REMOTE'", true, "title", true);
+                }, (sErrorMessage) => {
+                    oDeferred.reject(new Error(sErrorMessage));
+                }, "type eq 'CATALOG_PAGE' or type eq 'H' or type eq 'SM_CATALOG' or type eq 'REMOTE'", true, "title", true);
             } else if (bRefreshRequired) {
                 this._refreshRemoteCatalogs(oDeferred);
             } else {
@@ -2508,7 +2548,7 @@ sap.ui.define([
          * it might become <code>false</code> again in case one of the catalogs has been invalidated,
          * e.g. due to the addition of a tile ("Add to catalog" scenario).
          *
-         * @returns {boolean}
+         * @returns {boolean} if the catalogs collection is still valid, <code>false</code> otherwise.
          * @since 1.16.4
          * @deprecated since 1.120
          * @see #getCatalogs
@@ -2588,9 +2628,9 @@ sap.ui.define([
                 }
             }
 
-            function onFailure (oCatalogTile, sMessage) {
+            function onFailure (oCatalogTile, sErrorMessage) {
                 // log errors, but do not fail
-                Log.error(`Failed to load catalog tile: ${sMessage}`, oCatalogTile.toString(), sCOMPONENT);
+                Log.error(`Failed to load catalog tile: ${sErrorMessage}`, oCatalogTile.toString(), sCOMPONENT);
                 onLoaded();
             }
 
@@ -2921,13 +2961,11 @@ sap.ui.define([
 
             // Apply the 'search' contract when available
             function getKeywordsFromSearchContract (oCatalogTile) {
-                let oSearchContract;
-
                 if (oCatalogTile.isStub()) {
                     return [];
                 }
 
-                oSearchContract = oCatalogTile.getContract("search");
+                const oSearchContract = oCatalogTile.getContract("search");
                 if (oSearchContract) {
                     return oSearchContract.getKeywords();
                 }
@@ -3030,7 +3068,7 @@ sap.ui.define([
             if (oGroup && !(oGroup instanceof Page)) {
                 // same behavior like addCatalogTileToGroup of the Bookmark service:
                 // if the group is unknown don't use the default group but reject.
-                oDeferred.reject("The given object is not a group");
+                oDeferred.reject(new Error("The given object is not a group"));
                 return oDeferred.promise();
             }
 
@@ -3042,8 +3080,8 @@ sap.ui.define([
                 .then(() => {
                     oDeferred.resolve();
                 })
-                .catch((vError) => {
-                    oDeferred.reject(vError.toString());
+                .catch((oError) => {
+                    oDeferred.reject(oError);
                 });
             return oDeferred.promise();
         };
@@ -3092,7 +3130,7 @@ sap.ui.define([
             if (oGroup && !(oGroup instanceof Page)) {
                 // same behavior like addCatalogTileToGroup of the Bookmark service:
                 // if the group is unknown don't use the default group but reject.
-                oDeferred.reject("The given object is not a group");
+                oDeferred.reject(new Error("The given object is not a group"));
                 return oDeferred.promise();
             }
 
@@ -3100,8 +3138,8 @@ sap.ui.define([
                 .then(() => {
                     oDeferred.resolve();
                 })
-                .catch((vError) => {
-                    oDeferred.reject(vError.toString());
+                .catch((oError) => {
+                    oDeferred.reject(oError);
                 });
             return oDeferred.promise();
         };
@@ -3182,7 +3220,15 @@ sap.ui.define([
                     aPromises.push(new Promise((resolve, reject) => {
                         if (bBagUpdated) {
                             aUpdatedBags.push(sBagId);
-                            oBag.save(resolve, reject);
+                            oBag.save(resolve, (mErrorMessages, mErrorInfo) => {
+                                const sFirstFailedBag = Object.keys(mErrorMessages)[0];
+
+                                reject(new LaunchpadError(`Bag save failed: ${mErrorMessages[sFirstFailedBag]}`, {
+                                    info: mErrorInfo[sFirstFailedBag],
+                                    otherMessages: mErrorMessages,
+                                    otherInfo: mErrorInfo
+                                }));
+                            });
                         } else {
                             resolve();
                         }
@@ -3221,9 +3267,9 @@ sap.ui.define([
                     this.getTileSize(oChipInstance);
                     resolve();
                 } catch (oError) {
-                    const sMessage = `Chip configuration check failed: ${oError.toString()}`;
-                    Log.error(sMessage, oChipInstance.getId(), sCOMPONENT);
-                    reject(sMessage);
+                    const sMessage = `Chip configuration check failed for '${oChipInstance.getId()}':`;
+                    Log.error(sMessage, oError, sCOMPONENT);
+                    reject(oError);
                 }
             });
         };
@@ -3277,7 +3323,9 @@ sap.ui.define([
                             // the create service does not support deep insert
                             // Chip ChipBags -> Chip
                         });
-                        oGroup.addChipInstance(oChipInstance, resolve, reject, undefined);
+                        oGroup.addChipInstance(oChipInstance, resolve, (sErrorMessage) => {
+                            reject(new Error(sErrorMessage));
+                        }, undefined);
                     } else {
                         // This can happen in the app cold-start use case, when the app creates a bookmark
                         // createPageChipInstanceFromRawData might throw Errors
@@ -3288,10 +3336,14 @@ sap.ui.define([
                                 pageId: "/UI2/Fiori2LaunchpadHome", // Default Page
                                 title: sTitle // the title is used for e.g. the message toast after deleting a bookmark
                             }, (oRawChipInstance) => {
-                                oFactory.createChipInstance(oRawChipInstance, resolve, reject, /* oPage */undefined);
-                            }, reject);
-                        } catch (vError) {
-                            reject(vError);
+                                oFactory.createChipInstance(oRawChipInstance, resolve, (sErrorMessage) => {
+                                    reject(new Error(sErrorMessage));
+                                }, /* oPage */undefined);
+                            }, (sErrorMessage) => {
+                                reject(new Error(sErrorMessage));
+                            });
+                        } catch (oError) {
+                            reject(oError);
                         }
                     }
                 });
@@ -3301,9 +3353,9 @@ sap.ui.define([
                         .then(() => {
                             return this._checkBookmarkConfiguration(oChipInstance);
                         })
-                        .catch((vError) => {
+                        .catch((oError) => {
                             return new Promise((resolve, reject) => {
-                                oChipInstance.remove(reject.bind(undefined, vError), reject.bind(undefined, vError));
+                                oChipInstance.remove(reject.bind(undefined, oError), reject.bind(undefined, oError));
                             });
                         });
                 });
@@ -3312,9 +3364,9 @@ sap.ui.define([
         /**
          * Tells whether the given CHIP instance represents a bookmark matching the given identifier.
          *
-         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance
+         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance the CHIP instance to be checked
          * @param {string | object} vIdentifier the url as string or an identifier object
-         * @returns {boolean}
+         * @returns {boolean} If the CHIP instance represents a bookmark matching the given identifier.
          * @see #addBookmark
          * @since 1.17.1
          * @deprecated since 1.120
@@ -3369,16 +3421,16 @@ sap.ui.define([
                         oDeferred.resolve(iCount);
                     } else {
                         jQuery.when.apply(jQuery, aDeferreds)
-                            .fail((sMessage) => {
-                                oDeferred.reject(sMessage);
+                            .fail((oError) => {
+                                oDeferred.reject(oError);
                             })
                             .done(() => {
                                 oDeferred.resolve(iCount);
                             });
                     }
                 })
-                .catch((vError) => {
-                    oDeferred.reject(vError.message || vError);
+                .catch((oError) => {
+                    oDeferred.reject(oError);
                 });
             return oDeferred.promise();
         };
@@ -3402,9 +3454,9 @@ sap.ui.define([
          * @since 1.83.0
          * @deprecated since 1.120
          */
-        this._visitCustomBookmarks = function (oIdentifier, fnVisitor) {
+        this._visitCustomBookmarks = async function (oIdentifier, fnVisitor) {
             if (!oIdentifier.chipId) {
-                return Promise.reject("_visitCustomBookmarks: Required parameter is missing: oIdentifier.chipId");
+                throw new Error("_visitCustomBookmarks: Required parameter is missing: oIdentifier.chipId");
             }
             return new Promise((resolve, reject) => {
                 this.getGroups()
@@ -3487,7 +3539,9 @@ sap.ui.define([
             return LaunchPageAdapter.prototype._visitBookmarks(sUrl, (oChipInstance) => {
                 const oDeferred = new jQuery.Deferred();
                 oChipInstance.remove(oDeferred.resolve.bind(oDeferred),
-                    oDeferred.reject.bind(oDeferred));
+                    (sErrorMessage) => {
+                        oDeferred.reject(new Error(sErrorMessage));
+                    });
                 return oDeferred.promise();
             });
         };
@@ -3515,7 +3569,9 @@ sap.ui.define([
         this.deleteCustomBookmarks = function (oIdentifier) {
             return this._visitCustomBookmarks(oIdentifier, (oChipInstance) => {
                 return new Promise((resolve, reject) => {
-                    oChipInstance.remove(resolve, reject);
+                    oChipInstance.remove(resolve, (sErrorMessage) => {
+                        reject(new Error(sErrorMessage));
+                    });
                 });
             });
         };
@@ -3579,7 +3635,9 @@ sap.ui.define([
                     })
                     .then(() => {
                         return new Promise((resolve, reject) => {
-                            oChipInstance.updateConfiguration(oConfiguration, resolve, reject);
+                            oChipInstance.updateConfiguration(oConfiguration, resolve, (sErrorMessage) => {
+                                reject(new Error(sErrorMessage));
+                            });
                         });
                     })
                     .then(() => {
@@ -3593,7 +3651,7 @@ sap.ui.define([
                         oDeferred.resolve();
                     })
                     .catch((oError) => {
-                        oDeferred.reject(oError.toString());
+                        oDeferred.reject(oError);
                     });
 
                 return oDeferred.promise();
@@ -3671,7 +3729,9 @@ sap.ui.define([
                         return new Promise((resolve, reject) => {
                             // chip might throw an error because of missing writeConfiguration contract
                             try {
-                                oChipInstance.updateConfiguration(oConfiguration, resolve, reject);
+                                oChipInstance.updateConfiguration(oConfiguration, resolve, (sErrorMessage) => {
+                                    reject(new Error(sErrorMessage));
+                                });
                             } catch (oError) {
                                 reject(oError);
                             }
@@ -3690,7 +3750,9 @@ sap.ui.define([
                         }
                         return new Promise((resolve, reject) => {
                             if (oBookmarkConfig.title) {
-                                oChipInstance.setTitle(oBookmarkConfig.title, true, resolve, reject);
+                                oChipInstance.setTitle(oBookmarkConfig.title, true, resolve, (sErrorMessage) => {
+                                    reject(new Error(sErrorMessage));
+                                });
                             } else {
                                 resolve();
                             }
@@ -3722,7 +3784,7 @@ sap.ui.define([
         this.isCustomTile = function (tile) {
             return !isAppLauncher(tile);
         };
-    };
+    }
 
     /**
      * Returns raw catalog tile data that can be used to instantiate the tile
@@ -3739,8 +3801,9 @@ sap.ui.define([
                 return new Promise((resolve, reject) => {
                     // There is no good way to access the raw data as it is normalized and well hidden in closures in sap.ushell_abap.pbServices.ui2
                     // Therefore we trigger the allCatalogs request again which reads from the cache of the OData wrapper
-                    oUI2PageBuildingService.readAllCatalogs(PAGE_ID_WITHOUT_TM, resolve, reject,
-                        "type eq 'CATALOG_PAGE' or type eq 'H' or type eq 'SM_CATALOG' or type eq 'REMOTE'", "title", true);
+                    oUI2PageBuildingService.readAllCatalogs(PAGE_ID_WITHOUT_TM, resolve, (sErrorMessage) => {
+                        reject(new Error(sErrorMessage));
+                    }, "type eq 'CATALOG_PAGE' or type eq 'H' or type eq 'SM_CATALOG' or type eq 'REMOTE'", "title", true);
                 });
             })
             .then((oResponse) => {