@sapui5/sap.ushell_abap 1.139.0 → 1.140.0

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@sapui5/sap.ushell_abap",
-    "version": "1.139.0",
+    "version": "1.140.0",
     "description": "SAPUI5 Library sap.ushell_abap",
     "homepage": "https://sap.github.io/ui5-tooling/pages/SAPUI5/",
     "keywords": [

package/src/main/js/sap/ushell_abap/.library

@@ -2,7 +2,7 @@
 <library xmlns="http://www.sap.com/sap.ui.library.xsd">
     <name>sap.ushell_abap</name>
     <vendor>SAP SE</vendor>
-    <version>1.139.0</version>
+    <version>1.140.0</version>
     <copyright>Copyright (c) 2009-2025 SAP SE, All Rights Reserved</copyright>
     <documentation>SAP library: sap.ushell_abap</documentation>
 

package/src/main/js/sap/ushell_abap/adapters/abap/AdapterContainer.js

@@ -34,7 +34,7 @@ sap.ui.define([
         return sContainerKey.substring(sCONTAINER_KEY_PREFIX.length, sCONTAINER_KEY_PREFIX.length + 40);
     }
 
-    const AdapterContainer = function (sContainerKey, oService, oScope, sAppName) {
+    function AdapterContainer (sContainerKey, oService, oScope, sAppName) {
         this._oService = oService;
         this._oScope = oScope;
         this["sap-cache-id"] = ObjectPath.get("_oService._oConfig.services.personalization.cacheId", this);
@@ -55,7 +55,7 @@ sap.ui.define([
         };
         this._oPropertyBag = {};
         this._aOperationQueue = [];
-    };
+    }
 
     /**
      * Resets the container item values to initial ( retaining key, validity, etc!)
@@ -200,8 +200,8 @@ sap.ui.define([
     };
 
     /**
-     * Locates an item for the key sItemKey,
-     * returns { index : nr,  TrueItemKey : truekey,  containerProperty : }
+     * @param {string} sItemKey - The item key.
+     * @returns {{index: int, TrueItemKey: string, containerProperty: string}} An object containing match details.
      * either trueKey xor containerProperty is set.
      * index is filled iff it is a present item
      */
@@ -299,6 +299,8 @@ sap.ui.define([
     /**
      * set oItemValue under sItemKey
      * returns undefined
+     * @param {string} sItemKey the item key
+     * @param {object} oItemValue the item value to be set
      */
     AdapterContainer.prototype.setItemValue = function (sItemKey, oItemValue) {
         const sItemValue = JSON.stringify(oItemValue);
@@ -332,6 +334,7 @@ sap.ui.define([
 
     /**
      * delete (1st) item with key sItemKey
+     * @param {string} sItemKey the item key
      */
     AdapterContainer.prototype.delItem = function (sItemKey) {
         const oItemRef = this._locateItem(sItemKey);

package/src/main/js/sap/ushell_abap/adapters/abap/AppStateAdapter.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview The Unified Shell's AppStateAdapter for the ABAP platform.
- * @version 1.139.0
+ * @version 1.140.0
  */
 sap.ui.define([
     "sap/base/util/ObjectPath",
@@ -38,7 +38,7 @@ sap.ui.define([
      *
      * @private
      */
-    const AppStateAdapter = function (oSystem, sParameters, oConfig) {
+    function AppStateAdapter (oSystem, sParameters, oConfig) {
         this._oConfig = oConfig && oConfig.config;
         const sAppStateServiceURL = `${ObjectPath.get("services.appState.baseUrl", oConfig) || "/sap/opu/odata/UI2/INTEROP"}/`;
         const oODataWrapperSettings = {
@@ -51,7 +51,7 @@ sap.ui.define([
             throw new SrvcError(oMessage, "sap.ushell_abap.adapters.abap.AppStateAdapter");
         }
         ODataService.call(this, this._oWrapper, fnDefaultFailure);
-    };
+    }
 
     /**
      * Save the given data sValue for the given key at the persistence layer

package/src/main/js/sap/ushell_abap/adapters/abap/ClientSideTargetResolutionAdapter.js

@@ -9,7 +9,7 @@
  *     <li>provide the resolveHashFragmentFallback function, a fallback method called by ClientSideTargetResolution service.</li>
  *   </ul>
  *
- * @version 1.139.0
+ * @version 1.140.0
  */
 sap.ui.define([
     "sap/base/util/ObjectPath",
@@ -106,7 +106,7 @@ sap.ui.define([
      * @since 1.34.0
      * @private
      */
-    const ClientSideTargetResolutionAdapter = function (oSystem, sParameters, oAdapterConfig) {
+    function ClientSideTargetResolutionAdapter (oSystem, sParameters, oAdapterConfig) {
         const that = this;
         // as the method getProductVersion returns the product name, the following holds true.
         const oContainer = Container;
@@ -287,7 +287,7 @@ sap.ui.define([
             );
             that._storeFromFullStartupResponse(oFullStartupResult);
         });
-    };
+    }
 
     /**
      * Checks the Resolve Link/Start Up result for Application Dependencies and if present modifies the results
@@ -871,9 +871,7 @@ sap.ui.define([
         }
 
         oODataResponse.results.forEach((oEntry) => {
-            let oParam;
             const sEntryName = oEntry.name;
-            let sEntryValue;
             let sUserDefaultValue;
 
             if (Object.prototype.hasOwnProperty.call(oRes.parameters, sEntryName)) {
@@ -886,8 +884,8 @@ sap.ui.define([
                 required: that._getObjectDefaulting(oEntry, "required", false)
             };
 
-            oParam = oRes.parameters[sEntryName];
-            sEntryValue = that._getObjectDefaulting(oEntry, "value", "");
+            const oParam = oRes.parameters[sEntryName];
+            const sEntryValue = that._getObjectDefaulting(oEntry, "value", "");
 
             if (oEntry.regexp === true) {
                 oParam.filter = {
@@ -1131,7 +1129,6 @@ sap.ui.define([
      */
     ClientSideTargetResolutionAdapter.prototype._resolveHashFragmentBE = function (sFragmentNoHash) {
         const that = this;
-        let bBatchQueueOpened;
         const sFormFactor = Utils.getFormFactor();
 
         /**
@@ -1147,7 +1144,7 @@ sap.ui.define([
             return encodeURIComponent(sUnencoded).replace(/'/g, "''");
         }
 
-        bBatchQueueOpened = this._openBatchQueueUnlessOpen(this._getODataWrapper());
+        const bBatchQueueOpened = this._openBatchQueueUnlessOpen(this._getODataWrapper());
 
         /**
          * Adds the given post parameters to a url
@@ -1324,6 +1321,45 @@ sap.ui.define([
 
         // check if we have it already
         return new Promise((fnResolve, fnReject) => {
+            /*
+             * Trigger call to front-end server. This case may occur, for example, during application direct start with
+             * a system alias that is not sent by the backend. Backend only sends data about the system aliases that are
+             * mentioned in the systemAlias fields of the target mappings (or for virtual target mappings).
+             */
+            function fnRetryBufferOrUseInterop () {
+                oSystemAliasData = that._readSystemAliasFromBuffer(sSystemAlias); // note: already in ClientSideTargetResolutionAdapter format
+                if (oSystemAliasData) {
+                    Log.debug(
+                        `System alias '${sSystemAlias}' is now in buffer`,
+                        "Skipping INTEROP service call",
+                        "sap.ushell_abap.adapters.abap.ClientSideTargetResolutionAdapter"
+                    );
+                    fnResolve(oSystemAliasData);
+                } else {
+                    Log.debug(
+                        `System alias '${sSystemAlias}' still not in buffer`,
+                        "Resolving via INTEROP service",
+                        "sap.ushell_abap.adapters.abap.ClientSideTargetResolutionAdapter"
+                    );
+                    that._readSystemAliasViaInterop(sSystemAlias)
+                        .catch((sError) => {
+                            fnReject(sError);
+                        })
+                        .then((oOdataSystemAliasData) => {
+                            oSystemAliasData = that._fixSystemAlias(oOdataSystemAliasData);
+
+                            if (oSystemAliasData && oSystemAliasData.id) {
+                                that._writeSystemAliasToBuffer(oSystemAliasData);
+                                fnResolve(oSystemAliasData);
+                            } else {
+                                sMessage = "Data returned for system alias is not valid. Has no 'id'. System alias data will not be cached.";
+                                Log.warning(`ClientSideTargetResolutionAdapter: ${sMessage}`);
+                                fnResolve(oSystemAliasData);
+                            }
+                        });
+                }
+            }
+
             oSystemAliasData = this._readSystemAliasFromBuffer(sSystemAlias); // note: already in ClientSideTargetResolutionAdapter format
             if (oSystemAliasData) {
                 Log.debug(
@@ -1343,45 +1379,6 @@ sap.ui.define([
 
                 // must wait at least on the small start_up response before using INTEROP
 
-                /*
-                 * Trigger call to front-end server. This case may occur, for example, during application direct start with
-                 * a system alias that is not sent by the backend. Backend only sends data about the system aliases that are
-                 * mentioned in the systemAlias fields of the target mappings (or for virtual target mappings).
-                 */
-                const fnRetryBufferOrUseInterop = function () {
-                    oSystemAliasData = that._readSystemAliasFromBuffer(sSystemAlias); // note: already in ClientSideTargetResolutionAdapter format
-                    if (oSystemAliasData) {
-                        Log.debug(
-                            `System alias '${sSystemAlias}' is now in buffer`,
-                            "Skipping INTEROP service call",
-                            "sap.ushell_abap.adapters.abap.ClientSideTargetResolutionAdapter"
-                        );
-                        fnResolve(oSystemAliasData);
-                    } else {
-                        Log.debug(
-                            `System alias '${sSystemAlias}' still not in buffer`,
-                            "Resolving via INTEROP service",
-                            "sap.ushell_abap.adapters.abap.ClientSideTargetResolutionAdapter"
-                        );
-                        that._readSystemAliasViaInterop(sSystemAlias)
-                            .catch((sError) => {
-                                fnReject(sError);
-                            })
-                            .then((oOdataSystemAliasData) => {
-                                oSystemAliasData = that._fixSystemAlias(oOdataSystemAliasData);
-
-                                if (oSystemAliasData && oSystemAliasData.id) {
-                                    that._writeSystemAliasToBuffer(oSystemAliasData);
-                                    fnResolve(oSystemAliasData);
-                                } else {
-                                    sMessage = "Data returned for system alias is not valid. Has no 'id'. System alias data will not be cached.";
-                                    Log.warning(`ClientSideTargetResolutionAdapter: ${sMessage}`);
-                                    fnResolve(oSystemAliasData);
-                                }
-                            });
-                    }
-                };
-
                 this._oInitialSegmentPromise.then(fnRetryBufferOrUseInterop, fnRetryBufferOrUseInterop);
             }
         });

package/src/main/js/sap/ushell_abap/adapters/abap/CommonDataModelAdapter.js

@@ -2,7 +2,7 @@
 /**
  * @fileOverview The Unified Shell's CommonDataModelAdapter for the ABAP platform, it is used to avoid 404 when no adapter is found
  *
- * @version 1.139.0
+ * @version 1.140.0
  */
 sap.ui.define([
 ], () => {

package/src/main/js/sap/ushell_abap/adapters/abap/ConfigurationDefaultsAdapter.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview The ConfigurationDefaults adapter for the ABAP platform.
- * @version 1.139.0
+ * @version 1.140.0
  */
 sap.ui.define([
     "sap/ushell_abap/bootstrap/evo/abap.constants",
@@ -11,7 +11,6 @@ sap.ui.define([
     "use strict";
 
     /**
-     * @returns {sap.ushell_abap.adapters.abap.ConfigurationDefaultsAdapter}
      * @private
      */
     return function () {

package/src/main/js/sap/ushell_abap/adapters/abap/ContainerAdapter.js

@@ -2,7 +2,7 @@
 /**
  * @fileOverview The Unified Shell's container adapter for the ABAP platform.
  *
- * @version 1.139.0
+ * @version 1.140.0
  */
 sap.ui.define([
     "sap/ui/thirdparty/jquery",
@@ -42,6 +42,8 @@ sap.ui.define([
      * Constructs a new instance of the container adapter for the ABAP platform.
      *
      * @param {sap.ushell.System} oSystem the logon system (alias, platform, base URL)
+     * @param {string} sParameter  the parameter to be passed to the container adapter
+     * @param {object} oProperties the properties to be passed to the container adapter, e.g. the configuration
      *
      * @hideconstructor
      * @see sap.ushell.services.initializeContainer
@@ -49,7 +51,7 @@ sap.ui.define([
      * @since 1.11.0
      * @private
      */
-    const ContainerAdapter = function (oSystem, sParameter, oProperties) {
+    function ContainerAdapter (oSystem, sParameter, oProperties) {
         let oUser;
         const S_LOGOFF_URL = "/sap/public/bc/icf/logoff";
 
@@ -78,7 +80,7 @@ sap.ui.define([
                 oFrame.setAttribute("src", sUrl);
 
                 function onload () {
-                    parent.postMessage(sSafeUrl, "*");
+                    window.parent.postMessage(sSafeUrl, "*");
                 }
 
                 oFrame.addEventListener("load", onload);
@@ -129,9 +131,7 @@ sap.ui.define([
         // startup result (modified!)
         this._setThemeAccessibilityFlags = function (oStartupResult) {
             if (oStartupResult.userProfile && oStartupResult.userProfile.length) {
-                let oUserProfileDataTheme;
-                let oUserProfileDataAccessibility;
-                oUserProfileDataTheme = oStartupResult.userProfile.filter((profileProperty) => {
+                const oUserProfileDataTheme = oStartupResult.userProfile.filter((profileProperty) => {
                     return profileProperty.id && profileProperty.id === "THEME";
                 })[0];
                 // Theme
@@ -145,7 +145,7 @@ sap.ui.define([
                 }
                 // AccessibilityPermitted: Note: we only register whether editing the Accessibility is allowed on the
                 // ABAP Platform, we don't test whether accessibility is available!
-                oUserProfileDataAccessibility = oStartupResult.userProfile.filter((profileProperty) => {
+                const oUserProfileDataAccessibility = oStartupResult.userProfile.filter((profileProperty) => {
                     return profileProperty.id && profileProperty.id === "ACCESSIBILITY";
                 })[0];
                 if (oUserProfileDataAccessibility && oUserProfileDataAccessibility.id) {
@@ -540,7 +540,7 @@ sap.ui.define([
             }
             return sUrl;
         };
-    };
+    }
 
     return ContainerAdapter;
 });

package/src/main/js/sap/ushell_abap/adapters/abap/FlpLaunchPageAdapter.js

@@ -3,7 +3,7 @@
 /**
  * @fileoverview The Unified Shell's page building adapter for the ABAP platform. Private copy. Classical home page functions are deprecated.
  * @since 1.121
- * @version 1.139.0
+ * @version 1.140.0
  */
 sap.ui.define([
     "sap/ui/thirdparty/URI",
@@ -78,7 +78,7 @@ sap.ui.define([
      * @since 1.121.0
      * @private
      */
-    const LaunchPageAdapter = function (oUnused, sParameter, oAdapterConfiguration) {
+    function LaunchPageAdapter (oUnused, sParameter, oAdapterConfiguration) {
         let bCatalogsValid; // undefined = not yet valid
         let oGetGroupsDeferred; // used to synchronize parallel getGroups-requests
         let oGetCatalogsDeferred; // used to synchronize parallel getCatalog-requests
@@ -188,6 +188,8 @@ sap.ui.define([
          *
          * @param {object} [oConfiguration] object containing an order array, example: {order: ["id1", "id2", "id3"]}
          * @param {object[]} aElements array of objects. Each object must provide a getId method
+         *
+         * @returns {object[]} array of elements ordered according to the configuration
          * @private
          * @since 1.11.0
          * @deprecated since 1.120
@@ -226,6 +228,24 @@ sap.ui.define([
             return aOrderedElements;
         };
 
+        /**
+         * Removes vValue from the given array.
+         *
+         * @param {Array<*>} aArray The array from which the value should be removed from.
+         * @param {any} vValue The value to be removed.
+         * @returns {int} The index of the vValue in the array or -1 if it was not found.
+         * @private
+         * @deprecated since 1.120
+         */
+        function removeFromArray (aArray, vValue) {
+            const iSourceIndex = aArray.indexOf(vValue);
+            if (iSourceIndex < 0) {
+                return iSourceIndex;
+            }
+            aArray.splice(iSourceIndex, 1);
+            return iSourceIndex;
+        }
+
         /**
          * Removes the given tile from the given Page layout, according to it's current type.
          *
@@ -249,24 +269,6 @@ sap.ui.define([
             return removeFromArray(oLayout.order, oTile.getId());
         }
 
-        /**
-         * Removes vValue from the given array.
-         *
-         * @param {Array<*>} aArray The array from which the value should be removed from.
-         * @param {any} vValue The value to be removed.
-         * @returns {int} The index of the vValue in the array or -1 if it was not found.
-         * @private
-         * @deprecated since 1.120
-         */
-        function removeFromArray (aArray, vValue) {
-            const iSourceIndex = aArray.indexOf(vValue);
-            if (iSourceIndex < 0) {
-                return iSourceIndex;
-            }
-            aArray.splice(iSourceIndex, 1);
-            return iSourceIndex;
-        }
-
         /**
          * Adds the given tile ID to the given Page layout in the specified index and according to it's current type.
          *
@@ -332,7 +334,7 @@ sap.ui.define([
         /**
          * Orders the pages of _oCurrentPageSet based on the configuration maintained in _oCurrentPageSet and returns the result.
          *
-         * @returns {sap.ushell_abap.pbServices.ui2.Page[]}
+         * @returns {sap.ushell_abap.pbServices.ui2.Page[]} Returns a UI2 Page
          * @private
          * @deprecated since 1.120
          */
@@ -414,6 +416,7 @@ sap.ui.define([
          * Triggers loading of a CHIP instance and adds the temporary property $loadingPromise to it
          * as it does not wait for the loading success or failure.
          * As soon as it is completely loaded (or loading failed) the $loadingPromise property is removed again.
+         * @param {object} oChipInstance the CHIP instance to be loaded
          * @deprecated since 1.120
          */
         LaunchPageAdapter.prototype._triggerChipInstanceLoad = function (oChipInstance) {
@@ -438,6 +441,49 @@ sap.ui.define([
             oChipInstance.load(fnSuccess, fnFailure);
         };
 
+        /**
+         * Tells whether the given CHIP instance is a static or dynamic app launcher
+         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance the chip instance
+         * @returns {boolean} true if the CHIP instance is an app launcher, false otherwise
+         */
+        function isAppLauncher (oChipInstance) {
+            const sBaseChipId = oChipInstance.getChip().getBaseChipId();
+            return sBaseChipId === sDYNAMIC_BASE_CHIP_ID || sBaseChipId === sSTATIC_BASE_CHIP_ID;
+        }
+
+        /**
+         * Tells whether the given CHIP instance is a card
+         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance the chip instance
+         * @returns {boolean} true if the CHIP instance is a card, false otherwise
+         */
+        function isCard (oChipInstance) {
+            const sBaseChipId = oChipInstance.getChip().getBaseChipId();
+            return S_CARD_BASE_CHIP_ID === sBaseChipId;
+        }
+
+        /**
+         * Tells whether the given CHIP instance is remote
+         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance the chip instance
+         * @returns {boolean} true if the CHIP instance is remote, false otherwise
+         */
+        function isRemoteChipInstance (oChipInstance) {
+            return !!oChipInstance.getChip().getRemoteCatalog();
+        }
+
+        /**
+         * Tells whether the given CHIP instance is not loadable.
+         * This means it's data from the OData Service could not be loaded.
+         *
+         * Note: If this method returns false does not mean that the later loading will not fail
+         *
+         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance the chip instance
+         * @returns {boolean} true if the CHIP instance is not loadable, false otherwise
+         */
+        function isBrokenChip (oChipInstance) {
+            // alternative: !oChipInstance.getChip().isInitiallyDefined();
+            return !isRemoteChipInstance(oChipInstance) && oChipInstance.getChip().getBaseChipId() === undefined;
+        }
+
         /**
          * Triggers loading of all ChipInstances of the given pages and calls fnLocalChipsLoaded
          * when all local CHIP instances are completely loaded.
@@ -462,6 +508,7 @@ sap.ui.define([
             /**
              * Loads dependent libraries (core-ext-light for custom tiles and custom remote tiles)
              * and triggers the loading of the chip instances.
+             * @param {object} oChipInstance the CHIP instance to be loaded
              */
             function loadDependenciesAndTriggerChipInstanceLoad (oChipInstance) {
                 // append the promise for loading to the instance, but only as long as loading is
@@ -500,6 +547,7 @@ sap.ui.define([
 
             /**
              * loads a CHIP instance and triggers finalize() or reject afterwards
+             * @param {object} oChipInstance the CHIP instance to be loaded
              */
             function loadChipInstance (oChipInstance) {
                 function onLoad () {
@@ -630,8 +678,8 @@ sap.ui.define([
          * This is the case for the results of {@link #addTile}, but not for {@link #addBookmark}.
          * Such wrappers must be unwrapped by {@link #moveTile} or else the title becomes "hard coded" in the newly created CHIP instance.
          *
-         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oTile
-         * @returns {boolean}
+         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oTile the tile object
+         * @returns {boolean} true if the tile has a config
          * @deprecated since 1.120
          */
         LaunchPageAdapter.prototype._isWrapperOnly = function (oTile) {
@@ -700,49 +748,6 @@ sap.ui.define([
             return aWrappedCatalogs;
         }
 
-        /**
-         * Tells whether the given CHIP instance is a static or dynamic app launcher
-         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance
-         * @returns {boolean}
-         */
-        function isAppLauncher (oChipInstance) {
-            const sBaseChipId = oChipInstance.getChip().getBaseChipId();
-            return sBaseChipId === sDYNAMIC_BASE_CHIP_ID || sBaseChipId === sSTATIC_BASE_CHIP_ID;
-        }
-
-        /**
-         * Tells whether the given CHIP instance is a card
-         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance
-         * @returns {boolean}
-         */
-        function isCard (oChipInstance) {
-            const sBaseChipId = oChipInstance.getChip().getBaseChipId();
-            return S_CARD_BASE_CHIP_ID === sBaseChipId;
-        }
-
-        /**
-         * Tells whether the given CHIP instance is remote
-         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance
-         * @returns {boolean}
-         */
-        function isRemoteChipInstance (oChipInstance) {
-            return !!oChipInstance.getChip().getRemoteCatalog();
-        }
-
-        /**
-         * Tells whether the given CHIP instance is not loadable.
-         * This means it's data from the OData Service could not be loaded.
-         *
-         * Note: If this method returns false does not mean that the later loading will not fail
-         *
-         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance
-         * @returns {boolean}
-         */
-        function isBrokenChip (oChipInstance) {
-            // alternative: !oChipInstance.getChip().isInitiallyDefined();
-            return !isRemoteChipInstance(oChipInstance) && oChipInstance.getChip().getBaseChipId() === undefined;
-        }
-
         /**
          * Returns the tile configuration of the given (app launcher) CHIP instance.
          * It logs an error message if the tile configuration cannot be parsed.
@@ -920,7 +925,7 @@ sap.ui.define([
          * @private
          */
         this._parseReferenceLost = function (sReferenceLost) {
-            var sReferenceLostSafe = sReferenceLost || Object.prototype.toString.apply(sReferenceLostSafe);
+            const sReferenceLostSafe = sReferenceLost || "";
 
             if (!sReferenceLostSafe.match(/^Reference lost: Note \d+ Page.+\s,\sInstance ID.+$/)) {
                 Log.warning(
@@ -1078,7 +1083,7 @@ sap.ui.define([
                                 });
                                 break;
                             case O_ERROR_TYPES.emptyConfiguration:
-                                var sRawTileConfiguration = oChipInstance.getConfigurationParameter("tileConfiguration");
+                                const sRawTileConfiguration = oChipInstance.getConfigurationParameter("tileConfiguration");
                                 aResult.push({
                                     type: O_ERROR_TYPES.emptyConfiguration,
                                     chipInstanceId: oChipInstance.getId(),
@@ -1113,6 +1118,7 @@ sap.ui.define([
          * Formats information about one error into a string.
          *
          * @param {object} oTileError An object representing tile errors
+         * @returns {string} A string describing the error
          */
         this._formatTileError = function (oTileError) {
             switch (oTileError.type) {
@@ -2103,6 +2109,10 @@ sap.ui.define([
             const that = this;
             const oDeferred = new jQuery.Deferred();
 
+            function doReject (sMessage) {
+                oDeferred.reject(`Tile not successfully loaded${sMessage ? (`: ${sMessage}`) : ""}`);
+            }
+
             function doResolve () {
                 let sTileType;
 
@@ -2145,10 +2155,6 @@ sap.ui.define([
                     .catch(doReject);
             }
 
-            function doReject (sMessage) {
-                oDeferred.reject(`Tile not successfully loaded${sMessage ? (`: ${sMessage}`) : ""}`);
-            }
-
             if (!oTile.$loadingPromise) { // loading resolved or failed
                 if (!oTile.isStub()) { // success
                     // call getImplementationAsSapui5Async async for non-AppLaunchers and resolves.
@@ -2508,7 +2514,7 @@ sap.ui.define([
          * it might become <code>false</code> again in case one of the catalogs has been invalidated,
          * e.g. due to the addition of a tile ("Add to catalog" scenario).
          *
-         * @returns {boolean}
+         * @returns {boolean} if the catalogs collection is still valid, <code>false</code> otherwise.
          * @since 1.16.4
          * @deprecated since 1.120
          * @see #getCatalogs
@@ -2921,13 +2927,11 @@ sap.ui.define([
 
             // Apply the 'search' contract when available
             function getKeywordsFromSearchContract (oCatalogTile) {
-                let oSearchContract;
-
                 if (oCatalogTile.isStub()) {
                     return [];
                 }
 
-                oSearchContract = oCatalogTile.getContract("search");
+                const oSearchContract = oCatalogTile.getContract("search");
                 if (oSearchContract) {
                     return oSearchContract.getKeywords();
                 }
@@ -3312,9 +3316,9 @@ sap.ui.define([
         /**
          * Tells whether the given CHIP instance represents a bookmark matching the given identifier.
          *
-         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance
+         * @param {sap.ushell_abap.pbServices.ui2.ChipInstance} oChipInstance the CHIP instance to be checked
          * @param {string | object} vIdentifier the url as string or an identifier object
-         * @returns {boolean}
+         * @returns {boolean} If the CHIP instance represents a bookmark matching the given identifier.
          * @see #addBookmark
          * @since 1.17.1
          * @deprecated since 1.120
@@ -3722,7 +3726,7 @@ sap.ui.define([
         this.isCustomTile = function (tile) {
             return !isAppLauncher(tile);
         };
-    };
+    }
 
     /**
      * Returns raw catalog tile data that can be used to instantiate the tile

package/src/main/js/sap/ushell_abap/adapters/abap/LaunchPageAdapter.js

@@ -4,7 +4,7 @@
  * @fileOverview The Unified Shell's page building adapter for the ABAP platform.
  *
  * @deprecated since 1.100
- * @version 1.139.0
+ * @version 1.140.0
  */
 sap.ui.define([
     "sap/ushell_abap/adapters/abap/FlpLaunchPageAdapter"

package/src/main/js/sap/ushell_abap/adapters/abap/MenuAdapter.js

@@ -31,7 +31,7 @@ sap.ui.define([
      * @since 1.72.0
      * @private
      */
-    const MenuAdapter = function () { };
+    function MenuAdapter () { }
 
     /**
      * Returns whether the menu is enabled

package/src/main/js/sap/ushell_abap/adapters/abap/NavTargetResolutionAdapter.js

@@ -8,7 +8,7 @@
  * service now calls the ClientSideTargetResolution service in the ABAP
  * platform.
  *
- * @version 1.139.0
+ * @version 1.140.0
  */
 sap.ui.define([], () => {
     "use strict";