npm - @sapui5/sap.ushell - Versions diffs - 1.142.0 → 1.143.0 - Mend

@sapui5/sap.ushell 1.142.0 → 1.143.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (349) hide show

package/src/main/js/sap/ushell/components/pages/Component.js CHANGED Viewed

@@ -5,7 +5,7 @@
  * #Shell-home or #Launchpad-openFLPPage if spaces are enabled (/core/spaces/enabled).
  * In the future it should completely replace the classical homepage.
  *
- * @version 1.142.0
+ * @version 1.143.0
  */
 sap.ui.define([

package/src/main/js/sap/ushell/components/pages/MyHomeImport.js CHANGED Viewed

@@ -2,7 +2,7 @@
 /**
  * @fileOverview MyHome migrate functionality for the PageRuntime view
  *
- * @version 1.142.0
+ * @version 1.143.0
  */
 sap.ui.define([

package/src/main/js/sap/ushell/components/pages/controller/PageRuntime.controller.js CHANGED Viewed

@@ -2,7 +2,7 @@
 /**
  * @file PageRuntime controller for PageRuntime view
- * @version 1.142.0
+ * @version 1.143.0
  */
 sap.ui.define([
     "sap/ui/core/Element",
@@ -144,7 +144,7 @@ sap.ui.define([
             });
             const oRenderer = Container.getRendererInternal();
-            this.bIsHomeIntentRootIntent = ushellUtils.isFlpHomeIntent(oRenderer.getShellConfig().rootIntent);
+            this.bIsHomeIntentRootIntent = ushellUtils.isFlpHomeIntent(ushellUtils.getRootIntent());
             this.oErrorPage = this.byId("errorPage");
             this.oEmptyPage = this.byId("emptyPage");
             this.oPagesNavContainer = this.byId("pagesNavContainer");

package/src/main/js/sap/ushell/components/pages/controller/PagesAndSpaceId.js CHANGED Viewed

@@ -27,12 +27,12 @@ sap.ui.define([
             if (sShellHash === undefined) {
                 sShellHash = hasher.getHash();
             }
-            const oHash = urlParsingService.parseShellHash(sShellHash) || {};
+            const oParsedHash = urlParsingService.parseShellHash(sShellHash) || {};
             const oIntent = {
-                semanticObject: oHash.semanticObject || "",
-                action: oHash.action || ""
+                semanticObject: oParsedHash.semanticObject || "",
+                action: oParsedHash.action || ""
             };
-            const oHashPartsParams = oHash.params || {};
+            const oHashPartsParams = oParsedHash.params || {};
             const aPageId = oHashPartsParams.pageId || [];
             const aSpaceId = oHashPartsParams.spaceId || [];

package/src/main/js/sap/ushell/components/pages/manifest.json CHANGED Viewed

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.pages",
         "applicationVersion": {
-            "version": "1.142.0"
+            "version": "1.143.0"
         },
         "i18n": {
             "bundleUrl": "../../renderer/resources/resources.properties",

package/src/main/js/sap/ushell/components/runtimeSwitcher/controller/RuntimeSwitcher.controller.js CHANGED Viewed

@@ -2,7 +2,7 @@
 /**
  * @file RuntimeSwitcher's controller for RuntimeSwitcher's view
- * @version 1.142.0
+ * @version 1.143.0
  */
 sap.ui.define([
     "sap/ui/core/mvc/Controller",

package/src/main/js/sap/ushell/components/runtimeSwitcher/manifest.json CHANGED Viewed

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.runtimeSwitcher",
         "applicationVersion": {
-            "version": "1.142.0"
+            "version": "1.143.0"
         },
         "ach": "CA-FLP-FE-COR",
         "type": "component",

package/src/main/js/sap/ushell/components/shell/FloatingContainer/manifest.json CHANGED Viewed

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.shell.FloatingContainer",
         "applicationVersion": {
-            "version": "1.142.0"
+            "version": "1.143.0"
         },
         "i18n": {
             "bundleUrl": "../../../renderer/resources/resources.properties",

package/src/main/js/sap/ushell/components/shell/MenuBar/manifest.json CHANGED Viewed

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.shell.MenuBar",
         "applicationVersion": {
-            "version": "1.142.0"
+            "version": "1.143.0"
         },
         "i18n": {
             "bundleUrl": "../../../renderer/resources/resources.properties",

package/src/main/js/sap/ushell/components/shell/NavigationBarMenu/controller/NavigationBarMenu.controller.js CHANGED Viewed

@@ -4,7 +4,7 @@
  * @fileOverview Controller for the NavigationBarMenu Popover. It is responsible for Popover handling, model binding, persistence
  * logic to pin, unpin and rearrange pinned spaces as well as executing navigation.
  *
- * @version 1.142.0
+ * @version 1.143.0
  * @private
  */
 sap.ui.define([

package/src/main/js/sap/ushell/components/shell/NavigationBarMenu/controller/NavigationBarMenuButton.controller.js CHANGED Viewed

@@ -4,7 +4,7 @@
  * @fileOverview Controller for the NavigationBarMenu Popover. It is responsible for Popover handling, model binding, persistence
  * logic to pin, unpin and rearrange pinned spaces as well as executing navigation.
  *
- * @version 1.142.0
+ * @version 1.143.0
  * @private
  */
 sap.ui.define([

package/src/main/js/sap/ushell/components/shell/NavigationBarMenu/manifest.json CHANGED Viewed

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.shell.NavigationBarMenu",
         "applicationVersion": {
-            "version": "1.142.0"
+            "version": "1.143.0"
         },
         "i18n": {
             "bundleUrl": "../../../renderer/resources/resources.properties",

package/src/main/js/sap/ushell/components/shell/Notifications/Component.js CHANGED Viewed

@@ -53,7 +53,7 @@ sap.ui.define([
     return UIComponent.extend("sap.ushell.components.shell.Notifications.Component", {
         metadata: {
-            version: "1.142.0",
+            version: "1.143.0",
             library: "sap.ushell.components.shell.Notifications",
             dependencies: {
                 libs: ["sap.m"]

package/src/main/js/sap/ushell/components/shell/PostLoadingHeaderEnhancement/Component.js CHANGED Viewed

@@ -142,8 +142,8 @@ sap.ui.define([
             const { oldURL, newURL } = oHashChangeEvent;
             const sOldHash = UrlParsing.getHash(oldURL);
             const sNewHash = UrlParsing.getHash(newURL);
-            const sOldInnerAppRoute = UrlParsing.parseShellHash(sOldHash).appSpecificRoute;
-            const sNewInnerAppRoute = UrlParsing.parseShellHash(sNewHash).appSpecificRoute;
+            const sOldInnerAppRoute = UrlParsing.parseShellHash(sOldHash, true).appSpecificRoute;
+            const sNewInnerAppRoute = UrlParsing.parseShellHash(sNewHash, true).appSpecificRoute;
             const bInnerAppNavigationOccurred = sOldInnerAppRoute !== sNewInnerAppRoute;

package/src/main/js/sap/ushell/components/shell/ProductSwitch/Component.js CHANGED Viewed

@@ -41,7 +41,7 @@ sap.ui.define([
     return UIComponent.extend("sap.ushell.components.shell.ProductSwitch.Component", {
         metadata: {
-            version: "1.142.0",
+            version: "1.143.0",
             library: "sap.ushell.components.shell.ProductSwitch",
             dependencies: {
                 libs: {

package/src/main/js/sap/ushell/components/shell/Search/manifest.json CHANGED Viewed

@@ -4,7 +4,7 @@
         "id": "sap.ushell.components.shell.Search",
         "applicationVersion": {
-            "version": "1.142.0"
+            "version": "1.143.0"
         },
         "i18n": {
             "bundleUrl": "../../../renderer/resources/resources.properties",

package/src/main/js/sap/ushell/components/shell/SearchCEP/Component.js CHANGED Viewed

@@ -33,7 +33,7 @@ sap.ui.define([
     return UIComponent.extend("sap.ushell.components.shell.SearchCEP.Component", {
         metadata: {
-            version: "1.142.0",
+            version: "1.143.0",
             library: ["sap.ushell", "sap.ushell.components.shell"],
             dependencies: {
                 libs: ["sap.m"]

package/src/main/js/sap/ushell/components/shell/SearchCEP/SearchProviders/FrequentActivityProvider.js CHANGED Viewed

@@ -2,7 +2,7 @@
 /**
  * @fileOverview
- * @version 1.142.0
+ * @version 1.143.0
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/components/shell/SearchCEP/SearchProviders/RecentSearchProvider.js CHANGED Viewed

@@ -2,7 +2,7 @@
 /**
  * @fileOverview
- * @version 1.142.0
+ * @version 1.143.0
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/components/shell/SearchCEP/SearchProviders/SearchProvider.js CHANGED Viewed

@@ -2,7 +2,7 @@
 /**
  * @fileOverview This module is the search provider main interface
- * @version 1.142.0
+ * @version 1.143.0
  */
 sap.ui.define([
     "sap/ushell/resources",

package/src/main/js/sap/ushell/components/shell/SearchCEP/SearchProviders/SearchServiceProvider.js CHANGED Viewed

@@ -2,7 +2,7 @@
 /**
  * @fileOverview This module handles the navigation service search actions
- * @version 1.142.0
+ * @version 1.143.0
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/components/shell/SearchCEPNew/Component.js CHANGED Viewed

@@ -92,7 +92,9 @@ sap.ui.define([
             await this._initSearchField();
             this._registerHandleHashChange();
-            if (this._oShellHeader.isLargeState() || this._oShellHeader.isExtraLargeState()) {
+            const bIsInitiallyCollapsed = Config.last("/core/search/initiallyCollapsed");
+            if (!bIsInitiallyCollapsed && (this._oShellHeader.isLargeState() || this._oShellHeader.isExtraLargeState())) {
                 this._fetchSuggestions();
                 this._toggleSearchFieldInput(true);
             }

package/src/main/js/sap/ushell/components/shell/SearchCEPNew/SearchProviders/FrequentActivityProvider.js CHANGED Viewed

@@ -2,7 +2,7 @@
 /**
  * @fileOverview
- * @version 1.142.0
+ * @version 1.143.0
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/components/shell/SearchCEPNew/SearchProviders/RecentSearchProvider.js CHANGED Viewed

@@ -2,7 +2,7 @@
 /**
  * @fileOverview
- * @version 1.142.0
+ * @version 1.143.0
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/components/shell/SearchCEPNew/SearchProviders/SearchProvider.js CHANGED Viewed

@@ -2,7 +2,7 @@
 /**
  * @fileOverview This module is the search provider main interface
- * @version 1.142.0
+ * @version 1.143.0
  */
 sap.ui.define([
     "sap/ushell/components/shell/SearchCEPNew/SearchProviders/FrequentActivityProvider",

package/src/main/js/sap/ushell/components/shell/SearchCEPNew/SearchProviders/SearchServiceProvider.js CHANGED Viewed

@@ -2,7 +2,7 @@
 /**
  * @fileOverview This module handles the navigation service search actions
- * @version 1.142.0
+ * @version 1.143.0
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/components/shell/SearchCEPNew/manifest.json CHANGED Viewed

@@ -6,7 +6,7 @@
         "title": "SearchCEPNew",
         "ach": "CA-FLP-FE-UI",
         "applicationVersion": {
-            "version": "1.142.0"
+            "version": "1.143.0"
         }
     },
     "sap.ui": {

package/src/main/js/sap/ushell/components/shell/Settings/Component.js CHANGED Viewed

@@ -47,7 +47,7 @@ sap.ui.define([
     return UIComponent.extend("sap.ushell.components.shell.Settings.Component", {
         metadata: {
-            version: "1.142.0",
+            version: "1.143.0",
             library: "sap.ushell",
             dependencies: {
                 libs: {

package/src/main/js/sap/ushell/components/shell/Settings/appearance/Appearance.controller.js CHANGED Viewed

@@ -43,6 +43,8 @@ sap.ui.define([
 ) => {
     "use strict";
+    const sGroupKeySeparator = "###";
     return Controller.extend("sap.ushell.components.shell.Settings.appearance.Appearance", {
         TILE_SIZE: {
             Small: 0,
@@ -93,7 +95,7 @@ sap.ui.define([
         // Group header text for a set is a set label. Other themes not in a set are grouped under Individual Themes
         getThemeSetHeader: function (oGroup) {
-            const oSet = this.aThemeSets.find((set) => oGroup.key === set.id);
+            const oSet = this.aThemeSets.find((set) => oGroup.key?.split(sGroupKeySeparator)[2] === set.id);
             const sGroupTitle = oSet?.label || ushellResources.i18n.getText("AppearanceIndividualThemes");
             return new GroupHeaderListItem({ title: sGroupTitle });
         },
@@ -110,6 +112,30 @@ sap.ui.define([
             return this._getSelectedThemeData()?.id || this.oUser.getTheme();
         },
+        _getGroupKey: function (vendor, activationTime, setId) {
+            // we need to order and group ascending but descending by activation time. For the grouping, all the information
+            // must be present within one property. Hence, we invert the time value by subtracting it from the current time.
+            const sInvertedActivationTime = activationTime ? (new Date(Date.now() - new Date(activationTime))).getTime() : "";
+            if (!setId) {
+                if (this.aThemeSets?.length > 0) {
+                    // there is no set id but sets are supported in general. Hence, this is an individual theme.
+                    return [
+                        "individualThemes",
+                        sInvertedActivationTime,
+                        "" // setId
+                    ].join(sGroupKeySeparator);
+                }
+                // if there are no sets at all, do not group
+                return;
+            }
+            return [
+                (vendor === "SAP" ? "standardThemes" : "customThemes"),
+                sInvertedActivationTime,
+                setId
+            ].join(sGroupKeySeparator);
+        },
         // The main function. Builds the list of themes. Items are grouped by setId.
         _getThemeListData: function (sCurrentThemeId) {
             const aThemes = this.aThemeListFromServer || [];
@@ -132,7 +158,7 @@ sap.ui.define([
             this.bShowDeprecationMsg = false;
             // If the user is not allowed to change themes, return only the current theme
-            if (!this._isThemeCofigurable() || this.oUser.isSetThemePermitted() === false) {
+            if (!this._isThemeConfigurable() || this.oUser.isSetThemePermitted() === false) {
                 const oCurrentTheme = aThemes.find((theme) => theme?.id === sCurrentThemeId);
                 return [{
                     id: sCurrentThemeId,
@@ -163,7 +189,8 @@ sap.ui.define([
                         mode: "Image", // specific theme svg can be displayed with an img tag
                         deprecated: theme?.deprecated === true,
                         setId: set.id,
-                        isSelected: false
+                        isSelected: false,
+                        groupKey: this._getGroupKey(set?.vendor, set?.activationTime || set?.creationTime, set.id)
                     };
                     aListData.push(oItemData);
                 });
@@ -181,7 +208,8 @@ sap.ui.define([
                         mode: "InlineSvg", // combined svg files can be only shown with inline decomposition
                         deprecated: set.deprecated === true,
                         setId: set.id,
-                        isSelected: false
+                        isSelected: false,
+                        groupKey: this._getGroupKey(set?.vendor, set?.activationTime || set?.creationTime, set.id)
                     };
                     aListData.push(oItemData);
                 });
@@ -214,7 +242,7 @@ sap.ui.define([
             return aListData;
         },
-        _isThemeCofigurable: function () {
+        _isThemeConfigurable: function () {
             return Config.last("/core/shell/model/setTheme") !== false;
         },
@@ -229,7 +257,7 @@ sap.ui.define([
             const bDisplaySettingsTabVisible = bSizeBehaviorConfigurable || bContentDensityConfigurable || bShowContentProviderInfoConfigurable;
             const oConfigModel = new JSONModel({
-                themeConfigurable: this._isThemeCofigurable(),
+                themeConfigurable: this._isThemeConfigurable(),
                 sizeBehaviorConfigurable: bSizeBehaviorConfigurable,
                 tileSize: this.TILE_SIZE[Config.last("/core/home/sizeBehavior")],
                 contentDensityConfigurable: bContentDensityConfigurable,
@@ -246,7 +274,7 @@ sap.ui.define([
         getDarkModeModel: function () {
             const oUrlSearch = new URLSearchParams(window.location.search);
             const bDetectionSupported = !oUrlSearch.get("sap-theme") && !oUrlSearch.get("sap-ui-theme");
-            const bThemeConfigurable = this._isThemeCofigurable();
+            const bThemeConfigurable = this._isThemeConfigurable();
             const oDarkModeModel = new JSONModel({
                 enabled: bThemeConfigurable,

package/src/main/js/sap/ushell/components/shell/Settings/appearance/Appearance.view.xml CHANGED Viewed

@@ -17,7 +17,7 @@
                     items="{
                         path: '/options',
                         sorter: [{
-                            path: 'setId',
+                            path: 'groupKey',
                             descending: false,
                             group: true
                         }, {

package/src/main/js/sap/ushell/components/shell/ShellBar/Component.js CHANGED Viewed

@@ -5,6 +5,7 @@ sap.ui.define([
     "sap/ui/core/UIComponent",
     "sap/ui/Device",
     "sap/ui/model/json/JSONModel",
+    "sap/ushell/Config",
     "sap/ushell/Container",
     "sap/ushell/EventHub",
     "sap/ushell/renderer/ShellLayout",
@@ -14,6 +15,7 @@ sap.ui.define([
     UIComponent,
     Device,
     JSONModel,
+    Config,
     Container,
     EventHub,
     ShellLayout,
@@ -50,14 +52,6 @@ sap.ui.define([
         init: function () {
             // Call the init function of the parent
             UIComponent.prototype.init.apply(this, arguments);
-            const oModel = new JSONModel({
-                logo: {},
-                searchField: {
-                    show: false
-                }
-            });
-            this.setModel(oModel);
             this.FLPRangeSet = {
                 name: "Ushell",
                 rangeBorders: [600, 1024, 1440, 1920],
@@ -70,6 +64,14 @@ sap.ui.define([
                 this.FLPRangeSet.rangeNames
             );
+            const oModel = new JSONModel({
+                logo: {},
+                searchField: {
+                    show: (this.isLargeState() || this.isExtraLargeState()) && !Config.last("/core/search/initiallyCollapsed") && Config.last("/core/search/useWebComponents")
+                }
+            });
+            this.setModel(oModel);
             // handle initial state of the side content
             const bInitialValue = ShellLayout.hasAdjacentSideContentBeforeMain();
             ushellUtils.applySideContent.call(this, bInitialValue);
@@ -111,7 +113,10 @@ sap.ui.define([
                 const bShow = (sStateName !== "COL");
                 this.getModel().setProperty("/searchField/show", bShow);
-                document.body.classList.toggle(sSearchOverlayCSS, bShow && bWithOverlay);
+                if (!Config.last("/core/search/useWebComponents")) {
+                    document.body.classList.toggle(sSearchOverlayCSS, bShow && bWithOverlay);
+                }
                 // save for animation after rendering
                 _iSearchWidth = bShow ? iMaxRemSize || 35 : 0;

package/src/main/js/sap/ushell/components/shell/ShellBar/controller/ShellBar.controller.js CHANGED Viewed

@@ -17,7 +17,7 @@ sap.ui.define([
     "sap/ushell/state/modules/BackNavigation",
     "sap/ushell/state/ShellModel",
     "sap/ushell/ui/shell/ShellAppTitle",
-    "sap/ushell/utils"
+    "sap/ushell/utils/UrlParsing"
 ], (
     Device,
     Element,
@@ -36,7 +36,7 @@ sap.ui.define([
     BackNavigation,
     ShellModel,
     ShellAppTitle,
-    ushellUtils
+    UrlParsing
 ) => {
     "use strict";
@@ -228,7 +228,8 @@ sap.ui.define([
         _updateHomeUri: function (sHomeUri) {
             const oModel = this.getOwnerComponent().getModel();
             oModel.setProperty("/logo/homeUri", sHomeUri);
-            oModel.setProperty("/logo/isRootIntent", ushellUtils.isRootIntent(sHomeUri));
+            const oParsedHash = UrlParsing.parseShellHash(sHomeUri, true);
+            oModel.setProperty("/logo/isRootIntent", UrlParsing.isRootIntent(oParsedHash));
         },
         pressNavBackButton: async function () {

package/src/main/js/sap/ushell/components/shell/ShellBar/manifest.json CHANGED Viewed

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.shell.ShellBar",
         "applicationVersion": {
-            "version": "1.142.0"
+            "version": "1.143.0"
         },
         "type": "component",
         "ach": "CA-FLP-FE-COR",

package/src/main/js/sap/ushell/components/shell/SideNavigation/manifest.json CHANGED Viewed

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.shell.SideNavigation",
         "applicationVersion": {
-            "version": "1.142.0"
+            "version": "1.143.0"
         },
         "i18n": {
             "bundleUrl": "./resources/resources.properties",

package/src/main/js/sap/ushell/components/shell/UserActionsMenu/Component.js CHANGED Viewed

@@ -14,7 +14,7 @@ sap.ui.define([
     return UIComponent.extend("sap.ushell.components.shell.UserActionsMenu.Component", {
         metadata: {
-            version: "1.142.0",
+            version: "1.143.0",
             library: "sap.ushell",
             dependencies: {
                 libs: ["sap.m"]

package/src/main/js/sap/ushell/components/shell/UserImage/Component.js CHANGED Viewed

@@ -39,7 +39,7 @@ sap.ui.define([
     return UIComponent.extend("sap.ushell.components.shell.UserImage.Component", {
         metadata: {
-            version: "1.142.0",
+            version: "1.143.0",
             library: "sap.ushell.components.shell.UserImage",
             dependencies: {
                 libs: {

package/src/main/js/sap/ushell/components/tiles/applauncher/StaticTile.controller.js CHANGED Viewed

@@ -52,18 +52,18 @@ sap.ui.define([
             const oConfig = tileUtils.getAppLauncherConfig(oTileApi, oTileApi.configurationUi.isEnabled(), false);
             const that = this;
             let sNavigationTargetUrl = oConfig.navigation_target_url;
-            let oHash;
+            let oParsedHash;
             const sSystem = oTileApi.url.getApplicationSystem();
             if (sSystem) { // propagate system to target application
                 // when the navigation url is hash we want to make sure system parameter is in the parameters part
                 if (UrlParsing.isIntentUrl(sNavigationTargetUrl)) {
-                    oHash = UrlParsing.parseShellHash(sNavigationTargetUrl);
-                    if (!oHash.params) {
-                        oHash.params = {};
+                    oParsedHash = UrlParsing.parseShellHash(sNavigationTargetUrl);
+                    if (!oParsedHash.params) {
+                        oParsedHash.params = {};
                     }
-                    oHash.params["sap-system"] = sSystem;
-                    sNavigationTargetUrl = `#${UrlParsing.constructShellHash(oHash)}`;
+                    oParsedHash.params["sap-system"] = sSystem;
+                    sNavigationTargetUrl = `#${UrlParsing.constructShellHash(oParsedHash)}`;
                 } else {
                     sNavigationTargetUrl += `${(sNavigationTargetUrl.indexOf("?") < 0) ? "?" : "&"}sap-system=${sSystem}`;
                 }

package/src/main/js/sap/ushell/components/tiles/applauncherdynamic/DynamicTile.controller.js CHANGED Viewed

@@ -61,18 +61,18 @@ sap.ui.define([
         REFRESH_INTERVAL_MIN: 10,
         constructTargetUrlWithSapSystem: function (sNavigationTargetUrl, sSystem) {
-            let oHash;
+            let oParsedHash;
             if (sSystem) { // propagate system to target application
                 // when the navigation url is hash we want to make sure system parameter is in the parameters part
                 // BCP 1780450594
                 if (UrlParsing.isIntentUrl(sNavigationTargetUrl)) {
-                    oHash = UrlParsing.parseShellHash(sNavigationTargetUrl);
-                    if (!oHash.params) {
-                        oHash.params = {};
+                    oParsedHash = UrlParsing.parseShellHash(sNavigationTargetUrl);
+                    if (!oParsedHash.params) {
+                        oParsedHash.params = {};
                     }
-                    oHash.params["sap-system"] = sSystem;
-                    sNavigationTargetUrl = `#${UrlParsing.constructShellHash(oHash)}`;
+                    oParsedHash.params["sap-system"] = sSystem;
+                    sNavigationTargetUrl = `#${UrlParsing.constructShellHash(oParsedHash)}`;
                 } else {
                     sNavigationTargetUrl += `${(sNavigationTargetUrl.indexOf("?") < 0) ? "?" : "&"}sap-system=${sSystem}`;
                 }

package/src/main/js/sap/ushell/components/tiles/cdm/applauncher/StaticTile.controller.js CHANGED Viewed

@@ -196,17 +196,17 @@ sap.ui.define([
         _createTargetUrl: function () {
             let sTargetURL = this.getView().getViewData().properties.targetURL;
             const sSystem = this.getView().getViewData().configuration["sap-system"];
-            let oHash;
+            let oParsedHash;
             if (sTargetURL && sSystem) {
                 // when the navigation url is hash we want to make sure system parameter is in the parameters part
                 if (UrlParsing.isIntentUrl(sTargetURL)) {
-                    oHash = UrlParsing.parseShellHash(sTargetURL);
-                    if (!oHash.params) {
-                        oHash.params = {};
+                    oParsedHash = UrlParsing.parseShellHash(sTargetURL);
+                    if (!oParsedHash.params) {
+                        oParsedHash.params = {};
                     }
-                    oHash.params["sap-system"] = sSystem;
-                    sTargetURL = `#${UrlParsing.constructShellHash(oHash)}`;
+                    oParsedHash.params["sap-system"] = sSystem;
+                    sTargetURL = `#${UrlParsing.constructShellHash(oParsedHash)}`;
                 } else {
                     sTargetURL += `${(sTargetURL.indexOf("?") < 0) ? "?" : "&"}sap-system=${sSystem}`;
                 }