@sapui5/sap.ushell 1.140.0 → 1.141.0

package/src/main/js/sap/ushell/ui/QuickAccess.js

@@ -107,27 +107,25 @@ sap.ui.define([
 
             const oUserRecentsService = await Container.getServiceAsync("UserRecents");
             const aRecentActivities = await new Promise((resolve) => {
-                oUserRecentsService.getRecentActivity().then(
-                    (aActivities) => {
+                oUserRecentsService.getRecentActivity()
+                    .then((aActivities) => {
                         resolve(aActivities.map((oActivity) => {
                             oActivity.timestamp = utils.formatDate(oActivity.timestamp);
                             return oActivity;
                         }));
-                    },
-                    () => {
+                    })
+                    .catch(() => {
                         resolve([]);
-                    }
-                );
+                    });
             });
             const aFrequentActivities = await new Promise((resolve) => {
-                oUserRecentsService.getFrequentActivity().then(
-                    (aActivity) => {
+                oUserRecentsService.getFrequentActivity()
+                    .then((aActivity) => {
                         resolve(aActivity);
-                    },
-                    () => {
+                    })
+                    .catch(() => {
                         resolve([]);
-                    }
-                );
+                    });
             });
 
             this.oModel.setData({

package/src/main/js/sap/ushell/ui/ShellHeader.js

@@ -572,11 +572,11 @@ sap.ui.define([
         // restore all hidden elements to unhide some or all of them when the user makes the window wider
         oBeginContainer.style.flexBasis = "";
         oEndContainer.style.display = "";
-        aElements.forEach((e) => {
-            if (e.getAttribute("id") === "shellAppTitle") {
-                e.classList.remove("sapUiPseudoInvisibleText");
+        aElements.forEach((oElement) => {
+            if (oElement.getAttribute("id") === "shellAppTitle") {
+                oElement.classList.remove("sapUiPseudoInvisibleText");
             } else {
-                e.style.display = "";
+                oElement.style.display = "";
             }
         });
 

package/src/main/js/sap/ushell/ui/appfinder/AppBoxInternal.js

@@ -150,9 +150,9 @@ sap.ui.define([
     // browser events
     AppBoxInternal.prototype.onclick = AppBoxInternal.prototype.firePress;
 
-    AppBoxInternal.prototype.onsapspace = function (e) {
-        e.preventDefault();
-        this.firePress(e);
+    AppBoxInternal.prototype.onsapspace = function (oEvent) {
+        oEvent.preventDefault();
+        this.firePress(oEvent);
     };
 
     AppBoxInternal.prototype.onsapenter = AppBoxInternal.prototype.onsapspace;

package/src/main/js/sap/ushell/ui/cards/RecentActivitiesExtension.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview Extension for recent activities card
  *
- * @version 1.140.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/ui/integration/Extension",

package/src/main/js/sap/ushell/ui/footerbar/AboutDialog.controller.js

@@ -85,8 +85,8 @@ sap.ui.define([
             const oAboutDialog = this._getDialog();
 
             // application info
-            this._setupAppInfoModel().catch((error) => {
-                Log.error("Failed to setup application info model.", error);
+            this._setupAppInfoModel().catch((oError) => {
+                Log.error("Failed to setup application info model.", oError);
             });
             // system information
             const oSystemInformation = this._getSystemInformation();
@@ -239,8 +239,8 @@ sap.ui.define([
                         oAboutDialog.setModel(new JSONModel(oApplicationInformation), "AppInfo");
                         resolve();
                     })
-                    .catch((error) => {
-                        reject(error);
+                    .catch((oError) => {
+                        reject(oError);
                     });
             });
         },

package/src/main/js/sap/ushell/ui/footerbar/AddBookmarkButton.js

@@ -480,11 +480,11 @@ sap.ui.define([
                         status: "resolved"
                     };
                 })
-                .catch((sMsg) => {
-                    Log.error("Failed to add one a bookmark: ", sMsg, "sap.ushell.ui.footerbar.AddBookmarkButton");
+                .catch((oError) => {
+                    Log.error("Failed to add one a bookmark: ", oError, "sap.ushell.ui.footerbar.AddBookmarkButton");
                     return {
                         pageId: oContentNode.id,
-                        error: sMsg,
+                        error: oError.message,
                         status: "failed"
                     };
                 });
@@ -577,7 +577,7 @@ sap.ui.define([
      * @returns {Promise} A promise which resolves on success
      * @deprecated since 1.118.
      */
-    AddBookmarkButton.prototype._handleOKButtonPressClassicMode = function () {
+    AddBookmarkButton.prototype._handleOKButtonPressClassicMode = async function () {
         const oBookmarkTileView = this.getBookmarkTileView();
         const oBookmarkTileController = oBookmarkTileView.getController();
         const oBookmarkData = oBookmarkTileController.getBookmarkTileData();
@@ -587,7 +587,7 @@ sap.ui.define([
             if (oTitle) {
                 oTitle.setValueState(ValueState.Error);
                 oTitle.setValueStateText(ushellResources.i18n.getText("bookmarkTitleInputError"));
-                return Promise.reject();
+                throw new Error("Invalid bookmark title");
             }
         }
         this.oDialog.setBusy(true);
@@ -607,8 +607,8 @@ sap.ui.define([
                 .then(() => {
                     oMessageService.info(ushellResources.i18n.getText("tile_created_msg"));
                 })
-                .catch((sMsg) => {
-                    Log.error("Failed to add bookmark", sMsg, "sap.ushell.ui.footerbar.AddBookmarkButton");
+                .catch((oError) => {
+                    Log.error("Failed to add bookmark", oError, "sap.ushell.ui.footerbar.AddBookmarkButton");
                     oMessageService.error(ushellResources.i18n.getText("fail_to_add_tile_msg"));
                 });
         });

package/src/main/js/sap/ushell/ui/footerbar/ContactSupportDialog.controller.js

@@ -114,7 +114,7 @@ sap.ui.define([
                 try {
                     await oSupportTicketService.createTicket({ subject: sSubject, text: sText, clientContext: this.oClientContext });
                     oMessageService.info(resources.i18n.getText("supportTicketCreationSuccess"));
-                } catch (error) {
+                } catch (oError) {
                     oMessageService.error(resources.i18n.getText("supportTicketCreationFailed"));
                 }
                 this.closeDialog();

package/src/main/js/sap/ushell/ui/footerbar/JamShareButton.js

@@ -81,6 +81,10 @@ sap.ui.define([
 
         if (Container.inAppRuntime()) {
             this.adjustFLPUrl(this.getJamData())
+                .catch((oError) => {
+                    Log.error("Could not retrieve FLP URL", oError, "sap.ushell.ui.footerbar.JamShareButton");
+                    throw oError;
+                })
                 .then(() => {
                     return this.oShareComponentPromise.then((oShareComponent) => {
                         oShareComponent.open();
@@ -88,9 +92,6 @@ sap.ui.define([
                             cb();
                         }
                     });
-                }, (sError) => {
-                    Log.error("Could not retrieve FLP URL", sError, "sap.ushell.ui.footerbar.JamShareButton");
-                    return undefined;
                 });
         } else {
             return this.oShareComponentPromise.then((oShareComponent) => {

package/src/main/js/sap/ushell/ui/launchpad/CatalogsContainer.js

@@ -189,7 +189,7 @@ sap.ui.define([
             Measurement.resume("FLP:DashboardManager.CatalogsRendering");
             this.filterElements();
             Measurement.pause("FLP:DashboardManager.CatalogsRendering");
-        } catch (ex) {
+        } catch (oError) {
             Control.prototype.updateAggregation.apply(this, arguments);
         }
     };
@@ -317,8 +317,7 @@ sap.ui.define([
 
         // validate data is still can be added to the screen object and still the ordering will be ok else call refresh.
         if (!TileContainerUtils.validateOrder(aBindingContexts, aItems, indexSearchMissingFilteredElem)) {
-            // eslint-disable-next-line no-throw-literal
-            throw true;
+            throw new Error("Invalid order");
         }
 
         // add the missing elements and check if there is a need for header.

package/src/main/js/sap/ushell/ui/launchpad/DashboardGroupsContainer.js

@@ -111,7 +111,7 @@ sap.ui.define([
                     return groups[i];
                 }
             }
-        } catch (e) {
+        } catch {
             // continue regardless of error
         }
 

package/src/main/js/sap/ushell/ui/launchpad/ExtendedChangeDetection.js

@@ -7,7 +7,7 @@
  * of recreating them. Items which get removed from the aggregation get destroyed and items which get added to the
  * aggregation get created.
  *
- * @version 1.140.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/ui/base/ManagedObject",
@@ -80,7 +80,7 @@ sap.ui.define([
             try {
                 const oContext = JSON.parse(sContext);
                 return oContext[oBindingInfo.key];
-            } catch (err) {
+            } catch {
                 return sContext;
             }
         });

package/src/main/js/sap/ushell/ui/launchpad/LinkTileWrapperRenderer.js

@@ -54,8 +54,8 @@ sap.ui.define([
 
         try {
             oTileView = oControl.getTileViews()[0];
-        } catch (ex) {
-            Log.warning("Failed to load tile view: ", ex.message);
+        } catch (oError) {
+            Log.warning("Failed to load tile view: ", oError);
             tileLoadingFailed();
         }
 

package/src/main/js/sap/ushell/ui/launchpad/Section.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview Provides control sap.ushell.ui.launchpad.Section
  *
- * @version 1.140.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/ui/launchpad/TileContainerUtils.js

@@ -109,8 +109,7 @@ sap.ui.define([
                 TileContainerUtils.applyFilterOnItem(elementsToDisplay[j], filters);
             } else {
                 // order problem needs to refresh.
-                // eslint-disable-next-line no-throw-literal
-                throw true;
+                throw new Error("Order problem needs to refresh");
             }
         }
 

package/src/main/js/sap/ushell/ui/launchpad/TileRenderer.js

@@ -27,8 +27,8 @@ sap.ui.define([
 
         try {
             oTileView = tile.getTileViews()[0];
-        } catch (oException) {
-            Log.warning("Failed to load tile view: ", oException.message);
+        } catch (oError) {
+            Log.warning("Failed to load tile view: ", oError);
             oTileView = tile.getFailedtoLoadViewText();
         }
         const oTileContainer = tile.getParent();

package/src/main/js/sap/ushell/ui/launchpad/section/CompactArea.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview Provides control sap.ushell.ui.launchpad.section.CompactArea
  *
- * @version 1.140.0
+ * @version 1.141.0
  */
 
 sap.ui.define([

package/src/main/js/sap/ushell/ui/shell/ShellAppTitle.js

@@ -507,8 +507,8 @@ sap.ui.define([
         oNavMenuPopover.attachAfterOpen(() => {
             // fix for scrolling (By @Alexander Pashkov) on sap.m.Popover being override
             // in Mobile by UI5
-            oNavMenu.$().on("touchmove.scrollFix", (e) => {
-                e.stopPropagation();
+            oNavMenu.$().on("touchmove.scrollFix", (oEvent) => {
+                oEvent.stopPropagation();
             });
 
             // calls to afterOpen on the navigation menu itself in case some things needed to be made
@@ -749,6 +749,7 @@ sap.ui.define([
     };
 
     ShellAppTitle.prototype.onkeyup = function (oEvent) {
+        Button.prototype.onkeyup.apply(this, arguments);
         if (oEvent.keyCode === 32) { // Spacebar
             this.onclick(oEvent);
         }

package/src/main/js/sap/ushell/ui/shell/ShellNavigationMenu.js

@@ -91,39 +91,39 @@ sap.ui.define([
         delete this.jqElement;
     };
 
-    KeyboardNavigation.prototype.keydownHandler = function (e) {
-        switch (e.keyCode) {
+    KeyboardNavigation.prototype.keydownHandler = function (oEvent) {
+        switch (oEvent.keyCode) {
             case this.keyCodes.ARROW_UP:
-                this.upDownHandler(e, true);
+                this.upDownHandler(oEvent, true);
                 break;
             case this.keyCodes.ARROW_DOWN:
-                this.upDownHandler(e, false);
+                this.upDownHandler(oEvent, false);
                 break;
             case this.keyCodes.ARROW_LEFT:
-                this.leftRightHandler(e, false);
+                this.leftRightHandler(oEvent, false);
                 break;
             case this.keyCodes.ARROW_RIGHT:
-                this.leftRightHandler(e, true);
+                this.leftRightHandler(oEvent, true);
                 break;
             case this.keyCodes.HOME:
-                this.homeEndHandler(e, true);
+                this.homeEndHandler(oEvent, true);
                 break;
             case this.keyCodes.END:
-                this.homeEndHandler(e, false);
+                this.homeEndHandler(oEvent, false);
                 break;
             case this.keyCodes.PAGE_UP:
                 // PageUp acts as Home
-                this.homeEndHandler(e, true);
+                this.homeEndHandler(oEvent, true);
                 break;
             case this.keyCodes.PAGE_DOWN:
                 // PageDown acts as End
-                this.homeEndHandler(e, false);
+                this.homeEndHandler(oEvent, false);
                 break;
             case this.keyCodes.TAB:
-                if (e && e.shiftKey) {
-                    this._setItemFocus(e, jQuery("#sapUshellNavHierarchyItems li:[tabindex='0']"));
+                if (oEvent && oEvent.shiftKey) {
+                    this._setItemFocus(oEvent, jQuery("#sapUshellNavHierarchyItems li:[tabindex='0']"));
                 } else {
-                    this._setItemFocus(e, jQuery("#allMyAppsButton"));
+                    this._setItemFocus(oEvent, jQuery("#allMyAppsButton"));
                 }
                 break;
             default:
@@ -234,16 +234,16 @@ sap.ui.define([
         jqItemTo.focus();
     };
 
-    KeyboardNavigation.prototype.setFocusToLastFocusedMiniTile = function (e) {
+    KeyboardNavigation.prototype.setFocusToLastFocusedMiniTile = function (oEvent) {
         const jqLastVisitedMiniTile = jQuery(".sapUshellNavMiniTile[tabindex='0']");
 
         // if we found last-visited mini tils
         if (jqLastVisitedMiniTile && jqLastVisitedMiniTile[0]) {
             // set focus to it
-            this._setItemFocus(e, jQuery(jqLastVisitedMiniTile));
+            this._setItemFocus(oEvent, jQuery(jqLastVisitedMiniTile));
         } else {
             // set focus to first mini-tile available
-            this._setItemFocus(e, jQuery(jQuery(".sapUshellNavMiniTile")[0]));
+            this._setItemFocus(oEvent, jQuery(jQuery(".sapUshellNavMiniTile")[0]));
         }
     };
 
@@ -308,14 +308,14 @@ sap.ui.define([
             // hierarchy items list
             this.oItemsList.addEventDelegate({
                 // on tab next (Tab)
-                onsaptabnext: function (e) {
+                onsaptabnext: function (oEvent) {
                     if (jQuery(".sapUshellNavMiniTile").length) {
                         // focus last visited mini tile
-                        this.keyboardNavigation.setFocusToLastFocusedMiniTile(e);
+                        this.keyboardNavigation.setFocusToLastFocusedMiniTile(oEvent);
                     } else {
                         const oAllMyAppsBtn = Element.getElementById("allMyAppsButton");
 
-                        this.keyboardNavigation._setItemFocus(e, jQuery((oAllMyAppsBtn.getDomRef())));
+                        this.keyboardNavigation._setItemFocus(oEvent, jQuery((oAllMyAppsBtn.getDomRef())));
                     }
                 }.bind(this)
             });
@@ -440,7 +440,7 @@ sap.ui.define([
         if (Device.system.desktop) {
             oItem.addEventDelegate({
                 // on tab previous (Shift Tab)
-                onsapspace: function (e) {
+                onsapspace: function (oEvent) {
                     this.firePress();
                 }.bind(oItem)
             });

package/src/main/js/sap/ushell/ui/shell/ToolAreaItem.js

@@ -18,7 +18,7 @@ sap.ui.define([
      * A control to be placed in the tool area
      * @extends sap.ui.core.Control
      *
-     * @version 1.140.0
+     * @version 1.141.0
      *
      * @public
      * @since 1.30.5

package/src/main/js/sap/ushell/ui/tile/TileBase.js

@@ -87,15 +87,15 @@ sap.ui.define([
         renderer: TileBaseRenderer
     });
 
-    TileBase.prototype.ontap = function (e) {
+    TileBase.prototype.ontap = function (oEvent) {
         this.firePress({});
     };
 
-    TileBase.prototype.onsapenter = function (e) {
+    TileBase.prototype.onsapenter = function (oEvent) {
         this.firePress({});
     };
 
-    TileBase.prototype.onsapspace = function (e) {
+    TileBase.prototype.onsapspace = function (oEvent) {
         this.firePress({});
     };
 

package/src/main/js/sap/ushell/ui/utils.js

@@ -6,7 +6,7 @@
  * This is a utility module that collects common activities implemented
  * by controllers of different ui components.
  *
- * @version 1.140.0
+ * @version 1.141.0
  * @private
  */
 
@@ -59,7 +59,7 @@ sap.ui.define([
         let failureCount = 0;
         let successCount = 0;
         const promiseArray = [];
-        const failureMsgArr = [];
+        const aFailedMessages = [];
         let currEntryTitle;
         const oAfterSave = {
             refresh: false
@@ -73,10 +73,10 @@ sap.ui.define([
             resultDeferred.notify();
         }
 
-        function onSaveFail (err) {
-            failureMsgArr.push({
+        function onSaveFail (oError) {
+            aFailedMessages.push({
                 entry: currEntryTitle,
-                message: err
+                message: oError
             });
             failureCount++;
             resultDeferred.notify();
@@ -102,7 +102,7 @@ sap.ui.define([
 
         resultDeferred.progress(() => {
             if (failureCount > 0 && (failureCount + successCount === totalPromisesCount)) {
-                resultDeferred.reject(failureMsgArr);
+                resultDeferred.reject(aFailedMessages);
             }
         });
 

package/src/main/js/sap/ushell/ui5service/ShellUIService.js

@@ -879,6 +879,9 @@ sap.ui.define([
 
         /**
          * Sets the application screen size to either full width or letterbox.
+         *
+         * This method sets the application width dynamically. This can cause flickering depending on the current environment.
+         * As an alternative you can set the application width statically using the manifest property <code>sap.ui/fullWidth</code>.
          * @param {boolean} bFullWidth Whether the application should be displayed in full width.
          *
          * @since 1.133.0

package/src/main/js/sap/ushell/ui5service/ShellUIServiceFactory.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview The ShellUIService UI5 service factory
  *
- * @version 1.140.0
+ * @version 1.141.0
  */
 sap.ui.define([
     "sap/base/util/Deferred",

package/src/main/js/sap/ushell/ui5service/UserStatus.js

@@ -3,7 +3,7 @@
 /**
  * @fileOverview The UserStatus UI5 service
  *
- * @version 1.140.0
+ * @version 1.141.0
  * @deprecated since 1.70. Support for this service has been discontinued.
  */
 sap.ui.define([

package/src/main/js/sap/ushell/utils/CallbackQueue.js

@@ -0,0 +1,114 @@
+// Copyright (c) 2009-2025 SAP SE, All Rights Reserved
+sap.ui.define([
+    "sap/base/Log",
+    "sap/base/util/Deferred",
+    "sap/ushell/utils"
+], (
+    Log,
+    Deferred,
+    ushellUtils
+) => {
+    "use strict";
+
+    /**
+     * @alias sap.ushell.utils.CallbackQueue
+     * @class
+     * @classdesc A queue for managing promises in a sequential manner.
+     * It ensures that async processes are strictly executed after each other.
+     * This is useful when the effects on the callbacks might interfere with each other.
+     * In case a promise is failed the error handler is called and execution continues.
+     *
+     * @since 1.141.0
+     * @private
+     */
+    class CallbackQueue {
+        #pLastPromise = Promise.resolve();
+        #iIndex = 1;
+
+        /**
+         * Adds a callback on top of the queue.
+         * @param {function ():Promise} fnCallback
+         * A callback which is called when all previous callbacks in the queue have settled.
+         * @param {function ():Promise} fnErrorCallback
+         * A callback function to handle errors. It is called in case the main callback fails
+         * @returns {Promise}
+         * Resolves when this step is done with the result of fnCallback.
+         * If fnCallback failed it rejects with the error.
+         *
+         * Unless fnErrorCallback is provided.
+         * Then it resolves or rejects with the result or error of the fnErrorCallback.
+         *
+         * @since 1.141.0
+         * @private
+         */
+        async push (fnCallback, fnErrorCallback) {
+            // Save current state of promise chain
+            const pLastPromise = this.#pLastPromise;
+
+            // Create Deferred for async resolve
+            const oNextPromiseDeferred = new Deferred();
+
+            // Update promise with deferred
+            this.#pLastPromise = pLastPromise.then(() => oNextPromiseDeferred.promise);
+            this.#pLastPromise.index = this.#iIndex++; // add index for easier debugging
+
+            // Await current state of promise chain
+            await pLastPromise;
+
+            let bFailed = false;
+            let vResult;
+            try {
+                // Now execute target callback
+                vResult = await ushellUtils.promisify(fnCallback());
+            } catch (oError) {
+                Log.error("Error occurred in CallbackQueue:", oError);
+
+                bFailed = true;
+                vResult = oError;
+
+                if (fnErrorCallback) {
+                    try {
+                        vResult = await ushellUtils.promisify(fnErrorCallback(oError));
+                        bFailed = false;
+                    } catch (oNestedError) {
+                        Log.error("Error occurred in CallbackQueue:", oNestedError);
+
+                        bFailed = true;
+                        vResult = oNestedError;
+                    }
+                }
+
+                // Continue with next promise
+            }
+
+            // Finally resolve deferred to execute next step
+            oNextPromiseDeferred.resolve();
+
+            if (bFailed) {
+                throw vResult;
+            }
+            return vResult;
+        }
+
+        /**
+         * Waits for all promises in the queue to settle.
+         * When more callbacks are added to the queue, this method will ensure that they are also awaited.
+         * @returns {Promise} A promise that resolves when all queued promises have settled.
+         *
+         * @since 1.141.0
+         * @private
+         */
+        async waitAllSettled () {
+            const pLastPromise = this.#pLastPromise;
+
+            await pLastPromise;
+
+            if (pLastPromise !== this.#pLastPromise) {
+                // new promise was added
+                return this.waitAllSettled();
+            }
+        }
+    }
+
+    return CallbackQueue;
+});

package/src/main/js/sap/ushell/utils/Deferred.js

@@ -63,13 +63,13 @@ sap.ui.define([], () => {
 
         /**
          * Sets the Promise object into rejected state.
-         * @param {any} args reject value of the promise.
+         * @param {any} vArgument reject value of the promise.
          * @returns {Promise} the promise object
          * @public
          */
-        reject (args) {
+        reject (vArgument) {
             this.#promise._state = "rejected";
-            this.#reject(args);
+            this.#reject(vArgument);
             return this.#promise;
         }