@sapui5/sap.ushell 1.120.0 → 1.120.2

package/src/main/js/sap/ushell/components/factsheet/Component.js

@@ -17,7 +17,7 @@ sap.ui.define([
 
         // use inline declaration instead of component.json to save 1 round trip
         metadata: {
-            version: "1.120.0",
+            version: "1.120.2",
             library: "sap.ushell",
             dependencies: {
                 libs: ["sap.m", "sap.ui.vbm", "sap.suite.ui.commons", "sap.ui.layout", "sap.viz"],

package/src/main/js/sap/ushell/components/homepage/ActionMode.js

@@ -20,7 +20,7 @@
  *  - Deactivation handler
  *  - Rendering tile action menu
  *
- * @version 1.120.0
+ * @version 1.120.2
  *
  * @deprecated since 1.112
  */

package/src/main/js/sap/ushell/components/homepage/DashboardContent.view.js

@@ -5,7 +5,7 @@
  * with a header of type <code>sap.ushell.ui.launchpad.AnchorNavigationBar</code>
  * and content of type <code>sap.ushell.ui.launchpad.DashboardGroupsContainer</code>.
  *
- * @version 1.120.0
+ * @version 1.120.2
  * @name sap.ushell.components.homepage.DashboardContent.view
  *
  * @deprecated since 1.112

package/src/main/js/sap/ushell/components/homepage/DashboardGroupsBox.js

@@ -6,7 +6,7 @@
  * Exposes the public function <code>createGroupsBox</code>
  * @see sap.ushell.components.homepage.DashboardContent.view
  *
- * @version 1.120.0
+ * @version 1.120.2
  * @name sap.ushell.components.homepage.DashboardGroupsBox
  * @since 1.35.0
  *

package/src/main/js/sap/ushell/components/homepage/DashboardUIActions.js

@@ -5,7 +5,7 @@
  * Extends <code>sap.ui.base.Object</code><br>
  * Exposes the public function <code>initializeUIActions</code>
  *
- * @version 1.120.0
+ * @version 1.120.2
  * @name sap.ushell.components.homepage.DashboardUIActions
  * @since 1.35.0
  *

package/src/main/js/sap/ushell/components/homepage/manifest.json

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.homepage",
         "applicationVersion": {
-            "version": "1.120.0"
+            "version": "1.120.2"
         },
         "i18n": {
             "bundleUrl": "../../renderer/resources/resources.properties",

package/src/main/js/sap/ushell/components/pages/ActionMode.js

@@ -2,7 +2,7 @@
 /**
  * @fileOverview ActionMode for the PageRuntime view
  *
- * @version 1.120.0
+ * @version 1.120.2
  */
 
 sap.ui.define([

package/src/main/js/sap/ushell/components/pages/Component.js

@@ -5,7 +5,7 @@
  * #Shell-home or #Launchpad-openFLPPage if spaces are enabled (/core/spaces/enabled).
  * In the future it should completely replace the classical homepage.
  *
- * @version 1.120.0
+ * @version 1.120.2
  */
 
 sap.ui.define([

package/src/main/js/sap/ushell/components/pages/MyHomeImport.js

@@ -2,7 +2,7 @@
 /**
  * @fileOverview MyHome migrate functionality for the PageRuntime view
  *
- * @version 1.120.0
+ * @version 1.120.2
  */
 
 sap.ui.define([

package/src/main/js/sap/ushell/components/pages/controller/PageRuntime.controller.js

@@ -2,7 +2,7 @@
 
 /**
  * @file PageRuntime controller for PageRuntime view
- * @version 1.120.0
+ * @version 1.120.2
  */
 sap.ui.define([
     "sap/ushell/library",

package/src/main/js/sap/ushell/components/pages/manifest.json

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.pages",
         "applicationVersion": {
-            "version": "1.120.0"
+            "version": "1.120.2"
         },
         "i18n": {
             "bundleUrl": "../../renderer/resources/resources.properties",

package/src/main/js/sap/ushell/components/runtimeSwitcher/controller/RuntimeSwitcher.controller.js

@@ -2,7 +2,7 @@
 
 /**
  * @file RuntimeSwitcher's controller for RuntimeSwitcher's view
- * @version 1.120.0
+ * @version 1.120.2
  */
  sap.ui.define([
     "sap/ui/core/mvc/Controller",

package/src/main/js/sap/ushell/components/runtimeSwitcher/manifest.json

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.runtimeSwitcher",
         "applicationVersion": {
-            "version": "1.120.0"
+            "version": "1.120.2"
         },
         "ach": "CA-FLP-FE-COR",
         "type": "component",

package/src/main/js/sap/ushell/components/shell/MenuBar/manifest.json

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.shell.MenuBar",
         "applicationVersion": {
-            "version": "1.120.0"
+            "version": "1.120.2"
         },
         "i18n": {
             "bundleUrl": "../../../renderer/resources/resources.properties",

package/src/main/js/sap/ushell/components/shell/NavigationBarMenu/controller/NavigationBarMenu.controller.js

@@ -4,7 +4,7 @@
  * @fileOverview Controller for the NavigationBarMenu Popover. It is responsible for Popover handling, model binding, persistence
  * logic to pin, unpin and rearrange pinned spaces as well as executing navigation.
  *
- * @version 1.120.0
+ * @version 1.120.2
  * @private
  */
 sap.ui.define([

package/src/main/js/sap/ushell/components/shell/NavigationBarMenu/manifest.json

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.shell.NavigationBarMenu",
         "applicationVersion": {
-            "version": "1.120.0"
+            "version": "1.120.2"
         },
         "i18n": {
             "bundleUrl": "../../../renderer/resources/resources.properties",

package/src/main/js/sap/ushell/components/shell/Notifications/Component.js

@@ -44,7 +44,7 @@ sap.ui.define([
 
     return UIComponent.extend("sap.ushell.components.shell.Notifications.Component", {
         metadata: {
-            version: "1.120.0",
+            version: "1.120.2",
             library: "sap.ushell.components.shell.Notifications",
             dependencies: {
                 libs: ["sap.m"]

package/src/main/js/sap/ushell/components/shell/ProductSwitch/Component.js

@@ -33,7 +33,7 @@ sap.ui.define([
     return UIComponent.extend("sap.ushell.components.shell.ProductSwitch.Component", {
 
         metadata: {
-            version: "1.120.0",
+            version: "1.120.2",
             library: "sap.ushell.components.shell.ProductSwitch",
             dependencies: {
                 libs: {

package/src/main/js/sap/ushell/components/shell/Search/manifest.json

@@ -4,7 +4,7 @@
         "id": "sap.ushell.components.shell.Search",
 
         "applicationVersion": {
-            "version": "1.120.0"
+            "version": "1.120.2"
         },
         "i18n": {
             "bundleUrl": "../../../renderer/resources/resources.properties",

package/src/main/js/sap/ushell/components/shell/SearchCEP/Component.js

@@ -24,7 +24,7 @@ sap.ui.define([
 
     return UIComponent.extend("sap.ushell.components.shell.SearchCEP.Component", {
         metadata: {
-            version: "1.120.0",
+            version: "1.120.2",
             library: ["sap.ushell", "sap.ushell.components.shell"],
             dependencies: {
                 libs: ["sap.m"]

package/src/main/js/sap/ushell/components/shell/SearchCEP/SearchProviders/FrequentActivityProvider.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview
- * @version 1.120.0
+ * @version 1.120.2
  */
 sap.ui.define([
     "sap/base/Log"

package/src/main/js/sap/ushell/components/shell/SearchCEP/SearchProviders/RecentSearchProvider.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview
- * @version 1.120.0
+ * @version 1.120.2
  */
 sap.ui.define([
     "sap/base/Log"

package/src/main/js/sap/ushell/components/shell/SearchCEP/SearchProviders/SearchProvider.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview This module is the search provider main interface
- * @version 1.120.0
+ * @version 1.120.2
  */
 sap.ui.define([
     "sap/ushell/resources",

package/src/main/js/sap/ushell/components/shell/SearchCEP/SearchProviders/SearchServiceProvider.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview This module handles the navigation service search actions
- * @version 1.120.0
+ * @version 1.120.2
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/components/shell/Settings/Component.js

@@ -48,7 +48,7 @@ sap.ui.define([
     return UIComponent.extend("sap.ushell.components.shell.Settings.Component", {
 
         metadata: {
-            version: "1.120.0",
+            version: "1.120.2",
             library: "sap.ushell",
             dependencies: {
                 libs: {

package/src/main/js/sap/ushell/components/shell/UserActionsMenu/Component.js

@@ -27,7 +27,7 @@ sap.ui.define([
     return UIComponent.extend("sap.ushell.components.shell.UserActionsMenu.Component", {
 
         metadata: {
-            version: "1.120.0",
+            version: "1.120.2",
             library: "sap.ushell",
             dependencies: {
                 libs: ["sap.m"]

package/src/main/js/sap/ushell/components/shell/UserImage/Component.js

@@ -37,7 +37,7 @@ sap.ui.define([
     return UIComponent.extend("sap.ushell.components.shell.UserImage.Component", {
 
         metadata: {
-            version: "1.120.0",
+            version: "1.120.2",
             library: "sap.ushell.components.shell.UserImage",
             dependencies: {
                 libs: {

package/src/main/js/sap/ushell/components/visualizationOrganizer/Component.js

@@ -38,7 +38,7 @@ sap.ui.define([
     // visualizationOrganizer Component
     return UIComponent.extend("sap.ushell.components.visualizationOrganizer.Component", {
         metadata: {
-            version: "1.120.0",
+            version: "1.120.2",
             library: "sap.ushell",
             dependencies: { libs: ["sap.m"] },
             properties: {

package/src/main/js/sap/ushell/components/workPageBuilder/Component.js

@@ -3,7 +3,7 @@
  * @fileOverview WorkPageBuilder Component
  * This UIComponent gets initialized by the FLP renderer upon visiting a work page if work pages are enabled (/core/workPages/enabled).
  *
- * @version 1.120.0
+ * @version 1.120.2
  */
 
 sap.ui.define([

package/src/main/js/sap/ushell/components/workPageBuilder/controller/WorkPageBuilder.accessibility.js

@@ -2,7 +2,7 @@
 
 /**
  * @file WorkPageBuilder accessibility features
- * @version 1.120.0
+ * @version 1.120.2
  */
 
 sap.ui.define([

package/src/main/js/sap/ushell/components/workPageBuilder/controller/WorkPageBuilder.controller.js

@@ -2,7 +2,7 @@
 
 /**
  * @file WorkPageBuilder controller for WorkPageBuilder view
- * @version 1.120.0
+ * @version 1.120.2
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/components/workPageBuilder/controller/WorkPageHost.js

@@ -2,7 +2,7 @@
 
 /**
  * @file WorkPageHost for WorkPageBuilder
- * @version 1.120.0
+ * @version 1.120.2
  */
 
 sap.ui.define([

package/src/main/js/sap/ushell/components/workPageBuilder/controls/WorkPage.js

@@ -32,7 +32,7 @@ sap.ui.define([
      * @extends sap.ui.core.Control
      *
      *
-     * @version 1.120.0
+     * @version 1.120.2
      *
      * @private
      * @experimental

package/src/main/js/sap/ushell/components/workPageBuilder/controls/WorkPageButton.js

@@ -22,7 +22,7 @@ sap.ui.define([
      * @extends sap.ui.core.Control
      *
      *
-     * @version 1.120.0
+     * @version 1.120.2
      *
      * @private
      * @experimental

package/src/main/js/sap/ushell/components/workPageBuilder/controls/WorkPageCell.js

@@ -47,7 +47,7 @@ sap.ui.define([
      * @extends sap.ui.core.Control
      *
      *
-     * @version 1.120.0
+     * @version 1.120.2
      *
      * @private
      * @experimental

package/src/main/js/sap/ushell/components/workPageBuilder/controls/WorkPageColumn.js

@@ -34,7 +34,7 @@ sap.ui.define([
      * @extends sap.ui.core.Control
      *
      *
-     * @version 1.120.0
+     * @version 1.120.2
      *
      * @private
      * @experimental

package/src/main/js/sap/ushell/components/workPageBuilder/controls/WorkPageColumnResizer.js

@@ -19,7 +19,7 @@ sap.ui.define([
      * @extends sap.ui.core.Control
      *
      *
-     * @version 1.120.0
+     * @version 1.120.2
      *
      * @private
      * @experimental

package/src/main/js/sap/ushell/components/workPageBuilder/controls/WorkPageRow.js

@@ -27,7 +27,7 @@ sap.ui.define([
      * @extends sap.ui.core.Control
      *
      *
-     * @version 1.120.0
+     * @version 1.120.2
      *
      * @private
      * @experimental

package/src/main/js/sap/ushell/components/workPageBuilder/manifest.json

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.workPageBuilder",
         "applicationVersion": {
-            "version": "1.120.0"
+            "version": "1.120.2"
         },
         "i18n": "./resources/resources.properties",
         "ach": "CA-FLP-FE-UI",

package/src/main/js/sap/ushell/components/workPageRuntime/Component.js

@@ -3,7 +3,7 @@
  * @fileOverview WorkPages Runtime Component
  * This UIComponent gets initialized by the FLP renderer if work pages are enabled (/core/workPages/enabled).
  *
- * @version 1.120.0
+ * @version 1.120.2
  */
 
 sap.ui.define([

package/src/main/js/sap/ushell/components/workPageRuntime/controller/WorkPageRuntime.controller.js

@@ -2,7 +2,7 @@
 
 /**
  * @file WorkPageRuntime controller for WorkPageRuntime view
- * @version 1.120.0
+ * @version 1.120.2
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/components/workPageRuntime/manifest.json

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.workPageRuntime",
         "applicationVersion": {
-            "version": "1.120.0"
+            "version": "1.120.2"
         },
         "ach": "CA-FLP-FE-UI",
         "type": "component",

package/src/main/js/sap/ushell/components/workPageRuntime/services/NavigationResolver.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview This module resolves the given inbounds via the navigation service.
- * @version 1.120.0
+ * @version 1.120.2
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/components/workPageRuntime/services/WorkPage.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview This module communicates with the content API graphql service to retrieve and save workpage and visualization data.
- * @version 1.120.0
+ * @version 1.120.2
  */
 sap.ui.define([
     "sap/ui/core/Configuration",

package/src/main/js/sap/ushell/designtime/ApplicationContainer.designtime.js

@@ -2,7 +2,7 @@
 
 /**
  * @fileOverview Provides the Design Time Metadata for the sap.ushell.components.container.ApplicationContainer control
- * @version 1.120.0
+ * @version 1.120.2
  */
 sap.ui.define([], function () {
     "use strict";

package/src/main/js/sap/ushell/library.js

@@ -21,7 +21,7 @@ sap.ui.define([
      */
     var oUshellLibrary = Core.initLibrary({
         name: "sap.ushell",
-        version: "1.120.0",
+        version: "1.120.2",
         dependencies: [
             "sap.ui.core",
             "sap.m"
@@ -234,6 +234,7 @@ sap.ui.define([
         /**
          * A group of the classic homepage
          * @public
+         * @deprecated since 1.120
          */
         HomepageGroup: "HomepageGroup",
         /**

package/src/main/js/sap/ushell/navigationMode.js

@@ -11,7 +11,7 @@
  * Method Compute is used by ClientSide TargetResolution and takes not only the
  * next application but also the current application into account.
  *
- * @version 1.120.0
+ * @version 1.120.2
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/performance/ShellAnalytics.js

@@ -3,7 +3,7 @@
  * @fileOverview Provides analytical data like duration for navigation steps in the shell, in FLP,
  *               in particular an array of all statistical records
  *
- * @version 1.120.0
+ * @version 1.120.2
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/performance/StatisticalRecord.js

@@ -3,7 +3,7 @@
  * @fileOverview Class for statistical record
  *               It should contain data like step, duration after a navigation in the shell, can have status open.
  *               The closing of a record is logged in debug mode
- * @version 1.120.0
+ * @version 1.120.2
  */
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/plugins/appwarmup/Component.js

@@ -87,7 +87,7 @@ sap.ui.define(
         var sComponentName = "sap.ushell.plugins.appwarmup.Component";
         return Component.extend(sComponentName, {
             metadata: {
-                version: "1.120.0",
+                version: "1.120.2",
                 library: "sap.ushell"
             },
 

package/src/main/js/sap/ushell/renderer/Renderer.js

@@ -78,9 +78,9 @@ sap.ui.define([
      */
     var Renderer = UIComponent.extend("sap.ushell.renderer.Renderer", {
         metadata: {
-            version: "1.120.0",
+            version: "1.120.2",
             dependencies: {
-                version: "1.120.0",
+                version: "1.120.2",
                 libs: ["sap.ui.core", "sap.m"],
                 components: []
             },

package/src/main/js/sap/ushell/renderer/Shell.controller.js

@@ -1031,7 +1031,7 @@ sap.ui.define([
                 if (Config.last("/core/shell/model/enableTrackingActivity") !== undefined) {
                     this.oInitialEnableTrackingPromise = Promise.resolve();
                 } else {
-                    this.oInitialEnableTrackingPromise = new Promise(function (resolve, reject) {
+                    this.oInitialEnableTrackingPromise = new Promise(function (resolve) {
                         Config.once("/core/shell/model/enableTrackingActivity").do(resolve);
                     });
                 }
@@ -1087,7 +1087,7 @@ sap.ui.define([
 
                     Log.debug(`${sLogFesrPrefix} Interaction End`, "doHashChange", sModuleName);
                     fnResolveInteraction();
-                }, function (vError) {
+                }, function () {
                     Measurement.end("FLP:ShellController.doHashChange");
                     EventHub.emit("doHashChangeError", Date.now());
                     if (oDashboard) {
@@ -1354,7 +1354,7 @@ sap.ui.define([
             });
         },
 
-        _initiateApplication: function (oResolvedHashFragment, sFixedShellHash, oParsedShellHash, iOriginalHistoryLength, sAppPart, sOldFixedShellHash, sOldAppPart) {
+        _initiateApplication: function (oResolvedHashFragment, sFixedShellHash, oParsedShellHash, iOriginalHistoryLength, sAppPart, sOldFixedShellHash) {
             Measurement.start("FLP:ShellController._initiateApplication", "_initiateApplication", "FLP");
 
             var oMetadata = AppConfiguration.getMetadata(oResolvedHashFragment);
@@ -1593,7 +1593,7 @@ sap.ui.define([
                 }
 
                 var oDeferred = this._usesNavigationRedirect(oResolvedHashFragment.componentHandle);
-                var oNavigationPromise = new Promise(function (resolve, reject) {
+                var oNavigationPromise = new Promise(function (resolve) {
                     // When `oDeferred` succeeds, it implies the component references a trampoline application.
                     // The trampoline application subsequently gets destroyed after it's used to enable the redirection.
                     // The failure is being used here as a means for branching in the execution flow.
@@ -1716,7 +1716,7 @@ sap.ui.define([
                                                 }
                                             });
                                             fnResolveParams(fnPreparePostBodyParams());
-                                        }, function (sError) {
+                                        }, function () {
                                             fnResolveParams();
                                         });
                                     } else {
@@ -1849,7 +1849,9 @@ sap.ui.define([
 
             this.resetShellUIServiceHandlers();
 
-            AppLifeCycleAI.getAppMeta().setAppIcons(oMetadata);
+            // @Alon Barnes: Is this call even needed? The beforehand given oMetadata has not included the accessed property in the AppMeta.js
+            // So, maybe this call can even be removed?
+            AppLifeCycleAI.getAppMeta().setAppIcons();
 
             // obtain a unique id for the app (or the component)
             var sAppId = "-" + oParsedShellHash.semanticObject + "-" + oParsedShellHash.action;
@@ -2603,7 +2605,7 @@ sap.ui.define([
          * @private
          */
         _startFloatingContainerAnimation: function (bIsDock) {
-            return new Promise(function (resolve, reject) {
+            return new Promise(function (resolve) {
                 this._clearFloatingContainerAnimation();
                 var aElements = Array.from(document.getElementsByClassName("sapUshellFloatingContainerWrapper"));
                 aElements.forEach(function (oElement) {
@@ -2789,8 +2791,7 @@ sap.ui.define([
         // This function called after co-pilot start to be dragged
         _handleFloatingContainerDrag: function (evt, ui) {
             Measurement.start("FLP:Shell.controller._handleFloatingContainerUIStart", "starts dragging floating container", "FLP");
-            var floatingContainer = ui;
-            floatingContainer.style.display = "none";
+            ui.style.display = "none";
             if (window.getSelection) {
                 var selection = window.getSelection();
                 // for IE
@@ -2862,9 +2863,7 @@ sap.ui.define([
 
         getRightFloatingContainerVisibility: function () {
             var oRightFloatingContainer = this.getView().getRightFloatingContainer();
-            var bRightFloatingContainerVisible = oRightFloatingContainer && oRightFloatingContainer.getVisible();
-
-            return bRightFloatingContainerVisible;
+            return oRightFloatingContainer && oRightFloatingContainer.getVisible();
         },
 
         setHeaderTitle: function (sTitle) {
@@ -2915,8 +2914,7 @@ sap.ui.define([
         getFooterId: function () {
             var oView = this.getView();
             var oHelperModel = oView.getModel("helper");
-            var sFooterId = oHelperModel.getProperty("/shell/footerContent");
-            return sFooterId;
+            return oHelperModel.getProperty("/shell/footerContent");
         },
 
         removeFooter: function () {

package/src/main/js/sap/ushell/renderer/search/searchComponent/manifest.json

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.renderer.search.searchComponent",
         "applicationVersion": {
-            "version": "1.120.0"
+            "version": "1.120.2"
         },
         "type": "component"
     },