@sapui5/sap.ushell 1.118.0 → 1.119.0

package/src/main/js/sap/ushell/components/factsheet/factory/ThingInspector.js

@@ -1754,10 +1754,10 @@ sap.ui.define([
 
     /**
      * Returns tile height in rem, depending on device type and number of segments the tile consists of.
-     * @param {number=} [iSegments=1] Number of segments the tile will take vertically in the grid (optional).
+     * @param {int} [iSegments=1] Number of segments the tile will take vertically in the grid (optional).
      *   Currently expected values are 1, 2, 3, however any positive number is supported.
      *   Default value is 1.
-     * @return {string} Tile height in rem.
+     * @returns {string} Tile height in rem.
      */
     var getTeaserTileHeight = function (iSegments) {
         var iReturn;
@@ -1795,7 +1795,7 @@ sap.ui.define([
      * Returns the importance (High, Medium, Low) of a given record.
      * Necessary as the annotation for importance changed in OData V4 and we'd like to support both V2 and V4.
      * @param {object} oRecord as object.
-     * @return {string} Importance of the record (High, Medium, Low).
+     * @returns {string} Importance of the record (High, Medium, Low).
      */
     var getImportanceOfRecord = function (oRecord) {
         var sEnumMember = "";

package/src/main/js/sap/ushell/components/homeApp/error/HomeAppError.controller.js

@@ -24,7 +24,6 @@ sap.ui.define([
             this._oModel = new JSONModel({
                 icon: "sap-icon://documents",
                 text: resources.i18n.getText("HomeApp.GeneralError.Text"),
-                description: "",
                 details: JSON.stringify(messages, null, 4)
             });
             this.getView().setModel(this._oModel);

package/src/main/js/sap/ushell/components/homeApp/error/HomeAppError.view.xml

@@ -5,16 +5,17 @@
     xmlns:launchpad="sap.ushell.ui.launchpad"
     controllerName="sap.ushell.components.homeApp.error.HomeAppError"
     height="100%">
-    <MessagePage
+    <IllustratedMessage
         id="errorPage"
-        showHeader="false"
+        illustrationType="sapIllus-ErrorScreen"
+        enableDefaultTitleAndDescription="false"
         icon="{/icon}"
-        text="{/text}"
+        title="{/text}"
         description="{/description}">
-        <buttons>
+        <additionalContent>
             <Button
                 text="{i18n>HomeApp.CannotLoadApp.CopyButton}"
                 press=".onCopyErrorDetailsPress" />
-        </buttons>
-    </MessagePage>
+        </additionalContent>
+    </IllustratedMessage>
 </mvc:View>

package/src/main/js/sap/ushell/components/homepage/ActionMode.js

@@ -20,7 +20,7 @@
  *  - Deactivation handler
  *  - Rendering tile action menu
  *
- * @version 1.118.0
+ * @version 1.119.0
  *
  * @deprecated since 1.112
  */

package/src/main/js/sap/ushell/components/homepage/DashboardContent.controller.js

@@ -236,7 +236,7 @@ sap.ui.define([
                     mCurrentAction = (bIsGroupRemovable ? mActions.DELETE : oResourceBundle.getText("ResetGroupBtn"));
 
                 sap.ushell.Container.getServiceAsync("Message").then(function (oMessageSrvc) {
-                    oMessageSrvc.confirm(oResourceBundle.getText(bIsGroupRemovable ? "delete_group_msg" : "reset_group_msg", sGroupTitle), function (oAction) {
+                    oMessageSrvc.confirm(oResourceBundle.getText(bIsGroupRemovable ? "delete_group_msg" : "reset_group_msg", [sGroupTitle]), function (oAction) {
                         if (oAction === mCurrentAction) {
                             oEventBus.publish("launchpad", bIsGroupRemovable ? "deleteGroup" : "resetGroup", {
                                 groupId: sGroupId
@@ -265,11 +265,6 @@ sap.ui.define([
             utils.recalculateBottomSpace();
             utils.handleTilesVisibility();
 
-            // "reset" the appRendered event in case the user wants to navigate back to the same app.
-            if (EventHub.last("AppRendered") !== undefined) {
-                EventHub.emit("AppRendered", undefined);
-            }
-
             // Layout calculation is relevant only when the dashboard is presented
             if (Layout && jQuery("#dashboardGroups").is(":visible") && this.bModelInitialized) {
                 Layout.reRenderGroupsLayout(null);
@@ -341,7 +336,7 @@ sap.ui.define([
          * @param {string} sEventId Not used.
          * @param {object} oData Payload for the event handler.
          *
-         * @returns {Promise<void>} resolves if the scrolling worked, rejects if it didn't.
+         * @returns {Promise<undefined>} resolves if the scrolling worked, rejects if it didn't.
          */
         _scrollToGroup: function (sChannelId, sEventId, oData) {
             var sGroupId = oData.group ? oData.group.getGroupId() : oData.groupId;

package/src/main/js/sap/ushell/components/homepage/DashboardContent.view.js

@@ -5,7 +5,7 @@
  * with a header of type <code>sap.ushell.ui.launchpad.AnchorNavigationBar</code>
  * and content of type <code>sap.ushell.ui.launchpad.DashboardGroupsContainer</code>.
  *
- * @version 1.118.0
+ * @version 1.119.0
  * @name sap.ushell.components.homepage.DashboardContent.view
  *
  * @deprecated since 1.112
@@ -84,16 +84,14 @@ sap.ui.define([
             Core.getEventBus().subscribe("launchpad", "dashboardModelContentLoaded", this._onDashboardShown, this);
 
             /**
-             * In order to save performance we delay the actionmode, the footer creation and the overflow of the anchorBar
+             * In order to save performance we delay the ActionMode init, the footer creation and the overflow of the anchorBar
              * till core-ext file has been loaded.
              */
             this.oDoable = EventHub.once("CoreResourcesComplementLoaded").do(function () {
                 this.oAnchorNavigationBar.setOverflowEnabled(true);
 
                 if (bEnablePersonalization || bEnableTileActionsIcon) {
-                    sap.ui.require(["sap/ushell/components/homepage/ActionMode"], function (ActionMode) {
-                        ActionMode.init(this.oModel);
-                    }.bind(this));
+                    ActionMode.init(this.oModel);
                 }
                 if (bEnablePersonalization) {
                     this._createFooter();
@@ -160,8 +158,8 @@ sap.ui.define([
                 locked: "{isGroupLocked}",
                 isGroupDisabled: {
                     parts: ["isGroupLocked", "/isInDrag", "/homePageGroupDisplay"],
-                    formatter: function (bIsGroupLocked, bIsInDrag, sAnchorbarMode) {
-                        return bIsGroupLocked && bIsInDrag && sAnchorbarMode === "tabs";
+                    formatter: function (bIsGroupLocked, bIsInDrag, sAnchorBarMode) {
+                        return bIsGroupLocked && bIsInDrag && sAnchorBarMode === "tabs";
                     }
                 },
                 press: function (oEvent) {
@@ -223,7 +221,7 @@ sap.ui.define([
         },
 
         _actionModeButtonPress: function () {
-            this.oDashboardGroupsBox.getBinding("groups").filter([]); // replace model filter inorder to show hidden groups
+            this.oDashboardGroupsBox.getBinding("groups").filter([]); // replace model filter in order to show hidden groups
             var dashboardGroups = this.oDashboardGroupsBox.getGroups();
             ActionMode.toggleActionMode(this.oModel, "Menu Item", dashboardGroups);
             this._updateAnchorNavigationBarVisibility();
@@ -330,7 +328,7 @@ sap.ui.define([
 
         _handleEditModeChange: function () {
             if (this.oTileActionsButton) {
-                this.oTileActionsButton.toggleStyleClass("sapUshellAcionItemActive");
+                this.oTileActionsButton.toggleStyleClass("sapUshellActionItemActive");
             }
         },
 
@@ -378,9 +376,6 @@ sap.ui.define([
                         });
                     }
                 }
-                if (EventHub.last("firstSegmentCompleteLoaded")) {
-                    EventHub.emit("CloseFesrRecord", Date.now());
-                }
             }
         },
 
@@ -393,13 +388,18 @@ sap.ui.define([
                     this.oRenderer.showActionButton(this.oTileActionsButton.getId(), true);
                 }
             }
+
+            // track navigation in ShellAnalytics
+            if (EventHub.last("firstSegmentCompleteLoaded")) {
+                EventHub.emit("CloseFesrRecord", Date.now());
+            }
         },
 
         _updateAnchorNavigationBarVisibility: function () {
             var bOldVisible = this.oAnchorNavigationBar.getVisible(),
                 bActionModeActive = this.getModel().getObject("/tileActionModeActive"),
                 aVisibleGroups = this.getModel().getProperty("/groups").filter(function (oGroup) {
-                    // Check for group's visibility AND - depending on the ActionMode - the visiblityMode
+                    // Check for group's visibility AND - depending on the ActionMode - the visibilityMode
                     // (see ushell/utils.calcVisibilityModes() for details of visibilityModes)
                     if (bActionModeActive) {
                         return oGroup.isGroupVisible && oGroup.visibilityModes[1];

package/src/main/js/sap/ushell/components/homepage/DashboardGroupsBox.js

@@ -6,7 +6,7 @@
  * Exposes the public function <code>createGroupsBox</code>
  * @see sap.ushell.components.homepage.DashboardContent.view
  *
- * @version 1.118.0
+ * @version 1.119.0
  * @name sap.ushell.components.homepage.DashboardGroupsBox
  * @since 1.35.0
  *

package/src/main/js/sap/ushell/components/homepage/DashboardUIActions.js

@@ -5,7 +5,7 @@
  * Extends <code>sap.ui.base.Object</code><br>
  * Exposes the public function <code>initializeUIActions</code>
  *
- * @version 1.118.0
+ * @version 1.119.0
  * @name sap.ushell.components.homepage.DashboardUIActions
  * @since 1.35.0
  *

package/src/main/js/sap/ushell/components/homepage/manifest.json

@@ -3,7 +3,7 @@
     "sap.app": {
         "id": "sap.ushell.components.homepage",
         "applicationVersion": {
-            "version": "1.118.0"
+            "version": "1.119.0"
         },
         "i18n": {
             "bundleUrl": "../../renderers/fiori2/resources/resources.properties",

package/src/main/js/sap/ushell/components/pages/ActionMode.js

@@ -2,7 +2,7 @@
 /**
  * @fileOverview ActionMode for the PageRuntime view
  *
- * @version 1.118.0
+ * @version 1.119.0
  */
 
 sap.ui.define([
@@ -35,7 +35,7 @@ sap.ui.define([
             oController.getView().getModel("viewSettings").setProperty("/actionModeEditActive", true);
         }
         oController.getView().getModel("viewSettings").setProperty("/actionModeActive", true);
-        oController.handleMyHomeActionMode(true).catch(oController._onError.bind(oController));
+        oController.handleMyHomeActionMode(true).catch(oController.navigateToErrorPage.bind(oController));
 
         EventHub.emit("enableMenuBarNavigation", false);
 
@@ -83,7 +83,7 @@ sap.ui.define([
     ActionMode._cleanup = function () {
         this.oController.getView().getModel("viewSettings").setProperty("/actionModeActive", false);
         this.oController.getView().getModel("viewSettings").setProperty("/actionModeEditActive", false);
-        this.oController.handleMyHomeActionMode(false).catch(this.oController._onError.bind(this.oController));
+        this.oController.handleMyHomeActionMode(false).catch(this.oController.navigateToErrorPage.bind(this.oController));
         EventHub.emit("enableMenuBarNavigation", true);
 
         var oActionModeButton = Core.byId("ActionModeBtn");
@@ -136,7 +136,7 @@ sap.ui.define([
      * @param {sap.ui.core.Control} oSource Source control
      * @param {object} oParameters Event parameters
      *
-     * @returns {Promise<void>} A promise that is resolved when the Pages service is retrieved.
+     * @returns {Promise<undefined>} A promise that is resolved when the Pages service is retrieved.
      *
      * @private
      * @since 1.75.0
@@ -170,7 +170,7 @@ sap.ui.define([
      * @param {sap.ui.base.Event} oEvent Event object
      * @param {sap.ui.core.Control} oSource Source control
      *
-     * @returns {Promise<void>} A promise that is resolved when the Pages service is retrieved.
+     * @returns {Promise<undefined>} A promise that is resolved when the Pages service is retrieved.
      *
      * @private
      * @since 1.75.0
@@ -179,7 +179,7 @@ sap.ui.define([
         return sap.ushell.Container.getServiceAsync("Message").then(function (oMessageService) {
             var sTitle = oSource.getTitle();
             var sMsg = sTitle
-                ? resources.i18n.getText("PageRuntime.Message.Section.Delete", sTitle)
+                ? resources.i18n.getText("PageRuntime.Message.Section.Delete", [sTitle])
                 : resources.i18n.getText("PageRuntime.Message.Section.DeleteNoTitle");
             var sMsgTitle = resources.i18n.getText("PageRuntime.Dialog.Title.Delete");
 
@@ -233,7 +233,7 @@ sap.ui.define([
      * @param {sap.ui.base.Event} oEvent Event object
      * @param {sap.ui.core.Control} oSection Source control
      *
-     * @returns {Promise<void>} A promise that is resolved when the Pages service is retrieved.
+     * @returns {Promise<undefined>} A promise that is resolved when the Pages service is retrieved.
      *
      * @private
      * @since 1.75.0
@@ -259,7 +259,7 @@ sap.ui.define([
      * @param {sap.ui.core.Control} oSource Source control
      * @param {object} oParameters Event parameters
      *
-     * @returns {Promise<void>} A promise that is resolved when the Pages service is retrieved.
+     * @returns {Promise<undefined>} A promise that is resolved when the Pages service is retrieved.
      *
      * @private
      * @since 1.75.0
@@ -285,7 +285,7 @@ sap.ui.define([
      * @param {sap.ui.core.Control} oSource Source control
      * @param {object} oParameters Event parameters
      *
-     * @returns {Promise<void>} A promise that is resolved when the Pages service is retrieved.
+     * @returns {Promise<undefined>} A promise that is resolved when the Pages service is retrieved.
      *
      * @private
      * @since 1.75.0
@@ -330,7 +330,7 @@ sap.ui.define([
      * @param {sap.ui.core.Control} oSource Source control
      * @param {object} oParameters Event parameters
      *
-     * @returns {Promise<void>} A promise that is resolved when the Pages service is retrieved.
+     * @returns {Promise<undefined>} A promise that is resolved when the Pages service is retrieved.
      *
      * @private
      * @since 1.75.0

package/src/main/js/sap/ushell/components/pages/Component.js

@@ -5,7 +5,7 @@
  * #Shell-home or #Launchpad-openFLPPage if spaces are enabled (/core/spaces/enabled).
  * In the future it should completely replace the classical homepage.
  *
- * @version 1.118.0
+ * @version 1.119.0
  */
 
 sap.ui.define([

package/src/main/js/sap/ushell/components/pages/MyHomeImport.js

@@ -2,7 +2,7 @@
 /**
  * @fileOverview MyHome migrate functionality for the PageRuntime view
  *
- * @version 1.118.0
+ * @version 1.119.0
  */
 
 sap.ui.define([

package/src/main/js/sap/ushell/components/pages/StateManager.js

@@ -88,7 +88,7 @@ sap.ui.define([
      * @since 1.72.0
      */
     StateManager._setCurrentPageVisibility = function (visibility, refresh, navFromErrorPage) {
-        if (this.oPagesRuntimeNavContainer.getCurrentPage().isA("sap.m.MessagePage") && !navFromErrorPage) {
+        if (this.oPagesRuntimeNavContainer.getCurrentPage().isA("sap.m.IllustratedMessage") && !navFromErrorPage) {
             return;
         }
         var oCurrentPage = this.oPagesNavContainer.getCurrentPage();
@@ -258,7 +258,7 @@ sap.ui.define([
      * @since 1.74.0
      */
     StateManager.exit = function () {
-        this.oEventBus.unsubscribe("sap.ushell", "navigated", this._onPageNavigated, this);
+        this.oEventBus.unsubscribe("sap.ushell", "navigated", this._onShellNavigated, this);
         document.removeEventListener("visibilitychange", this._onTabNavigatedBind);
         this.oPagesNavContainer.detachNavigate(this._onPageNavigated, this);
         this.oPagesRuntimeNavContainer.detachNavigate(this._onErrorPageNavigated, this);

package/src/main/js/sap/ushell/components/pages/controller/ImportDialog.controller.js

@@ -128,8 +128,8 @@ sap.ui.define([
          *
          * @param {sap.ushell.services.Pages} pagesService The Pages service instance.
          * @param {object} group The group to which the visualization is added.
-         * @param {number} index the index of the section, the new visualization should be added to.
-         * @param {number} iTargetVizIndex The target visualization index.
+         * @param {int} index the index of the section, the new visualization should be added to.
+         * @param {int} iTargetVizIndex The target visualization index.
          * @param {boolean} defaultGroupImported Indicates if the default group has already been imported.
          * @returns {Promise} A promise resolving when the visualization has been moved.
          * @private
@@ -151,8 +151,8 @@ sap.ui.define([
          * @param {sap.ushell.services.Pages} pagesService The Pages service instance.
          * @param {object} group The group to which the visualization is added.
          * @param {object} tileData The tile data to update.
-         * @param {number} index the index of the section, the new visualization should be added to.
-         * @param {number} vizIndex The visualization index.
+         * @param {int} index the index of the section, the new visualization should be added to.
+         * @param {int} vizIndex The visualization index.
          * @returns {Promise} A promise resolving when the update is done.
          * @param {boolean} defaultGroupImported Indicates if the default group has already been imported.
          * @private
@@ -180,8 +180,8 @@ sap.ui.define([
          *
          * @param {object} group The group to which the visualization is added.
          * @param {object} tile contains important information on how the visualization should be created.
-         * @param {number} vizIndex the index of the new visualization.
-         * @param {number} index the index of the section, the new visualization should be added to.
+         * @param {int} vizIndex the index of the new visualization.
+         * @param {int} index the index of the section, the new visualization should be added to.
          * @param {object} services Ushell services that are need to add the bookmarks and the visualizations.
          * @param {object} contentNode of the current page.
          * @param {boolean} defaultGroupImported Indicates if the default group has already been imported.
@@ -238,7 +238,7 @@ sap.ui.define([
          * Adds visualizations to the existing preset section ('My Apps').
          *
          * @param {object} group contains important information on how the section should be created.
-         * @param {number} index the index of the current iteration.
+         * @param {int} index the index of the current iteration.
          * @param {object} services Ushell services that are needed to add the sections and the visualizations.
          * @param {object} contentNode of the current page.
          * @param {boolean} defaultGroupImported Indicates if the default group has already been imported.
@@ -265,7 +265,7 @@ sap.ui.define([
          * Generates a new section with all its visualizations.
          *
          * @param {object} group contains important information on how the section should be created.
-         * @param {number} index the index of the current iteration.
+         * @param {int} index the index of the current iteration.
          * @param {object} services Ushell services that are needed to add the sections and the visualizations.
          * @param {object} contentNode of the current page.
          * @param {boolean} defaultGroupImported Indicates if the default group has already been imported.
@@ -425,9 +425,9 @@ sap.ui.define([
          * Default section already exists, in case default group is not imported the section index needs to skip the default section.
          * @param {sap.ushell.services.Pages} pagesService The Pages service instance.
          * @param {object} group The group.
-         * @param {number} current The current index.
+         * @param {int} current The current index.
          * @param {boolean} defaultGroupImported Indicates if the default group has been imported.
-         * @returns {number} The section index.
+         * @returns {int} The section index.
          * @private
          */
         _getSectionIndex: function (pagesService, group, current, defaultGroupImported) {
@@ -440,7 +440,7 @@ sap.ui.define([
         /**
          * Determine the index of the 'My Home' preset section ('My Apps').
          * @param {sap.ushell.services.Pages} pagesService The Pages service instance.
-         * @returns {number} The section index.
+         * @returns {int} The section index.
          * @private
          */
         _getPresetSectionIndex: function (pagesService) {
@@ -454,7 +454,7 @@ sap.ui.define([
          * Determine the index of the 'My Home' default section ('Recently added apps').
          *
          * @param {sap.ushell.services.Pages} pagesService The Pages service instance.
-         * @returns {number} The section index.
+         * @returns {int} The section index.
          * @private
          */
         _getDefaultSectionIndex: function (pagesService) {