@sapui5/sap.ushell 1.112.1 → 1.113.0

package/src/main/js/sap/ushell/components/shell/SearchCEP/SearchProviders/RecentSearchProvider.js

@@ -1,8 +1,8 @@
-// Copyright (c) 2009-2022 SAP SE, All Rights Reserved
+// Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
 /**
  * @fileOverview
- * @version 1.112.1
+ * @version 1.113.0
  */
 sap.ui.define([
     "sap/ushell/components/shell/SearchCEP/SearchProviders/SearchProvider",

package/src/main/js/sap/ushell/components/shell/SearchCEP/SearchProviders/SearchProvider.js

@@ -1,8 +1,8 @@
-// Copyright (c) 2009-2022 SAP SE, All Rights Reserved
+// Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
 /**
  * @fileOverview This module is the search provider main interface
- * @version 1.112.1
+ * @version 1.113.0
  */
 sap.ui.define([], function () {
     "use strict";

package/src/main/js/sap/ushell/components/shell/Settings/Component.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2009-2022 SAP SE, All Rights Reserved
+// Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
 sap.ui.define([
     "sap/ui/core/Core",
@@ -48,7 +48,7 @@ sap.ui.define([
     return UIComponent.extend("sap.ushell.components.shell.Settings.Component", {
 
         metadata: {
-            version: "1.112.1",
+            version: "1.113.0",
             library: "sap.ushell",
             dependencies: {
                 libs: {

package/src/main/js/sap/ushell/components/shell/Settings/ErrorMessageHelper.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2009-2022 SAP SE, All Rights Reserved
+// Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
 sap.ui.define([], function () {
     "use strict";

package/src/main/js/sap/ushell/components/shell/Settings/ProfilingLoader.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2009-2022 SAP SE, All Rights Reserved
+// Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
 sap.ui.define([
     "sap/ushell/Config"

package/src/main/js/sap/ushell/components/shell/Settings/UserSettings.controller.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2009-2022 SAP SE, All Rights Reserved
+// Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
 sap.ui.define([
     "sap/base/Log",
@@ -41,7 +41,6 @@ sap.ui.define([
     var MessageType = coreLibrary.MessageType;
 
     return Controller.extend("sap.ushell.components.shell.Settings.UserSettings", {
-
         /**
          * Initializes the user settings dialog.
          *
@@ -69,7 +68,7 @@ sap.ui.define([
             // this helps avoiding infinite processing of entries due to async updates
             this.getView().setModel(new JSONModel({ entries: {} }), "results");
 
-            Device.orientation.attachHandler(this._fnOrientationChange);
+            Device.orientation.attachHandler(this._fnOrientationChange, this);
 
             this._oConfigDoable = Config
                 .on("/core/userPreferences/entries")
@@ -122,7 +121,6 @@ sap.ui.define([
                 this._setEntryValueResult(oEntry.id);
             }.bind(this));
 
-
             var oModel = oView.getModel();
             var oMasterEntryList = oView.byId("userSettingEntryList");
             var oSelectedItem = oMasterEntryList.getSelectedItem();
@@ -444,36 +442,35 @@ sap.ui.define([
             return Promise.all([
                 this._createContentWrapper(oEntry),
                 this._createEntryContent(oEntry)
-            ])
-                .then(function (aResults) {
-                    var aEntries = Config.last("/core/userPreferences/entries");
-                    var bEntryAvailable = aEntries.some(function (oEntry) {
-                        return oEntry.id === sEntryId && oEntry.visible !== false;
-                    });
-                    if (!bEntryAvailable) {
-                        // don't add entries which are not visible anymore
-                        return;
-                    }
+            ]).then(function (aResults) {
+                var aEntries = Config.last("/core/userPreferences/entries");
+                var bEntryAvailable = aEntries.some(function (oEntry) {
+                    return oEntry.id === sEntryId && oEntry.visible !== false;
+                });
+                if (!bEntryAvailable) {
+                    // don't add entries which are not visible anymore
+                    return;
+                }
 
-                    var oWrapper = aResults[0];
-                    var oEntryContent = aResults[1];
+                var oWrapper = aResults[0];
+                var oEntryContent = aResults[1];
 
-                    this.getView().byId("settingsApp").addDetailPage(oWrapper);
+                this.getView().byId("settingsApp").addDetailPage(oWrapper);
 
-                    if (oEntry.tabs.length > 1) {
-                        oWrapper.getContent()[1].getItems()[0].addContent(oEntryContent);
-                    } else {
-                        oWrapper.addContent(oEntryContent);
-                    }
+                if (oEntry.tabs.length > 1) {
+                    oWrapper.getContent()[1].getItems()[0].addContent(oEntryContent);
+                } else {
+                    oWrapper.addContent(oEntryContent);
+                }
 
-                    var sNewDetailPageId = oWrapper.getId();
-                    oResultsModel.setProperty("/entries/" + sEntryId + "/contentResult", sNewDetailPageId);
+                var sNewDetailPageId = oWrapper.getId();
+                oResultsModel.setProperty("/entries/" + sEntryId + "/contentResult", sNewDetailPageId);
 
-                    this._navToDetail(sNewDetailPageId, oView);
-                    this._emitEntryOpened(sEntryId);
+                this._navToDetail(sNewDetailPageId, oView);
+                this._emitEntryOpened(sEntryId);
 
-                    return oWrapper.getId();
-                }.bind(this));
+                return oWrapper.getId();
+            }.bind(this));
         },
 
         /**
@@ -611,7 +608,7 @@ sap.ui.define([
         },
 
         /**
-         *  Update user preferences using the UserInfo service
+         * Update user preferences using the UserInfo service
          *
          * @returns {Promise} A promise that resolves when
          * sendRequest method is executed centrally,
@@ -621,7 +618,6 @@ sap.ui.define([
          * However currently it is "saved with errors" is implemented.
          * @since 1.107.0
          */
-        // Update user preferences using the UserInfo service
         updateUserPreferences: function () {
             Log.debug("[000] updateUserPreferences: ", "UserSettings.controller");
 
@@ -636,7 +632,6 @@ sap.ui.define([
                 _reject = reject;
             });
 
-
             // the request is not sent immediately but when .sendRequest is called onSave
             this._updateUserPreferencesPromise.sendRequest = function () {
                 sap.ushell.Container.getServiceAsync("UserInfo").then(function (oUserInfo) {
@@ -654,6 +649,7 @@ sap.ui.define([
 
             return this._updateUserPreferencesPromise;
         },
+
         /**
          * Reloads FLP if instructions for it are found in results parameter.
          * @param {Array} aResults Array that contains the results.
@@ -663,6 +659,7 @@ sap.ui.define([
             var bRefresh = false;
             var bNoHash = false;
             var aUrlParams = [];
+            var aObsoleteUrlParams = [];
             aResults.forEach(function (oResult) {
                 if (oResult && oResult.refresh) {
                     bRefresh = true;
@@ -673,6 +670,9 @@ sap.ui.define([
                 if (oResult && oResult.urlParams && oResult.urlParams.length > 0) {
                     aUrlParams = aUrlParams.concat(oResult.urlParams);
                 }
+                if (oResult && oResult.obsoleteUrlParams && oResult.obsoleteUrlParams.length > 0) {
+                    aObsoleteUrlParams = aObsoleteUrlParams.concat(oResult.obsoleteUrlParams);
+                }
             });
 
             if (bRefresh) {
@@ -681,11 +681,12 @@ sap.ui.define([
                     // Remove hash, otherwise we navigate to "content" we do not want.
                     window.location = window.location.href.replace(window.location.hash, "");
                 } else {
-                    windowUtils.refreshBrowser(aUrlParams);
+                    windowUtils.refreshBrowser(aUrlParams, aObsoleteUrlParams);
                 }
                 return true;
             }
         },
+
         /**
          * Saves and closes the User Settings Dialog.
          * May show an error message.
@@ -781,13 +782,13 @@ sap.ui.define([
                 } else if (Array.isArray(errorInformation)) {
                     errorInformation.forEach(function (message) {
                         message.setAdditionalText(sEntryTitle);
-                        message.setTechnicalDetails({pluginId: sEntryId});
+                        message.setTechnicalDetails({ pluginId: sEntryId });
                         ErrorMessageHelper.addMessage(message);
                     });
                     return;
                 } else if (BaseObject.isA(errorInformation, "sap.ui.core.message.Message")) {
                     errorInformation.setAdditionalText(sEntryTitle);
-                    errorInformation.setTechnicalDetails({pluginId: sEntryId});
+                    errorInformation.setTechnicalDetails({ pluginId: sEntryId });
                     ErrorMessageHelper.addMessage(errorInformation);
                     return;
                 } else {
@@ -884,8 +885,8 @@ sap.ui.define([
         _handleSettingsDialogClose: function () {
             //to be sure that all user changes reset
             sap.ushell.Container.getUser().resetChangedProperties();
-             // Clear selection from list.
-             if (Device.system.phone) {
+            // Clear selection from list.
+            if (Device.system.phone) {
                 this.getView().byId("settingsApp").toMaster("settingsView--userSettingMaster");
             }
             this.getView().byId("userSettingsMessagePopoverBtn").setVisible(false);
@@ -895,9 +896,7 @@ sap.ui.define([
         onExit: function () {
             this._oConfigDoable.off();
 
-            Device.orientation.detachHandler(this._fnOrientationChange);
+            Device.orientation.detachHandler(this._fnOrientationChange, this);
         }
-
     });
-
 });

package/src/main/js/sap/ushell/components/shell/Settings/UserSettingsErrorMessagePopover.fragment.xml

@@ -17,7 +17,7 @@
             <Link
                 text="{i18n>contactSupportBtn}"
                 press=".handleContactSupportButtonPress"
-                enabled="{buttonStates>contactSupportBtnEnable}"/>
+                visible="{buttonStates>/contactSupportBtnEnable}"/>
         </MessageItem>
     </MessagePopover>
 </core:FragmentDefinition>

package/src/main/js/sap/ushell/components/shell/Settings/UserSettingsErrorMessagePopover.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2009-2022 SAP SE, All Rights Reserved
+// Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
 sap.ui.define([
     "sap/ui/core/Fragment",

package/src/main/js/sap/ushell/components/shell/Settings/appearance/Appearance.controller.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2009-2022 SAP SE, All Rights Reserved
+// Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
 sap.ui.define([
     "sap/base/Log",
@@ -114,7 +114,6 @@ sap.ui.define([
                         ariaTexts: { headerLabel: resources.i18n.getText("Appearance") }
                     }));
                 }.bind(this));
-
         },
 
         onExit: function () {
@@ -124,10 +123,9 @@ sap.ui.define([
         // Return the ID of the currently selected theme in the theme list.
         // If no selection, return the current user theme.
         _getSelectedTheme: function () {
-            var oSelectedItem = this.getView().byId("themeList").getSelectedItem(),
-                oBindingContext = oSelectedItem ? oSelectedItem.getBindingContext() : null,
-                sThemeId = oBindingContext ? oBindingContext.getProperty("id") : this.oUser.getTheme();
-            return sThemeId;
+            var oSelectedItem = this.getView().byId("themeList").getSelectedItem();
+            var oBindingContext = oSelectedItem ? oSelectedItem.getBindingContext() : null;
+            return oBindingContext ? oBindingContext.getProperty("id") : this.oUser.getTheme();
         },
 
         _getThemeListData: function (aThemeList, sCurrentThemeId) {
@@ -144,8 +142,8 @@ sap.ui.define([
                     name: sName
                 }];
             }
-            var oDarkModeModelData = this.getView().getModel("darkMode").getData(),
-                isDarkModeActive = this._isDarkModeActive();
+            var oDarkModeModelData = this.getView().getModel("darkMode").getData();
+            var isDarkModeActive = this._isDarkModeActive();
             return aThemeList.reduce(function (aList, oTheme) {
                 var oThemeForModel = {
                     id: oTheme.id,
@@ -206,8 +204,9 @@ sap.ui.define([
                     .then(function (oDarkModeSupport) {
                         oDarkModeModelData.enabled = true;
                         oDarkModeModelData.detectionSupported = oDarkModeSupport.canAutomaticallyToggleDarkMode();
-                        // If detection is not supported, e.g. due to the &sap-theme= url parameter, do not enable dark mode detection disregarding the previous user setting.
-                        oDarkModeModelData.detectionEnabled = oDarkModeModelData.detectionSupported && this.oUser.getDetectDarkMode(); // If possible and enabled by the user.
+                        // if detection is not supported, e.g. due to the "&sap-theme=" URL parameter,
+                        // then do not enable dark mode detection disregarding the user setting.
+                        oDarkModeModelData.detectionEnabled = oDarkModeModelData.detectionSupported && this.oUser.getDetectDarkMode();
                         oDarkModeModelData.supportedThemes = this._getSupportedDarkModeThemes(aThemeList, Config.last("/core/darkMode/supportedThemes") || []);
                         oDarkModeModel.setData(oDarkModeModelData);
                         return oDarkModeModel;
@@ -227,10 +226,10 @@ sap.ui.define([
             }, {});
 
             return aSupportedThemePairs.reduce(function (oResult, oPair) {
-                var sLightThemeId = oPair.light,
-                    sDarkThemeId = oPair.dark,
-                    sLightThemeName = oThemeNamesMap[sLightThemeId],
-                    sDarkThemeName = oThemeNamesMap[sDarkThemeId];
+                var sLightThemeId = oPair.light;
+                var sDarkThemeId = oPair.dark;
+                var sLightThemeName = oThemeNamesMap[sLightThemeId];
+                var sDarkThemeName = oThemeNamesMap[sDarkThemeId];
 
                 if (sLightThemeName && sDarkThemeName && !oResult[sLightThemeId] && !oResult[sDarkThemeId]) {
                     // skip if some theme is missing from pair in aThemeList or some of the theme is used (wrong configuration)
@@ -251,18 +250,15 @@ sap.ui.define([
         },
 
         onAfterRendering: function () {
-            var bDarkModeActive = this._isDarkModeActive(),
-                isListSelected = this.getView().getModel("config").getProperty("/themeConfigurable");
-
-            var oList = this.getView().byId("themeList"),
-                items = oList.getItems(),
-                oIcon,
-                sThemeId;
+            var bDarkModeActive = this._isDarkModeActive();
+            var isListSelected = this.getView().getModel("config").getProperty("/themeConfigurable");
+            var oList = this.getView().byId("themeList");
+            var items = oList.getItems();
 
             oList.toggleStyleClass("sapUshellThemeListDisabled", !isListSelected);
-            items.forEach(function (oListItem, index) {
-                sThemeId = oListItem.getCustomData()[0].getValue();
-                oIcon = oListItem.getContent()[0].getItems()[0].getItems()[0];
+            items.forEach(function (oListItem) {
+                var sThemeId = oListItem.getCustomData()[0].getValue();
+                var oIcon = oListItem.getContent()[0].getItems()[0].getItems()[0];
 
                 if (SAP_THEMES[sThemeId]) {
                     oIcon.addStyleClass(SAP_THEMES[sThemeId]);
@@ -272,11 +268,10 @@ sap.ui.define([
         },
 
         _handleThemeApplied: function () {
-
             var oConfigModel = this.getView().getModel("config");
             if (oConfigModel) {
                 oConfigModel.setProperty("/sapUiContentIconColor", Parameters.get("sapUiContentIconColor"));
-                 // readjusts the theme list after the dark mode change
+                // readjusts the theme list after the dark mode change
                 var oUserTheme = this.oUser.getTheme();
                 var aThemeListData = this._getThemeListData(this.aThemeListFromServer, oUserTheme);
 
@@ -288,8 +283,8 @@ sap.ui.define([
             var oConfigModel = this.getView().getModel("config");
 
             if (oConfigModel.getProperty("/themeConfigurable")) {
-                var sUserTheme = this.oUser.getTheme(),
-                    aThemeOptions = this.getView().getModel().getProperty("/options");
+                var sUserTheme = this.oUser.getTheme();
+                var aThemeOptions = this.getView().getModel().getProperty("/options");
                 aThemeOptions.forEach(function (oThemeOption) {
                     oThemeOption.isSelected = sUserTheme === oThemeOption.id;
                 });
@@ -301,7 +296,6 @@ sap.ui.define([
             if (oConfigModel.getProperty("/sizeBehaviorConfigurable")) {
                 oConfigModel.setProperty("/tileSize", this.TILE_SIZE[Config.last("/core/home/sizeBehavior")]);
             }
-
             if (this._oDarkModeModel && this._oDarkModeModel.getProperty("/enabled")) {
                 this._oDarkModeModel.setProperty("/detectionEnabled", this.oUser.getDetectDarkMode());
                 this.oUser.resetChangedProperty("detectDarkMode");
@@ -309,79 +303,77 @@ sap.ui.define([
         },
 
         /**
-         * Complete save method of the properties of the appearance tab
-         * Includes
-         * - preparing each property
-         * - save with the given function
-         * - post processing of save with error handling
+         * Save method for all properties of the "Appearance" tab.
+         * Includes:
+         *   - Preparing each property
+         *   - Saving with the given function
+         *   - Post processing of save with error handling
          *
-         * @param {Function} fnUpdateUserPreferences function used to update properties
-         * @returns {Promise} Promise that, resolves if no error occurs
-         *                                  rejects with error messages
+         * @param {function} fnUpdateUserPreferences Function that updates the properties.
+         * @returns {Promise<undefined|string[]>} Resolves without a value if no error occurs, otherwise rejects with error messages.
          */
         onSave: function (fnUpdateUserPreferences) {
             this._updateUserPreferences = fnUpdateUserPreferences;
-            var oConfigModel = this.getView().getModel("config"),
-                aSavePromises = [];
+            var oConfigModel = this.getView().getModel("config");
+            var aSavePromises = [];
 
             if (oConfigModel.getProperty("/themeConfigurable")) {
                 aSavePromises.push(this.onSaveThemes().then(function () {
-                   EventHub.emit("themeChanged", Date.now());
+                    EventHub.emit("themeChanged", Date.now());
                 }));
             }
 
             if (oConfigModel.getProperty("/contentDensityConfigurable")) {
                 aSavePromises.push(this.onSaveContentDensity());
             }
-
             if (oConfigModel.getProperty("/sizeBehaviorConfigurable")) {
                 aSavePromises.push(this.onSaveTileSize());
             }
-
             if (this._oDarkModeModel && this._oDarkModeModel.getProperty("/enabled")) {
                 aSavePromises.push(this.onSaveDarkModeEnabled());
             }
 
-
             return Promise.all(aSavePromises)
-                .then(function (aResult) {
+                .then(function (aResults) {
                     var aMessages = [];
-                    aResult.forEach(function (arrayEntry) {
-                        if (arrayEntry && BaseObject.isA(arrayEntry, "sap.ui.core.message.Message")) {
-                            aMessages.push(arrayEntry);
+                    aResults.forEach(function (sResult) {
+                        if (sResult && BaseObject.isA(sResult, "sap.ui.core.message.Message")) {
+                            aMessages.push(sResult);
                         }
                     });
-                    return aMessages.length > 0 ? Promise.reject(aMessages) : Promise.resolve();
+                    return (aMessages.length > 0) ? Promise.reject(aMessages) : Promise.resolve();
                 });
         },
+
         onSaveThemesSuccess: function (oUser) {
             oUser.resetChangedProperty("theme");
             return this._applyDarkMode(); // make sure that the dark mode is applied after the theme change
         },
+
         onSaveThemes: function () {
-            var oConfigModel = this.getView().getModel("config"),
-                sNewThemeId = this._getSelectedTheme(),
-                oUser = this.oUser,
-                sOriginalThemeId = oUser.getTheme(User.prototype.constants.themeFormat.ORIGINAL_THEME);
+            var oConfigModel = this.getView().getModel("config");
+            var sNewThemeId = this._getSelectedTheme();
+            var oUser = this.oUser;
+            var sOriginalThemeId = oUser.getTheme(User.prototype.constants.themeFormat.ORIGINAL_THEME);
 
             if (sNewThemeId && sNewThemeId !== sOriginalThemeId && oConfigModel.getProperty("/themeConfigurable")) {
                 oUser.setTheme(sNewThemeId);
                 return this._updateUserPreferences(oUser)
-                .then(function () {
-                    return this.onSaveThemesSuccess(oUser);
-                }.bind(this))
-                .catch(function (sErrorMessage) {
-                    if (!sErrorMessage.includes("THEME")) {
+                    .then(function () {
                         return this.onSaveThemesSuccess(oUser);
-                    }
-                    oUser.setTheme(sOriginalThemeId);
-                    oUser.resetChangedProperty("theme");
-                    Log.error("Can not save selected theme", sErrorMessage);
-                    throw new Message({
-                        type: MessageType.Error,
-                        description: sErrorMessage
-                    });
-                }.bind(this));
+                    }.bind(this))
+                    .catch(function (sErrorMessage) {
+                        if (!sErrorMessage.includes("THEME")) {
+                            return this.onSaveThemesSuccess(oUser);
+                        }
+                        oUser.setTheme(sOriginalThemeId);
+                        oUser.resetChangedProperty("theme");
+                        Log.error("Can not save selected theme", sErrorMessage);
+                        throw new Message({
+                            type: MessageType.Error,
+                            description: sErrorMessage
+                        });
+                    }.bind(this));
             }
             return Promise.resolve();
         },
@@ -405,11 +397,11 @@ sap.ui.define([
         },
 
         onSaveContentDensity: function () {
-            var oConfigModel = this.getView().getModel("config"),
-                oUser = this.oUser,
-                sNewContentDensity = oConfigModel.getProperty("/isCozyContentMode") ? "cozy" : "compact",
-                sUserContentDensity = oUser.getContentDensity();
-                Log.debug("[000] onSaveContentDensity", "Appearance.controller");
+            var oConfigModel = this.getView().getModel("config");
+            var oUser = this.oUser;
+            var sNewContentDensity = oConfigModel.getProperty("/isCozyContentMode") ? "cozy" : "compact";
+            var sUserContentDensity = oUser.getContentDensity();
+            Log.debug("[000] onSaveContentDensity", "Appearance.controller");
             if (sNewContentDensity !== sUserContentDensity && oConfigModel.getProperty("/contentDensityConfigurable")) {
                 oUser.setContentDensity(sNewContentDensity);
                 Log.debug("[000] onSaveContentDensity: sNewContentDensity", sNewContentDensity, "Appearance.controller");
@@ -434,9 +426,9 @@ sap.ui.define([
         },
 
         onSaveTileSize: function () {
-            var oConfigModel = this.getView().getModel("config"),
-                sNewSizeBehavior = this.TILE_SIZE.getName(oConfigModel.getProperty("/tileSize")), // take string value, not index
-                sCurrentSizeBehavior = Config.last("/core/home/sizeBehavior");
+            var oConfigModel = this.getView().getModel("config");
+            var sNewSizeBehavior = this.TILE_SIZE.getName(oConfigModel.getProperty("/tileSize")); // take string value, not index
+            var sCurrentSizeBehavior = Config.last("/core/home/sizeBehavior");
             if (sNewSizeBehavior && sNewSizeBehavior !== sCurrentSizeBehavior && oConfigModel.getProperty("/sizeBehaviorConfigurable")) {
                 return new Promise(function (resolve, reject) {
                     this.writeToPersonalization("flp.settings.FlpSettings", "sizeBehavior", sNewSizeBehavior)
@@ -451,13 +443,13 @@ sap.ui.define([
                             resolve();
                         })
                         .fail(function (sErrorMessage, parsedErrorInformation) {
-                            Log.error("Can not save tile size configuration", sErrorMessage);
+                            Log.error("Cannot save tile size configuration", sErrorMessage);
                             var oMessage = new Message({
-                                    type: MessageType.Error,
-                                    description: sErrorMessage,
-                                    message: parsedErrorInformation.message.value,
-                                    date: parsedErrorInformation.innererror.timestamp,
-                                    httpStatus: parsedErrorInformation.httpStatus
+                                type: MessageType.Error,
+                                description: sErrorMessage,
+                                message: parsedErrorInformation.message.value,
+                                date: parsedErrorInformation.innererror.timestamp,
+                                httpStatus: parsedErrorInformation.httpStatus
                             });
                             reject(oMessage);
                         });
@@ -465,16 +457,17 @@ sap.ui.define([
             }
             return Promise.resolve();
         },
+
         onSaveDarkModeEnabledSuccess: function (oUser, sNewDarkModeEnabled) {
             return sap.ushell.Container.getServiceAsync("DarkModeSupport")
-            .then(function (oDarkModeSupport) {
-                oUser.resetChangedProperty("detectDarkMode");
-                if (sNewDarkModeEnabled) {
-                    oDarkModeSupport.enableDarkModeBasedOnSystem();
-                } else {
-                    oDarkModeSupport.disableDarkModeBasedOnSystem();
-                }
-            });
+                .then(function (oDarkModeSupport) {
+                    oUser.resetChangedProperty("detectDarkMode");
+                    if (sNewDarkModeEnabled) {
+                        oDarkModeSupport.enableDarkModeBasedOnSystem();
+                    } else {
+                        oDarkModeSupport.disableDarkModeBasedOnSystem();
+                    }
+                });
         },
 
         // Save the value of the Enable Auto Dark Mode Detection switch
@@ -511,20 +504,18 @@ sap.ui.define([
          *
          * @param {string} sContainer The name of the container.
          * @param {string} sItem The name of the item.
-         * @param {*} vValue The value to be posted to the personalization service.
+         * @param {any} vValue The value to be posted to the personalization service.
          * @returns {Promise} Resolves once the personalization data is written. Rejected if the service fails in doing so.
          */
         writeToPersonalization: function (sContainer, sItem, vValue) {
             return jQuery.when(
-                    this.getPersonalizer(sContainer, sItem)
-                        .then(function (oPersonalizer) {
-                            return oPersonalizer.setPersData(vValue);
-                        }))
-                        .catch(function (oError) {
-                            Log.error("Personalization service does not work:");
-                            Log.error(oError.name + ": " + oError.message);
-                        }
-                );
+                this.getPersonalizer(sContainer, sItem).then(function (oPersonalizer) {
+                    return oPersonalizer.setPersData(vValue);
+                })
+            ).catch(function (oError) {
+                Log.error("Personalization service does not work:");
+                Log.error(oError.name + ": " + oError.message);
+            });
         },
 
         /**
@@ -532,7 +523,7 @@ sap.ui.define([
          *
          * @param {string} sContainer The container ID.
          * @param {string} sItem The item ID.
-         * @returns {Promise<object>} A promise which resolves with a new or cached Personalizer instance.
+         * @returns {Promise<object>} Resolves with a new or cached Personalizer instance.
          */
         getPersonalizer: function (sContainer, sItem) {
             var sKey = sContainer + "-" + sItem;
@@ -561,7 +552,6 @@ sap.ui.define([
                 }.bind(this));
         },
 
-
         // applies dark mode after the user has selected a new theme
         _applyDarkMode: function () {
             var oModel = this._oDarkModeModel;
@@ -583,7 +573,7 @@ sap.ui.define([
             return oModelData.enabled && oModelData.detectionSupported && oModelData.detectionEnabled;
         },
 
-        changeSystemModeDetection: function (oEvent) {
+        changeSystemModeDetection: function () {
             // update the theme list after the dark mode detection is changed by the user
             var oUserTheme = this._getSelectedTheme();
             this.getView().getModel().setProperty("/options", this._getThemeListData(this.aThemeListFromServer, oUserTheme));

package/src/main/js/sap/ushell/components/shell/Settings/appearance/AppearanceEntry.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2009-2022 SAP SE, All Rights Reserved
+// Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
 sap.ui.define([
     "sap/ui/core/mvc/XMLView",

package/src/main/js/sap/ushell/components/shell/Settings/homepage/HomepageEntry.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2009-2022 SAP SE, All Rights Reserved
+// Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
 sap.ui.define([
     "sap/base/Log",

package/src/main/js/sap/ushell/components/shell/Settings/notifications/NotificationsEntry.js

@@ -1,4 +1,4 @@
-// Copyright (c) 2009-2022 SAP SE, All Rights Reserved
+// Copyright (c) 2009-2023 SAP SE, All Rights Reserved
 
 sap.ui.define([
     "sap/ui/core/mvc/XMLView",