@sapui5/sap.ui.vk 1.134.0 → 1.135.0

package/src/sap/ui/vk/svg/Viewport.js

@@ -74,7 +74,7 @@ sap.ui.define([
 	 *
 	 * @public
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @extends sap.ui.vk.ViewportBase
 	 * @alias sap.ui.vk.svg.Viewport
 	 */

package/src/sap/ui/vk/thirdparty/pdf.worker.js

@@ -54306,7 +54306,7 @@ class PDFDocument {
     if (PDF_VERSION_REGEXP.test(version)) {
       this._version = version;
     } else {
-      warn(`Invalid PDF header version: 1.134.0`);
+      warn(`Invalid PDF header version: 1.135.0`);
     }
   }
   parseStartXRef() {

package/src/sap/ui/vk/threejs/AnimationHelper.js

@@ -35,8 +35,7 @@ sap.ui.define([
 	 *
 	 * @private
 	 * @author SAP SE
-	 * @version 1.134.0
-	 * @experimental Since 1.60.0 This class is experimental and might be modified or removed in future versions.
+	 * @version 1.135.0
 	 */
 	var AnimationHelper = function() {
 	};

package/src/sap/ui/vk/threejs/BaseNodeProxy.js

@@ -35,7 +35,7 @@ sap.ui.define([
 	 *
 	 * @public
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @extends sap.ui.vk.BaseNodeProxy
 	 * @implements sap.ui.base.Poolable
 	 * @alias sap.ui.vk.threejs.BaseNodeProxy

package/src/sap/ui/vk/threejs/Billboard.js

@@ -39,10 +39,9 @@ sap.ui.define([
 	 *
 	 * @private
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @extends sap.ui.base.ManagedObject
 	 * @alias sap.ui.vk.threejs.Billboard
-	 * @experimental Since 1.60.0 This class is experimental and might be modified or removed in future versions.
 	 */
 	var Billboard = BaseObject.extend("sap.ui.vk.threejs.Billboard", /** @lends sap.ui.vk.threejs.Billboard.prototype */ {
 		metadata: {

package/src/sap/ui/vk/threejs/Callout.js

@@ -39,10 +39,9 @@ sap.ui.define([
 	 *
 	 * @private
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @extends sap.ui.vk.threejs.Billboard
 	 * @alias sap.ui.vk.threejs.Callout
-	 * @experimental Since 1.60.0 This class is experimental and might be modified or removed in future versions.
 	 */
 	var Callout = Billboard.extend("sap.ui.vk.threejs.Callout", /** @lends sap.ui.vk.threejs.Callout.prototype */ {
 		metadata: {

package/src/sap/ui/vk/threejs/ContentDeliveryService.js

@@ -33,7 +33,7 @@ sap.ui.define([
 	 * @class Provides a class to communicate with content delivery service.
 	 * @private
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @extends sap.ui.base.ManagedObject
 	 * @alias sap.ui.vk.threejs.ContentDeliveryService
 	 */

package/src/sap/ui/vk/threejs/ContentManager.js

@@ -112,7 +112,7 @@ sap.ui.define([
 	 * @param {object} [mSettings] Initial settings for the new ContentManager object.
 	 * @protected
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @extends sap.ui.vk.ContentManager
 	 * @alias sap.ui.vk.threejs.ContentManager
 	 * @since 1.50.0

package/src/sap/ui/vk/threejs/DetailView.js

@@ -33,10 +33,9 @@ sap.ui.define([
 	 *
 	 * @private
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @extends sap.ui.base.ManagedObject
 	 * @alias sap.ui.vk.threejs.DetailView
-	 * @experimental Since 1.60.0 This class is experimental and might be modified or removed in future versions.
 	 */
 	var DetailView = BaseObject.extend("sap.ui.vk.threejs.DetailView", /** @lends sap.ui.vk.threejs.DetailView.prototype */ {
 		metadata: {

package/src/sap/ui/vk/threejs/HighlightPlayer.js

@@ -24,10 +24,9 @@ sap.ui.define([
 	 *
 	 * @private
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @extends sap.ui.base.Object
 	 * @alias sap.ui.vk.threejs.HighlightPlayer
-	 * @experimental Since 1.67.0 This class is experimental and might be modified or removed in future versions.
 	 */
 	var HighlightPlayer = BaseObject.extend("sap.ui.vk.threejs.HighlightPlayer", /** @lends sap.ui.vk.three.HighlightPlayer.prototype */ {
 
@@ -106,38 +105,32 @@ sap.ui.define([
 		}
 		this._timeElapsed = time - this._startTime;
 
-		var that = this;
-
 		var completedHighlights = [];
 		this._highlightsNodesMap.forEach(function(nodesInfo, highlight) {
-			var resColor = highlight.getColour(that._timeElapsed / 1000.0);
-			var nodes = nodesInfo.nodes, ni;
-			if (resColor !== undefined) {
-				for (ni = 0; ni < nodes.length; ni++) {
-					nodes[ni]._vkSetHighlightColor(resColor.colour);
-				}
-			}
+			const res = highlight.evaluate(this._timeElapsed / 1000.0);
 
-			var resOpacity = highlight.getOpacity(that._timeElapsed / 1000.0);
-			if (resOpacity !== undefined) {
-				for (ni = 0; ni < nodes.length; ni++) {
-					nodes[ni]._vkSetOpacity(resOpacity.opacity);
+			nodesInfo.nodes.forEach(function(node) {
+				if (res.color != null) {
+					node._vkSetHighlightColor(res.color);
 				}
-
-				if (resOpacity.isCompleted && highlight.isFadeOut() && nodesInfo.hiddenNodes !== undefined) {
-					that._viewStateManager.setVisibilityState(nodesInfo.hiddenNodes, false, false);
+				if (res.opacity != null) {
+					node._vkSetOpacity(res.opacity);
 				}
-			}
+			});
 
-			if ((resColor === undefined || resColor.isCompleted) && (resOpacity === undefined || resOpacity.isCompleted)) {
-				completedHighlights.push(highlight);
+			if (res.isCompleted) {
+				if (highlight.isFadeOut() && nodesInfo.hiddenNodes !== undefined) {
+					this._viewStateManager.setVisibilityState(nodesInfo.hiddenNodes, false, false);
+				}
+				if (highlight.isFadeInOut()) {
+					completedHighlights.push(highlight);
+				}
 			}
-
-		});
+		}, this);
 
 		completedHighlights.forEach(function(highlight) {
-			that._highlightsNodesMap.delete(highlight);
-		});
+			this._highlightsNodesMap.delete(highlight);
+		}, this);
 
 		if (this._highlightsNodesMap.size === 0) {
 			this._state = HighlightDisplayState.stopped;

package/src/sap/ui/vk/threejs/Material.js

@@ -28,13 +28,10 @@ sap.ui.define([
 	/**
 	 * Constructor for a new Material.
 	 *
-	 *
 	 * @class Provides the interface for the material.
-	 *
-	 *
 	 * @public
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @extends sap.ui.vk.Material
 	 * @alias sap.ui.vk.threejs.Material
 	 * @experimental Since 1.60.0 This class is experimental and might be modified or removed in future versions.

package/src/sap/ui/vk/threejs/NodeHierarchy.js

@@ -55,7 +55,7 @@ sap.ui.define([
 	 *
 	 * @public
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @extends sap.ui.vk.NodeHierarchy
 	 * @alias sap.ui.vk.threejs.NodeHierarchy
 	 */

package/src/sap/ui/vk/threejs/NodeProxy.js

@@ -42,7 +42,7 @@ sap.ui.define([
 	 *
 	 * @public
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @extends sap.ui.vk.NodeProxy
 	 * @alias sap.ui.vk.threejs.NodeProxy
 	 */
@@ -252,33 +252,14 @@ sap.ui.define([
 			}
 
 			if (nodeRef.material !== undefined) {
-				if (nodeRef.userData.highlightColor !== undefined) {
-					if (nodeRef.userData.originalMaterial.side) {
-						materialRef.side = nodeRef.userData.originalMaterial.side;
-					}
-					nodeRef.userData.originalMaterial = materialRef;
-					materialRef.userData.materialUsed++;
-
-					nodeRef.material = materialRef.clone();
-					var c = abgrToColor(nodeRef.userData.highlightColor);
-					nodeRef.material.color.lerp(new THREE.Color(c.red / 255.0, c.green / 255.0, c.blue / 255.0), c.alpha);
-					// when highlightColor = 0: total transparent, so do not change original emissive and specular
-					if (materialRef.userData.defaultHighlightingEmissive && nodeRef.userData.highlightColor !== 0) {
-						nodeRef.material.emissive.copy(materialRef.userData.defaultHighlightingEmissive);
-					}
-					if (materialRef.userData.defaultHighlightingSpecular && nodeRef.userData.highlightColor !== 0) {
-						nodeRef.material.specular.copy(materialRef.userData.defaultHighlightingSpecular);
-					}
-				} else {
-					if (nodeRef.material.side) {
-						materialRef.side = nodeRef.material.side;
-					}
-					nodeRef.material = materialRef;
-					materialRef.userData.materialUsed++;
-					delete nodeRef.userData.originalMaterial;
+				if (nodeRef.material.side) {
+					materialRef.side = nodeRef.material.side;
 				}
+				nodeRef.material = materialRef;
+				materialRef.userData.materialUsed++;
+				delete nodeRef.userData.originalMaterial;
 
-				nodeRef._vkUpdateMaterialOpacity(); // todo: probably should be _vkUpdateMaterialColorAndOpacity, not _vkUpdateMaterialOpacity
+				nodeRef._vkUpdateMaterialColorAndOpacity();
 			}
 		};
 

package/src/sap/ui/vk/threejs/OrthographicCamera.js

@@ -24,7 +24,7 @@ sap.ui.define([
 	 *
 	 * @public
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @extends sap.ui.vk.OrthographicCamera
 	 * @alias sap.ui.vk.threejs.OrthographicCamera
 	 * @since 1.52.0

package/src/sap/ui/vk/threejs/ParametricGenerators.js

@@ -27,7 +27,7 @@ sap.ui.define([
 		},
 
 		generateBox: function(boxJson, material) {
-			const mesh = new THREE.Mesh(new THREE.BoxGeometry(boxJson.width, boxJson.length, boxJson.height), material || undefined);
+			const mesh = new THREE.Mesh(new THREE.BoxGeometry(boxJson.length, boxJson.width, boxJson.height), material || undefined);
 			mesh.name = "box";
 			return mesh;
 		},

package/src/sap/ui/vk/threejs/PerspectiveCamera.js

@@ -24,7 +24,7 @@ sap.ui.define([
 	 *
 	 * @public
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @extends sap.ui.vk.PerspectiveCamera
 	 * @alias sap.ui.vk.threejs.PerspectiveCamera
 	 * @since 1.52.0

package/src/sap/ui/vk/threejs/PointCloudGroup.js

@@ -26,9 +26,8 @@ sap.ui.define([
 	 * @abstract
 	 * @private
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @alias sap.ui.vk.threejs.PointCloudGroup
-	 * @experimental Since 1.118.0 This class is experimental and might be modified or removed in future versions.
 	 */
 	const PointCloudGroup = function(settings) {
 		this._position = new THREE.Vector3();

package/src/sap/ui/vk/threejs/PolylineGeometry.js

@@ -13,7 +13,7 @@ sap.ui.define([
 ) {
 	"use strict";
 
-	function PolylineGeometry() {
+	function PolylineGeometry(outlineGeometry = null) {
 		var _this = new THREE.InstancedBufferGeometry();
 
 		Object.setPrototypeOf(_this, PolylineGeometry.prototype);
@@ -28,6 +28,34 @@ sap.ui.define([
 		_this.setAttribute("position", new THREE.Float32BufferAttribute(positions, 3));
 		_this.setAttribute("uv", new THREE.Float32BufferAttribute(uvs, 2));
 
+		const positionAttribute = outlineGeometry ? outlineGeometry.getAttribute("position") : null;
+		if (positionAttribute && positionAttribute.count > 0) {
+			const normal1 = outlineGeometry.getAttribute("normal1").array;
+			const normal2 = outlineGeometry.getAttribute("normal2").array;
+			const positions = [];
+			const vertexCount = positionAttribute.count;
+			const pa = positionAttribute.array;
+			for (let i = 0; i < vertexCount; ++i) {
+				positions.push(new THREE.Vector3(pa[i * 3], pa[i * 3 + 1], pa[i * 3 + 2]));
+			}
+
+			const edgeCount = vertexCount / 2;
+			const indices = [];
+			const normals = new Float32Array(6 * edgeCount);
+			for (let j = 0; j < edgeCount; ++j) {
+				indices.push(j * 2);
+				indices.push(j * 2 + 1);
+				normals[j * 6] = normal1[j * 6];
+				normals[j * 6 + 1] = normal1[j * 6 + 1];
+				normals[j * 6 + 2] = normal1[j * 6 + 2];
+				normals[j * 6 + 3] = normal2[j * 6];
+				normals[j * 6 + 4] = normal2[j * 6 + 1];
+				normals[j * 6 + 5] = normal2[j * 6 + 2];
+			}
+
+			_this.setVertices(positions, indices, normals);
+		}
+
 		return _this;
 	}
 

package/src/sap/ui/vk/threejs/Scene.js

@@ -16,6 +16,7 @@ sap.ui.define([
 	"./PolylineMaterial",
 	"./PolylineMesh",
 	"./ThreeUtils",
+	"../totara/TotaraUtils",
 	"sap/base/util/uid"
 ], function(
 	Log,
@@ -27,6 +28,7 @@ sap.ui.define([
 	PolylineMaterial,
 	PolylineMesh,
 	ThreeUtils,
+	TotaraUtils,
 	uid
 ) {
 	"use strict";
@@ -41,7 +43,7 @@ sap.ui.define([
 	 * @param {THREE.Scene} scene The three.js scene object.
 	 * @public
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @extends sap.ui.vk.Scene
 	 * @alias sap.ui.vk.threejs.Scene
 	 */
@@ -70,6 +72,8 @@ sap.ui.define([
 			this._initialView = null;
 			this._materialMap = new Map();
 
+			this._outlineGeometryToNodes = new Map(); // array of mesh nodes that have this geometry
+
 			// A storage (map) with all loaded annotations.
 			//
 			// annotationId -> { annotationInfo, node, attachment, targetNodes[] }
@@ -227,6 +231,7 @@ sap.ui.define([
 	};
 
 	Scene.prototype.destroy = function() {
+		this._outlineGeometryToNodes.clear();
 		this.clearThreeScene();
 		// if (this._sceneBuilder) {
 		// 	this._sceneBuilder.cleanup();
@@ -668,7 +673,7 @@ sap.ui.define([
 		return rg ? [rg.lastVertex - rg.firstVertex, rg.count] : [positionAttribute.count, geometry.index ? geometry.index.array.length : positionAttribute.count];
 	}
 
-	function addMeshVerticesIndices(resultVertices, resultIndices, resultCounts, node, isChild) {
+	function addMeshVerticesIndices(resultVertices, resultIndices, resultCounts, node, isChild, geometryToNodesMap) {
 		const geometry = node.isMesh && (!!node.userData.skipIt === isChild) && !nodeBoxIsNull(node) && node.geometry;
 		const positionAttribute = geometry && geometry.isBufferGeometry && geometry.getAttribute("position");
 		if (!positionAttribute) {
@@ -681,6 +686,10 @@ sap.ui.define([
 			tm = node.matrix;
 		}
 
+		if (geometryToNodesMap) {
+			TotaraUtils.pushElementIntoMapArray(geometryToNodesMap, node.userData.geometryId, isChild ? node.parent : node);
+		}
+
 		const rg = node.userData.renderGroup;
 		const vertexStart = rg ? rg.firstVertex : 0;
 		const vertexCount = rg ? (rg.lastVertex - vertexStart) : positionAttribute.count;
@@ -723,32 +732,58 @@ sap.ui.define([
 		resultCounts[1] += indexCount;
 	}
 
-	function createMergedGeometry(node) {
-		let i, childCount = node.children.length;
-		let [vertexCount, indexCount] = countMeshVerticesIndices(node, false);
-		for (i = 0; i < childCount; ++i) {
-			const [childVertexCount, childIndexCount] = countMeshVerticesIndices(node.children[i], true);
-			vertexCount += childVertexCount;
-			indexCount += childIndexCount;
-		}
+	function _addOutlineGeometry(node, isPolylineMesh, outlineMaterial, geometryToNodesMap) {
+		try {
+			// create merged geometry first
+			let i, childCount = node.children.length;
+			let [vertexCount, indexCount] = countMeshVerticesIndices(node, false);
+			for (i = 0; i < childCount; ++i) {
+				const [childVertexCount, childIndexCount] = countMeshVerticesIndices(node.children[i], true);
+				vertexCount += childVertexCount;
+				indexCount += childIndexCount;
+			}
 
-		if (!vertexCount) {
-			return null;
-		}
+			if (!vertexCount) {
+				return;
+			}
 
-		const vertices = new Float32Array(vertexCount * 3);
-		const indices = new Uint32Array(indexCount);
-		let counts = [0, 0]; // [0] - vertex, [1] - index
+			const vertices = new Float32Array(vertexCount * 3);
+			const indices = new Uint32Array(indexCount);
+			let counts = [0, 0]; // [0] - vertex, [1] - index
 
-		addMeshVerticesIndices(vertices, indices, counts, node, false);
-		for (i = 0; i < childCount; ++i) {
-			addMeshVerticesIndices(vertices, indices, counts, node.children[i], true);
-		}
+			addMeshVerticesIndices(vertices, indices, counts, node, false, geometryToNodesMap);
+			for (i = 0; i < childCount; ++i) {
+				addMeshVerticesIndices(vertices, indices, counts, node.children[i], true, geometryToNodesMap);
+			}
+
+			const geometry = new THREE.BufferGeometry();
+			geometry.setAttribute("position", new THREE.BufferAttribute(vertices, 3));
+			geometry.setIndex(new THREE.BufferAttribute(indices, 1));
+
+			// now create the outline geometry from it
+			const outlineGeometry = new OutlineGeometry(geometry);
+			const positionAttribute = outlineGeometry.getAttribute("position");
+			if (positionAttribute && positionAttribute.count > 0) {
+				let line;
+				if (isPolylineMesh) {
+					const polylineGeometry = new PolylineGeometry(outlineGeometry);
+					polylineGeometry.boundingBox = new THREE.Box3(); // set empty bounding box, disable hit testing
+					line = new PolylineMesh(polylineGeometry, outlineMaterial);
+				} else {
+					outlineGeometry.boundingBox = new THREE.Box3(); // set empty bounding box, disable hit testing
+					line = new THREE.LineSegments(outlineGeometry, outlineMaterial);
+				}
 
-		const geometry = new THREE.BufferGeometry();
-		geometry.setAttribute("position", new THREE.BufferAttribute(vertices, 3));
-		geometry.setIndex(new THREE.BufferAttribute(indices, 1));
-		return geometry;
+				line.isOutline = true;
+				line.userData.skipIt = true;
+				line.renderOrder = node.renderOrder + 0.5;
+				line.matrixWorldNeedsUpdate = true;
+				node.add(line);
+				node.hasOutline = true;
+			}
+		} catch (err) {
+			Log.error("Unable to create outline geometry for node " + node.name, err);
+		}
 	}
 
 	function setMeshMaterial(node, newMaterial) {
@@ -794,58 +829,8 @@ sap.ui.define([
 					// }
 
 					if (!node.hasOutline) {// create outline
-						try {
-							var mergedGeometry = createMergedGeometry(node);
-							if (mergedGeometry !== null) {
-								node.hasOutline = true;
-								var outlineGeometry = new OutlineGeometry(mergedGeometry);
-								var positionAttribute = outlineGeometry.getAttribute("position");
-								if (positionAttribute && positionAttribute.count > 0) {
-									let line;
-
-									if (this._illustrationLineWidth > 0.0) {
-										// convert to PolylineGeometry
-										const normal1 = outlineGeometry.getAttribute("normal1").array;
-										const normal2 = outlineGeometry.getAttribute("normal2").array;
-										const positions = [];
-										const vertexCount = positionAttribute.count;
-										const pa = positionAttribute.array;
-										for (let i = 0; i < vertexCount; ++i) {
-											positions.push(new THREE.Vector3(pa[i * 3], pa[i * 3 + 1], pa[i * 3 + 2]));
-										}
-
-										const edgeCount = vertexCount / 2;
-										const indices = [];
-										const normals = new Float32Array(6 * edgeCount);
-										for (let j = 0; j < edgeCount; ++j) {
-											indices.push(j * 2);
-											indices.push(j * 2 + 1);
-											normals[j * 6] = normal1[j * 6];
-											normals[j * 6 + 1] = normal1[j * 6 + 1];
-											normals[j * 6 + 2] = normal1[j * 6 + 2];
-											normals[j * 6 + 3] = normal2[j * 6];
-											normals[j * 6 + 4] = normal2[j * 6 + 1];
-											normals[j * 6 + 5] = normal2[j * 6 + 2];
-										}
-
-										const polylineGeometry = new PolylineGeometry();
-										polylineGeometry.setVertices(positions, indices, normals);
-										polylineGeometry.boundingBox = new THREE.Box3(); // set empty bounding box, disable hit testing
-										line = new PolylineMesh(polylineGeometry, this._outlineThickMaterial);
-									} else {
-										outlineGeometry.boundingBox = new THREE.Box3(); // set empty bounding box, disable hit testing
-										line = new THREE.LineSegments(outlineGeometry, this._outlineMaterial);
-									}
-
-									line.isOutline = true;
-									line.renderOrder = node.renderOrder + 0.5;
-									line.matrixWorldNeedsUpdate = true;
-									node.add(line);
-								}
-							}
-						} catch (err) {
-							Log.error("Unable to create outline geometry for node " + node.name, err);
-						}
+						const isThickLines = this._illustrationLineWidth > 0.0;
+						_addOutlineGeometry(node, isThickLines, isThickLines ? this._outlineThickMaterial : this._outlineMaterial, this._outlineGeometryToNodes);
 					}
 					if (node.isMesh && node.material && !node.material.isLineBasicMaterial && !node.material.isLineMaterial) {// update material
 						switch (renderMode) {
@@ -887,6 +872,28 @@ sap.ui.define([
 		}
 	};
 
+	Scene.prototype.onGeometryUpdated = function(geometryId) {
+		const nodes = this._outlineGeometryToNodes.get(geometryId);
+		if (nodes) {
+			for (let ni = 0; ni < nodes.length; ++ni) {
+				const node = nodes[ni];
+				const ch = node.children;
+				for (let i = ch.length - 1; i >= 0; --i) {
+					const outlineNode = ch[i];
+					if (outlineNode.isOutline) {
+						const isPolylineMesh = outlineNode.isPolylineMesh;
+						const outlineMaterial = outlineNode.material;
+						node.remove(outlineNode);
+
+						// must rebuild the outline mesh used in illustration rendering as it was built off a proxy mesh
+						_addOutlineGeometry(node, isPolylineMesh, outlineMaterial, null);
+						break;
+					}
+				}
+			}
+		}
+	};
+
 	/**
 	 * Get initial view
 	 *

package/src/sap/ui/vk/threejs/SceneBuilder.js

@@ -104,8 +104,7 @@ sap.ui.define([
 	 *
 	 * @private
 	 * @author SAP SE
-	 * @version 1.134.0
-	 * @experimental Since 1.60.0 This class is experimental and might be modified or removed in future versions.
+	 * @version 1.135.0
 	 */
 	var SceneBuilder = function(rootNode, contentResource, resolve, reject) {
 		this._rootNode = rootNode;
@@ -386,26 +385,12 @@ sap.ui.define([
 		return matrix;
 	};
 
-	var DefaultHighlightingEmissive = {
-		r: 0.0235,
-		g: 0.0235,
-		b: 0.0235
-	};
-
-	var DefaultHighlightingSpecular = {
-		r: 0.0602,
-		g: 0.0602,
-		b: 0.0602
-	};
-
 	////////////////////////////////////////////////////////////////////////////////////////////////////////
 	// Create a place-holder material, whose value should be updated when material data is available
 	SceneBuilder.prototype._createTemporaryMaterial = function(materialId, materialType) {
 		var vkMaterial = new Material(materialType || MaterialType.MeshPhongMaterial);
 		var material = vkMaterial.getMaterialRef();
 		material.vertexColors = true; // note: we will turn vertex colors in the shader if geometry.attributes.color is not defined
-		material.userData.defaultHighlightingEmissive = DefaultHighlightingEmissive;
-		material.userData.defaultHighlightingSpecular = DefaultHighlightingSpecular;
 		material.userData.materialUsed = 0;
 		material.userData.materialId = materialId;
 		material.userData.toBeUpdated = true;
@@ -1558,7 +1543,7 @@ sap.ui.define([
 
 		if (geoInfo.isPointCloud) { // update scene point scale
 			const nativeSceneUD = this._vkScene.getSceneRef().userData;
-			const points = geoInfo.data.points;
+			const points = data.points;
 			const box = new THREE.Box3().setFromArray(points); // todo: pass bbox from loader instead of recomputing
 
 			nativeSceneUD.pointCloudBoundingBox ??= new THREE.Box3();
@@ -1613,14 +1598,16 @@ sap.ui.define([
 				var meshId = submeshInfo.meshId;
 				var nodes = this._meshNodes.get(meshId);
 				if (nodes) {
-					// "nodes" is a list of all meshes that have this geometry
-					for (var ni = 0; ni < nodes.length; ni++) {
+					// "nodes" is a list of all meshes that have this geometry and already exist in the scene
+					for (let ni = 0; ni < nodes.length; ++ni) {
 						// "nodes[ni].children" are all submeshes of a mesh
 						replaceSubmeshGeometry(nodes[ni].children,
 							this._geometrySubmeshIndices.get(nodes[ni].userData.nodeId + ":" + geometryId),
 							geometryId, geometryDescriptor, nativeSceneUD, true);
 					}
 				}
+
+				// "submeshes" are copies that don't exist in the scene (it is not attached to any nodes)
 				var submeshes = this._meshSubmeshes.get(meshId);
 				if (submeshes) {
 					replaceSubmeshGeometry(submeshes, submeshInfo.submeshIndex,
@@ -1631,6 +1618,7 @@ sap.ui.define([
 			this._geometryProxies.delete(geometryId);
 		}
 
+		this._vkScene.onGeometryUpdated(geometryId);
 		if (this._fireSceneUpdated) {
 			this._fireSceneUpdated(skipHierarchyProcessing);
 		}
@@ -2837,9 +2825,6 @@ sap.ui.define([
 		// exact pixel to pixel equality seems to be impossible without using custom shaders
 		// material.specular.multiplyScalar(3.0 / (material.shininess * 0.5 + 1.0));
 
-		material.userData.defaultHighlightingEmissive = DefaultHighlightingEmissive;
-		material.userData.defaultHighlightingSpecular = DefaultHighlightingSpecular;
-
 		material.userData.imageIdsToAddAsTexture = new Set();
 		var info, infos;
 		if (materialInfo.textureDiffuse) {

package/src/sap/ui/vk/threejs/Texture.js

@@ -18,13 +18,10 @@ sap.ui.define([
 	/**
 	 * Constructor for a new Material.
 	 *
-	 *
 	 * @class Provides the interface for the material.
-	 *
-	 *
 	 * @public
 	 * @author SAP SE
-	 * @version 1.134.0
+	 * @version 1.135.0
 	 * @extends sap.ui.vk.Texture
 	 * @alias sap.ui.vk.threejs.Texture
 	 * @experimental Since 1.60.0 This class is experimental and might be modified or removed in future versions.