@sapui5/sap.suite.ui.microchart 1.90.6 → 1.93.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sapui5/sap.suite.ui.microchart",
-  "version": "1.90.6",
+  "version": "1.93.1",
   "description": "SAPUI5 Library sap.suite.ui.microchart",
   "homepage": "https://sap.github.io/ui5-tooling/pages/SAPUI5/",
   "author": "SAP SE (https://www.sap.com)",

package/src/sap/suite/ui/microchart/.library

@@ -6,7 +6,7 @@
 	<copyright>SAPUI5
 
 (c) Copyright 2009-2021 SAP SE. All rights reserved</copyright>
-	<version>1.90.6</version>
+	<version>1.93.1</version>
 
 	<documentation>UI5 library: sap.suite.ui.microchart</documentation>
 

package/src/sap/suite/ui/microchart/AreaMicroChart.js

@@ -35,7 +35,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 * @since 1.34
 	 *
 	 * @public

package/src/sap/suite/ui/microchart/AreaMicroChartItem.js

@@ -20,7 +20,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Element
 	 *
 	 * @author SAP SE
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 * @since 1.34
 	 *
 	 * @public

package/src/sap/suite/ui/microchart/AreaMicroChartLabel.js

@@ -17,7 +17,7 @@ sap.ui.define(['./library', 'sap/ui/core/Element'],
 	 * Displays or hides the labels for start and end dates, start and end values, and minimum and maximum values.
 	 * @extends sap.ui.core.Element
 	 *
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 * @since 1.34
 	 *
 	 * @public

package/src/sap/suite/ui/microchart/AreaMicroChartPoint.js

@@ -18,7 +18,7 @@ sap.ui.define(['./library', 'sap/ui/core/Element'],
 	 * @extends sap.ui.core.Element
 	 *
 	 * @author SAP SE
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 * @since 1.34
 	 *
 	 * @public

package/src/sap/suite/ui/microchart/AreaMicroChartRenderer.js

@@ -55,8 +55,7 @@ sap.ui.define([
 			oRm.openEnd();
 
 			if (bShouldRenderTopLabels) {
-				oRm.openStart("div");
-				oRm.attr("id", oControl.getId() + "-top-labels");
+				oRm.openStart("div", oControl.getId() + "-top-labels");
 				oRm.class("sapSuiteAMCLabels");
 				oRm.class("sapSuiteAMCPositionTop");
 				oRm.openEnd();
@@ -77,8 +76,7 @@ sap.ui.define([
 			}
 
 			if (bShouldRenderLeftLabels) {
-				oRm.openStart("div");
-				oRm.attr("id", oControl.getId() + "-left-labels");
+				oRm.openStart("div", oControl.getId() + "-left-labels");
 				oRm.class("sapSuiteAMCSideLabels");
 				oRm.class("sapSuiteAMCPositionLeft");
 				oRm.openEnd();
@@ -87,20 +85,17 @@ sap.ui.define([
 				oRm.close("div");
 			}
 
-			oRm.openStart("div");
-			oRm.attr("id", oControl.getId() + "-canvas-cont");
+			oRm.openStart("div", oControl.getId() + "-canvas-cont");
 			oRm.class("sapSuiteAMCCanvasContainer");
 			oRm.openEnd();
-			oRm.openStart("canvas");
-			oRm.attr("id", oControl.getId() + "-canvas");
+			oRm.openStart("canvas", oControl.getId() + "-canvas");
 			oRm.class("sapSuiteAMCCanvas");
 			oRm.openEnd();
 			oRm.close("canvas");
 			oRm.close("div");
 
 			if (bShouldRenderRightLabels) {
-				oRm.openStart("div");
-				oRm.attr("id", oControl.getId() + "-right-labels");
+				oRm.openStart("div", oControl.getId() + "-right-labels");
 				oRm.class("sapSuiteAMCSideLabels");
 				oRm.class("sapSuiteAMCPositionRight");
 				oRm.openEnd();
@@ -114,8 +109,7 @@ sap.ui.define([
 			}
 
 			if (bShouldRenderBottomLabels) {
-				oRm.openStart("div");
-				oRm.attr("id", oControl.getId() + "-bottom-labels");
+				oRm.openStart("div", oControl.getId() + "-bottom-labels");
 				oRm.class("sapSuiteAMCLabels");
 				oRm.class("sapSuiteAMCPositionBtm");
 				oRm.openEnd();
@@ -129,8 +123,7 @@ sap.ui.define([
 				oRm.close("div");
 			}
 
-			oRm.openStart("div");
-			oRm.attr("id", oControl.getId() + "-css-helper");
+			oRm.openStart("div", oControl.getId() + "-css-helper");
 			oRm.style("display", "none");
 			oRm.openEnd();
 			oRm.close("div");
@@ -179,8 +172,7 @@ sap.ui.define([
 		}
 
 		var sLabel = oLabel ? oLabel.getLabel() : "";
-		oRm.openStart("div");
-		oRm.attr("id", oControl.getId() + sId);
+		oRm.openStart("div", oControl.getId() + sId);
 
 		oRm.class("sapSuiteAMCSemanticColor" + oLabel.getColor());
 

package/src/sap/suite/ui/microchart/BulletMicroChart.js

@@ -40,7 +40,7 @@ sap.ui.define([
 	 * <br>Note: You can assign a custom tooltip for this microchart. The custom tooltip can be set using expression binding. When no custom tooltip is defined, the tooltip is generated automatically based on the logic described in {@link sap.ui.core.Element#getTooltip_AsString}. For a combination of a generated and a custom tooltip, use <code>((AltText))</code> inside of the tooltip string. The aggregated data of the microchart can also be customized.
 	 * @extends sap.ui.core.Control
 	 *
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 * @since 1.34
 	 *
 	 * @public

package/src/sap/suite/ui/microchart/BulletMicroChartData.js

@@ -17,7 +17,7 @@ sap.ui.define(['./library', 'sap/ui/core/Element'],
 	 * Contains the thresholds data.
 	 * @extends sap.ui.core.Element
 	 *
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 * @since 1.34
 	 *
 	 * @constructor

package/src/sap/suite/ui/microchart/ColumnMicroChart.js

@@ -36,7 +36,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 * @since 1.34
 	 *
 	 * @public

package/src/sap/suite/ui/microchart/ColumnMicroChartData.js

@@ -17,7 +17,7 @@ sap.ui.define(['./library', 'sap/ui/core/Element'],
 	 * Defines the column chart data.
 	 * @extends sap.ui.core.Element
 	 *
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 * @since 1.34
 	 *
 	 * @public

package/src/sap/suite/ui/microchart/ColumnMicroChartLabel.js

@@ -18,7 +18,7 @@ sap.ui.define(['./library',	'sap/ui/core/Element'],
 	 * Displays or hides the labels of a column micro chart.
 	 * @extends sap.ui.core.Element
 	 *
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 * @since 1.34
 	 *
 	 * @public

package/src/sap/suite/ui/microchart/ComparisonMicroChart.js

@@ -33,7 +33,7 @@ sap.ui.define([
 	 * <br>Note: You can assign a custom tooltip for this microchart. The custom tooltip can be set using expression binding. When no custom tooltip is defined, the tooltip is generated automatically based on the logic described in {@link sap.ui.core.Element#getTooltip_AsString}. For a combination of a generated and a custom tooltip, use <code>((AltText))</code> inside of the tooltip string. The aggregated data of the microchart can also be customized.
 	 * @extends sap.ui.core.Control
 	 *
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 * @since 1.34
 	 *
 	 * @public

package/src/sap/suite/ui/microchart/ComparisonMicroChartData.js

@@ -17,7 +17,7 @@ sap.ui.define(['./library', 'sap/ui/core/Element', 'sap/ui/core/Control'],
 	 * Contains the values of the comparison chart.
 	 * @extends sap.ui.core.Element
 	 *
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 * @since 1.34
 	 *
 	 * @constructor

package/src/sap/suite/ui/microchart/ComparisonMicroChartRenderer.js

@@ -53,16 +53,14 @@ sap.ui.define([
 
 			this._renderInnerContent(oRm, oControl, sAriaLabel);
 
-			oRm.openStart("div");
-			oRm.attr("id", oControl.getId() + "-info");
+			oRm.openStart("div", oControl.getId() + "-info");
 			oRm.attr("aria-hidden", "true");
 			oRm.style("display", "none");
 			oRm.openEnd();
 			oRm.text(sAriaLabel);
 			oRm.close("div");
 
-			oRm.openStart("div");
-			oRm.attr("id", oControl.getId() + "-hidden");
+			oRm.openStart("div", oControl.getId() + "-hidden");
 			oRm.attr("aria-hidden", "true");
 		//	oRm.writeAttribute("tabindex", "-1");
 			oRm.attr("focusable", "false");
@@ -149,8 +147,7 @@ sap.ui.define([
 	ComparisonMicroChartRenderer._renderChartBar = function(oRm, oControl, oChartData, iIndex, sColor) {
 		var oData = oControl.getData()[iIndex];
 
-		oRm.openStart("div");
-		oRm.attr("id", oControl.getId() + "-chart-item-bar-" + iIndex);
+		oRm.openStart("div", oControl.getId() + "-chart-item-bar-" + iIndex);
 		oRm.class("sapSuiteCpMCChartBar");
 
 		if (oControl.getData()[iIndex].hasListeners("press")) {
@@ -162,7 +159,7 @@ sap.ui.define([
 			if (!library._isTooltipSuppressed(oControl._getBarAltText(iIndex))) {
 				oRm.attr("title", oControl._getBarAltText(iIndex));
 			} else {
-				// By setting the empty title attribute on the bar, the followng desired behavior is achieved:
+				// By setting the empty title attribute on the bar, the following desired behavior is achieved:
 				// no tooltip is displayed when hovering over the bar press area, independent whether the tooltip of the chart is suppressed or displayed.
 				oRm.attr("title", "");
 			}
@@ -198,9 +195,9 @@ sap.ui.define([
 			oRm.openStart("div");
 			oRm.attr("data-bar-index", iIndex);
 			oRm.class("sapSuiteCpMCChartBarNoValue");
-			if (!!oChartData.negativeNoValue && !oChartData.value) {
+			if (oChartData.negativeNoValue && !oChartData.value) {
 				oRm.class("sapSuiteCpMCNegPosNoValue");
-			} else if (!!oChartData.negativeNoValue || !!oChartData.value) {
+			} else if (oChartData.negativeNoValue || oChartData.value) {
 				oRm.class("sapSuiteCpMCNotFirstBarPart");
 			}
 			oRm.style("width", oChartData.positiveNoValue + "%");
@@ -214,8 +211,7 @@ sap.ui.define([
 	ComparisonMicroChartRenderer._renderChartTitle = function(oRm, oControl, iIndex) {
 		var oData = oControl.getData()[iIndex];
 
-		oRm.openStart("div");
-		oRm.attr("id", oControl.getId() + "-chart-item-" + iIndex + "-title");
+		oRm.openStart("div", oControl.getId() + "-chart-item-" + iIndex + "-title");
 		oRm.class("sapSuiteCpMCChartItemTitle");
 		oRm.openEnd();
 		oRm.text(oData.getTitle());
@@ -229,8 +225,7 @@ sap.ui.define([
 		var sAValToShow = sDisplayValue ? sDisplayValue : "" + oData.getValue();
 		var sValScale = sAValToShow + sScale;
 
-		oRm.openStart("div");
-		oRm.attr("id", oControl.getId() + "-chart-item-" + iIndex + "-value");
+		oRm.openStart("div", oControl.getId() + "-chart-item-" + iIndex + "-value");
 		oRm.class("sapSuiteCpMCChartItemValue");
 		if (ValueColor[sColor]) {
 			oRm.class("sapSuiteCpMCSemanticColor" + oData.getColor());

package/src/sap/suite/ui/microchart/DeltaMicroChart.js

@@ -44,7 +44,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 * @since 1.34
 	 *
 	 * @public

package/src/sap/suite/ui/microchart/DeltaMicroChartRenderer.js

@@ -107,11 +107,10 @@ sap.ui.define([
 				this._renderTitle(oRm, sTitle1, "sapSuiteDMCPositionTop");
 			}
 
-			oRm.openStart("div");
+			oRm.openStart("div", oControl.getId() + "-dmc-chart");
 			oRm.class("sapSuiteDMCChart");
-			oRm.attr("id", oControl.getId() + "-dmc-chart");
 			oRm.openEnd();
-			oRm.openStart("div");
+			oRm.openStart("div", oControl.getId() + "-dmc-bar1");
 			oRm.class("sapSuiteDMCBar");
 			oRm.class("sapSuiteDMCBar1");
 
@@ -128,7 +127,6 @@ sap.ui.define([
 			}
 			oRm.class(getDir(oControl._oChartData.bar1.left));
 			oRm.style("width", oControl._oChartData.bar1.width + "%");
-			oRm.attr("id", oControl.getId() + "-dmc-bar1");
 			oRm.openEnd();
 			oRm.openStart("div");
 			oRm.class("sapSuiteDMCBarInternal");
@@ -137,7 +135,7 @@ sap.ui.define([
 			oRm.close("div");
 			oRm.close("div");
 
-			oRm.openStart("div");
+			oRm.openStart("div", oControl.getId() + "-dmc-bar2");
 			oRm.class("sapSuiteDMCBar");
 			oRm.class("sapSuiteDMCBar2");
 			if (oControl._oChartData.delta.isMax) {
@@ -153,7 +151,6 @@ sap.ui.define([
 			}
 			oRm.class(getDir(oControl._oChartData.bar2.left));
 			oRm.style("width", oControl._oChartData.bar2.width + "%");
-			oRm.attr("id", oControl.getId() + "-dmc-bar2");
 			oRm.openEnd();
 			oRm.openStart("div");
 			oRm.class("sapSuiteDMCBarInternal");
@@ -162,7 +159,7 @@ sap.ui.define([
 			oRm.close("div");
 			oRm.close("div");
 
-			oRm.openStart("div");
+			oRm.openStart("div", oControl.getId() + "-dmc-bar-delta");
 			oRm.class("sapSuiteDMCBar");
 			oRm.class("sapSuiteDMCBarDelta");
 			if (!oControl._oChartData.delta.isMax) {
@@ -176,7 +173,6 @@ sap.ui.define([
 			}
 			oRm.class(getDir(oControl._oChartData.delta.left));
 			oRm.style("width", oControl._oChartData.delta.width + "%");
-			oRm.attr("id", oControl.getId() + "-dmc-bar-delta");
 			oRm.openEnd();
 			oRm.openStart("div");
 			fnSetColor(sColor, "background-color");
@@ -218,16 +214,14 @@ sap.ui.define([
 			oRm.openStart("div");
 			oRm.class("sapSuiteDMCLbls");
 			oRm.openEnd();
-			oRm.openStart("div");
-			oRm.attr("id", oControl.getId() + "-value1");
+			oRm.openStart("div", oControl.getId() + "-value1");
 			oRm.class("sapSuiteDMCLabel");
 			oRm.class("sapSuiteDMCValue1");
 			oRm.openEnd();
 			oRm.text(sAdv1ToShow);
 			oRm.close("div");
 
-			oRm.openStart("div");
-			oRm.attr("id", oControl.getId() + "-delta");
+			oRm.openStart("div", oControl.getId() + "-delta");
 			oRm.class("sapSuiteDMCLabel");
 			oRm.class("sapSuiteDMCDelta");
 			fnSetColor(sColor, "color");
@@ -235,8 +229,7 @@ sap.ui.define([
 			oRm.text(sAddvToShow);
 			oRm.close("div");
 
-			oRm.openStart("div");
-			oRm.attr("id", oControl.getId() + "-value2");
+			oRm.openStart("div", oControl.getId() + "-value2");
 			oRm.class("sapSuiteDMCLabel");
 			oRm.class("sapSuiteDMCValue2");
 			oRm.openEnd();

package/src/sap/suite/ui/microchart/HarveyBallMicroChart.js

@@ -35,7 +35,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 * @since 1.34
 	 *
 	 * @public
@@ -404,6 +404,12 @@ sap.ui.define([
 		if (Device.browser.msie) {
 			this.$().trigger("focus");
 		}
+		// if the press event is used then event needs to be marked.Otherwise the Parent Control events should trigger.
+		if (this.hasListeners("press") === true) {
+			// mark the event for components that needs to know if the event was handled.
+			oEvent.setMarked();
+			oEvent.stopPropagation();
+		}
 		this.firePress();
 	};
 

package/src/sap/suite/ui/microchart/HarveyBallMicroChartItem.js

@@ -20,7 +20,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Element
 	 *
 	 * @author SAP SE
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 * @since 1.34
 	 *
 	 * @public

package/src/sap/suite/ui/microchart/HarveyBallMicroChartRenderer.js

@@ -4,14 +4,12 @@
 */
 
 sap.ui.define([
-	"sap/ui/thirdparty/jquery",
 	"sap/m/library",
-	"sap/ui/Device",
 	"./library",
 	"sap/base/security/encodeXML",
 	"sap/suite/ui/microchart/MicroChartRenderUtils",
 	"sap/ui/core/theming/Parameters"
-], function (jQuery, MobileLibrary, Device, library, encodeXML, MicroChartRenderUtils, Parameters, ValueColor, ValueCSSColor) {
+], function (MobileLibrary, library, encodeXML, MicroChartRenderUtils, Parameters) {
 	"use strict";
 
 	// shortcut for sap.m.ValueColor

package/src/sap/suite/ui/microchart/InteractiveBarChart.js

@@ -11,9 +11,11 @@ sap.ui.define([
 	'sap/m/FlexBox',
 	'sap/ui/core/ResizeHandler',
 	"sap/base/Log",
+	"sap/f/IllustratedMessage",
+	"sap/f/library",
 	"./InteractiveBarChartRenderer"
 ],
-	function(jQuery, library, MobileLibrary, Control, Device, FlexBox, ResizeHandler, Log) {
+	function(jQuery, library, MobileLibrary, Control, Device, FlexBox, ResizeHandler,  Log, IllustratedMessage, sapFLibrary) {
 	"use strict";
 
 	/**
@@ -28,7 +30,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 *
 	 * @public
 	 * @since 1.42.0
@@ -61,7 +63,19 @@ sap.ui.define([
 				/**
 				 * End of displayed scale.
 				 */
-				max: {type : "float", group : "Appearance"}
+				max: {type : "float", group : "Appearance"},
+				/**
+				 * TRUE if error is present, FALSE otherwise
+				 */
+				showError: {type: "boolean", group: "Appearance", defaultValue: false},
+				/**
+				 * error message title
+				 */
+				errorMessageTitle: {type:"string", group: "Appearance"},
+				/**
+				 * error message description
+				 */
+				errorMessage: {type:"string", group: "Appearance"}
 			},
 			defaultAggregation : "bars",
 			aggregations : {
@@ -136,8 +150,11 @@ sap.ui.define([
 		this._oRb = sap.ui.getCore().getLibraryResourceBundle("sap.suite.ui.microchart");
 		this._fMin = null;
 		this._fMax = null;
-
 		this._bThemeApplied = true;
+		this._oIllustratedMessageControl =  new IllustratedMessage({
+			illustrationSize:sapFLibrary.IllustratedMessageSize.Base,
+			illustrationType: sapFLibrary.IllustratedMessageType.NoData
+		   });
 		if (!sap.ui.getCore().isInitialized()) {
 			this._bThemeApplied = false;
 			sap.ui.getCore().attachInit(this._handleCoreInitialized.bind(this));
@@ -163,6 +180,10 @@ sap.ui.define([
 		// set the data needed for responsiveness
 		this._setResponsivenessData();
 		this._setInternalMinMax();
+		this._errorMessage = this.getErrorMessage();
+		this._errorMessageTitle = this.getErrorMessageTitle();
+		this._oIllustratedMessageControl.setTitle(this._errorMessageTitle);
+		this._oIllustratedMessageControl.setDescription(this._errorMessage);
 		this._bMinMaxValid = this._checkIfMinMaxValid();
 		if (this.getAggregation("bars") && this.getDisplayedBars()) {
 			this._iVisibleBars = Math.min(this.getAggregation("bars").length, this.getDisplayedBars());
@@ -219,6 +240,7 @@ sap.ui.define([
 
 	InteractiveBarChart.prototype.exit = function() {
 		this._deregisterResizeHandler();
+		this._oIllustratedMessageControl.destroy();
 	};
 
 	/* =========================================================== */
@@ -471,7 +493,8 @@ sap.ui.define([
 		// we need to invalidate in every theme changed, as some colors are not defined by CSS but in rendering routine
 		this._bThemeApplied = true;
 		this._bCompact = this._isCompact();
-		this.invalidate();
+		// removed invalidate after testing by switching into various themes, no observed changes/issues, also
+		// no visible hardcoded css in the renderer file
 	};
 
 	/**

package/src/sap/suite/ui/microchart/InteractiveBarChartBar.js

@@ -16,7 +16,7 @@ sap.ui.define(['./library', 'sap/ui/core/Element'],
 	 * @extends sap.ui.core.Element
 	 *
 	 * @author SAP SE
-	 * @version 1.90.6
+	 * @version 1.93.1
 	 *
 	 * @public
 	 * @since 1.42.0