@sapui5/sap.suite.ui.generic.template 1.145.0 → 1.145.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sapui5/sap.suite.ui.generic.template",
-  "version": "1.145.0",
+  "version": "1.145.1",
   "description": "SAPUI5 Library sap.suite.ui.generic.template",
   "keywords": [
     "sapui5",

package/src/sap/suite/ui/generic/template/.library

@@ -7,7 +7,7 @@
 
 		(c) Copyright 2009-2015 SAP SE. All rights reserved
 	</copyright>
-	<version>1.145.0</version>
+	<version>1.145.1</version>
 
 	<documentation>Library with generic Suite UI templates.</documentation>
 

package/src/sap/suite/ui/generic/template/AnalyticalListPage/manifest.json

@@ -8,7 +8,7 @@
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
 			"__comment": "applicationVersion oder componentversion??",
-			"version": "1.145.0"
+			"version": "1.145.1"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/Canvas/manifest.json

@@ -8,7 +8,7 @@
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
 			"__comment": "applicationVersion oder componentversion??",
-			"version": "1.145.0"
+			"version": "1.145.1"
 		},
 		"title": "Canvas",
 		"description": "Canvas Page",

package/src/sap/suite/ui/generic/template/ListReport/controller/ControllerImplementation.js

@@ -1,5 +1,6 @@
 sap.ui.define([
 	"sap/ui/model/Filter",
+	"sap/ui/model/FilterOperator",
 	"sap/suite/ui/generic/template/ListReport/extensionAPI/ExtensionAPI",
 	"sap/suite/ui/generic/template/listTemplates/listUtils",
 	"sap/suite/ui/generic/template/listTemplates/controller/MessageStripHelper",
@@ -31,6 +32,7 @@ sap.ui.define([
 	"sap/fe/controls/easyFilter/PXFeedback"
 ], function (
 	Filter,
+	FilterOperator,
 	ExtensionAPI,
 	listUtils,
 	MessageStripHelper,
@@ -594,10 +596,89 @@ sap.ui.define([
 				return restoreFocusHelper;
 			}
 
-			// // Expose selected private functions to unit tests
-			// var getDownloadUrl = testableHelper.testable(getDownloadUrl, "getDownloadUrl");
+			/**
+			 * Helper function to get missing navigation properties from the current variant.
+			 * This logic was moved from SmartFilterBarWrapper to avoid control-specific
+			 * business logic in the wrapper layer.
+			 * @param {object} oSmartFilterBar - The SmartFilterBar control
+			 * @returns {Array} Array of missing navigation property filters
+			 */
+			function fnGetMissingNavProperties(oSmartFilterBar) {
+				//Fetch the navigation properties
+				const oMetaModel = oSmartFilterBar.getModel().getMetaModel(),
+					sEntitySet = oSmartFilterBar.getEntitySet(),
+					oDataEntitySet = oMetaModel.getODataEntitySet(sEntitySet),
+					oDataEntityType = oMetaModel.getODataEntityType(oDataEntitySet.entityType),
+					aNavigationProperties = oDataEntityType['navigationProperty'];
+				//Fetch the added filters in the current variant
+				const sCurrentVariantID = oSmartFilterBar.getVariantManagement().getCurrentVariantId(),
+					oCurrentVariant = oSmartFilterBar.getVariantManagement().getAllVariants().find(function(variant) {
+						return variant.getId() === sCurrentVariantID;
+					});
+				if (!oCurrentVariant
+					|| !oCurrentVariant.getContent()
+					|| !oCurrentVariant.getContent().searchListReportVariant
+					|| !oCurrentVariant.getContent().searchListReportVariant.filterBarVariant
+					|| !aNavigationProperties
+					|| !aNavigationProperties.length
+				) {
+					return [];
+				}
+				const oManifestNavigationProperties = oSmartFilterBar.getNavigationProperties() ?
+					oSmartFilterBar.getNavigationProperties().split(",").reduce(function(accumulator, currentValue){
+						accumulator[currentValue] = true;
+						return accumulator;
+					}, {}) : {},
+					oNavigationProperties = aNavigationProperties.reduce(function(accumulator, currentValue){
+						accumulator[currentValue.name] = true;
+						return accumulator;
+					}, {}),
+					oSmartFilterBarVariant = JSON.parse(oCurrentVariant.getContent().searchListReportVariant.filterBarVariant),
+					aMissing = [];
+				delete oSmartFilterBarVariant["_CUSTOM"];
+
+				// Compare the filter source and navigation properties
+				// Take into account if parameter is already specified in page setting in manifest.json - settings->filterSettings->navigationProperties
+				// If parameter exist in navigationProperties -> SFB will handle specific parameter and code ignore it
+				for (const sFilterKey in oSmartFilterBarVariant) {
+					const sParamName = sFilterKey.split(".")[0]; // take first part from navigation parameter. Example: to_Currency.Currency_Code -> to_Currency
+					if (!oNavigationProperties[sParamName] || oManifestNavigationProperties[sParamName]
+					) {
+						// Parameter is
+						// 1) not navigation property -> we don't process it
+						// 2) is defined in manifest.json - settings->filterSettings->navigationProperties -> value will be handled by SFB
+						continue;
+					}
+					if (oSmartFilterBarVariant[sFilterKey].items && oSmartFilterBarVariant[sFilterKey].items.length) {
+						aMissing.push(oSmartFilterBarVariant[sFilterKey].items.map(function(entry) {
+							return {
+								exclude: false,
+								field: sFilterKey,
+								operation: FilterOperator.EQ,
+								value1: entry.key
+							};
+						}));
+						continue;
+					}
+					if (oSmartFilterBarVariant[sFilterKey].ranges && oSmartFilterBarVariant[sFilterKey].ranges.length) {
+						aMissing.push(oSmartFilterBarVariant[sFilterKey].ranges.map(function(entry) {
+							return {
+								exclude: entry.exclude,
+								field: entry.keyField,
+								operation: entry.operation,
+								value1: entry.value1,
+								value2: entry.value2
+							};
+						}));
+					}
+				}
+				return aMissing;
+			}
+
+			// Expose selected private functions to unit tests
 			/* eslint-enable */
 			testableHelper.testable(onShareListReportActionButtonPressImpl, "ControllerImplementation_onShareListReportActionButtonPressImpl");
+			testableHelper.testable(fnGetMissingNavProperties, "fnGetMissingNavProperties");
 
 			// Generation of Event Handlers
 			return {
@@ -757,6 +838,9 @@ sap.ui.define([
 				},
 
 				handlers: {
+					onAfterVariantInitialise: function(oEvent) {
+						oTemplateUtils.oCommonUtils.getControlStateWrapper(oEvent.getSource()).onAfterVariantInitialise();
+					},
 					addEntry: addEntry,
 					addEntryWithFilters: addEntryWithFilters,
 					deleteEntries: fnDeleteEntries,
@@ -802,6 +886,8 @@ sap.ui.define([
 					onAfterSFBVariantLoad: function (oEvent) {
 						oState.oIappStateHandler.onAfterSFBVariantLoad(oEvent);
 						oState.oEasyFilterBarHandler && oState.oEasyFilterBarHandler.handleVariantLoad(oEvent);
+						// Cache missing navigation property filters for performance
+						oState.aMissingNavFilters = fnGetMissingNavProperties(oState.oSmartFilterbar);
 					},
 					onSmartListDataReceived: function (oEvent) {
 						var oSmartList = oEvent.getSource();
@@ -854,11 +940,8 @@ sap.ui.define([
 						// However, this connection is not there in the multi view multi table scenario which is the only case in which this snapshot
 						// will be used later.
 						var aFiltersFromRebindEvent = oBindingParams.filters.slice(0);
-						// To get the missing navigation properties from the user variant
-						var oSmartFilterBarId = oState.oSmartFilterbar.getId(),
-							oSmartFilterBarWrapper = oTemplateUtils.oCommonUtils.getControlStateWrapperById(oSmartFilterBarId, "SmartFilterBar"),
-							aMissingFilters = oSmartFilterBarWrapper.getMissingNavProperties();
-						if (aMissingFilters.length) {
+						// To get the missing navigation properties from the user variant (cached from last variant load)
+						if (oState.aMissingNavFilters && oState.aMissingNavFilters.length) {
 							// Display message to the user, which filters currently are not visible
 							var sCurrentVariant =  oState.oSmartFilterbar.getVariantManagement().getId(),
 								sCurrentVariantId =  oState.oSmartFilterbar.getCurrentVariantId(),
@@ -874,7 +957,7 @@ sap.ui.define([
 										}
 										return accumulator;
 									}, {}),
-								aMissingPropertyNames = aMissingFilters.reduce(function(accumulator, currentValue) {
+								aMissingPropertyNames = oState.aMissingNavFilters.reduce(function(accumulator, currentValue) {
 									var sName = currentValue[0].field.split(".")[0];
 									if (oMappedProperty[sName]) {
 										accumulator.push(oMappedProperty[sName]);
@@ -892,7 +975,7 @@ sap.ui.define([
 							// Generate filters and set them into binding parameters
 							// use same logic as in sap.ui.comp.smartfilterbar.FilterProviderUtils, method generateFilters()
 							var aFilters = [];
-							aMissingFilters.forEach(function(oEntry) {
+							oState.aMissingNavFilters.forEach(function(oEntry) {
 								var aIncludeFilters = [],
 									aExcludeFilters = [];
 								oEntry.forEach(function(oFilterEntry) {

package/src/sap/suite/ui/generic/template/ListReport/controller/IappStateHandler.js

@@ -214,12 +214,6 @@ sap.ui.define([
 		// However, for iAppState case, SVM wrapper also needs to contain SFB wrapper (and not oCustomFiltersWrapper directly)
 
 
-		// DynamicPage state: header pinned
-		var oDynamicPage = oController.byId(StableIdHelper.getStableId({type: "ListReportPage", subType: "DynamicPage"}));
-		// TODO: Discuss: should this state (header pinned) be part of variant (only page variant or SFB variant)? Assumption: no
-		var oDynamicPageWrapper = oTemplateUtils.oCommonUtils.getControlStateWrapper(oDynamicPage);
-		aControlStateWrappers.push(oDynamicPageWrapper);
-
 		// SmartVariantManagement state: Selected Variant and whether it's dirty, including wrappers for managed controls (all controls, for which the corresponding state
 		// information should be part of the variant)
 		// Due to direct connection between SVM and SFB, also their wrappers need to each other directly. Remarks:
@@ -230,13 +224,19 @@ sap.ui.define([
 		if (oSmartVariantManagement){
 			var oSmartVariantManagementWrapper = oTemplateUtils.oCommonUtils.getControlStateWrapper(oSmartVariantManagement, {
 				managedControlWrappers: aPageVariantControlStateWrappers.concat([oSmartFilterBarWrapper]),
-				dynamicPageWrapper: oDynamicPageWrapper
+				smartFilterBarWrapper: oSmartFilterBarWrapper
 			});
 			aControlStateWrappers.push(oSmartVariantManagementWrapper);
 		} else {
 			aControlStateWrappers.push(oSmartFilterBarWrapper);
 		}
 
+		// DynamicPage state: header pinned
+		var oDynamicPage = oController.byId(StableIdHelper.getStableId({type: "ListReportPage", subType: "DynamicPage"}));
+		// The DynamicPage state (header pinned) is intentionally stored only in iAppState and not included in any variant (neither page variant nor SFB variant).
+		var oDynamicPageWrapper = oTemplateUtils.oCommonUtils.getControlStateWrapper(oDynamicPage);
+		aControlStateWrappers.push(oDynamicPageWrapper);
+
 
 		// Wrapper to control whether data is loaded
 
@@ -774,7 +774,8 @@ sap.ui.define([
 				// For desktop devices, expand the header for Standard and Custom variants and for tablet and mobile devices,
 				// collapse the header only if search is triggered.
 				if (Device.system.desktop) {
-					oTemplateUtils.oCommonUtils.getControlStateWrapper(oController.byId(StableIdHelper.getStableId({type: "ListReportPage", subType: "DynamicPage"}))).setHeaderState(oController, true);
+					var oTemplatePrivateModel = oTemplateUtils.oComponentUtils.getTemplatePrivateModel();
+					oTemplatePrivateModel.setProperty("/listReport/isHeaderExpanded", true);
 				} else {
 					collapseHeader();
 				}
@@ -909,6 +910,16 @@ sap.ui.define([
                 }
                 sap.ui.getCore().getMessageManager().removeMessages(removedMessages);
             }
+
+			// Restore header collapse logic (originally removed in change 5641712)
+			// Collapse header when user manually selects a variant (context === undefined) that has executeOnSelect set to true
+			var oContext = oEvent.getParameter("context");
+			var bExecuteOnSelect = oEvent.getParameter("executeOnSelect");
+
+			if (oContext === undefined && bExecuteOnSelect) {
+				collapseHeader();
+			}
+
 			fnRestoreExtendedFilterDataOnAfterSFBVariantLoad(oEvent);
 		}
 

package/src/sap/suite/ui/generic/template/ListReport/manifest.json

@@ -8,7 +8,7 @@
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
 			"__comment": "applicationVersion oder componentversion??",
-			"version": "1.145.0"
+			"version": "1.145.1"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/ListReport/view/fragments/SmartChart.fragment.xml

@@ -7,8 +7,9 @@
 		AHMultipleViews:'sap/suite/ui/generic/template/js/AnnotationHelperMultipleViews'}">
 
 	<template:with path="entityType>com.sap.vocabularies.UI.v1.HeaderInfo" var="header">
-		<smartChart:SmartChart
-			id="listReport{= ${parameter>/settings/quickVariantSelectionX} ? ${path: 'tabItem>', formatter: 'AH.getSuffixFromIconTabFilterKey'} : ''}" 
+	<smartChart:SmartChart
+		id="listReport{= ${parameter>/settings/quickVariantSelectionX} ? ${path: 'tabItem>', formatter: 'AH.getSuffixFromIconTabFilterKey'} : ''}"
+		afterVariantInitialise="._templateEventHandlers.onAfterVariantInitialise"
 			visible="{path: 'tabItem>', formatter: 'AHMultipleViews.getVisibleForTableTabs'}"
 			smartFilterId=""
 			persistencyKey="listReportChart{= ${parameter>/settings/quickVariantSelectionX} ? ${path: 'tabItem>', formatter: 'AH.getSuffixFromIconTabFilterKey'} : ''}"

package/src/sap/suite/ui/generic/template/ListReport/view/fragments/SmartTable.fragment.xml

@@ -17,8 +17,9 @@
 			<template:with path="tableAnnotationPath>" helper="AH.searchForFirstSemKey_Title_Description" var="targetColumn">
 				<template:with path="parameter>/" helper="StableIdHelper.preparePathForStableId" var="smartControlId">
 					<template:if test="{= ${smartControlId>}.buildStableId({type: 'ListReportTable', subType: 'SmartTable', sQuickVariantKey: ${tabItem>key}})}" />
-					<smarttable:SmartTable id="{smartControlId>id}" useDateRangeType="{= ${parameter>/settings/filterSettings/dateSettings/useDateRange} }"
-						smartFilterId="{= ${parameter>/settings/quickVariantSelectionX} ? '' : 'listReportFilter'}"
+				<smarttable:SmartTable id="{smartControlId>id}" useDateRangeType="{= ${parameter>/settings/filterSettings/dateSettings/useDateRange} }"
+					afterVariantInitialise="._templateEventHandlers.onAfterVariantInitialise"
+					smartFilterId="{= ${parameter>/settings/quickVariantSelectionX} ? '' : 'listReportFilter'}"
 						visible="{path: 'tabItem>', formatter: 'AHMultipleViews.getVisibleForTableTabs'}"
 						initialise="._templateEventHandlers.onTableInit"
 						persistencyKey="{= ${path: 'parameter>/settings/routeConfig/', formatter: 'AH.getPersistencyKeyForSmartTable'} }{= ${parameter>/settings/quickVariantSelectionX} ? ${path: 'tabItem>', formatter: 'AH.getSuffixFromIconTabFilterKey'} : ''}"
@@ -39,7 +40,7 @@
 						showTablePersonalisation="true"
 						placeToolbarInTable="{parameter>/templateSpecific/isResponsiveTable}"
 						customizeConfig="{parts: [{path: 'entitySet>'}, {path: 'entitySet>dummy'}, {path: 'tableSettings>calculateWidthIncludingColumnHeader'}], formatter: 'AH.buildSmartTableCustomizeConfig'}"
-						initialNoDataText="{= ${appSettings>/noDataRepresentation} === 'textOnly' ? 
+						initialNoDataText="{= ${appSettings>/noDataRepresentation} === 'textOnly' ?
 								( !${parameter>/settings/isWorklist} ? '{i18n>NODATA_SMARTTABLE_LR}' : '$NO_FILTERBAR' ) :
 								null
 						}"
@@ -48,7 +49,7 @@
 						useInfoToolbar="On">
 
 						<!--
-							SmartTable "noData" can be set either as a property (attribute) or as an aggregation, 
+							SmartTable "noData" can be set either as a property (attribute) or as an aggregation,
 							but not both at the same time.
 
 							1. When noDataRepresentation = "textOnly"

package/src/sap/suite/ui/generic/template/ObjectPage/controller/ControllerImplementation.js

@@ -2473,8 +2473,11 @@ sap.ui.define([
 						});
 					}
 				},
-				handlers: {
-					onEditAndActiveToggle: function () { // Implementation of draft toggle for static header
+			handlers: {
+				onAfterVariantInitialise: function(oEvent) {
+					oTemplateUtils.oCommonUtils.getControlStateWrapper(oEvent.getSource()).onAfterVariantInitialise();
+				},
+				onEditAndActiveToggle: function () { // Implementation of draft toggle for static header
 						var oUIModel = oObjectPage.getModel("ui");
 						var bIsEditable = oUIModel.getProperty("/editable");
 

package/src/sap/suite/ui/generic/template/ObjectPage/manifest.json

@@ -6,7 +6,7 @@
 		"type": "component",
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
-			"version": "1.145.0"
+			"version": "1.145.1"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/ObjectPage/view/fragments/SmartChart.fragment.xml

@@ -11,8 +11,9 @@
 					<template:if test="{:= ${smartChartId>}.set(AH.getStableIdPartFromFacet(${facet>}) + '::Chart') }"/>
 					<!-- Header Level for Smart Chart is hardcoded here with "H5" for fallback scenarios, After Section Title hiding logic, if required the level is calculated on the class /ObjectPage/controller/SectionTitleHandler.js-->
 					<!-- Header Style for Smart Chart is hardcoded here with "H5" for all Scenarios.-->
-					<smartChart:SmartChart
-						id="{smartChartId>value}"
+				<smartChart:SmartChart
+					id="{smartChartId>value}"
+					afterVariantInitialise="._templateEventHandlers.onAfterVariantInitialise"
 						header="{chartAnnotation>Title/String}"
 						initialized="._templateEventHandlers.onChartInit"
 						requestAtLeastFields="{parts: [{path: 'chartAnnotation>'}, {path: 'entitySet>entityType'}], formatter: 'AH.getApplicablePathForChartToolbarActions'}"

package/src/sap/suite/ui/generic/template/ObjectPage/view/fragments/SmartTable.fragment.xml

@@ -16,8 +16,9 @@
 								<template:if test="{= ${smartControlId>}.buildStableId({type: 'ObjectPageTable', subType: 'SmartTable', sFacet: ${facetId>id}})}" />
 								<!-- Header Level for Smart Table is hardcoded here with "H5" for fallback scenarios, After Section Title hiding logic, if required the level is calculated on the class /ObjectPage/controller/SectionTitleHandler.js-->
 								<!-- Header Style for Smart Table is hardcoded here with "H5" for all Scenarios.-->
-								<st:SmartTable id="{smartControlId>id}"
-									initialise="._templateEventHandlers.onTableInit($event, '{facetId>id}')"
+							<st:SmartTable id="{smartControlId>id}"
+								afterVariantInitialise="._templateEventHandlers.onAfterVariantInitialise"
+								initialise="._templateEventHandlers.onTableInit($event, '{facetId>id}')"
 									persistencyKey="{parts: [{path: 'smartControlId>id'}, {path: 'objectPageTableSettings>value/persistencyKeyState'}], formatter: 'AH.getPersistencyKey'}"
 									tableBindingPath="{= ${path: 'target>AnnotationPath'}.slice(0, ${path: 'target>AnnotationPath'}.lastIndexOf('/')) }"
 									fitContainer="false"

package/src/sap/suite/ui/generic/template/QuickCreate/manifest.json

@@ -6,7 +6,7 @@
 		"type": "component",
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
-			"version": "1.145.0"
+			"version": "1.145.1"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/QuickView/manifest.json

@@ -6,7 +6,7 @@
 	"type": "component",
 	"i18n": "i18n/i18n.properties",
 	"applicationVersion": {
-		"version": "1.145.0"
+		"version": "1.145.1"
 	},
 	"title": "{{TITLE}}",
 	"description": "{{DESCRIPTION}}",