@sapui5/sap.suite.ui.generic.template 1.144.1 → 1.145.1

package/src/sap/suite/ui/generic/template/genericUtilities/controlStateWrapperFactory/SmartVariantManagementWrapper.js

@@ -4,18 +4,16 @@ sap.ui.define([
 
 	/**
 	 * Constructor for SmartVariantManagementWrapper
-	 * @param {sap.ui.comp.smartvariants.SmartVariantManagement} vTarget - The SmartVariantManagement control
-	 * or the Id of control for which this wrapper is created
+	 * @param {sap.ui.comp.smartvariants.SmartVariantManagement} oControl - The SmartVariantManagement control
 	 * @param {object} oController - the controller of the current component
 	 * @param {object} oFactory - the controlStateWrapperFactory
 	 * @param {object} mParams
 	 * @param {array} mParams.managedControlWrappers - array of controlStateWrappers for controls handled by the SVM
-	 * (currently also including SFB wrapper - to be removed)
-	 * @param {Object} mParams.dynamicPageWrapper - dynamicPageWrapper instance handled by SVM
+	 * @param {object} mParams.smartFilterBarWrapper - explicit reference to SmartFilterBarWrapper for special handling
 	 * @returns {object}
 	 */
 
-	function SmartVariantManagementWrapper(vTarget, oController, oFactory, mParams) {
+	function SmartVariantManagementWrapper(oControl, oController, oFactory, mParams) {
 		// Special handling of SmartFilterBarWrapper for several reasons:
 		// - Suppress selection when restoring a variant. Selection is solely triggered according to information in appState. Otherwise, erroneous selection could be triggered in
 		//		a few situations:
@@ -26,14 +24,10 @@ sap.ui.define([
 		//	- Store and restore extension state (extension implemented in SFB instead of SVM, which would be more appropriate from architectural point of view)
 		// flag to control whether we are currently in the process of applying a state to suppress the event to inform about a new state´
 		// only needed when setting the variant itself - for managed controls, their wrappers should avoid firing the event themselves
-		var oSmartVariantManagement, fnResolveControlAssigned, oPreliminaryState;
-		var oControlAssignedPromise = new Promise(function (resolve) {
-			fnResolveControlAssigned = resolve;
-		});
-
-		if (typeof vTarget !== "string") {
-            fnSetControl(vTarget);
-        }
+		var oSmartVariantManagement = oControl;
+		var oPreliminaryState;
+		var bIsApplyingVariant = false;
+		var bAllControlsInitialized = false;
 
 		// Handles the state of the variant management itself (i.e. which variant is selected and whether it's dirty), including the state of the managed controls.
 		// Is responsible esp. to restore this state with correct dependency resp. in correct order
@@ -50,69 +44,74 @@ sap.ui.define([
 		// For these controls, a real user changes are already handled by the direct connection. On the other hand, these controls also fire their change events, if their state is
 		// changed from SVM (by the same connection) - setting variant dirty here would be wrong.
 		mParams.managedControlWrappers.forEach(function(oWrapper){
-			if (!oWrapper.bVMConnection){
-				oWrapper.attachStateChanged(function(){
-					oSmartVariantManagement.currentVariantSetModified(true);
-				});
-			}
+			(oWrapper.oVMConnectionPromise || Promise.resolve(oWrapper.bVMConnection)).then(function(bVMConnection) {
+				if (!bVMConnection) {
+					oWrapper.attachStateChanged(function(){
+						oSmartVariantManagement.currentVariantSetModified(true);
+					});
+				}
+			});
 		});
 
+		// Get SmartFilterBarWrapper explicitly from params.
+		// This connection is needed because SmartFilterBar provides special callbacks to store/restore state
+		// for controls that don't have a direct variant management connection (bVMConnection = false), such as:
+		// - Extension filters (custom filters added via app or adaptation extensions)
+		// - Multiple views state (selected tab in multi-table/chart scenarios)
+		// These controls need their state saved/restored with variants via the SFB's beforeVariantFetch/afterVariantLoad events.
+		var oSmartFilterBarWrapper = mParams.smartFilterBarWrapper;
 
-
-		function fnSetControl(oControl) {
-			oSmartVariantManagement = oControl;
-			fnResolveControlAssigned(oSmartVariantManagement);
-		}
-
-		var oSmartFilterBarWrapper = mParams.managedControlWrappers.find(function(oWrapper){
-			return oWrapper.setSVMWrapperCallbacks;
-		});
-
-		// provide callbacks needed for SFB wrapper to store/restore extnesion state with variant
+		// Provide callbacks needed for SFB wrapper to store/restore extension state with variant
 		if (oSmartFilterBarWrapper){
-			oSmartFilterBarWrapper.setSVMWrapperCallbacks({
-				getManagedControlStates: function(){
-					var mManagedControlStates = Object.create(null);
-					mParams.managedControlWrappers.forEach(function(oWrapper){
-						if (!oWrapper.bVMConnection){
-							mManagedControlStates[oWrapper.getLocalId()] = oWrapper.getState();
-						}
-					});
-					return mManagedControlStates;
-				},
-				setManagedControlStates: function(oState){
-					mParams.managedControlWrappers.forEach(function(oWrapper){
-						if (!oWrapper.bVMConnection){
-							oWrapper.setState(oState[oWrapper.getLocalId()]);
-						}
-					});
-				},
-				setHeaderState: function(bHeaderToBeExpanded) {
-					mParams.dynamicPageWrapper.setHeaderState(oController, bHeaderToBeExpanded);
-				}
+			// Build array with wrapper + bVMConnection info once all wrappers are ready
+			Promise.all(mParams.managedControlWrappers.map(function(oWrapper){
+				return (oWrapper.oVMConnectionPromise || Promise.resolve(oWrapper.bVMConnection)).then(function(bVMConnection){
+					return {
+						wrapper: oWrapper,
+						bVMConnection: bVMConnection
+					};
+				});
+			})).then(function(aWrapperInfo) {
+				oSmartFilterBarWrapper.setSVMWrapperCallbacks({
+					getManagedControlStates: function(){
+						var mManagedControlStates = Object.create(null);
+						aWrapperInfo.forEach(function(oInfo){
+							if (!oInfo.bVMConnection) {
+								mManagedControlStates[oInfo.wrapper.getLocalId()] = oInfo.wrapper.getState();
+							}
+						});
+						return mManagedControlStates;
+					},
+					setManagedControlStates: function(oState){
+						aWrapperInfo.forEach(function(oInfo){
+							if (!oInfo.bVMConnection) {
+								oInfo.wrapper.setState(oState[oInfo.wrapper.getLocalId()]);
+							}
+						});
+					}
+				});
 			});
 		}
 
+		// Create promise that resolves when all managed controls' variant management is ready
+		// This ensures getState() can query controls even if setState() is never called (e.g., app starts from scratch)
+		var oAllControlsInitializedPromise = Promise.all(
+			mParams.managedControlWrappers.map(function(oWrapper){
+				return oWrapper.oVariantManagementInitializedPromise || Promise.resolve();
+			})
+		);
+
+		// Set flag when all controls are initialized
+		oAllControlsInitializedPromise.then(function() {
+			bAllControlsInitialized = true;
+		});
+
 		// Wrapper is intended to set a state to the ui, but not to trigger a selection (which should happen only after all (relevant) parts of ui state is set to the correct state
 		// are set correct. Therefore, setting variant from here should never trigger a selection.
 		function fnSetVariant(sVariantId){
 			if (oSmartFilterBarWrapper){
 				oSmartFilterBarWrapper.suppressSelection(true);
 			}
-			var sId = mParams.managedControlWrappers[0].getLocalId();
-			var oControl = oController.getView().byId(sId);
-			if (oControl && oControl.isA("sap.ui.comp.smarttable.SmartTable")) {
-				oControl.attachAfterVariantInitialise(function() {
-					//set currentVariantId only when sVariantId is not standard (as it might be overriding existing
-					//different currentVariantId) or smartTable's (oControl) currentVariantId is not equal to sVariantId.
-					if (sVariantId !== '*standard*' && sVariantId !== '') {
-						if (oControl.getCurrentVariantId && oControl.getCurrentVariantId() !== sVariantId) {
-							oControl.setCurrentVariantId(sVariantId);
-						}
-						oSmartVariantManagement.setModified(false);
-					}
-				});
-			}
 			oSmartVariantManagement.setCurrentVariantId(sVariantId);
 			if (oSmartFilterBarWrapper){
 				oSmartFilterBarWrapper.suppressSelection(false);
@@ -133,7 +132,11 @@ sap.ui.define([
 		}
 
 		function getState() {
-			if (!oSmartVariantManagement) {
+			// Return preliminary state if managed controls not fully initialized
+			// Note: If early getState() calls become an issue (controls not initialized yet), we could enhance this to:
+			// - Store only SVM-specific data (variantId, modified) in oPreliminaryState
+			// - Always query managed control wrappers directly (they handle their own preliminary state via PreliminaryWrapper)
+			if (!bAllControlsInitialized) {
 				return oPreliminaryState;
 			}
 
@@ -150,22 +153,23 @@ sap.ui.define([
 
 		function setState(oState) {
 			oPreliminaryState = oState;
-			oControlAssignedPromise.then(function() {
+
+			// Wait for all managed controls to be initialized before applying state
+			oAllControlsInitializedPromise.then(function() {
+				bIsApplyingVariant = true;
 				if (!oPreliminaryState) {
 					// if no state is provided set default variant (not modified)
 					// use cases:
 					// - LR: if appStateKey in the URL that cannot be read
 					// - OP: if switching to different object instance (in discovery mode always, in persistency mode when page was not shown)
 					fnSetVariant(oSmartVariantManagement.getDefaultVariantId());
-					return;
-				}
-				if (oPreliminaryState.modified) {
+				} else if (oPreliminaryState.modified) {
 					// Special logic according to UX: If variant was modified anyway, there's no benefit for the user to see the name (but it could be confusing), so standard variant (not default!) should be
 					// set (which is achieved by empty string)
 					fnSetVariant("");
+					oSmartVariantManagement.currentVariantSetModified(true);
 					// Usually restoring the state of any of the managed controls should mark the variant as dirty, but there might be edge cases (state from an old release not containing information for any
 					// managed control now relevant), so to be on the safe side, we set modified=true explicitly.
-					oSmartVariantManagement.currentVariantSetModified(true);
 					fnSetManagedControlStates(oPreliminaryState);
 				} else {
 					fnSetVariant(oPreliminaryState.variantId);
@@ -183,6 +187,7 @@ sap.ui.define([
 						}
 					}
 				}
+				bIsApplyingVariant = false;
 			});
 		}
 
@@ -190,26 +195,30 @@ sap.ui.define([
 			// state of variant management itself can be changed directly (user selects a different variant or stores current state as (new) variant), or indirectly (user changes some
 			// data of a control managed by VM, e.g. some filter values in SFB)
 
-			oControlAssignedPromise.then(function() {
-				// state change when user selects a different variant
-				oSmartVariantManagement.attachSelect(fnHandler);
+			// Wrap the handler to suppress events when applying a variant
+			var fnSuppressibleHandler = function() {
+				if (!bIsApplyingVariant) {
+					fnHandler();
+				}
+			};
 
-				// when user saves current state as a new variant, this is also a state change (as the variant id is part of the state)
-				// note: Even if new (SFB) variant is marked as execute on select, and currently no data is selected, no need to select data here (and thus also not to collapse header).
-				// This is one of the possible ways to get into a state with a clean variant with execute on select, but no data loaded - see also comment to identify SFB wrapper.
-				oSmartVariantManagement.attachAfterSave(fnHandler);
+			// state change when user selects a different variant
+			oSmartVariantManagement.attachSelect(fnSuppressibleHandler);
 
-				// any change of a managed control is state change
-				mParams.managedControlWrappers.forEach(function(oWrapper){
-					oWrapper.attachStateChanged(fnHandler);
-				});
+			// when user saves current state as a new variant, this is also a state change (as the variant id is part of the state)
+			// note: Even if new (SFB) variant is marked as execute on select, and currently no data is selected, no need to select data here (and thus also not to collapse header).
+			// This is one of the possible ways to get into a state with a clean variant with execute on select, but no data loaded - see also comment to identify SFB wrapper.
+			oSmartVariantManagement.attachAfterSave(fnSuppressibleHandler);
+
+			// any change of a managed control is state change
+			mParams.managedControlWrappers.forEach(function(oWrapper){
+				oWrapper.attachStateChanged(fnSuppressibleHandler);
 			});
 		}
 
 		return {
 			getState : getState,
 			setState : setState,
-			setControl: fnSetControl,
 			attachStateChanged : attachStateChanged
 		};
 	}

package/src/sap/suite/ui/generic/template/lib/AppComponent.js

@@ -959,7 +959,7 @@ sap.ui.define([
 	 * @public
 	 * @extends sap.ui.core.UIComponent
 	 * @author SAP SE
-	 * @version 1.144.1
+	 * @version 1.145.1
 	 * @name sap.suite.ui.generic.template.lib.AppComponent
 	 */
 	var oAppComponent = UIComponent.extend("sap.suite.ui.generic.template.lib.AppComponent", {

package/src/sap/suite/ui/generic/template/lib/PageLeaveHandler.js

@@ -1,5 +1,5 @@
-sap.ui.define(["sap/ui/base/Object", 
-	"sap/base/util/extend", 
+sap.ui.define(["sap/ui/base/Object",
+	"sap/base/util/extend",
 	"sap/suite/ui/generic/template/lib/CRUDHelper",
 	"sap/suite/ui/generic/template/lib/MessageUtils"
 ], function (BaseObject, extend, CRUDHelper, MessageUtils) {
@@ -7,7 +7,7 @@ sap.ui.define(["sap/ui/base/Object",
 
 	function getMethods(oTemplateContract) {
 
-		var fnOnDiscardOrKeepDraftConfirmed, 
+		var fnOnDiscardOrKeepDraftConfirmed,
 			fnOnDiscardOrKeepDraftCancel;
 
 		function getSelectedKey(oKeepDiscardPopup) {
@@ -22,6 +22,22 @@ sap.ui.define(["sap/ui/base/Object",
 			firstListItemOption.focus();
 		}
 
+		function checkIfNavigationIsExplace() {
+			var UShellContainer = sap.ui.require("sap/ushell/Container");
+			if (!UShellContainer) {
+				return Promise.resolve(false); // No UShell container, assume inplace navigation
+			}
+
+			return UShellContainer.getServiceAsync("FioriElements").then(function(oFioriElementsService) {
+				if (oFioriElementsService && typeof oFioriElementsService.isExplaceNavigation === "function") {
+					return oFioriElementsService.isExplaceNavigation();
+				}
+				return false; // API not available, default to inplace behavior
+			}).catch(function() {
+				return false; // Service not available or error, default to inplace behavior
+			});
+		}
+
 		/*
 		ShowDiscardDraftPopUp
 		*/
@@ -29,7 +45,7 @@ sap.ui.define(["sap/ui/base/Object",
 			fnOnDiscardOrKeepDraftConfirmed = onDiscardOrKeepDraftConfirmed;
 			fnOnDiscardOrKeepDraftCancel = onDiscardOrKeepDraftCancel;
 
-			var oDraftPopup, 
+			var oDraftPopup,
 				oComponent = getComponent(),
 				oController = oComponent.oController;
 			var sFragmentname = "sap.suite.ui.generic.template.ObjectPage.view.fragments.DraftConfirmationPopup";
@@ -134,13 +150,25 @@ sap.ui.define(["sap/ui/base/Object",
 		function fnPerformAfterDiscardOrKeepDraftImpl(fnPositive, fnNegative, sMode, bIsTechnical) {
 			var sEnableDiscardDraftConfirmation = oTemplateContract.oNavigationControllerProxy.isDiscardDraftConfirmationNeeded();
 			var bNeedsPopup = ((sEnableDiscardDraftConfirmation === "always" && sMode.startsWith("Leave")) || (sEnableDiscardDraftConfirmation === "restricted" && sMode === "LeavePage")) && isObjectEditable();
-			if (bNeedsPopup) {
-				fnDiscardOrKeepDraftConfirmation(fnPositive, fnNegative, sMode);
-			} else {
+
+			if (!bNeedsPopup) {
 				fnPositive();
+				return;
 			}
+
+			// Check if navigation will be explace and skip popup if so
+			checkIfNavigationIsExplace().then(function(bIsExplace) {
+				if (bIsExplace) {
+					fnPositive(); // Skip popup for explace navigation
+				} else {
+					fnDiscardOrKeepDraftConfirmation(fnPositive, fnNegative, sMode);
+				}
+			}).catch(function() {
+				// Fallback: show popup as before if API check fails
+				fnDiscardOrKeepDraftConfirmation(fnPositive, fnNegative, sMode);
+			});
 		}
-		
+
 		function getComponent() {
 			var oComponent;
 			var oCurrentIdentity = oTemplateContract.oNavigationControllerProxy.getCurrentIdentity();

package/src/sap/suite/ui/generic/template/lib/i18n/i18n.properties

@@ -565,6 +565,9 @@ RTA_CONFIGURATION_TITLE_FILTER_BAR=Configure Filter Bar
 # XTIT: Title text on Configurations dialog for Object Page
 RTA_CONFIGURATION_TITLE_OBJECT_PAGE=Configure Object Page
 
+# XMSG: Information message text in Configurations dialog
+RTA_CONFIGURATION_INFO_MESSAGE=Changes will only be visible after the application reloads.
+
 # XBUT: Button text for Cancel on Configurations dialog
 RTA_CONFIGURATION_CANCEL=Cancel
 

package/src/sap/suite/ui/generic/template/lib/i18n/i18n_en_US_saprigi.properties

@@ -368,6 +368,8 @@ RTA_CONFIGURATION_TITLE_FILTER_BAR=\u206A\u206A\u206A\u200C\u200C\u200B\u200B\u2
 
 RTA_CONFIGURATION_TITLE_OBJECT_PAGE=\u206A\u206A\u206A\u200C\u200D\u200C\u200D\u200D\u200D\u200D\u200D\u200B\u200D\u200C\u200D\u200B\u200C\u200C\u200C\u200D\u200C\u200B\u200D\u200B\u200C\u200D\u200D\u200D\u200D\u200D\u200C\u200C\u200C\u200B\u200C\u200B\u200B\u200C\u200B\u200C\u200C\u200B\u206AConfigure Object Page\u206A\u206A
 
+RTA_CONFIGURATION_INFO_MESSAGE=\u206A\u206A\u206A\u200C\u200D\u200D\u200C\u200D\u200B\u200C\u200D\u200C\u200D\u200C\u200D\u200C\u200C\u200C\u200D\u200D\u200D\u200C\u200D\u200D\u200D\u200B\u200D\u200D\u200D\u200D\u200C\u200D\u200B\u200C\u200C\u200C\u200C\u200B\u200C\u200D\u200C\u200C\u200C\u206AChanges will only be visible after the application reloads.\u206A\u206A
+
 RTA_CONFIGURATION_CANCEL=\u206A\u206A\u206A\u200C\u200B\u200B\u200D\u200B\u200C\u200C\u200D\u200B\u200B\u200D\u200C\u200C\u200B\u200B\u200B\u200C\u200D\u200B\u200B\u200C\u200D\u200D\u200C\u200B\u200D\u200B\u200D\u200B\u200D\u200B\u200D\u200C\u200C\u200C\u200C\u200D\u200C\u206ACancel\u206A\u206A
 
 RTA_CONFIGURATION_APPLY=\u206A\u206A\u206A\u200C\u200C\u200B\u200B\u200B\u200D\u200C\u200D\u200C\u200C\u200C\u200B\u200C\u200B\u200B\u200D\u200B\u200D\u200C\u200B\u200B\u200D\u200D\u200D\u200D\u200C\u200D\u200D\u200C\u200D\u200D\u200B\u200C\u200D\u200B\u200C\u200D\u200C\u200C\u200D\u200B\u206AApply\u206A\u206A

package/src/sap/suite/ui/generic/template/lib/navigation/NavigationController.js

@@ -2219,25 +2219,6 @@ sap.ui.define(["sap/ui/base/Object",
 			}) : Promise.reject();
 		}
 
-		/**
-		 * Calls state changer per each (template) component on url change.
-		 * @param {Array<sap.suite.ui.generic.template.lib.StatePreserver>} aStateChangers array of StatePreserver instances
-		 * @param {map} appStates map of appStates
-		 * @param {boolean} bIsFCLMode optional, defined only in FLC
-		 * @returns {boolean} returns true if url change can be handled by state changer,
-		 * 	returns false in FCL, so the route-matched logic will continue as normal.
-		 */
-		function fnGetIsStateChange(aStateChangers, appStates, bIsFCLMode) {
-			var bIsStateChangeResult = false;
-			for (var i = 0; i < aStateChangers.length; i++){
-				var oStateChanger = aStateChangers[i];
-				if (oStateChanger.isStateChange(appStates)){
-					bIsStateChangeResult = bIsFCLMode ? false : true;
-				}
-			}
-			return bIsStateChangeResult;
-		}
-
 		// Start: Handling url-changes
 		/*
 		 * calls onActivate on the specified view, if it exists
@@ -2541,11 +2522,16 @@ sap.ui.define(["sap/ui/base/Object",
 				fnNavigate(sTargetHash, true);
 				return; // fnHandleRouteMatched will be called with the new url, so leave further processing to that call
 			}
-			// State changers can interfere in FCL, for example between LR and OP when the search query is updated. In particular, it is necessary to skip the early return in FCL and display an error in case of 404.
-			// The last parameter will still trigger state changers (with possible side effects), but will never return true as a result.
-			var bIsStateChange = fnGetIsStateChange(oTemplateContract.aStateChangers, oCurrentIdentity.appStates, !!oTemplateContract.oFlexibleColumnLayoutHandler);
 			// State changers may identify the hash change as something which can be handled by them internally. In this case we do not need to run the whole mechanism.
 			// Since isStateChange is allowed to have side-effects we call all StateChangers.
+			var bIsStateChange = false;
+			for (var i = 0; i < oTemplateContract.aStateChangers.length; i++){
+				var oStateChanger = oTemplateContract.aStateChangers[i];
+				if (oStateChanger.isStateChange(oCurrentIdentity.appStates)){
+					bIsStateChange = true;
+				}
+			}
+
 			if (bIsStateChange){
 				oRoutingOptions = null;
 				oCurrentHash.hash = sHash;
@@ -3130,8 +3116,7 @@ sap.ui.define(["sap/ui/base/Object",
 		var fnPrepareHostView = testableHelper.testable(fnPrepareHostView, "prepareHostView");
 		var fnPreloadComponent = testableHelper.testable(fnPreloadComponent, "preloadComponent");
 		var fnGetRouteInfoByHash = testableHelper.testable(fnGetRouteInfoByHash, "getRouteInfoByHash");
-		var fnGetIsStateChange = testableHelper.testable(fnGetIsStateChange, "getIsStateChange");
-
+		
 		// Note: Function createHostView will be added by routingHelper.
 		// Allow to mock this by unit tests
 		testableHelper.testable(function(fnCreateHostView){
@@ -3228,7 +3213,7 @@ sap.ui.define(["sap/ui/base/Object",
 	 * @param {sap.suite.ui.generic.template.lib.AppComponent} oAppComponent The AppComponent instance
 	 * @public
 	 * @extends sap.ui.base.Object
-	 * @version 1.144.1
+	 * @version 1.145.1
 	 * @since 1.30.0
 	 * @alias sap.suite.ui.generic.template.lib.NavigationController
 	 */

package/src/sap/suite/ui/generic/template/lib/presentationControl/SmartTableHandler.js

@@ -586,7 +586,7 @@ sap.ui.define([
 			const getFieldProps = function (sField) {
 				return {
 					"sProperty": sField,
-					"sLabel": (mPropertyByFieldName[sField]["com.sap.vocabularies.Common.v1.Label"] || "").String || mPropertyByFieldName[sField]["sap:label"] || "",
+					"sLabel": getColumnLabel(sField),
 					"sValue": oItemContext.getProperty(sField),
 					"bHidden": !aVisibleColumns.has(sField)
 				};

package/src/sap/suite/ui/generic/template/library.js

@@ -66,7 +66,7 @@ sap.ui.define([
 		interfaces: [],
 		controls: [],
 		elements: [],
-		version: "1.144.1",
+		version: "1.145.1",
 		extensions: {
 			//Configuration used for rule loading of Support Assistant
 			"sap.ui.support": {