@sapui5/sap.suite.ui.generic.template 1.136.3 → 1.136.4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sapui5/sap.suite.ui.generic.template",
-  "version": "1.136.3",
+  "version": "1.136.4",
   "description": "SAPUI5 Library sap.suite.ui.generic.template",
   "keywords": [
     "sapui5",

package/src/sap/suite/ui/generic/template/.library

@@ -7,7 +7,7 @@
 
 		(c) Copyright 2009-2015 SAP SE. All rights reserved
 	</copyright>
-	<version>1.136.3</version>
+	<version>1.136.4</version>
 
 	<documentation>Library with generic Suite UI templates.</documentation>
 

package/src/sap/suite/ui/generic/template/AnalyticalListPage/manifest.json

@@ -8,7 +8,7 @@
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
 			"__comment": "applicationVersion oder componentversion??",
-			"version": "1.136.3"
+			"version": "1.136.4"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/Canvas/manifest.json

@@ -8,7 +8,7 @@
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
 			"__comment": "applicationVersion oder componentversion??",
-			"version": "1.136.3"
+			"version": "1.136.4"
 		},
 		"title": "Canvas",
 		"description": "Canvas Page",

package/src/sap/suite/ui/generic/template/ListReport/manifest.json

@@ -8,7 +8,7 @@
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
 			"__comment": "applicationVersion oder componentversion??",
-			"version": "1.136.3"
+			"version": "1.136.4"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/ObjectPage/controller/ControllerImplementation.js

@@ -1936,7 +1936,6 @@ sap.ui.define([
 							oState.oSectionTitleHandler.adjustSubSectionTitle(oSubSection);
 							// Add accessible name to the SmartForm in the first subsection if all titles are hidden, because accessible name will not propogate to the form control
 							oState.oSectionTitleHandler.addAccessibleName(oSubSection);
-							oState.oSectionTitleHandler.manageAccessability(oSubSection);
 						}
 					}
 

package/src/sap/suite/ui/generic/template/ObjectPage/controller/MessageSortingHandler.js

@@ -491,7 +491,8 @@ sap.ui.define([
 			oMessage.aFullTargets.some(function(sFullPath){
 				if (sFullPath.startsWith(sBindingPathPrefix)){ // This full target points to a place on the current object page
 					oTemplateUtils.oInfoObjectHandler.executeForAllInformationObjects("smartTable", function(oInfoObject){ // Check for all tables whether it even points to the table
-						if (!bFound){ // If a suitable table has already been identified skip all other tables
+						const bControlExists = !!controlHelper.byId(oInfoObject.getId());
+						if (!bFound && bControlExists){ // If a suitable table has already been identified skip all other tables
 							var sStart = sBindingPathPrefix + oInfoObject.getNavigationProperty();
 							if (sFullPath === sStart || sFullPath.startsWith(sStart + "(")){ // If the full target really identifies the table or an entry within the table
 								bFound = true;
@@ -807,6 +808,7 @@ sap.ui.define([
 			return sTableText + sRowHeaderText + sRowText + sErrorColumnText;
 		}
 		testableHelper.testableStatic(getSubtitleForRow, "filterHelper_getSubtitleForRow");
+		testableHelper.testableStatic(fnFindTableForMessage, "messageSortingHandler_fnFindTableForMessage");
 		// public instance methods
 		return {
 			getPrepareMessageDisplayPromise: getPrepareMessageDisplayPromise

package/src/sap/suite/ui/generic/template/ObjectPage/manifest.json

@@ -6,7 +6,7 @@
 		"type": "component",
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
-			"version": "1.136.3"
+			"version": "1.136.4"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/QuickCreate/manifest.json

@@ -6,7 +6,7 @@
 		"type": "component",
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
-			"version": "1.136.3"
+			"version": "1.136.4"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/QuickView/manifest.json

@@ -6,7 +6,7 @@
 	"type": "component",
 	"i18n": "i18n/i18n.properties",
 	"applicationVersion": {
-		"version": "1.136.3"
+		"version": "1.136.4"
 	},
 	"title": "{{TITLE}}",
 	"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/lib/AppComponent.js

@@ -950,7 +950,7 @@ sap.ui.define([
 	 * @public
 	 * @extends sap.ui.core.UIComponent
 	 * @author SAP SE
-	 * @version 1.136.3
+	 * @version 1.136.4
 	 * @name sap.suite.ui.generic.template.lib.AppComponent
 	 */
 	var oAppComponent = UIComponent.extend("sap.suite.ui.generic.template.lib.AppComponent", {

package/src/sap/suite/ui/generic/template/lib/CommonEventHandlers.js

@@ -28,7 +28,8 @@ sap.ui.define(["sap/ui/base/Object",
 	"sap/ui/core/CustomData",
 	"sap/m/VBox",
 	"sap/suite/ui/generic/template/genericUtilities/utils",
-	"sap/ui/core/Element"
+	"sap/ui/core/Element",
+	"sap/ui/generic/app/util/ModelUtil"
 ], function(
 	BaseObject,
 	Event,
@@ -60,7 +61,8 @@ sap.ui.define(["sap/ui/base/Object",
 	CustomData,
 	VBox,
 	genericUtils,
-	Element
+	Element,
+	ModelUtil
 ) {
 	"use strict";
 
@@ -1094,7 +1096,11 @@ sap.ui.define(["sap/ui/base/Object",
 					// and text, using the formatutil and the textarrangement, title should
 					// be passed on the smartlink
 					if (oControl.getFieldName) {
-						var oEntityType = oMetaModel.getODataEntityType(oEntitySet.entityType);
+						// The value "sEntitySet" holds the entity set of an object page or a table.
+						//
+						// Sometimes, the SmartLink is located on a field group which belongs to the child entity set of object page.
+						// So, we have to always derive the entity type from the smart link's binding context.
+						var oEntityType = ModelUtil.getEntityTypeFromContext(oControl.getBindingContext());
 						var oField = oEntityType.property.find(function (oProperty) { return oProperty.name === sSourceClickedField; });
 						var sTextArrangement = "descriptionAndId";
 						if (oField) { // TODO: Need to provide the correct field Object using the entityType and corresponding association (should be handled by a BLI)
@@ -2562,12 +2568,10 @@ sap.ui.define(["sap/ui/base/Object",
 			var  sPath = oContext.getPath();
 			var  oContactData = oModel.getContext(sPath);
 			var oContactAnnotation = JSON.parse(oSourceControl.data("contactDetails"));
-			var sEmail;
-			if (oContactAnnotation.email[0].address && oContactAnnotation.email[0].address.Path) {
-				sEmail = oContactData.getProperty(oContactAnnotation.email[0].address.Path);
-			} else {
-				sEmail = (oContactAnnotation.email[0].address && oContactAnnotation.email[0].address.String);
-			}
+			var emailObj = oContactAnnotation?.email?.[0]?.address;
+			var sEmail = emailObj?.Path
+				? oContactData.getProperty(emailObj.Path)
+				: emailObj?.String;
 
 
 			fnFetchContactStatus(sEmail).then(function (oContactStatus) {

package/src/sap/suite/ui/generic/template/lib/ai/EasyFilterBarHandler.js

@@ -413,12 +413,14 @@ sap.ui.define([
 		 */
 		function fnShowValueHelp(oEvent) {
 			var oSmartFilterbar = oState.oSmartFilterbar;
+            var sKey = oEvent.getParameter("key");
             fnValueHelpPromiseResolve = oEvent.getParameter("resolve");
 			oSmartFilterbar.associateValueLists();
             try {
-                oSmartFilterbar.openValueHelpRequestForFilterItem(oEvent.getParameter("key"));
+                oSmartFilterbar.ensureLoadedValueHelp(sKey);
+                oSmartFilterbar.openValueHelpRequestForFilterItem(sKey);
             } catch (error) {
-                oLogger.error("Value help cannot be triggered for the field " + oEvent.getParameter("key"));
+                oLogger.error("Value help cannot be triggered for the field " + sKey);
             }
 		}
 
@@ -524,6 +526,7 @@ sap.ui.define([
 
             var aFinalResponse = [];
             var oOwnerFilterControl = oState.oSmartFilterbar;
+            var sKey = key;
             var sEntitySet = oController.getOwnerComponent().getEntitySet();
             var oEntityType = oTemplateUtils.oCommonUtils.getMetaModelEntityType(sEntitySet);
             var oSFBModel = oOwnerFilterControl.getModel();
@@ -628,6 +631,12 @@ sap.ui.define([
                 oVHPromise.then((oValueList)=>{
                 var oValueListDefaultBinding = oValueList[""];
                 var sValueListEntity = oValueListDefaultBinding.CollectionPath.String;
+                if (Array.isArray(oValueListDefaultBinding.Parameters)) {
+                    var oParameter = oValueListDefaultBinding.Parameters.find(oParam => (oParam.RecordType === "com.sap.vocabularies.Common.v1.ValueListParameterInOut" && oParam.LocalDataProperty.PropertyPath === sKey));
+                if (oParameter) {    
+                    key = oParameter.ValueListProperty.String; 
+                    }
+                }
                     //Get All Records using $search
                     aFilters.forEach((oFilter)=>{
                         oSFBModel.read("/" + sValueListEntity, {

package/src/sap/suite/ui/generic/template/lib/navigation/NavigationController.js

@@ -3216,7 +3216,7 @@ sap.ui.define(["sap/ui/base/Object",
 	 * @param {sap.suite.ui.generic.template.lib.AppComponent} oAppComponent The AppComponent instance
 	 * @public
 	 * @extends sap.ui.base.Object
-	 * @version 1.136.3
+	 * @version 1.136.4
 	 * @since 1.30.0
 	 * @alias sap.suite.ui.generic.template.lib.NavigationController
 	 */

package/src/sap/suite/ui/generic/template/library.js

@@ -66,7 +66,7 @@ sap.ui.define([
 		interfaces: [],
 		controls: [],
 		elements: [],
-		version: "1.136.3",
+		version: "1.136.4",
 		extensions: {
 			//Configuration used for rule loading of Support Assistant
 			"sap.ui.support": {