@sapui5/sap.suite.ui.generic.template 1.136.1 → 1.136.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sapui5/sap.suite.ui.generic.template",
-  "version": "1.136.1",
+  "version": "1.136.2",
   "description": "SAPUI5 Library sap.suite.ui.generic.template",
   "keywords": [
     "sapui5",

package/src/sap/suite/ui/generic/template/.library

@@ -7,7 +7,7 @@
 
 		(c) Copyright 2009-2015 SAP SE. All rights reserved
 	</copyright>
-	<version>1.136.1</version>
+	<version>1.136.2</version>
 
 	<documentation>Library with generic Suite UI templates.</documentation>
 

package/src/sap/suite/ui/generic/template/AnalyticalListPage/manifest.json

@@ -8,7 +8,7 @@
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
 			"__comment": "applicationVersion oder componentversion??",
-			"version": "1.136.1"
+			"version": "1.136.2"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/Canvas/manifest.json

@@ -8,7 +8,7 @@
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
 			"__comment": "applicationVersion oder componentversion??",
-			"version": "1.136.1"
+			"version": "1.136.2"
 		},
 		"title": "Canvas",
 		"description": "Canvas Page",

package/src/sap/suite/ui/generic/template/ListReport/controller/ControllerImplementation.js

@@ -26,7 +26,8 @@ sap.ui.define([
 	"sap/suite/ui/generic/template/lib/ai/EasyFilterBarHandler",
 	"sap/ui/model/FilterOperator",
 	"sap/ui/core/message/MessageType",
-	"sap/ui/core/Element"
+	"sap/ui/core/Element",
+	"sap/suite/ui/generic/template/genericUtilities/testableHelper"
 ], function (
 	Filter,
 	ExtensionAPI,
@@ -55,7 +56,8 @@ sap.ui.define([
 	EasyFilterBarHandler,
 	FilterOperator,
 	MessageType,
-	Element
+	Element,
+	testableHelper
 ) {
 	"use strict";
 
@@ -335,6 +337,7 @@ sap.ui.define([
 
 			function onShareListReportActionButtonPressImpl(oButton) {
 				var getFilterInfoForTilePromise = function () {
+					try {
 					var oPresentationControlHandler = oState.oPresentationControlHandler;
 					var oMetaModel = oPresentationControlHandler.getModel().getMetaModel();
 					var sEntityTypeName = oMetaModel.getODataEntitySet(oPresentationControlHandler.getEntitySet()).entityType;
@@ -363,7 +366,14 @@ sap.ui.define([
 							sServiceUrl: ""
 						});
 					}
+				} catch (error) {
 
+					oLogger.error("An error occurred while handling Share button press. A static tile will be created instead of a dynamic one. Error:", error.message);
+					return Promise.resolve({
+						sServiceUrl: ""
+					});
+
+				}
 				};
 
 				var oFragmentController = {
@@ -547,6 +557,7 @@ sap.ui.define([
 			// // Expose selected private functions to unit tests
 			// var getDownloadUrl = testableHelper.testable(getDownloadUrl, "getDownloadUrl");
 			/* eslint-enable */
+			testableHelper.testableStatic(onShareListReportActionButtonPressImpl, "ControllerImplementation_onShareListReportActionButtonPressImpl");
 
 			// Generation of Event Handlers
 			return {
@@ -696,7 +707,7 @@ sap.ui.define([
 						onShareListReportActionButtonPressImpl(oMenuButton);
 					});
 				},
-
+				
 				handlers: {
 					addEntry: addEntry,
 					addEntryWithFilters: addEntryWithFilters,

package/src/sap/suite/ui/generic/template/ListReport/manifest.json

@@ -8,7 +8,7 @@
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
 			"__comment": "applicationVersion oder componentversion??",
-			"version": "1.136.1"
+			"version": "1.136.2"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/ObjectPage/controller/ControllerImplementation.js

@@ -2132,6 +2132,13 @@ sap.ui.define([
 				//                           and register for all relevant updates on that context so that we call the same function with
 				// 2. !bFirstTimeForContext = adapt to the change
 				var fnExecuteDynamicColumnHide = function (bFirstTimeForContext, oSmartTableInfoObject) {
+					if (!bFirstTimeForContext && !oContext.getObject(oContext.getPath())) {
+						// In case then method is trigged by property change
+						// and there is no data in model for current context path -> we don't trigger column visibility recalculation
+						// As object data are missing, it's meaningless. But in some cases can break application navigation.
+						// Table columns visibility change -> which will trigger save app state -> which will modify URL
+						return;
+					}
 					var aHiddenColumnInfo = oSmartTableInfoObject.getHiddenColumnInfo();
 
 					// if columns are hidden only statically, no need to refresh hiding here

package/src/sap/suite/ui/generic/template/ObjectPage/manifest.json

@@ -6,7 +6,7 @@
 		"type": "component",
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
-			"version": "1.136.1"
+			"version": "1.136.2"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/QuickCreate/manifest.json

@@ -6,7 +6,7 @@
 		"type": "component",
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
-			"version": "1.136.1"
+			"version": "1.136.2"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/QuickView/manifest.json

@@ -6,7 +6,7 @@
 	"type": "component",
 	"i18n": "i18n/i18n.properties",
 	"applicationVersion": {
-		"version": "1.136.1"
+		"version": "1.136.2"
 	},
 	"title": "{{TITLE}}",
 	"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/detailTemplates/detailUtils.js

@@ -216,34 +216,6 @@ sap.ui.define([	"sap/suite/ui/generic/template/genericUtilities/FeLogger", "sap/
 				oPaginatorButtonsHelper.handleShowPrevObject(oEvent);
 			}
 
-			function fnConstructTitleAdditionalInfo(sTitle, oTemplateContract, oCurrentIdentity) {
-				let sObjectTitle, sObjectSubtitle, sHeaderText;
-				let oCurrentRegistryEntry = oTemplateContract.componentRegistry[oCurrentIdentity.treeNode.componentId];
-				let oTemplatePrivateModel = oCurrentRegistryEntry.utils.getTemplatePrivateModel();
-				sObjectTitle = oTemplatePrivateModel.getProperty("/objectPage/headerInfo/objectTitle");
-				sObjectSubtitle = oTemplatePrivateModel.getProperty("/objectPage/headerInfo/objectSubtitle");
-				let oParentNode = oTemplateContract.mRoutingTree[oCurrentIdentity.treeNode.parentRoute]; //start from the currentNode's parent node
-				let aAncestors = [];
-				let sSeperator = " - ";
-				while (oParentNode.level > 0) { //construct the title only till the main object page
-					aAncestors.push(oParentNode.text || oParentNode.headerTitle);
-					oParentNode = oTemplateContract.mRoutingTree[oParentNode.parentRoute];
-				}
-				let sAncestorsTitle = aAncestors.join(" - "); //final string constructed for the breadcrumb
-				sObjectSubtitle = sObjectSubtitle ? "(" + sObjectSubtitle + ")" : "";
-				if (sObjectTitle && !sObjectSubtitle) {
-					sObjectTitle += sSeperator;
-				}
-				if (sObjectSubtitle) {
-					sObjectSubtitle += sSeperator;
-				}
-				if (sAncestorsTitle && sTitle) {
-					sAncestorsTitle += sSeperator;
-				}
-				sHeaderText = `${sObjectTitle} ${sObjectSubtitle} ${sAncestorsTitle} ${sTitle}`;
-				return {headerText : sHeaderText};
-			}
-
 			// Expose selected private functions to unit tests
 			/* eslint-disable */
 			var fnGetHashChangerInstance = testableHelper.testable(fnGetHashChangerInstance, "getHashChangerInstance");
@@ -334,8 +306,37 @@ sap.ui.define([	"sap/suite/ui/generic/template/genericUtilities/FeLogger", "sap/
 			return oControllerBase;
 		}
 
+		function fnConstructTitleAdditionalInfo(sTitle, oTemplateContract, oCurrentIdentity) {
+			let sObjectTitle, sObjectSubtitle, sHeaderText;
+			let oCurrentRegistryEntry = oTemplateContract.componentRegistry[oCurrentIdentity.treeNode.componentId];
+			let oTemplatePrivateModel = oCurrentRegistryEntry.utils.getTemplatePrivateModel();
+			sObjectTitle = oTemplatePrivateModel.getProperty("/objectPage/headerInfo/objectTitle");
+			sObjectSubtitle = oTemplatePrivateModel.getProperty("/objectPage/headerInfo/objectSubtitle");
+			let oParentNode = oTemplateContract.mRoutingTree[oCurrentIdentity.treeNode.parentRoute]; //start from the currentNode's parent node
+			let aAncestors = [];
+			let sSeperator = " - ";
+			while (oParentNode.level > 0) { //construct the title only till the main object page
+				aAncestors.push(oParentNode.text || oParentNode.headerTitle);
+				oParentNode = oTemplateContract.mRoutingTree[oParentNode.parentRoute];
+			}
+			let sAncestorsTitle = aAncestors.join(" - "); //final string constructed for the breadcrumb
+			sObjectSubtitle = sObjectSubtitle ? "(" + sObjectSubtitle + ")" : "";
+			if (sObjectTitle && !sObjectSubtitle) {
+				sObjectTitle += sSeperator;
+			}
+			if (sObjectSubtitle) {
+				sObjectSubtitle += sSeperator;
+			}
+			if (sAncestorsTitle && sTitle) {
+				sAncestorsTitle += sSeperator;
+			}
+			sHeaderText = `${sObjectTitle} ${sObjectSubtitle} ${sAncestorsTitle} ${sTitle}`;
+			return { headerText: sHeaderText };
+		}
+
 		return {
 			getComponentBase: getComponentBase,
-			getControllerBase: getControllerBase
+			getControllerBase: getControllerBase,
+			fnConstructTitleAdditionalInfo: fnConstructTitleAdditionalInfo
 		};
 	});

package/src/sap/suite/ui/generic/template/genericUtilities/controlStateWrapperFactory/SmartFilterBarWrapper.js

@@ -78,7 +78,7 @@ sap.ui.define([
 						appExtension: oCustomData[dataPropertyNameCustom],
 						adaptationExtensions: oCustomData[dataPropertyNameExtension]
 					};
-
+				aBasicFilters = oSmartFilterBar.getAllFilterItems(true);
 				mParams.oCustomFiltersWrapper.setState(oCustomFiltersState);
 				oSVMWrapperCallbacks.setManagedControlStates(oCustomData[dataPropertyNameGeneric]);
 				/* SFB header state of a variant (standard or custom) gets determined by the Apply Automatically checkbox's value of the corresponding
@@ -190,6 +190,12 @@ sap.ui.define([
 			oSelectOptions = oSelectOptions && oSelectOptions.filter(function(oSelectOption){
 				return oSelectOption.PropertyName !== dataPropertyNameGeneric;
 			});
+			// Get standard filters that are part of the standard variant but are currently not visible in the filterbar.
+			// This is only done if the variant has been modified (i.e., it's dirty).
+			const aStandardItems = oSmartFilterBar.getVariantManagement?.().getModified?.() ? oSmartFilterBar.getAllFilterItems().filter(function(oFilterItem){
+				return oFilterItem.getGroupName() === sap.ui.comp.filterbar.FilterBar.INTERNAL_GROUP && !oFilterItem.getVisibleInFilterBar();
+			}) : [];
+
 			return {
 					selectOptions:	oSelectOptions,
 					parameters: oUiState.getSelectionVariant().Parameters,
@@ -200,7 +206,10 @@ sap.ui.define([
 					}).map(function(oFilterItem){
 						return oFilterItem.getName();
 					}),
-					removedFilterItems: aBasicFilters.filter(function(oFilterItem){
+					// Combine basic filters and standard variant filters (only if the variant is dirty), removing duplicates, then filter out those not visible in the filter bar, 
+					// This is necessary because when the variant is dirty and the iAppState is shared or the app is refreshed, the final iAppState is applied on top of the standard variant.
+					// Keeping track of removed standard filters when the variant is dirty ensures the filter state remains consistent and avoids unexpected behavior for users.
+					removedFilterItems: Array.from(new Set(aBasicFilters.concat(aStandardItems))).filter(function(oFilterItem){
 						return  !oFilterItem.getVisibleInFilterBar();
 					}).map(function(oFilterItem){
 						return oFilterItem.getName();

package/src/sap/suite/ui/generic/template/lib/AppComponent.js

@@ -950,7 +950,7 @@ sap.ui.define([
 	 * @public
 	 * @extends sap.ui.core.UIComponent
 	 * @author SAP SE
-	 * @version 1.136.1
+	 * @version 1.136.2
 	 * @name sap.suite.ui.generic.template.lib.AppComponent
 	 */
 	var oAppComponent = UIComponent.extend("sap.suite.ui.generic.template.lib.AppComponent", {
@@ -1050,6 +1050,10 @@ sap.ui.define([
 				externalNavigationSettings: {
 					type: "object",
 					defaultValue: null
+				},
+				skipOPContextInfoInBrowserTitle: {
+					type: "boolean",
+					defaultValue: false
 				}
 			},
 			events: {
@@ -1059,7 +1063,7 @@ sap.ui.define([
 				config: {
 					async: true,
 					viewType: "XML",
-					viewPath: "",
+					path: "",
 					clearTarget: false
 				},
 				routes: [],

package/src/sap/suite/ui/generic/template/lib/CommonEventHandlers.js

@@ -1107,7 +1107,7 @@ sap.ui.define(["sap/ui/base/Object",
 								oMainNavigation.setDescription(oTexts.secondText);
 							}
 							sTitle = oTexts.firstText;
-							if (sTextArrangement && oTexts.secondText) {
+							if (!!oField["sap:unit"] && oTexts.secondText) {
 								sTitle = oTexts.firstText + " " + oTexts.secondText;
 							}
 						}

package/src/sap/suite/ui/generic/template/lib/ai/EasyFilterBarHandler.js

@@ -114,7 +114,7 @@ sap.ui.define([
                                     if (oRange.operation === "BT") {
                                         return {
                                             operator: FilterOperator.BT,
-                                            selectedValues: [{ value1: oRange.value1, value2: oRange.value2 }]
+                                            selectedValues: [oRange.value1, oRange.value2]
                                         };
                                     } else {
                                         return {
@@ -293,39 +293,40 @@ sap.ui.define([
 
             var aSelectOptions = [];
             var oEditStateFilter = 0;
-            oAIFilters.forEach(function(oFilterItem) {
 
-                if ( oFilterItem.key === "EditState") {
-                    oEditStateFilter  = oFilterItem.keySpecificSelectedValues[0].selectedValues[0]; // Edit state generally should not have more than one filter value
+            oAIFilters.forEach(function (oFilterItem) {
+                if (oFilterItem.key === "EditState") {
+                    oEditStateFilter = oFilterItem.keySpecificSelectedValues[0].selectedValues[0]; // Edit state generally should not have more than one filter value
                 } else {
                     var oFilter = {
-                        PropertyName : oFilterItem.key,
-                        Ranges : []
+                        PropertyName: oFilterItem.key,
+                        Ranges: []
                     };
                     // keySpecificSelectedValues will have one selectedValues object for each operator
                     // ex : [{operator: "EQ", selectedValues: ["HT-1010","HT-10001","1097"]}, {operator: "Contains", selectedValues: ["HT-100"]}]
-                    oFilterItem.keySpecificSelectedValues.forEach(function(oSelectedValues) {
-                        oSelectedValues.selectedValues.forEach(function (oValue) {
-                            var oRange = {
-                                Sign : "I", // currently not considering "E"
-                                High : ""
-                            };
-                            if (oSelectedValues.operator === "Contains") { // need to check for other operators if special handling is required
-                                oRange.Option = "CP";
-                                oRange.Low = oValue;
-                            } else if (oSelectedValues.operator === "BT" || oSelectedValues.operator === "NB") {
-                                // For "BT" and "NB" High is required
-                                // AI reuse responds with array of values for BT and BN (between and not between)
-                                // But in few cases it can also respond with two separate filters (LT and GT)
-                                // FE DOES NOT do the auto merging and results in two separate selectOptions (results in OR condition)
-                                oRange.Low = oValue[0];
-                                oRange.High = oValue[1];
-                            } else {
-                                oRange.Option = oSelectedValues.operator;
-                                oRange.Low = oValue;
-                            }
+                    oFilterItem.keySpecificSelectedValues.forEach(function (oSelectedValues) {
+                        var oRange = {
+                            Sign: "I", // currently not considering "E"
+                            High: ""
+                        };
+
+                        if ((oSelectedValues.operator === "BT" || oSelectedValues.operator === "NB")) {
+                            oRange.Low = oSelectedValues.selectedValues[0];
+                            oRange.High = oSelectedValues.selectedValues[1];
+                            oRange.Option = oSelectedValues.operator;
                             oFilter.Ranges.push(oRange);
-                        });
+                        } else {
+                            oSelectedValues.selectedValues.forEach(function (oValue) {
+                                if (oSelectedValues.operator === "Contains") { // need to check for other operators if special handling is required
+                                    oRange.Option = "CP";
+                                    oRange.Low = oValue;
+                                } else {
+                                    oRange.Option = oSelectedValues.operator;
+                                    oRange.Low = oValue;
+                                }
+                                oFilter.Ranges.push(oRange);
+                            });
+                        }
                     });
                     // one oFilter will have multiple ranges if multiple filters are selected for the same property
                     aSelectOptions.push(oFilter);
@@ -333,7 +334,7 @@ sap.ui.define([
             });
             return {
                 aSelectOptions: aSelectOptions,
-                oEditStateFilter : oEditStateFilter
+                oEditStateFilter: oEditStateFilter
             };
         }
 

package/src/sap/suite/ui/generic/template/lib/navigation/NavigationController.js

@@ -434,6 +434,10 @@ sap.ui.define(["sap/ui/base/Object",
 			return oNavigationControllerProxy.oAppComponent.getProperty('draftDiscardConfirmationSettings').enabled;
 		}
 
+		function isOPContextSkippedInBrowserTitle(){
+			return oNavigationControllerProxy.oAppComponent.getProperty('skipOPContextInfoInBrowserTitle');
+		}
+
 		// returns a promise from FLP shell which can be resolved to get information such as semantic object, action of the application
 		function getParsedShellHashFromFLP(){
 			return UShellContainer && UShellContainer.getServiceAsync("URLParsing");
@@ -518,7 +522,7 @@ sap.ui.define(["sap/ui/base/Object",
 			oTemplateContract.oShellServicePromise.then(function (oShellService) {
 				var oCurrentRegistryEntry = oTemplateContract.componentRegistry[oCurrentIdentity.treeNode.componentId];
 				var oAdditionalInformation = oCurrentRegistryEntry.oControllerUtils && oCurrentRegistryEntry.oControllerUtils.oServices.oTemplateCapabilities.fnConstructTitleAdditionalInfo;
-				if (oAdditionalInformation) {
+				if (oAdditionalInformation && !isOPContextSkippedInBrowserTitle()) {
 					oShellService.setTitle(sTitle, oCurrentRegistryEntry.oControllerUtils.oServices.oTemplateCapabilities.fnConstructTitleAdditionalInfo(sTitle, oTemplateContract, oCurrentIdentity));
 				} else {
 					oShellService.setTitle(sTitle);
@@ -3206,7 +3210,7 @@ sap.ui.define(["sap/ui/base/Object",
 	 * @param {sap.suite.ui.generic.template.lib.AppComponent} oAppComponent The AppComponent instance
 	 * @public
 	 * @extends sap.ui.base.Object
-	 * @version 1.136.1
+	 * @version 1.136.2
 	 * @since 1.30.0
 	 * @alias sap.suite.ui.generic.template.lib.NavigationController
 	 */

package/src/sap/suite/ui/generic/template/lib/navigation/routingHelper.js

@@ -77,7 +77,8 @@ sap.ui.define(["sap/ui/core/Element",
 		// creates a view target as specified and returns the created target
 		function createViewTarget(oNavigationControllerProxy, sHostId, sViewName, sTargetName, sHostAggregation, oBehaviour) {
 			return createTarget(oNavigationControllerProxy, sTargetName, sHostId, sHostAggregation, oBehaviour, {
-				viewName: sViewName
+				type: "View",
+				name: sViewName
 			});
 		}
 

package/src/sap/suite/ui/generic/template/library.js

@@ -66,7 +66,7 @@ sap.ui.define([
 		interfaces: [],
 		controls: [],
 		elements: [],
-		version: "1.136.1",
+		version: "1.136.2",
 		extensions: {
 			//Configuration used for rule loading of Support Assistant
 			"sap.ui.support": {