@sapui5/sap.suite.ui.generic.template 1.121.2 → 1.122.0

package/src/sap/suite/ui/generic/template/ObjectPage/controller/inlineCreationRows/InlineCreationRowsHelper.js

@@ -83,7 +83,8 @@ sap.ui.define([
             oUIModelPropsWithChangeEventAttached = new Set(),
             mContextWithCreatablePathByTableId = new Map(),
             oEditedRowContexts = new Set(),
-            mRequiredPropHelperByTableId = new Map();
+            mRequiredPropHelperByTableId = new Map(),
+            oGridTableWithRowsUpdatedEvent = new Set();
 
             /**
              * This method is invoked when the object page content changes. For example, 
@@ -475,6 +476,8 @@ sap.ui.define([
             function fnUpdateTableRows(oTable) {
                 if (controlHelper.isMTable(oTable)) {
                     fnUpdateResponsiveTableRows(oTable);
+                } else {
+                    fnAttachRowsUpdatedEventForGridTable(oTable);
                 }
             }
 
@@ -489,11 +492,9 @@ sap.ui.define([
                 var sDefaultRowType,
                     sTableId = oTable.getId(),
                     aInactiveRows = fnGetInactiveRowsWithoutTypeBinding(oTable);
-
                 if (aInactiveRows.length === 0) {
                     return;
                 }
-
                 // Preserving the default row type into "mDefaultRowTypeByTableId".
                 // sDefaultRowType is used by "fnHideInlineControlsOnInactiveRow" to restore the row type when the row is persisted 
                 if (mDefaultRowTypeByTableId.get(sTableId)) {
@@ -505,7 +506,7 @@ sap.ui.define([
 
                 aInactiveRows.forEach(function (oInactiveRow) {
                     // Making non insertable property cells as read-only
-                    fnUpdateResponsiveTableRowsBasedOnNonInsertableProperties(oTable, oInactiveRow);
+                    fnUpdateTableRowsBasedOnNonInsertableProperties(oTable, oInactiveRow);
                     // Hiding the inline controls
                     fnInvokeCallbackAfterRendering(oInactiveRow, fnHideInlineControlsOnInactiveRow.bind(null, oInactiveRow, sDefaultRowType));
                 });
@@ -524,8 +525,27 @@ sap.ui.define([
                 });
                 return aInactiveRows;
             }
+            /**
+             * This method attaches a 'rowUpdated' event listener to a Grid Table.
+             * Each time a table is updated, it processes the rows for non insertable cells.
+            */
+            function fnAttachRowsUpdatedEventForGridTable(oTable) {
+                var sId = oTable.getId();
+                if (oGridTableWithRowsUpdatedEvent.has(sId)) {
+                    return;
+                }
+                oGridTableWithRowsUpdatedEvent.add(sId);
+                oTable.attachEvent("rowsUpdated", function() {
+                    var oRows = oTable.getRows();
+                    
+                    oRows.forEach(function(oRow) {
+                        // Making non insertable property cells as read-only
+                        fnUpdateTableRowsBasedOnNonInsertableProperties(oTable, oRow);
+                    });
+                });
+            }
 
-            function fnUpdateResponsiveTableRowsBasedOnNonInsertableProperties(oTable, oInActiveRow) {
+            function fnUpdateTableRowsBasedOnNonInsertableProperties(oTable, oInActiveRow) {
                 // Support NonInsertableProperties to disable the field while creation
                 var oSmartTable = oTable.getParent();
                 var aColumns = oTable.getColumns();
@@ -541,7 +561,12 @@ sap.ui.define([
                     }
                     var aInactiveRowCells = oInActiveRow.getCells();
                     for (var j = 0; j < aIndexOfNonInsertableProperties.length; j++) {
-                        aInactiveRowCells[aIndexOfNonInsertableProperties[j]].bindProperty("editable", {
+                        var oCell = aInactiveRowCells[aIndexOfNonInsertableProperties[j]];
+                        var oBinding = oCell.getBinding("editable");
+                        if (oBinding && oBinding.getPath() === "BINDING_PATH_TRANSIENT_CONTEXT") {
+                            return;
+                        }
+                        oCell.bindProperty("editable", {
                             path: BINDING_PATH_TRANSIENT_CONTEXT,
                             formatter: function (bIsTransient) {
                                 return !bIsTransient;

package/src/sap/suite/ui/generic/template/ObjectPage/extensionAPI/ExtensionAPI.js

@@ -2,7 +2,6 @@ sap.ui.define(
 	["sap/ui/base/Object", "sap/base/util/extend", "sap/suite/ui/generic/template/genericUtilities/FeLogger", "sap/suite/ui/generic/template/genericUtilities/controlHelper"],
 	function(BaseObject, extend, FeLogger, controlHelper) {
 		"use strict";
-		var oLogger = new FeLogger("ObjectPageExtensionAPI.extensionAPI").getLogger();
 		/**
 		 * API to be used in extensions of ObjectPage. Breakout coding can access an instance of this class via
 		 * <code>this.extensionAPI</code>. Do not instantiate yourself.
@@ -14,7 +13,8 @@ sap.ui.define(
 		function getMethods(oTemplateUtils, oController, oBase, oState) {
 			return /** @lends sap.suite.ui.generic.template.ObjectPage.extensionAPI.ExtensionAPI.prototype */ {
 				/**
-				 * Get the entries currently selected in one ui element (table, chart, or list)
+				 * Generally, this method returns the currently selected contexts in one ui element (table, chart, or list).
+				 * In case the context menu is opened, it returns the contexts applicable to the context menu.
 				 *
 				 * @param {string} sUiElementId the id identifying the ui element the selected context is requested for
 				 * @return {sap.ui.model.Context[]} contains one entry per entry selected
@@ -22,31 +22,13 @@ sap.ui.define(
 				 */
 				getSelectedContexts: function(sUiElementId) {
 					var oControl = oController.byId(sUiElementId);
-					return oTemplateUtils.oServices.oPresentationControlHandlerFactory.getPresentationControlHandler(oTemplateUtils.oCommonUtils.getOwnerPresentationControl(oControl)).getSelectedContexts();
-				},
-
-				/**
-				 * Hides Section and/or SubSection's title for embedded components and custom section(s), if the Section and/or SubSection's title matches with the inner Control's title.
-				 * In case the control's resolved title is provided and is same as section's title, then the section's title is also automatically hidden.
-				 * It's meant to be invoked from the onSubSectionEnteredExtension ExtensionAPI.
-				 * @param {string} sSubSectionId the ID identifying the Sub-Section to which you want to hide the title
-				 * @param {string} [sTitle] Optional parameter which represents the resolved title of the inner conrol defined in the Resue Component or Custom Section/SubSection
-				 * @deprecated Since version 1.121.0 use API setAsTitleOwner instead.
-				 */
-				hideDuplicateSectionOrSubSectionTitle: function(sSubSectionId, sTitle) {
-					var oSubSection = oController.byId(sSubSectionId);
-					if (!oSubSection) {
-						oLogger.error("Control ID with " + sSubSectionId + " is not part of the viewport ");
-					}
-					var oSection = oSubSection.getParent();
-					if (!sTitle || oSubSection.getTitle() === sTitle) {
-						oSubSection.setShowTitle(false);
-						oSection.addStyleClass("sapUiTableOnObjectPageAdjustmentsForSection");
-					}
-					if (!sTitle || oSection.getSubSections().length === 1 && oSection.getTitle() === sTitle) {
-						oSection.setShowTitle(false);
-						oSection.addStyleClass("sapUiTableOnObjectPageAdjustmentsForSection");
+					var oPresentationControl = oTemplateUtils.oCommonUtils.getOwnerPresentationControl(oControl);
+					// This focus info is added to state by sap.suite.ui.generic.template.lib.ContextMenuHandler when the context menu is opened
+					// If the state contains focus info, return the contexts applicable for context menu
+					if (oState.oFocusInfo && oState.oFocusInfo.smartControlId === oPresentationControl.getId()) {
+						return oState.oFocusInfo.applicableContexts;
 					}
+					return oTemplateUtils.oServices.oPresentationControlHandlerFactory.getPresentationControlHandler(oPresentationControl).getSelectedContexts();
 				},
 				
 				/**

package/src/sap/suite/ui/generic/template/ObjectPage/manifest.json

@@ -6,7 +6,7 @@
 		"type": "component",
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
-			"version": "1.121.2"
+			"version": "1.122.0"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/ObjectPage/view/fragments/SmartTable.fragment.xml

@@ -139,6 +139,7 @@
 											<table:AnalyticalTable id="{path: 'facet>', formatter: 'AH.getStableIdPartFromFacet'}::analyticalTable"
 												visibleRowCountMode="Auto" enableColumnReordering="true"
 												rowSelectionChange="._templateEventHandlers.onSelectionChange"
+												beforeOpenContextMenu="._templateEventHandlers.beforeOpenContextMenu($event, '{smartControlId>id}')"
 												showColumnVisibilityMenu="false"
 												enableColumnFreeze="true" enableCellFilter="true" rowActionCount="{= ${parts: [ {path: 'listEntitySet>'}, {path: 'parameter>/settings/subPages/'}, {path: 'parameter>/manifest'}, {path: 'facet>Target/AnnotationPath'},{path: 'parameter>/isDraftEnabled'}], formatter: 'AH.getRowActionCountForDetailPage'}}">
 												<core:Fragment fragmentName="sap.suite.ui.generic.template.ObjectPage.view.fragments.SmartTableUiTableCommons" type="XML"/>
@@ -157,6 +158,7 @@
 												visibleRowCountMode="Auto"
 												expandFirstLevel="false"
 												rowSelectionChange="._templateEventHandlers.onSelectionChange"
+												beforeOpenContextMenu="._templateEventHandlers.beforeOpenContextMenu($event, '{smartControlId>id}')"
 												rowActionCount="{= ({parts: [{path: 'listEntitySet>'}, {path: 'parameter>/settings/subPages/'}], formatter: 'AH.hasSubObjectPage'} ? 1 : 0 )}">
 												<core:Fragment fragmentName="sap.suite.ui.generic.template.ObjectPage.view.fragments.SmartTableUiTableCommons" type="XML"/>
 												<table:columns>
@@ -172,6 +174,7 @@
 											<table:Table id="{path: 'facet>', formatter: 'AH.getStableIdPartFromFacet'}::gridTable"
 												enableColumnReordering="true" showColumnVisibilityMenu="false" visibleRowCountMode="Auto"
 												rowSelectionChange="._templateEventHandlers.onSelectionChange"
+												beforeOpenContextMenu="._templateEventHandlers.beforeOpenContextMenu($event, '{smartControlId>id}')"
 												enableColumnFreeze="true" enableCellFilter="true"
 												rowActionCount="{= ${parts: [ {path: 'listEntitySet>'}, {path: 'parameter>/settings/subPages/'},{path: 'parameter>/manifest'}, {path: 'facet>Target/AnnotationPath'},{path: 'parameter>/isDraftEnabled'}], formatter: 'AH.getRowActionCountForDetailPage'}}">
 												<core:Fragment fragmentName="sap.suite.ui.generic.template.ObjectPage.view.fragments.SmartTableUiTableCommons" type="XML"/>
@@ -190,6 +193,7 @@
 												growing="true" growingThreshold="10"
 												mode="{objectPageTableSettings>value/mode}"
 												selectionChange="._templateEventHandlers.onSelectionChange"
+												beforeOpenContextMenu="._templateEventHandlers.beforeOpenContextMenu($event, '{smartControlId>id}')"
 												delete="._templateEventHandlers.deleteEntry"
 												itemPress="._templateEventHandlers.onListNavigate"
 												updateFinished="._templateEventHandlers.checkUpdateFinished"

package/src/sap/suite/ui/generic/template/QuickCreate/manifest.json

@@ -6,7 +6,7 @@
 		"type": "component",
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
-			"version": "1.121.2"
+			"version": "1.122.0"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/QuickView/manifest.json

@@ -6,7 +6,7 @@
 	"type": "component",
 	"i18n": "i18n/i18n.properties",
 	"applicationVersion": {
-		"version": "1.121.2"
+		"version": "1.122.0"
 	},
 	"title": "{{TITLE}}",
 	"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/fragments/SmartTableResponsiveTableCommons.fragment.xml

@@ -2,7 +2,12 @@
 
 	<core:Fragment fragmentName="sap.suite.ui.generic.template.fragments.TableColumns" type="XML" />
 	<core:Fragment fragmentName="sap.suite.ui.generic.template.fragments.TableColumnListItem" type="XML" />
-	<!-- <contextMenu>
+	<!--
+	<contextMenu>
 		<core:Fragment fragmentName="sap.suite.ui.generic.template.fragments.SmartControlContextMenu" type="XML"/>
-	</contextMenu>	 -->
+	</contextMenu>
+	<dependents>
+		<plugins.ContextMenuSetting scope="Selection"/>
+	</dependents>
+	-->
 </core:FragmentDefinition>

package/src/sap/suite/ui/generic/template/fragments/SmartTableUiTableCommons.fragment.xml

@@ -1,4 +1,4 @@
-<core:FragmentDefinition xmlns:core="sap.ui.core" xmlns:table="sap.ui.table"
+<core:FragmentDefinition xmlns="sap.m" xmlns:core="sap.ui.core" xmlns:table="sap.ui.table"
 	xmlns:template="http://schemas.sap.com/sapui5/extension/sap.ui.core.template/1"
 	template:require="{AH: 'sap/suite/ui/generic/template/js/AnnotationHelper'}">
 
@@ -7,6 +7,7 @@
 			enableNotification="true"
 			selectionChange="._templateEventHandlers.onMultiSelectionChange"
 			selectionMode="{tableSettings>mode}" />
+		<!-- <plugins.ContextMenuSetting scope="Selection"/> -->
 	</table:dependents>
 	<table:rowSettingsTemplate>
 		<table:RowSettings 
@@ -15,5 +16,5 @@
 	</table:rowSettingsTemplate>
 	<!-- <table:contextMenu>
 		<core:Fragment fragmentName="sap.suite.ui.generic.template.fragments.SmartControlContextMenu" type="XML"/>
-	</table:contextMenu>	 -->
+	</table:contextMenu> -->
 </core:FragmentDefinition>

package/src/sap/suite/ui/generic/template/genericUtilities/controlHelper.js

@@ -1,10 +1,14 @@
-sap.ui.define(["sap/ui/dom/getFirstEditableInput", "sap/suite/ui/generic/template/genericUtilities/FeLogger"], function(getFirstEditableInput, FeLogger) {
+sap.ui.define([
+	"sap/ui/dom/getFirstEditableInput", 
+	"sap/suite/ui/generic/template/genericUtilities/FeLogger",
+	"sap/ui/core/Element"
+], function(getFirstEditableInput, FeLogger, Element) {
 		"use strict";
 		
 	var oFeLogger = new FeLogger("genericUtilities.controlHelper");
 	var oLogger = oFeLogger.getLogger();
 	
-	var byId = sap.ui.getCore().byId;
+	var byId = Element.getElementById;
 	
 	function isControlOfType(sPathToType, oControl){
 		var FNClass = sap.ui.require(sPathToType);
@@ -14,7 +18,7 @@ sap.ui.define(["sap/ui/dom/getFirstEditableInput", "sap/suite/ui/generic/templat
 	function getUI5ControlForDomElement(oDom){
 	    for (; oDom; oDom = oDom.parentNode) {
 	        if (oDom.hasAttribute && oDom.hasAttribute("data-sap-ui")) {
-				return sap.ui.getCore().byId(oDom.id);
+				return byId(oDom.id);
 	        }
 	    }		
 	}

package/src/sap/suite/ui/generic/template/genericUtilities/filterHelper.js

@@ -3,7 +3,7 @@ sap.ui.define([
 	"sap/ui/core/format/DateFormat",
 	"sap/base/security/encodeURL",
 	"sap/m/DynamicDateUtil",
-	"sap/ui/core/CalendarType"
+	"sap/base/i18n/date/CalendarType"
 ], function (FilterOperator, DateFormat, encodeURL, DynamicDateUtil, CalendarType) {
     "use strict";
 

package/src/sap/suite/ui/generic/template/js/AnnotationHelperHiddenTermSupport.js

@@ -0,0 +1,69 @@
+sap.ui.define([
+    "sap/base/util/isEmptyObject",
+    "sap/suite/ui/generic/template/js/AnnotationHelper"
+], function (isEmptyObject, AnnotationHelper) {
+    "use strict";
+
+    var oHiddenColumnInfo = {
+        staticHiddenColumns: [],
+        columnKeyToCellHiddenPath: undefined
+    };
+
+     /*
+        *  This method is called in the initialization and dataReceived phase of the specified SmartTable.
+        *  It handles everything which can be done regarding hiding columns at this point in time.
+        *  This is:
+        *     - Check for columns which are hidden statically(Bool) or dynamically(Path)
+        *     - Immediately hide the columns which are statically hidden at SmartTable init
+        *     - Dynamically hide the cells based the Path property at SmartTable dataReceived event
+    */
+    function fnGetHiddenColumnInfo(oSmartTable) {
+        // Initialization which needs the control to be created
+        var oMetaModel = oSmartTable.getModel().getMetaModel(); // prepare metadata
+        var oEntitySet = oMetaModel.getODataEntitySet(oSmartTable.getEntitySet());
+        var oEntityType = oMetaModel.getODataEntityType(oEntitySet.entityType);
+        var aCustomData = oSmartTable.getCustomData();
+        var oCustomDataForLineItemQualifier = aCustomData.find(function(oCustomData){
+            return oCustomData.getKey() === "lineItemQualifier";
+        });
+        var sLineItemSuffix = (oCustomDataForLineItemQualifier && oCustomDataForLineItemQualifier.getValue()) ? ("#" + oCustomDataForLineItemQualifier.getValue()) : "";
+        var aDataFields = oEntityType["com.sap.vocabularies.UI.v1.LineItem" + sLineItemSuffix] || [];
+        
+        var aStaticHiddenColumns = []; // list of keys of columns that are always hidden
+        var mColumnKeyToDynamicHiddenPath = Object.create(null); // map of column keys to pathes that determine whether the column is shown
+       
+        aDataFields.forEach(fnAnalyzeColumnHideInfoForDataField.bind(null, aStaticHiddenColumns, mColumnKeyToDynamicHiddenPath, oMetaModel, oEntityType));
+        if (!isEmptyObject(mColumnKeyToDynamicHiddenPath) || aStaticHiddenColumns.length) { // if there is at least one column with hide info we store this analysis in the info object
+            oHiddenColumnInfo.staticHiddenColumns = aStaticHiddenColumns;
+            oHiddenColumnInfo.columnKeyToCellHiddenPath = mColumnKeyToDynamicHiddenPath;
+        }
+        return oHiddenColumnInfo;
+    }
+
+    /*
+        * Add the information derived from the UI:Hidden annotation for one line item to either
+        * aStaticHiddenColumns or mColumnKeyToDynamicHiddenPath, or none.
+    */
+    function fnAnalyzeColumnHideInfoForDataField(aStaticHiddenColumns, mColumnKeyToDynamicHiddenPath, oMetaModel, oEntityType, oDataField) {
+        // regular expression for ?
+        var rPath = /[A-Za-z].*[A-Za-z]/;
+
+        var sColumnKey = AnnotationHelper.createP13NColumnKey(oDataField);
+        var vExpression = AnnotationHelper.getBindingForHiddenPath(oDataField);
+        if (vExpression === "{= !${} }") {
+            aStaticHiddenColumns.push(sColumnKey);
+        }
+        if (typeof (vExpression) === "string") {
+            var sPath = vExpression.match(rPath) && vExpression.match(rPath)[0];
+            if (sPath && sPath.indexOf("/") === -1) {
+                mColumnKeyToDynamicHiddenPath[sColumnKey] = sPath;
+            }
+        } else if (!vExpression) {
+            aStaticHiddenColumns.push(sColumnKey);
+        }
+    }
+
+    return {
+		getHiddenColumnInfo: fnGetHiddenColumnInfo
+	};
+});

package/src/sap/suite/ui/generic/template/lib/AdaptiveCardHelper.js

@@ -15,7 +15,7 @@ sap.ui.define([
 	var fnGetColorFromAnnotations = function (sCriticalityPath) {
 		if (sCriticalityPath) {
 			var sColorExp = sCriticalityPath.indexOf('/') > -1 ? sCriticalityPath.replaceAll('/', '.') : sCriticalityPath;
-			return "${if(" + sColorExp + " == '0', 'Default', if(" + sColorExp + " == '1' , 'Attention', if(" + sColorExp + " == '2' , 'Warning', 'Good')))}";
+			return "${if(int(" + sColorExp + ") == 0, 'Default', if(int(" + sColorExp + ") == 1 , 'Attention', if(int(" + sColorExp + ") == 2 , 'Warning', 'Good')))}";
 		}
 		return 'Default';
 	};
@@ -137,7 +137,7 @@ sap.ui.define([
 							var aParts = oBindingInfoOfText.parts;
 							if (aParts && aParts.length > 0) {
 								aParts.forEach(function (part) {
-									if (part.path !== oDataPointData.path) {
+									if (part.path !== oDataPointData.path && part.path !== "__$$SmartFieldNotExistingBindingPath") {
 										oDataPointData.paths[part.path] = part.path;
 									}
 								});
@@ -250,7 +250,7 @@ sap.ui.define([
 								if (aParts && aParts.length > 0) {
 									for (var j = 0; j < aParts.length; j++) {
 										var part = aParts[j];
-										if (part.path !== oFieldData.path) {
+										if (part.path !== oFieldData.path && part.path !== "__$$SmartFieldNotExistingBindingPath") {
 											oFieldData.paths[part.path] = part.path;
 										}
 									}
@@ -280,7 +280,7 @@ sap.ui.define([
 				return oPath !== oField.path && oPath.indexOf("##@@") === -1;
 			});
 		}
-		var sValue =  oField.edmType === "Edm.Decimal" ? "${formatNumber(" + oField.path + ", 2)}" : "${" + oField.path + "}";
+		var sValue =  oField.edmType === "Edm.Decimal" ? "${formatNumber(float(" + oField.path + "), 2)}" : "${" + oField.path + "}";
 		var sId = "";
 		var sDescription = "";
 		var sPath;

package/src/sap/suite/ui/generic/template/lib/AppComponent.js

@@ -173,7 +173,7 @@ sap.ui.define([
 			                                  //             Parameter fnFallback will be the fallback function (see above) with oBeforeData already set accordingly.
 			                                  // Currently this infrastructure is used by one topic (namely 'focus', see class FocusHelper).
 			                                  // The implementation of this infrastructure is done in class BusyHelper.
-			bEnablePlaceholder: bShellConfigPlaceholderEnabled, //holds the value of placeholder enablement shell and URL
+			bEnablePlaceholder: bShellConfigPlaceholderEnabled, //holds the value of placeholder enablement shell and URL (URL enablement will be added in constructor code of NavigationController).
 			bStateHandlingSuspended: false, // holds the RTA or Key user mode
 			nDelayedDraftTimerInSeconds: 20		// holds the timer interval value for draft data save and by default, the value is 20 seconds
 		};
@@ -915,7 +915,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.UIComponent
 	 * @abstract
 	 * @author SAP SE
-	 * @version 1.121.2
+	 * @version 1.122.0
 	 * @name sap.suite.ui.generic.template.lib.AppComponent
 	 */
 	return UIComponent.extend("sap.suite.ui.generic.template.lib.AppComponent", {

package/src/sap/suite/ui/generic/template/lib/CommonEventHandlers.js

@@ -809,7 +809,18 @@ sap.ui.define(["sap/ui/base/Object",
 				var mTargetEntities = oComponentUtils.getParameterModelForTemplating().oData.templateSpecific.targetEntities[oEntitySet.entityType].mTargetEntities;
 				oControl = getClickedControl();
 				sControlBindingContextPath = oControl.getBindingContext().getPath();
-				sSourceClickedField = oControl && oControl.mProperties.fieldName;
+				if (oControl) {
+					if (oControl.isA("sap.ui.comp.navpopover.SmartLink")) {
+						sSourceClickedField = oControl && oControl.mProperties.fieldName;
+					} else if (oControl.isA("sap.m.ObjectIdentifier")) {
+						var oTextBinding = oControl.getBinding("text");
+						if (oTextBinding && oTextBinding.oType) {
+							sSourceClickedField = oTextBinding.sPath;
+						} else {
+							sSourceClickedField = oControl.getBinding("title").sPath;
+						}
+					}
+				}
 
 				//SemanticObjectController may also decide to render some as links even as we do not, using forceLinkRendering property
 				if (mTargetEntities[sSourceClickedField]) {
@@ -1321,6 +1332,36 @@ sap.ui.define(["sap/ui/base/Object",
 			}
 		}
 
+		/**
+		 * This method is called in the onDataReceived event of the specified SmartTable.
+		 * It handles everything which can be done regarding hiding of cells at this point in time.
+		*/
+		function fnHideTableCells(oSmartTable, oHiddenColumnInfo) {
+			for (var sColumnKey in oHiddenColumnInfo.columnKeyToCellHiddenPath) {
+				var sPath = oHiddenColumnInfo.columnKeyToCellHiddenPath[sColumnKey];
+				fnHandleTableCellVisibility(oSmartTable, sColumnKey, sPath);
+			}
+		}
+
+		/**
+		 * This method is called for each Row of Table,to control the visibility of the Cell based on the Hidden property in LineItem.
+		 */
+		function fnHandleTableCellVisibility(oSmartTable, sColumnKey, sPath) {
+			var oSmartTableHandler = oServices.oPresentationControlHandlerFactory.getPresentationControlHandler(oSmartTable);
+			var oTable = oSmartTable.getTable();
+			var aItems = oTable.getRows ? oTable.getRows() : oTable.getItems();
+			aItems.forEach(function(oItem) {
+				var oColumn = oSmartTableHandler.getColumnByKey(sColumnKey);
+				var oCell = oColumn && oItem.getCells()[oTable.indexOfColumn(oColumn)];
+				oCell && oCell.bindProperty("visible", {
+					path: sPath,
+					formatter: function (bIsHidden) {
+						return !bIsHidden;
+					}
+				});
+			});
+		}
+
 		// callback for the onBeforeRebindTable event of a smart table
 		// oEvent is the original event
 		// oCallbacks is an optional object which contains additional callbacks to be called.
@@ -1606,7 +1647,7 @@ sap.ui.define(["sap/ui/base/Object",
 				var sEntitySet = oTable.getEntitySet();
 				var oEditPromise = CRUDHelper.directEdit(oServices.oTransactionController, sEntitySet, oBindingContext.sPath, oBindingContext.getModel(), oServices.oApplication, oCommonUtils, oServices.oViewDependencyHelper, oViewProxy, bOpenInEditMode);
 				oEditPromise.then(function(oResult){
-					oCommonUtils.navigateFromListItem(oResult.context, bReplace, bOpenInEditMode);
+					oCommonUtils.navigateFromListItem(oResult.context, bReplace, true);
 				}, function(oError){
 					if (oError.lockedByUser) {
 						var sLockText = oCommonUtils.getText("ST_GENERIC_DRAFT_LOCKED_BY_USER", [" ", oError.lockedByUser]);
@@ -1662,13 +1703,13 @@ sap.ui.define(["sap/ui/base/Object",
 				var iViewLevel = oComponentUtils.getViewLevel();
 				var aCurrentKeys = oServices.oApplication.getCurrentKeys(iViewLevel + 1);
 				var bReplace = aCurrentKeys.length > iViewLevel + 1;  // if the list from which the navigation is started is not the most right one, perform the navigation as a replace navigation
-				// This will care for:
-				// - wait until side-effects have been executed
-				// - app is not busy (otherwise do nothing)
-				// - send a data loss popup in case needed (might also result in doing nothing)
-				if (oEventSource.data("CrossNavigation") || (!oEventSource.data("CrossNavigation") && !oComponentUtils.isDraftEnabled())){
+				if (oEventSource.data("CrossNavigation") || !oComponentUtils.isDraftEnabled()){
+					// oCommonUtils.fnProcessDataLossOrDraftDiscardConfirmation will care for:
+					// - wait until side-effects have been executed
+					// - app is not busy (otherwise do nothing)
+					// - send a data loss popup in case needed (might also result in doing nothing)					
 					oCommonUtils.fnProcessDataLossOrDraftDiscardConfirmation(onListNavigateImpl.bind(null, oEventSource, oEventParameters, oState, oBindingContext, bReplace), Function.prototype, "LeaveApp");
-				} else {
+				} else if (!oServices.oApplication.getBusyHelper().isBusy()) { // if the app is already busy with something else stop navigation here
 					onListNavigateImpl(oEventSource, oEventParameters, oState, oBindingContext, bReplace, oViewProxy);
 				}
 			}
@@ -2641,7 +2682,8 @@ sap.ui.define(["sap/ui/base/Object",
 			onBeforeExport: fnOnBeforeExport,
 			handleSideEffectForField: fnHandleSideEffectForField,
 			onSmartFieldModeToggled: onSmartFieldModeToggled,
-			onRenderTeamsContactCollabOptions: fnRenderTeamsContactCollabOptions
+			onRenderTeamsContactCollabOptions: fnRenderTeamsContactCollabOptions,
+			hideTableCells: fnHideTableCells
 		};
 	}
 

package/src/sap/suite/ui/generic/template/lib/CommonUtils.js

@@ -527,7 +527,39 @@ sap.ui.define(["sap/ui/base/Object",
 		function fnUpdateBreakoutEnablementForAction(mBreakOutActionEnabled, aContexts, oModel, sSelectedTabKey, oControl, oBreakoutAction){
 			var sControlId = oBreakoutAction.id + ((sSelectedTabKey && !oBreakoutAction.determining) ? "-" + sSelectedTabKey : "");
 			var bIsAnalyticalListPage = oControl && oControl.getId().indexOf("AnalyticalListPage") > -1;
-			var bEnabled = !bIsAnalyticalListPage || !!mBreakOutActionEnabled[sControlId].enabled;
+			// Finding the default value of "enabled"
+			// For LR/OP, the default value is true.
+			// For ALP, the default value is taken from "mBreakoutActionEnabled" map.
+			//
+			// Reason for the special handling in ALP:
+			// This method is invoked twice in ALP. Once for smart table and once again for smart chart.
+			// In the first iteration (smart table actions), the calculated enablement value is stored on "mBreakoutActionEnabled".
+			// In the second iteration (smart chart actions), the enablement should be calculated only for the chart actions (oBreakoutAction.filter = "chart").
+			// As the previously calculated value for the table actions should be retained, the value stored on "mBreakoutActionEnabled" is used as the default value. 
+			var bDefaultValue = !bIsAnalyticalListPage || !!mBreakOutActionEnabled[sControlId].enabled;
+			var bEnabled = fnIsBreakoutActionEnabled(oBreakoutAction, aContexts, oModel, oControl, bDefaultValue, bIsAnalyticalListPage);
+			
+			mBreakOutActionEnabled[sControlId] = {
+					enabled: bEnabled
+			};			
+		}
+		
+		/**
+		 * This method analyzes the applicable contexts and tells whether the breakout action should be enabled.
+		 * 
+		 * If the context based analysis is not required (i.e the action doesn't require selection), 
+		 * it will simply return the default value <code>bDefaultValue</code>.
+		 * 
+		 * @param {object} oBreakoutAction Manifest information about the breakout action
+		 * @param {Array<sap.ui.model.Context>} aContexts Applicable contexts
+		 * @param {sap.ui.model.Model} oModel Model of the smart control
+		 * @param {sap.ui.core.Control} oControl The smart control
+		 * @param {boolean} bDefaultValue The default value of "enabled".
+		 * @param {boolean} bIsAnalyticalListPage Boolean flag that tells whether the current breakout action belong to the Analytical List Page
+		 * @returns {boolean}
+		 */
+		function fnIsBreakoutActionEnabled(oBreakoutAction, aContexts, oModel, oControl, bDefaultValue, bIsAnalyticalListPage) {
+			var bEnabled = bDefaultValue;
 			var bFilterIsChart = oBreakoutAction.filter === "chart";
 			if (oBreakoutAction.requiresSelection) {
 				if (aContexts.length > 0) { // context selected
@@ -544,6 +576,8 @@ sap.ui.define(["sap/ui/base/Object",
 					}
 				} else if (controlHelper.isSmartChart(oControl)) {
 					//table button chart ondata received
+					// For LR/OP, directly evaluate the drill stack filters and enable the action accordingly.
+					// For ALP, evaluate the drill stack filters only when oBreakoutAction.filter is "chart" and skip the evaluation for table based actions. 
 					if (!bIsAnalyticalListPage || bFilterIsChart) {
 						// If enabled Selection is made on the chart but drilldown is performed later.
 						bEnabled = oControl.getDrillStackFilters().length > 0;
@@ -553,11 +587,10 @@ sap.ui.define(["sap/ui/base/Object",
 					bEnabled = bEnabled && bFilterIsChart; //table ondatareceived when chart selected
 				}
 			}
-			mBreakOutActionEnabled[sControlId] = {
-					enabled: bEnabled
-			};			
+			return bEnabled;
+			
 		}
-		
+
 		function fnUpdateBreakoutEnablement(mBreakOutActionEnabled, mBreakoutActions, aContexts, oModel, sSelectedTabKey, oControl) {
 			for (var sActionId in mBreakoutActions) {
 				var oBreakoutAction = mBreakoutActions[sActionId];
@@ -666,9 +699,6 @@ sap.ui.define(["sap/ui/base/Object",
 		 * Triggers navigation from a given list item.
 		 *
 		 * @param {sap.ui.model.context} selected context for navigation
-		 * @param {object} oTable The table from which navigation was triggered
-		 *        control in the table
-		 * @public
 		 */
 		function fnNavigateFromListItem(oContext, bReplace, bOpenInEditMode) {
 			var iDisplayMode;
@@ -680,6 +710,7 @@ sap.ui.define(["sap/ui/base/Object",
 			}
 			if (bOpenInEditMode) {
 				oServices.oApplication.setObjectInEditMode(true);
+				iDisplayMode = 6;
 			}
 			oComponentUtils.navigateAccordingToContext(oContext, iDisplayMode, bReplace);
 		}
@@ -1762,6 +1793,7 @@ sap.ui.define(["sap/ui/base/Object",
 			getToolbarActionEnablementInfo: getToolbarActionEnablementInfo,
 			fillEnabledMapForBreakoutActions: fnFillEnabledMapForBreakoutActions,
 			getBreakoutActions: fnGetBreakoutActions,
+			isBreakoutActionEnabled: fnIsBreakoutActionEnabled,
 			getSelectionPoints: getSelectionPoints,
 			getDeleteRestrictions: fnGetDeleteRestrictions,
 			getSmartTableDefaultVariant: fnGetSmartTableDefaultVariant,

package/src/sap/suite/ui/generic/template/lib/ComponentUtils.js

@@ -8,9 +8,8 @@ sap.ui.define(["sap/ui/base/Object",
 	"sap/base/util/extend",
 	"sap/base/util/isEmptyObject",
 	"sap/suite/ui/generic/template/genericUtilities/FeError",
-	"sap/base/util/UriParameters",
 	"sap/suite/ui/generic/template/lib/CommandComponentUtils"
-	], function(BaseObject, ManagedObjectModel, controlHelper, FeLogger, oDataModelHelper, CRUDActionHandler, StatePreserver, extend, isEmptyObject, FeError, UriParameters,
+	], function(BaseObject, ManagedObjectModel, controlHelper, FeLogger, oDataModelHelper, CRUDActionHandler, StatePreserver, extend, isEmptyObject, FeError,
 		CommandComponentUtils) {
 	"use strict";
 	var	sClassName = "lib.ComponentUtils";
@@ -1039,7 +1038,7 @@ sap.ui.define(["sap/ui/base/Object",
 
 		function isRenderingWaitingForViewportEntered () {
 			var oManifestSettings = getSettings();
-			var useViewLazyLoadingFromUri = UriParameters.fromQuery(window.location.search).get("sap-fe-xx-lazyloadingtest");
+			var useViewLazyLoadingFromUri = new URLSearchParams(window.location.search).get("sap-fe-xx-lazyloadingtest");
 			return useViewLazyLoadingFromUri != null ? useViewLazyLoadingFromUri === "true" : oManifestSettings.renderingBehavior && oManifestSettings.renderingBehavior.waitForViewportEnter;
 		}