@sapui5/sap.suite.ui.generic.template 1.120.41 → 1.120.42

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sapui5/sap.suite.ui.generic.template",
-  "version": "1.120.41",
+  "version": "1.120.42",
   "description": "SAPUI5 Library sap.suite.ui.generic.template",
   "keywords": [
     "sapui5",

package/src/sap/suite/ui/generic/template/.library

@@ -7,7 +7,7 @@
 
 		(c) Copyright 2009-2015 SAP SE. All rights reserved
 	</copyright>
-	<version>1.120.41</version>
+	<version>1.120.42</version>
 
 	<documentation>Library with generic Suite UI templates.</documentation>
 

package/src/sap/suite/ui/generic/template/AnalyticalListPage/i18n/i18n_it.properties

@@ -204,9 +204,9 @@ NODATA_ADAPTFILTERDIALOG=Nessun dato
 
 
 
-NODATA_SMARTCHART_ALP=Per iniziare, impostare i filtri rilevanti e selezionare "Avvio".
+NODATA_SMARTCHART_ALP=Per iniziare, imposta i filtri rilevanti e seleziona "Avvio".
 
-NODATA_SMARTTABLE_ALP=Per iniziare, impostare i filtri rilevanti e selezionare "Avvio".
+NODATA_SMARTTABLE_ALP=Per iniziare, imposta i filtri rilevanti e seleziona "Avvio".
 
 MESSAGE_MULTIPLE_VALUES_L_FORM=Alcuni filtri non sono rilevanti per il tab "{1}" ({0}). L\u2019impostazione di questi filtri non incide sui risultati.
 

package/src/sap/suite/ui/generic/template/AnalyticalListPage/manifest.json

@@ -8,7 +8,7 @@
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
 			"__comment": "applicationVersion oder componentversion??",
-			"version": "1.120.41"
+			"version": "1.120.42"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/Canvas/manifest.json

@@ -8,7 +8,7 @@
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
 			"__comment": "applicationVersion oder componentversion??",
-			"version": "1.120.41"
+			"version": "1.120.42"
 		},
 		"title": "Canvas",
 		"description": "Canvas Page",

package/src/sap/suite/ui/generic/template/ListReport/controller/ControllerImplementation.js

@@ -497,8 +497,7 @@ sap.ui.define([
 				return restoreFocusHelper;
 			}
 
-			// // Expose selected private functions to unit tests
-			// var getDownloadUrl = testableHelper.testable(getDownloadUrl, "getDownloadUrl");
+			// Expose selected private functions to unit tests
 			/* eslint-enable */
 
 			// Generation of Event Handlers
@@ -646,6 +645,9 @@ sap.ui.define([
 				},
 
 				handlers: {
+					onAfterVariantInitialise: function(oEvent) {
+						oTemplateUtils.oCommonUtils.getControlStateWrapper(oEvent.getSource()).onAfterVariantInitialise();
+					},
 					addEntry: addEntry,
 					addEntryWithFilters: addEntryWithFilters,
 					deleteEntries: fnDeleteEntries,

package/src/sap/suite/ui/generic/template/ListReport/controller/IappStateHandler.js

@@ -209,12 +209,6 @@ sap.ui.define([
 		// However, for iAppState case, SVM wrapper also needs to contain SFB wrapper (and not oCustomFiltersWrapper directly)
 
 
-		// DynamicPage state: header pinned
-		var oDynamicPage = oController.byId(StableIdHelper.getStableId({type: "ListReportPage", subType: "DynamicPage"}));
-		// TODO: Discuss: should this state (header pinned) be part of variant (only page variant or SFB variant)? Assumption: no
-		var oDynamicPageWrapper = oTemplateUtils.oCommonUtils.getControlStateWrapper(oDynamicPage);
-		aControlStateWrappers.push(oDynamicPageWrapper);
-
 		// SmartVariantManagement state: Selected Variant and whether it's dirty, including wrappers for managed controls (all controls, for which the corresponding state
 		// information should be part of the variant)
 		// Due to direct connection between SVM and SFB, also their wrappers need to each other directly. Remarks:
@@ -225,13 +219,19 @@ sap.ui.define([
 		if (oSmartVariantManagement){
 			var oSmartVariantManagementWrapper = oTemplateUtils.oCommonUtils.getControlStateWrapper(oSmartVariantManagement, {
 				managedControlWrappers: aPageVariantControlStateWrappers.concat([oSmartFilterBarWrapper]),
-				dynamicPageWrapper: oDynamicPageWrapper
+				smartFilterBarWrapper: oSmartFilterBarWrapper
 			});
 			aControlStateWrappers.push(oSmartVariantManagementWrapper);
 		} else {
 			aControlStateWrappers.push(oSmartFilterBarWrapper);
 		}
 
+		// DynamicPage state: header pinned
+		var oDynamicPage = oController.byId(StableIdHelper.getStableId({type: "ListReportPage", subType: "DynamicPage"}));
+		// The DynamicPage state (header pinned) is intentionally stored only in iAppState and not included in any variant (neither page variant nor SFB variant).
+		var oDynamicPageWrapper = oTemplateUtils.oCommonUtils.getControlStateWrapper(oDynamicPage);
+		aControlStateWrappers.push(oDynamicPageWrapper);
+
 
 		// Wrapper to control whether data is loaded
 
@@ -768,7 +768,8 @@ sap.ui.define([
 				// For desktop devices, expand the header for Standard and Custom variants and for tablet and mobile devices,
 				// collapse the header only if search is triggered.
 				if (Device.system.desktop) {
-					oTemplateUtils.oCommonUtils.getControlStateWrapper(oController.byId(StableIdHelper.getStableId({type: "ListReportPage", subType: "DynamicPage"}))).setHeaderState(oController, true);
+					var oTemplatePrivateModel = oTemplateUtils.oComponentUtils.getTemplatePrivateModel();
+					oTemplatePrivateModel.setProperty("/listReport/isHeaderExpanded", true);
 				} else {
 					collapseHeader();
 				}
@@ -887,6 +888,15 @@ sap.ui.define([
 			// regarding a), while SFB takes care to set the data for standard filters (created via annotation), for others (extension filters, edit state filter, anything else that
 			// should be controlled by VM (currently anything else we add to iAppState, but maybe that's only correct in case of page variant management)) we have to set it
 			// (independent of the context).
+			// Restore header collapse logic (originally removed in change 5641712)
+			// Collapse header when user manually selects a variant (context === undefined) that has executeOnSelect set to true
+			var oContext = oEvent.getParameter("context");
+			var bExecuteOnSelect = oEvent.getParameter("executeOnSelect");
+
+			if (oContext === undefined && bExecuteOnSelect) {
+				collapseHeader();
+			}
+
 			fnRestoreExtendedFilterDataOnAfterSFBVariantLoad(oEvent);
 		}
 

package/src/sap/suite/ui/generic/template/ListReport/manifest.json

@@ -8,7 +8,7 @@
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
 			"__comment": "applicationVersion oder componentversion??",
-			"version": "1.120.41"
+			"version": "1.120.42"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/ListReport/view/fragments/SmartChart.fragment.xml

@@ -8,7 +8,8 @@
 
 	<template:with path="entityType>com.sap.vocabularies.UI.v1.HeaderInfo" var="header">
 		<smartChart:SmartChart
-			id="listReport{= ${parameter>/settings/quickVariantSelectionX} ? ${path: 'tabItem>', formatter: 'AH.getSuffixFromIconTabFilterKey'} : ''}" 
+			id="listReport{= ${parameter>/settings/quickVariantSelectionX} ? ${path: 'tabItem>', formatter: 'AH.getSuffixFromIconTabFilterKey'} : ''}"
+			afterVariantInitialise="._templateEventHandlers.onAfterVariantInitialise"
 			visible="{path: 'tabItem>', formatter: 'AHMultipleViews.getVisibleForTableTabs'}"
 			smartFilterId=""
 			persistencyKey="listReportChart{= ${parameter>/settings/quickVariantSelectionX} ? ${path: 'tabItem>', formatter: 'AH.getSuffixFromIconTabFilterKey'} : ''}"

package/src/sap/suite/ui/generic/template/ListReport/view/fragments/SmartTable.fragment.xml

@@ -13,6 +13,7 @@
 				<template:with path="parameter>/" helper="sap.suite.ui.generic.template.js.StableIdHelper.preparePathForStableId" var="smartControlId">
 					<template:if test="{= ${smartControlId>}.buildStableId({type: 'ListReportTable', subType: 'SmartTable', sQuickVariantKey: ${tabItem>key}})}" />
 					<smarttable:SmartTable id="{smartControlId>id}"
+						afterVariantInitialise="._templateEventHandlers.onAfterVariantInitialise"
 						smartFilterId="{= ${parameter>/settings/quickVariantSelectionX} ? '' : 'listReportFilter'}"
 						visible="{path: 'tabItem>', formatter: 'AHMultipleViews.getVisibleForTableTabs'}"
 						initialise="._templateEventHandlers.onTableInit"
@@ -122,7 +123,7 @@
 									visibleRowCountMode="Auto"
 									showOverlay="{= ${_templPriv>/listReport/firstSelection} &amp;&amp; !${_templPriv>/generic/bDataAreShownInTable}}"
 									class="{path: 'parameter>/settings/condensedTableLayout', formatter: 'AHListReport.setSizeCondensedCssClass'}"
-									expandFirstLevel="true" 
+									expandFirstLevel="true"
 									rowSelectionChange="._templateEventHandlers.onSelectionChange"
 									rowActionCount="{parts: [{path: 'entitySet>'}, {path: 'parameter>/settings/subPages/'}, {path: 'parameter>/manifest/'}, {path: 'parameter>/settings/'}], formatter: 'AH.getRowActionCountForListReport'}">
 									<template:with path="entitySet>" var="listEntitySet">
@@ -178,7 +179,7 @@
 							<template:else >
 								<Table id="{:= ${parameter>/stableId}.getStableId({type: 'ListReportTable', subType: 'ResponsiveTable', sQuickVariantKey: ${tabItem>key}})}"
 									showOverlay="{= ${_templPriv>/listReport/firstSelection} &amp;&amp; !${_templPriv>/generic/bDataAreShownInTable}}"
-									fixedLayout="{= ${appSettings>/enableAutoColumnWidthForSmartTable} ? undefined : !!${parameter>/settings/isWorklist} }" 
+									fixedLayout="{= ${appSettings>/enableAutoColumnWidthForSmartTable} ? undefined : !!${parameter>/settings/isWorklist} }"
 									growing="true" growingScrollToLoad="true"
 									sticky="ColumnHeaders,HeaderToolbar"
 									mode="{tableSettings>mode}"

package/src/sap/suite/ui/generic/template/ObjectPage/controller/ControllerImplementation.js

@@ -2220,6 +2220,13 @@ sap.ui.define([
 				//                           and register for all relevant updates on that context so that we call the same function with
 				// 2. !bFirstTimeForContext = adapt to the change
 				var fnExecuteDynamicColumnHide = function (bFirstTimeForContext, oSmartTableInfoObject) {
+					if (!bFirstTimeForContext && !oContext.getObject(oContext.getPath())) {
+						// In case then method is trigged by property change
+						// and there is no data in model for current context path -> we don't trigger column visibility recalculation
+						// As object data are missing, it's meaningless. But in some cases can break application navigation.
+						// Table columns visibility change -> which will trigger save app state -> which will modify URL
+						return;
+					}
 					var aHiddenColumnInfo = oSmartTableInfoObject.getHiddenColumnInfo();
 
 					// if columns are hidden only statically, no need to refresh hiding here
@@ -2463,7 +2470,10 @@ sap.ui.define([
 					}
 				},
 				handlers: {
-					onEditAndActiveToggle: function () {
+					onAfterVariantInitialise: function(oEvent) {
+						oTemplateUtils.oCommonUtils.getControlStateWrapper(oEvent.getSource()).onAfterVariantInitialise();
+					},
+					onEditAndActiveToggle: function () { // Implementation of draft toggle for static header
 						var oUIModel = oObjectPage.getModel("ui");
 						var bIsEditable = oUIModel.getProperty("/editable");
 						oTemplateUtils.oServices.oApplicationController.synchronizeDraftAsync().then(function() {
@@ -2946,4 +2956,4 @@ sap.ui.define([
 		}
 	};
 	return oMethods;
-});
+});

package/src/sap/suite/ui/generic/template/ObjectPage/controller/RelatedAppsHandler.js

@@ -83,51 +83,47 @@ sap.ui.define([
 							fnReject();
 							return;
 						}
+
+						var oAppComponent = oController.getOwnerComponent().getAppComponent();
+						// Preparing the array of semantic objects to fetch links.
+						// Initialize the array with the current app's semantic object.
+						var aSemanticObjects = [sCurrentSemObj];
+
 						//Get all semantic object from manifest setting
 						var oSettings = oTemplateUtils.oComponentUtils.getSettings();
 						var oRelatedAppsSettings = oSettings.relatedAppsSettings;
-
-						var oLinksDeferred;
 						var bHasRelatedAppSettings = oRelatedAppsSettings && Object.keys(oRelatedAppsSettings).length > 0;
-					
-						if (bHasRelatedAppSettings) {
-							const oSemanticObjectSet = new Set();
-						   // Add the current semantic object into the set
-							oSemanticObjectSet.add(sCurrentSemObj);
 
+						if (bHasRelatedAppSettings) {
 							// Iterate through oRelatedAppSettings and add all related apps into the set
 							for (const sKey in oRelatedAppsSettings) {
-								if (sKey && oRelatedAppsSettings.hasOwnProperty(sKey)) {
+								if (oRelatedAppsSettings.hasOwnProperty(sKey)) {
 									const sSemanticObject = oRelatedAppsSettings[sKey].semanticObject;
-									oSemanticObjectSet.add(sSemanticObject); // Set will handle duplicates
+									aSemanticObjects.push(sSemanticObject);
 								}
 							}
-							// Create an array from the set
-							let aSemanticObjects = Array.from(oSemanticObjectSet);
-
-							// Use the map method to convert the array of strings into an array of objects
-							aSemanticObjects = aSemanticObjects.map(sSemObj => ([{ semanticObject: sSemObj }]));
-
-							// aSemanticObjects now contains the desired format
-							oLinksDeferred = oXApplNavigation.getLinks(aSemanticObjects);
-						} else {
-							var oAppComponent = oController.getOwnerComponent().getAppComponent();
-							oLinksDeferred = oXApplNavigation.getLinks({
-								semanticObject: sCurrentSemObj,
+						}
+						// Remove duplicates
+						aSemanticObjects = Array.from(new Set(aSemanticObjects));
+						// Add parameters to semantic objects
+						var aSemanticObjectsWithParams = aSemanticObjects.map(sSemanticObject => {
+							return [{
+								semanticObject: sSemanticObject,
 								params: oParam,
 								ui5Component: oAppComponent
-							});
-						}
-						oLinksDeferred.done(function (aLinks) {
+							}];
+						});
+
+						oXApplNavigation.getLinks(aSemanticObjectsWithParams).done(function (aResult) {
+							// Convert the response into a single dimension array by flattening it
+							var aLinks = aResult.flat(Infinity);
+							// Get structured links
 							var aSemObjWithLink = [];
-							var fnAddLink = function(oLinkDef){
+							var fnAddLink = function (oLinkDef) {
 								var oLink = getStructuredSemanticObjectActionLinks(oLinkDef);
-								aSemObjWithLink.push(oLink);								
+								aSemObjWithLink.push(oLink);
 							};
-							aLinks.forEach(bHasRelatedAppSettings ? function(aLinks){
-								aLinks[0].forEach(fnAddLink);
-							} : fnAddLink);
-
+							aLinks.forEach(fnAddLink);
 							//Get All Semantic Object Unavailable action
 							var getStringProperty = function (oAction) {
 								return oAction.String;
@@ -194,8 +190,7 @@ sap.ui.define([
 							oButtonsModel.setProperty("/buttons", aButtons);
 							fnResolve();
 							oBusyHelper.getUnbusy().then(oActionSheet.openBy.bind(oActionSheet, oButton));
-						});
-						oLinksDeferred.fail(fnReject);
+						}).fail(fnReject);
 					}, fnReject);
 				});
 				oBusyHelper.setBusy(oOpenPromise);

package/src/sap/suite/ui/generic/template/ObjectPage/i18n/i18n_cnr.properties

@@ -19,7 +19,7 @@ SAVE=Sa\u010Duvaj
 
 SAVE_AND_EDIT=Sa\u010Duvaj i uredi
 
-SAVE_AND_NEXT=Sa\u010Duvaj i sljede\u0107e
+SAVE_AND_NEXT=Sa\u010Duvaj i idi na sljede\u0107e
 
 VALIDATE_DRAFT=Validiraj
 

package/src/sap/suite/ui/generic/template/ObjectPage/i18n/i18n_mk.properties

@@ -19,7 +19,7 @@ SAVE=\u0417\u0430\u0447\u0443\u0432\u0430\u0458
 
 SAVE_AND_EDIT=\u0417\u0430\u0447\u0443\u0432\u0430\u0458 \u0438 \u0443\u0440\u0435\u0434\u0438
 
-SAVE_AND_NEXT=\u0417\u0430\u0447\u0443\u0432\u0430\u0458 \u0438 \u0441\u043B\u0435\u0434\u043D\u043E
+SAVE_AND_NEXT=\u0417\u0430\u0447\u0443\u0432\u0430\u0458 \u0438 \u043E\u0434\u0438 \u0441\u043B\u0435\u0434\u043D\u043E
 
 VALIDATE_DRAFT=\u041F\u043E\u0442\u0432\u0440\u0434\u0438
 

package/src/sap/suite/ui/generic/template/ObjectPage/i18n/i18n_sh.properties

@@ -19,7 +19,7 @@ SAVE=Sa\u010Duvaj
 
 SAVE_AND_EDIT=Sa\u010Duvaj i uredi
 
-SAVE_AND_NEXT=Sa\u010Duvaj i slede\u0107e
+SAVE_AND_NEXT=Sa\u010Duvaj i idi na slede\u0107e
 
 VALIDATE_DRAFT=Validiraj
 

package/src/sap/suite/ui/generic/template/ObjectPage/i18n/i18n_sl.properties

@@ -5,7 +5,7 @@ DESCRIPTION=Stran objekta
 
 EDIT=Obdelava
 
-CREATE_OBJECT=Ustvari
+CREATE_OBJECT=Kreiraj
 
 DISPLAY_ACTIVE_VERSION=Prikaz shranjene verzije
 
@@ -23,7 +23,7 @@ SAVE_AND_NEXT=Shrani in naprej
 
 VALIDATE_DRAFT=Validacija
 
-CREATE=Ustvari
+CREATE=Kreiraj
 
 CLOSE=Zapiranje
 
@@ -33,7 +33,7 @@ ADD=Dodajanje
 
 SEG_BUTTON_TEXT={0} ({1})
 
-CREATE_DRAFT_MESSAGE_TEXT=Ustvarite objekt.
+CREATE_DRAFT_MESSAGE_TEXT=Kreirajte objekt.
 
 SAVE_DRAFT_MESSAGE_TEXT=Uporabite spremembe za shranjeno verzijo.
 

package/src/sap/suite/ui/generic/template/ObjectPage/i18n/i18n_sr.properties

@@ -19,7 +19,7 @@ SAVE=\u0421\u0430\u0447\u0443\u0432\u0430\u0458
 
 SAVE_AND_EDIT=\u0421\u0430\u0447\u0443\u0432\u0430\u0458 \u0438 \u0443\u0440\u0435\u0434\u0438
 
-SAVE_AND_NEXT=\u0421\u0430\u0447\u0443\u0432\u0430\u0458 \u0438 \u0441\u043B\u0435\u0434\u0435\u045B\u0435
+SAVE_AND_NEXT=\u0421\u0430\u0447\u0443\u0432\u0430\u0458 \u0438 \u0438\u0434\u0438 \u043D\u0430 \u0441\u043B\u0435\u0434\u0435\u045B\u0435
 
 VALIDATE_DRAFT=\u0412\u0430\u043B\u0438\u0434\u0438\u0440\u0430\u0458
 

package/src/sap/suite/ui/generic/template/ObjectPage/manifest.json

@@ -6,7 +6,7 @@
 		"type": "component",
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
-			"version": "1.120.41"
+			"version": "1.120.42"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/ObjectPage/view/fragments/SmartChart.fragment.xml

@@ -11,6 +11,7 @@
 					<template:if test="{:= ${smartChartId>}.set(AH.getStableIdPartFromFacet(${facet>}) + '::Chart') }"/>
 					<smartChart:SmartChart
 						id="{smartChartId>value}"
+						afterVariantInitialise="._templateEventHandlers.onAfterVariantInitialise"
 						header="{chartAnnotation>Title/String}"
 						initialized="._templateEventHandlers.onChartInit"
 						requestAtLeastFields="{parts: [{path: 'chartAnnotation>'}, {path: 'entitySet>entityType'}], formatter: 'AH.getApplicablePathForChartToolbarActions'}"

package/src/sap/suite/ui/generic/template/ObjectPage/view/fragments/SmartTable.fragment.xml

@@ -15,6 +15,7 @@
 								<template:if test="{= ${facetId>}.buildStableId({type: 'ObjectPage', subType: 'Facet', sRecordType: ${facet>RecordType}, sAnnotationPath: ${facet>Target/AnnotationPath}, sAnnotationId: ${facet>ID/String}, bIsHeaderFacet: ${isHeaderFacet>value}})}"/>
 								<template:if test="{= ${smartControlId>}.buildStableId({type: 'ObjectPageTable', subType: 'SmartTable', sFacet: ${facetId>id}})}" />
 								<st:SmartTable id="{smartControlId>id}"
+									afterVariantInitialise="._templateEventHandlers.onAfterVariantInitialise"
 									initialise="._templateEventHandlers.onTableInit($event, '{facetId>id}')"
 									persistencyKey="{parts: [{path: 'smartControlId>id'}, {path: 'objectPageTableSettings>value/persistencyKeyState'}], formatter: 'AH.getPersistencyKey'}"
 									tableBindingPath="{= ${path: 'target>AnnotationPath'}.slice(0, ${path: 'target>AnnotationPath'}.lastIndexOf('/')) }"

package/src/sap/suite/ui/generic/template/QuickCreate/manifest.json

@@ -6,7 +6,7 @@
 		"type": "component",
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
-			"version": "1.120.41"
+			"version": "1.120.42"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/QuickView/manifest.json

@@ -6,7 +6,7 @@
 	"type": "component",
 	"i18n": "i18n/i18n.properties",
 	"applicationVersion": {
-		"version": "1.120.41"
+		"version": "1.120.42"
 	},
 	"title": "{{TITLE}}",
 	"description": "{{DESCRIPTION}}",