@sapui5/sap.suite.ui.generic.template 1.114.1 → 1.114.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@sapui5/sap.suite.ui.generic.template",
-  "version": "1.114.1",
+  "version": "1.114.3",
   "description": "SAPUI5 Library sap.suite.ui.generic.template",
   "keywords": [
     "sapui5",

package/src/sap/suite/ui/generic/template/.library

@@ -7,7 +7,7 @@
 
 		(c) Copyright 2009-2015 SAP SE. All rights reserved
 	</copyright>
-	<version>1.114.1</version>
+	<version>1.114.3</version>
 
 	<documentation>Library with generic Suite UI templates.</documentation>
 

package/src/sap/suite/ui/generic/template/AnalyticalListPage/manifest.json

@@ -8,7 +8,7 @@
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
 			"__comment": "applicationVersion oder componentversion??",
-			"version": "1.114.1"
+			"version": "1.114.3"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/Canvas/manifest.json

@@ -8,7 +8,7 @@
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
 			"__comment": "applicationVersion oder componentversion??",
-			"version": "1.114.1"
+			"version": "1.114.3"
 		},
 		"title": "Canvas",
 		"description": "Canvas Page",

package/src/sap/suite/ui/generic/template/ListReport/manifest.json

@@ -8,7 +8,7 @@
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
 			"__comment": "applicationVersion oder componentversion??",
-			"version": "1.114.1"
+			"version": "1.114.3"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/ObjectPage/controller/ControllerImplementation.js

@@ -226,19 +226,22 @@ sap.ui.define([
 				oTemplateUtils.oCommonEventHandlers.submitChangesForSmartMultiInput();
 				var oSaveEntityPromise = oTemplateUtils.oServices.oCRUDManager.saveEntity(); // This Promise may include a dialog step (warning scenario) -> do not use it for busy handling
 				var bSuccess = false; // will be set before the busy session ends
-				oSaveEntityPromise.then(function (oContext) {
-					if (!bStayInEdit) {
-						var oTemplatePrivateModel = oTemplateUtils.oComponentUtils.getTemplatePrivateModel();
-						//	switch to display mode
-						oTemplatePrivateModel.setProperty("/objectPage/displayMode", 1);
-						fnReturnToDisplayNonDraft();
-						oViewProxy.setEditable(false);
-					}
-					performAfterSaveOperations(oContext, oView, bIsComponentDirty, mPendingChangesToContextInfo, bStayInEdit, bEditNextObject);
-					bSuccess =  true;
-				}, function(){
-					oTemplateUtils.oInfoObjectHandler.executeForAllInformationObjects("smartTable", function(oInfoObject){
-						oInfoObject.onSaveWithError();
+				var oSideEffectsExecutedPromise = new Promise(function(fnSideEffectsExecuted, fnSideEffectsRejected){
+					oSaveEntityPromise.then(function (oContext) {
+						if (!bStayInEdit) {
+							var oTemplatePrivateModel = oTemplateUtils.oComponentUtils.getTemplatePrivateModel();
+							//	switch to display mode
+							oTemplatePrivateModel.setProperty("/objectPage/displayMode", 1);
+							fnReturnToDisplayNonDraft();
+							oViewProxy.setEditable(false);
+						}
+						performAfterSaveOperations(oContext, oView, bIsComponentDirty, mPendingChangesToContextInfo, bStayInEdit, bEditNextObject, fnSideEffectsExecuted, fnSideEffectsRejected);
+						bSuccess =  true;
+					}, function(){
+						oTemplateUtils.oInfoObjectHandler.executeForAllInformationObjects("smartTable", function(oInfoObject){
+							oInfoObject.onSaveWithError();
+						});
+						fnSideEffectsRejected();
 					});
 				});
 				// Define a function that is called after the end of the busy session to set the focus. It can rely on bSuccess
@@ -249,13 +252,14 @@ sap.ui.define([
 				};
 				oTemplateUtils.oServices.oApplication.setNextFocus(fnSetFocusAfterwards);
 				var oEvent = {
-					saveEntityPromise: oSaveEntityPromise
+					saveEntityPromise: oSaveEntityPromise,
+					sideEffectsExecutedPromise: oSideEffectsExecutedPromise
 				};
 				oTemplateUtils.oComponentUtils.fire(oController, "AfterSave", oEvent);
 			}
 
 			//common flow for Save and Save-continue Edit (Non draft)
-			function performAfterSaveOperations(oContext, oView, bSomethingWasChanged, mPendingChangesToContextInfo, bStayInEdit, bEditNextObject) {
+			function performAfterSaveOperations(oContext, oView, bSomethingWasChanged, mPendingChangesToContextInfo, bStayInEdit, bEditNextObject, fnSideEffectsExecuted, fnSideEffectsRejected) {
 				var oUIModel = oObjectPage.getModel("ui");
 				var bCreateMode = oUIModel.getProperty("/createMode");
 				var oComponent = oController.getOwnerComponent();
@@ -285,7 +289,7 @@ sap.ui.define([
 					sSuccessMessageKey = bSomethingWasChanged ? "OBJECT_SAVED" : "OBJECT_NOT_MODIFIED";
 				}
 				MessageUtils.showSuccessMessageIfRequired(oTemplateUtils.oCommonUtils.getText(sSuccessMessageKey), oTemplateUtils.oServices);
-
+				var aSideEffectPromises = [];
 				for (var sProperty in mPendingChangesToContextInfo) {
 					var oInfo = mPendingChangesToContextInfo[sProperty];
 					var oCurrentContext = oInfo.context;
@@ -300,8 +304,12 @@ sap.ui.define([
 					if (iMetaDataIndex > -1) {
 						aSourceProperties.splice(iMetaDataIndex, 1);
 					}
-					oTemplateUtils.oServices.oApplicationController.executeSideEffects(oCurrentContext, aSourceProperties);
+					var oSideEffectForPropertyPromise = oTemplateUtils.oServices.oApplicationController.executeSideEffects(oCurrentContext, aSourceProperties);
+					aSideEffectPromises.push(oSideEffectForPropertyPromise);
 				}
+				Promise.allSettled(aSideEffectPromises).then(function(){
+					fnSideEffectsExecuted(); // do not expose the arguments passed to the members of aSideEffectPromises to the outside
+				});
 			}
 
 			function onSaveAndContinueEdit(oEvent) {
@@ -2339,31 +2347,27 @@ sap.ui.define([
 							oTemplateUtils.oCommonEventHandlers.submitChangesForSmartMultiInput(oEvent);
 						}
 					},
-					
-					contextEditableChanged: function (oEvent) {
+					onModeToggled: function (oEvent) {
 						/* Set the FieldGroupIds of the SmartField(s) which are 1:1 associated with the object page entity set so that side effect annotation targeting
 						   the object entity set would work. Assigning FieldGroupIds to other SmartFields is already taken care by the SmartFields  */
-						if (oEvent.getParameter("editable")) {
-							var oSmartField = oEvent.getSource();
-							oSmartField._getComputedMetadata().then(function (oComputedMetaData) {
-								if (oComputedMetaData && oComputedMetaData.navigationPath && !!oSmartField.getBindingContext()) {
-									var oClonedMetaData = deepExtend({}, oComputedMetaData);
-									var oMetaModel = oController.getOwnerComponent().getModel().getMetaModel();
-
-									/* EntitySet and EntityType of the cloned metamodel of smartfield needs to be changed to the parent entity so that when
-									   _calculateFieldGroupIDs looks through the passed metamodel, it should be able to find the corresponding side effect annotation */
-									oClonedMetaData.entitySet = oMetaModel.getODataEntitySet(oController.getOwnerComponent().getEntitySet());
-									oClonedMetaData.entityType = oMetaModel.getODataEntityType(oClonedMetaData.entitySet.entityType);
-
-									var aIDs = oSmartField._calculateFieldGroupIDs(oClonedMetaData);
-									if (aIDs) {
-										oSmartField._setInternalFieldGroupIds(aIDs);
-									}
+						var oSmartField = oEvent.getSource();
+						oSmartField._getComputedMetadata().then(function (oComputedMetaData) {
+							if (oComputedMetaData && oComputedMetaData.navigationPath && !!oSmartField.getBindingContext()) {
+								var oClonedMetaData = deepExtend({}, oComputedMetaData);
+								var oMetaModel = oController.getOwnerComponent().getModel().getMetaModel();
+
+								/* EntitySet and EntityType of the cloned metamodel of smartfield needs to be changed to the parent entity so that when
+									_calculateFieldGroupIDs looks through the passed metamodel, it should be able to find the corresponding side effect annotation */
+								oClonedMetaData.entitySet = oMetaModel.getODataEntitySet(oController.getOwnerComponent().getEntitySet());
+								oClonedMetaData.entityType = oMetaModel.getODataEntityType(oClonedMetaData.entitySet.entityType);
+
+								var aIDs = oSmartField._calculateFieldGroupIDs(oClonedMetaData);
+								if (aIDs) {
+									oSmartField._setInternalFieldGroupIds(aIDs);
 								}
-							});
-						}
+							}
+						});
 					},
-
 					deleteEntry: function (oEvent) {
 						var oListItem = oEvent.getParameter("listItem");
 						var oListItemContext = oListItem.getBindingContext();

package/src/sap/suite/ui/generic/template/ObjectPage/extensionAPI/NonDraftTransactionController.js

@@ -15,6 +15,12 @@ sap.ui.define(["sap/ui/base/Object", "sap/base/util/extend"], function(BaseObjec
 			 * Attach a handler to the save event
 			 *
 			 * @param {function} fnFunction the handler function
+			 * This function will receive an object which contains two properties: <code>saveEntityPromise</code> and <code>sideEffectsExecutedPromise</code> which both point to Promises.
+			 * Both Promises will be rejected in case the save operation fails in the backend.
+			 * Otherwise both Promises will be resolved, but at different point in time.
+			 * The <code>saveEntityPromise</code> will be resolved immediately when the save operation has finished successfully.
+			 * The <code>sideEffectsExecutedPromise</code> will be resolved as soon as the processing of all side-effects connected to this action has finished as well.
+			 * Note that even a side-effect execution which results in an error would be considered as finished processing here.
 			 * @public
 			 */
 			attachAfterSave: function(fnFunction) {

package/src/sap/suite/ui/generic/template/ObjectPage/manifest.json

@@ -6,7 +6,7 @@
 		"type": "component",
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
-			"version": "1.114.1"
+			"version": "1.114.3"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/QuickCreate/manifest.json

@@ -6,7 +6,7 @@
 		"type": "component",
 		"i18n": "i18n/i18n.properties",
 		"applicationVersion": {
-			"version": "1.114.1"
+			"version": "1.114.3"
 		},
 		"title": "{{TITLE}}",
 		"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/QuickView/manifest.json

@@ -6,7 +6,7 @@
 	"type": "component",
 	"i18n": "i18n/i18n.properties",
 	"applicationVersion": {
-		"version": "1.114.1"
+		"version": "1.114.3"
 	},
 	"title": "{{TITLE}}",
 	"description": "{{DESCRIPTION}}",

package/src/sap/suite/ui/generic/template/designtime/ListReport.designtime.js

@@ -134,7 +134,7 @@ sap.ui.define(["sap/suite/ui/generic/template/designtime/utils/designtimeHelper"
 					actions: ["rename", "remove", "reveal"]
 				},
 				"sap.m.MenuButton": { // used for create and create with filters and possibly created by combining of buttons
-					actions: ["split", "rename"]
+					actions: ["split", "rename", "remove"]
 				},	
 				"sap.m.Button": {
 					actions: ["remove", "reveal", "rename"]

package/src/sap/suite/ui/generic/template/fragments/SmartFormDataField.fragment.xml

@@ -60,7 +60,7 @@
                             <template:repeat list="{connectedFields>Data}" var="connectedFieldElement">
                                 <sfi:SmartField clientSideMandatoryCheck="false"
                                     fetchValueListReadOnly="{parts:[{path: 'parameter>/entityType'},{path: 'connectedFieldElement>'}], formatter: 'AH.getValueListReadOnly'}"
-                                    contextEditableChanged="._templateEventHandlers.contextEditableChanged"
+									modeToggled="._templateEventHandlers.onModeToggled"
 									value="{path: 'connectedFieldElement>Value', formatter: 'AHModel.simplePath'}"
 									changeModelValue="._templateEventHandlers.onSmartFieldModelValueChanged">
 									<sfi:customData>
@@ -166,7 +166,7 @@
 											clientSideMandatoryCheck="false"
 											textLabel="{path: 'dataField>', formatter: 'AH.getDataFieldLabel'}"
 											fetchValueListReadOnly="{parts:[{path: 'parameter>/entityType'},{path: 'dataField>'}], formatter: 'AH.getValueListReadOnly'}"
-											contextEditableChanged="._templateEventHandlers.contextEditableChanged"
+											modeToggled="._templateEventHandlers.onModeToggled"
 											changeModelValue="._templateEventHandlers.onSmartFieldModelValueChanged">
 											<sfi:customData>
 												<core:CustomData key="defaultTextInEditModeSource" value="{path: 'dataFieldValue>', formatter: 'AH.setValidationForValueList'}" />
@@ -199,7 +199,7 @@
 											clientSideMandatoryCheck="false"
 											tokenUpdate="._templateEventHandlers.submitChangesForSmartMultiInput"
 											selectionFinish="._templateEventHandlers.submitChangesForSmartMultiInput"
-											contextEditableChanged="._templateEventHandlers.contextEditableChanged"
+											modeToggled="._templateEventHandlers.onModeToggled"
 											value="{path: 'dataField>Value', formatter: 'AHModel.simplePath'}"
 											textLabel="{path: 'dataField>', formatter: 'AH.getDataFieldLabel'}"
 											fetchValueListReadOnly="false"/>

package/src/sap/suite/ui/generic/template/lib/AppComponent.js

@@ -852,7 +852,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.UIComponent
 	 * @abstract
 	 * @author SAP SE
-	 * @version 1.114.1
+	 * @version 1.114.3
 	 * @name sap.suite.ui.generic.template.lib.AppComponent
 	 */
 	return UIComponent.extend("sap.suite.ui.generic.template.lib.AppComponent", {

package/src/sap/suite/ui/generic/template/lib/navigation/NavigationController.js

@@ -2996,7 +2996,7 @@ sap.ui.define(["sap/ui/base/Object",
 	 * @param {sap.suite.ui.generic.template.lib.AppComponent} oAppComponent The AppComponent instance
 	 * @public
 	 * @extends sap.ui.base.Object
-	 * @version 1.114.1
+	 * @version 1.114.3
 	 * @since 1.30.0
 	 * @alias sap.suite.ui.generic.template.lib.NavigationController
 	 */

package/src/sap/suite/ui/generic/template/lib/presentationControl/SmartTableHandler.js

@@ -67,8 +67,8 @@ sap.ui.define([
 				}
 				return aRet;
 			}
-			// possibly a bug in the UI5 framework itself .. getCurrentContexts() for UITable only returns the contexts of selected rows in the table
-			return bIsUiTable ? oListBinding.getContexts() : oListBinding.getCurrentContexts();
+			
+			return oListBinding.getAllCurrentContexts();
         }
 
 		function fnGetModel() {

package/src/sap/suite/ui/generic/template/library.js

@@ -38,7 +38,7 @@ sap.ui.define(['sap/ui/core/Core', 'sap/ui/core/library','sap/fe/placeholder/lib
 		interfaces: [],
 		controls: [],
 		elements: [],
-		version: "1.114.1",
+		version: "1.114.3",
 		extensions: {
 			//Configuration used for rule loading of Support Assistant
 			"sap.ui.support": {