@sapui5/sap.suite.ui.commons 1.141.0 → 1.142.1

package/src/sap/suite/ui/commons/networkgraph/util/DragDropManager.js

@@ -0,0 +1,197 @@
+/*!
+ * 
+		SAP UI development toolkit for HTML5 (SAPUI5)
+		(c) Copyright 2009-2015 SAP SE. All rights reserved
+	
+ */
+sap.ui.define([
+	"sap/ui/core/dnd/DragInfo",
+	"sap/ui/core/dnd/DropInfo",
+	"sap/base/Log"
+], function (DragInfo, DropInfo, Log) {
+	"use strict";
+
+	// Instance object: Only one will exist
+	var instance = null;
+	var sDragSessionKey = "networkGraphDragSession";
+
+	/**
+	 * Constructor for DragDropManager.
+	 * This class is for internal use only
+	 *
+	 * @class
+	 * Manages drag and drop functionality for network graph components.
+	 * This class handles drag start, drag end, drag over, and drop events
+	 * for both Graph and Node controls in the network graph library.
+	 *
+	 * @private
+	 */
+	function DragDropManager() { }
+
+	/**
+	 * Validates if the given control is supported for drag and drop operations.
+	 *
+	 * @param oControl - The control to validate
+	 * @returns {boolean} True if the control is eligible for drag and drop, otherwise false
+	 * @private
+	 */
+	DragDropManager.prototype.isValidControl = function (oControl) {
+		if (!oControl || typeof oControl !== 'object') {
+			return false;
+		}
+
+		// Check if it's an empty object
+		if (Object.keys(oControl).length === 0 && oControl.constructor === Object) {
+			return false;
+		}
+
+		// Check if it has the required isA method
+		if (typeof oControl.isA !== 'function') {
+			return false;
+		}
+
+		return oControl.isA("sap.suite.ui.commons.networkgraph.Graph") ||
+			oControl.isA("sap.suite.ui.commons.networkgraph.Node");
+	}
+
+	/**
+	 * Handles the drag start event for nodes.
+	 *
+	 * @param {sap.ui.base.Event} oEvent - The drag start event handler
+	 * @private
+	 */
+	DragDropManager.prototype._handleDragStart = function (oEvent) {
+		let dragSession = oEvent.getParameter("dragSession");
+		let browserEvent = oEvent.getParameter("browserEvent");
+		dragSession.setComplexData(sDragSessionKey, {
+			cursorX: browserEvent.clientX,
+			cursorY: browserEvent.clientY
+		});
+	}
+
+	/**
+	 * Handles the drag end event for nodes.
+	 *
+	 * @param {sap.ui.base.Event} oEvent - The drag End event handler
+	 * @private
+	 */
+	DragDropManager.prototype._handleDragEnd = function (oEvent) {
+
+		let oBrowserEvent = oEvent.getParameter("browserEvent");
+
+		if (!oBrowserEvent) {
+			Log.warn("No native browser event available in drag end event.");
+			return;
+		}
+	};
+
+	/**
+	 * Handles the drag over event for nodes.
+	 *
+	 * @param {sap.ui.base.Event} oEvent - The drag over event handler
+	 * @private
+	 */
+	DragDropManager.prototype._handleDragOver = function (oEvent) {
+		// Optional: Implement visual feedback  of drag ghost for Lasso selection
+		let oBrowserEvent = oEvent.getParameter("browserEvent");
+
+		if (!oBrowserEvent) {
+			Log.warn("No native browser event available in drag over event.");
+			return;
+		}
+	};
+
+	/**
+	 * Handles the drop event.
+	 *
+	 * @param {sap.ui.base.Event} oEvent - The drop event
+	 * @param {sap.suite.ui.commons.networkgraph.Graph} oGraph - The graph control
+	 * @private
+	 */
+	DragDropManager.prototype._handleDrop = function (oEvent, oGraph) {
+		let oBrowserEvent = oEvent.getParameter("browserEvent") || {};
+		let { clientX = 0, clientY = 0 } = oBrowserEvent,
+			oDraggedControl = oEvent.getParameter("draggedControl");
+		if (!oBrowserEvent) {
+			Log.warn("No native browser event available in drop event.");
+			return;
+		}
+
+		if (oEvent.getParameter("draggedControl")?.isA("sap.suite.ui.commons.networkgraph.Node")) {
+			let dragSessionComplexData = oEvent.getParameter("dragSession").getComplexData(sDragSessionKey),
+				deltaX = clientX - (dragSessionComplexData?.cursorX || 0),
+				deltaY = clientY - (dragSessionComplexData?.cursorY || 0);
+
+			oGraph.fireEvent("nodeDropped", {
+				node: oDraggedControl,
+				newX: oDraggedControl.getX() + deltaX,
+				newY: oDraggedControl.getY() + deltaY
+			});
+		} else {
+			let boundingRect = oGraph?._$innerscroller[0]?.getBoundingClientRect() || { left: 0, top: 0 },
+				x = clientX - boundingRect.left,
+				y = clientY - boundingRect.top;
+
+			oGraph.fireEvent("nodeDropped", {
+				...oEvent.getParameters(),
+				node: oDraggedControl,
+				newX: x,
+				newY: y
+			});
+		}
+	};
+
+	// Add drag and drop config if needed
+	DragDropManager.prototype.injectDnD = function (oControl) {
+		if (!this.isValidControl(oControl)) {
+			throw new Error("DragDropManager: Control is not valid for DnD");
+		}
+		var sControlType = oControl.getMetadata().getName();
+		switch (sControlType) {
+			case "sap.suite.ui.commons.networkgraph.Graph":
+				var dragInfo = new DragInfo({
+					sourceAggregation: "nodes",
+					dragEnd: this._handleDragEnd.bind(this)
+				});
+				var dropInfo = new DropInfo({
+					dropPosition: "Between",
+					drop: function (oEvent) {
+						this._handleDrop(oEvent, oControl);
+					}.bind(this),
+					dragOver: this._handleDragOver.bind(this)
+				});
+
+				oControl.addDragDropConfig(dragInfo);
+				oControl.addDragDropConfig(dropInfo);
+				break;
+			case "sap.suite.ui.commons.networkgraph.Node":
+				var dragInfo = new DragInfo({
+					dragStart: this._handleDragStart.bind(this),
+				});
+				oControl.addDragDropConfig(dragInfo);
+				break;
+			default:
+				throw new Error("DragDropManager: Control type " + sControlType + " is not supported");
+		}
+	};
+
+	// Remove DnD config
+	DragDropManager.prototype.removeDnD = function (oControl) {
+		if (!this.isValidControl(oControl)) {
+			throw new Error("DragDropManager: Control is not valid for DnD");
+		}
+		// Check if control has any drag drop configurations
+		if (!oControl.getDragDropConfig || oControl.getDragDropConfig().length === 0) {
+			return true; // Not an error, just nothing to remove
+		}
+
+		oControl?.destroyDragDropConfig();
+	};
+
+	// Exported singleton object - instantiate on first access
+	if (!instance) {
+		instance = new DragDropManager();
+	}
+
+	return instance;
+}, /* bExport= */true);

package/src/sap/suite/ui/commons/statusindicator/Circle.js

@@ -30,7 +30,7 @@ sap.ui.define([
 		 * @extends sap.suite.ui.commons.statusindicator.SimpleShape
 		 *
 		 * @author SAP SE
-		 * @version 1.141.0
+		 * @version 1.142.1
 		 * @since 1.50
 		 *
 		 * @constructor

package/src/sap/suite/ui/commons/statusindicator/CustomShape.js

@@ -36,7 +36,7 @@ sap.ui.define([
 	 * @extends sap.suite.ui.commons.statusindicator.Shape
 	 *
 	 * @author SAP SE
-	 * @version 1.141.0
+	 * @version 1.142.1
 	 * @since 1.50
 	 *
 	 * @constructor

package/src/sap/suite/ui/commons/statusindicator/DiscreteThreshold.js

@@ -21,7 +21,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.141.0
+	 * @version 1.142.1
 	 * @since 1.50
 	 *
 	 * @constructor

package/src/sap/suite/ui/commons/statusindicator/FillingOption.js

@@ -23,7 +23,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.141.0
+	 * @version 1.142.1
 	 * @since 1.50
 	 *
 	 * @constructor

package/src/sap/suite/ui/commons/statusindicator/LibraryShape.js

@@ -23,7 +23,7 @@ sap.ui.define([
 	 * @extends sap.suite.ui.commons.statusindicator.CustomShape
 	 *
 	 * @author SAP SE
-	 * @version 1.141.0
+	 * @version 1.142.1
 	 * @since 1.60.0
 	 *
 	 * @constructor

package/src/sap/suite/ui/commons/statusindicator/Path.js

@@ -29,7 +29,7 @@ sap.ui.define([
 		 * @extends sap.suite.ui.commons.statusindicator.SimpleShape
 		 *
 		 * @author SAP SE
-		 * @version 1.141.0
+		 * @version 1.142.1
 		 * @since 1.50
 		 *
 		 * @constructor

package/src/sap/suite/ui/commons/statusindicator/PropertyThreshold.js

@@ -28,7 +28,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.141.0
+	 * @version 1.142.1
 	 * @since 1.50
 	 *
 	 * @constructor

package/src/sap/suite/ui/commons/statusindicator/Rectangle.js

@@ -29,7 +29,7 @@ sap.ui.define(
 		 * @extends sap.suite.ui.commons.statusindicator.SimpleShape
 		 *
 		 * @author SAP SE
-		 * @version 1.141.0
+		 * @version 1.142.1
 		 * @since 1.50
 		 *
 		 * @constructor

package/src/sap/suite/ui/commons/statusindicator/Shape.js

@@ -42,7 +42,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.141.0
+	 * @version 1.142.1
 	 * @since 1.50
 	 *
 	 * @constructor

package/src/sap/suite/ui/commons/statusindicator/ShapeGroup.js

@@ -30,7 +30,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.141.0
+	 * @version 1.142.1
 	 * @since 1.50
 	 *
 	 * @constructor

package/src/sap/suite/ui/commons/statusindicator/SimpleShape.js

@@ -30,7 +30,7 @@ sap.ui.define([
 	 * @extends sap.suite.ui.commons.statusindicator.Shape
 	 *
 	 * @author SAP SE
-	 * @version 1.141.0
+	 * @version 1.142.1
 	 * @since 1.50
 	 *
 	 * @constructor

package/src/sap/suite/ui/commons/statusindicator/StatusIndicator.js

@@ -49,7 +49,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.141.0
+	 * @version 1.142.1
 	 * @since 1.50
 	 *
 	 * @constructor

package/src/sap/suite/ui/commons/taccount/TAccount.js

@@ -56,7 +56,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.141.0
+	 * @version 1.142.1
 	 * @since 1.58.0
 	 *
 	 * @constructor

package/src/sap/suite/ui/commons/taccount/TAccountGroup.js

@@ -41,7 +41,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.141.0
+	 * @version 1.142.1
 	 * @since 1.58.0
 	 *
 	 * @constructor

package/src/sap/suite/ui/commons/taccount/TAccountItem.js

@@ -41,7 +41,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.141.0
+	 * @version 1.142.1
 	 * @since 1.58.0
 	 *
 	 * @constructor

package/src/sap/suite/ui/commons/taccount/TAccountItemProperty.js

@@ -24,7 +24,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.Control
 	 *
 	 * @author SAP SE
-	 * @version 1.141.0
+	 * @version 1.142.1
 	 * @since 1.58.0
 	 *
 	 * @constructor

package/src/sap/suite/ui/commons/taccount/TAccountPanel.js

@@ -65,7 +65,7 @@ sap.ui.define([
 	 * @extends sap.m.Panel
 	 *
 	 * @author SAP SE
-	 * @version 1.141.0
+	 * @version 1.142.1
 	 * @since 1.58.0
 	 *
 	 * @constructor

package/src/sap/suite/ui/commons/themes/base/CalculationBuilderItem.less

@@ -231,9 +231,17 @@
 
 .sapCalculationBuilderItemExpandButtonFocus {
 	position: absolute;
-	height: 22px;
-	width: 22px;
-	left: 3px;
+	height: 1.375rem;
+	width: 1.375rem;
+	left: 0.188rem;
+	box-sizing: border-box;
+}
+
+.sapUiSizeCozy .sapCalculationBuilderItemExpandButtonFocus {
+	position: absolute;
+	height: 2.25rem;
+	width: 2rem;
+	left: 0.188rem;
 	box-sizing: border-box;
 }
 

package/src/sap/suite/ui/commons/themes/base/CollaborationPopover.less

@@ -137,4 +137,32 @@
 .sapSuiteCollaborationBarMsgStrip {
     background-color: @sapLegendBackgroundColor6 !important;
     border-width: 0px !important;
-}
+}
+
+.sapSuiteCollaborationBarMenu {
+    .sapSuiteUiCommonsCollaborationMail {
+        .sapUiIcon {
+            color: @sapLegendColor6;
+        }
+    }
+
+    .sapSuiteUiCommonsCollaborationMSTeamsShare,
+    .sapSuiteUiCommonsCollaborationChat,
+    .sapSuiteUiCommonsCollaborationTab {
+        .sapUiIcon {
+            color: @sapLegendColor20;
+        }
+    }
+
+    .sapSuiteUiCommonsCollaborationManager {
+        .sapUiIcon {
+            color: @sapLegendColor17;
+        }
+    }
+
+    .sapSuiteUiCommonsCollaborationLink {
+        .sapUiIcon {
+            color: @sapLegendColor18;
+        }
+    }
+}

package/src/sap/suite/ui/commons/themes/base/NetworkGraph.less

@@ -56,6 +56,11 @@
 	margin: auto;
 }
 
+.sapSuiteUiCommonsNetworkGraphInnerScrollerCenter.sapSuiteUiCommonsNetworkGraphInnerScrollerNoMargin {
+	margin: 0;
+	width: 100%;
+}
+
 .sapSuiteUiCommonsNetworkGraphSearchField {
 	max-width: 220px;
 }

package/src/sap/suite/ui/commons/windowmessages/CollaborationMessageBroker.js

@@ -38,7 +38,7 @@ sap.ui.define([
             try {
                 const oMessageBrokerService = await UshellContainer.getServiceAsync("MessageBroker");
                 const sResponseData = JSON.stringify(oResponseData);
-                await oMessageBrokerService.publish(CHANNEL_ID, CLIENT_ID, Date.now().toString(), sMessageName, [sClientId], sResponseData);
+                await oMessageBrokerService.publish(CHANNEL_ID, CLIENT_ID, sMessageName, [sClientId], sResponseData);
                 oLogger.info(`Published successfully to CLIENT_ID: ${sClientId} on CHANNEL_ID: ${CHANNEL_ID} DATA: ${sResponseData}`);
             } catch (error) {
                 oLogger.error(`Failed to publish message: ${error}`);
@@ -85,9 +85,9 @@ sap.ui.define([
         };
 
         UshellContainer.getServiceAsync("MessageBroker").then(function (oMessageBrokerService) {
-            oMessageBrokerService.connect(CLIENT_ID).then(function() {
+            oMessageBrokerService.connect(CLIENT_ID, Function.prototype).then(function() {
                 oLogger.info("Client ID: " + CLIENT_ID + " is connected successfully");
-                oMessageBrokerService.subscribe(CLIENT_ID, aSubscribedChannels, fnMessageCallback, Function.prototype);
+                oMessageBrokerService.subscribe(CLIENT_ID, aSubscribedChannels, fnMessageCallback);
             });
         });
     }

package/src/sap/suite/ui/commons/windowmessages/CollaborationMessageConsumer.js

@@ -70,14 +70,14 @@ sap.ui.define([
             oMessageBrokerService = await UshellContainer.getServiceAsync("MessageBroker");
 
             try {
-                await oMessageBrokerService.connect(sClientId);
+                await oMessageBrokerService.connect(sClientId, Function.prototype);
                 oLogger.info(`Client ID: ${sClientId} is connected successfully`);
             } catch {
                 oLogger.warn("Could not connect to the Message Broker");
                 return null;
             }
 
-            await oMessageBrokerService.subscribe(sClientId, channels, callback, Function.prototype);
+            await oMessageBrokerService.subscribe(sClientId, channels, callback);
             return oMessageBrokerService;
         } catch (error) {
             oLogger.error(`Error during connect or subscribe: ${error}`);
@@ -106,7 +106,7 @@ sap.ui.define([
                 try {
                     oMessageBrokerService = await connectAndSubscribe(CLIENT_ID, SUBSCRIBED_CHANNELS, fnMessageCallback);
                     if (oMessageBrokerService) {
-                        await oMessageBrokerService.publish(CHANNEL_ID, CLIENT_ID, Date.now().toString(), MSG_NAME, TARGET_CLIENT_IDS);
+                        await oMessageBrokerService.publish(CHANNEL_ID, CLIENT_ID, MSG_NAME, TARGET_CLIENT_IDS);
 
                         try {
                             oMessageBrokerService.disconnect(CLIENT_ID);
@@ -123,6 +123,7 @@ sap.ui.define([
                 }
             });
         },
+
         updateTopLevelURLforAppRuntime: async function (sUrl) {
             let oMessageBrokerService;
 
@@ -131,7 +132,7 @@ sap.ui.define([
 
                 if (oMessageBrokerService) {
                     const payload = JSON.stringify({ url: sUrl });
-                    await oMessageBrokerService.publish(CHANNEL_ID, CLIENT_ID, Date.now().toString(), UPDATE_TOP_LEVEL_URL_MSG_NAME, TARGET_CLIENT_IDS, payload);
+                    await oMessageBrokerService.publish(CHANNEL_ID, CLIENT_ID, UPDATE_TOP_LEVEL_URL_MSG_NAME, TARGET_CLIENT_IDS, payload);
 
                     try {
                         oMessageBrokerService.disconnect(CLIENT_ID);