@sapui5/sap.fe.templates 1.142.7 → 1.142.9

package/src/sap/fe/templates/ObjectPage/ObjectPageController.controller.ts

@@ -2,7 +2,7 @@ import type { SemanticObjectMappingType } from "@sap-ux/vocabularies-types/vocab
 import Log from "sap/base/Log";
 import merge from "sap/base/util/merge";
 import type { EnhanceWithUI5 } from "sap/fe/base/ClassSupport";
-import { defineUI5Class,extensible,finalExtension,publicExtension,usingExtension } from "sap/fe/base/ClassSupport";
+import { defineUI5Class, extensible, finalExtension, publicExtension, usingExtension } from "sap/fe/base/ClassSupport";
 import ActionRuntime from "sap/fe/core/ActionRuntime";
 import type { StartupParameters } from "sap/fe/core/AppComponent";
 import type { FEView } from "sap/fe/core/BaseController";
@@ -24,7 +24,7 @@ import UiModelConstants from "sap/fe/core/controllerextensions/editFlow/editFlow
 import NavigationReason from "sap/fe/core/controllerextensions/routing/NavigationReason";
 import type CommandExecution from "sap/fe/core/controls/CommandExecution";
 import { RecommendationDialogDecision } from "sap/fe/core/controls/Recommendations/ConfirmRecommendationDialog";
-import type { HiddenDraft,MicroChartManifestConfiguration } from "sap/fe/core/converters/ManifestSettings";
+import type { HiddenDraft, MicroChartManifestConfiguration } from "sap/fe/core/converters/ManifestSettings";
 import type { InternalModelContext } from "sap/fe/core/helpers/ModelHelper";
 import ModelHelper from "sap/fe/core/helpers/ModelHelper";
 import { getResourceModel } from "sap/fe/core/helpers/ResourceModelHelper";
@@ -54,6 +54,7 @@ import InstanceManager from "sap/m/InstanceManager";
 import MessageBox from "sap/m/MessageBox";
 import type NavContainer from "sap/m/NavContainer";
 import type Popover from "sap/m/Popover";
+import type SearchField from "sap/m/SearchField";
 import type ToolbarSpacer from "sap/m/ToolbarSpacer";
 import Device from "sap/ui/Device";
 import type UI5Event from "sap/ui/base/Event";
@@ -289,12 +290,13 @@ class ObjectPageController extends PageController {
 	}
 
 	/**
-	 * Find the last visible subsection and add the sapUxAPObjectPageSubSectionFitContainer CSS class if it contains only a GridTable or a TreeTable.
+	 * Add the sapUxAPObjectPageSubSectionFitContainer CSS class to every visible subsection that contains only a single GridTable or TreeTable.
+	 * This makes the table fill the full height of its container so that the scrollbar appears on the table itself rather than on the page.
 	 * @param subSections The sub sections to look for
 	 */
 	private checkSectionsForNonResponsiveTable(subSections: ObjectPageSubSection[]): void {
-		const changeClassForTables = (event: Event, lastVisibleSubSection: ObjectPageSubSection): void => {
-			const blocks = [...lastVisibleSubSection.getBlocks(), ...lastVisibleSubSection.getMoreBlocks()];
+		const changeClassForTables = (event: Event, visibleSubSection: ObjectPageSubSection): void => {
+			const blocks = [...visibleSubSection.getBlocks(), ...visibleSubSection.getMoreBlocks()];
 			if (blocks.length === 1) {
 				const table = this.searchTableInBlock(blocks[0] as SubSectionBlock);
 				if (!table) {
@@ -310,17 +312,15 @@ class ObjectPageController extends PageController {
 					tableAPI?.getTableDefinition().control.rowCountMode === "Auto"
 				) {
 					//In case there is only a single table in a subSection we fit that to the whole page so that the scrollbar comes only on table and not on page
-					lastVisibleSubSection.addStyleClass("sapUxAPObjectPageSubSectionFitContainer");
-					lastVisibleSubSection.detachEvent("modelContextChange", changeClassForTables, this);
+					visibleSubSection.addStyleClass("sapUxAPObjectPageSubSectionFitContainer");
+					visibleSubSection.detachEvent("modelContextChange", changeClassForTables, this);
 				}
 			}
 		};
-		for (let subSectionIndex = subSections.length - 1; subSectionIndex >= 0; subSectionIndex--) {
-			if (subSections[subSectionIndex].getVisible()) {
-				const lastVisibleSubSection = subSections[subSectionIndex];
+		for (const subSection of subSections) {
+			if (subSection.getVisible()) {
 				// We need to attach this event in order to manage the Object Page Lazy Loading mechanism
-				lastVisibleSubSection.attachEvent("modelContextChange", lastVisibleSubSection, changeClassForTables, this);
-				break;
+				subSection.attachEvent("modelContextChange", subSection, changeClassForTables, this);
 			}
 		}
 	}
@@ -623,7 +623,7 @@ class ObjectPageController extends PageController {
 				// We set the focus in a timeeout, otherwise the focus sometimes goes to the TabBar
 				const oObjectPage = this._getObjectPageLayoutControl();
 				const oMandatoryField = this._getFirstEmptyMandatoryFieldFromSubSection(aSubSections);
-				let oFieldToFocus;
+				let oFieldToFocus: UI5Element | undefined;
 				if (oMandatoryField) {
 					if (oMandatoryField.isA("sap.fe.macros.MultiValueField")) {
 						oFieldToFocus = (oMandatoryField as unknown as MultiValueFieldBlock).getMultiValueField();
@@ -639,9 +639,22 @@ class ObjectPageController extends PageController {
 					const focusInfo = oFieldToFocus.getFocusInfo() as { targetInfo: object };
 					focusInfo.targetInfo = { silent: true };
 					if (oFieldToFocus.isA("sap.ui.mdc.field.FieldInput")) {
-						oFieldToFocus = oFieldToFocus.getParent();
+						oFieldToFocus = oFieldToFocus.getParent() as UI5Element | undefined;
+					}
+
+					if (
+						oFieldToFocus?.isA<SearchField>("sap.m.SearchField") &&
+						oFieldToFocus.getEnableSuggestions() &&
+						!oFieldToFocus.isBound("enableSuggestions")
+					) {
+						// In case the focus is set on a search field with suggestions, we temporarily disable the suggestions to avoid triggering them on focus
+						// unless this property is bound (to avoid modifying something in a model)
+						oFieldToFocus.setEnableSuggestions(false);
+						oFieldToFocus.focus(focusInfo);
+						oFieldToFocus.setEnableSuggestions(true);
+					} else {
+						oFieldToFocus?.focus(focusInfo);
 					}
-					oFieldToFocus.focus(focusInfo);
 				}
 			}.bind(this),
 			0 //300

package/src/sap/fe/templates/ObjectPage/manifest.json

@@ -4,7 +4,7 @@
 		"id": "sap.fe.templates.ObjectPage",
 		"type": "component",
 		"applicationVersion": {
-			"version": "1.142.7"
+			"version": "1.142.9"
 		},
 		"title": "Object Page",
 		"tags": {

package/src/sap/fe/templates/library.js

@@ -36,7 +36,7 @@ sap.ui.define(["sap/f/library", "sap/fe/core/library", "sap/fe/macros/library",
     controls: [],
     elements: [],
     // eslint-disable-next-line no-template-curly-in-string
-    version: "1.142.7",
+    version: "1.142.9",
     noLibraryCSS: true
     // eslint-disable-next-line @typescript-eslint/no-explicit-any
   });