@sapui5/sap.fe.templates 1.139.0 → 1.141.0

package/src/sap/fe/templates/ObjectPage/ObjectPageController.controller.ts

@@ -52,11 +52,11 @@ import type InputBase from "sap/m/InputBase";
 import InstanceManager from "sap/m/InstanceManager";
 import MessageBox from "sap/m/MessageBox";
 import type NavContainer from "sap/m/NavContainer";
-import type OverflowToolbar from "sap/m/OverflowToolbar";
 import type Popover from "sap/m/Popover";
 import type ToolbarSpacer from "sap/m/ToolbarSpacer";
 import Device from "sap/ui/Device";
 import type UI5Event from "sap/ui/base/Event";
+import type { CommandExecution$ExecuteEvent } from "sap/ui/core/CommandExecution";
 import type Control from "sap/ui/core/Control";
 import UI5Element from "sap/ui/core/Element";
 import type InvisibleText from "sap/ui/core/InvisibleText";
@@ -102,6 +102,7 @@ export type BindingParams = {
 };
 
 const ProgrammingModel = FELibrary.ProgrammingModel;
+
 @defineUI5Class("sap.fe.templates.ObjectPage.ObjectPageController")
 class ObjectPageController extends PageController {
 	oView!: FEView;
@@ -442,14 +443,15 @@ class ObjectPageController extends PageController {
 				// Due to the left alignment of the Draft switch and the collaborative draft avatar controls
 				// there is a ToolbarSpacer in the actions aggregation which we need to exclude here!
 				// Due to the ACC report, we also need not to check for the InvisibleText elements
-				if (
-					action.isA<ShareAPI>("sap.fe.macros.share.ShareAPI") ||
-					action.isA<SummarizationButton>("sap.fe.macros.ai.SummarizationButton") ||
+				if (action.isA<SummarizationButton>("sap.fe.macros.ai.SummarizationButton")) {
+					return action.getContent()?.getVisible() ?? false;
+				} else if (
+					action.isA<ShareAPI>("sap.fe.macros.Share") ||
 					action.isA<EasyFillButton>("sap.fe.macros.ai.EasyFillButton") ||
 					action.isA<CollaborationDraft>("sap.fe.templates.ObjectPage.components.CollaborationDraft")
 				) {
-					// since ShareAPI, summarize and CollaborationDraft does not have a disable property
-					// hence there is no need to check if it is disbaled or not
+					// since Share and CollaborationDraft does not have a disable property
+					// hence there is no need to check if it is disabled or not
 					return action.getVisible();
 				} else if (!action.isA<InvisibleText>("sap.ui.core.InvisibleText") && !action.isA<ToolbarSpacer>("sap.m.ToolbarSpacer")) {
 					return action.getVisible() && (action as Button).getEnabled();
@@ -491,12 +493,13 @@ class ObjectPageController extends PageController {
 	}
 
 	_getFirstEmptyMandatoryFieldFromSubSection(aSubSections: ObjectPageSubSection[]): InputBase | undefined {
-		if (aSubSections) {
-			for (const subSection of aSubSections) {
-				const aBlocks = subSection.getBlocks() as (Form | FormAPI)[];
+		if (aSubSections.length === 0) return undefined;
+		for (const subSection of aSubSections) {
+			const aBlocks = subSection.getBlocks() as (Form | FormAPI)[];
 
-				if (aBlocks) {
-					for (const blockControl of aBlocks) {
+			if (aBlocks) {
+				for (const blockControl of aBlocks) {
+					if (blockControl.getBindingContext?.()) {
 						let aFormContainers;
 
 						if (blockControl.isA<Form>("sap.ui.layout.form.Form")) {
@@ -522,6 +525,7 @@ class ObjectPageController extends PageController {
 				}
 			}
 		}
+
 		return undefined;
 	}
 
@@ -608,7 +612,7 @@ class ObjectPageController extends PageController {
 				if (document.URL === currentURL) {
 					this._routing.navigateBackFromContext(oContext);
 				}
-			}, 100);
+			}, 500);
 		};
 
 		if (this.getAppComponent().getRouterProxy().checkIfBackHasSameContext()) {
@@ -624,13 +628,17 @@ class ObjectPageController extends PageController {
 					Log.warning("Error while setting back navigation", e);
 				});
 		} else {
+			const hiddenDraftEnabled = (this.getAppComponent()?.getEnvironmentCapabilities()?.getCapabilities()?.HiddenDraft as HiddenDraft)
+				?.enabled;
 			draft.processDataLossOrDraftDiscardConfirmation(
 				navBack,
 				Function.prototype,
 				oContext,
 				this,
 				true,
-				draft.NavigationType.BackNavigation
+				draft.NavigationType.BackNavigation,
+				undefined,
+				hiddenDraftEnabled ? true : undefined
 			);
 		}
 	}
@@ -795,7 +803,9 @@ class ObjectPageController extends PageController {
 		if (cards.length > 0) {
 			const cardObject = this.collaborationManager.updateCards(cards);
 			const parentAppId = this.getAppComponent().getId();
-			this.getAppComponent().getCollaborationManagerService().addCardsToCollaborationManager(cardObject, parentAppId);
+			this.getAppComponent()
+				.getCollaborationManagerService()
+				.addCardsToCollaborationManager(cardObject, parentAppId, this.getView().getId());
 			this.getAppComponent().getCollaborationManagerService().shareAvailableCards();
 		}
 	}
@@ -949,12 +959,26 @@ class ObjectPageController extends PageController {
 		return this.byId("fe::ObjectPage") as ObjectPageLayout;
 	}
 
-	_getPageTitleInformation(): { title: string; subtitle: string; intent: string; icon: string; description: string } {
+	async _getPageTitleInformation(): Promise<{ title: string; subtitle: string; intent: string; icon: string; description: string }> {
 		const oObjectPage = this._getObjectPageLayoutControl();
 		const oObjectPageSubtitle = oObjectPage.getCustomData().find(function (oCustomData) {
 			return oCustomData.getKey() === "ObjectPageSubtitle";
 		});
-		const objectPageDescription = oObjectPage.data("ObjectPageDescription");
+		const oObjectPageDescription = oObjectPage.getCustomData().find(function (oCustomData) {
+			return oCustomData.getKey() === "ObjectPageDescription";
+		});
+		const extractPaths = (bindingInfo?: { parts?: { path?: string; model?: string }[] }): string[] =>
+			Array.from(
+				new Set(
+					(bindingInfo?.parts || [])
+						.filter((part) => !part.model)
+						.map((part) => part.path || "")
+						.filter(Boolean)
+				)
+			);
+		const subtitlePaths = extractPaths(oObjectPageSubtitle?.getBindingInfo("value"));
+		const descriptionPaths = extractPaths(oObjectPageDescription?.getBindingInfo("value"));
+		const pathsToResolve = [...subtitlePaths, ...descriptionPaths];
 		const appComponent = this.getAppComponent();
 		const rootViewController = appComponent.getRootViewController();
 		const fnClearCacheTitle = (): void => {
@@ -964,33 +988,20 @@ class ObjectPageController extends PageController {
 			oObjectPageSubtitle.getBinding("value")?.attachChange(fnClearCacheTitle, this);
 			this.clearTitleHierarchyCacheSetUp = true;
 		}
-		return {
-			title: oObjectPage.data("ObjectPageTitle") || "",
-			subtitle: oObjectPageSubtitle && oObjectPageSubtitle.getValue(),
+		const oObjectPageContext = oObjectPage.getBindingContext();
+		const build = (): { title: string; subtitle: string; intent: string; icon: string; description: string } => ({
+			title: oObjectPage.data("ObjectPageTitle") ?? "",
+			subtitle: oObjectPageSubtitle?.getValue() ?? "",
 			intent: "",
 			icon: "",
-			description: objectPageDescription
-		};
-	}
-
-	_executeHeaderShortcut(sId: string): void {
-		const sButtonId = `${this.getView().getId()}--${sId}`,
-			oButton = (this._getObjectPageLayoutControl().getHeaderTitle() as ObjectPageDynamicHeaderTitle)
-				.getActions()
-				.find((oElement) => oElement.getId() === sButtonId);
-		if (oButton) {
-			CommonUtils.fireButtonPress(oButton);
+			description: oObjectPageDescription?.getValue() ?? ""
+		});
+		//if no context or nothing to resolve, direct return
+		if (!oObjectPageContext || pathsToResolve.length === 0) {
+			return Promise.resolve(build());
 		}
-	}
-
-	_executeFooterShortcut(sId: string): void {
-		const sButtonId = `${this.getView().getId()}--${sId}`,
-			oButton = (this._getObjectPageLayoutControl().getFooter() as OverflowToolbar).getContent().find(function (
-				oElement: UI5Element
-			) {
-				return oElement.getMetadata().getName() === "sap.m.Button" && oElement.getId() === sButtonId;
-			});
-		CommonUtils.fireButtonPress(oButton);
+		await Promise.all(pathsToResolve.map(async (p) => (oObjectPageContext as ODataV4Context).requestObject(p).catch(() => undefined)));
+		return build();
 	}
 
 	_executeTabShortCut(oExecution: UI5Event): void {
@@ -1211,6 +1222,9 @@ class ObjectPageController extends PageController {
 					);
 				}
 			});
+			const isSkipBindingToView = skipBindingToView as unknown as CommandExecution$ExecuteEvent;
+			const isStandardSave =
+				isSkipBindingToView && typeof isSkipBindingToView == "object" && isSkipBindingToView.getSource().getCommand() === "Save";
 
 			const bindings = await Promise.all(awaitCreateDocuments);
 			// We need to either reject or resolve a promise here and return it since this save
@@ -1223,7 +1237,8 @@ class ObjectPageController extends PageController {
 					bExecuteSideEffectsOnError: executeSideEffectsOnError,
 					bindings: bindings as unknown as ODataListBinding[],
 					mergePatchDraft: this.mergePatchDraft,
-					skipBindingToView
+					skipBindingToView,
+					isStandardSave
 				});
 			} catch (error: unknown) {
 				// If the saveDocument in editFlow returns errors we need
@@ -1269,7 +1284,8 @@ class ObjectPageController extends PageController {
 			}
 		}
 		const isDocumentModified =
-			!!this.getView().getModel("ui").getProperty(UiModelConstants.DocumentModified) || !context.getProperty("HasActiveEntity");
+			!!this.getView().getModel("ui").getProperty(UiModelConstants.DocumentModified) ||
+			(!this.getStickyEditMode() && context.getProperty("HasActiveEntity") === false);
 		const afterCancel: Function = (promiseResult: ODataV4Context) => {
 			// focus is retained on the last focused element
 			if (lastFocusedControlId !== undefined) {