@sapui5/sap.fe.templates 1.102.0 → 1.103.0

package/src/sap/fe/templates/ObjectPage/ObjectPageController.controller.ts

@@ -1,4 +1,4 @@
-import ResourceBundle from "sap/base/i18n/ResourceBundle";
+import type ResourceBundle from "sap/base/i18n/ResourceBundle";
 import Log from "sap/base/Log";
 import merge from "sap/base/util/merge";
 import CommonUtils from "sap/fe/core/CommonUtils";
@@ -19,41 +19,37 @@ import Placeholder from "sap/fe/core/controllerextensions/Placeholder";
 import Share from "sap/fe/core/controllerextensions/Share";
 import ViewState from "sap/fe/core/controllerextensions/ViewState";
 import { defineUI5Class, extensible, finalExtension, publicExtension, usingExtension } from "sap/fe/core/helpers/ClassSupport";
-import ModelHelper, { InternalModelContext } from "sap/fe/core/helpers/ModelHelper";
+import type { InternalModelContext } from "sap/fe/core/helpers/ModelHelper";
+import ModelHelper from "sap/fe/core/helpers/ModelHelper";
 import PageController from "sap/fe/core/PageController";
 import ChartRuntime from "sap/fe/macros/chart/ChartRuntime";
 import CommonHelper from "sap/fe/macros/CommonHelper";
 import DelegateUtil from "sap/fe/macros/DelegateUtil";
 import TableUtils from "sap/fe/macros/table/Utils";
 import SelectionVariant from "sap/fe/navigation/SelectionVariant";
-import { default as ExtensionAPI, default as ObjectPageExtensionAPI } from "sap/fe/templates/ObjectPage/ExtensionAPI";
-import RootContainerBaseController from "sap/fe/templates/RootContainer/controller/RootContainerBaseController";
+import type { default as ObjectPageExtensionAPI } from "sap/fe/templates/ObjectPage/ExtensionAPI";
+import { default as ExtensionAPI } from "sap/fe/templates/ObjectPage/ExtensionAPI";
+import type RootContainerBaseController from "sap/fe/templates/RootContainer/controller/RootContainerBaseController";
 import EditFlowOverrides from "sap/fe/templates/RootContainer/overrides/EditFlow";
 import TableScroller from "sap/fe/templates/TableScroller";
 import InstanceManager from "sap/m/InstanceManager";
 import Link from "sap/m/Link";
 import MessageBox from "sap/m/MessageBox";
-import Popover from "sap/m/Popover";
-import SelectList from "sap/m/SelectList";
-import Event from "sap/ui/base/Event";
-import Control from "sap/ui/core/Control";
+import type Popover from "sap/m/Popover";
 import Core from "sap/ui/core/Core";
-import Fragment from "sap/ui/core/Fragment";
-import Item from "sap/ui/core/Item";
 import OverrideExecution from "sap/ui/core/mvc/OverrideExecution";
-import XMLPreprocessor from "sap/ui/core/util/XMLPreprocessor";
-import XMLTemplateProcessor from "sap/ui/core/XMLTemplateProcessor";
-import Binding from "sap/ui/model/Binding";
+import type Binding from "sap/ui/model/Binding";
 import JSONModel from "sap/ui/model/json/JSONModel";
-import Context from "sap/ui/model/odata/v4/Context";
+import type Context from "sap/ui/model/odata/v4/Context";
 import ODataListBinding from "sap/ui/model/odata/v4/ODataListBinding";
-import ODataMetaModel from "sap/ui/model/odata/v4/ODataMetaModel";
-import ODataModel from "sap/ui/model/odata/v4/ODataModel";
-import ResourceModel from "sap/ui/model/resource/ResourceModel";
-import ObjectPageDynamicHeaderTitle from "sap/uxap/ObjectPageDynamicHeaderTitle";
-import ObjectPageLayout from "sap/uxap/ObjectPageLayout";
-import ObjectPageSection from "sap/uxap/ObjectPageSection";
-import ObjectPageSubSection from "sap/uxap/ObjectPageSubSection";
+import type ODataMetaModel from "sap/ui/model/odata/v4/ODataMetaModel";
+import type ODataModel from "sap/ui/model/odata/v4/ODataModel";
+import type ResourceModel from "sap/ui/model/resource/ResourceModel";
+import type ObjectPageDynamicHeaderTitle from "sap/uxap/ObjectPageDynamicHeaderTitle";
+import type ObjectPageLayout from "sap/uxap/ObjectPageLayout";
+import type ObjectPageSection from "sap/uxap/ObjectPageSection";
+import type ObjectPageSubSection from "sap/uxap/ObjectPageSubSection";
+import DraftHandler from "./handler/DraftHandler";
 import IntentBasedNavigationOverride from "./overrides/IntentBasedNavigation";
 import InternalRoutingOverride from "./overrides/InternalRouting";
 import MessageHandlerOverride from "./overrides/MessageHandler";
@@ -151,11 +147,15 @@ class ObjectPageController extends PageController {
 	onExit() {
 		if (this.mCustomSectionExtensionAPIs) {
 			for (const sId of Object.keys(this.mCustomSectionExtensionAPIs)) {
-				this.mCustomSectionExtensionAPIs[sId] && this.mCustomSectionExtensionAPIs[sId].destroy();
+				if (this.mCustomSectionExtensionAPIs[sId]) {
+					this.mCustomSectionExtensionAPIs[sId].destroy();
+				}
 			}
 			delete this.mCustomSectionExtensionAPIs;
 		}
-		this.extensionAPI && this.extensionAPI.destroy();
+		if (this.extensionAPI) {
+			this.extensionAPI.destroy();
+		}
 		delete this.extensionAPI;
 
 		const oMessageButton = this.getView().byId("fe::FooterBar::MessageButton"),
@@ -177,7 +177,7 @@ class ObjectPageController extends PageController {
 	onBeforeRendering() {
 		PageController.prototype.onBeforeRendering.apply(this);
 		// In the retrieveTextFromValueList scenario we need to ensure in case of reload/refresh that the meta model in the methode retrieveTextFromValueList of the FieldRuntime is available
-		if (this.oView.oViewData.retrieveTextFromValueList && CommonHelper.getMetaModel() === undefined) {
+		if (this.oView.oViewData?.retrieveTextFromValueList && CommonHelper.getMetaModel() === undefined) {
 			CommonHelper.setMetaModel(this.getAppComponent().getMetaModel());
 		}
 	}
@@ -195,7 +195,7 @@ class ObjectPageController extends PageController {
 	_onBeforeBinding(oContext: any, mParameters: any) {
 		// TODO: we should check how this comes together with the transaction helper, same to the change in the afterBinding
 		const aTables = this._findTables(),
-			oObjectPage = this._getObjectPageLayoutControl() as ObjectPageLayout,
+			oObjectPage = this._getObjectPageLayoutControl(),
 			oInternalModelContext = this.getView().getBindingContext("internal") as InternalModelContext,
 			oInternalModel = this.getView().getModel("internal") as JSONModel,
 			aBatchGroups = oInternalModelContext.getProperty("batchGroups"),
@@ -309,7 +309,13 @@ class ObjectPageController extends PageController {
 			oFirstClickableElement = aActions.find(function (oAction: any) {
 				// Due to the left alignment of the Draft switch and the collaborative draft avatar controls
 				// there is a ToolbarSpacer in the actions aggregation which we need to exclude here!
-				return !oAction.isA("sap.m.ToolbarSpacer") && oAction.getVisible() && oAction.getEnabled();
+				// Due to the ACC report, we also need not to check for the InvisibleText elements
+				return (
+					!oAction.isA("sap.ui.core.InvisibleText") &&
+					!oAction.isA("sap.m.ToolbarSpacer") &&
+					oAction.getVisible() &&
+					oAction.getEnabled()
+				);
 			});
 		}
 		return oFirstClickableElement;
@@ -348,7 +354,7 @@ class ObjectPageController extends PageController {
 												return aFields[0];
 											}
 										} catch (error) {
-											Log.debug("Error when searching for mandaotry empty field: " + error);
+											Log.debug(`Error when searching for mandaotry empty field: ${error}`);
 										}
 									}
 								}
@@ -362,7 +368,7 @@ class ObjectPageController extends PageController {
 	}
 
 	_updateFocusInEditMode(aSubSections: any) {
-		const oObjectPage = this._getObjectPageLayoutControl() as ObjectPageLayout;
+		const oObjectPage = this._getObjectPageLayoutControl();
 
 		const oMandatoryField = this._getFirstEmptyMandatoryFieldFromSubSection(aSubSections);
 		let oFieldToFocus: any;
@@ -405,7 +411,7 @@ class ObjectPageController extends PageController {
 
 	// eslint-disable-next-line @typescript-eslint/no-unused-vars
 	_onAfterBinding(oBindingContext: any, mParameters: any) {
-		const oObjectPage = this._getObjectPageLayoutControl() as ObjectPageLayout;
+		const oObjectPage = this._getObjectPageLayoutControl();
 		const aTables = this._findTables();
 
 		this._sideEffects.clearPropertiesStatus();
@@ -449,7 +455,7 @@ class ObjectPageController extends PageController {
 			// Update 'enabled' property of DataFieldForAction buttons on table toolbar
 			// The same is also performed on Table selectionChange event
 			const oActionOperationAvailableMap = JSON.parse(
-					CommonHelper.parseCustomData(DelegateUtil.getCustomData(oTable, "operationAvailableMap")) as any
+					CommonHelper.parseCustomData(DelegateUtil.getCustomData(oTable, "operationAvailableMap"))
 				),
 				aSelectedContexts = oTable.getSelectedContexts();
 
@@ -519,7 +525,7 @@ class ObjectPageController extends PageController {
 				};
 
 			if (!oBinding) {
-				Log.error("Expected binding missing for table: " + oTable.getId());
+				Log.error(`Expected binding missing for table: ${oTable.getId()}`);
 				return;
 			}
 
@@ -640,9 +646,7 @@ class ObjectPageController extends PageController {
 	/**
 	 * Get the status of edit mode for sticky session.
 	 *
-	 * @returns {boolean} The status of edit mode for sticky session
-	 *
-	 *
+	 * @returns The status of edit mode for sticky session
 	 */
 	getStickyEditMode() {
 		const oBindingContext = this.getView().getBindingContext && (this.getView().getBindingContext() as Context);
@@ -665,18 +669,16 @@ class ObjectPageController extends PageController {
 		const oObjectPageSubtitle = oObjectPage.getCustomData().find(function (oCustomData: any) {
 			return oCustomData.getKey() === "ObjectPageSubtitle";
 		});
-		const oTitleInfo = {
+		return {
 			title: oObjectPage.data("ObjectPageTitle") || "",
 			subtitle: oObjectPageSubtitle && oObjectPageSubtitle.getValue(),
 			intent: "",
 			icon: ""
 		};
-
-		return oTitleInfo;
 	}
 
 	_executeHeaderShortcut(sId: any) {
-		const sButtonId = this.getView().getId() + "--" + sId,
+		const sButtonId = `${this.getView().getId()}--${sId}`,
 			oButton = (this._getObjectPageLayoutControl().getHeaderTitle() as ObjectPageDynamicHeaderTitle)
 				.getActions()
 				.find(function (oElement: any) {
@@ -686,7 +688,7 @@ class ObjectPageController extends PageController {
 	}
 
 	_executeFooterShortcut(sId: any) {
-		const sButtonId = this.getView().getId() + "--" + sId,
+		const sButtonId = `${this.getView().getId()}--${sId}`,
 			oButton = (this._getObjectPageLayoutControl().getFooter() as any).getContent().find(function (oElement: any) {
 				return oElement.getMetadata().getName() === "sap.m.Button" && oElement.getId() === sButtonId;
 			});
@@ -705,12 +707,11 @@ class ObjectPageController extends PageController {
 				if (iSelectedSectionIndex <= iSectionIndexMax - 1) {
 					newSection = aSections[++iSelectedSectionIndex];
 				}
-			} else {
+			} else if (iSelectedSectionIndex !== 0) {
 				// PreviousTab
-				if (iSelectedSectionIndex !== 0) {
-					newSection = aSections[--iSelectedSectionIndex];
-				}
+				newSection = aSections[--iSelectedSectionIndex];
 			}
+
 			if (newSection) {
 				oObjectPage.setSelectedSection(newSection);
 				newSection.focus();
@@ -797,7 +798,19 @@ class ObjectPageController extends PageController {
 					bExecuteSideEffectsOnError: bExecuteSideEffectsOnError,
 					bindings: aBindings
 				};
-				return this.editFlow.saveDocument(oContext, mParameters).catch(() => this._showMessagePopover);
+				// We need to either reject or resolve a promise here and return it since this save
+				// function is not only called when pressing the save button in the footer, but also
+				// when the user selects create or save in a dataloss popup.
+				// The logic of the dataloss popup needs to detect if the save had errors or not in order
+				// to decide if the subsequent action - like a back navigation - has to be executed or not.
+				return this.editFlow.saveDocument(oContext, mParameters).catch((...args) => {
+					// If the saveDocument in editFlow returns errors we need
+					// to show the message popover here and ensure that the
+					// dataloss logic does not perform the follow up function
+					// like e.g. a back navigation hence we return a promise and reject it
+					this._showMessagePopover(...args);
+					return Promise.reject(...args);
+				});
 			})
 			.finally(function () {
 				if (BusyLocker.isLocked(oModel)) {
@@ -823,72 +836,8 @@ class ObjectPageController extends PageController {
 		return this.editFlow.applyDocument(oContext).catch(() => this._showMessagePopover());
 	}
 
-	_showSwitchDraftAndActivePopover(event: Event) {
-		const view = this.getView(),
-			source = event.getSource(),
-			fragmentName = "sap.fe.templates.ObjectPage.view.fragments.SwitchDraftAndActiveObjectPopOver";
-
-		if (this.switchDraftAndActivePopOver) {
-			this.switchDraftAndActivePopOver.openBy(source, false);
-		} else {
-			const localThisModel = new JSONModel({}),
-				preprocessorSettings = {
-					bindingContexts: {
-						"this": localThisModel.createBindingContext("/")
-					},
-					models: {
-						"this": localThisModel
-					}
-				};
-			const popoverFragment = XMLTemplateProcessor.loadTemplate(fragmentName, "fragment");
-			Promise.resolve(XMLPreprocessor.process(popoverFragment, { name: fragmentName }, preprocessorSettings))
-				.then((fragment) => {
-					return Fragment.load({ definition: fragment, controller: this });
-				})
-				.then((popover: any) => {
-					view.addDependent(popover);
-					popover.setModel(view.getModel("sap.fe.i18n"), "i18n");
-					popover.setPlacement("Bottom");
-					this.switchDraftAndActivePopOver = popover;
-					popover.attachAfterOpen(() => {
-						// While the list entry corresponding to the currently displayed document version is emphasized with a blue
-						// background, we need to pre-focus the other entry
-						const context: any = this.getView().getBindingContext(),
-							isActiveEntity = context.getObject().IsActiveEntity;
-						const switchDraftAndActiveOptionsList: SelectList = (popover.getContent() as unknown as Control[]).find(
-							(element) => element.data("listIdentifier") === "switchDraftAndActivePopoverList"
-						) as SelectList;
-						const listItemToFocus: Item = isActiveEntity
-							? (switchDraftAndActiveOptionsList.getItems().find((element) => element.getKey() === "switchToDraft") as Item)
-							: (switchDraftAndActiveOptionsList.getItems().find((element) => element.getKey() === "switchToActive") as Item);
-						listItemToFocus.focus();
-					});
-					popover.openBy(source);
-					// ensure to remove the reference to the draft popover as it would be destroyed on exit
-					view.attachEventOnce("beforeExit", () => {
-						delete this.switchDraftAndActivePopOver;
-					});
-				})
-				.catch(function (Error) {
-					Log.error("Error while opening the draft switch popup", Error);
-				});
-		}
-	}
-
-	_switchDraftAndActivePopoverListSelect(event: Event) {
-		const context: any = this.getView().getBindingContext(),
-			selectedItemKey = event.getParameter("item").getProperty("key"),
-			isActiveEntity = context.getObject().IsActiveEntity;
-		// It was decided that we should NOT set the entry in the list corresponding to the currently displayed document version to
-		// disabled, hence the user can click entries which to not cause an action (clicking "Draft" when you already display the
-		// draft version of the document)
-		// Hence we check here which entry in the list was clicked and which document version we currently display and only do
-		// the switch between draft / active version if it makes sense.
-		if ((isActiveEntity && selectedItemKey === "switchToDraft") || (!isActiveEntity && selectedItemKey === "switchToActive")) {
-			this.editFlow.toggleDraftActive(context);
-		}
-		((event.getSource() as Control).getParent() as Popover).close();
-	}
+	_showSwitchDraftAndActivePopover = DraftHandler.showSwitchDraftAndActivePopover;
+	_switchDraftAndActivePopoverListSelect = DraftHandler.switchDraftAndActivePopoverListSelect;
 
 	_updateRelatedApps() {
 		const oObjectPage = this._getObjectPageLayoutControl();
@@ -929,15 +878,13 @@ class ObjectPageController extends PageController {
 		) {
 			//In case there is only a single table in a section we fit that to the whole page so that the scrollbar comes only on table and not on page
 			aSubsection.addStyleClass("sapUxAPObjectPageSubSectionFitContainer");
-		} else {
-			if (aSubSectionTables && !aSubsection.hasStyleClass("sapUxAPObjectPageSubSectionFitContainer")) {
-				aSubSectionTables.forEach(function (oTable: { table: any; gridTable: any }) {
-					if (oTable.gridTable) {
-						//Resetting the row count to default value in case we have a combination of forms and tables or multiple tables in a subsection
-						oTable.table.getType().setRowCount(null);
-					}
-				});
-			}
+		} else if (aSubSectionTables && !aSubsection.hasStyleClass("sapUxAPObjectPageSubSectionFitContainer")) {
+			aSubSectionTables.forEach(function (oTable: { table: any; gridTable: any }) {
+				if (oTable.gridTable) {
+					//Resetting the row count to default value in case we have a combination of forms and tables or multiple tables in a subsection
+					oTable.table.getType().setRowCount(null);
+				}
+			});
 		}
 	}
 
@@ -982,9 +929,9 @@ class ObjectPageController extends PageController {
 	/**
 	 * Chart Context is resolved for 1:n microcharts.
 	 *
-	 * @param {sap.ui.model.Context} oChartContext The Context of the MicroChart
-	 * @param {string} sChartPath The collectionPath of the the chart
-	 * @returns {Array} Array of Attributes of the chart Context
+	 * @param oChartContext The Context of the MicroChart
+	 * @param sChartPath The collectionPath of the the chart
+	 * @returns Array of Attributes of the chart Context
 	 */
 	_getChartContextData(oChartContext: any, sChartPath: string) {
 		const oContextData = oChartContext.getObject();
@@ -1005,7 +952,6 @@ class ObjectPageController extends PageController {
 	 * @function
 	 * @name sap.fe.templates.ObjectPage.ObjectPageController.controller#_scrollTablesToRow
 	 * @param {string} sRowPath 'sPath of the table row'
-	 *
 	 */
 
 	_scrollTablesToRow(sRowPath: string) {
@@ -1022,10 +968,10 @@ class ObjectPageController extends PageController {
 	 *
 	 * @function
 	 * @name _mergeMultipleContexts
-	 * @param {object} oPageContext Page context
-	 * @param {object|Array} aLineContext Selected Contexts
-	 * @param {string} sChartPath Collection name of the chart
-	 * @returns {object} Selection Variant Object
+	 * @param oPageContext Page context
+	 * @param aLineContext Selected Contexts
+	 * @param sChartPath Collection name of the chart
+	 * @returns Selection Variant Object
 	 */
 	_mergeMultipleContexts(oPageContext: Context, aLineContext: any[], sChartPath: string) {
 		let aAttributes: any[] = [],
@@ -1044,14 +990,14 @@ class ObjectPageController extends PageController {
 			sPathLine = oContext.getPath();
 			sMetaPathLine = oMetaModel && oMetaModel.getMetaPath(sPathLine).replace(/^\/*/, "");
 
-			aLineContext.map((oSingleContext: any) => {
+			aLineContext.forEach((oSingleContext: any) => {
 				if (sChartPath) {
 					const oChartContextData = this._getChartContextData(oSingleContext, sChartPath);
 					if (oChartContextData) {
-						aAttributes = oChartContextData.map(function (oChartContextData: any) {
+						aAttributes = oChartContextData.map(function (oSubChartContextData: any) {
 							return {
-								contextData: oChartContextData,
-								entitySet: sMetaPathPage + "/" + sChartPath
+								contextData: oSubChartContextData,
+								entitySet: `${sMetaPathPage}/${sChartPath}`
 							};
 						});
 					}
@@ -1099,54 +1045,55 @@ class ObjectPageController extends PageController {
 	 *
 	 * @function
 	 * @param {sap.m.Breadcrumbs} [oSource] parent control
-	 * @description Used when context of the objectpage changes.
+	 * @description Used when context of the object page changes.
 	 *              This event callback is attached to modelContextChange
 	 *              event of the Breadcrumb control to catch context change.
-	 *              Then element binding and hrefs are updated for each Link.
+	 *              Then element binding and hrefs are updated for each link.
 	 *
 	 * @ui5-restricted
 	 * @experimental
 	 */
-	_setBreadcrumbLinks(oSource: any) {
-		const oContext = oSource.getBindingContext();
-		const oAppComponent = this.getAppComponent();
-		if (oContext) {
-			const sNewPath = oContext.getPath(),
-				aPathParts = sNewPath.split("/"),
-				oMetaModel = oAppComponent.getMetaModel();
-			let sPath = "",
-				iSkipParameterized = 0;
-
-			aPathParts.shift();
-			aPathParts.splice(-1, 1);
-			aPathParts.forEach(function (sPathPart: any, i: any) {
-				sPath += "/" + sPathPart;
-				const oRootViewController = oAppComponent.getRootViewController() as RootContainerBaseController;
-				const sParameterPath = oMetaModel.getMetaPath(sPath);
-				const bResultContext = oMetaModel.getObject(sParameterPath + "/@com.sap.vocabularies.Common.v1.ResultContext");
-				if (bResultContext) {
-					// We dont need to create a breadcrumb for Parameter path
-					iSkipParameterized = 1;
-					return;
+	async _setBreadcrumbLinks(oSource: any) {
+		const oContext = oSource.getBindingContext(),
+			oAppComponent = this.getAppComponent(),
+			aPromises: Promise<void>[] = [],
+			aSkipParameterized: any[] = [],
+			sNewPath = oContext && oContext.getPath(),
+			aPathParts = sNewPath && sNewPath.split("/"),
+			oMetaModel = oAppComponent && oAppComponent.getMetaModel();
+		let sPath = "";
+		aPathParts.shift();
+		aPathParts.splice(-1, 1);
+		aPathParts.forEach(function (sPathPart: any) {
+			sPath += `/${sPathPart}`;
+			const oRootViewController = oAppComponent.getRootViewController() as RootContainerBaseController;
+			const sParameterPath = oMetaModel.getMetaPath(sPath);
+			const bResultContext = oMetaModel.getObject(`${sParameterPath}/@com.sap.vocabularies.Common.v1.ResultContext`);
+			if (bResultContext) {
+				// We dont need to create a breadcrumb for Parameter path
+				aSkipParameterized.push(1);
+				return;
+			} else {
+				aSkipParameterized.push(0);
+			}
+			aPromises.push(oRootViewController.getTitleInfoFromPath(sPath));
+		});
+		try {
+			const titleHierarchyInfos: any[] = await Promise.all(aPromises);
+			let idx, hierarchyPosition, oLink;
+			for (const titleHierarchyInfo of titleHierarchyInfos) {
+				hierarchyPosition = titleHierarchyInfos.indexOf(titleHierarchyInfo);
+				idx = hierarchyPosition - aSkipParameterized[hierarchyPosition];
+				oLink = oSource.getLinks()[idx] ? oSource.getLinks()[idx] : new Link();
+				//sCurrentEntity is a fallback value in case of empty title
+				oLink.setText(titleHierarchyInfo.subtitle || titleHierarchyInfo.title);
+				oLink.setHref(titleHierarchyInfo.intent);
+				if (!oSource.getLinks()[idx]) {
+					oSource.addLink(oLink);
 				}
-
-				const pWaitForTitleHiearchyInfo = oRootViewController.getTitleInfoFromPath(sPath);
-
-				pWaitForTitleHiearchyInfo
-					.then(function (oTitleHiearchyInfo: any) {
-						const idx = i - iSkipParameterized,
-							oLink = oSource.getLinks()[idx] ? oSource.getLinks()[idx] : new Link();
-						// sCurrentEntity is a fallback value in case of empty title
-						oLink.setText(oTitleHiearchyInfo.subtitle || oTitleHiearchyInfo.title);
-						oLink.setHref(oTitleHiearchyInfo.intent);
-						if (!oSource.getLinks()[idx]) {
-							oSource.addLink(oLink);
-						}
-					})
-					.catch(function (oError: any) {
-						Log.error("Error while computing the title hierarchy", oError);
-					});
-			});
+			}
+		} catch (error: any) {
+			Log.error("Error while setting the breadcrumb links:" + error);
 		}
 	}
 
@@ -1182,17 +1129,17 @@ class ObjectPageController extends PageController {
 			const sLinkId = id;
 			// process viable links from getLinks for all datapoints having outbound
 			if (aSupportedLinks && aSupportedLinks.length === 1 && aSupportedLinks[0].supported) {
-				oInternalModelContext.setProperty("isHeaderDPLinkVisible/" + sLinkId, true);
+				oInternalModelContext.setProperty(`isHeaderDPLinkVisible/${sLinkId}`, true);
 			}
 		}
 
 		/**
-		 * @param oDataPoints
+		 * @param oSubDataPoints
 		 * @param oPageData
 		 */
-		function fnGetLinks(oDataPoints: any, oPageData: any) {
-			for (const sId in oDataPoints) {
-				const oDataPoint = oDataPoints[sId];
+		function fnGetLinks(oSubDataPoints: any, oPageData: any) {
+			for (const sId in oSubDataPoints) {
+				const oDataPoint = oSubDataPoints[sId];
 				const oParams: any = {};
 				const oLink = oView.byId(sId);
 				if (!oLink) {
@@ -1305,7 +1252,7 @@ class ObjectPageController extends PageController {
 						}
 					})
 					.catch(function (err: any) {
-						Log.error("An error occurs while scrolling to the newly created Item: " + err);
+						Log.error(`An error occurs while scrolling to the newly created Item: ${err}`);
 					});
 			}
 			// fire ModelContextChange on the message button whenever the table context changes
@@ -1317,21 +1264,20 @@ class ObjectPageController extends PageController {
 		 * Invokes an action - bound/unbound and sets the page dirty.
 		 *
 		 * @param oView
-		 * @param {string} sActionName The name of the action to be called
-		 * @param {map} [mParameters] Contains the following attributes:
-		 * @param {sap.ui.model.odata.v4.Context} [mParameters.contexts] Mandatory for a bound action, either one context or an array with contexts for which the action shall be called
-		 * @param {sap.ui.model.odata.v4.ODataModel} [mParameters.model] Mandatory for an unbound action; an instance of an OData V4 model
-		 * @returns {Promise}
+		 * @param sActionName The name of the action to be called
+		 * @param [mParameters] Contains the following attributes:
+		 * @param [mParameters.contexts] Mandatory for a bound action, either one context or an array with contexts for which the action shall be called
+		 * @param [mParameters.model] Mandatory for an unbound action; an instance of an OData V4 model
+		 * @returns The action promise
 		 * @ui5-restricted
 		 * @final
 		 */
 		onCallAction(oView: any, sActionName: string, mParameters: any) {
 			const oController = oView.getController();
-			const that = oController;
 			return oController.editFlow
 				.invokeAction(sActionName, mParameters)
-				.then(that._showMessagePopover.bind(that, undefined))
-				.catch(that._showMessagePopover.bind(that));
+				.then(oController._showMessagePopover.bind(oController, undefined))
+				.catch(oController._showMessagePopover.bind(oController));
 		},
 		onDataPointTitlePressed(oController: any, oSource: any, oManifestOutbound: any, sControlConfig: any, sCollectionPath: any) {
 			oManifestOutbound = typeof oManifestOutbound === "string" ? JSON.parse(oManifestOutbound) : oManifestOutbound;
@@ -1348,7 +1294,7 @@ class ObjectPageController extends PageController {
 			aNavigationData = aNavigationData.map(function (oNavigationData: any) {
 				return {
 					data: oNavigationData,
-					metaPath: sMetaPath + (sCollectionPath ? "/" + sCollectionPath : "")
+					metaPath: sMetaPath + (sCollectionPath ? `/${sCollectionPath}` : "")
 				};
 			});
 			if (oTargetInfo && oTargetInfo.parameters) {
@@ -1368,11 +1314,11 @@ class ObjectPageController extends PageController {
 		/**
 		 * Triggers an outbound navigation when a user chooses the chevron.
 		 *
-		 * @param {object} oController
-		 * @param {string} sOutboundTarget Name of the outbound target (needs to be defined in the manifest)
-		 * @param {sap.ui.model.odata.v4.Context} oContext The context that contains the data for the target app
-		 * @param {string} sCreatePath Create path when the chevron is created.
-		 * @returns {Promise} Promise which is resolved once the navigation is triggered (??? maybe only once finished?)
+		 * @param oController
+		 * @param sOutboundTarget Name of the outbound target (needs to be defined in the manifest)
+		 * @param oContext The context that contains the data for the target app
+		 * @param sCreatePath Create path when the chevron is created.
+		 * @returns Promise which is resolved once the navigation is triggered (??? maybe only once finished?)
 		 * @ui5-restricted
 		 * @final
 		 */