@sapui5/sap.fe.macros 1.93.0 → 1.93.1

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@sapui5/sap.fe.macros",
-	"version": "1.93.0",
+	"version": "1.93.1",
 	"description": "SAPUI5 Library sap.fe.macros",
 	"license": "SEE LICENSE IN LICENSE.txt",
 	"author": "SAP SE (https://www.sap.com)",

package/src/sap/fe/macros/.library

@@ -6,7 +6,7 @@
     <copyright>SAP UI development toolkit for HTML5 (SAPUI5)
         (c) Copyright 2009-2021 SAP SE. All rights reserved
     </copyright>
-    <version>1.93.0</version>
+    <version>1.93.1</version>
 
     <documentation>UI5 library: sap.fe.macros</documentation>
 

package/src/sap/fe/macros/DelegateUtil.js

@@ -196,12 +196,16 @@ sap.ui.define(
 				oModifier = mParameters.oModifier,
 				sOriginalProperty = mParameters.sBindingPath + "/" + sPropertyName,
 				oPropertyContext = oMetaModel.createBindingContext(sOriginalProperty),
-				sValueHelpProperty = FieldHelper.valueHelpProperty(oPropertyContext);
+				sValueHelpProperty = FieldHelper.valueHelpProperty(oPropertyContext),
+				bIsAbsolute = mParameters.sBindingPath && mParameters.sBindingPath.indexOf("/") === 0;
 
 			// unit/currency
 			if (sValueHelpProperty.indexOf("$Path") > -1) {
 				sValueHelpProperty = oMetaModel.getObject(sValueHelpProperty);
 			}
+			if (bIsAbsolute) {
+				sValueHelpProperty = mParameters.sBindingPath + "/" + sValueHelpProperty;
+			}
 			var sGeneratedId = ValueHelpTemplating.generateID(
 				mParameters.flexId,
 				StableIdHelper.generate([oModifier ? oModifier.getId(mParameters.oControl) : mParameters.oControl.getId(), sValueHelpType]),

package/src/sap/fe/macros/FilterBarDelegate.js

@@ -443,7 +443,7 @@ sap.ui.define(
 				oParameters = {
 					sPropertyName: sPropertyPath,
 					sBindingPath: sBindingPath,
-					sValueHelpType: VALUE_HELP_TYPE,
+					sValueHelpType: sIdPrefix + VALUE_HELP_TYPE,
 					oControl: oParentControl,
 					oMetaModel: oMetaModel,
 					oModifier: oModifier,

package/src/sap/fe/macros/field/FieldRuntime.js

@@ -138,7 +138,10 @@ sap.ui.define(
 			 */
 			getFieldStateOnChange: function(oEvent) {
 				var oSourceField = oEvent.getSource(),
-					mFieldState = {};
+					mFieldState = {},
+					_isBindingStateMessages = function(oBinding) {
+						return oBinding && oBinding.getDataState() ? oBinding.getDataState().getInvalidValue() === undefined : true;
+					};
 				if (oSourceField.isA("sap.fe.macros.FieldAPI")) {
 					oSourceField = oSourceField.getContent();
 				}
@@ -151,9 +154,8 @@ sap.ui.define(
 					var bIsValid = oEvent.getParameter("valid") || oEvent.getParameter("isValid");
 					if (bIsValid === undefined) {
 						if (oSourceField.getMaxConditions() === 1) {
-							bIsValid =
-								oSourceField.getConditions()[0] &&
-								oSourceField.getConditions()[0].validated === ConditionValidated.Validated;
+							var oValueBindingInfo = oSourceField.getBindingInfo("value");
+							bIsValid = _isBindingStateMessages(oValueBindingInfo && oValueBindingInfo.binding);
 						}
 						if (oSourceField.getValue() === "" && !oSourceField.getProperty("required")) {
 							bIsValid = true;
@@ -164,10 +166,11 @@ sap.ui.define(
 						validity: !!bIsValid
 					};
 				} else {
-					var oBinding = oSourceField.getBinding("value") || oEvent.getBinding("selected");
+					// oSourceField extends from Input || is a CheckBox
+					var oBinding = oSourceField.getBinding("value") || oSourceField.getBinding("selected");
 					mFieldState = {
 						fieldValue: oBinding && oBinding.getValue(),
-						validity: oBinding && oBinding.getDataState() ? oBinding.getDataState().getMessages().length === 0 : true
+						validity: _isBindingStateMessages(oBinding)
 					};
 				}
 				return {

package/src/sap/fe/macros/field/QuickViewLinkDelegate.js

@@ -457,6 +457,8 @@ sap.ui.define(
 							});
 					// check if all link items in this.aLinkCustomData are also present in aNewLinkCustomData
 					if (
+						aNewLinkCustomData &&
+						that.aLinkCustomData &&
 						that.aLinkCustomData.filter(function(link) {
 							return (
 								aNewLinkCustomData.filter(function(otherLink) {

package/src/sap/fe/macros/internal/field/editStyle/TextArea.fragment.xml

@@ -28,6 +28,7 @@
 		enabled="{this>enabledExpression}"
 		change="FieldRuntime.handleChange($controller, $event)"
 		fieldGroupIds="{parts:[{path:'dataField>Value/$Path'}, {path:'entityType>'}], formatter: 'FIELD.getFieldGroupIds'}"
+		validateFieldGroup=".sideEffects.handleFieldGroupChange($event)"
 		ariaLabelledBy="{this>ariaLabelledBy}"
 	/>
 

package/src/sap/fe/macros/internal/valuehelp/ValueListHelper.js

@@ -284,6 +284,21 @@ sap.ui.define(
 		}
 
 		var ValueListHelper = {
+			initializeCachedValueHelp: function() {
+				// Destroy existing MDC value help objects (BCP 2180373096)
+				aCachedValueHelp.forEach(function(oValueHelp) {
+					if (!oValueHelp.oVHFilterBar.isDestroyed()) {
+						oValueHelp.oVHFilterBar.destroy();
+					}
+					if (!oValueHelp.oVHDialogTable.isDestroyed()) {
+						oValueHelp.oVHDialogTable.destroy();
+					}
+				});
+				// initialize cache
+				aCachedValueHelp = [];
+				aSuggestCachedValueHelp = [];
+			},
+
 			getColumnVisibility: function(oValueList, oVLParameter, oSource) {
 				var bIsDropDownListe = oSource && !!oSource.valueHelpWithFixedValues,
 					sRedundantColumn = _redundantDescription(oValueList, oVLParameter, bIsDropDownListe);

package/src/sap/fe/macros/library.js

@@ -59,7 +59,7 @@ sap.ui.define(
 			interfaces: [],
 			controls: [],
 			elements: [],
-			version: "1.93.0",
+			version: "1.93.1",
 			noLibraryCSS: true
 		});
 

package/src/sap/fe/macros/table/Actions.fragment.xml

@@ -27,7 +27,7 @@
 							press="{= ${action>noWrap} ? ${action>press} : CORE.buildActionWrapper(${action>}, ${this>})}"
 							type="Transparent"
 							visible="{action>visible}"
-							enabled="{= ${action>requiresSelection} ? '{= %{internal>numberOfSelectedContexts} >= 1}' : ${action>enabled} }"
+							enabled="{action>enabled}"
 						/>
 					</mdcat:ActionToolbarAction>
 				</template:then>
@@ -166,7 +166,7 @@
 					ariaHasPopup="Dialog"
 				/>
 			</mdcat:ActionToolbarAction>
-		</template:if>	
+		</template:if>
 	</template:if>
 	<template:if
 		test="{= ${collection>@com.sap.vocabularies.Common.v1.DraftRoot} || ${targetCollection>@com.sap.vocabularies.Common.v1.DraftNode} || ${collection>@@CORE.isStickySessionSupported} || TABLE.getIBNData(${this>}) || (COMMON.isDraftParentEntityForContainment(${targetCollection>$ContainsTarget}, ${this>}) ? ${this>showCreate} : 'false')}"

package/src/sap/fe/macros/table/delegates/TableDelegate.js

@@ -396,7 +396,9 @@ sap.ui.define(
 						TableHelper.handleTableDeleteEnablementForSideEffects(oTable, oInternalModelContext);
 						// Refresh the selected contexts to trigger re-calculation of enabled state of actions.
 						oInternalModelContext.setProperty("selectedContexts", []);
-						oInternalModelContext.setProperty("selectedContexts", oTable.getSelectedContexts());
+						var aSelectedContexts = oTable.getSelectedContexts();
+						oInternalModelContext.setProperty("selectedContexts", aSelectedContexts);
+						oInternalModelContext.setProperty("numberOfSelectedContexts", aSelectedContexts.length);
 					});
 					oInternalModelContext.setProperty("dataReceivedAttached", true);
 				}